FWD » Core Development » Base Language

09/11/2013

07:51 PM Feature #2074: add CAN-QUERY() and CAN-SET() support

Need another clarification. Consider the following rule:... Eugenie Lyzenko

06:15 PM Feature #2074: add CAN-QUERY() and CAN-SET() support

Yes, except the javadoc should read like this:... Greg Shah

06:13 PM Feature #2074: add CAN-QUERY() and CAN-SET() support

And the annotation for method should be:... Eugenie Lyzenko

06:08 PM Feature #2074: add CAN-QUERY() and CAN-SET() support

> 1. I would leave resource() field untouched. This will contain additional info we probably will able to use to sepa... Greg Shah

06:00 PM Feature #2074: add CAN-QUERY() and CAN-SET() support

And one more question:
For example consider the following attribute:... Eugenie Lyzenko

02:30 PM Feature #2074: add CAN-QUERY() and CAN-SET() support

Some additional thoughts about annotation:
1. I would leave resource() field untouched. This will contain addition... Eugenie Lyzenko

12:02 PM Feature #2074: add CAN-QUERY() and CAN-SET() support

Greg Shah wrote:
> Constantin: are you suggesting putting all the annotations on interface method definitions instea... Constantin Asofiei

11:57 AM Feature #2074: add CAN-QUERY() and CAN-SET() support

Constantin: are you suggesting putting all the annotations on interface method definitions instead of on the implemen... Greg Shah

11:57 AM Feature #2074: add CAN-QUERY() and CAN-SET() support

Thoughts:
1. The code @Method[] methods = h.get().getClass().getMethods();@ is not safe to chain this way. h.get(... Greg Shah

11:31 AM Feature #2074: add CAN-QUERY() and CAN-SET() support

While I'm modifying the attribute related classes you can review canQuery/canSet implementation proposal(HandleOps.ja... Eugenie Lyzenko

11:18 AM Feature #2074: add CAN-QUERY() and CAN-SET() support

> Do you mean that we should remove the "resource" field of LegacyAttribute/LegacyMethod?
Yes, as it will only confu... Constantin Asofiei

11:16 AM Feature #2074: add CAN-QUERY() and CAN-SET() support

OK, so we don't need to add the writable flag to the annotation.
> And I keep forgetting but fortunately I reminde... Greg Shah

11:06 AM Feature #2074: add CAN-QUERY() and CAN-SET() support

How the @LegacyAttribute@ annotation should look:... Constantin Asofiei

10:46 AM Feature #2074: add CAN-QUERY() and CAN-SET() support

Please document the change you propose (show the LegacyAttribute annotation definition and examples of use). Greg Shah

10:44 AM Feature #2074: add CAN-QUERY() and CAN-SET() support

Greg Shah wrote:
> Constantin: If I understand correctly, no changes are needed to the annotations design to support... Constantin Asofiei

10:38 AM Feature #2074: add CAN-QUERY() and CAN-SET() support

Constantin: If I understand correctly, no changes are needed to the annotations design to support these other use cas... Greg Shah

10:36 AM Feature #2074: add CAN-QUERY() and CAN-SET() support

Greg Shah wrote:
> > For each attribute/method we will specify its interface too, beside the associated method name ... Constantin Asofiei

10:31 AM Feature #2074: add CAN-QUERY() and CAN-SET() support

> For each attribute/method we will specify its interface too, beside the associated method name (sometimes the hwrap... Greg Shah

10:21 AM Feature #2074: add CAN-QUERY() and CAN-SET() support

> Constantin: is this design sufficient to support the needs of #2123 and the LIST-QUERY-ATTRS/LIST-SET-ATTRS?
Yes... Constantin Asofiei

10:03 AM Feature #2074: add CAN-QUERY() and CAN-SET() support

Please implement the annotations for all currently supported methods and attributes. This way, it will just be a sta... Greg Shah

09:51 AM Feature #2074: add CAN-QUERY() and CAN-SET() support

OK understood. Do we have the list of attributes we need to implement this way for now? Only "FRAME" and "FILE-TYPE" ... Eugenie Lyzenko

02:10 PM Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

The ProcessDaemon actually already has a reference to StreamDaemon. When we instantiate both in ThinClient, we alrea... Greg Shah

01:47 PM Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

As I understand StreamDaemon and ProcessDaemon are executed on the Client (on the same node). How can I obtain Proces... Vadim Gindin

11:49 AM Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

I don't want to mix Linux PRINTER output device support in with generic process launching. In addition, Windows PRIN... Greg Shah

11:33 AM Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

I didn't find the reason to write a separate stream class such PrinterStream, but I find the other way. We can add ne... Vadim Gindin

09/10/2013

07:20 PM Feature #2074: add CAN-QUERY() and CAN-SET() support

> The question I have is what will be the cost of this solution in term of application performance?
Yes, it is slo... Greg Shah

06:29 PM Feature #2074: add CAN-QUERY() and CAN-SET() support

OK. This is very clean approach and we can implement incrementally only what we currently need. The question I have i... Eugenie Lyzenko

10:09 AM Feature #2074: add CAN-QUERY() and CAN-SET() support

After some additional thought, I have come up with a 3rd option that I think is even better. Consider these annotati... Greg Shah

05:49 AM Feature #2074: add CAN-QUERY() and CAN-SET() support

Suggestion at this time.
Yes the approach #2 above looks preferable. However I see the discussion points here. The... Eugenie Lyzenko

09:48 PM Feature #1640: implement DOM XML support

Constantin Asofiei wrote:
> Evgeny, please provide the list of methods which, like @get-attribute-node@, require a v... Evgeny Kiselev

09/09/2013

03:38 PM Feature #1640: implement DOM XML support

Evgeny, please provide the list of methods which, like @get-attribute-node@, require a valid x-noderef resource and c... Constantin Asofiei

01:45 PM Feature #1640: implement DOM XML support

> I did not remove @XComonImpl.readOnlyError@ because I'm waiting @ErrorManager.displayAndAddError@ method.
I missed... Constantin Asofiei

11:48 PM Feature #1640: implement DOM XML support

issues from note 114:
1) I need @getHandle()@ for code like this @hRoot:handle:subtype@. Is it possible for @someHan... Evgeny Kiselev

03:16 PM Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

> I've made a rule which converts OUTPUT TO PRINTER to this code:
>
>> UnnamedStreams.assingOut(StreamFactory.creat... Greg Shah

02:49 PM Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

I need some help.
1. Rules.
I've made a rule which converts OUTPUT TO PRINTER to this code:
... Vadim Gindin

12:43 PM Feature #1639: implement socket support

> about SSL connections:
For Milestone 7, we don't need SSL support ("-ssl" never appears in any CONNECT() string ... Greg Shah

10:52 AM Feature #2074 (WIP): add CAN-QUERY() and CAN-SET() support

Greg Shah

09/08/2013

04:03 PM Feature #1639: implement socket support

A few issues to discuss/mention:
# about SSL connections:
a. OpenEdge keeps the private keys in a global store. Als... Constantin Asofiei

07:51 AM Feature #1640: implement DOM XML support

Evgeny, I missed something from your tests; your cases are mostly something like this:... Constantin Asofiei

09/06/2013

02:39 PM Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

Your plan is almost exactly right.
> add new method for the StreamFactory called openPrinterStream
Yes.
> im... Greg Shah

01:16 PM Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

I reviewed the input-output rules and the code in classes /goldencode/p2j/util/Stream*.java
I'm going to do the fol... Vadim Gindin

12:35 PM Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

The UI layout manager will do this when the columns won't fit into the width available. It is actually quite a compl... Greg Shah

12:27 PM Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

Here is the resulting file for surprising test. Vadim Gindin

11:45 AM Feature #1631 (WIP): implement support for LANDSCAPE/PORTRAIT in I/O statements

> I expected that the result pdf will content one line. But the actual result really surprised me (see output_to_prin... Greg Shah

11:08 AM Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

I ran all tests on windev01 and made additional test. The common results are:
# LANDSCAPE/PORTRAIT options are not a... Vadim Gindin

07:24 AM Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

Interesting. OK, this means that on Linux the options are silently ignored. Our runtime implementation will have to... Greg Shah

07:16 AM Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

Greg Shah wrote:
> The key questions here are:
>
> # What are the parameters passed to lp by Progress for these d... Vadim Gindin

07:28 AM Feature #1625 (WIP): implement OUTPUT TO PRINTER on Windows

Please see #1631 for details on how the PRINTER option works for Linux/UNIX. When used on Linux, the PRINTER destina... Greg Shah

09/05/2013

04:53 PM Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

> The Progress documentation says that landscape/portrait options should be supported by printer driver, i.e. real be... Greg Shah

03:36 PM Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

The next script is:... Vadim Gindin

10:37 AM Feature #1640: implement DOM XML support

> Greg: there are some common attributes (like INSTANTIATING-PROCEDURE and UNIQUE-ID) for which the implementation ca... Greg Shah

10:20 AM Feature #1640: implement DOM XML support

> Widget Pool is not implemented in @com.goldencode.p2j.xml.XmlFactory.createSaxAttributes()@ because I didn't find a... Constantin Asofiei

10:19 AM Feature #1640: implement DOM XML support

As a side-note, in some files there are lots of whitespace changes. Please change the settings to your editor so that... Constantin Asofiei

10:14 PM Feature #1640: implement DOM XML support

from note 107:
1-11 is done.
from note 109:
1. done
2. done
3. in the update it's implemented incorrect. Because need... Evgeny Kiselev

09/04/2013

04:56 PM Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

> 1. Greg, you wroted in the task 1631: "You will have to test with wider than 132 and narrower than 132 terminals to... Greg Shah

04:53 PM Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

> 4. Attributes paged and page-size. Default page-size is 56. LANDSCAPE, PORTRAIT options do not affect page size - d... Greg Shah

04:32 PM Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

1. While starting progress in terminal width = 60. Message: "Unable to use your terminal. Check your PROTERMCAP file.... Vadim Gindin

09/03/2013

04:41 PM Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

> It creates 3 identical files with textwidth=132 symbols. So in this case our options also do not affect the page wi... Greg Shah

04:25 PM Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

The first test is for default terminal wich is xterm (80x24) on lindev01:... Vadim Gindin

10:48 AM Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

Questions/Answers:
1. Why are you using the STREAM-IO in your tests? Unless it is needed, you generally should el... Greg Shah

12:11 PM Feature #2108 (Closed): event model rationalization

Greg Shah

12:10 PM Feature #2108: event model rationalization

Attached update is committed to bzr revision 10378. Constantin Asofiei

09/02/2013

05:21 PM Feature #2108: event model rationalization

Code Review 0829a
Everything looks good.
1. Please add javadoc to explain the details in note 14 answers 1, 3, ... Greg Shah

10:07 AM Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

I've made a script for testing conditions about width of text in the outut file. Here it is:... Vadim Gindin

08/30/2013

05:57 PM Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

> 1. lindev01. I ran different test. See below.
Please try both test programs on both lindev01 and windev01. In p... Greg Shah

04:31 PM Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

I tried to run simple test with these options on lindev01 and windev01.
1. lindev01. I ran different test. See belo... Vadim Gindin

09:46 AM Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

The work above was all done to support the proper conversion of these options. But the runtime behavior has not yet ... Greg Shah

01:40 PM Feature #2108: event model rationalization

ca_upd20130829a.zip has passed regression testing. Constantin Asofiei

04:31 AM Feature #1640: implement DOM XML support

Evgeny Kiselev wrote:
> in *1* instance is created. In my case I'm understand this state as unknown, but there is so... Constantin Asofiei

08/29/2013

06:32 PM Feature #1640: implement DOM XML support

Constantin Asofiei wrote:
> 3. @XEntityImpl.invalidNodeError@
> - I don't like how the @XEntityImpl.invalidNodeErro... Evgeny Kiselev

09:13 AM Feature #2108: event model rationalization

The attached fix solved some bugs found during regression testing and addresses the issues in the review.
# I coul... Constantin Asofiei

08/28/2013

05:59 PM Feature #2108: event model rationalization

OK, I have completed my code review (to the 0827a level). Overall: it is really good! The code is now also insanely... Greg Shah

04:41 PM Feature #2108: event model rationalization

More questions:
4. In regard to your assumption in note 9:
> From my testing, I think is reasonbly to think a d... Greg Shah

04:33 PM Feature #2108: event model rationalization

I am in the middle of the code review. So far I have finished the ui and net package code. I have these initial que... Greg Shah

08/27/2013

02:43 PM Feature #1640: implement DOM XML support

Constantin Asofiei wrote:
> 7. @XentityImpl.invalidArgumentError@
> - if you need access to the @HandleResource.t... Evgeny Kiselev

04:50 AM Feature #1640: implement DOM XML support

When you post an update, please summarize the changes (as compared to the previous update) and what issues were fixed... Constantin Asofiei

12:12 PM Feature #2108: event model rationalization

The most important change here is related to the fact that when Session-free is used and a external procedure is invo... Constantin Asofiei

08/26/2013

08:20 PM Feature #1640: implement DOM XML support

I have upload last version of code. This code doesn't fix all issues from note 107 by Constantin.
Also in second ar... Evgeny Kiselev

08/23/2013

09:34 AM Feature #1640: implement DOM XML support

Evgeny, this the review for your 0707a.zip update. Please let me know if you see anything wrong with my reasoning.
... Constantin Asofiei

05:29 AM Feature #1640: implement DOM XML support

> 3) I have found strange case:
> @hRoot:GET-PARENT(hWork).@ if @hRoot@ is unknown and @hWork@ is valid and known w... Constantin Asofiei

08/22/2013

06:57 PM Feature #1640: implement DOM XML support

Constantin Asofiei wrote:
> Evgeny, in regards to note 100: have you gotten past this one? Can you post the full tes... Evgeny Kiselev

04:20 PM Feature #1640: implement DOM XML support

Evgeny, in regards to note 100: have you gotten past this one? Can you post the full test program which you used to g... Constantin Asofiei

04:18 PM Feature #1640: implement DOM XML support

Evgeny, in regards to note 79. From the docs of @node-value-to-memptr@:... Constantin Asofiei

09:49 AM Feature #2108: event model rationalization

This update is good for review and includes:
# changes to the net protocol to support async requests; this is needed... Constantin Asofiei

08/19/2013

02:09 PM Feature #2167: add longchar and codepage support

1. character/longchar interchangeability. Note that this is related to integer/int64 and date/datetime/datetime-tz, w... Ovidiu Maxiniuc

02:07 PM Feature #2167 (New): add longchar and codepage support

Ovidiu Maxiniuc