FWD » Core Development » Base Language

10/21/2013

09:17 PM Feature #1641: implement SAX XML support

First drop for review:
1) SaxAttributes is close to finish version, there are some not important TODOs
2) SaxEntity... Evgeny Kiselev

10/20/2013

05:04 PM Bug #2183 (WIP): fix resource save/restoration when used with string/handle functions

Hynek Cihlar

02:06 PM Feature #2013: implement the SELF system handle

> Perhaps just the NullWidget stuff is open?
Yes, only the NullWidget usage remains to be removed. Constantin Asofiei

01:47 PM Feature #2013: implement the SELF system handle

What is left to do on this task? I think your recent work with async events/sockets probably filled most of the gaps... Greg Shah

01:40 PM Feature #2041: implement runtime support for "shared" attributes that are just stubbed

The BUFFER-FIELD implementation of COLUMN-LABEL, DATA-TYPE, FORMAT and LABEL will be handled in other tasks that are ... Greg Shah

12:09 PM Feature #1781 (Closed): add missing support for the WIDGET-HANDLE builtin function

Greg Shah

10/18/2013

05:39 PM Feature #1781: add missing support for the WIDGET-HANDLE builtin function

Committed to p2j_repo as revision 10401. Hynek Cihlar

12:56 PM Feature #1781: add missing support for the WIDGET-HANDLE builtin function

Check it in and distribute it. Greg Shah

12:46 PM Feature #1781: add missing support for the WIDGET-HANDLE builtin function

Regression tests passed. Hynek Cihlar

02:01 PM Feature #1634: implement full native library (.so or DLL) support

Loading/Unloading
# No loading of a library occurs until a RUN statement is executed which matches a PROCEDURE EXT... Greg Shah

12:24 PM Feature #1634: implement full native library (.so or DLL) support

After a long effort of writing testcases, I have enough results to have sufficient understanding of how the native li... Greg Shah

08:52 AM Feature #1646 (Closed): implement BASE64-ENCODE/BASE64-DECODE built-in functions

Greg Shah

04:44 AM Feature #1641: implement SAX XML support

I think there is a good chance that the progress documentation is wrong; although the code passes, I couldn't find a ... Constantin Asofiei

10/17/2013

07:32 PM Feature #1641: implement SAX XML support

what means in documentation @A CHARACTER or LONGCHAR expression evaluating to the value of the attribute.@ for exampl... Evgeny Kiselev

05:32 PM Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions

I'm sorry, I forgot..
It passed regression testing. Vadim Gindin

02:12 PM Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions

What is the status of regression testing? (I know the answer but you were supposed to post it here so there is docum... Greg Shah

01:32 PM Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions

committed to bzr. Revision 10399. Vadim Gindin

05:04 PM Feature #1781: add missing support for the WIDGET-HANDLE builtin function

Yes, I forgot to mention that the regression test is in progress. Hynek Cihlar

05:02 PM Feature #1781: add missing support for the WIDGET-HANDLE builtin function

It looks good. Please conversion regression test this. Greg Shah

04:52 PM Feature #1781: add missing support for the WIDGET-HANDLE builtin function

Built-in functions ordered alphabetically, see the attached hc_upd20131017a.zip. Hynek Cihlar

02:36 PM Feature #2074: add CAN-QUERY() and CAN-SET() support

Committed to bzr as 10400. Eugenie Lyzenko

02:14 PM Feature #2074: add CAN-QUERY() and CAN-SET() support

Go ahead. Greg Shah

01:54 PM Feature #2074: add CAN-QUERY() and CAN-SET() support

> Runtime testing is enough.
The runtime testing has been passed. The results can be found at 10398_4e69e3d_201310... Eugenie Lyzenko

10/16/2013

11:51 AM Feature #1781: add missing support for the WIDGET-HANDLE builtin function

Sorry, I should have seen this other thing before: all entries in builtin_functions.rules should be in alphabetical o... Greg Shah

11:28 AM Feature #1781 (Review): add missing support for the WIDGET-HANDLE builtin function

Resolved the issues from review.
Attached hc_upd20131016a.zip with p2j changes and hc_upd20131016b.zip with testcas... Hynek Cihlar

10:58 AM Feature #1781: add missing support for the WIDGET-HANDLE builtin function

Code Review 1012a
1. The testcases should not be in the same update zip.
2. There should not be a p2j/ director... Greg Shah

10:37 AM Feature #2074: add CAN-QUERY() and CAN-SET() support

Runtime testing is enough. Greg Shah

10:36 AM Feature #2074: add CAN-QUERY() and CAN-SET() support

> It looks good. Get it tested.
Will the runtime regression be enough or we need conversion testing too? Eugenie Lyzenko

10:14 AM Feature #2074: add CAN-QUERY() and CAN-SET() support

It looks good. Get it tested.
Also, please make sure you add the additional Redmine task to make a more complete ... Greg Shah

09:54 AM Feature #2074: add CAN-QUERY() and CAN-SET() support

1. Moved package private static calls to @date@ class.
2. Modified @DatetimeFormat@ class to reflect the change in 1... Eugenie Lyzenko

09:18 AM Feature #2074: add CAN-QUERY() and CAN-SET() support

>
> > 2. If I understand correctly, I think it is the date version of these which needs to be package private:
Cor... Constantin Asofiei

09:07 AM Feature #2074: add CAN-QUERY() and CAN-SET() support

> 1. LogicalTerminal.getHeightChars(), getWidthChars(),getHeightPixels(), getWidthPixels() have had their annotations... Eugenie Lyzenko

08:20 AM Feature #2074: add CAN-QUERY() and CAN-SET() support

Code Review 1015a
1. LogicalTerminal.getHeightChars(), getWidthChars(),getHeightPixels(), getWidthPixels() have ha... Greg Shah

05:55 AM Feature #2074: add CAN-QUERY() and CAN-SET() support

The minor changes and fix for SessionUtils.java have been uploaded. Eugenie Lyzenko

02:11 AM Feature #2074: add CAN-QUERY() and CAN-SET() support

Eugenie, please do the following changes:
* HandleOps - needs history enry
* LegacyAtribute - change history entry to... Constantin Asofiei

09:44 PM Feature #2074: add CAN-QUERY() and CAN-SET() support

1. and 2. - Done. The new update has been uploaded. In addition to the testcases.
However one question I have face... Eugenie Lyzenko

09:53 PM Feature #2194: Creating testcases to check legacy attributes for resources used in CAN-QUERY/CAN-...

The goal is to provide the 4GL code that is able to check all possible resource/attribute pair for correct result wit... Eugenie Lyzenko

09:48 PM Feature #2194 (New): Creating testcases to check legacy attributes for resources used in CAN-QUER...

Eugenie Lyzenko

10/15/2013

06:56 PM Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions

Code Review 1014b
I am OK with these changes. Get them regression tested.
> May be I just didn't understand yo... Greg Shah

06:24 PM Feature #2074: add CAN-QUERY() and CAN-SET() support

Code Review 1014a
1. Please change "belonged" to "ignore". Of course, the meaning of the boolean is reversed in t... Greg Shah

04:50 PM Feature #2074: add CAN-QUERY() and CAN-SET() support

The new update uploaded for review.
1. Adding separation for static annotations by belonged() member of the Legacy... Eugenie Lyzenko

01:15 PM Feature #2074: add CAN-QUERY() and CAN-SET() support

> If you re-look the HandleOps code for canQuery/canSet wrappers you will find the code that handles this case:
As l... Constantin Asofiei

12:52 PM Feature #2074: add CAN-QUERY() and CAN-SET() support

> BTW, there is another bug in the code: canQuery/canSet must check if the handle is unknown; in this case these meth... Eugenie Lyzenko

02:50 AM Feature #2074: add CAN-QUERY() and CAN-SET() support

It's a little more complicated than this. Some session handles (like LAST-EVENT, SESSION, etc) are implemented via st... Constantin Asofiei

04:37 PM Bug #2183: fix resource save/restoration when used with string/handle functions

The random 64-bit value is acceptable for now. The 4GL apps have so many other security holes that it isn't worth sp... Greg Shah

04:33 PM Bug #2183: fix resource save/restoration when used with string/handle functions

#1781-15
_Also, for security purposes, we should not make the resource ID algorithm a simple sequence. It should be ... Hynek Cihlar

01:01 PM Feature #1781: add missing support for the WIDGET-HANDLE builtin function

Review request.
The attached changes implement all the points except for the improvements in resource ID allocatio... Hynek Cihlar

10/14/2013

04:33 PM Feature #2074: add CAN-QUERY() and CAN-SET() support

One example. Consider the FORMAT attribute for LAST-EVENT resource.
The handle constructed for this resource will ... Eugenie Lyzenko

10:48 AM Feature #2074: add CAN-QUERY() and CAN-SET() support

> May be the current interfaces class tree does not properly reflect the resource dependency? Don't we need to change... Constantin Asofiei

10:34 AM Feature #2074: add CAN-QUERY() and CAN-SET() support

> Looks like there is a case I've overlooked: for CommonLastEvent interface (defining the LAST-EVENT resource in P2J)... Eugenie Lyzenko

04:18 PM Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions

I made a corrections and attached an archive.
About LogicalTerminal and ThinClient I want to say following.
1. ... Vadim Gindin

09:41 AM Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions

Code Review 1014a
1. DynamicOps and TextOps are both missing a history entry.
2. This code in @if(type == null)... Greg Shah

06:44 AM Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions

I've made proposed corrections. It was enough to make my test case working. Here is and archive. Vadim Gindin

10/12/2013

03:38 PM Feature #2074: add CAN-QUERY() and CAN-SET() support

Looks like there is a case I've overlooked: for @CommonLastEvent@ interface (defining the LAST-EVENT resource in P2J)... Constantin Asofiei

10/11/2013

05:10 PM Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions

> For this function the converted code is DynamicOps.length(str) and during execution it goes to TextOps.length(Text... Greg Shah

03:50 PM Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions

Greg Shah wrote:
> Code Review 1010a
> [...]
> 4. In LogicalTerminal, why do this:
>
> [...]
>
> As far as I... Vadim Gindin

12:41 PM Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions

Interesting... I'll try.
Here is the progress procedure I wroted about.... Vadim Gindin

12:34 PM Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions

OK, do implement the support for your current findings.
> There is no error, mentioned in the old comment.
I th... Greg Shah

11:42 AM Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions

There is the old comment in the @SecurityOps.base64Encode@ method: ... Vadim Gindin

10:12 AM Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions

> How to create memptr with negative size?
Search for REAL_LOWER_BOUND in memptr.java. The short story: in Progre... Greg Shah

09:30 AM Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions

How to create memptr with negative size? I tried to call @set-size(..)=-100@ but it didn't work. After this call the ... Vadim Gindin

10/10/2013

04:02 PM Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions

I will make additional testing to answer these questions. Vadim Gindin

02:09 PM Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions

Code Review 1010a
1. Is this todo in base64Encode() still valid?... Greg Shah

01:37 PM Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions

I switched to java7, implemented "skip" operator support for a message statement including message truncating. By the... Vadim Gindin

11:41 AM Feature #2074 (Closed): add CAN-QUERY() and CAN-SET() support

Greg Shah

11:39 AM Feature #2074: add CAN-QUERY() and CAN-SET() support

The testcases update. Committed in bzr as 1035. Eugenie Lyzenko

11:14 AM Feature #2074: add CAN-QUERY() and CAN-SET() support

1010b has been committed as 10398. Eugenie Lyzenko

10:54 AM Feature #2074: add CAN-QUERY() and CAN-SET() support

It looks good. Check it in and distribute it. Greg Shah

10:27 AM Feature #2074: add CAN-QUERY() and CAN-SET() support

> This should be the last change for this task.
The new drop fixes the HANDLE attribute issue. The approach does n... Eugenie Lyzenko

09:30 AM Feature #2074: add CAN-QUERY() and CAN-SET() support

Code Review 1010a
I am OK with the changes.
> OK. I'll work on solution.
This should be the last change for ... Greg Shah

09:11 AM Feature #2074: add CAN-QUERY() and CAN-SET() support

This update includes additional fix for ERROR attribute in temp-table. The TempTable.java class has been modified ins... Eugenie Lyzenko

07:52 AM Feature #2074: add CAN-QUERY() and CAN-SET() support

Code Review 1009d
I am fine with all the changes. Greg Shah

07:46 AM Feature #2074: add CAN-QUERY() and CAN-SET() support

> 2. TEMP-TABLE resource should be Errorable. Otherwise we have no support for ERROR rw attribute.
Yes, please fix... Greg Shah

08:03 PM Feature #2074: add CAN-QUERY() and CAN-SET() support

> 2. TEMP-TABLE resource should be Errorable. Otherwise we have no support for ERROR rw attribute.
This issue can ... Eugenie Lyzenko

10:49 AM Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

I've committed the missed file PrinterStream. New rev is 10397. Vadim Gindin

10:15 AM Feature #1631 (Closed): implement support for LANDSCAPE/PORTRAIT in I/O statements

The update did pass regression testing. Greg Shah

09:54 AM Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

I've checked in the last update (vig_upd20130924b.zip). Revision number is 10396. Vadim Gindin

10:16 AM Feature #2010 (Closed): runtime support for LANDSCAPE/PORTRAIT I/O options

Greg Shah

10/09/2013

02:58 PM Feature #2074: add CAN-QUERY() and CAN-SET() support

The uploaded drop also fixes the issue with missed annotations for SCHEMA-LOCATION and SCHEMA-PATH in x-document reso... Eugenie Lyzenko

12:20 PM Feature #2074: add CAN-QUERY() and CAN-SET() support

The new update for your review. It fixes almost all deviations in getting annotation. The root cause was the getLegac... Eugenie Lyzenko

10:48 AM Feature #2074: add CAN-QUERY() and CAN-SET() support

The update evl_upd20131009b.zip has been committed in bzr as 10395. Eugenie Lyzenko

10:13 AM Feature #2074: add CAN-QUERY() and CAN-SET() support

> 1. Please add javadoc for the name and setter members of LegacyAttribute.java.
>
> 2. Please add javadoc for the... Eugenie Lyzenko

08:44 AM Feature #2074: add CAN-QUERY() and CAN-SET() support

Eugenie, be aware there is a known case to convert badly in P2J: @h = temp-table tt1:handle@ (getting the handle of a... Constantin Asofiei

08:42 AM Feature #2074: add CAN-QUERY() and CAN-SET() support

After you have checked in your changes, you can continue the debugging. Since these changes affect so many files, I ... Greg Shah

08:39 AM Feature #2074: add CAN-QUERY() and CAN-SET() support

Code Review 1009a
1. Please add javadoc for the name and setter members of LegacyAttribute.java.
2. Please add ... Greg Shah

08:27 AM Feature #2074: add CAN-QUERY() and CAN-SET() support

OK, please work your way through the debugging and report your findings here.
> It can be both CAN-SET/CAN-QUERY i... Greg Shah

08:12 AM Feature #2074: add CAN-QUERY() and CAN-SET() support

> There are many deviations. Are these problems with our CAN-SET/CAN-QUERY implementation or is it some other issue?
... Eugenie Lyzenko

10/08/2013

07:19 PM Feature #1641: implement SAX XML support

Greg Shah wrote:
> When do you expect to have a first version for review?
First version for review will be availabl... Evgeny Kiselev

05:37 AM Feature #1641: implement SAX XML support

When do you expect to have a first version for review? Greg Shah

05:52 PM Feature #2074: add CAN-QUERY() and CAN-SET() support

> I don't understand what SetExp of yes and no mean.
SetExp is Setter Expected
yes - means the attribute should... Eugenie Lyzenko

05:30 PM Feature #2074: add CAN-QUERY() and CAN-SET() support

Please do merge and then re-run the tests.
> Also note in INI file some resources has "?" as SetExp value. This m... Greg Shah

04:31 PM Feature #2074: add CAN-QUERY() and CAN-SET() support

The testcases refresh contains change for can_qset_test1.p to be able to run on 4GL Linux/Windows. For some reasons I... Eugenie Lyzenko

05:36 AM Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions

This command can be used to display and change the default JDK:... Greg Shah

10/07/2013

06:08 PM Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions

I got the compile error after update: Category cannot be resolved or is not a field ... Vadim Gindin

03:44 PM Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions

Please make sure your p2j project is updated to the latest version in bzr. In my version of ErrorManager, the method... Greg Shah

03:30 PM Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions

Greg Shah wrote:
..
>
> Have you tried the version as @ErrorManager.recordOrShowError(12119, ERROR_12119, false, ... Vadim Gindin

09:17 AM Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions

> what the method BDT.generateUnknown() needed for?
It is used when you have an instance of a BDT and it can be an... Greg Shah

09:14 AM Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions

Greg Shah wrote:
> Code Review 1003a
..
> 3. As far as I know, @new longchar()@ does already yield an unknown long... Vadim Gindin

08:25 AM Feature #2074: add CAN-QUERY() and CAN-SET() support

> The INI file and captured 4GL log should also be committed in bzr. Correct?
Yes. Greg Shah

05:25 AM Feature #1612: finish SESSION system handle support

Attached testcases for the high-priority attributes/methods. Constantin Asofiei

10/06/2013

04:55 PM Feature #2074: add CAN-QUERY() and CAN-SET() support

>... When it is working in the 4GL, go ahead and check it in to the testcases project.
The INI file and captured 4... Eugenie Lyzenko

03:35 PM Feature #2074: add CAN-QUERY() and CAN-SET() support

Good work. I like the approach. When it is working in the 4GL, go ahead and check it in to the testcases project.
... Greg Shah

03:29 PM Feature #2074: add CAN-QUERY() and CAN-SET() support

The testcases has been added. Consider the test can_qset_test1.p. It takes the data from file, create respective reso... Eugenie Lyzenko

09:52 AM Feature #1612: finish SESSION system handle support

The remaining work for this task is not needed until M12 so it has been re-assigned to that milestone. A sub-task to... Greg Shah

09:50 AM Feature #2004 (Closed): runtime support for SESSION handle

Greg Shah

10/05/2013

09:15 AM Feature #1612: finish SESSION system handle support

1004d.zip was comitted to bzr revision 10394. Constantin Asofiei

10/04/2013

03:53 PM Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions

Code Review 1003a
1. The SecurityOps.ERROR_12119 and SecurityOps.PAD members need javadoc.
2. There should be... Greg Shah

03:44 PM Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions

> Progress docs says that '\' is not escape symbol for Progress. It's only escape symbol for Unix and it's a path sep... Greg Shah

02:08 PM Feature #1612: finish SESSION system handle support

Code Review 1004d
I'm OK with this. Check it in if it passes testing. Greg Shah

11:54 AM Feature #1612: finish SESSION system handle support

> 1. ClientParameters copyright date should be 2013 instead of 2005-2013.
Fixed
>
> 2. The javadoc in ClientParam... Constantin Asofiei

11:28 AM Feature #1612: finish SESSION system handle support

Code Review 1004c
1. ClientParameters copyright date should be 2013 instead of 2005-2013.
2. The javadoc in Cli... Greg Shah

10:14 AM Feature #1612: finish SESSION system handle support

This is built on top of rev 10393 and on top of 1002d. Adds support for these attributes:... Constantin Asofiei

09:59 AM Feature #1612: finish SESSION system handle support

> If the client is running a GUI driver, it should set the most common value (I'm not sure what it is). We can check... Constantin Asofiei

09:28 AM Feature #1612: finish SESSION system handle support

> We should relax this, and allow it to be configured via a "client:driver:window-system" setting.
I'm OK with thi... Greg Shah

09:22 AM Feature #1612: finish SESSION system handle support

Greg Shah wrote:
> > from where does the client initially read the WINDOW-SYSTEM value?
>
> At startup, the clie... Constantin Asofiei

07:40 AM Feature #1612: finish SESSION system handle support

This version was committed to bzr revision 10393. Contains a change related to @unknown()@ API which still needs to b... Constantin Asofiei

10/03/2013

02:37 PM Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions

Here are results of additional testing and the first code for review.
1. Slashes.
Progress docs says that '\' is ... Vadim Gindin

11:51 AM Feature #1612: finish SESSION system handle support

Code Review 1003c
Really good! The only feedback I have is that I would like you to add a Redmine task to describ... Greg Shah

10:47 AM Feature #1612: finish SESSION system handle support

This is for the LegacyResource and ControlTextWidget related changes (is merged with latest rev, 10392); also, it add... Constantin Asofiei

08:54 AM Feature #2074: add CAN-QUERY() and CAN-SET() support

Code Review 1003a
I am fine with the code. Please do add the following text to the javadoc for the HandleOps.getL... Greg Shah

06:48 AM Feature #2074: add CAN-QUERY() and CAN-SET() support

> The new question. We have separate interface for frame widget - CommonFrame. This means the similar methods in this... Constantin Asofiei

06:44 AM Feature #2074: add CAN-QUERY() and CAN-SET() support

The changes look good in 1003a.
About the tests: note that @CREATE VALUE(...)@ can't be used with non-widget reso... Constantin Asofiei

06:31 AM Feature #2074: add CAN-QUERY() and CAN-SET() support

This is the universal testcase from Progress docs(with little modifications and improvement). Possible to check each ... Eugenie Lyzenko

05:48 AM Feature #2074: add CAN-QUERY() and CAN-SET() support

> The changes in HandleOps.getLegacyAttribute() look fine. Remember I was mentioning attributes which are read-only f... Eugenie Lyzenko

03:46 AM Feature #2074: add CAN-QUERY() and CAN-SET() support

The changes in HandleOps.getLegacyAttribute() look fine. Remember I was mentioning attributes which are read-only for... Constantin Asofiei

10/02/2013

07:32 PM Feature #2074: add CAN-QUERY() and CAN-SET() support

The second update includes fix for END-ELEMENT method error, some missed attributes/methods additions and rule file f... Eugenie Lyzenko

06:11 PM Feature #2074: add CAN-QUERY() and CAN-SET() support

Code Review 1002a
Everything looks OK to me except that the SaxWriter.endElement() methods are marked as END-DOCUM... Greg Shah

03:50 PM Feature #2074: add CAN-QUERY() and CAN-SET() support

Greg Shah wrote:
> > Yes, it's a bug, but it's affects only methods_attributes.rule, changes in the code is not need... Evgeny Kiselev

03:44 PM Feature #2074: add CAN-QUERY() and CAN-SET() support

> Yes, it's a bug, but it's affects only methods_attributes.rule, changes in the code is not needed. Do I need to fix... Greg Shah

03:43 PM Feature #2074: add CAN-QUERY() and CAN-SET() support

Eugenie Lyzenko wrote:
> The question about recent rule changes. According to the methods_attributes.rule the attrib... Evgeny Kiselev

01:43 PM Feature #2074: add CAN-QUERY() and CAN-SET() support

This is update for recent code changes and suggested getLegacyAttribute() modification for you to review.
Now I ne... Eugenie Lyzenko

01:21 PM Feature #2074: add CAN-QUERY() and CAN-SET() support

Evgeny Kiselev: Please respond to the question in note 64. Greg Shah

01:20 PM Feature #2074: add CAN-QUERY() and CAN-SET() support

The question about recent rule changes. According to the methods_attributes.rule the attribute PUBLIC-ID is rw and ha... Eugenie Lyzenko

04:25 PM Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions

> How about "For the source string +\/+\/ in Progress procedure the converted class contains +\\/+\\/ string and I'm ... Greg Shah

04:20 PM Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions

Here are some conversion results of other base64 tests.
1. The command @copy-lob from file "/home/vig/testencode" ... Vadim Gindin

03:46 PM Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions

2 remarks:
* How about "For the source string @+\/+\/@ in Progress procedure the converted class contains @+\\/+\\/@... Vadim Gindin

02:47 PM Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions

Interesting! And this is great news!
Please put comments in the code to explain that the Apache commons base64 li... Greg Shah

02:43 PM Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions

I used the old Base64.java class. In company with my check it produces no deviations from Progress behavior on our te... Vadim Gindin

01:36 PM Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions

Before we go too far with the Apache commons base64 support, perhaps it makes sense to try base64 encode/decode that ... Greg Shah

01:25 PM Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions

Here are results of testing new base64Decode method with new check.
Behaviour of Base64.decode() method differs from... Vadim Gindin

04:08 PM Feature #1781: add missing support for the WIDGET-HANDLE builtin function

> (1) I am not sure I completely understand the above,
Sadly, I don't either. I wonder if a "handle value" is jus... Greg Shah

04:02 PM Feature #1781: add missing support for the WIDGET-HANDLE builtin function

Greg Shah wrote:
> > Do we still want the randomized resource IDs?
>
> Yes, I think it still makes sense. We may... Hynek Cihlar

03:42 PM Feature #1781: add missing support for the WIDGET-HANDLE builtin function

I found the following paragraph on the VALID-HANDLE function reference page:
_If a handle is valid, it can still p... Hynek Cihlar

03:38 PM Feature #1781: add missing support for the WIDGET-HANDLE builtin function

> Do we still want the randomized resource IDs?
Yes, I think it still makes sense. We may find some 4GL code that... Greg Shah

03:28 PM Feature #1781: add missing support for the WIDGET-HANDLE builtin function

Greg Shah wrote:
> Also, for security purposes, we should not make the resource ID algorithm a simple sequence. It ... Hynek Cihlar

03:18 PM Feature #1781: add missing support for the WIDGET-HANDLE builtin function

Greg Shah wrote:
> This is a useful set of findings.
>
> Don't forget to test out uninitialized handles and zero ... Hynek Cihlar

10:46 AM Feature #1612: finish SESSION system handle support

> from where does the client initially read the WINDOW-SYSTEM value?
At startup, the client must already know wha... Greg Shah

10:35 AM Feature #1612: finish SESSION system handle support

> 2. Add a redmine task to the UI project to implement the backing support for GET-/SET-WAIT-STATE(). Assign it to m... Constantin Asofiei

10:28 AM Feature #1612: finish SESSION system handle support

Code Review 1002d
1. LT.getClientType() returns "4GLCLIENT" but the javadoc states it would return "CLIENT" instea... Greg Shah

10:15 AM Feature #1612: finish SESSION system handle support

This update adds runtime for the following:... Constantin Asofiei

08:09 AM Feature #1612: finish SESSION system handle support

Looking back at my example, I don't think I showed exactly what I was intending to show.
The key point that I reca... Greg Shah

01:59 AM Feature #1612: finish SESSION system handle support

Attached update adds runtime support for these numeric-format related attributes and methods:... Constantin Asofiei

02:10 AM Bug #2188: fix runtime for SCREEN-VALUE attribute

From #1612 note 27: @SCREEN-VALUE@ attribute doesn't seem to be fixed properly. See the @GenericFrame.getScreenValue@... Constantin Asofiei

02:03 AM Bug #2188 (New): fix runtime for SCREEN-VALUE attribute

Constantin Asofiei

10/01/2013

07:33 PM Feature #1612: finish SESSION system handle support

Code Review 1001b
I am fine with the changes. It pains me to see how I got the initial group/decimal separator us... Greg Shah

01:16 PM Feature #1612: finish SESSION system handle support

This update is only for SESSION's format-related attributes/methods. I'm putting it through regression testing, but I... Constantin Asofiei

11:06 AM Feature #1612: finish SESSION system handle support

I've started working on the format-related stuff: @NUMERIC-SEPARATOR, @NUMERIC-DECIMAL-POINT@, @NUMERIC-FORMAT@, and ... Constantin Asofiei

06:08 PM Feature #2074: add CAN-QUERY() and CAN-SET() support

>But we need to keep in mind that IIRC there are some attributes which are settable for some resources, and not read-... Eugenie Lyzenko

02:41 PM Feature #2074: add CAN-QUERY() and CAN-SET() support

> Your assumption is incorrect. object.getClass().getInterfaces() will always return the directly implemented interfa... Eugenie Lyzenko

02:23 PM Feature #2074: add CAN-QUERY() and CAN-SET() support

> Does not the call @objFromHandle.getClass().getInterfaces()@ retrieve ALL interfaces implementing in the current cl... Constantin Asofiei

02:08 PM Feature #2074: add CAN-QUERY() and CAN-SET() support

> Eugenie: there are some cases when the interface defining the resource is not directly implemented by the P2J class... Eugenie Lyzenko

06:05 PM Feature #1781: add missing support for the WIDGET-HANDLE builtin function

Also, for security purposes, we should not make the resource ID algorithm a simple sequence. It should be randomized... Greg Shah

06:03 PM Feature #1781: add missing support for the WIDGET-HANDLE builtin function

This is a useful set of findings.
Don't forget to test out uninitialized handles and zero handles compared to hand... Greg Shah

05:59 PM Feature #1781: add missing support for the WIDGET-HANDLE builtin function

Ad 2
handle method is already recognized and parsed. Only emitting of handle.toString seems to be missing.
Ad 3
... Hynek Cihlar

03:10 PM Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions

Good work! Make sure that the javadoc for the method has this algorithm included. Greg Shah

02:40 PM Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions

Here is an updated full set of tests for base64-decode function:... Vadim Gindin

02:32 PM Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions

I added more tests and find out several things:
1. Source string can contain any number of pad symbols ('=') at the e... Vadim Gindin

09/30/2013

03:48 PM Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions

Great work! Hopefully you will find the final part of the rule soon. Greg Shah

03:22 PM Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions

I added more tests, as you adviced. Here is a results.... Vadim Gindin

09:13 AM Feature #1640 (Closed): implement DOM XML support

Greg Shah

09:01 AM Feature #1640: implement DOM XML support

Committed to bzr revision 10390 Evgeny Kiselev

03:11 AM Feature #1640: implement DOM XML support

I've taken a look at the 20130926 and 20103929 harness results in your folder and I think we can say that testing has... Constantin Asofiei

09:09 PM Feature #1640: implement DOM XML support

Regression testing for evk_20130923a.zip is finished (20130926_220122):
There are some errors with @timeout errors@ ... Evgeny Kiselev

09:12 AM Feature #1980 (Closed): runtime support for DOM XML processing

Greg Shah

02:55 AM Feature #2074: add CAN-QUERY() and CAN-SET() support

Eugenie: there are some cases when the interface defining the resource is not directly implemented by the P2J class, ... Constantin Asofiei

09/27/2013

05:15 PM Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions

> 1. Am I on the right way or I didn't understood your last comment?
Yes.
> 2. Is the simple rule suits to the ... Greg Shah

04:30 PM Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions

The error is not displayed when NO-ERROR is specified. error-status:error is not set. only error-status:get-number(1)... Vadim Gindin

08:34 AM Feature #1607 (Closed): implement full named events support

Greg Shah

04:09 AM Feature #1607: implement full named events support

ca_upd20130926d.zip was committed to revision 10388. Constantin Asofiei

08:33 AM Feature #1977 (Closed): implement the runtime support for named events

Greg Shah

08:25 AM Feature #1612: finish SESSION system handle support

Good job. This makes sense and it results in a cleaner, more understandable set of frame definitions. Greg Shah

08:00 AM Feature #1612: finish SESSION system handle support

I think I've got it how 4GL interprets string literals in DISPLAY and FORM statements. See this test:... Constantin Asofiei

05:44 AM Feature #1612: finish SESSION system handle support

> Is this just a quirk of Progress? In the DISPLAY case, can you actually use the field for editing? There is no lv... Constantin Asofiei

06:19 AM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types

Conversion test ended with success.
Committed revision 10389 and distributed by mail. Ovidiu Maxiniuc

05:22 AM Feature #2013: implement the SELF system handle

@NullWidget@ usage should be removed and SELF handle (for widgets) tested carefully - see notes 21/22 in #1612. Constantin Asofiei

09/26/2013

04:29 PM Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions

> I did it. It don't change the ERROR-STATUS:ERROR handle. It remains false. However it add the error number 12119. I... Greg Shah

04:04 PM Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions

Greg Shah wrote:
> I assume the error is occurring in the decode function but it is important to confirm that. Just... Vadim Gindin

01:22 PM Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions

I assume the error is occurring in the decode function but it is important to confirm that. Just put a "pause." into... Greg Shah

01:05 PM Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions

Question 2. I converted and ran test 2. Recalling, that it is the same test as 1 but with wrong "base64" string "abra... Vadim Gindin

12:21 PM Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions

The null check is just for safety purposes. It should never get used by converted code that was automatically genera... Greg Shah

12:13 PM Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions

I have a question. Lets see at the method com.goldencode.p2j.util.SecurityOps.base64Encode(BinaryData). There is a nu... Vadim Gindin

10:46 AM Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions

I'm not exactly sure what you mean by this question. But I suggest you try this code to see how multiple message stm... Greg Shah

10:43 AM Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions

Thank you, but will the MESSAGE command override it's previous output? Vadim Gindin

10:41 AM Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions

OK, good. One thing to change: don't use DISPLAY for just printing a line of text. It creates an entire frame which... Greg Shah

10:35 AM Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions

You're right. My mistake.
Here is updated error test.... Vadim Gindin

02:08 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types

Just noticed that Constantin has committed some changes in the same file, in a very close area (consecutive line numb... Ovidiu Maxiniuc

12:42 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types

Good. You can check it in and distribute it. Greg Shah

12:38 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types

The attached update passed the conversion test (no differences detected for both src and ddl). There is no need for r... Ovidiu Maxiniuc

01:37 PM Feature #1612: finish SESSION system handle support

OK, I'm fine with your approach to all of this. Make some notes in #1779 (FOCUS) and also #2015 (SELF), so that we d... Greg Shah

01:25 PM Feature #1612: finish SESSION system handle support

> > But, there are widgets implementations (like ControlTextWidget and BrowseColumnWidget classes) which can represen... Constantin Asofiei

12:18 PM Feature #1612: finish SESSION system handle support

> for widgets, the resource type can't be set at the interface, because they all grow from CommonWidget. In this case... Greg Shah

11:50 AM Feature #1612: finish SESSION system handle support

There are some more issues:
# for widgets, the resource type can't be set at the interface, because they all grow fr... Constantin Asofiei

10:09 AM Feature #1612: finish SESSION system handle support

I like it. Two things:
1.
> system handle implementations (like SessionUtils.getResourceType()) still need to ... Greg Shah

10:02 AM Feature #1612: finish SESSION system handle support

> Can we change the getResourceType() implementation to use the LegacyResource annotation as its source of TYPE info?... Constantin Asofiei

09:50 AM Feature #1612: finish SESSION system handle support

> To solve this, we could have a LegacyResource annotation to annotate the interface associated with the resource def... Greg Shah

09:43 AM Feature #1612: finish SESSION system handle support

I've been looking at the FIRST-QUERY attribute, and I think we need to change something in the FIRST/LAST-resource im... Constantin Asofiei

08:23 AM Feature #1612: finish SESSION system handle support

For now, just implement it in the runtime section of the directory. Use the Directory interface with ID_RELATIVE whi... Greg Shah

06:46 AM Feature #1612: finish SESSION system handle support

Greg, how do you suggest to implement the @PARAMETER@ attribute? The @SESSION:PARAMETER@ attribute holds the value of... Constantin Asofiei

05:46 AM Feature #1612: finish SESSION system handle support

Following attributes will be added first
* client-type
* parameter
* first-buffer Constantin Asofiei

01:31 PM Feature #1607: implement full named events support

The runtime testing seems OK, but I want to do another run, to clean some failures. Constantin Asofiei

09:47 AM Feature #1607: implement full named events support

Attached version contains the comment changes at note 29. Runtime testing is still in progress - conversion testing h... Constantin Asofiei

08:31 AM Feature #1607: implement full named events support

Code Review 0926b
I'm fine with the code. Before checking in, please make these comment changes:
1. This comm... Greg Shah

04:47 AM Feature #1607: implement full named events support

Attached update is going through regression testing now.
Beside other fixes, I've renamed PersistentProc to Proce... Constantin Asofiei

04:48 AM Feature #1977 (Review): implement the runtime support for named events

Constantin Asofiei

04:03 AM Feature #2004 (WIP): runtime support for SESSION handle

Constantin Asofiei

09/25/2013

07:12 PM Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions

> returns empty file
Instead of using copy-lob in these cases, it is cleaner to just check if the length/size of ... Greg Shah

04:53 PM Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions

Greg Shah wrote:
> Also: please add a testcase showing how these functions respond to the following:
>
> # unknow... Vadim Gindin

02:23 PM Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions

> Should I only check and probably test them?
You can check them, but I can guarantee that they don't properly imp... Greg Shah

02:15 PM Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions

Here is additional testing.
6. Empty input.... Vadim Gindin

09:52 AM Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions

To be clear: memptr and raw are BaseDataTypes that can be compared for equality, inequality, less than... Greg Shah

09:51 AM Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions

See BinaryData.compareTo() and CompareOps.equals(BDT, BDT). Greg Shah

09:48 AM Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions

Greg Shah wrote:
> ..
> Create a test like number 1 above, but first do the encode on a text string and then decode... Vadim Gindin

11:48 AM Feature #1607: implement full named events support

> In ProcedureManager, all procedures are saved in the ppMap and deleted, via WorkArea's Scopeable implementation. If... Greg Shah

11:15 AM Feature #1607: implement full named events support

> 1. Why are only persistent procedures checked for subscriptions? The ProcedureManager code uses PersistentProc and... Constantin Asofiei

11:09 AM Feature #1607: implement full named events support

Code Review 0925a
1. Why are only persistent procedures checked for subscriptions? The ProcedureManager code uses... Greg Shah

10:46 AM Feature #1607: implement full named events support

Greg Shah wrote:
> > When the procedure code is executed, the NO-ERROR clause doesn't look like is in effect any mor... Constantin Asofiei

10:44 AM Feature #1607: implement full named events support

> When the procedure code is executed, the NO-ERROR clause doesn't look like is in effect any more, as the ERROR cond... Greg Shah

10:36 AM Feature #1607: implement full named events support

A first version of the runtime for named events. I've also added support for the PUBLISHED-EVENTS attribute for proce... Constantin Asofiei

09:08 AM Feature #1607: implement full named events support

It seems that every new feature, even straightforward ones, will always have some significant divergence from the Pro... Greg Shah

08:19 AM Feature #1607: implement full named events support

The publish/subscribe/unsubscribe rules from the documentation are simple, but practice proves to be more complex.
... Constantin Asofiei

09:25 AM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types

My intention was to identify nodes of this type: @(E)@, ie. an expression formed by another one (@E@) between unneede... Ovidiu Maxiniuc

09:13 AM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types

I'm fine with the change. My only question: what is the purpose of the @nodeRef.numImmediateChildren == 1@ test as p... Greg Shah

08:55 AM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types

Fixed issue by moving 'chp_wrapper' annotation to first operator in if it is enclosed into one or more superfluous pa... Ovidiu Maxiniuc

07:56 AM Feature #1640: implement DOM XML support

I want to clarify something. Phase 2 (build) and 3 (runtime-regression) of your list above are needed. Phase 4 (ful... Greg Shah

01:41 AM Feature #1640: implement DOM XML support

> How long is "normal" time for regression test running ?
Depending on which task you are running, the times are the... Constantin Asofiei

09:33 PM Feature #1640: implement DOM XML support

Constantin Asofiei wrote:
> Next step is to run regression testing; let me know if you encounter any problems.
I'... Evgeny Kiselev

09/24/2013

04:43 PM Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions

> Can't read data from source file and shows error: "Error -26 in file to longchar". Strange error. It looks like a b... Greg Shah

04:08 PM Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions

base64-decode(expr) - where expr - character or longchar. Resulting MEMPTR contains binary data
base64-encode(expr) ... Vadim Gindin

04:37 PM Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

It looks good. Thanks! Greg Shah

04:23 PM Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

Sure, I understand an importance of such rules. I just wanted to make a final step to remember goals of that rules. I... Vadim Gindin

11:08 AM Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

OK, this is fine.
> In addition, please apply the same cleanup items I mentioned in note 67 above to the PrinterSt... Greg Shah

08:58 AM Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

I corrected progress.g and PrinterStream Vadim Gindin

02:36 PM Feature #2041: implement runtime support for "shared" attributes that are just stubbed

Greg Shah wrote:
> It looks like we have a PRIVATE-DATA implementation in both BaseEntity and QueryWrapper that need... Constantin Asofiei

02:06 PM Feature #2041: implement runtime support for "shared" attributes that are just stubbed

It looks like we have a PRIVATE-DATA implementation in both BaseEntity and QueryWrapper that needs to be deleted. Bo... Greg Shah

01:22 PM Feature #2041: implement runtime support for "shared" attributes that are just stubbed

Implemented by some resources:
- local-name: x-noderef (pending to be released), soap-header-entryref
- namespace-u... Constantin Asofiei

11:44 AM Feature #2041: implement runtime support for "shared" attributes that are just stubbed

Constantin: I have looked at #2002 to see the runtime implementation status of these attributes. It is not clear fro... Greg Shah

01:11 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types

Seems like the wrapping annotation is put on the wrong node that is later removed.
I will dig into this tomorrow in ... Ovidiu Maxiniuc

12:50 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types

Ovidiu, name_map.xml was removed before the build. Anyway, I've isolate the problem to calls like:... Constantin Asofiei

12:40 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types

Constantin,
please remove the xml that caches the functions signature.
You probably had an f1 function with int64 ... Ovidiu Maxiniuc

12:32 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types

Greg/Ovidiu,
With revision 10385, there is a case which doesn't convert properly. It looks something like this:
<... Constantin Asofiei

08:19 AM Feature #1977 (WIP): implement the runtime support for named events

Constantin Asofiei

09/23/2013

05:38 PM Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

Oops. I spoke too soon. Your P2J build is not clean:
antlr_progress:
[antlr] ANTLR Parser Generator Versi... Greg Shah

05:13 PM Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

OK, this is ready for testing. Greg Shah

04:38 PM Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

I made described corrections Vadim Gindin

03:37 PM Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

Code Review 0923b
OK. Functionally the code is good. The last issues are about the code formatting/naming...
... Greg Shah

01:26 PM Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

corrected archive Vadim Gindin

12:24 PM Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

Then just do the call to SD.store() from inside PrinterStream.createPrinterStream(). Hiding the printer-specific stu... Greg Shah

12:18 PM Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

Greg Shah wrote:
> Code Review 0923a
>
> 1. There is no PrinterStream class in this update. I think you accident... Vadim Gindin

11:15 AM Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

Code Review 0923a
1. There is no PrinterStream class in this update. I think you accidentally included ProcessStr... Greg Shah

09:22 AM Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements

Next update Vadim Gindin

02:27 AM Feature #1640: implement DOM XML support

Evgeny: the attached version contains just some format related changes, plus I've removed the @XEntity[Impl].getHandl... Constantin Asofiei

11:05 PM Feature #1640: implement DOM XML support

last update for regression testing. merged with 10385 revision Evgeny Kiselev