Project

General

Profile

Activity

From 11/18/2013 to 12/17/2013

12/17/2013

02:03 PM Feature #1645: implement web services support
I have reviewed the above findings. The approach seems reasonable. I'll check the licenses for the AXIS2 dependenci... Greg Shah
12:56 PM Feature #1645: implement web services support
In regard to the CPL 1.0, it is acceptable to use code under that license.
License text:
http://opensource.org/...
Greg Shah

12/16/2013

01:38 PM Feature #2041: implement runtime support for "shared" attributes that are just stubbed
Constantin Asofiei wrote:
> Hynek, changes look good, nice catch with the UNIQUE-ID/ADM-DATA for a procedure resourc...
Hynek Cihlar
04:20 AM Feature #2041: implement runtime support for "shared" attributes that are just stubbed
Hynek, changes look good, nice catch with the UNIQUE-ID/ADM-DATA for a procedure resource (that it should not be save... Constantin Asofiei
07:54 PM Feature #2041: implement runtime support for "shared" attributes that are just stubbed
I am attaching the implementation involving ADM-DATA, UNIQUE-ID, PRIVATE-DATA and COLUMN-LABEL attribute. Regression ... Hynek Cihlar
08:09 AM Feature #1641: implement SAX XML support
Evgeny Kiselev wrote:
> I've try to find something with files (can't believe that they copy all file in memory). May...
Constantin Asofiei
03:25 AM Feature #1641: implement SAX XML support
Review for 1215a.zip:
@SaxReader/SaxWriter@
- add back the @public final static@ modifiers to the sax constants. I ...
Constantin Asofiei
07:47 PM Feature #1641: implement SAX XML support
1) added license
2) rollback constants in SaxReader and SaxWriter file (because this constants specify in literals.r...
Evgeny Kiselev
03:57 AM Feature #2208: create a java application running web services for testing purposes
Some more notes about what should be covered:
# for the various CONNECT statement options, I need more than one WSDL...
Constantin Asofiei
03:28 AM Feature #1645: implement web services support
I don't want to rely on progress or any other freely available services for the testing. Look at the WSDL structure, ... Constantin Asofiei
07:50 PM Feature #1645: implement web services support
This is training server from progress:
http://wstraining.progress.com/index.html
Evgeny Kiselev

12/15/2013

03:25 PM Feature #1645: implement web services support
Following are findings about how 4GL implements the web service requests and what tools we need to address this. The ... Constantin Asofiei

12/12/2013

04:09 PM Feature #1647 (Closed): implement an option for SETUSERID and USERID to be backed by a replacemen...
Greg Shah
04:06 PM Feature #2138 (Closed): finish SEARCH-TARGET support
Greg Shah
03:23 PM Feature #2138: finish SEARCH-TARGET support
Attached update was merged with 10419 (#2196 work), passed regression testing and was committed to bzr revision 10420. Constantin Asofiei
04:06 PM Bug #1971 (Closed): emit worker versions for functions to fix source-procedure handle
Greg Shah
03:22 PM Bug #1971: emit worker versions for functions to fix source-procedure handle
1116d.zip was bundled with #2138 work. Committed to bzr revision 10420. Constantin Asofiei
04:05 PM Bug #1968 (Closed): implement MAP TO actual-name IN handle clause for function definitions
Greg Shah
03:21 PM Bug #1968: implement MAP TO actual-name IN handle clause for function definitions
1116c.zip was bundled with #2138 work. Committed to bzr revision 10420. Constantin Asofiei
06:44 AM Feature #2196 (Closed): implement proper resource deletion of resources created in a procedure ra...
Greg Shah
02:39 AM Feature #2196: implement proper resource deletion of resources created in a procedure ran persistent
1210b.zip was committed to bzr revision 10419. Constantin Asofiei
06:30 AM Feature #1641: implement SAX XML support
The stax-utils license is this:... Greg Shah
01:38 AM Feature #1641: implement SAX XML support
> I've try to find something with files (can't believe that they copy all file in memory). Maybe 4gl copy file in som... Constantin Asofiei
07:37 PM Feature #1641: implement SAX XML support
Constantin Asofiei wrote:
> A note about the update: the module in the header (for the new classes you've added) mus...
Evgeny Kiselev
01:31 AM Feature #2208: create a java application running web services for testing purposes
First, please create some simple SOAP services: exposed over both HTTP and HTTPS, with and without parameters; I need... Constantin Asofiei
07:39 PM Feature #2208 (WIP): create a java application running web services for testing purposes
Evgeny Kiselev

12/11/2013

04:33 PM Feature #1641: implement SAX XML support
Greg Shah wrote:
> What license is used for the stax-utils? Please put the URL to the project here.
https://java.n...
Evgeny Kiselev
08:09 AM Feature #1641: implement SAX XML support
What license is used for the stax-utils? Please put the URL to the project here. Greg Shah
03:37 AM Feature #1641: implement SAX XML support
A note about the update: the module in the header (for the new classes you've added) must be the file name, not the p... Constantin Asofiei
07:18 PM Feature #1641: implement SAX XML support
1) Fixed issues in note 72
2) Added stax-utils.jar (need to Indented output)
3) From note 74 - fixed problem with @...
Evgeny Kiselev
11:28 AM Feature #2041: implement runtime support for "shared" attributes that are just stubbed
> Some additional notes: from the list at note 3, work should be done at this task only for UNIQUE-ID, ADM-DATA, NAME... Greg Shah
11:18 AM Feature #2041: implement runtime support for "shared" attributes that are just stubbed
Constantin Asofiei wrote:
> Greg: the list is a break-down of widget attributes by their associated widgets, but, as...
Hynek Cihlar
10:46 AM Feature #2041: implement runtime support for "shared" attributes that are just stubbed
Greg Shah wrote:
> I don't quite understand what the spreadsheet is saying. For example, the DCOLOR attribute is al...
Hynek Cihlar

12/10/2013

06:46 PM Feature #1641: implement SAX XML support
Constantin Asofiei wrote:
>What happens if you call SET-INPUT-SOURCE after parsing was started?
> > For saxReader...
Evgeny Kiselev
06:56 AM Feature #1641: implement SAX XML support
Evgeny Kiselev wrote:
> > This is strange; lets say you are changing output destination from file @a.xml@ to file @b...
Constantin Asofiei
07:27 PM Feature #1641: implement SAX XML support
Constantin Asofiei wrote:
> I like the part in SAX writer, we are getting close to finish this.
>
> > For example fo...
Evgeny Kiselev
04:55 PM Feature #2208: create a java application running web services for testing purposes
Build a java application running web services covering all features of a SOAP message (soap header, parameter types, ... Constantin Asofiei
04:45 PM Feature #2208 (Closed): create a java application running web services for testing purposes
Constantin Asofiei
04:34 PM Feature #2041: implement runtime support for "shared" attributes that are just stubbed
Agreed. Greg Shah
04:28 PM Feature #2041: implement runtime support for "shared" attributes that are just stubbed
Greg: the list is a break-down of widget attributes by their associated widgets, but, as you note, the "P2J support" ... Constantin Asofiei
03:58 PM Feature #2041: implement runtime support for "shared" attributes that are just stubbed
I don't quite understand what the spreadsheet is saying. For example, the DCOLOR attribute is already supported acro... Greg Shah
02:34 PM Feature #2041: implement runtime support for "shared" attributes that are just stubbed
From this list, only the DATA-TYPE and TABLE attributes are used in appserver reachable code; and, all of them are us... Constantin Asofiei
04:32 PM Feature #2022 (WIP): runtime support for web services
Constantin Asofiei
10:19 AM Feature #2196: implement proper resource deletion of resources created in a procedure ran persistent
1209d/10b:
Persistence changes look OK.
Eric Faulhaber
09:58 AM Feature #2196: implement proper resource deletion of resources created in a procedure ran persistent
Code Review 1210b
I'm OK with the changes. You can check in and distribute when they pass testing.
Greg Shah
09:13 AM Feature #2196: implement proper resource deletion of resources created in a procedure ran persistent
Greg Shah wrote:
> 1. Why do we now call applyChanges() from both Conversation.block() and Queue.transact()?
From m...
Constantin Asofiei
08:47 AM Feature #2138: finish SEARCH-TARGET support
Code Review 1210a
I am fine with the changes. You can check in and distribute when it passes testing.
Greg Shah
08:34 AM Feature #2138: finish SEARCH-TARGET support
I've rewritten the code to make it more clear... the old logic was not that OK, although it did work. Local tests pas... Constantin Asofiei

12/09/2013

06:14 PM Feature #2196: implement proper resource deletion of resources created in a procedure ran persistent
Code Review 1209d
Eric: please review the changes in the persist package.
I am generally fine with the changes....
Greg Shah
09:39 AM Feature #2196: implement proper resource deletion of resources created in a procedure ran persistent
With this version all hand-written tests pass. Needs to be regression tested. Constantin Asofiei
02:45 PM Feature #2138: finish SEARCH-TARGET support
Code Review 1209a
I'm OK with this update except for:
1. In ProcedureManager, there is this code:...
Greg Shah
01:31 PM Feature #2138: finish SEARCH-TARGET support
1209a.zip has passed regression testing (runtime and conversion). Constantin Asofiei
06:53 AM Feature #2138: finish SEARCH-TARGET support
This fixes the support for the SEARCH-SELF and SEARCH-TARGET modes; regression testing is running. The changes for th... Constantin Asofiei
03:54 AM Feature #1641: implement SAX XML support
I like the part in SAX writer, we are getting close to finish this.
> For example for sax-writer it's just reset c...
Constantin Asofiei
09:01 PM Feature #1641: implement SAX XML support
>> - the No input file specified error is shown regardless of input source?
Yes, it's not depends from source.
>> s...
Evgeny Kiselev

12/08/2013

04:52 PM Feature #2041: implement runtime support for "shared" attributes that are just stubbed
Hynek Cihlar wrote:
> Constantin Asofiei wrote:
> > Hynek Cihlar wrote:
> > >GenericWidget columnLabel setter/gett...
Hynek Cihlar

12/05/2013

03:44 PM Feature #2041: implement runtime support for "shared" attributes that are just stubbed
> Stanislav, are you planning to implement them?
There are ADM-DATA and UNIQUE-ID attributes for tables. I'm not pla...
Stanislav Lomany
03:33 PM Feature #2041: implement runtime support for "shared" attributes that are just stubbed
Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > SOAPHeaderEntryImpl is heavily unimplemented. Still implement t...
Hynek Cihlar
03:24 PM Feature #2041: implement runtime support for "shared" attributes that are just stubbed
Evgeny Kiselev wrote:
> Constantin Asofiei wrote:
> > # @XEntityImpl.getName and XEntityImpl.setName@ - this is a q...
Hynek Cihlar

12/02/2013

03:08 AM Feature #2041: implement runtime support for "shared" attributes that are just stubbed
Hynek Cihlar wrote:
> > # in the end, each resource contains its own support for ADM-DATA and UNIQUE-ID (I mean, the...
Constantin Asofiei

12/01/2013

06:41 PM Feature #2041: implement runtime support for "shared" attributes that are just stubbed
Constantin Asofiei wrote:
> # @XEntityImpl.getName and XEntityImpl.setName@ - this is a question for Evgeny: is the @...
Evgeny Kiselev
02:00 PM Feature #2041: implement runtime support for "shared" attributes that are just stubbed
GenericWidget columnLabel setter/getter should call handle.invalidAttribute not just throw an exception (see note-5).... Hynek Cihlar
01:44 PM Feature #2041: implement runtime support for "shared" attributes that are just stubbed
Buffer resource is not mentioned but is also missing implementations for adm-data, unique-id, namespace-uri and buffe... Hynek Cihlar
12:08 PM Feature #2041: implement runtime support for "shared" attributes that are just stubbed
SOAPHeaderEntryImpl is heavily unimplemented. Still implement those local-name and namespace-uri attributes mentioned... Hynek Cihlar
11:27 AM Feature #2041: implement runtime support for "shared" attributes that are just stubbed
Constantin Asofiei wrote:
> Hynek, some notes:
> # SAX resource is WIP by Evgeny (and I expect all attrs/methods to...
Hynek Cihlar

11/30/2013

05:51 PM Feature #2041: implement runtime support for "shared" attributes that are just stubbed
Hynek, some notes:
# SAX resource is WIP by Evgeny (and I expect all attrs/methods to be implemented, including ADM-...
Constantin Asofiei
04:50 PM Feature #2041: implement runtime support for "shared" attributes that are just stubbed
I have summarized the state of all attributes and what needs to be done. Please review the attached Calc sheet.
Al...
Hynek Cihlar
04:45 PM Feature #2041 (WIP): implement runtime support for "shared" attributes that are just stubbed
Hynek Cihlar
10:23 AM Feature #1641: implement SAX XML support
Review for 1129a.zip; I like how you handled the callbacks in @XMLCallbackWrapper@ and how @SaxReaderImpl@ code looks... Constantin Asofiei
08:22 PM Feature #1641: implement SAX XML support
new drop for review:
1) Finishing with callback handler wrapper
2) added DTD and schema validation in SaxReader
3)...
Evgeny Kiselev

11/26/2013

06:42 PM Feature #1641: implement SAX XML support
Greg Shah wrote:
> How much more time do you estimate that you will need to complete this work?
I've finishing with...
Evgeny Kiselev
11:39 AM Feature #1641: implement SAX XML support
How much more time do you estimate that you will need to complete this work? Greg Shah
09:03 AM Feature #1634: implement full native library (.so or DLL) support
Greg Shah wrote:
> I will go ahead and return 'O' instead of 'R' for getParameterModes().
OK. This will allow Cont...
Constantin Asofiei
08:49 AM Feature #1634: implement full native library (.so or DLL) support
I will go ahead and return 'O' instead of 'R' for getParameterModes().
The mode checking for native API calls is d...
Greg Shah
01:25 AM Feature #1634: implement full native library (.so or DLL) support
Greg Shah wrote:
> > BTW, the native invocation code I think looks better in a distinct class; NativeProcedureCaller...
Constantin Asofiei
08:41 AM Bug #2183 (Closed): fix resource save/restoration when used with string/handle functions
Greg Shah
05:32 AM Bug #2183: fix resource save/restoration when used with string/handle functions
The code (hc_upd20131118a.zip) passed regression tests (the run 20131116) and was committed as revision 10416. Hynek Cihlar

11/25/2013

05:14 PM Feature #1634: implement full native library (.so or DLL) support
> BTW, the native invocation code I think looks better in a distinct class; NativeProcedureCaller.invoke should deleg... Greg Shah
09:17 AM Feature #1650: process launching support for Windows (JNI library changes and any associated modi...
The 4GL process launching requires a controlling terminal or pty. For instance, the programs that are launched from ... Greg Shah
09:00 AM Feature #1650: process launching support for Windows (JNI library changes and any associated modi...
> Greg/Eugenie: if the client is ran in a non-TTY mode, the process launching will not work. Is this by intent?
Ye...
Eugenie Lyzenko
03:17 AM Feature #1650: process launching support for Windows (JNI library changes and any associated modi...
Greg/Eugenie: if the client is ran in a non-TTY mode, the process launching will not work. Is this by intent? I think... Constantin Asofiei

11/24/2013

11:50 AM Feature #1634: implement full native library (.so or DLL) support
Greg Shah wrote:
> Question: what does the NativeProcedureCaller.invoke() return value mean/what is it used for? It...
Constantin Asofiei
11:42 AM Feature #1634: implement full native library (.so or DLL) support
Question: what does the NativeProcedureCaller.invoke() return value mean/what is it used for? It is not clear from t... Greg Shah

11/22/2013

04:20 PM Feature #1634: implement full native library (.so or DLL) support
Misc Notes
The 4GL doesn't use native language header files or other definitions. No common OS platforms provide ...
Greg Shah
04:10 PM Feature #1634: implement full native library (.so or DLL) support
As mentioned before, EXTENT parameters are always passed as a pointer. One cannot pass an extent var of indeterminat... Greg Shah
03:59 PM Feature #1634: implement full native library (.so or DLL) support
RETURN Parameter Additional Notes
The definition of a RETURN parameter can be placed as the 1st parameter definiti...
Greg Shah
02:22 PM Feature #1634: implement full native library (.so or DLL) support
Outbound Checking Findings
The use of "outbound" means on the outbound "side" of the API call. In other words these ...
Greg Shah
12:12 PM Feature #2196: implement proper resource deletion of resources created in a procedure ran persistent
Greg Shah wrote:
> We can partially mitigate this (for the body of the message) by only setting the context during t...
Constantin Asofiei
11:06 AM Feature #2196: implement proper resource deletion of resources created in a procedure ran persistent
We can partially mitigate this (for the body of the message) by only setting the context during the state sync proces... Greg Shah
10:25 AM Feature #2196: implement proper resource deletion of resources created in a procedure ran persistent
Greg Shah wrote:
> What are the implications for setting context permanently for the reader/writer threads on DIRECT...
Constantin Asofiei
10:13 AM Feature #2196: implement proper resource deletion of resources created in a procedure ran persistent
OK, then let's get the context set properly instead of reworking all of this code.
What are the implications for s...
Greg Shah
10:11 AM Feature #2196: implement proper resource deletion of resources created in a procedure ran persistent
Yes, I agree with you, but that is not enough. To make all call-paths reachable from the frame deletion code independ... Constantin Asofiei
09:49 AM Feature #2196: implement proper resource deletion of resources created in a procedure ran persistent
My point is that the applyChanges() method is already running in the proper instance because that instance is what is... Greg Shah
09:42 AM Feature #2196: implement proper resource deletion of resources created in a procedure ran persistent
Greg Shah wrote:
> Isn't the @this@ reference in LogicalTerminal.applyChanges() the same as the instance returned by...
Constantin Asofiei
09:41 AM Feature #2196: implement proper resource deletion of resources created in a procedure ran persistent
> this will need the context-local LogicalTerminal instance (obtained via LogicalTerminal.locate()) to destroy the fr... Greg Shah
11:42 PM Feature #2196: implement proper resource deletion of resources created in a procedure ran persistent
> What is there in the visible flag case that requires the context?
The problem is that a frame (for which its insta...
Constantin Asofiei
09:42 AM Feature #1641: implement SAX XML support
If there is no difference in the versions, use the one that is Apache licensed. Greg Shah
06:17 AM Feature #1641: implement SAX XML support
Constantin Asofiei wrote:
> Evgeny Kiselev wrote:
> > Unfortunately we need to add woodstox StAX api. Because JDK S...
Evgeny Kiselev
05:22 AM Feature #1641: implement SAX XML support
Evgeny Kiselev wrote:
> Unfortunately we need to add woodstox StAX api. Because JDK StAX api is not support any vali...
Constantin Asofiei
05:12 AM Feature #1641: implement SAX XML support
Unfortunately we need to add woodstox StAX api. Because JDK StAX api is not support any validation (DTD and schemas).... Evgeny Kiselev

11/21/2013

02:16 PM Bug #1971: emit worker versions for functions to fix source-procedure handle
I am OK with the changes. Greg Shah
01:53 PM Feature #2196: implement proper resource deletion of resources created in a procedure ran persistent
Generally speaking, to increase security, it is a good practice to limit the use of credentials (e.g. security contex... Greg Shah
09:14 AM Feature #2196: implement proper resource deletion of resources created in a procedure ran persistent
LE: the queue may be multiplexed, thus the reason... I think we need to do something similar to how Dispatcher.proces... Constantin Asofiei
09:12 AM Feature #2196: implement proper resource deletion of resources created in a procedure ran persistent
Greg, is there a specific reason the Reader/Writer threads don't have a security context set? I ask this because some... Constantin Asofiei

11/20/2013

11:27 AM Feature #2196: implement proper resource deletion of resources created in a procedure ran persistent
Greg Shah wrote:
> 1. The addition of a BLOCK node as a prior sibling to CS_INSTANCE_VARS in the templates, seems a ...
Constantin Asofiei
09:36 AM Bug #2183: fix resource save/restoration when used with string/handle functions
Hynek Cihlar wrote:
> ... I am attaching the latest changes with the fixed RemoteResource/RemoteResourceImpl/Agent, ...
Constantin Asofiei
09:26 AM Bug #1971: emit worker versions for functions to fix source-procedure handle
See attached. Constantin Asofiei

11/19/2013

04:19 PM Bug #2183: fix resource save/restoration when used with string/handle functions
Yesterday's regression test run ended with suspiciously high number of errors. I've started another control run. Mean... Hynek Cihlar

11/18/2013

06:27 PM Feature #1641: implement SAX XML support
>OK, I understand now. What StAX implementation will you be using?
I'm using standard implementation in JDK.
http:...
Evgeny Kiselev
02:52 AM Feature #1641: implement SAX XML support
Evgeny Kiselev wrote:
> Constantin Asofiei wrote:
> So Idea is parse tag by tag. Java SAX API cannot parse tag by t...
Constantin Asofiei
11:47 AM Bug #1971: emit worker versions for functions to fix source-procedure handle
There was no update attached. Greg Shah
11:26 AM Bug #1968: implement MAP TO actual-name IN handle clause for function definitions
I'm fine with the 1116c changes. There is a minor formatting problem in SourceNameMapper (blank line missing before ... Greg Shah
11:21 AM Feature #1972 (Closed): provide full-support for DYNAMIC-FUNCTION set to function parameters
Greg Shah
10:54 AM Feature #2196: implement proper resource deletion of resources created in a procedure ran persistent
Code Review 1116e
I am OK with the changes. I do have some questions:
1. The addition of a BLOCK node as a pri...
Greg Shah
09:30 AM Bug #2183: fix resource save/restoration when used with string/handle functions
Constantin Asofiei wrote:
> Hynek, the RemoteResource/RemoteResourceImpl/Agent changes are incorrect. The @RemoteRes...
Hynek Cihlar
02:30 AM Bug #2183: fix resource save/restoration when used with string/handle functions
Hynek, the RemoteResource/RemoteResourceImpl/Agent changes are incorrect. The @RemoteResource@ interface is used to s... Constantin Asofiei
03:01 AM Feature #2138 (WIP): finish SEARCH-TARGET support
Constantin Asofiei
 

Also available in: Atom