Activity
From 11/26/2013 to 12/25/2013
12/25/2013
- 07:33 PM Feature #1641: implement SAX XML support
- This update has passed regression.
But I have found that I forgot implementation of @NONAMESPACE-SCHEMA-LOCATION@ ...
12/24/2013
- 07:40 AM Feature #1645: implement web services support
- This version adds validation for the header callback proc/context and fixes the soap faults (though some more testing...
- 06:15 AM Feature #2215: implement the unwrapped mode of passing parameters to web service requests
- OpenEdge's unwrapped mode allows 4GL values and variables as arguments for a web service request; these are automatic...
- 06:01 AM Feature #2215 (New): implement the unwrapped mode of passing parameters to web service requests
12/23/2013
- 08:13 AM Feature #1645: implement web services support
- I've cleaned up and documented the code for the web services implementation. What major features are missing:
* fini... - 03:07 AM Feature #1641: implement SAX XML support
- Evgeny, the logic looks good, I don't have any other comments beside some formatting/javadoc issues and some left-beh...
- 08:07 PM Feature #1641: implement SAX XML support
- Constantin Asofiei wrote:
> Review for 1215a.zip:
> - MemptrInputStream.read - is it possible to save the mptr.leng... - 02:32 AM Feature #2041: implement runtime support for "shared" attributes that are just stubbed
- 1222a.zip looks good, go ahead and get it regression tested.
- 07:08 PM Feature #2041: implement runtime support for "shared" attributes that are just stubbed
- Fixed the issues with the INSTANTIATING-PROCEDURE attribute. Also resolved an incoming conflict on the @BufferImpl.ge...
12/21/2013
- 03:31 AM Bug #2183: fix resource save/restoration when used with string/handle functions
- 1220a.zip passed testing, was committed to bzr rev 10424.
12/20/2013
- 06:38 PM Feature #1645: implement web services support
- 1. Create new redmine tasks for the unwrapped mode and any error/fault processing that is not being implemented. Put...
- 02:36 PM Feature #1645: implement web services support
- The wrapped mode is working nicely, async mode is almost done too (only remaining feature is canceling the requests),...
- 09:21 AM Bug #2183: fix resource save/restoration when used with string/handle functions
- Code Review 1220a
I am fine with the changes. I think that these errors are really things that are generically ra... - 06:27 AM Bug #2183: fix resource save/restoration when used with string/handle functions
- This version raises the "** Value too large for integer. (78)" if the given value can't be stored in a 64 bit integer...
- 06:38 AM Feature #2041: implement runtime support for "shared" attributes that are just stubbed
- PS: the @ProcedureManager.getInstantiatingProcedure(Object referent);@ will perform no validation, will return the ha...
- 06:37 AM Feature #2041: implement runtime support for "shared" attributes that are just stubbed
- Review of 1219a.zip:
# I would prefer to have a @ProcedureManager.setInstantiatingProcedure(Object referent, handle i...
12/19/2013
- 05:41 PM Feature #2041: implement runtime support for "shared" attributes that are just stubbed
- Changes attached, please review. Regression test is pending.
- 02:44 PM Bug #2183: fix resource save/restoration when used with string/handle functions
- AFAIK, the subtract is correct for the 2s complement, but the code is missing check for value greater than max unsign...
- 12:27 PM Bug #2183: fix resource save/restoration when used with string/handle functions
- OK, one more question about the TWO_64 usage. In @ResourceIdHelper.idFromString@, you have this code (btw, shouldn't ...
- 11:59 AM Bug #2183: fix resource save/restoration when used with string/handle functions
- True, I was looking at the other method. Please ignore the comment about throwing an exception when calling @handle.f...
- 10:02 AM Bug #2183: fix resource save/restoration when used with string/handle functions
- Hynek Cihlar wrote:
> Sorry, I didn't express myself clearly. With your change, when "-1" is passed to @handle.fromS... - 09:54 AM Bug #2183: fix resource save/restoration when used with string/handle functions
- Constantin Asofiei wrote:
> > Also when you call @handle.fromString()@ with a negative number, an exception is throw... - 09:01 AM Bug #2183: fix resource save/restoration when used with string/handle functions
- Hynek Cihlar wrote:
> Constantin, I would remove the doc references about treating the long as unsigned number, now ... - 08:54 AM Bug #2183: fix resource save/restoration when used with string/handle functions
- Constantin, I would remove the doc references about treating the long as unsigned number, now we use it as plain sign...
- 08:00 AM Bug #2183: fix resource save/restoration when used with string/handle functions
- Code Review 1219b
I am OK with the changes. If Hynek is OK with them, then go ahead with testing. - 02:40 AM Bug #2183: fix resource save/restoration when used with string/handle functions
- This is 1218a.zip merged with latest rev. 1218a.zip passed, 1219a.zip was committed to bzr revision 10423.
1219b.z...
12/18/2013
- 05:16 PM Bug #2183: fix resource save/restoration when used with string/handle functions
- Constantin Asofiei wrote:
> I should have caught this earlier. Why are negative resource ids ignored in @ResourceIdHe... - 05:04 PM Bug #2183: fix resource save/restoration when used with string/handle functions
- Constantin Asofiei wrote:
> Fixed signatures of static proxy methods. Added logging to @RemoteObject.registerStaticN... - 03:20 PM Bug #2183: fix resource save/restoration when used with string/handle functions
- Code Review 1218a
The changes all look good.
The LT will need merging with the one just checked in by VIG.
I... - 08:20 AM Bug #2183: fix resource save/restoration when used with string/handle functions
- Fixed signatures of static proxy methods. Added logging to @RemoteObject.registerStaticNetworkServer@, to report any ...
- 06:22 AM Bug #2183: fix resource save/restoration when used with string/handle functions
- I should have caught this earlier. Why are negative resource ids ignored in @ResourceIdHelper.idFromString@?...
- 04:50 AM Bug #2183: fix resource save/restoration when used with string/handle functions
- Some socket-related static proxy methods got bad after the 1118a.zip update, as some signatures are out-of-sync. I'm ...
12/17/2013
- 02:03 PM Feature #1645: implement web services support
- I have reviewed the above findings. The approach seems reasonable. I'll check the licenses for the AXIS2 dependenci...
- 12:56 PM Feature #1645: implement web services support
- In regard to the CPL 1.0, it is acceptable to use code under that license.
License text:
http://opensource.org/...
12/16/2013
- 01:38 PM Feature #2041: implement runtime support for "shared" attributes that are just stubbed
- Constantin Asofiei wrote:
> Hynek, changes look good, nice catch with the UNIQUE-ID/ADM-DATA for a procedure resourc... - 04:20 AM Feature #2041: implement runtime support for "shared" attributes that are just stubbed
- Hynek, changes look good, nice catch with the UNIQUE-ID/ADM-DATA for a procedure resource (that it should not be save...
- 07:54 PM Feature #2041: implement runtime support for "shared" attributes that are just stubbed
- I am attaching the implementation involving ADM-DATA, UNIQUE-ID, PRIVATE-DATA and COLUMN-LABEL attribute. Regression ...
- 08:09 AM Feature #1641: implement SAX XML support
- Evgeny Kiselev wrote:
> I've try to find something with files (can't believe that they copy all file in memory). May... - 03:25 AM Feature #1641: implement SAX XML support
- Review for 1215a.zip:
@SaxReader/SaxWriter@
- add back the @public final static@ modifiers to the sax constants. I ... - 07:47 PM Feature #1641: implement SAX XML support
- 1) added license
2) rollback constants in SaxReader and SaxWriter file (because this constants specify in literals.r... - 03:57 AM Feature #2208: create a java application running web services for testing purposes
- Some more notes about what should be covered:
# for the various CONNECT statement options, I need more than one WSDL... - 03:28 AM Feature #1645: implement web services support
- I don't want to rely on progress or any other freely available services for the testing. Look at the WSDL structure, ...
- 07:50 PM Feature #1645: implement web services support
- This is training server from progress:
http://wstraining.progress.com/index.html
12/15/2013
- 03:25 PM Feature #1645: implement web services support
- Following are findings about how 4GL implements the web service requests and what tools we need to address this. The ...
12/12/2013
- 04:09 PM Feature #1647 (Closed): implement an option for SETUSERID and USERID to be backed by a replacemen...
- 04:06 PM Feature #2138 (Closed): finish SEARCH-TARGET support
- 03:23 PM Feature #2138: finish SEARCH-TARGET support
- Attached update was merged with 10419 (#2196 work), passed regression testing and was committed to bzr revision 10420.
- 04:06 PM Bug #1971 (Closed): emit worker versions for functions to fix source-procedure handle
- 03:22 PM Bug #1971: emit worker versions for functions to fix source-procedure handle
- 1116d.zip was bundled with #2138 work. Committed to bzr revision 10420.
- 04:05 PM Bug #1968 (Closed): implement MAP TO actual-name IN handle clause for function definitions
- 03:21 PM Bug #1968: implement MAP TO actual-name IN handle clause for function definitions
- 1116c.zip was bundled with #2138 work. Committed to bzr revision 10420.
- 06:44 AM Feature #2196 (Closed): implement proper resource deletion of resources created in a procedure ra...
- 02:39 AM Feature #2196: implement proper resource deletion of resources created in a procedure ran persistent
- 1210b.zip was committed to bzr revision 10419.
- 06:30 AM Feature #1641: implement SAX XML support
- The stax-utils license is this:...
- 01:38 AM Feature #1641: implement SAX XML support
- > I've try to find something with files (can't believe that they copy all file in memory). Maybe 4gl copy file in som...
- 07:37 PM Feature #1641: implement SAX XML support
- Constantin Asofiei wrote:
> A note about the update: the module in the header (for the new classes you've added) mus... - 01:31 AM Feature #2208: create a java application running web services for testing purposes
- First, please create some simple SOAP services: exposed over both HTTP and HTTPS, with and without parameters; I need...
- 07:39 PM Feature #2208 (WIP): create a java application running web services for testing purposes
12/11/2013
- 04:33 PM Feature #1641: implement SAX XML support
- Greg Shah wrote:
> What license is used for the stax-utils? Please put the URL to the project here.
https://java.n... - 08:09 AM Feature #1641: implement SAX XML support
- What license is used for the stax-utils? Please put the URL to the project here.
- 03:37 AM Feature #1641: implement SAX XML support
- A note about the update: the module in the header (for the new classes you've added) must be the file name, not the p...
- 07:18 PM Feature #1641: implement SAX XML support
- 1) Fixed issues in note 72
2) Added stax-utils.jar (need to Indented output)
3) From note 74 - fixed problem with @... - 11:28 AM Feature #2041: implement runtime support for "shared" attributes that are just stubbed
- > Some additional notes: from the list at note 3, work should be done at this task only for UNIQUE-ID, ADM-DATA, NAME...
- 11:18 AM Feature #2041: implement runtime support for "shared" attributes that are just stubbed
- Constantin Asofiei wrote:
> Greg: the list is a break-down of widget attributes by their associated widgets, but, as... - 10:46 AM Feature #2041: implement runtime support for "shared" attributes that are just stubbed
- Greg Shah wrote:
> I don't quite understand what the spreadsheet is saying. For example, the DCOLOR attribute is al...
12/10/2013
- 06:46 PM Feature #1641: implement SAX XML support
- Constantin Asofiei wrote:
>What happens if you call SET-INPUT-SOURCE after parsing was started?
> > For saxReader... - 06:56 AM Feature #1641: implement SAX XML support
- Evgeny Kiselev wrote:
> > This is strange; lets say you are changing output destination from file @a.xml@ to file @b... - 07:27 PM Feature #1641: implement SAX XML support
- Constantin Asofiei wrote:
> I like the part in SAX writer, we are getting close to finish this.
>
> > For example fo... - 04:55 PM Feature #2208: create a java application running web services for testing purposes
- Build a java application running web services covering all features of a SOAP message (soap header, parameter types, ...
- 04:45 PM Feature #2208 (Closed): create a java application running web services for testing purposes
- 04:34 PM Feature #2041: implement runtime support for "shared" attributes that are just stubbed
- Agreed.
- 04:28 PM Feature #2041: implement runtime support for "shared" attributes that are just stubbed
- Greg: the list is a break-down of widget attributes by their associated widgets, but, as you note, the "P2J support" ...
- 03:58 PM Feature #2041: implement runtime support for "shared" attributes that are just stubbed
- I don't quite understand what the spreadsheet is saying. For example, the DCOLOR attribute is already supported acro...
- 02:34 PM Feature #2041: implement runtime support for "shared" attributes that are just stubbed
- From this list, only the DATA-TYPE and TABLE attributes are used in appserver reachable code; and, all of them are us...
- 04:32 PM Feature #2022 (WIP): runtime support for web services
- 10:19 AM Feature #2196: implement proper resource deletion of resources created in a procedure ran persistent
- 1209d/10b:
Persistence changes look OK. - 09:58 AM Feature #2196: implement proper resource deletion of resources created in a procedure ran persistent
- Code Review 1210b
I'm OK with the changes. You can check in and distribute when they pass testing. - 09:13 AM Feature #2196: implement proper resource deletion of resources created in a procedure ran persistent
- Greg Shah wrote:
> 1. Why do we now call applyChanges() from both Conversation.block() and Queue.transact()?
From m... - 08:47 AM Feature #2138: finish SEARCH-TARGET support
- Code Review 1210a
I am fine with the changes. You can check in and distribute when it passes testing. - 08:34 AM Feature #2138: finish SEARCH-TARGET support
- I've rewritten the code to make it more clear... the old logic was not that OK, although it did work. Local tests pas...
12/09/2013
- 06:14 PM Feature #2196: implement proper resource deletion of resources created in a procedure ran persistent
- Code Review 1209d
Eric: please review the changes in the persist package.
I am generally fine with the changes.... - 09:39 AM Feature #2196: implement proper resource deletion of resources created in a procedure ran persistent
- With this version all hand-written tests pass. Needs to be regression tested.
- 02:45 PM Feature #2138: finish SEARCH-TARGET support
- Code Review 1209a
I'm OK with this update except for:
1. In ProcedureManager, there is this code:... - 01:31 PM Feature #2138: finish SEARCH-TARGET support
- 1209a.zip has passed regression testing (runtime and conversion).
- 06:53 AM Feature #2138: finish SEARCH-TARGET support
- This fixes the support for the SEARCH-SELF and SEARCH-TARGET modes; regression testing is running. The changes for th...
- 03:54 AM Feature #1641: implement SAX XML support
- I like the part in SAX writer, we are getting close to finish this.
> For example for sax-writer it's just reset c... - 09:01 PM Feature #1641: implement SAX XML support
- >> - the No input file specified error is shown regardless of input source?
Yes, it's not depends from source.
>> s...
12/08/2013
- 04:52 PM Feature #2041: implement runtime support for "shared" attributes that are just stubbed
- Hynek Cihlar wrote:
> Constantin Asofiei wrote:
> > Hynek Cihlar wrote:
> > >GenericWidget columnLabel setter/gett...
12/05/2013
- 03:44 PM Feature #2041: implement runtime support for "shared" attributes that are just stubbed
- > Stanislav, are you planning to implement them?
There are ADM-DATA and UNIQUE-ID attributes for tables. I'm not pla... - 03:33 PM Feature #2041: implement runtime support for "shared" attributes that are just stubbed
- Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > SOAPHeaderEntryImpl is heavily unimplemented. Still implement t... - 03:24 PM Feature #2041: implement runtime support for "shared" attributes that are just stubbed
- Evgeny Kiselev wrote:
> Constantin Asofiei wrote:
> > # @XEntityImpl.getName and XEntityImpl.setName@ - this is a q...
12/02/2013
- 03:08 AM Feature #2041: implement runtime support for "shared" attributes that are just stubbed
- Hynek Cihlar wrote:
> > # in the end, each resource contains its own support for ADM-DATA and UNIQUE-ID (I mean, the...
12/01/2013
- 06:41 PM Feature #2041: implement runtime support for "shared" attributes that are just stubbed
- Constantin Asofiei wrote:
> # @XEntityImpl.getName and XEntityImpl.setName@ - this is a question for Evgeny: is the @... - 02:00 PM Feature #2041: implement runtime support for "shared" attributes that are just stubbed
- GenericWidget columnLabel setter/getter should call handle.invalidAttribute not just throw an exception (see note-5)....
- 01:44 PM Feature #2041: implement runtime support for "shared" attributes that are just stubbed
- Buffer resource is not mentioned but is also missing implementations for adm-data, unique-id, namespace-uri and buffe...
- 12:08 PM Feature #2041: implement runtime support for "shared" attributes that are just stubbed
- SOAPHeaderEntryImpl is heavily unimplemented. Still implement those local-name and namespace-uri attributes mentioned...
- 11:27 AM Feature #2041: implement runtime support for "shared" attributes that are just stubbed
- Constantin Asofiei wrote:
> Hynek, some notes:
> # SAX resource is WIP by Evgeny (and I expect all attrs/methods to...
11/30/2013
- 05:51 PM Feature #2041: implement runtime support for "shared" attributes that are just stubbed
- Hynek, some notes:
# SAX resource is WIP by Evgeny (and I expect all attrs/methods to be implemented, including ADM-... - 04:50 PM Feature #2041: implement runtime support for "shared" attributes that are just stubbed
- I have summarized the state of all attributes and what needs to be done. Please review the attached Calc sheet.
Al... - 04:45 PM Feature #2041 (WIP): implement runtime support for "shared" attributes that are just stubbed
- 10:23 AM Feature #1641: implement SAX XML support
- Review for 1129a.zip; I like how you handled the callbacks in @XMLCallbackWrapper@ and how @SaxReaderImpl@ code looks...
- 08:22 PM Feature #1641: implement SAX XML support
- new drop for review:
1) Finishing with callback handler wrapper
2) added DTD and schema validation in SaxReader
3)...
11/26/2013
- 06:42 PM Feature #1641: implement SAX XML support
- Greg Shah wrote:
> How much more time do you estimate that you will need to complete this work?
I've finishing with... - 11:39 AM Feature #1641: implement SAX XML support
- How much more time do you estimate that you will need to complete this work?
- 09:03 AM Feature #1634: implement full native library (.so or DLL) support
- Greg Shah wrote:
> I will go ahead and return 'O' instead of 'R' for getParameterModes().
OK. This will allow Cont... - 08:49 AM Feature #1634: implement full native library (.so or DLL) support
- I will go ahead and return 'O' instead of 'R' for getParameterModes().
The mode checking for native API calls is d... - 01:25 AM Feature #1634: implement full native library (.so or DLL) support
- Greg Shah wrote:
> > BTW, the native invocation code I think looks better in a distinct class; NativeProcedureCaller... - 08:41 AM Bug #2183 (Closed): fix resource save/restoration when used with string/handle functions
- 05:32 AM Bug #2183: fix resource save/restoration when used with string/handle functions
- The code (hc_upd20131118a.zip) passed regression tests (the run 20131116) and was committed as revision 10416.
Also available in: Atom