Activity
From 02/17/2014 to 03/18/2014
03/18/2014
- 01:59 PM Bug #2133: fix precision for decimal, dynamic-extent variables
- Hynek Cihlar wrote:
> Unless you are against it, I will keep the @isExpressionOfExtentType@ method even though the i... - 11:02 AM Bug #2133: fix precision for decimal, dynamic-extent variables
- Constantin Asofiei wrote:
> Hynek, about 0316a.zip. The implementation of @isExpressionOfExtentType@ should check f... - 04:09 AM Bug #2133: fix precision for decimal, dynamic-extent variables
- Hynek, about 0316a.zip. The implementation of @isExpressionOfExtentType@ should check for @extent@ annotations, not ...
- 01:53 PM Feature #1634: implement full native library (.so or DLL) support
- The update fixes the usual string conversion in Windows. Now we have properly converted...
03/16/2014
- 04:54 PM Bug #2133: fix precision for decimal, dynamic-extent variables
- I am attaching the initial implementation for fixing the @assignMulti@ method. The changes include the modification o...
03/14/2014
- 07:54 PM Feature #1634: implement full native library (.so or DLL) support
- The update for your review contains modification for @progress.g@ file and minor fix for @control_flow.rules@. The se...
03/13/2014
- 05:56 PM Feature #1634: implement full native library (.so or DLL) support
- The today update contains the @SourceNameMapper@ changes for you to review. The testcases are also included. The curr...
- 01:17 PM Feature #1634: implement full native library (.so or DLL) support
- Eugenie Lyzenko wrote:
> When the server is starting there is no physical dependency on the @test4.p@ file on the di... - 12:54 PM Feature #1634: implement full native library (.so or DLL) support
- > I don't understand: do you match an absolute name for the legacy 4GL program to an EXISTING file on the disk?
>
... - 12:04 PM Feature #1634: implement full native library (.so or DLL) support
- Eugenie Lyzenko wrote:
> I need to know what exactly the @"configured basepath"@ variable is on the run-time stage. ... - 11:41 AM Feature #1634: implement full native library (.so or DLL) support
- > canonicalize() will prepare the name so that it can be matched against a name from name_map.xml. Also, all names in...
- 10:57 AM Feature #1634: implement full native library (.so or DLL) support
- Greg Shah wrote:
> > I'm asking because the SourceNameMapper.canonicalize() is used in different places inside Sourc... - 09:15 AM Feature #1634: implement full native library (.so or DLL) support
- > And after the conversion has been completed it is not required to keep the original 4GL source tree on the server s...
- 09:05 AM Feature #1634: implement full native library (.so or DLL) support
- > All files to be converted must reside within a single subdirectory under the project home. This ensures that we can...
- 07:28 AM Feature #1634: implement full native library (.so or DLL) support
- > On the conversion stage the driver map the 4GL file name to the internal class for every program to be converted
... - 08:58 PM Feature #1634: implement full native library (.so or DLL) support
- Another important thing to clarify.
Observing the full deployment path from conversion the source to run the conve... - 07:15 AM Bug #2257: Set statment does not define variable
- The following code throws an exception during conversion procedure(this is legal code in 4gl):...
03/12/2014
- 07:44 PM Bug #2257 (New): Set statment does not define variable
- 05:36 PM Feature #1634: implement full native library (.so or DLL) support
- > 1. In your example is it key point the string leading to be the same as characters inside the strings(both ' or ")?...
- 04:22 PM Feature #1634: implement full native library (.so or DLL) support
- > The change in progressToJavaString() will cause problems with strings in Windows mode where the next char after the...
- 09:36 AM Feature #1634: implement full native library (.so or DLL) support
- > Does it mean all file-system container values in directory.xml file for the OS where the server is running should c...
- 09:32 AM Feature #1634: implement full native library (.so or DLL) support
- > It is not "predefined". That directory.xml is just a file that was designed to be run on Linux. All the values in t...
- 08:44 AM Feature #1634: implement full native library (.so or DLL) support
- Code Review 0311a
1. The change in progressToJavaString() will cause problems with strings in Windows mode where t... - 08:12 AM Feature #1634: implement full native library (.so or DLL) support
- > The question: do we plan to keep predefined "/" file separator value in directory.xml file?
It is not "predefine... - 08:46 AM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
- No. But please do create a new Redmine task (a bug) that describes the problem and has the testcase code for the rec...
03/11/2014
- 07:43 PM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
- Greg Shah wrote:
> Yes. Although, I am surprised it doesn't work (we support other define var cases that are in a f... - 08:46 PM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
- I'm responding to the note in #1629.
> Am correct ?
Yes. Although, I am surprised it doesn't work (we support ... - 08:04 PM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
- OK, I understand what you are trying to do.
I think there are 2 options (test these to see if either or both work)... - 05:09 PM Feature #1634: implement full native library (.so or DLL) support
- This update introduces the @SourceNameMapper.canonicalize()@ changes. I've found the @fileSep@ variable used in this ...
- 09:27 PM Feature #1634: implement full native library (.so or DLL) support
- This is the suggested change for conversion part of the process for you to review.
The @SourceNameMapper.canonical...
03/10/2014
- 07:10 PM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
- For example if I set @ECHO@ I want to know in code if something is displayed and if I set @NO-ECHO@ then display buff...
- 07:08 PM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
- What do you mean by "display"?
- 06:51 PM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
- Is any way to check what display is showing now in 4gl ?
- 07:59 AM Feature #1634: implement full native library (.so or DLL) support
- > So I guess we must transform path\to\program.p string to path\\to\\program.p for java converted code
Modify @pr... - 04:03 AM Bug #2133: fix precision for decimal, dynamic-extent variables
- Hynek Cihlar wrote:
> There's a bug in @ArrayAssigner.assignMulti(BaseDataType[], BaseDataType[])@. When assigning a...
03/09/2014
- 04:47 PM Bug #2133: fix precision for decimal, dynamic-extent variables
- There's a bug in @ArrayAssigner.assignMulti(BaseDataType[], BaseDataType[])@. When assigning a determinate array to a...
03/08/2014
- 02:58 PM Feature #1634: implement full native library (.so or DLL) support
- >Eugenie: please do provide full support for absolute (drive letter) paths on Windows.
OK.
Another finding. The... - 11:47 AM Feature #1634: implement full native library (.so or DLL) support
- > My suggestion is the converted code(meaning runtime level) should have only one interpretation for Windows file sep...
- 06:38 AM Feature #1634: implement full native library (.so or DLL) support
- Eugenie Lyzenko wrote:
> The first point I'm thinking about is how to convert these cases. My suggestion is the conv...
03/07/2014
- 05:29 PM Feature #1634: implement full native library (.so or DLL) support
- ...
- 04:42 PM Feature #1634: implement full native library (.so or DLL) support
- > Also: make sure you have tests including:
>
> drive letter + COLON + relative paths
> drive letter + COLON + ab... - 04:14 PM Feature #1634: implement full native library (.so or DLL) support
- I don't think that case 1 will work in the 4GL on Windows. The other two definitely need to be supported.
Also: m... - 03:57 PM Feature #1634: implement full native library (.so or DLL) support
- Which cases we need to handle for Windows:...
- 02:52 PM Feature #1634: implement full native library (.so or DLL) support
- Don't forget to send out the email too.
- 02:23 PM Feature #1634: implement full native library (.so or DLL) support
- > Eugenie: your next step is to implement proper support in @SourceNameMapper.canonicalize@ as described in note 117....
- 02:07 PM Feature #1634: implement full native library (.so or DLL) support
- Sorry, I should have picked up on that.
Eugenie: your next step is to implement proper support in @SourceNameMappe... - 02:05 PM Feature #1634: implement full native library (.so or DLL) support
- Greg Shah wrote:
> Where is the least-intrusive place to process that? It cannot be done at conversion time since i... - 02:02 PM Feature #1634: implement full native library (.so or DLL) support
- Where is the least-intrusive place to process that? It cannot be done at conversion time since it can be a runtime-g...
- 02:01 PM Feature #1634: implement full native library (.so or DLL) support
- Greg Shah wrote:
> Agreed. You can check in and distribute your change.
I think we forgot about a case: RUN <windo... - 02:00 PM Feature #1634: implement full native library (.so or DLL) support
- Agreed. You can check in and distribute your change.
- 01:48 PM Feature #1634: implement full native library (.so or DLL) support
- The conversion testing finished. There are no differences in generated java code in @src/aero/timco/majic@ including ...
- 10:03 AM Feature #1634: implement full native library (.so or DLL) support
- > 1. Check in your 0306b change.
Committed in bzr as 1116.
> 2. Do a conversion regression test of 0306a. There... - 09:51 AM Feature #1634: implement full native library (.so or DLL) support
- Excellent! OK, please go ahead with the following:
1. Check in your 0306b change.
2. Do a conversion regressio... - 09:34 AM Feature #1634: implement full native library (.so or DLL) support
- > 2. Are there any diffs in the converted code caused by this change (other than name_map.xml)?
After check I conf... - 09:02 AM Feature #1634: implement full native library (.so or DLL) support
- > 1. With this change, does the Windows native API support work properly?
I think yes. There are some diffs regard... - 08:15 AM Feature #1634: implement full native library (.so or DLL) support
- Code Review 0306a/b
I am fine with the changes.
Questions:
1. With this change, does the Windows native API ... - 09:06 PM Feature #1634: implement full native library (.so or DLL) support
- The update for you to review to fix @name_map.xml@ entries. Only @name_map.xml@ generation rule is involved. So no ne...
- 04:23 PM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
- Make sure you have a testcase that does something like this:...
- 01:13 AM Feature #1599: shift EXP implementation (MathOps.pow()) to BigDecimal
- I also added a javadoc fix of the method pow(BigDecimal, BigDecimal). The changes were regression tested and checked ...
03/05/2014
- 04:53 PM Feature #1634: implement full native library (.so or DLL) support
- Some finding for execution the test in 4GL systems:
Source:... - 04:48 PM Feature #1634: implement full native library (.so or DLL) support
- > And what about native library path names? For example @"library_calls/testapi/testapi.dll"@. Here we also need Linu...
- 04:05 PM Feature #1634: implement full native library (.so or DLL) support
- > We want to implement all name_map.xml entries in Linux form, even if the app was written with Windows file seps. In...
- 03:52 PM Feature #1634: implement full native library (.so or DLL) support
- Greg Shah wrote:
> Constantin: please provide your thoughts on where exactly to put this code. I know we need to re... - 03:43 PM Feature #1634: implement full native library (.so or DLL) support
- We want to implement all name_map.xml entries in Linux form, even if the app was written with Windows file seps. In ...
- 03:22 PM Feature #1634: implement full native library (.so or DLL) support
- > I understand. But my concern is that changing the p2j.cfg.xml has other implications that may make this a bad idea....
- 01:25 PM Feature #1634: implement full native library (.so or DLL) support
- No, you are right. The @p2j.cfg.xml.win@ should have @case-sensitive==false@. Keep this change.
- 12:59 PM Feature #1634: implement full native library (.so or DLL) support
- > I understand. But my concern is that changing the p2j.cfg.xml has other implications that may make this a bad idea....
- 12:24 PM Feature #1634: implement full native library (.so or DLL) support
- > This change was made according to note #96 above.
I understand. But my concern is that changing the p2j.cfg.xml... - 12:11 PM Feature #1634: implement full native library (.so or DLL) support
- >...
- 11:40 AM Feature #1634: implement full native library (.so or DLL) support
- Code Review 0305a
The change to @collect_names.rules@ is fine. The @null@ check is not really needed, because if ... - 11:19 AM Feature #1634: implement full native library (.so or DLL) support
- Code Review 0305b
The change to these values is concerning:... - 10:47 AM Feature #1634: implement full native library (.so or DLL) support
- Two updates for you to review, one for P2J code, other - for testcases(@p2j.cfg.xml.win@ to convert testcases). As fo...
- 09:22 AM Feature #1634: implement full native library (.so or DLL) support
- Please post a real update so that I can use diffing tools (like meld) to compare your changes. The changes you have ...
03/04/2014
- 05:31 PM Feature #1634: implement full native library (.so or DLL) support
- The changes for you to review to convert/compile/run testcases in Windows. The result - there are no messages during ...
- 12:49 PM Feature #1634: implement full native library (.so or DLL) support
- > Using libname = ExpressionConversionWorker.progressToJavaString(libname) causes the exception:
Please search the... - 12:42 PM Feature #1634: implement full native library (.so or DLL) support
- The strange thing I'm struggling with. Using libname = ExpressionConversionWorker.progressToJavaString(libname) cause...
03/03/2014
- 04:33 PM Feature #1599: shift EXP implementation (MathOps.pow()) to BigDecimal
- Code Review 0227a
It looks fine. Assuming it passes testing, you can check it in and distribute it.
02/28/2014
- 10:06 AM Feature #1634: implement full native library (.so or DLL) support
- > The place to fix is:
Yes. Instead of the call to @removeQuotes()@, it should call @ExpressionConversionWorker.p... - 09:20 AM Feature #1634: implement full native library (.so or DLL) support
- > ... But in this case the text is stored into the name_map.xml during annotations/collect_names.rules and the string...
- 08:55 AM Feature #1634: implement full native library (.so or DLL) support
- > Greg, please advise: is this a conversion bug in the library name conversion, or a problem in load_library_native, ...
- 05:56 AM Feature #1634: implement full native library (.so or DLL) support
- Eugenie Lyzenko wrote:
> This is just fragment, the others - inside attached
> [...]
The @~\@ comes from the 4GL c... - 05:42 AM Feature #1634: implement full native library (.so or DLL) support
- This is just fragment, the others - inside attached...
- 04:52 AM Feature #1634: implement full native library (.so or DLL) support
- Eugenie Lyzenko wrote:
> > What I think we need to do is to keep the program names in name_map.xml with the linux-st... - 04:48 AM Feature #1634: implement full native library (.so or DLL) support
- > What I think we need to do is to keep the program names in name_map.xml with the linux-style separator.
After ch... - 02:55 AM Feature #1634: implement full native library (.so or DLL) support
- Greg Shah wrote:
> No, this is not a conversion problem. We can't change the source code since it is valid 4GL and ...
02/27/2014
- 06:06 PM Feature #1634: implement full native library (.so or DLL) support
- Another similar issue is library name transformation from requested @"library_calls\\testapi\\testapi.dll"@ to @"libr...
- 03:38 PM Feature #1634: implement full native library (.so or DLL) support
- In the 4GL, this code works without problem on both Linux and Windows.
This means there is a runtime problem in ou... - 02:54 PM Feature #1634: implement full native library (.so or DLL) support
- The first thing I've faced is the issue with hardcoded test file path name to run for example:...
- 11:19 AM Feature #1634: implement full native library (.so or DLL) support
- > The Linux copy has the error I need to clarify:
Please compare your results to the logs in note 79 to see if err... - 10:30 AM Feature #1634: implement full native library (.so or DLL) support
- I'm executing test_runner.p in both Linux and Windows to compare behavior/results. The Linux copy has the error I nee...
- 08:17 AM Feature #1634: implement full native library (.so or DLL) support
- > I think what you are missing is copy the p2jspi.jar in your JRE's ext lib folder.
Yes, you are right, the server... - 07:54 AM Feature #1634: implement full native library (.so or DLL) support
- Eugenie Lyzenko wrote:
> Ti enable persistence for server the following changes should be done in directory.xml file... - 07:52 AM Feature #1634: implement full native library (.so or DLL) support
- Regarding previous note error. Do I need to set up the SQL server running on Windows to execute the tests?
- 07:49 AM Feature #1634: implement full native library (.so or DLL) support
- Trying to start the server on Windows for native library with persistence enabled. But the error is happening.
Ti ... - 03:06 PM Feature #1599: shift EXP implementation (MathOps.pow()) to BigDecimal
- Fixed error handling issue in MathOps.pow(BigDecimal, BigDecimal). Regression test is in progress.
- 02:55 PM Bug #2133: fix precision for decimal, dynamic-extent variables
- Constantin Asofiei wrote:
> When the number of array elements is missing, then we have a dynamic extent. And looks l... - 12:00 PM Bug #2133: fix precision for decimal, dynamic-extent variables
- Hynek Cihlar wrote:
> Setting decimal precision in the @DEFINE VARIABLE@ statement of an @EXTENT@ with the missing n... - 11:13 AM Bug #2133: fix precision for decimal, dynamic-extent variables
- Setting decimal precision in the @DEFINE VARIABLE@ statement of an @EXTENT@ with the missing number of array elements...
- 02:52 PM Bug #2250: Conversion error when decimal precision defined on dynamic extent variable
- Setting decimal precision in the @DEFINE VARIABLE@ statement of an @EXTENT@ with the missing number of array elements...
- 02:51 PM Bug #2250 (Closed): Conversion error when decimal precision defined on dynamic extent variable
02/26/2014
- 03:35 PM Feature #1599 (Closed): shift EXP implementation (MathOps.pow()) to BigDecimal
- 03:17 PM Feature #1599: shift EXP implementation (MathOps.pow()) to BigDecimal
- 0220a regression tested and checked in to bzr revision 10481.
02/25/2014
- 12:57 PM Feature #1608: implement full appserver support (from 4GL clients only)
- About static resources generated in a appserver procedure ran persistent (using @RUN ... PERSISTENT ON SERVER@ or via...
02/24/2014
- 02:26 PM Bug #2133: fix precision for decimal, dynamic-extent variables
- Greg Shah wrote:
> > Can it ever happen to have the array reference registered to multiple scopes on the scope stack... - 02:18 PM Bug #2133: fix precision for decimal, dynamic-extent variables
- > Can it ever happen to have the array reference registered to multiple scopes on the scope stack?
Yes. I believe... - 01:47 PM Bug #2133: fix precision for decimal, dynamic-extent variables
- When the dynamic array is resized (@EXTENT@ statement is encountered), old array reference is "deregistered" and new ...
- 12:11 PM Feature #2145 (Closed): eliminate program-name limitations
- 11:50 AM Feature #2145: eliminate program-name limitations
- Greg Shah wrote:
> Have you retested the "standalone" super proc/persistent proc testcases?
Yes, the tests are OK.
... - 10:49 AM Feature #2145: eliminate program-name limitations
- Code Review 0222b/e
I am fine with the changes. This is another nice improvement/refactoring of the code such tha...
02/23/2014
- 03:15 PM Feature #1599 (WIP): shift EXP implementation (MathOps.pow()) to BigDecimal
- 03:13 PM Bug #2133 (WIP): fix precision for decimal, dynamic-extent variables
- 03:12 PM Bug #2133: fix precision for decimal, dynamic-extent variables
- The decimal precision is effectively lost when (1) unfixed decimal array is defined and later fixed with the @EXTENT@...
- 04:18 AM Feature #2145 (Review): eliminate program-name limitations
- 04:14 AM Feature #2145: eliminate program-name limitations
- The 0222b.zip and 0222e.zip (from #2248) have passed regression testing, after checking the cumulative regression tes...
02/22/2014
- 09:47 AM Feature #2145: eliminate program-name limitations
- Failures during testing of 0222b.zip: there are cases like this (MAJIC uses them):...
- 05:05 AM Feature #2145: eliminate program-name limitations
- This version allows java-style calls for internal and external procedures and centralizes the maintenance of procedur...
02/21/2014
- 09:15 AM Feature #2145: eliminate program-name limitations
- Greg Shah wrote:
> Option 3 is the best solution, IF it is possible.
I think I will go ahead with this one. The onl... - 08:31 AM Feature #2145: eliminate program-name limitations
- Option 3 is the best solution, IF it is possible.
A modified option 1 may be the next best approach. The idea is ... - 04:10 AM Feature #2145 (WIP): eliminate program-name limitations
- Regression testing showed problems related to calling the hand-written java code: we need to determine the policy of ...
02/20/2014
- 04:45 PM Feature #1625: implement OUTPUT TO PRINTER on Windows
- The Linux/UNIX support for OUTPUT TO PRINTER is already done from the work in #1631. The remaining work for this tas...
- 04:37 PM Feature #1824 (Closed): client platform delegate implementation
- The design choices implemented in #1811 eliminate the need for this work.
- 11:05 AM Feature #2145: eliminate program-name limitations
- > The only dependence on reflection is the "java-style calls of legacy user-def functions", when we need to determine...
- 10:56 AM Feature #2145 (Review): eliminate program-name limitations
- Greg Shah wrote:
> We don't have much choice in coding so much dependence on reflection and the old approach was als... - 09:58 AM Feature #2145: eliminate program-name limitations
- Code Review 0220d
I am OK with the changes. As always with the procedure processing, this stuff is pretty nasty. ... - 09:21 AM Feature #2145 (WIP): eliminate program-name limitations
- This solves the OOME and the SOURCE- and TARGET-PROCEDURE deviations. Is going through testing now.
- 08:21 AM Feature #1599: shift EXP implementation (MathOps.pow()) to BigDecimal
- Code Review 0220a
Everything looks good. If it passes runtime regression testing, you can check it in and distrib... - 03:58 AM Feature #1599: shift EXP implementation (MathOps.pow()) to BigDecimal
- I also moved the @log@ private methods down to the private methods section. The attached changes are submitted for re...
- 01:26 AM Feature #1624: add support for PUT CONTROL
- Evgeny Kiselev wrote:
> Do I need to commit testcases ?
Of course, the testcases need to be in the repository. - 11:00 PM Feature #1624: add support for PUT CONTROL
- Do I need to commit testcases ?
- 11:59 PM Feature #2208: create a java application running web services for testing purposes
- I've committed intermediate version of test server to the @testcases/uast/web_services/server/@.
To run this from ID...
02/19/2014
- 03:41 PM Feature #1599: shift EXP implementation (MathOps.pow()) to BigDecimal
- Code Review 0219a
The code looks good. My only comments relate to some coding standards:
1. Lines 608 and 614 a... - 02:52 PM Feature #1599: shift EXP implementation (MathOps.pow()) to BigDecimal
- Please review the attached changes. Testcases checked in to testcases/uast/math/exp.p.
- 12:15 PM Feature #1624 (Closed): add support for PUT CONTROL
- 11:52 AM Feature #1624: add support for PUT CONTROL
- update evk_upd20140214a.zip has been passed regression testing.
Committed to bzr revision 10470. - 11:13 PM Feature #1624 (Review): add support for PUT CONTROL
02/18/2014
- 01:50 PM Feature #2145: eliminate program-name limitations
- This should solve the SOURCE- and TARGET-PROCEDURE cases (when invoking an external program or a trigger). Also, it i...
- 11:02 AM Feature #1634: implement full native library (.so or DLL) support
- Almost.
> take the testcases from @native_library_calls_4gl_..._sample_20131107.zip@
No, that is just a slightly... - 10:51 AM Feature #1634: implement full native library (.so or DLL) support
- Greg,
The question about task #2234. The goal is to take the testcases from @native_library_calls_4gl_..._sample_2...
02/17/2014
Also available in: Atom