FWD » Core Development » Base Language

04/22/2014

11:53 AM Bug #2288: incorrect conversion and results for unknown value comparisons

The 0421a update has passed conversion regression testing. Now performing runtime testing. Eric Faulhaber

10:06 PM Bug #2288: incorrect conversion and results for unknown value comparisons

Regression testing again showed an unwanted change with the 0420a update. Previously,... Eric Faulhaber

04/21/2014

01:31 PM Bug #2288: incorrect conversion and results for unknown value comparisons

It probably makes sense to note the status of this task in #18 and to move that task into the Database project. It ma... Greg Shah

01:13 PM Bug #2288: incorrect conversion and results for unknown value comparisons

Greg Shah wrote:
> Not that you were asking, but I am fine with the changes.
OK, the feedback is helpful, particula... Eric Faulhaber

12:49 PM Bug #2288: incorrect conversion and results for unknown value comparisons

Code Review 0420a
Not that you were asking, but I am fine with the changes.
Are the remaining portions of #18 o... Greg Shah

11:20 AM Bug #2288: incorrect conversion and results for unknown value comparisons

Regression testing indicated that this change had the useful side effect of fixing some queries that were selecting t... Eric Faulhaber

04/19/2014

10:27 PM Bug #2288: incorrect conversion and results for unknown value comparisons

The attached update, based on some of Vadim's findings documented in #18 (note 9), resolves the issue. Eric Faulhaber

04/18/2014

02:28 PM Bug #2288: incorrect conversion and results for unknown value comparisons

Seems it started off that way, though in the history, #18 only describes the inequality comparisons with true/false, ... Eric Faulhaber

02:10 PM Bug #2288: incorrect conversion and results for unknown value comparisons

Is this the same as #18? Greg Shah

12:57 AM Bug #2288: incorrect conversion and results for unknown value comparisons

Consider the following 4GL test (testcases/uast/unknown-comparison2.p):... Eric Faulhaber

12:30 AM Bug #2288 (Closed): incorrect conversion and results for unknown value comparisons

Eric Faulhaber

03:06 AM Bug #2284: Fix parameter initialization

Hynek Cihlar wrote:
> Attached is the fix for the above two initialization issues, *please review*. Regression test ... Constantin Asofiei

04/17/2014

04:05 PM Bug #2284: Fix parameter initialization

It turns out I was running the P2J conversion without the proper version defined, i.e. with the default 9.0C as Const... Hynek Cihlar

10:15 AM Support #2234 (Closed): test and fix native API support on Windows

Greg Shah

08:48 AM Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

There are polymorphic functions (FUNC_POLY), attributes (ATTR_POLY) and methods (METH_POLY) in the 4GL. These are bu... Greg Shah

04/16/2014

06:59 PM Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

Several data type wrapper implementations have TODOs in @assign(BaseDataType value, boolean force)@, as in the follow... Eric Faulhaber

06:47 PM Feature #2287 (Closed): implement missing type conversion for POLY cases in data type wrapper ass...

Eric Faulhaber

04/15/2014

09:36 AM Feature #2184: create and populate the temp-table on the remote side, based on the received metad...

Update for review. Stanislav Lomany

04/14/2014

03:15 PM Bug #2284: Fix parameter initialization

The original source suggests that Progress 9.0C version behaves differently in respect to the parameter initializatio... Hynek Cihlar

01:41 AM Bug #2284: Fix parameter initialization

Hynek Cihlar wrote:
> Note that the file @variable_definitions.rules@ contained logic of Progress V9.0C. I removed t... Constantin Asofiei

05:12 AM Feature #2184: create and populate the temp-table on the remote side, based on the received metad...

Stanislav Lomany wrote:
> Constantin, is there a simple way do determine that the specific context is run using an a... Constantin Asofiei

04:59 AM Feature #2184: create and populate the temp-table on the remote side, based on the received metad...

Constantin, is there a simple way do determine that the specific context is run using an agent? Stanislav Lomany

02:20 AM Bug #2283: Appserver persistence-related abend on subsequent connect

Stanislav, if you look into the @TM.resettables@ list, there are two @BufferManager@ instances, when it should have b... Constantin Asofiei

04/13/2014

05:35 PM Bug #2284: Fix parameter initialization

Attached is the fix resolving the found parameter initialization issues.
Note that the file @variable_definitions... Hynek Cihlar

04:23 PM Bug #2284 (WIP): Fix parameter initialization

Hynek Cihlar

04:04 PM Bug #2284: Fix parameter initialization

The following are the cases where the variable initialization fails.
* Components of an indeterminate unfixed extent... Hynek Cihlar

03:29 PM Bug #2284 (Closed): Fix parameter initialization

Hynek Cihlar

04:21 PM Bug #2133: fix precision for decimal, dynamic-extent variables

Because the problem of parameter initialization goes beyond the extents, I created a separate issue for it. See #2284. Hynek Cihlar

04/12/2014

04:44 AM Bug #2283: Appserver persistence-related abend on subsequent connect

Testcase (@called.p@):... Stanislav Lomany

04:38 AM Bug #2283 (Closed): Appserver persistence-related abend on subsequent connect

Stanislav Lomany

04/10/2014

03:18 PM Feature #2184: create and populate the temp-table on the remote side, based on the received metad...

Stanislav Lomany wrote:
> Where should we "keep" the values - in the global scopes (should we add them?) of scoped d... Constantin Asofiei

12:49 PM Feature #2184: create and populate the temp-table on the remote side, based on the received metad...

> I think the problem is here. When an appserver procedure is ran persistent and its topmost scope is finished, I thi... Stanislav Lomany

09:44 AM Feature #2184: create and populate the temp-table on the remote side, based on the received metad...

Stanislav Lomany wrote:
> Note that topmost scope for the external procedure is also deleted.
I think the problem i... Constantin Asofiei

08:39 AM Feature #2184: create and populate the temp-table on the remote side, based on the received metad...

Guys, consider an external persistent procedure and a buffer scoped to that procedure. When we call an internal proce... Stanislav Lomany

01:31 PM Feature #1634: implement full native library (.so or DLL) support

The @evl_upd20140403b.zip@ has been committed into bzr as 10509. Eugenie Lyzenko

01:00 PM Feature #1634: implement full native library (.so or DLL) support

Today I have got completely passed CTRL-C session tests(2-way and 3-way in single passed run). So I have started the ... Eugenie Lyzenko

04/09/2014

05:30 PM Feature #1634: implement full native library (.so or DLL) support

I have finished regression testing. The results have been uploaded to share. So I can start uploading changes:
1. ... Eugenie Lyzenko

11:32 AM Feature #1634: implement full native library (.so or DLL) support

Eugenie Lyzenko wrote:
> 1. I have to commit the @majic@ changes first, into the @staging@ branch, correct?
Yes, ... Constantin Asofiei

11:09 AM Feature #1634: implement full native library (.so or DLL) support

Looks like I'm finishing with regression testing. Wait for finished CTRL-C results to arrive. And before committing P... Eugenie Lyzenko

04/08/2014

07:16 PM Feature #1634: implement full native library (.so or DLL) support

The main part of the runtime testing has passed without any regression. One time cycle, clean run(except known tc-job... Eugenie Lyzenko

01:57 PM Feature #1634: implement full native library (.so or DLL) support

> Eugenie, have you added the ACL I mentioned at note 209?
For unknown reasons I have not got the e-mail with this... Eugenie Lyzenko

01:31 PM Feature #1634: implement full native library (.so or DLL) support

Eugenie, have you added the ACL I mentioned at note 209? Because after adding this ACL, your update worked fine for m... Constantin Asofiei

01:24 PM Feature #1634: implement full native library (.so or DLL) support

Greg, Constantin,
After a lot of debugging(including remote session to @devbox01@ P2J server and client) I need on... Eugenie Lyzenko

04/07/2014

03:30 AM Feature #2184: create and populate the temp-table on the remote side, based on the received metad...

Stanislav, you are correct: the @loadedBuffers.size() > 0@ check is needed in @scopeDeleted()@. The problem here is ... Constantin Asofiei

04/05/2014

05:03 AM Feature #2184: create and populate the temp-table on the remote side, based on the received metad...

Guys, there is an issue with scoping on app server. Consider a simple testcase: ... Stanislav Lomany

04/04/2014

01:37 PM Feature #1634: implement full native library (.so or DLL) support

> For this, I expected that copying the entire contents of the @x86_64-w64-mingw32.zip@ archive in my mingw64 folder ... Eugenie Lyzenko

11:33 AM Feature #1634: implement full native library (.so or DLL) support

Eugenie Lyzenko wrote:
> > Eugenie, is it correct for the x86_64-w64-mingw32.zip to contain this path: @x86_64-w64-m... Constantin Asofiei

10:59 AM Feature #1634: implement full native library (.so or DLL) support

> Eugenie, is it correct for the x86_64-w64-mingw32.zip to contain this path: @x86_64-w64-mingw32/libs/@, instead of ... Eugenie Lyzenko

07:38 AM Feature #1634: implement full native library (.so or DLL) support

Eugenie, is it correct for the x86_64-w64-mingw32.zip to contain this path: @x86_64-w64-mingw32/libs/@, instead of @x... Constantin Asofiei

06:29 AM Feature #1634: implement full native library (.so or DLL) support

Eugenie Lyzenko wrote:
> Found the runtime regression. When the client starts, after enter username and login the fo... Constantin Asofiei

12:12 PM Bug #2133: fix precision for decimal, dynamic-extent variables

Hynek Cihlar wrote:
> Hynek Cihlar wrote:
> > Yes, of course, sorry for that. The attached file is the correct exam... Constantin Asofiei

12:03 PM Bug #2133: fix precision for decimal, dynamic-extent variables

Regression test of 0329a.zip passed. Fixed the indent in 0329a.zip (see the attached 0404a.zip) and committed to revi... Hynek Cihlar

11:37 AM Bug #2133: fix precision for decimal, dynamic-extent variables

Hynek Cihlar wrote:
> Yes, of course, sorry for that. The attached file is the correct example.
Constantin, is th... Hynek Cihlar

05:00 AM Bug #2133: fix precision for decimal, dynamic-extent variables

Hynek Cihlar wrote:
> I think you reviewed the wrong file.
Yes, it was the wrong file. What confused me was that I... Constantin Asofiei

04/03/2014

06:02 PM Feature #1634: implement full native library (.so or DLL) support

Found the runtime regression. When the client starts, after enter username and login the following exception occurs:
... Eugenie Lyzenko

03:09 PM Feature #1634: implement full native library (.so or DLL) support

The conversion testing completed without regressions. The @src/aero/timco/majic@ directory with converted files is id... Eugenie Lyzenko

12:33 PM Feature #1634: implement full native library (.so or DLL) support

> With these changes, do the native library calls all work as expected on Windows?
The converted code and output f... Eugenie Lyzenko

12:01 PM Feature #1634: implement full native library (.so or DLL) support

> The only issue I see is that the class javadoc for @ServerPropertiesDaemon@ is incorrect (due to copy/paste). Pleas... Eugenie Lyzenko

11:29 AM Feature #1634: implement full native library (.so or DLL) support

Code Review 0403a
The only issue I see is that the class javadoc for ServerPropertiesDaemon is incorrect (due to c... Greg Shah

07:06 AM Feature #1634: implement full native library (.so or DLL) support

> I'm refering to the @EnvironmentOps.propathOverride@ field defined at line 151 (which has no javadoc, btw, and was ... Eugenie Lyzenko

06:42 AM Feature #1634: implement full native library (.so or DLL) support

Eugenie Lyzenko wrote:
> The fixed update for review.
>
> > the @EnvironmentOps.propathOverride@ is not used, it ... Constantin Asofiei

06:35 AM Feature #1634: implement full native library (.so or DLL) support

The fixed update for review.
> the @EnvironmentOps.propathOverride@ is not used, it needs to be removed.
This c... Eugenie Lyzenko

02:10 AM Feature #1634: implement full native library (.so or DLL) support

Eugenie, about 0328a.zip:
# the @EnvironmentOps.propathOverride@ is not used, it needs to be removed.
# there is on... Constantin Asofiei

01:23 PM Bug #2133: fix precision for decimal, dynamic-extent variables

Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > Any update on the review request from the note #33?
> I guess ... Hynek Cihlar

01:09 PM Bug #2133: fix precision for decimal, dynamic-extent variables

Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > Note the call @extj.setParameter(j, true)@ for the input-output... Hynek Cihlar

02:02 AM Bug #2133: fix precision for decimal, dynamic-extent variables

Hynek Cihlar wrote:
> Note the call @extj.setParameter(j, true)@ for the input-output case which initializes the arr... Constantin Asofiei

11:32 AM Bug #2277: Wrong conversion of session handler

Next 4gl code produce uncompilable java code:... Greg Shah

04/02/2014

03:18 PM Bug #2133: fix precision for decimal, dynamic-extent variables

Any update on the review request from the note #33? Hynek Cihlar

03:17 PM Bug #2133: fix precision for decimal, dynamic-extent variables

File attachment for the #35 note above. Hynek Cihlar

03:16 PM Bug #2133: fix precision for decimal, dynamic-extent variables

Constantin Asofiei wrote:
> Sorry, I'm coming back on this one: when we can choose between emitting code and hiding ... Hynek Cihlar

04/01/2014

05:43 PM Feature #1634: implement full native library (.so or DLL) support

The different testing performed to check the validity of the 0328a update shows no difference in local conversion in ... Eugenie Lyzenko

07:09 AM Bug #2133: fix precision for decimal, dynamic-extent variables

Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > May I suggest the following solution? To revert the change in @... Constantin Asofiei

03/31/2014

07:14 PM Bug #2133: fix precision for decimal, dynamic-extent variables

Attached is the final fix for the extent-to-extent assignment. The delta from the previous version (hc_upd20140324a.z... Hynek Cihlar

02:56 PM Bug #2133: fix precision for decimal, dynamic-extent variables

Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > Constantin Asofiei wrote:
> > For the function case, @ControlF... Hynek Cihlar

03:31 AM Bug #2133: fix precision for decimal, dynamic-extent variables

Hynek Cihlar wrote:
> May I suggest the following solution? To revert the change in @OutputExtentParameter@ and @Arr... Constantin Asofiei

03:29 AM Bug #2133: fix precision for decimal, dynamic-extent variables

Hynek Cihlar wrote:
> Constantin Asofiei wrote:
> For the function case, @ControlFlowOps@ is not called. Perhaps it... Constantin Asofiei

06:03 PM Bug #2277: Wrong conversion of session handler

If code spits like this:... Evgeny Kiselev

05:58 PM Bug #2277 (New): Wrong conversion of session handler

Evgeny Kiselev

04:07 AM Feature #1608: implement full appserver support (from 4GL clients only)

0326c.zip was committed to bzr rev 10502. Constantin Asofiei

03/30/2014

08:32 PM Bug #2133: fix precision for decimal, dynamic-extent variables

Constantin Asofiei wrote:
> This one I think requires a conversion change: @integer[] j = extj.getVariable(2);@ need... Hynek Cihlar

03/28/2014

04:26 PM Feature #1634: implement full native library (.so or DLL) support

The update 0328a fixes the conversion issue I've found and works OK with and without another P2J server running simul... Eugenie Lyzenko

01:41 PM Feature #1634: implement full native library (.so or DLL) support

The fix for conversion issue in @EnvironmentOps@. Based on the fact the @SessionManager.get()@ returns not null when ... Eugenie Lyzenko

01:01 PM Feature #1634: implement full native library (.so or DLL) support

I have found the regression with @EnvironmentOps@ trying MAJIC conversion on my local system in Linux with last updat... Eugenie Lyzenko

11:04 PM Feature #1634: implement full native library (.so or DLL) support

> @EnvironmentOps@ is designed only for server side usage. We should never try to use it on the client. Please use th... Eugenie Lyzenko

04:24 PM Bug #2133: fix precision for decimal, dynamic-extent variables

Constantin Asofiei wrote:
> Go ahead and fix this in @ControlFlowOps$InternalEntryCaller.valid@.
For the function... Hynek Cihlar

03/27/2014

11:07 AM Feature #1634: implement full native library (.so or DLL) support

> And I think we can do this because the value of the propathOverride is only per the server instance.
No, this is... Greg Shah

03/26/2014

05:00 PM Feature #1634: implement full native library (.so or DLL) support

> No. We must be able to customize this value. That means calling "up" to the server to read a value from the directo... Eugenie Lyzenko

03:54 PM Feature #1634: implement full native library (.so or DLL) support

> For the point you noted the EnvironmentOps.getVersion().toStringMessage() can be replaced with string "10.2B". Is i... Greg Shah

02:47 PM Feature #1634: implement full native library (.so or DLL) support

> The problem is this code in Registry.java:
>
> ... Eugenie Lyzenko

12:14 PM Feature #1634: implement full native library (.so or DLL) support

The problem is this code in Registry.java:... Greg Shah

10:33 AM Feature #1634: implement full native library (.so or DLL) support

For note #1
The reason of this change is I've found if we just use as expected to be working:... Eugenie Lyzenko

09:51 AM Feature #1634: implement full native library (.so or DLL) support

Code Review 0326a
Everything here is much better. It is very close.
1. The changes in @EnvironmentOps.fixupProp... Greg Shah

08:37 AM Feature #1634: implement full native library (.so or DLL) support

The update for review contains the changes for previous notes. Note I have changed @ThinClient@ to do not use @Platfo... Eugenie Lyzenko

04:48 PM Bug #2133: fix precision for decimal, dynamic-extent variables

Hynek Cihlar wrote:
> In Progress, function/procedure fixed-extent parameter's components are initialized to unknown... Constantin Asofiei

04:40 PM Bug #2133: fix precision for decimal, dynamic-extent variables

Hynek Cihlar wrote:
> Constantin Asofiei wrote:
> > Hynek Cihlar wrote:
> > > The following code sample causes the... Constantin Asofiei

04:21 PM Bug #2133: fix precision for decimal, dynamic-extent variables

Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > The following code sample causes the error message 'Calling pro... Hynek Cihlar

04:15 PM Bug #2133: fix precision for decimal, dynamic-extent variables

Hynek Cihlar wrote:
> The following code sample causes the error message 'Calling procedure /home/hc/p34141_Untitled... Constantin Asofiei

04:08 PM Bug #2133: fix precision for decimal, dynamic-extent variables

The following code sample causes the error message 'Calling procedure /home/hc/p34141_Untitled8.ped cannot input an i... Hynek Cihlar

03:51 PM Bug #2133: fix precision for decimal, dynamic-extent variables

In Progress, function/procedure fixed-extent parameter's components are initialized to unknown values when an unfixed... Hynek Cihlar

03:09 PM Bug #2133: fix precision for decimal, dynamic-extent variables

The converted code doesn't give the correct error message when assigning a fixed array to an indeterminate and alread... Hynek Cihlar

10:01 AM Bug #2133: fix precision for decimal, dynamic-extent variables

I have finished a release-candidate implementation for the decimal precision. I am testing it and also looking for ed... Hynek Cihlar

04:03 PM Feature #1608: implement full appserver support (from 4GL clients only)

Code Review 0326c
The changes look good. They can be runtime regression tested. Greg Shah

01:54 PM Feature #1608: implement full appserver support (from 4GL clients only)

Fixes for note 142 (all persistent procedures need to be deleted by the Agent which created them) and a bug in sessio... Constantin Asofiei

01:23 PM Bug #2265 (Closed): Extent initializer compiles fine on scalar variable definition

Greg Shah

01:16 PM Bug #2265: Extent initializer compiles fine on scalar variable definition

I see now. Can you then close the issue? Hynek Cihlar

01:12 PM Bug #2265: Extent initializer compiles fine on scalar variable definition

Hynek Cihlar wrote:
> I probably wasn't descriptive enough. The code sample doesn't compile in Progress, it gives "T... Constantin Asofiei

12:00 PM Bug #2265: Extent initializer compiles fine on scalar variable definition

I probably wasn't descriptive enough. The code sample doesn't compile in Progress, it gives "Too many initial values ... Hynek Cihlar

10:44 AM Bug #2265: Extent initializer compiles fine on scalar variable definition

Hynek, P2J will always convert valid 4GL code, which can compile in Progress. We do not want and will not start hunti... Constantin Asofiei

10:39 AM Bug #2265: Extent initializer compiles fine on scalar variable definition

The following code snippet compiles without errors producing invalid Java code.... Hynek Cihlar

10:34 AM Bug #2265 (Closed): Extent initializer compiles fine on scalar variable definition

Hynek Cihlar

03/25/2014

05:02 PM Feature #1634: implement full native library (.so or DLL) support

Code Review 0325a
1. The @isUnderWindowsFamily()@ does not need to be implemented on the client side. The @getOpe... Greg Shah

11:49 AM Feature #1634: implement full native library (.so or DLL) support

The update for review with reworked OS detection tools.
The questions to clarify:
1. @EnvironmentOps@ is the clas... Eugenie Lyzenko

02:11 PM Bug #2133: fix precision for decimal, dynamic-extent variables

Hynek, the changes look good. How is the decimal precision working? Constantin Asofiei

11:47 AM Bug #2133: fix precision for decimal, dynamic-extent variables

Attached are changes based on the feedback from last review - @isExpressionOfExtentType@ was removed. I submitted the... Hynek Cihlar

03/24/2014

12:15 PM Feature #1634: implement full native library (.so or DLL) support

For efficiency, please only call down to the client once per session. Save off the value (in the server side) the fir... Greg Shah

12:12 PM Feature #1634: implement full native library (.so or DLL) support

No, we need to fix @EnvironmentOps.getOperatingSystem()@ and @EnvironmentOps.getPathSeparator()@ to query the client ... Greg Shah

11:55 AM Feature #1634: implement full native library (.so or DLL) support

There is still an issue in @SourceNameMapper.convertName()@ with the usage of @PlatformHelper.isUnderWindowsFamily()@... Eugenie Lyzenko

11:34 AM Feature #1634: implement full native library (.so or DLL) support

There is still an issue in SourceNameMapper.convertName() with the usage of PlatformHelper.isUnderWindowsFamily(). T... Greg Shah

11:28 AM Feature #1634: implement full native library (.so or DLL) support

> Eugenie, the changes in 0324a.zip look good.
Meaning I can run conversion and runtime regression testing for thi... Eugenie Lyzenko

10:41 AM Feature #1634: implement full native library (.so or DLL) support

Eugenie, the changes in 0324a.zip look good. Constantin Asofiei

09:37 AM Feature #1634: implement full native library (.so or DLL) support

The update for your review contains clean up for @SourceNameMap@ class for @canonicalize()@ usage and javadoc small c... Eugenie Lyzenko

08:57 AM Feature #1634: implement full native library (.so or DLL) support

Eugenie Lyzenko wrote:
> Or we do not need any additional processing, just call @p2jMap.get(pname);@?
This one is c... Constantin Asofiei

08:49 AM Feature #1634: implement full native library (.so or DLL) support

> When I changed the FILE-NAME and NAME implementation for external procedures, I discovered that these attributes an... Eugenie Lyzenko

07:36 AM Feature #1634: implement full native library (.so or DLL) support

Eugenie Lyzenko wrote:
> I do not understand why we need the changes here? If canonicalize() now works as before any... Constantin Asofiei