FWD » Core Development » Base Language

06/25/2014

03:44 PM Feature #2232: finish testing the wrapped mode using the web services exposed by the testing server

Marius Gligor wrote:
> Having these fixes all tested web services are working in P2J.
The update looks OK. For thi... Constantin Asofiei

11:16 AM Feature #2232: finish testing the wrapped mode using the web services exposed by the testing server

Debugging the SimpleOperations converted web service test case in P2J an AxisFault is throw in WebServiceHelper line ... Marius Gligor

08:56 AM Feature #2287 (Closed): implement missing type conversion for POLY cases in data type wrapper ass...

Greg Shah

02:40 AM Feature #2287 (Review): implement missing type conversion for POLY cases in data type wrapper ass...

Passed MAJIC regression tests. Passed the customer server conversion test.
Committed revision 10551. Marius Gligor

08:56 AM Feature #2050 (Closed): ATTR_POLY/METH_POLY used as rvalue or in expressions

Greg Shah

02:41 AM Feature #2050 (Review): ATTR_POLY/METH_POLY used as rvalue or in expressions

Passed MAJIC regression tests. Passed the customer's server conversion test.
Committed revision 10551. Marius Gligor

07:09 AM Bug #2197: fix the error message list cleanup when NO-ERROR mode is enabled and ERROR-STATUS:ERRO...

Take a look at first NO-ERROR implementation please. I want to understand if I am on a right way. Also note at the pl... Vadim Gindin

09:00 PM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

Code Review 0624a
The merge looks fine. Greg Shah

08:52 PM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

Find a testcase that fails regularly and use the test XML file or the results details to see the recreate. Manually ... Greg Shah

06/24/2014

07:54 PM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

Merged with last revision.
I have still a problem with regression testing. ~ 100 tests have been failed by timeout... Evgeny Kiselev

11:42 AM Feature #2208 (Closed): create a java application running web services for testing purposes

Marius has done a code review and he notes that the code is acceptable and that this task can be closed.
Please do... Greg Shah

11:34 AM Feature #2232: finish testing the wrapped mode using the web services exposed by the testing server

Today I started to do a code review on issue #2208
1. I did a checkout of testcases project and I have the testcas... Marius Gligor

06/23/2014

03:44 PM Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

Yes. All that remains is to commit the changes into remote repository and notify the team. Marius Gligor

03:43 PM Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

Please check in and distribute you update.
If I understand properly, both #2287 and #2050 can be closed now, right? Greg Shah

03:12 PM Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

MAJIC conversion regression test passed. Marius Gligor

12:42 PM Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

The customer's server conversion passed. I have the same expected differences.
I'm going to prepare and start a MAJI... Marius Gligor

11:37 AM Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

Code Review 0623a
Your new version is much better. The code looks good.
If the customer server conversion test... Greg Shah

07:56 AM Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

1. Done.
2. Doesn't work should be: ... Marius Gligor

11:09 AM Feature #2232: finish testing the wrapped mode using the web services exposed by the testing server

No I didn't do any code review for #2208 so far. Marius Gligor

10:44 AM Feature #2232: finish testing the wrapped mode using the web services exposed by the testing server

Have you reviewed #2208 already? If so, can we close it or does that code need some changes? Greg Shah

10:42 AM Feature #2232: finish testing the wrapped mode using the web services exposed by the testing server

As part of this task, please do prepare code changes that resolve any found issues. Greg Shah

10:39 AM Feature #2232: finish testing the wrapped mode using the web services exposed by the testing server

1. I used the following existing test case (wsdl-test1.p) to check the RESPONSE on 4GL when call a SOAP WS in wrapped... Marius Gligor

06/20/2014

03:59 PM Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

Code Review 0619a
1. Line 1132 of expressions.rules has a typo. @uppercase = (cls == "caharacter" or cls == "long... Greg Shah

09:56 AM Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

I have no other questions regarding conversion. I tried to do just punctual changes in rules and keep no changes on o... Marius Gligor

09:47 AM Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

Marius, I've reviewed your previous several notes on the matter, and your reasoning and approach with respect to @toU... Eric Faulhaber

09:03 AM Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

Eric will be reviewing and responding to this WHERE clause issue.
One thought: in the end, if your changes only ch... Greg Shah

08:03 AM Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

I've restarted an new customer server conversion using the latest changes. The full conversion took 5 hours and 21 mi... Marius Gligor

07:00 AM Bug #2293: Fixing an unfixed extent output parameter causes an error

> I copied the throw statement together with other code from OutputExtentParameter. The exception is there to catch t... Constantin Asofiei

02:59 AM Feature #2232 (WIP): finish testing the wrapped mode using the web services exposed by the testin...

Marius Gligor

06/19/2014

06:27 PM Bug #2293: Fixing an unfixed extent output parameter causes an error

Constantin Asofiei wrote:
> Review for 0618a.zip:
> * fix the copyright date in annotations/output_parameters.rules... Hynek Cihlar

04:41 AM Bug #2293: Fixing an unfixed extent output parameter causes an error

Review for 0618a.zip:
* fix the copyright date in annotations/output_parameters.rules and convert/output_parameters.... Constantin Asofiei

08:24 AM Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

The rules for DYNAMIC-FUNCTION in WHERE expressions are like on any other expressions like IF for example.
So the ty... Marius Gligor

04:46 AM Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

I created and converted a small test case using a WHERE clause and a DYNAMIC-FUNCTION operand.... Marius Gligor

03:19 AM Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

Here is the analyse of unexpected differences from the customer's server conversion. The affected generated files are... Marius Gligor

06/18/2014

04:12 PM Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

Here the other differences in generated Java code. The first two are OK because we have a NOT-EQ expression.
The thi... Marius Gligor

03:40 PM Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

Yes I know that and will do. In the mean time I changed the Apenndo0.java class by hand and I did a rebuild of the pr... Marius Gligor

03:26 PM Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

Marius Gligor wrote:
> Unfortunately the converted code was not compiled:
It's not just a matter for the code to co... Constantin Asofiei

03:24 PM Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

On the customer's Server conversion I saved the initial succeeded conversion.
Today I applied my changes on P2J proj... Marius Gligor

10:19 AM Bug #2293: Fixing an unfixed extent output parameter causes an error

I have also checked-in all test cases for the above changes. See testcases/uast/output_var_param.p and testcases/uast... Hynek Cihlar

10:01 AM Bug #2293: Fixing an unfixed extent output parameter causes an error

*The attached file provides*
* fix for output extent parameter dimension not initialized to unknown... Hynek Cihlar

08:46 AM Bug #2197: fix the error message list cleanup when NO-ERROR mode is enabled and ERROR-STATUS:ERRO...

Vadim Gindin wrote:
> I've updated tests as you asked. In cases when actual error is raised there are no possibility... Constantin Asofiei

04:40 AM Bug #2197: fix the error message list cleanup when NO-ERROR mode is enabled and ERROR-STATUS:ERRO...

I've updated tests as you asked. In cases when actual error is raised there are no possibility to hardcode it to the ... Vadim Gindin

09:14 PM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

Regression testing is finished. But atm I've found quite a lot timeout failed tests:
50 in gso_tests
42 in tc_tests... Evgeny Kiselev

06/17/2014

01:32 PM Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

For now, please change @zip64Mode="always"@ to @zip64Mode="as-needed"@. This change will be checked in soon, but for... Greg Shah

12:50 PM Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

I started the customer's server conversion on my workstation. The conversion took 4 hours 58 minutes and 41 seconds.
... Marius Gligor

08:08 AM Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

There is only one P2J repo, so you are OK. Greg Shah

07:30 AM Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

I started the customer server conversion on my workstation as is described on #2299.
For P2J I used the current deve... Marius Gligor

07:20 AM Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

Code Review 0617a
The changes are good.
Is there anything else to do for this task (or for #2050)? If not, the... Greg Shah

03:53 AM Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

Using ExpressionConversionWorker the rule in annotations/functions.rules became more simple and cover also the case o... Marius Gligor

08:48 AM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

Greg Shah wrote:
> Constantin: do you have any concerns with my changes (or with Evgeny's)?
The changes look OK to me. Constantin Asofiei

07:16 AM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

Constantin: do you have any concerns with my changes (or with Evgeny's)? Greg Shah

07:15 AM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

Code Review 0616a
I'm OK with the changes. Please run both conversion and runtime regression testing. If you hav... Greg Shah

08:07 PM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

This update merged with ges_upd20140612a.zip
Fixed issues from note 28.
Also I've decided to remove unnecessary cal... Evgeny Kiselev

06:05 AM Bug #2197: fix the error message list cleanup when NO-ERROR mode is enabled and ERROR-STATUS:ERRO...

Vadim Gindin wrote:
> 1. The main conclusion is there are no stacking behavior with error lists. I.e. the error list... Constantin Asofiei

06/16/2014

03:29 PM Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

In regard to how to setup and run conversion on the server project, please see #2299. Read that task history careful... Greg Shah

03:23 PM Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

Code Review 0616a
The approach is much better. It is almost done now. The final issue is this code (from annotat... Greg Shah

01:34 PM Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

Constantin, please could you offer me more details? What is server project, where is located, how to do the test? Marius Gligor

12:42 PM Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

Marius, when regression testing this update, make sure to check the converted sources for the server project, if ther... Constantin Asofiei

11:38 AM Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

Here are the new changes related to this issue and #2050.
1. I created a new annotation "poly_wrapper" to be used ... Marius Gligor

12:28 PM Bug #2293: Fixing an unfixed extent output parameter causes an error

Greg Shah wrote:
> Eric: is there a reason not to allow this to naturally support write use cases?
It's not neede... Eric Faulhaber

11:24 AM Bug #2293: Fixing an unfixed extent output parameter causes an error

Eric: is there a reason not to allow this to naturally support write use cases? Greg Shah

08:21 AM Bug #2293: Fixing an unfixed extent output parameter causes an error

I didn't find any write-usages myself and from the code it wasn't clear whether it was planned to use the constructor... Hynek Cihlar

03:02 AM Feature #2050 (WIP): ATTR_POLY/METH_POLY used as rvalue or in expressions

Marius Gligor

08:23 PM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

Greg Shah wrote:
> Please check if this is working. Does this resolve your problem? Does this work for the genera... Evgeny Kiselev

06/14/2014

04:48 PM Bug #2293: Fixing an unfixed extent output parameter causes an error

Constantin Asofiei wrote:
> This suggests that the FieldReference instance created via that c'tor is read-only, and ... Eric Faulhaber

11:42 AM Bug #2293: Fixing an unfixed extent output parameter causes an error

Hynek Cihlar wrote:
> What I am trying to say is that if you construct the @FieldReference@ with any "non-indexed" c... Constantin Asofiei

10:49 AM Bug #2293: Fixing an unfixed extent output parameter causes an error

Greg Shah wrote:
> The actual reading (and writing if necessary) is deferred until the runtime code needs to access ... Hynek Cihlar

06:44 AM Bug #2197: fix the error message list cleanup when NO-ERROR mode is enabled and ERROR-STATUS:ERRO...

I made some tests and committed them into @/errlist@ subfolder. There are also your tests there. Most of my tests con... Vadim Gindin

06/13/2014

02:05 PM Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

> Do you think that is a good idea to use another annotation instead of "chp_wrapper" for this case?
Yes, it will ... Greg Shah

02:02 PM Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

When my rule from annotations/functions.rules is executed the return type of the function is not yet known. I think t... Marius Gligor

01:51 PM Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

Code Review 0613b
This code in builtin_funcs.rules is definitely not right:... Greg Shah

12:34 PM Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

Exactly right. The @on="false"@ is a way to make the contained rule part of the @else@ branch of the conditional. Greg Shah

12:33 PM Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

I did the changes in the rules. Please let me know if my changes are OK. Marius Gligor

12:02 PM Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

OK. Now I understand. The real structure was:... Marius Gligor

11:40 AM Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

This is my first issue on which I'm working and require to define new rules.
I have one question please regarding ru... Marius Gligor

10:53 AM Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

Code Review 0613a
1. The datetimetz imports have been expanded.
2. In functions.rules, this code is too restric... Greg Shah

09:45 AM Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

Here is the attachement. Marius Gligor

09:45 AM Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

Here are the latest changes that I made on this issue.
1. I implemented a rule to wrap the result of a DYNAMIC-FUN... Marius Gligor

10:21 AM Bug #2293: Fixing an unfixed extent output parameter causes an error

The idea of the FieldReference is to allow the delegation of reading/writing a database field to runtime code that is... Greg Shah

04:32 AM Bug #2293: Fixing an unfixed extent output parameter causes an error

Actually, setting the sizer in the constructor @FieldReference(Database, Class, String)@ makes sense. So the question... Hynek Cihlar

04:11 AM Bug #2293: Fixing an unfixed extent output parameter causes an error

In the constructor @FieldReference(Database, Class<?>, String)@ the setter is not set and the sizer is. This is suspi... Hynek Cihlar

06/12/2014

09:07 AM Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

Code Review 0612a
The changes look fine.
> The only solution remains to change the conversion and to wrap the r... Greg Shah

06:15 AM Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

Unfortunately my idea to fix the note #13 does not work. Using the following test case:... Marius Gligor

09:02 AM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

I think our approach to explicit terminal stream processing has been poor in the past. We "took advantage" of using ... Greg Shah

06:12 AM Bug #2197: fix the error message list cleanup when NO-ERROR mode is enabled and ERROR-STATUS:ERRO...

Vadim Gindin wrote:
> Current implementation for me does not seems clear. Why don't we use a Stack structure to main... Constantin Asofiei

05:11 AM Bug #2197: fix the error message list cleanup when NO-ERROR mode is enabled and ERROR-STATUS:ERRO...

It seems we need not only additional errors list. We also need additional flags like @error@, @pending@ and some othe... Vadim Gindin

06/11/2014

07:19 PM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

I need to determine Terminal stream. But got a problem:... Evgeny Kiselev

10:02 AM Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

Code Review 0611a
The changes look good.
> 2. Regarding the RAW type on the customer's Linux server I've got th... Greg Shah

08:24 AM Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

1. I've fixed the issues from your code review.
2. Regarding the RAW type on the customer's Linux server I've got ... Marius Gligor

06/10/2014

01:45 PM Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

Code Review 0610a
It looks very good. Some notes:
1. For the raw(BDT) constructor, please check if a properly ... Greg Shah

11:35 AM Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

Today I did tests using test cases like Constantin suggested. The results are the same as for message cases.
The exp... Marius Gligor

11:02 AM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

> > 5. The @GenericFrame.view(FrameElement[] data)@ use of @cacheWidgetIDs()@ seems like it will never do anything. ... Greg Shah

08:26 PM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

Greg Shah wrote:
> Code Review 0607a
>
> 1. @GenericFrame@ is missing a history entry.
> 2. Can @GenericFrame.re... Evgeny Kiselev

06/09/2014

12:16 PM Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

Marius Gligor wrote:
> message v1 + dynamic-function("f2").
> message v1 - dynamic-function("f2").
> message dynam... Constantin Asofiei

12:02 PM Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

For DynamicOps.plus() and DynamicOps.minus() implementation I'm using the following test case:
... Marius Gligor

11:33 AM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

Code Review 0607a
1. @GenericFrame@ is missing a history entry.
2. Can @GenericFrame.refreshWidgets()@ could us... Greg Shah

08:58 AM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

Fixed all issues from note #22, #23, #24
testcases:... Evgeny Kiselev

06/06/2014

01:29 PM Feature #2232: finish testing the wrapped mode using the web services exposed by the testing server

In wrapped mode, the request and the response are both treated as a string with the serialized XML contents of the SO... Constantin Asofiei

12:50 PM Bug #2197: fix the error message list cleanup when NO-ERROR mode is enabled and ERROR-STATUS:ERRO...

Vadim, regarding Q2 in note 4: as Greg mentioned, we can't clean the list too early and the right place to me looks l... Constantin Asofiei

12:28 PM Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

I would really like to avoid such a flag. The reason is simple: I want the wrapper classes (BDT subclasses) to limit... Greg Shah

11:21 AM Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

regarding "dynamic" flag I think that is better to set on this call ControlFlowOps.invokeDynamicFunctionImpl Marius Gligor

11:20 AM Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

Marius Gligor wrote:
> In order to know if a BDT is the result of a DYNAMIC-FUNCTION call I have an idea.
Your idea... Constantin Asofiei

11:00 AM Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

Here are the latest changes that I did so far for other BDT's like handle, longchar, raw, memptr, date, raw etc.
I... Marius Gligor

06/04/2014

10:02 AM Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

Excellent point/question.
Marius: please do implement the missing functionality in the util/DynamicOps class as ... Greg Shah

09:56 AM Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

Greg: will the DynamicOps APIs be implemented with this task or another? Constantin Asofiei

06/03/2014

02:41 PM Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

Code Review 0603b
The changes look good. Greg Shah

12:34 PM Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

The archive contains the implementation of decimal wrapper type conversion for POLY cases. Marius Gligor

11:29 AM Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

Until to fix the conversion issue I found a temporary solution to test the behaviour on P2J by swap the _isEqual oper... Marius Gligor

10:05 AM Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

Code Review 0603a
The changes look good. I'm glad you were able to fix the problem without extra conversion-time ... Greg Shah

09:55 AM Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

I haven't reviewed your changes yet. But while you were editing the code, I wrote this:
> When this expression: _is... Greg Shah

09:30 AM Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

I added new BDT types for conversion to a logical value.
I found and implemented the conversion rules for date and h... Marius Gligor

09:09 AM Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

I added the line in my configuration file and now works properly.
Thanks Marius Gligor

08:09 AM Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

Marius Gligor wrote:
> I have no such line in my p2j.cfg.xml.
> My configuration file is for <!-- Majic-specific P2... Constantin Asofiei

08:05 AM Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

I have no such line in my p2j.cfg.xml.
My configuration file is for <!-- Majic-specific P2J main configuration -->
Marius Gligor

07:23 AM Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

Marius Gligor wrote:
> 2. Another problem that I found is related to initial values for P4G primitives.
I think thi... Constantin Asofiei

07:17 AM Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

1. Working to add more BDT types for conversion inside the logical class and I found a blocked issue.
I have the fo... Marius Gligor

05:04 AM Feature #1630 (Closed): implement support for UNBUFFERED in I/O statements

Greg Shah

08:12 PM Feature #1630: implement support for UNBUFFERED in I/O statements

Committed to bzr rev. 10542. Evgeny Kiselev

06/02/2014

02:11 PM Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

Code Review 0602b
The changes look good. I assume you are working on the same changes for the other BDT types. Greg Shah

12:20 PM Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

1. I've started to work on this issue by executing the provided test case on P4G environment and I found the followin... Marius Gligor

02:01 AM Feature #2287 (WIP): implement missing type conversion for POLY cases in data type wrapper assign...

Marius Gligor

12:10 PM Bug #2288 (Closed): incorrect conversion and results for unknown value comparisons

Update 0421a passed runtime regression testing and was committed to bzr rev. 10523 (although in the commit message I ... Eric Faulhaber

08:36 AM Feature #2311 (Closed): rewrite parsing of handle chains and other misc parser changes

Greg Shah

06:40 AM Feature #2311 (Review): rewrite parsing of handle chains and other misc parser changes

Greg Shah wrote:
> Excellent! Please check it in and distribute it.
Committed to bzr rev 10539. The task can be clo... Constantin Asofiei

06:24 AM Feature #2311: rewrite parsing of handle chains and other misc parser changes

Excellent! Please check it in and distribute it. Greg Shah

06:34 AM Feature #1630: implement support for UNBUFFERED in I/O statements

Great! Please do commit it and distribute it. Greg Shah

08:08 PM Feature #1630: implement support for UNBUFFERED in I/O statements

Update @evk_upd20140528a.zip@ has passed regression testing and ready to commit. Evgeny Kiselev

06/01/2014

08:41 AM Feature #2311: rewrite parsing of handle chains and other misc parser changes

0531b.passed conversion testing - MAJIC has 1 case and the server project has 2 cases where RecordBuffer.start/EndBat... Constantin Asofiei

05/31/2014

03:31 PM Feature #2311: rewrite parsing of handle chains and other misc parser changes

Greg Shah wrote:
> What do you suggest for the assignment stmts issue?
The fix in the end was pretty simple - I jus... Constantin Asofiei

09:09 PM Feature #1630: implement support for UNBUFFERED in I/O statements

Greg Shah wrote:
> Code Review 0528a
>
> The code looks good.
>
> Have you finished testing all of your testca... Evgeny Kiselev

05/30/2014

07:39 PM Feature #2311: rewrite parsing of handle chains and other misc parser changes

What do you suggest for the assignment stmts issue? We can defer it, but we may just hit it in future code. If that... Greg Shah

05:56 PM Feature #2311: rewrite parsing of handle chains and other misc parser changes

Greg Shah wrote:
> OK, then go ahead, check in and distribute it.
Committed to bzr rev 10538.
As a reminder, the... Constantin Asofiei

05:40 PM Feature #2311: rewrite parsing of handle chains and other misc parser changes

OK, then go ahead, check in and distribute it. Greg Shah

05:38 PM Feature #2311: rewrite parsing of handle chains and other misc parser changes

Greg Shah wrote:
> You're confident that the handle unwrapping changes are safe?
MAJIC uses only @unwrapWidget@, an... Constantin Asofiei

05:01 PM Feature #2311: rewrite parsing of handle chains and other misc parser changes

You're confident that the handle unwrapping changes are safe? Greg Shah

04:52 PM Feature #2311: rewrite parsing of handle chains and other misc parser changes

Greg Shah wrote:
> I am fine with the changes. At this point, is there anything left to do?
Conversion testing pas... Constantin Asofiei

04:41 PM Feature #2311: rewrite parsing of handle chains and other misc parser changes

Code Review 0530b
I am fine with the changes. At this point, is there anything left to do? Greg Shah

04:25 PM Feature #2311: rewrite parsing of handle chains and other misc parser changes

OK, the attached version contains this:
# @progress.g@ history fixed
# @methods_attributes.rules@ - was added a not... Constantin Asofiei

04:05 PM Feature #2311: rewrite parsing of handle chains and other misc parser changes

> Thus, is there anything else I should do at this point? Because I doubt the COM_INVOCATION/COM_METHOD/COM_PARAMETER... Greg Shah

03:29 PM Feature #2311: rewrite parsing of handle chains and other misc parser changes

Constantin Asofiei wrote:
> What I think ECW needs is just some simplifications of the cases when COLON nodes are in... Constantin Asofiei

03:01 PM Feature #2311: rewrite parsing of handle chains and other misc parser changes

Constantin Asofiei wrote:
> > 1. The com_invocation/com_method processing in methods_attributes.rules is removed. I... Constantin Asofiei

02:17 PM Feature #2311: rewrite parsing of handle chains and other misc parser changes

> BTW, are there other POLY tests, beside the ones at #2050?
Yes, dynamic_function_context_analysis.p is useful to... Greg Shah

01:46 PM Feature #2311: rewrite parsing of handle chains and other misc parser changes

Greg Shah wrote:
> Code Review 0526f
>
> Generally, I am happy with the changes. The methods_attributes.rules is ... Constantin Asofiei

08:11 AM Feature #1630: implement support for UNBUFFERED in I/O statements

Code Review 0528a
The code looks good.
Have you finished testing all of your testcases? If it is fully working... Greg Shah

08:10 PM Feature #1630: implement support for UNBUFFERED in I/O statements

>1. Please merge the code up to the latest P2J level in bzr (Stream.java is missing changes).
>2. In both classes, p... Evgeny Kiselev

05/29/2014

05:26 PM Feature #2311: rewrite parsing of handle chains and other misc parser changes

Code Review 0526f
Generally, I am happy with the changes. The methods_attributes.rules is so much simpler now. Ni... Greg Shah

05:38 AM Feature #2311: rewrite parsing of handle chains and other misc parser changes

A remainder issue is an investigation of the @annotations/assignment_style_stmt_rewriting.rules@ file: this will spli... Constantin Asofiei

05/28/2014

02:38 PM Bug #2293: Fixing an unfixed extent output parameter causes an error

Constantin Asofiei wrote:
> OK, this is a conversion problem, if the fix is not trivial leave it for another time.
... Hynek Cihlar

12:43 PM Bug #2293: Fixing an unfixed extent output parameter causes an error

Hynek Cihlar wrote:
> Constantin Asofiei wrote:
> > Not sure if you are aware, table fields can not be set as dynam... Constantin Asofiei

12:35 PM Bug #2293: Fixing an unfixed extent output parameter causes an error

Constantin Asofiei wrote:
> Not sure if you are aware, table fields can not be set as dynamic extent in 4GL. How doe... Hynek Cihlar

11:52 AM Bug #2293: Fixing an unfixed extent output parameter causes an error

Hynek Cihlar wrote:
> Is the conversion of output extent fields supposed to work? When converting a temp-table field... Constantin Asofiei

11:45 AM Bug #2293: Fixing an unfixed extent output parameter causes an error

Is the conversion of output extent fields supposed to work? When converting a temp-table field passed as output param... Hynek Cihlar

10:36 AM Bug #2293: Fixing an unfixed extent output parameter causes an error

By the way, we can remove the need to call @setParameter@ from the converted code completely. For example, when @exte... Hynek Cihlar

01:45 PM Feature #1630: implement support for UNBUFFERED in I/O statements

Code Review 0523a
The changes look good. I have some minor comments and questions:
1. Please merge the code up to ... Greg Shah

12:24 PM Feature #2311: rewrite parsing of handle chains and other misc parser changes

The ges_upd20140428a.zip (amongs other changes) rewrites the AST tree for a chaining in a handle, com-handle or objec... Constantin Asofiei

12:09 PM Feature #2311 (Closed): rewrite parsing of handle chains and other misc parser changes

Constantin Asofiei

05/27/2014

01:59 PM Bug #2293: Fixing an unfixed extent output parameter causes an error

Constantin Asofiei wrote:
> Hynek,
>
> The approach loosk good, just a question about how the converted code looks: ... Hynek Cihlar

11:59 AM Bug #2293: Fixing an unfixed extent output parameter causes an error

Hynek,
The approach loosk good, just a question about how the converted code looks: if we have @integer[] p = extp... Constantin Asofiei