FWD » Core Development » Base Language

07/18/2014

06:29 PM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

ok Evgeny Kiselev

10:13 AM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

Very good point. OK, I guess it is back in.
Evgeny: please make this change and the final changes to finish the u... Greg Shah

09:50 AM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

Greg Shah wrote:
> I had removed that code when I changed progress.g to match the strings "term" or "terminal" as th... Constantin Asofiei

09:01 AM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

I had removed that code when I changed progress.g to match the strings "term" or "terminal" as the KW_TERM. I prefer... Greg Shah

05:48 AM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

Greg Shah wrote:
> Constantin, what do you think?
The changes look OK, except for @StreamFactory.openFileStream@, w... Constantin Asofiei

07/17/2014

05:24 PM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

Code Review 0717a
Generally the changes look good to me.
Constantin, what do you think?
Some feedback:
... Greg Shah

03:36 PM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

Finally I've found a problem. Please review it.
This is dirty fix and not finally, but it have passed regression tes... Evgeny Kiselev

03:31 PM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

Please post your latest findings, your latest code and your testing results as they stand. Greg Shah

02:20 AM Bug #2293: Fixing an unfixed extent output parameter causes an error

Hynek Cihlar wrote:
> The attached hc_upd20140715a.zip resolves the issue related to the conversion of non-extent ta... Constantin Asofiei

07/16/2014

05:37 PM Bug #2293: Fixing an unfixed extent output parameter causes an error

The attached hc_upd20140715a.zip resolves the issue related to the conversion of non-extent table fields passed to ou... Hynek Cihlar

07/15/2014

03:43 AM Feature #1634: implement full native library (.so or DLL) support

Fixed @SESSION:TEMP-DIRECTORY@ - it needs to check the client-side, not the server-side. The other case where java.l... Constantin Asofiei

07/13/2014

05:49 PM Bug #2293 (Closed): Fixing an unfixed extent output parameter causes an error

Greg Shah

03:33 PM Bug #2293: Fixing an unfixed extent output parameter causes an error

The attached 0713a is 0710a plus up to date bzr check-ins. 0713a checked in to bzr revision 10568. Hynek Cihlar

10:33 AM Bug #2293: Fixing an unfixed extent output parameter causes an error

If I understand correctly, no merge is needed and you are ready to check it in.
You can go ahead with the check in... Greg Shah

05:49 PM Bug #2292 (Closed): Fix error handling when unfixed extent passed to fixed extent input parameter

Greg Shah

03:35 PM Bug #2292 (Feedback): Fix error handling when unfixed extent passed to fixed extent input paramet...

Hynek Cihlar

03:34 PM Bug #2292: Fix error handling when unfixed extent passed to fixed extent input parameter

Fixed by #2293. Hynek Cihlar

07/12/2014

06:23 PM Bug #2293: Fixing an unfixed extent output parameter causes an error

Conversion and runtime tests passed. During conversion test no differences in generated code were reported. Hynek Cihlar

07/11/2014

10:04 AM Bug #2338: fix _MSG function

Vadim, the logic looks good. The only part I'm not comfortable with is the NumberedException changes: you are keepin... Constantin Asofiei

07:50 AM Bug #2338 (WIP): fix _MSG function

Greg Shah

02:02 AM Bug #2338: fix _MSG function

Here is the first version of implementation. Now I'm working on QUIT condition and recordOrShowError (errors without ... Vadim Gindin

12:13 AM Bug #2338: fix _MSG function

Constantin Asofiei wrote:
> This article states that warnings are logged too: http://knowledgebase.progress.com/arti... Vadim Gindin

11:58 PM Bug #2338: fix _MSG function

From #1632 _MSG() is built-in undocumented function.
Constantin Asofiei wrote:
> Vadim Gindin wrote:
> > I ran the _... Vadim Gindin

10:57 PM Bug #2338 (Closed): fix _MSG function

Vadim Gindin

07:49 AM Bug #2197 (Closed): fix the error message list cleanup when NO-ERROR mode is enabled and ERROR-ST...

Greg Shah

07/10/2014

10:43 AM Bug #2197: fix the error message list cleanup when NO-ERROR mode is enabled and ERROR-STATUS:ERRO...

Vadim: please open a new task to resolve the remaining issue (_MSG problems). Make sure that Constantin and myself a... Greg Shah

07/09/2014

03:46 PM Bug #2197: fix the error message list cleanup when NO-ERROR mode is enabled and ERROR-STATUS:ERRO...

Committed to bzr. Rev #10565 Vadim Gindin

03:53 AM Bug #2293: Fixing an unfixed extent output parameter causes an error

Hynek Cihlar wrote:
> Please review.
The changes look good. Go ahead with conversion and runtime testing. Constantin Asofiei

08:12 PM Bug #2293: Fixing an unfixed extent output parameter causes an error

The attached change set provides the following in addition to the previous change set:
* fixed the formatting issu... Hynek Cihlar

08:13 PM Bug #2292: Fix error handling when unfixed extent passed to fixed extent input parameter

This issue is fixed by #2293. Once #2293 is closed, this can be closed with Nofix resolution. Hynek Cihlar

07/08/2014

05:35 AM Bug #2197: fix the error message list cleanup when NO-ERROR mode is enabled and ERROR-STATUS:ERRO...

Vadim Gindin wrote:
> Corrected update for note 8.
If all your tests work OK, go ahead and release it. Constantin Asofiei

03:04 AM Bug #2197: fix the error message list cleanup when NO-ERROR mode is enabled and ERROR-STATUS:ERRO...

Corrected update for note 8. Vadim Gindin

07/07/2014

03:41 AM Bug #2197: fix the error message list cleanup when NO-ERROR mode is enabled and ERROR-STATUS:ERRO...

Vadim Gindin wrote:
> I ran the _msg_test.p_ and _msg_test2.p_ several times and I found that there are no stack sco... Constantin Asofiei

02:43 AM Bug #2197: fix the error message list cleanup when NO-ERROR mode is enabled and ERROR-STATUS:ERRO...

Vadim Gindin wrote:
> Here is the current update, that passed regression tests. Only _gso_ctrlc_3way_tests_ tests ar... Constantin Asofiei

03:41 AM Feature #1632: implement _MSG() undocumented built-in function

This article states that warnings are logged too: http://knowledgebase.progress.com/articles/Article/P82729
Also, ... Constantin Asofiei

03:28 AM Feature #1632: implement _MSG() undocumented built-in function

Vadim Gindin wrote:
> I ran the _msg_test.p_ and _msg_test2.p_ several times and I found that there are no stack sco... Constantin Asofiei

02:17 AM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

About note 42: what you are seeing are unnamed input streams (which are opened via a @OUTPUT TO ...@ and @INPUT FROM... Constantin Asofiei

07/05/2014

11:53 AM Bug #2197: fix the error message list cleanup when NO-ERROR mode is enabled and ERROR-STATUS:ERRO...

I ran the _msg_test.p_ and _msg_test2.p_ several times and I found that there are no stack scope at all (stack scope ... Vadim Gindin

07/04/2014

03:40 PM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

Maybe problem in wrong conversion or unnecessary stream redirection.
I've looked on @text.p@ source code and didn't ... Evgeny Kiselev

02:53 PM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

After analyzing converted source code, I've found next difference:
without updates code:
@UnnamedStreams.assignOut(... Evgeny Kiselev

03:32 PM Bug #2197: fix the error message list cleanup when NO-ERROR mode is enabled and ERROR-STATUS:ERRO...

Here is the current update, that passed regression tests. Only _gso_ctrlc_3way_tests_ tests are failed (6/6). I'm not... Vadim Gindin

07/03/2014

12:02 PM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

I've found the problem.
!failed1.png!
As you can see on screen shots, there is no border around menus.
One the left ... Evgeny Kiselev

07/02/2014

05:49 AM Feature #2232 (Closed): finish testing the wrapped mode using the web services exposed by the tes...

Greg Shah

04:50 AM Feature #2232: finish testing the wrapped mode using the web services exposed by the testing server

No regression tests are mandatory for this changes.
Committed revision 10557. Marius Gligor

04:34 AM Feature #2232: finish testing the wrapped mode using the web services exposed by the testing server

You can release the 0630a.zip update, the changes don't affect MAJIC runtime. Constantin Asofiei

03:38 AM Bug #2197: fix the error message list cleanup when NO-ERROR mode is enabled and ERROR-STATUS:ERRO...

Review for 0701a.zip:
* please move ErrorManager.isPendingError back to line 1338
* the ErrorManager.setError APIs ... Constantin Asofiei

07/01/2014

05:44 PM Bug #2197: fix the error message list cleanup when NO-ERROR mode is enabled and ERROR-STATUS:ERRO...

You're right. Thank you I managed this error and prepared the next update, that contains NO-ERROR implementation with... Vadim Gindin

05:49 AM Bug #2197: fix the error message list cleanup when NO-ERROR mode is enabled and ERROR-STATUS:ERRO...

Vadim Gindin wrote:
> I'm trying to debug my current implementation and I faced with a problem during this process.... Constantin Asofiei

08:24 AM Bug #2293: Fixing an unfixed extent output parameter causes an error

Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > The attached set of changes resolves issues mentioned above. Plea... Hynek Cihlar

05:42 AM Bug #2293: Fixing an unfixed extent output parameter causes an error

Hynek Cihlar wrote:
> The attached set of changes resolves issues mentioned above. Please review.
* the @implements... Constantin Asofiei

06/30/2014

07:04 PM Bug #2293: Fixing an unfixed extent output parameter causes an error

The attached set of changes resolves issues mentioned above. Please review.
Note that there are two non-trivial ... Hynek Cihlar

03:05 PM Bug #2197: fix the error message list cleanup when NO-ERROR mode is enabled and ERROR-STATUS:ERRO...

About _noerr_diff_err.p_ It seems I made wrong conclusion. There are only one @silentErrorDisable@ right after @setCu... Vadim Gindin

10:13 AM Feature #2232: finish testing the wrapped mode using the web services exposed by the testing server

Tests and the Axis2-OutSoapHeader project has been committed in testcases revision 1161
Marius Gligor

09:54 AM Feature #2232: finish testing the wrapped mode using the web services exposed by the testing server

Marius, the update looks good. Please commit the tests and the Axis2-OutSoapHeader.zip to bzr. Constantin Asofiei

08:59 AM Feature #2232: finish testing the wrapped mode using the web services exposed by the testing server

The previous JAX-WS servcie used to test the SOAP header in response does not send the header OOB (Out Of Band)
P4G... Marius Gligor

06/27/2014

02:26 PM Feature #2232: finish testing the wrapped mode using the web services exposed by the testing server

Marius Gligor wrote:
> 3. The case of prefix must be the same as described in namspece. For example xmlns:SOAP-ENV="... Constantin Asofiei

12:03 PM Feature #2232: finish testing the wrapped mode using the web services exposed by the testing server

1. I've just tested the script on P4GL and I changed the test script. In 4GL the order of procedure parameters is man... Marius Gligor

11:34 AM Feature #2232: finish testing the wrapped mode using the web services exposed by the testing server

I will let Constantin do the code review.
My only question: it seems like our output has case differences from t... Greg Shah

11:23 AM Feature #2232 (Review): finish testing the wrapped mode using the web services exposed by the tes...

I created a simple JAX-WS using Netbeans IDE deployed on GlassFish AS which allow easily to insert a SOAP header.
<... Marius Gligor

08:07 AM Feature #2232: finish testing the wrapped mode using the web services exposed by the testing server

1. I fixed the issues form WebServiceHelper.
2. For FAULT test I used for example the wsdl_test1.p and I did a cha... Marius Gligor

06:56 AM Feature #2232: finish testing the wrapped mode using the web services exposed by the testing server

Review for 0626a.zip:
* when adding multi-line comments, use single-line commenting, not block commenting
* @WebSer... Constantin Asofiei

06/26/2014

01:57 PM Feature #2232: finish testing the wrapped mode using the web services exposed by the testing server

Bellow are the request and response SOAP messages on P4GL and P2J.
1. Industry standards supported by OpenEdge acc... Marius Gligor

06:21 AM Bug #2197: fix the error message list cleanup when NO-ERROR mode is enabled and ERROR-STATUS:ERRO...

Vadim Gindin wrote:
> Take a look at first NO-ERROR implementation please. I want to understand if I am on a right w... Constantin Asofiei

06/25/2014

03:44 PM Feature #2232: finish testing the wrapped mode using the web services exposed by the testing server

Marius Gligor wrote:
> Having these fixes all tested web services are working in P2J.
The update looks OK. For thi... Constantin Asofiei

11:16 AM Feature #2232: finish testing the wrapped mode using the web services exposed by the testing server

Debugging the SimpleOperations converted web service test case in P2J an AxisFault is throw in WebServiceHelper line ... Marius Gligor

08:56 AM Feature #2287 (Closed): implement missing type conversion for POLY cases in data type wrapper ass...

Greg Shah

02:40 AM Feature #2287 (Review): implement missing type conversion for POLY cases in data type wrapper ass...

Passed MAJIC regression tests. Passed the customer server conversion test.
Committed revision 10551. Marius Gligor

08:56 AM Feature #2050 (Closed): ATTR_POLY/METH_POLY used as rvalue or in expressions

Greg Shah

02:41 AM Feature #2050 (Review): ATTR_POLY/METH_POLY used as rvalue or in expressions

Passed MAJIC regression tests. Passed the customer's server conversion test.
Committed revision 10551. Marius Gligor

07:09 AM Bug #2197: fix the error message list cleanup when NO-ERROR mode is enabled and ERROR-STATUS:ERRO...

Take a look at first NO-ERROR implementation please. I want to understand if I am on a right way. Also note at the pl... Vadim Gindin

09:00 PM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

Code Review 0624a
The merge looks fine. Greg Shah

08:52 PM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

Find a testcase that fails regularly and use the test XML file or the results details to see the recreate. Manually ... Greg Shah

06/24/2014

07:54 PM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

Merged with last revision.
I have still a problem with regression testing. ~ 100 tests have been failed by timeout... Evgeny Kiselev

11:42 AM Feature #2208 (Closed): create a java application running web services for testing purposes

Marius has done a code review and he notes that the code is acceptable and that this task can be closed.
Please do... Greg Shah

11:34 AM Feature #2232: finish testing the wrapped mode using the web services exposed by the testing server

Today I started to do a code review on issue #2208
1. I did a checkout of testcases project and I have the testcas... Marius Gligor

06/23/2014

03:44 PM Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

Yes. All that remains is to commit the changes into remote repository and notify the team. Marius Gligor

03:43 PM Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

Please check in and distribute you update.
If I understand properly, both #2287 and #2050 can be closed now, right? Greg Shah

03:12 PM Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

MAJIC conversion regression test passed. Marius Gligor

12:42 PM Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

The customer's server conversion passed. I have the same expected differences.
I'm going to prepare and start a MAJI... Marius Gligor

11:37 AM Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

Code Review 0623a
Your new version is much better. The code looks good.
If the customer server conversion test... Greg Shah

07:56 AM Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

1. Done.
2. Doesn't work should be: ... Marius Gligor

11:09 AM Feature #2232: finish testing the wrapped mode using the web services exposed by the testing server

No I didn't do any code review for #2208 so far. Marius Gligor

10:44 AM Feature #2232: finish testing the wrapped mode using the web services exposed by the testing server

Have you reviewed #2208 already? If so, can we close it or does that code need some changes? Greg Shah

10:42 AM Feature #2232: finish testing the wrapped mode using the web services exposed by the testing server

As part of this task, please do prepare code changes that resolve any found issues. Greg Shah

10:39 AM Feature #2232: finish testing the wrapped mode using the web services exposed by the testing server

1. I used the following existing test case (wsdl-test1.p) to check the RESPONSE on 4GL when call a SOAP WS in wrapped... Marius Gligor

06/20/2014

03:59 PM Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

Code Review 0619a
1. Line 1132 of expressions.rules has a typo. @uppercase = (cls == "caharacter" or cls == "long... Greg Shah

09:56 AM Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

I have no other questions regarding conversion. I tried to do just punctual changes in rules and keep no changes on o... Marius Gligor

09:47 AM Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

Marius, I've reviewed your previous several notes on the matter, and your reasoning and approach with respect to @toU... Eric Faulhaber

09:03 AM Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

Eric will be reviewing and responding to this WHERE clause issue.
One thought: in the end, if your changes only ch... Greg Shah

08:03 AM Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

I've restarted an new customer server conversion using the latest changes. The full conversion took 5 hours and 21 mi... Marius Gligor

07:00 AM Bug #2293: Fixing an unfixed extent output parameter causes an error

> I copied the throw statement together with other code from OutputExtentParameter. The exception is there to catch t... Constantin Asofiei

02:59 AM Feature #2232 (WIP): finish testing the wrapped mode using the web services exposed by the testin...

Marius Gligor

06/19/2014

06:27 PM Bug #2293: Fixing an unfixed extent output parameter causes an error

Constantin Asofiei wrote:
> Review for 0618a.zip:
> * fix the copyright date in annotations/output_parameters.rules... Hynek Cihlar

04:41 AM Bug #2293: Fixing an unfixed extent output parameter causes an error

Review for 0618a.zip:
* fix the copyright date in annotations/output_parameters.rules and convert/output_parameters.... Constantin Asofiei

08:24 AM Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

The rules for DYNAMIC-FUNCTION in WHERE expressions are like on any other expressions like IF for example.
So the ty... Marius Gligor

04:46 AM Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

I created and converted a small test case using a WHERE clause and a DYNAMIC-FUNCTION operand.... Marius Gligor

03:19 AM Feature #2287: implement missing type conversion for POLY cases in data type wrapper assign method

Here is the analyse of unexpected differences from the customer's server conversion. The affected generated files are... Marius Gligor