Project

General

Profile

Activity

From 07/01/2014 to 07/30/2014

07/29/2014

01:55 PM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
Code Review 0728a
I am fine with the changes.
Greg Shah
01:11 PM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
Fixed everything from note 63 except conversion rules.
Evgeny Kiselev
09:28 AM Bug #2348 (Closed): unable to find internal procedure from database session trigger
Greg Shah
09:01 AM Bug #2348 (Review): unable to find internal procedure from database session trigger
0729a.zip was committed to bzr rev 10584. This can be closed. Constantin Asofiei
08:54 AM Bug #2348: unable to find internal procedure from database session trigger
Great! Please go ahead and release this as is. Thanks for the quick turnaround. Eric Faulhaber
03:43 AM Bug #2348 (WIP): unable to find internal procedure from database session trigger
This should fix your case. The problem was that the DB trigger invocation code was not pushing the trigger's externa... Constantin Asofiei

07/28/2014

02:50 PM Bug #2348: unable to find internal procedure from database session trigger
I've come across an unexpected stop condition invoking an internal procedure from a database session trigger in P2J:
...
Eric Faulhaber
02:47 PM Bug #2348 (Closed): unable to find internal procedure from database session trigger
Eric Faulhaber
11:02 AM Feature #2196: implement proper resource deletion of resources created in a procedure ran persistent
0728a.zip passed testing and was committed to bzr rev 10582.
Constantin Asofiei
10:40 AM Feature #2196: implement proper resource deletion of resources created in a procedure ran persistent
Code Review 0728a
The change looks good. I am actually very, very surprised we got away without this for so long.
Greg Shah
04:43 AM Feature #2196: implement proper resource deletion of resources created in a procedure ran persistent
Attached update fixes a case when a frame (for which its instantiating procedure is no longer alive) is implicitly hi... Constantin Asofiei

07/25/2014

04:08 PM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
> For this task I need to rollback changes which contains things related to #2345?
Yes, following the implementati...
Greg Shah
01:27 PM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
Greg Shah wrote:
> Evgeny: please follow this plan. Ask questions as needed.
Just want to clarify:
* For this tas...
Evgeny Kiselev
09:33 AM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
> P2J works incorrect in the case when the frame is already visible, and a widget (which is already displayed) has a ... Greg Shah
05:30 AM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
I don't think the problem is related to where the output is sent or if the unnamed output stream is redirected or not... Constantin Asofiei

07/24/2014

03:09 PM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
testcase:... Evgeny Kiselev
09:30 AM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
> what part from the case in note 21/22 is not working? I've tested with latest P2J and the code looks fine.
Evgen...
Greg Shah

07/23/2014

04:43 PM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
Some 4GL background first:
* in 4GL, application code uses statements to write or read data to/from streams
* these s...
Constantin Asofiei
09:59 AM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
> The deeper I dig, the more I think that if we merge the TerminalStream usage with the direct terminal, we will brea... Greg Shah
04:55 AM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
Greg, looking at the logic where TerminalStream was previously opened by StreamDaemon, I think it was only this case:... Constantin Asofiei

07/22/2014

05:45 PM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
Greg Shah wrote:
> My idea is to allow -1 to always be used to refer to the current terminal stream, even on the ser...
Evgeny Kiselev
12:09 PM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
> wouldn't it be better to let the client-side be aware of only one terminal stream? Better said, are we sure it is O... Greg Shah
03:20 AM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
Greg, I think we should double-check the @redir*.p@ tests from @testcases/uast@. More, the @ThinClient.currentStream... Constantin Asofiei

07/21/2014

07:12 PM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
fixed issues from note 53 Evgeny Kiselev
04:31 PM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
Code Review 0721a
1. In @StreamFactory.openFileStream()@ the call to @int id = work.obtain().rsb.openFileStream(fi...
Greg Shah
02:36 PM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
Added missing history entries.
Added Constantine changes from note 47
Fixed issues from note 46
Also I've found ...
Evgeny Kiselev

07/19/2014

06:08 PM Bug #2293: Fixing an unfixed extent output parameter causes an error
0715a passed the conversion test on the customer's server project - there were no differences in the generated code. ... Hynek Cihlar

07/18/2014

06:29 PM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
ok Evgeny Kiselev
10:13 AM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
Very good point. OK, I guess it is back in.
Evgeny: please make this change and the final changes to finish the u...
Greg Shah
09:50 AM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
Greg Shah wrote:
> I had removed that code when I changed progress.g to match the strings "term" or "terminal" as th...
Constantin Asofiei
09:01 AM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
I had removed that code when I changed progress.g to match the strings "term" or "terminal" as the KW_TERM. I prefer... Greg Shah
05:48 AM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
Greg Shah wrote:
> Constantin, what do you think?
The changes look OK, except for @StreamFactory.openFileStream@, w...
Constantin Asofiei

07/17/2014

05:24 PM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
Code Review 0717a
Generally the changes look good to me.
Constantin, what do you think?
Some feedback:
...
Greg Shah
03:36 PM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
Finally I've found a problem. Please review it.
This is dirty fix and not finally, but it have passed regression tes...
Evgeny Kiselev
03:31 PM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
Please post your latest findings, your latest code and your testing results as they stand. Greg Shah
02:20 AM Bug #2293: Fixing an unfixed extent output parameter causes an error
Hynek Cihlar wrote:
> The attached hc_upd20140715a.zip resolves the issue related to the conversion of non-extent ta...
Constantin Asofiei

07/16/2014

05:37 PM Bug #2293: Fixing an unfixed extent output parameter causes an error
The attached hc_upd20140715a.zip resolves the issue related to the conversion of non-extent table fields passed to ou... Hynek Cihlar

07/15/2014

03:43 AM Feature #1634: implement full native library (.so or DLL) support
Fixed @SESSION:TEMP-DIRECTORY@ - it needs to check the client-side, not the server-side. The other case where java.l... Constantin Asofiei

07/13/2014

05:49 PM Bug #2293 (Closed): Fixing an unfixed extent output parameter causes an error
Greg Shah
03:33 PM Bug #2293: Fixing an unfixed extent output parameter causes an error
The attached 0713a is 0710a plus up to date bzr check-ins. 0713a checked in to bzr revision 10568. Hynek Cihlar
10:33 AM Bug #2293: Fixing an unfixed extent output parameter causes an error
If I understand correctly, no merge is needed and you are ready to check it in.
You can go ahead with the check in...
Greg Shah
05:49 PM Bug #2292 (Closed): Fix error handling when unfixed extent passed to fixed extent input parameter
Greg Shah
03:35 PM Bug #2292 (Feedback): Fix error handling when unfixed extent passed to fixed extent input paramet...
Hynek Cihlar
03:34 PM Bug #2292: Fix error handling when unfixed extent passed to fixed extent input parameter
Fixed by #2293. Hynek Cihlar

07/12/2014

06:23 PM Bug #2293: Fixing an unfixed extent output parameter causes an error
Conversion and runtime tests passed. During conversion test no differences in generated code were reported. Hynek Cihlar

07/11/2014

10:04 AM Bug #2338: fix _MSG function
Vadim, the logic looks good. The only part I'm not comfortable with is the NumberedException changes: you are keepin... Constantin Asofiei
07:50 AM Bug #2338 (WIP): fix _MSG function
Greg Shah
02:02 AM Bug #2338: fix _MSG function
Here is the first version of implementation. Now I'm working on QUIT condition and recordOrShowError (errors without ... Vadim Gindin
12:13 AM Bug #2338: fix _MSG function
Constantin Asofiei wrote:
> This article states that warnings are logged too: http://knowledgebase.progress.com/arti...
Vadim Gindin
11:58 PM Bug #2338: fix _MSG function
From #1632 _MSG() is built-in undocumented function.
Constantin Asofiei wrote:
> Vadim Gindin wrote:
> > I ran the _...
Vadim Gindin
10:57 PM Bug #2338 (Closed): fix _MSG function
Vadim Gindin
07:49 AM Bug #2197 (Closed): fix the error message list cleanup when NO-ERROR mode is enabled and ERROR-ST...
Greg Shah

07/10/2014

10:43 AM Bug #2197: fix the error message list cleanup when NO-ERROR mode is enabled and ERROR-STATUS:ERRO...
Vadim: please open a new task to resolve the remaining issue (_MSG problems). Make sure that Constantin and myself a... Greg Shah

07/09/2014

03:46 PM Bug #2197: fix the error message list cleanup when NO-ERROR mode is enabled and ERROR-STATUS:ERRO...
Committed to bzr. Rev #10565 Vadim Gindin
03:53 AM Bug #2293: Fixing an unfixed extent output parameter causes an error
Hynek Cihlar wrote:
> Please review.
The changes look good. Go ahead with conversion and runtime testing.
Constantin Asofiei
08:12 PM Bug #2293: Fixing an unfixed extent output parameter causes an error
The attached change set provides the following in addition to the previous change set:
* fixed the formatting issu...
Hynek Cihlar
08:13 PM Bug #2292: Fix error handling when unfixed extent passed to fixed extent input parameter
This issue is fixed by #2293. Once #2293 is closed, this can be closed with Nofix resolution. Hynek Cihlar

07/08/2014

05:35 AM Bug #2197: fix the error message list cleanup when NO-ERROR mode is enabled and ERROR-STATUS:ERRO...
Vadim Gindin wrote:
> Corrected update for note 8.
If all your tests work OK, go ahead and release it.
Constantin Asofiei
03:04 AM Bug #2197: fix the error message list cleanup when NO-ERROR mode is enabled and ERROR-STATUS:ERRO...
Corrected update for note 8. Vadim Gindin

07/07/2014

03:41 AM Bug #2197: fix the error message list cleanup when NO-ERROR mode is enabled and ERROR-STATUS:ERRO...
Vadim Gindin wrote:
> I ran the _msg_test.p_ and _msg_test2.p_ several times and I found that there are no stack sco...
Constantin Asofiei
02:43 AM Bug #2197: fix the error message list cleanup when NO-ERROR mode is enabled and ERROR-STATUS:ERRO...
Vadim Gindin wrote:
> Here is the current update, that passed regression tests. Only _gso_ctrlc_3way_tests_ tests ar...
Constantin Asofiei
03:41 AM Feature #1632: implement _MSG() undocumented built-in function
This article states that warnings are logged too: http://knowledgebase.progress.com/articles/Article/P82729
Also, ...
Constantin Asofiei
03:28 AM Feature #1632: implement _MSG() undocumented built-in function
Vadim Gindin wrote:
> I ran the _msg_test.p_ and _msg_test2.p_ several times and I found that there are no stack sco...
Constantin Asofiei
02:17 AM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
About note 42: what you are seeing are unnamed input streams (which are opened via a @OUTPUT TO ...@ and @INPUT FROM... Constantin Asofiei

07/05/2014

11:53 AM Bug #2197: fix the error message list cleanup when NO-ERROR mode is enabled and ERROR-STATUS:ERRO...
I ran the _msg_test.p_ and _msg_test2.p_ several times and I found that there are no stack scope at all (stack scope ... Vadim Gindin

07/04/2014

03:40 PM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
Maybe problem in wrong conversion or unnecessary stream redirection.
I've looked on @text.p@ source code and didn't ...
Evgeny Kiselev
02:53 PM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
After analyzing converted source code, I've found next difference:
without updates code:
@UnnamedStreams.assignOut(...
Evgeny Kiselev
03:32 PM Bug #2197: fix the error message list cleanup when NO-ERROR mode is enabled and ERROR-STATUS:ERRO...
Here is the current update, that passed regression tests. Only _gso_ctrlc_3way_tests_ tests are failed (6/6). I'm not... Vadim Gindin

07/03/2014

12:02 PM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
I've found the problem.
!failed1.png!
As you can see on screen shots, there is no border around menus.
One the left ...
Evgeny Kiselev

07/02/2014

05:49 AM Feature #2232 (Closed): finish testing the wrapped mode using the web services exposed by the tes...
Greg Shah
04:50 AM Feature #2232: finish testing the wrapped mode using the web services exposed by the testing server
No regression tests are mandatory for this changes.
Committed revision 10557.
Marius Gligor
04:34 AM Feature #2232: finish testing the wrapped mode using the web services exposed by the testing server
You can release the 0630a.zip update, the changes don't affect MAJIC runtime. Constantin Asofiei
03:38 AM Bug #2197: fix the error message list cleanup when NO-ERROR mode is enabled and ERROR-STATUS:ERRO...
Review for 0701a.zip:
* please move ErrorManager.isPendingError back to line 1338
* the ErrorManager.setError APIs ...
Constantin Asofiei

07/01/2014

05:44 PM Bug #2197: fix the error message list cleanup when NO-ERROR mode is enabled and ERROR-STATUS:ERRO...
You're right. Thank you I managed this error and prepared the next update, that contains NO-ERROR implementation with... Vadim Gindin
05:49 AM Bug #2197: fix the error message list cleanup when NO-ERROR mode is enabled and ERROR-STATUS:ERRO...
Vadim Gindin wrote:
> I'm trying to debug my current implementation and I faced with a problem during this process....
Constantin Asofiei
08:24 AM Bug #2293: Fixing an unfixed extent output parameter causes an error
Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > The attached set of changes resolves issues mentioned above. Plea...
Hynek Cihlar
05:42 AM Bug #2293: Fixing an unfixed extent output parameter causes an error
Hynek Cihlar wrote:
> The attached set of changes resolves issues mentioned above. Please review.
* the @implements...
Constantin Asofiei
 

Also available in: Atom