FWD » Core Development » Base Language

09/12/2014

12:54 PM Feature #2385 (Closed): implement environment access on GUI interfaces.

Greg Shah

10:54 AM Feature #2385: implement environment access on GUI interfaces.

0911c passed regression tests. Committed revision 10608. Marius Gligor

09/11/2014

02:07 PM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

Evgeny Kiselev wrote:
> testcases:
> uast/no_echo/put_unformatted_bug.p
> uast/no_echo/put_unformtted_bug1.p
# pl... Constantin Asofiei

12:16 PM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

committed testcases into testcases/uast/no_echo
revision 1199.
testcases:
uast/no_echo/put_unformatted_bug.p
ua... Evgeny Kiselev

07:23 AM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

Evgeny Kiselev wrote:
> > What standalone testcases have you run to confirm your changes are correct?
I think Greg... Constantin Asofiei

01:58 PM Feature #2385: implement environment access on GUI interfaces.

Code Review 0911c
The changes look good. Please get these runtime regression tested. Greg Shah

01:39 PM Feature #2385: implement environment access on GUI interfaces.

OK. I understood thanks. Marius Gligor

01:37 PM Feature #2385: implement environment access on GUI interfaces.

In other words, when you call @DirectoryManager.getInstance()@ on the client, you will get a remote proxy to a server... Greg Shah

01:36 PM Feature #2385: implement environment access on GUI interfaces.

The @DirectoryServer@ class (which backs the @DirectoryManager.getInstance()@ on the server side) uses @Utils.getDire... Greg Shah

01:34 PM Feature #2385: implement environment access on GUI interfaces.

Marius Gligor wrote:
> Yes you are right it works in @/server/default/runtime/default/@
> But on note 12 you said:... Constantin Asofiei

01:33 PM Feature #2385: implement environment access on GUI interfaces.

done. Marius Gligor

01:30 PM Feature #2385: implement environment access on GUI interfaces.

Yes you are right it works in @/server/default/runtime/default/@
But on note 12 you said: @The lookup should allow ... Marius Gligor

01:24 PM Feature #2385: implement environment access on GUI interfaces.

I think you need to have it located in @/server/default/runtime/default/@ instead of @/server/default/@. Greg Shah

01:21 PM Feature #2385: implement environment access on GUI interfaces.

It works only for DirScope.ACCOUNTS Marius Gligor

01:17 PM Feature #2385: implement environment access on GUI interfaces.

I tried to use @DirectoryManager.getInstance()@ but it doesn't work.
I'm using the following code:... Marius Gligor

12:41 PM Feature #2385: implement environment access on GUI interfaces.

Code Review 0911b
Instead of adding a @ServerExports@ method to access the read-only flag, please use the @Directo... Greg Shah

11:35 AM Feature #2385: implement environment access on GUI interfaces.

Fixed 0911a code review. The read only flag is global and read from server node @readOnlyEnvironments@ which should h... Marius Gligor

10:49 AM Feature #2385: implement environment access on GUI interfaces.

Code Review 0911a
The changes are very good.
> a) The read only flag which change the loading rule from client ... Greg Shah

09:51 AM Feature #2385 (Review): implement environment access on GUI interfaces.

Marius Gligor

09:26 AM Feature #2385: implement environment access on GUI interfaces.

1. I fixed code review issues from 0910a.
2. I integrated the changes from task #2366 related to override default ... Marius Gligor

09/10/2014

07:08 PM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

Greg Shah wrote:
> What is the status of your regression testing?
I've just started regression testing with latest ... Evgeny Kiselev

07:04 PM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

Greg Shah wrote:
> Code Review 0910a
>
> I am worried that your changes are just there to fix some very specific ... Evgeny Kiselev

03:06 PM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

What is the status of your regression testing?
What standalone testcases have you run to confirm your changes are ... Greg Shah

03:01 PM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

Code Review 0910a
I am worried that your changes are just there to fix some very specific behavior in a few testca... Greg Shah

07:44 AM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

I've added addition comments in code. There is next algorithm.
1) first output is @put unformatted@ (in my case this... Evgeny Kiselev

05:20 PM Feature #2385: implement environment access on GUI interfaces.

Code Review 0910a
1. Doesn't @StanzaIni@ always get used on the client side? If so, then the jar file reading is ... Greg Shah

11:09 AM Feature #2385: implement environment access on GUI interfaces.

Here are my changes that I did so far on this task. Please do a code review on these changes and let me know the resu... Marius Gligor

09/09/2014

04:23 PM Bug #2338: fix _MSG function

Vadim Gindin wrote:
> I ran your test and in both cases (with or without NO-ERROR) it behaved in the same way. _MSG(... Constantin Asofiei

04:07 PM Bug #2338: fix _MSG function

I ran your test and in both cases (with or without NO-ERROR) it behaved in the same way. _MSG(1) = 74. The error bein... Vadim Gindin

01:21 PM Bug #2338: fix _MSG function

> > 1. With NO-ERROR the error number wasn't recorded to _MSG array. That is little unexpected.
> Please correct me,... Vadim Gindin

01:02 PM Bug #2338: fix _MSG function

Vadim Gindin wrote:
> I'm not sure, that I understood correctly. I expected that 0 is the default value that exists ... Constantin Asofiei

12:49 PM Bug #2338: fix _MSG function

Constantin Asofiei wrote:
> I think it shows that:
> # if a @NO-ERROR@ is added to @DELETE book@, then the ERROR-ST... Vadim Gindin

06:57 AM Bug #2338: fix _MSG function

Vadim Gindin wrote:
> 2a. format constraint 1-digit number.
> While trying to validate number 10 there are an er... Constantin Asofiei

09/08/2014

02:09 PM Bug #2338: fix _MSG function

> 1a. size(memptr) < size(file). For exapmle size(memptr) = 5 and size(file) = 23.
> Progress reads all file and dyn... Greg Shah

02:07 PM Bug #2386: STRING(memptr_var) will render the contents of the memptr as a null terminated string

See uast/memptr/memptr_to_string.p.
In the 4GL, the contents seem to be read from index 1 (1-based indexing) and i... Greg Shah

02:03 PM Bug #2386 (New): STRING(memptr_var) will render the contents of the memptr as a null terminated s...

Greg Shah

09/07/2014

02:50 PM Bug #2338: fix _MSG function

I forgot to add for the case №1 "Stream", that STRING(memptr) in Progress successfully outputs string representation ... Vadim Gindin

02:45 PM Bug #2338: fix _MSG function

I tried to test these mysterious cases. It is not easy. Here are some findings.
1. @Stream.readBlock()@ method, th... Vadim Gindin

09/05/2014

02:06 PM Feature #27: implement a compatible ENCODE built-in function

Here is the Progress 4GL compatible @ENCODE@ algorithm specification.
+Summary+
The function takes a source byt... Greg Shah

11:05 AM Feature #2385: implement environment access on GUI interfaces.

I agree with your thoughts. If this read-only approach is still going to take a significant amount of time/changes, ... Greg Shah

10:56 AM Feature #2385: implement environment access on GUI interfaces.

Indeed the big problem with @INI@ files on @P2J@ is the deployment location. Reading or writing @INI@ files on server... Marius Gligor

10:06 AM Feature #2385: implement environment access on GUI interfaces.

Interesting findings.
> Since we are looking to use INI files in both Linux OS and Windows OS the name of the INI ... Greg Shah

09:36 AM Feature #2385: implement environment access on GUI interfaces.

I did some tests using @LOAD@ @USE@ and @UNLOAD@ statements to manage user environment on both @OE@ and @P2J@.
Curre... Marius Gligor

09/04/2014

04:02 AM Feature #2385: implement environment access on GUI interfaces.

Ovidiu,
So far I did no changes on current implementation for Windows environment access.
I only added getLegac... Marius Gligor

03:05 AM Feature #2385 (WIP): implement environment access on GUI interfaces.

Current implementation for @COLOR-TABLE@ and @FONT-TABLE@ statements load the default environment from server directo... Marius Gligor

02:47 AM Feature #2385: implement environment access on GUI interfaces.

GUI clients are using environment statements LOAD USE and UNLOAD to load colors, fonts and potentially other resource... Marius Gligor

02:06 AM Feature #2385 (Closed): implement environment access on GUI interfaces.

Marius Gligor

09/03/2014

03:37 PM Bug #2367 (Closed): re-connecting an appserver agent after a hard client termination

Greg Shah

06:47 AM Bug #2367: re-connecting an appserver agent after a hard client termination

Greg Shah wrote:
> Code Review 0902a
>
> The changes look good.
Committed to rev 10604. Constantin Asofiei

01:14 PM Feature #27: implement a compatible ENCODE built-in function

New/updated articles have been found:
http://programmers.stackexchange.com/questions/206645/how-can-i-reverse-engi... Greg Shah

12:59 PM Feature #27: implement a compatible ENCODE built-in function

The following link (see attached for the actual text file that is linked) is a really useful primer on the theory beh... Greg Shah

09/02/2014

10:19 AM Bug #2367: re-connecting an appserver agent after a hard client termination

Code Review 0902a
The changes look good. Greg Shah

09:59 AM Bug #2367: re-connecting an appserver agent after a hard client termination

Constantin Asofiei wrote:
> Ovidiu, attached update should fix the remaining problem. The solution was to make the ... Ovidiu Maxiniuc

06:20 AM Bug #2367: re-connecting an appserver agent after a hard client termination

Ovidiu, attached update should fix the remaining problem. The solution was to make the (queue state check, add sessi... Constantin Asofiei

04:53 AM Bug #2367: re-connecting an appserver agent after a hard client termination

Ovidiu, you are correct, if the client is killed just before the session listener is registered, we still have proble... Constantin Asofiei

09/01/2014

04:26 PM Bug #2367: re-connecting an appserver agent after a hard client termination

Constantin,
I tested on Linux/PostgreSQL with bzr rev 10603 and your update 0806b, @initial_agents@, @min_agents@ a... Ovidiu Maxiniuc

10:40 AM Bug #2367: re-connecting an appserver agent after a hard client termination

Constantin Asofiei wrote:
>
> Eric: as Ovidiu is away, please do a quick test on the server project, by killing th... Ovidiu Maxiniuc

08/26/2014

05:52 PM Bug #2367: re-connecting an appserver agent after a hard client termination

Code Review 0806b
Wow! That is tricky code with lots of subtlety. You documented it well and the approach makes ... Greg Shah

04:47 PM Bug #2367 (WIP): re-connecting an appserver agent after a hard client termination

This one was tricky to duplicate and even trickier to solve. The cause is this: if the appserver client terminates t... Constantin Asofiei

02:52 PM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

> In out code, we add extra new line only for MODE_EXPORT, but in this situation we need to add extra line only when ... Greg Shah

02:04 PM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

I know, that 4gl documentation is not always correct, but there is next paragraph in @put@ statement:
>UNFORMATTED
... Evgeny Kiselev

01:32 PM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

Greg Shah wrote:
> I still don't know the answer to this question from note 87.
>
> And I would like to know your... Evgeny Kiselev

10:34 AM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

Code Review 0820a
I am fine with the changes.
> However, I think the problems 10/11 in #1629 note 17 will NOT b... Greg Shah

09:45 AM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

Evgeny Kiselev wrote:
> Before merge this update have been passed regression testing, but now it not compile because... Constantin Asofiei

08:35 AM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

fix problem described in note 86
fix issues from note 87
merged with latest revision
Before merge this update ha... Evgeny Kiselev

08/25/2014

10:48 AM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

OK, that makes more sense now. What do you suggest? Greg Shah

10:00 AM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

Here is my stacktrace:... Evgeny Kiselev

09:24 AM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

> problem with @put unformatted "~n ".@:
> ...
> and in method com.goldencode.p2j.util.Stream#generateFormattedText... Greg Shah

08/22/2014

09:32 AM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

problem described in note 86 divide into 2 problems:
1) incorrect position for message method with redirected stream ... Evgeny Kiselev

08/15/2014

03:05 PM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

Code Review 0812a
The proposed code can be accepted with only some minor changes (listed below).
However, I t... Greg Shah

04:50 AM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

update:
1) rollback isTerm() method
2) rollback ThinClient(described below)
3) I've added in StreamFactory next co... Evgeny Kiselev