FWD » Core Development » Base Language

01/28/2015

04:52 PM Bug #2499: DST portion of the timezone offset is always included when it should be conditional

I'm good with this approach if you find the the @datetime@ and @datetimetz@ are OK too. Greg Shah

04:37 PM Bug #2499 (WIP): DST portion of the timezone offset is always included when it should be conditional

Most likely, the code inside @getDefaultOffset@ should be fixed:... Ovidiu Maxiniuc

11:55 AM Bug #2507: format validation with editing blocks

Greg Shah wrote:
> Code Review ca_upd20150128a.zip
>
> My only concern is with the use of @checkFormat()@ instead... Constantin Asofiei

08:31 AM Bug #2507: format validation with editing blocks

Code Review ca_upd20150128a.zip
My only concern is with the use of @checkFormat()@ instead of @validateFormat()@ o... Greg Shah

04:19 AM Bug #2507: format validation with editing blocks

From what I see, the format validation is done when LEAVE is sent for the widget. More, when EDITING mode is enabled... Constantin Asofiei

04:05 AM Bug #2507: format validation with editing blocks

Constantin,
Consider this:... Constantin Asofiei

04:04 AM Bug #2507 (Closed): format validation with editing blocks

Constantin Asofiei

01/26/2015

02:42 PM Bug #2499: DST portion of the timezone offset is always included when it should be conditional

Some ideas about automating the DST testing (in junits or date.main):
> Ovidiu Maxiniuc wrote:
Java 8 has some new A... Constantin Asofiei

12:35 PM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

Evgeny Kiselev wrote:
> My changes in @Window@ class is issue for gso_276 test. Looking for approach.
Did you int... Greg Shah

12:34 PM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

Code Review evk_upd20150126a.zip
1. Please remove @import org.apache.commons.logging.*;@ from @Stream.java@.
2.... Greg Shah

07:46 AM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

My changes in @Window@ class is issue for gso_276 test. Looking for approach. Evgeny Kiselev

09:01 PM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

Tests gso_17 and gso_488 has been fixed in @Stream@ class. Even if output is unformatted we still need to use formatt... Evgeny Kiselev

11:51 AM Feature #2505: SEARCH and loading of static resources from the server-side application jar

Today our SEARCH and any file reading occurs exclusively on the client side. As part of #2476 we are implementing su... Greg Shah

11:47 AM Feature #2505 (New): SEARCH and loading of static resources from the server-side application jar

Greg Shah

11:46 AM Feature #2504: real environment access for OS-GETENV

Today we map OS-GETENV to the JVM @System.getProperty()@ which does not real from real environment variables, but ins... Greg Shah

11:40 AM Feature #2504 (Closed): real environment access for OS-GETENV

Greg Shah

01/23/2015

01:57 PM Bug #2499: DST portion of the timezone offset is always included when it should be conditional

I took a quick look at this. Outside the util package, @date.getDefaultOffset()@ is used from @persist/HQLPreprocess... Greg Shah

01:51 PM Bug #2499: DST portion of the timezone offset is always included when it should be conditional

TIMCO reported a problem with transactions starting at midnight. Constantin tracked the problem back to the TODAY fu... Greg Shah

01:46 PM Bug #2499 (WIP): DST portion of the timezone offset is always included when it should be conditional

Greg Shah

09:29 AM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

>Eugenie Lyzenko: is there anything about GSO 488 which was not captured in the 4GL?
I think yes. The 4GL system @... Eugenie Lyzenko

08:39 AM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

Code Review evk_upd20150121a.zip
The changes are fine. In the future, please post the update without the @01_@ pr... Greg Shah

07:46 AM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

Greg Shah wrote:
> Are the ChUI-specific changes to @Window.message()@ still needed (to set the cursor position to c... Evgeny Kiselev

01/20/2015

07:26 AM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

Code Review evk_upd20150119a.zip
It looks good.
Are the ChUI-specific changes to @Window.message()@ still neede... Greg Shah

09:18 PM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

Explicit flush stream is helped, thanks.
That's why different test in regression testing were failed from time to t... Evgeny Kiselev

01/19/2015

01:27 PM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

> So we need always NL before message if message is not on the first line(or we need to calculate NL character as not... Greg Shah

09:06 PM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

Greg Shah wrote:
> Please post the corresponding 4GL output so that I can better understand what this code is suppose... Evgeny Kiselev

01/18/2015

09:11 AM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

Please post the corresponding 4GL output so that I can better understand what this code is supposed to do. Greg Shah

01/17/2015

05:57 PM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

Constantin Asofiei wrote:
> Evgeny Kiselev wrote:
> > - Message should be always on New Line if current position is n... Evgeny Kiselev

01/16/2015

02:11 PM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

Evgeny Kiselev wrote:
> - Message should be always on New Line if current position is not in the start of line. I th... Constantin Asofiei

06:40 AM Bug #2485: Invalid THIS-PROCEDURE in AdminClient

Committed to bzr rev 10711. Stanislav Lomany

05:36 AM Bug #2485: Invalid THIS-PROCEDURE in AdminClient

Stanislav Lomany wrote:
> MAJIC converted OK. Please review the update so I can distribute it.
I'm OK with the chan... Constantin Asofiei

05:28 AM Bug #2485: Invalid THIS-PROCEDURE in AdminClient

MAJIC converted OK. Please review the update so I can distribute it. Stanislav Lomany

02:18 AM Bug #2485: Invalid THIS-PROCEDURE in AdminClient

Fixed conversion. MAJIC conversion is running. Stanislav Lomany

01/15/2015

06:08 PM Bug #2485 (Closed): Invalid THIS-PROCEDURE in AdminClient

Greg Shah

05:42 PM Bug #2485 (Review): Invalid THIS-PROCEDURE in AdminClient

Stanislav Lomany

05:40 PM Bug #2485: Invalid THIS-PROCEDURE in AdminClient

svl_upd20150115a.zip was committed into bzr rev 10710.
svl_upd20150114b.zip was committed to staging on devsrv01. Stanislav Lomany

10:45 AM Bug #2485: Invalid THIS-PROCEDURE in AdminClient

Stanislav Lomany wrote:
> So, should I distribute the P2J update without regression testing
Run only the CTRL-C pa... Constantin Asofiei

10:43 AM Bug #2485: Invalid THIS-PROCEDURE in AdminClient

So, should I distribute the P2J update without regression testing and check in MAJIC part into staging branch on devs... Stanislav Lomany

10:07 AM Bug #2485: Invalid THIS-PROCEDURE in AdminClient

Stanislav Lomany wrote:
> Fixed getting "headless" attribute.
If this solves the admin client problem without regre... Constantin Asofiei

09:34 AM Bug #2485: Invalid THIS-PROCEDURE in AdminClient

Fixed getting "headless" attribute. Stanislav Lomany

03:53 AM Bug #2485: Invalid THIS-PROCEDURE in AdminClient

Stanislav Lomany wrote:
> Looks like with this call is disturbing natural order of loading @TransactionManager@ and ... Constantin Asofiei

09:38 AM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

I think your idea of changing the approach seems to be on the right track.
> Message should be always on New Line ... Greg Shah

05:21 AM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

At the moment regression tests finished with failed status.
5 tests are failed because of different numbers of rows ... Evgeny Kiselev

01/14/2015

03:14 PM Bug #2485: Invalid THIS-PROCEDURE in AdminClient

Heh, there is a problem with @TransactionManager.isHeadless@: normal clients do not start.... Stanislav Lomany

02:20 PM Bug #2485: Invalid THIS-PROCEDURE in AdminClient

The query changes are the same that were sent to Scott. Stanislav Lomany

12:48 PM Bug #2485: Invalid THIS-PROCEDURE in AdminClient

Code Review svl_upd20150114b.zip
I'm fine with the external procedure wrapping parts of this.
Eric: please revi... Greg Shah

12:48 PM Bug #2485: Invalid THIS-PROCEDURE in AdminClient

Code Review svl_upd20150114a.zip
I'm fine with this. Greg Shah

11:40 AM Bug #2485: Invalid THIS-PROCEDURE in AdminClient

Updates for review. Stanislav Lomany

08:22 AM Bug #2485: Invalid THIS-PROCEDURE in AdminClient

Yes, I think that is fine. We just need to put some clear comments into there to explain why this is being done. Greg Shah

01:59 AM Bug #2485: Invalid THIS-PROCEDURE in AdminClient

Greg, can we assume that if we are in headless mode (@TransactionManager.isHeadless()@ returns true), we are under li... Constantin Asofiei

10:07 AM Bug #2489: FileSystemOps.searchPath(String) should return the 4GL procedure name for external pro...

It is common for 4GL code to search for 4GL external procedure names before executing those programs. Such searches ... Greg Shah

09:54 AM Bug #2489 (Closed): FileSystemOps.searchPath(String) should return the 4GL procedure name for ext...

Greg Shah

01/13/2015

04:06 PM Bug #2485 (WIP): Invalid THIS-PROCEDURE in AdminClient

Constantin, thanks, that helped.
Guys, there is one more issue: if we connect to a fresh server - no standards cli... Stanislav Lomany

09:42 AM Bug #2485: Invalid THIS-PROCEDURE in AdminClient

Stanislav,
Your stacktrace is hiding another NPE, when the scope is initially pushed:... Constantin Asofiei

08:54 AM Bug #2485: Invalid THIS-PROCEDURE in AdminClient

I think all of the issues have the same cause. Reproduction:
1. Log into admin client.
2. MAJIC -> Printer Maintena... Stanislav Lomany

07:18 AM Bug #2485 (Closed): Invalid THIS-PROCEDURE in AdminClient

Stanislav Lomany