FWD » Core Development » Base Language

02/12/2015

09:39 PM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

Code Review evk_upd20150205a.zip
The changes look fine. You'll need to merge up to the latest level before the ne... Greg Shah

02/06/2015

08:47 PM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

>Even the character type seems incorrect as the default format for character is x(8). It is not based on the length o... Evgeny Kiselev

02/05/2015

06:02 PM Bug #2499: DST portion of the timezone offset is always included when it should be conditional

I agree. Well done. Greg Shah

06:00 PM Bug #2499: DST portion of the timezone offset is always included when it should be conditional

I believe I have good news.
The testing of 0204a finished with following result:
gso_ctrlc_tests: 2 fails: once th... Ovidiu Maxiniuc

02/04/2015

02:45 PM Bug #2499: DST portion of the timezone offset is always included when it should be conditional

Yes, exactly. Greg Shah

02:44 PM Bug #2499: DST portion of the timezone offset is always included when it should be conditional

Greg Shah wrote:
> 2. Prepare a version of the fix that has the @date.java@ changes merged with the H063 version o... Ovidiu Maxiniuc

02:31 PM Bug #2499: DST portion of the timezone offset is always included when it should be conditional

> 1. Check in and distribute om_upd20150203a.zip.
The update was committed to bzr renvo 10742 and distributed by m... Ovidiu Maxiniuc

01:31 PM Bug #2499: DST portion of the timezone offset is always included when it should be conditional

Great!
Next steps:
1. Check in and distribute om_upd20150203a.zip.
2. Prepare a version of the fix that has ... Greg Shah

01:13 PM Bug #2499: DST portion of the timezone offset is always included when it should be conditional

Greg Shah wrote:
> I'm fine with the changes. If it passes testing, you can check it in.
The @main@ passed the reg... Ovidiu Maxiniuc

02/03/2015

12:45 PM Bug #2511: timestamp instance oddity when assigning to a datetime

Consider the following P4GL code fragment executed on windev01, configured with timezone UTC+02:00 (only need to be o... Ovidiu Maxiniuc

12:11 PM Bug #2511 (New): timestamp instance oddity when assigning to a datetime

Ovidiu Maxiniuc

11:21 AM Bug #2499: DST portion of the timezone offset is always included when it should be conditional

The om_upd20150203a.zip update has:
* 3 fails in CTRL+C
* 2 fails in gc_tests
* 6 fails in tc_tests
Except for ... Ovidiu Maxiniuc

07:44 AM Bug #2499: DST portion of the timezone offset is always included when it should be conditional

Code Review om_upd20150203a.zip
I'm fine with the changes. If it passes testing, you can check it in.
Please a... Greg Shah

02/02/2015

05:34 PM Bug #2499: DST portion of the timezone offset is always included when it should be conditional

I am putting this update to test.
It passed my tests regarding the DST. Yet, there is an issue regarding the assign... Ovidiu Maxiniuc

02/01/2015

11:41 AM Bug #2510 (Closed): client-side context reset problem

Let's not worry about this now. Your update is a good, safe movement forward. Greg Shah

11:36 AM Bug #2510: client-side context reset problem

Greg Shah wrote:
> You can go ahead and check it in.
Released to rev 10734.
> My only question is whether the C... Constantin Asofiei

11:30 AM Bug #2510: client-side context reset problem

You can go ahead and check it in. Greg Shah

11:30 AM Bug #2510: client-side context reset problem

Code Review ca_upd20150131c.zip
It looks good. My only question is whether the @ContextLocal@ should also have it... Greg Shah

10:37 AM Bug #2510 (Review): client-side context reset problem

Attached update fixes the reset of client-side context data, when CTRL-C is pressed and ClientCore.start loop goes to... Constantin Asofiei

10:36 AM Bug #2510 (Closed): client-side context reset problem

Constantin Asofiei

01/30/2015

12:40 PM Bug #2509 (Closed): problem converting INPUT x @ y constructs

Greg Shah

12:27 PM Bug #2509: problem converting INPUT x @ y constructs

P2J incorrectly resolves the frame of a @INPUT i@ expression, in a case like this:... Constantin Asofiei

12:23 PM Bug #2509 (Closed): problem converting INPUT x @ y constructs

Constantin Asofiei

05:21 AM Bug #2507 (Closed): format validation with editing blocks

Greg Shah

01:11 AM Bug #2507: format validation with editing blocks

Greg Shah wrote:
> Code Review ca_upd20150129b.zip
>
> I'm fine with the changes.
Passed runtime testing, re... Constantin Asofiei

01/29/2015

05:51 PM Bug #2499: DST portion of the timezone offset is always included when it should be conditional

Code Review om_upd20150129b.zip
There are no changes in the @datetime.java@ that was in the update zip. Otherwise... Greg Shah

02:44 PM Bug #2499: DST portion of the timezone offset is always included when it should be conditional

This is most likely an RC.
I only done the 'theoretical' checking on @datetime@ and @datetimetz@. I am preparing no... Ovidiu Maxiniuc

04:28 PM Bug #2507: format validation with editing blocks

Code Review ca_upd20150129b.zip
I'm fine with the changes. Greg Shah

03:57 PM Bug #2507: format validation with editing blocks

> This is going through runtime testing now.
CTRL-C passed, MAIN part was killed and restarted, as after ~5 hours ... Constantin Asofiei

10:52 AM Bug #2507: format validation with editing blocks

This is replacement of 0128a.zip. Enhances the support for character formats and is a good step forward, but there ar... Constantin Asofiei

01/28/2015

04:52 PM Bug #2499: DST portion of the timezone offset is always included when it should be conditional

I'm good with this approach if you find the the @datetime@ and @datetimetz@ are OK too. Greg Shah

04:37 PM Bug #2499 (WIP): DST portion of the timezone offset is always included when it should be conditional

Most likely, the code inside @getDefaultOffset@ should be fixed:... Ovidiu Maxiniuc

11:55 AM Bug #2507: format validation with editing blocks

Greg Shah wrote:
> Code Review ca_upd20150128a.zip
>
> My only concern is with the use of @checkFormat()@ instead... Constantin Asofiei

08:31 AM Bug #2507: format validation with editing blocks

Code Review ca_upd20150128a.zip
My only concern is with the use of @checkFormat()@ instead of @validateFormat()@ o... Greg Shah

04:19 AM Bug #2507: format validation with editing blocks

From what I see, the format validation is done when LEAVE is sent for the widget. More, when EDITING mode is enabled... Constantin Asofiei

04:05 AM Bug #2507: format validation with editing blocks

Constantin,
Consider this:... Constantin Asofiei

04:04 AM Bug #2507 (Closed): format validation with editing blocks

Constantin Asofiei

01/26/2015

02:42 PM Bug #2499: DST portion of the timezone offset is always included when it should be conditional

Some ideas about automating the DST testing (in junits or date.main):
> Ovidiu Maxiniuc wrote:
Java 8 has some new A... Constantin Asofiei

12:35 PM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

Evgeny Kiselev wrote:
> My changes in @Window@ class is issue for gso_276 test. Looking for approach.
Did you int... Greg Shah

12:34 PM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

Code Review evk_upd20150126a.zip
1. Please remove @import org.apache.commons.logging.*;@ from @Stream.java@.
2.... Greg Shah

07:46 AM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

My changes in @Window@ class is issue for gso_276 test. Looking for approach. Evgeny Kiselev

09:01 PM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

Tests gso_17 and gso_488 has been fixed in @Stream@ class. Even if output is unformatted we still need to use formatt... Evgeny Kiselev

11:51 AM Feature #2505: SEARCH and loading of static resources from the server-side application jar

Today our SEARCH and any file reading occurs exclusively on the client side. As part of #2476 we are implementing su... Greg Shah

11:47 AM Feature #2505 (New): SEARCH and loading of static resources from the server-side application jar

Greg Shah

11:46 AM Feature #2504: real environment access for OS-GETENV

Today we map OS-GETENV to the JVM @System.getProperty()@ which does not real from real environment variables, but ins... Greg Shah

11:40 AM Feature #2504 (Closed): real environment access for OS-GETENV

Greg Shah

01/23/2015

01:57 PM Bug #2499: DST portion of the timezone offset is always included when it should be conditional

I took a quick look at this. Outside the util package, @date.getDefaultOffset()@ is used from @persist/HQLPreprocess... Greg Shah

01:51 PM Bug #2499: DST portion of the timezone offset is always included when it should be conditional

TIMCO reported a problem with transactions starting at midnight. Constantin tracked the problem back to the TODAY fu... Greg Shah

01:46 PM Bug #2499 (WIP): DST portion of the timezone offset is always included when it should be conditional

Greg Shah

09:29 AM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

>Eugenie Lyzenko: is there anything about GSO 488 which was not captured in the 4GL?
I think yes. The 4GL system @... Eugenie Lyzenko

08:39 AM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

Code Review evk_upd20150121a.zip
The changes are fine. In the future, please post the update without the @01_@ pr... Greg Shah

07:46 AM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

Greg Shah wrote:
> Are the ChUI-specific changes to @Window.message()@ still needed (to set the cursor position to c... Evgeny Kiselev

01/20/2015

07:26 AM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

Code Review evk_upd20150119a.zip
It looks good.
Are the ChUI-specific changes to @Window.message()@ still neede... Greg Shah

09:18 PM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

Explicit flush stream is helped, thanks.
That's why different test in regression testing were failed from time to t... Evgeny Kiselev

01/19/2015

01:27 PM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

> So we need always NL before message if message is not on the first line(or we need to calculate NL character as not... Greg Shah

09:06 PM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

Greg Shah wrote:
> Please post the corresponding 4GL output so that I can better understand what this code is suppose... Evgeny Kiselev

01/18/2015

09:11 AM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

Please post the corresponding 4GL output so that I can better understand what this code is supposed to do. Greg Shah

01/17/2015

05:57 PM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

Constantin Asofiei wrote:
> Evgeny Kiselev wrote:
> > - Message should be always on New Line if current position is n... Evgeny Kiselev

01/16/2015

02:11 PM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

Evgeny Kiselev wrote:
> - Message should be always on New Line if current position is not in the start of line. I th... Constantin Asofiei

06:40 AM Bug #2485: Invalid THIS-PROCEDURE in AdminClient

Committed to bzr rev 10711. Stanislav Lomany

05:36 AM Bug #2485: Invalid THIS-PROCEDURE in AdminClient

Stanislav Lomany wrote:
> MAJIC converted OK. Please review the update so I can distribute it.
I'm OK with the chan... Constantin Asofiei

05:28 AM Bug #2485: Invalid THIS-PROCEDURE in AdminClient

MAJIC converted OK. Please review the update so I can distribute it. Stanislav Lomany

02:18 AM Bug #2485: Invalid THIS-PROCEDURE in AdminClient

Fixed conversion. MAJIC conversion is running. Stanislav Lomany

01/15/2015

06:08 PM Bug #2485 (Closed): Invalid THIS-PROCEDURE in AdminClient

Greg Shah

05:42 PM Bug #2485 (Review): Invalid THIS-PROCEDURE in AdminClient

Stanislav Lomany

05:40 PM Bug #2485: Invalid THIS-PROCEDURE in AdminClient

svl_upd20150115a.zip was committed into bzr rev 10710.
svl_upd20150114b.zip was committed to staging on devsrv01. Stanislav Lomany

10:45 AM Bug #2485: Invalid THIS-PROCEDURE in AdminClient

Stanislav Lomany wrote:
> So, should I distribute the P2J update without regression testing
Run only the CTRL-C pa... Constantin Asofiei

10:43 AM Bug #2485: Invalid THIS-PROCEDURE in AdminClient

So, should I distribute the P2J update without regression testing and check in MAJIC part into staging branch on devs... Stanislav Lomany

10:07 AM Bug #2485: Invalid THIS-PROCEDURE in AdminClient

Stanislav Lomany wrote:
> Fixed getting "headless" attribute.
If this solves the admin client problem without regre... Constantin Asofiei

09:34 AM Bug #2485: Invalid THIS-PROCEDURE in AdminClient

Fixed getting "headless" attribute. Stanislav Lomany

03:53 AM Bug #2485: Invalid THIS-PROCEDURE in AdminClient

Stanislav Lomany wrote:
> Looks like with this call is disturbing natural order of loading @TransactionManager@ and ... Constantin Asofiei

09:38 AM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

I think your idea of changing the approach seems to be on the right track.
> Message should be always on New Line ... Greg Shah

05:21 AM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

At the moment regression tests finished with failed status.
5 tests are failed because of different numbers of rows ... Evgeny Kiselev