Project

General

Profile

Activity

From 12/02/2019 to 12/31/2019

12/31/2019

03:04 PM Bug #4476: Shared frame does not get @ widget method generated
This is data from a correctly built testcase, which does *not* create the fields in the from on-the-fly.
@sharedfr...
Roger Borrello
02:14 PM Bug #4476: Shared frame does not get @ widget method generated
Let me recap what is generated by the pair of testcases in #note-1 :
@sharedframes/SharedFrameAtLabel.java@...
Roger Borrello
12:00 PM Bug #4484 (Test): Accumulator confusion using same field for count and total
Greg Shah
12:00 PM Bug #4483 (Test): Unable to use logical variable check in underline statement
Greg Shah
12:00 PM Bug #4482 (Test): Enable/Disable with empty EXCEPT causes issues
Greg Shah
11:59 AM Bug #4480 (Test): Extent does not become fixed when there is an initial list of values
Greg Shah
11:58 AM Bug #4455 (Test): Extent field on unsubscripted next-prompt not converted properly
Greg Shah
11:57 AM Bug #4423 (Test): Incorrect buffer scoping when same buffer name used as a parameter to internal ...
Greg Shah
10:42 AM Bug #4427 (Test): Unable to convert keyword input when used to index into an extent
Greg Shah
10:39 AM Bug #4427: Unable to convert keyword input when used to index into an extent
Committed @rules/annotations/input_builtin_prep.rules@ to *4207a-11367*. Roger Borrello
10:19 AM Bug #4427: Unable to convert keyword input when used to index into an extent
Constantin Asofiei wrote:
> Roger, I think I found the root cause. Try replacing the @walk-rules@ with @ascent-rule...
Roger Borrello

12/28/2019

03:05 PM Feature #3810: SECURITY-POLICY and other security features
I still have two issues with @CLIENT-PRINCIPAL@ EXPORT/IMPORT support.
1. The quirk which is described in #4108 also...
Igor Skornyakov
03:54 AM Feature #3810: SECURITY-POLICY and other security features
Greg Shah wrote:
> 3809e is frozen at this time. Please create a new 3810e branch.
Thank you, Greg.
Created tas...
Igor Skornyakov
08:58 PM Feature #3810: SECURITY-POLICY and other security features
3809e is frozen at this time. Please create a new 3810e branch. Greg Shah

12/27/2019

02:17 PM Feature #3810: SECURITY-POLICY and other security features
It seems that multiple changes are required. Which branch should I use to commit? At this moment I'm working with 380... Igor Skornyakov
02:33 AM Feature #3810: SECURITY-POLICY and other security features
Contrary to what is was said in #3810-174, the value of the @PRIMARY-PASSPHRASE@ attribute is *not* always hidden (re... Igor Skornyakov

12/26/2019

05:27 PM Feature #3810: SECURITY-POLICY and other security features
With with 3809e revision 11456 @uast/security/export-cp.p@ reveals multiple incompatibilities in @CLIENT-PRINCIPAL@ ... Igor Skornyakov

12/25/2019

02:47 PM Feature #3810: SECURITY-POLICY and other security features
I'm trying to converted run @uast/security/export-cp.p@ with 3809e revision 11456 and two attached databases. The ser... Igor Skornyakov

12/24/2019

02:22 PM Bug #4427: Unable to convert keyword input when used to index into an extent
Roger, I think I found the root cause. Try replacing the @walk-rules@ with @ascent-rules@ in @input_builtin_prep.rul... Constantin Asofiei
12:19 PM Bug #4427: Unable to convert keyword input when used to index into an extent
I see that getScreenValue() is the method used in your testcase. The AST and Java look so much cleaner than in my tes... Roger Borrello
11:44 AM Bug #4427: Unable to convert keyword input when used to index into an extent
Constantin Asofiei wrote:
> Roger Borrello wrote:
> > Thanks for looking. I had a much more complicated testcase or...
Roger Borrello
11:17 AM Bug #4427: Unable to convert keyword input when used to index into an extent
Roger Borrello wrote:
> Thanks for looking. I had a much more complicated testcase originally, which has been greatl...
Constantin Asofiei
11:16 AM Bug #4427: Unable to convert keyword input when used to index into an extent
There's something else going on. This case parses/converts properly:... Constantin Asofiei
11:11 AM Bug #4427: Unable to convert keyword input when used to index into an extent
Thanks for looking. I had a much more complicated testcase originally, which has been greatly reduced:... Roger Borrello
10:59 AM Bug #4427: Unable to convert keyword input when used to index into an extent
Constantin Asofiei wrote:
> Roger Borrello wrote:
> > I went to a basic @input mybuff[x]@ where x was just an integ...
Constantin Asofiei
10:55 AM Bug #4427: Unable to convert keyword input when used to index into an extent
Roger Borrello wrote:
> I went to a basic @input mybuff[x]@ where x was just an integer. It generated:
I don't thin...
Constantin Asofiei
10:22 AM Bug #4427: Unable to convert keyword input when used to index into an extent
Roger Borrello wrote:
> What is @dynamicindex@ annotation used for? I'm trying to determine why the LBRACKET subtree...
Roger Borrello

12/23/2019

11:53 AM Bug #4427: Unable to convert keyword input when used to index into an extent
What is @dynamicindex@ annotation used for? I'm trying to determine why the LBRACKET subtree is duplicated in @input_... Roger Borrello

12/20/2019

04:54 PM Bug #4427: Unable to convert keyword input when used to index into an extent
Roger Borrello wrote:
> I looked at a much simpler case of using @input mynum@ then @input mybuff[mynum]@ instead of...
Roger Borrello
04:02 PM Bug #4427: Unable to convert keyword input when used to index into an extent
I looked at a much simpler case of using @input mynum@ then @input mybuff[mynum]@ instead of the more complicated, ne... Roger Borrello
02:52 PM Bug #4160: Arrays assigment issue
Constantin Asofiei wrote:
> Greg Shah wrote:
> > > a bug in ArrayAssigner - when is defined, a dynamic extent var g...
Roger Borrello
01:06 PM Bug #4160: Arrays assigment issue
Roger Borrello wrote:
> Does this mean the testcase is invalid? Or is there a bug? I was using 4207a, not trunk.
I ...
Constantin Asofiei
01:04 PM Bug #4160: Arrays assigment issue
Constantin Asofiei wrote:
> The above is from trunk: @if false then accum "third" (count).@ is marked as unreachable...
Roger Borrello
12:57 PM Bug #4160: Arrays assigment issue
Greg Shah wrote:
> > a bug in ArrayAssigner - when is defined, a dynamic extent var gets registered with the previou...
Constantin Asofiei
12:07 PM Bug #4160: Arrays assigment issue
The above is from trunk: @if false then accum "third" (count).@ is marked as unreachable, which is not correct. Any a... Constantin Asofiei
11:56 AM Bug #4160: Arrays assigment issue
Constantin Asofiei wrote:
> Roger Borrello wrote:
> > Roger Borrello wrote:
> > > I think there is a regression. S...
Roger Borrello
10:24 AM Bug #4160: Arrays assigment issue
Roger Borrello wrote:
> Roger Borrello wrote:
> > I think there is a regression. See testcase below. In fact, I jus...
Constantin Asofiei
09:58 AM Bug #4160: Arrays assigment issue
Roger Borrello wrote:
> I think there is a regression. See testcase below. In fact, I just ran *4207a* against @uast...
Roger Borrello
09:56 AM Bug #4160: Arrays assigment issue
I think there is a regression. See testcase below. In fact, I just ran *4207a* against @uast/accum_scope*.p" and ther... Roger Borrello
09:36 AM Bug #4160: Arrays assigment issue
> use a special wrapper (so that we can make even the dynamic extent vars 'mutable', maybe limited to shared cases)
...
Greg Shah
09:33 AM Bug #4160: Arrays assigment issue
> a bug in ArrayAssigner - when is defined, a dynamic extent var gets registered with the previous scope, and not the... Greg Shah
01:09 PM Bug #4484: Accumulator confusion using same field for count and total
Constantin Asofiei wrote:
> Argh, there was another typo. fixed in 11366
Great... this update worked! We need to ...
Roger Borrello
12:45 PM Bug #4484: Accumulator confusion using same field for count and total
Argh, there was another typo. fixed in 11366 Constantin Asofiei
12:12 PM Bug #4484: Accumulator confusion using same field for count and total
Just reporting that there is another scenario which creates a hidden FieldRef. I checked in @uast/accum/accum_count_h... Roger Borrello
10:02 AM Bug #4484: Accumulator confusion using same field for count and total
Roger Borrello wrote:
> Constantin Asofiei wrote:
> > Roger, see 4207a rev 11362, it should fix the issue.
>
> I...
Roger Borrello
10:00 AM Bug #4484: Accumulator confusion using same field for count and total
Constantin Asofiei wrote:
> Roger, see 4207a rev 11362, it should fix the issue.
I'll take a look
Roger Borrello
09:31 AM Bug #4484: Accumulator confusion using same field for count and total
Roger, see 4207a rev 11362, it should fix the issue. Constantin Asofiei
07:12 PM Bug #4484: Accumulator confusion using same field for count and total
Found a subsequent error, when multiple accumulators are on the same statement.
Added a new testcase @uast/accum_s...
Roger Borrello
12:34 PM Bug #4480: Extent does not become fixed when there is an initial list of values
Greg Shah wrote:
> > The updated ended up being in Variable.java, so updated to progress.g are unnecessary. However,...
Roger Borrello
11:42 AM Bug #4480: Extent does not become fixed when there is an initial list of values
> The updated ended up being in Variable.java, so updated to progress.g are unnecessary. However, the changes could b... Greg Shah

12/19/2019

06:36 PM Bug #4160: Arrays assigment issue
Constantin Asofiei wrote:
> Ah, and I just realized something - for variables scoped to the external program, we sho...
Constantin Asofiei
03:48 PM Bug #4160: Arrays assigment issue
The conversion fixes are in 4207a rev 11360. It also moves the @ExtentExpr@ to anon classes, to get rid of the param... Constantin Asofiei
02:44 PM Bug #4160: Arrays assigment issue
I have a conversion fix for the INPUT and normal variable, but I'm working also on getting rid of the promotion of th... Constantin Asofiei
12:53 PM Bug #4160: Arrays assigment issue
And another side-note, in case of OE class properties, we are missing:
* getter which returns the extent var (withou...
Constantin Asofiei
12:46 PM Bug #4160: Arrays assigment issue
Greg, as a side note: for shared variables, if there is a dynamic extent case, then this solution will not work (as t... Constantin Asofiei
12:06 PM Bug #4160: Arrays assigment issue
Greg Shah wrote:
> OK. Can you please add that change to 4207a?
OK, will do.
Constantin Asofiei
12:04 PM Bug #4160: Arrays assigment issue
OK. Can you please add that change to 4207a? Greg Shah
11:47 AM Bug #4160: Arrays assigment issue
Greg, the @ref[0]@ approach was added, but only for OUTPUT parameters (I really don't recall why I did it only for th... Constantin Asofiei
11:38 AM Bug #4160: Arrays assigment issue
Indeterminate arrays are profoundly broken in the current FWD trunk. This task and #4123 show two very simple cases ... Greg Shah
01:47 PM Bug #4480 (WIP): Extent does not become fixed when there is an initial list of values
Roger Borrello
01:47 PM Bug #4480: Extent does not become fixed when there is an initial list of values
*Code checked into 4207a-11359.* Roger Borrello
01:42 PM Bug #4480: Extent does not become fixed when there is an initial list of values
h2. Testcases Converted and Compiled.
@form_with_extent.p@...
Roger Borrello
01:18 PM Bug #4480: Extent does not become fixed when there is an initial list of values
Roger Borrello wrote:
> Greg Shah wrote:
> > > But: the same might apply to OO properties, table fields and procedu...
Roger Borrello

12/18/2019

04:52 PM Bug #4484 (WIP): Accumulator confusion using same field for count and total
Roger Borrello
04:51 PM Bug #4484: Accumulator confusion using same field for count and total
Update to @rules/annotations/accumulate.rules@ checked into @4207a-11358@. Roger Borrello
04:34 PM Bug #4484: Accumulator confusion using same field for count and total
Constantin Asofiei wrote:
> Roger, please check this patch:
> [...]
>
> The problem was that the check if the ex...
Roger Borrello
04:24 PM Bug #4484: Accumulator confusion using same field for count and total
Roger, please check this patch:... Constantin Asofiei
04:08 PM Bug #4484: Accumulator confusion using same field for count and total
Constantin Asofiei wrote:
> Check the other @KW_ACCUM/EXPRESSION@ nodes. Once COUNT is encountered, any @ STATEMENT...
Roger Borrello
03:34 PM Bug #4484: Accumulator confusion using same field for count and total
Check the other @KW_ACCUM/EXPRESSION@ nodes. Once COUNT is encountered, any @ STATEMENT/KW_ACCUM/EXPRESSION@ will ha... Constantin Asofiei
03:25 PM Bug #4484: Accumulator confusion using same field for count and total
Roger Borrello wrote:
> Constantin Asofiei wrote:
> > Roger, there's another different in the AST: look for the @hi...
Roger Borrello
01:53 PM Bug #4484: Accumulator confusion using same field for count and total
Constantin Asofiei wrote:
> Roger, there's another different in the AST: look for the @hidden@ attribute at the AST ...
Roger Borrello
01:47 PM Bug #4484: Accumulator confusion using same field for count and total
Roger, there's another different in the AST: look for the @hidden@ attribute at the AST node; this depends on the @su... Constantin Asofiei
01:37 PM Bug #4484: Accumulator confusion using same field for count and total
Constantin Asofiei wrote:
> Roger Borrello wrote:
> > I tried that immediately above. It is an issue limited to fie...
Roger Borrello
01:34 PM Bug #4484: Accumulator confusion using same field for count and total
Roger Borrello wrote:
> I tried that immediately above. It is an issue limited to fields. Are we trying to be too _f...
Constantin Asofiei
01:29 PM Bug #4484: Accumulator confusion using same field for count and total
Constantin Asofiei wrote:
> OK, try this, too:
> [...]
>
> Is normal to declare @i@, as is an explicit var. I'm ...
Roger Borrello
01:25 PM Bug #4484: Accumulator confusion using same field for count and total
OK, try this, too:... Constantin Asofiei
01:24 PM Bug #4484: Accumulator confusion using same field for count and total
Roger Borrello wrote:
> Constantin Asofiei wrote:
> > This works fine in 4GL:
> > [...]
>
> I added count...
>...
Roger Borrello
01:20 PM Bug #4484: Accumulator confusion using same field for count and total
Constantin Asofiei wrote:
> This works fine in 4GL:
> [...]
I added count......
Roger Borrello
01:09 PM Bug #4484: Accumulator confusion using same field for count and total
This works fine in 4GL:... Constantin Asofiei
01:06 PM Bug #4484: Accumulator confusion using same field for count and total
Constantin Asofiei wrote:
> Roger, is this limited only for fields? Does FWD convert OK if you replace the field wit...
Roger Borrello
01:02 PM Bug #4484: Accumulator confusion using same field for count and total
Roger, is this limited only for fields? Does FWD convert OK if you replace the field with some variable? Constantin Asofiei
01:01 PM Bug #4484: Accumulator confusion using same field for count and total
Roger Borrello wrote:
> Doing some research related to what makes these aggregate functions _order-dependent_.
>
...
Roger Borrello
11:04 AM Bug #4484: Accumulator confusion using same field for count and total
Doing some research related to what makes these aggregate functions _order-dependent_.
+Run 1+...
Roger Borrello

12/17/2019

05:31 PM Bug #4427: Unable to convert keyword input when used to index into an extent
This still is not fixed, as the java code does not compile. Below is the compilation error of the testcase:... Roger Borrello
04:58 PM Bug #4484: Accumulator confusion using same field for count and total
Roger Borrello wrote:
> Roger Borrello wrote:
> > This looks like the culprit...
> >
> > [...]
> >
> > Would ...
Roger Borrello
04:26 PM Bug #4484: Accumulator confusion using same field for count and total
Roger Borrello wrote:
> This looks like the culprit...
>
> [...]
>
> Would it be simple as removing the check ...
Roger Borrello
04:09 PM Bug #4484: Accumulator confusion using same field for count and total
This looks like the culprit...... Roger Borrello
03:59 PM Bug #4484: Accumulator confusion using same field for count and total
Constantin Asofiei wrote:
> OK, I think this confirms the problem is with COUNT. Look at @process_aggregate@ functi...
Roger Borrello
03:46 PM Bug #4484: Accumulator confusion using same field for count and total
OK, I think this confirms the problem is with COUNT. Look at @process_aggregate@ function in @annotations/accumulate... Constantin Asofiei
03:39 PM Bug #4484: Accumulator confusion using same field for count and total
Constantin Asofiei wrote:
> This might be related to @COUNT@ which doesn't necessarily need the field reference; so,...
Roger Borrello
03:32 PM Bug #4484: Accumulator confusion using same field for count and total
This might be related to @COUNT@ which doesn't necessarily need the field reference; so, please expand your test to r... Constantin Asofiei
03:02 PM Bug #4484: Accumulator confusion using same field for count and total
h1. Testcase
*20191231 Update: Fixed in 4207a-11366*
Checked in: @uast/accum_overlap_count-total.p@...
Roger Borrello
02:55 PM Bug #4484 (Closed): Accumulator confusion using same field for count and total
Roger Borrello
03:18 PM Bug #4483 (WIP): Unable to use logical variable check in underline statement
Roger Borrello
03:16 PM Bug #4483: Unable to use logical variable check in underline statement
Greg Shah wrote:
> The @CONTENT_ARRAY@ is only found in the @MESSAGE@, @ENABLE@, @DISABLE@, @COLOR@ and @UNDERLINE@ ...
Roger Borrello
02:59 PM Bug #4483: Unable to use logical variable check in underline statement
The @CONTENT_ARRAY@ is only found in the @MESSAGE@, @ENABLE@, @DISABLE@, @COLOR@ and @UNDERLINE@ statements, but only... Greg Shah
02:06 PM Bug #4483: Unable to use logical variable check in underline statement
Constantin Asofiei wrote:
> Roger, see the @noUnwrap@ logic - this should decide if @_isEqual@ or @isEqual@ is emitt...
Roger Borrello
12:41 PM Bug #4483: Unable to use logical variable check in underline statement
Roger, see the @noUnwrap@ logic - this should decide if @_isEqual@ or @isEqual@ is emitted, and looks like it depends... Constantin Asofiei
11:59 AM Bug #4483: Unable to use logical variable check in underline statement
Roger Borrello wrote:
> h1. Testcase
>
> Below is the testcase @uast/underline_logic_uses_when.p@:
>
> [...]
...
Roger Borrello
11:55 AM Bug #4483: Unable to use logical variable check in underline statement
h1. Testcase
*20191231 Update: Fixed in 4207a-11357*
Below is the testcase @uast/underline_logic_uses_when.p@:
...
Roger Borrello
11:39 AM Bug #4483 (Closed): Unable to use logical variable check in underline statement
Roger Borrello
01:34 PM Bug #4480: Extent does not become fixed when there is an initial list of values
Greg Shah wrote:
> > But: the same might apply to OO properties, table fields and procedure parameters. So please do...
Roger Borrello
10:30 AM Bug #4482: Enable/Disable with empty EXCEPT causes issues
*Code updates in 4207a-11356.*
@rules/annotations/cleanup.rules@
Roger Borrello
09:27 AM Bug #4482 (WIP): Enable/Disable with empty EXCEPT causes issues
Roger Borrello
09:26 AM Bug #4482: Enable/Disable with empty EXCEPT causes issues
*20191231 Update: Fixed in 4207a-11356*
There is already a testcase that should have found this: @uast/enable_and_...
Roger Borrello
09:23 AM Bug #4482 (Closed): Enable/Disable with empty EXCEPT causes issues
Roger Borrello

12/16/2019

03:50 PM Bug #4480: Extent does not become fixed when there is an initial list of values
> But: the same might apply to OO properties, table fields and procedure parameters. So please do some tests, and if ... Greg Shah
02:26 PM Bug #4480: Extent does not become fixed when there is an initial list of values
Constantin Asofiei wrote:
> Roger, I agree, I think we need to 'fix' the extent when there is an initializer and no ...
Roger Borrello
02:05 PM Bug #4480: Extent does not become fixed when there is an initial list of values
Roger, I agree, I think we need to 'fix' the extent when there is an initializer and no extent value. For variables,... Constantin Asofiei
01:53 PM Bug #4480: Extent does not become fixed when there is an initial list of values
Roger Borrello wrote:
> h1. Testcase @uast/form_tests/form_with_extent.p@
>
> [...]
>
> The message is *Extent...
Roger Borrello
12:45 PM Bug #4480: Extent does not become fixed when there is an initial list of values
h1. Testcase @uast/form_tests/form_with_extent.p@
*20191231 Update: Checked in 4207a-11365*...
Roger Borrello
12:32 PM Bug #4480 (Closed): Extent does not become fixed when there is an initial list of values
Roger Borrello
09:26 AM Bug #4476: Shared frame does not get @ widget method generated
Roger Borrello wrote:
> h1. Testcase
>
> Added 2 testcases (since it is a shared frame)
>
> [...]
>
> [...]...
Roger Borrello

12/13/2019

05:15 PM Feature #3867: direct java class access from 4GL code
Greg Shah wrote:
> Constantin: Do you see any flaw in my logic?
No, I can't see any way to jump to the catch block ...
Constantin Asofiei
04:44 PM Feature #3867: direct java class access from 4GL code
Our current parsing for catch blocks creates an @INNER_BLOCK@ child of the @KW_CATCH@. This results in the following... Greg Shah
03:58 PM Bug #4476: Shared frame does not get @ widget method generated
h1. Testcase
*20200102 Update:* @rules/fixups/inline_format_phrase_var_defs.rules@ checked into *4207a-11369*.
...
Roger Borrello
03:40 PM Bug #4476 (Closed): Shared frame does not get @ widget method generated
Roger Borrello

12/11/2019

04:50 PM Bug #4461: DST and add-interval
My original issue is fixed in 3809e rev 11435, the DateOps change. Constantin Asofiei
12:32 PM Bug #4461: DST and add-interval
I agree that your timestamp approach is probably the right idea for @datetime@/@datetimetz@. We can break the inheri... Greg Shah
05:34 AM Bug #4461: DST and add-interval
This behaviour is somewhat expected. The problem is that we use "convention" time units instead of "physical" axis. O... Ovidiu Maxiniuc
04:50 PM Bug #4462: NOW with comparison operators
The fix is in 3809e rev 11435 . The dereference problem (actually any POLY operand) is still postponed. Constantin Asofiei
02:56 PM Feature #3854: update appserver support with PASOE features
Marian, in PASOE, is the format for @server-connection-id@ always @abcdefghijklm_abcdefgh@? (aka 13 chars, underscore... Constantin Asofiei
10:10 AM Bug #4455 (WIP): Extent field on unsubscripted next-prompt not converted properly
Roger Borrello
10:01 AM Bug #4455: Extent field on unsubscripted next-prompt not converted properly
Greg Shah wrote:
> OK, just add a TODO comment in to the array expansion rules to explain that the range case works ...
Roger Borrello
09:37 AM Bug #4455: Extent field on unsubscripted next-prompt not converted properly
OK, just add a TODO comment in to the array expansion rules to explain that the range case works in the 4GL (acts lik... Greg Shah
09:33 AM Bug #4455: Extent field on unsubscripted next-prompt not converted properly
Greg Shah wrote:
> Yes, that is the safe thing to do. Please also report here if the 4GL allows the range case at a...
Roger Borrello
09:16 AM Bug #4455: Extent field on unsubscripted next-prompt not converted properly
Yes, that is the safe thing to do. Please also report here if the 4GL allows the range case at all. Greg Shah
09:14 AM Bug #4455: Extent field on unsubscripted next-prompt not converted properly
Greg Shah wrote:
> Code Review Task Branch 4207a Revisions 11353 - 11354
>
> The changes are good.
>
> The onl...
Roger Borrello
09:02 AM Bug #4455: Extent field on unsubscripted next-prompt not converted properly
Greg Shah wrote:
> Code Review Task Branch 4207a Revisions 11353 - 11354
>
> The changes are good.
>
> The onl...
Roger Borrello

12/10/2019

06:59 PM Bug #4455: Extent field on unsubscripted next-prompt not converted properly
Code Review Task Branch 4207a Revisions 11353 - 11354
The changes are good.
The only problem is the range exten...
Greg Shah
06:10 PM Bug #4455: Extent field on unsubscripted next-prompt not converted properly
h1. Updated
Below are my updates and findings
h2. rules/annotations/progress_templates.tpl
I have added this...
Roger Borrello
05:24 PM Bug #4455: Extent field on unsubscripted next-prompt not converted properly
Greg Shah wrote:
> > On line 20, I don't have any subscript. This results in AST generation of:
>
> Are you sayin...
Roger Borrello
05:15 PM Bug #4455: Extent field on unsubscripted next-prompt not converted properly
> On line 20, I don't have any subscript. This results in AST generation of:
Are you saying that the @input/extent...
Greg Shah
04:28 PM Bug #4455: Extent field on unsubscripted next-prompt not converted properly
+*New Testcases*+
I have updated the testcase to not use the @p2j_test.df@, instead using TEMP-TABLE. I also added a...
Roger Borrello
03:42 PM Bug #4455: Extent field on unsubscripted next-prompt not converted properly
While building up a testcase to use variables instead of fields, I noticed this situation. It may be a red herring, b... Roger Borrello
01:01 PM Bug #4455: Extent field on unsubscripted next-prompt not converted properly
Please remove the @hidden="true"@. Otherwise it won't work.
> Is the @implied_extent_first_element@ name accurat...
Greg Shah
12:58 PM Bug #4455: Extent field on unsubscripted next-prompt not converted properly
Greg Shah wrote:
> Constantin Asofiei wrote:
> > I think you need to graft only the LBRACKET portion. As a side no...
Roger Borrello
12:14 PM Bug #4455: Extent field on unsubscripted next-prompt not converted properly
Constantin Asofiei wrote:
> I think you need to graft only the LBRACKET portion. As a side note, the fix should be ...
Greg Shah
12:13 PM Bug #4455: Extent field on unsubscripted next-prompt not converted properly
This:... Greg Shah
12:02 PM Bug #4455: Extent field on unsubscripted next-prompt not converted properly
I think you need to graft only the LBRACKET portion. As a side note, the fix should be generic for any extent - be i... Constantin Asofiei
11:58 AM Bug #4455: Extent field on unsubscripted next-prompt not converted properly
Greg Shah wrote:
> There is no documentation/task for "templatizing".
>
> I think the annotations can all be left...
Roger Borrello
11:40 AM Bug #4455: Extent field on unsubscripted next-prompt not converted properly
There is no documentation/task for "templatizing".
I think the annotations can all be left out. The line and colu...
Greg Shah
11:28 AM Bug #4455: Extent field on unsubscripted next-prompt not converted properly
Greg Shah wrote:
> Correct, so long as the child of the @kw_next_pmt@ is the field/var itself. For example, for any...
Roger Borrello
10:02 AM Bug #4455: Extent field on unsubscripted next-prompt not converted properly
Correct, so long as the child of the @kw_next_pmt@ is the field/var itself. For example, for anything with a @form_i... Greg Shah
06:49 PM Bug #4462: NOW with comparison operators
There is a bug in FWD, where a comparison like @dt > NOW@ (where @dt@ is datetime) fails with @Incompatible data type... Constantin Asofiei
06:38 PM Bug #4462 (New): NOW with comparison operators
Constantin Asofiei
06:32 PM Feature #3854: update appserver support with PASOE features
I was looking for some details on the support of the @server-connection-context@ attribute is. I looked at the code, ... Roger Borrello
06:29 PM Bug #4461: DST and add-interval
There's a bug in FWD which is exposed when a DST boundary is reached:... Constantin Asofiei
06:17 PM Bug #4461 (New): DST and add-interval
Constantin Asofiei

12/09/2019

06:14 PM Bug #4455: Extent field on unsubscripted next-prompt not converted properly
Greg Shah wrote:
> I'm not suggesting doing it in core conversion. The alternative idea was to add @next-prompt@ to...
Roger Borrello
05:46 PM Bug #4455: Extent field on unsubscripted next-prompt not converted properly
I'm not suggesting doing it in core conversion. The alternative idea was to add @next-prompt@ to the list of normal ... Greg Shah
05:39 PM Bug #4455: Extent field on unsubscripted next-prompt not converted properly
At core conversion time may be too late to do this, without having to go and 'hack' the frame generation to exclude t... Constantin Asofiei
05:31 PM Bug #4455: Extent field on unsubscripted next-prompt not converted properly
The primary issue is that @next-prompt@ is not honored as a statement in which we do array expansion (because we alwa... Greg Shah
05:23 PM Bug #4455: Extent field on unsubscripted next-prompt not converted properly
> Note that if you remove define shared frame person. the testcase is successful.
This is not the right way to say...
Greg Shah
05:20 PM Bug #4455: Extent field on unsubscripted next-prompt not converted properly
Constantin Asofiei wrote:
> Roger, the @ public FillInWidget widgetSchedule();@ line doesn't seem right, to be gen...
Roger Borrello
05:00 PM Bug #4455: Extent field on unsubscripted next-prompt not converted properly
Roger, the @ public FillInWidget widgetSchedule();@ line doesn't seem right, to be generated. You say that the fir... Constantin Asofiei
04:54 PM Bug #4455: Extent field on unsubscripted next-prompt not converted properly
Roger Borrello wrote:
> h1. Description
>
> When @next-prompt@ is passed an extent field of a shared frame, but n...
Roger Borrello
02:18 PM Bug #4455: Extent field on unsubscripted next-prompt not converted properly
h1. Description
When @next-prompt@ is passed an extent field of a shared frame, but no subscript, we generate an u...
Roger Borrello
01:00 PM Bug #4455 (Closed): Extent field on unsubscripted next-prompt not converted properly
Roger Borrello
02:48 PM Bug #4427 (WIP): Unable to convert keyword input when used to index into an extent
Roger Borrello
02:43 PM Bug #4423 (WIP): Incorrect buffer scoping when same buffer name used as a parameter to internal p...
Roger Borrello

12/06/2019

05:33 PM Bug #4453: Handling of filename with quotation mark broken in control_flow.rules
Greg Shah wrote:
> [...]
>
> I disagree with this. If all three are -1 then the @progressToJavaString()@ is NOT ...
Roger Borrello
05:16 PM Bug #4453: Handling of filename with quotation mark broken in control_flow.rules
... Greg Shah
05:01 PM Bug #4453: Handling of filename with quotation mark broken in control_flow.rules
Constantin Asofiei wrote:
> Rev 10509 was part of #1634 - there's lots of discussion for tilde and quote chars, in p...
Roger Borrello
04:37 PM Bug #4453: Handling of filename with quotation mark broken in control_flow.rules
Rev 10509 was part of #1634 - there's lots of discussion for tilde and quote chars, in paths. Constantin Asofiei
04:15 PM Bug #4453: Handling of filename with quotation mark broken in control_flow.rules
Constantin Asofiei wrote:
> And the implication for my 'garbage suffix' misdirection: if the 4GL code (like @RUN a.p...
Roger Borrello
03:35 PM Bug #4453: Handling of filename with quotation mark broken in control_flow.rules
And the implication for my 'garbage suffix' misdirection: if the 4GL code (like @RUN a.p_garbage@) is tested only wit... Constantin Asofiei
03:03 PM Bug #4453: Handling of filename with quotation mark broken in control_flow.rules
Constantin Asofiei wrote:
> Roger Borrello wrote:
> > When a file name is @runit.p"@ the Java should be @"runit.p\"...
Constantin Asofiei
03:00 PM Bug #4453: Handling of filename with quotation mark broken in control_flow.rules
Roger Borrello wrote:
> When a file name is @runit.p"@ the Java should be @"runit.p\""@.
Argh, I don't understand, ...
Constantin Asofiei
02:55 PM Bug #4453: Handling of filename with quotation mark broken in control_flow.rules
Roger Borrello wrote:
> Roger Borrello wrote:
> > h1. Description
> >
> > A filename with a quotation mark (albe...
Roger Borrello
02:39 PM Bug #4453: Handling of filename with quotation mark broken in control_flow.rules
Roger Borrello wrote:
> h1. Description
>
> A filename with a quotation mark (albeit a typo) is not processed pro...
Roger Borrello
02:38 PM Bug #4453: Handling of filename with quotation mark broken in control_flow.rules
h1. Description
A filename with a quotation mark (albeit a typo) is not processed properly.
h2. Testcase
@ru...
Roger Borrello
02:33 PM Bug #4453 (WIP): Handling of filename with quotation mark broken in control_flow.rules
Roger Borrello

12/05/2019

02:40 PM Feature #3853: implement LOG-MANAGER runtime
As part of this task, we should ensure that the default appserver logging that occurs in the 4GL is fully supported i... Greg Shah

12/04/2019

07:38 AM Feature #3855: implement equivalent support for REST (classic appserver, PASOE REST and WEB trans...
Marian, my questions related to @WebResponseWriter@ are:
* when is the flush happening? What happens if you try to w...
Constantin Asofiei
05:51 AM Feature #3855: implement equivalent support for REST (classic appserver, PASOE REST and WEB trans...
Greg Shah wrote:
> From Constantin:
>
> > We need some help in understanding the @WebHandler@ APIs, but not from ...
Marian Edu
02:12 AM Feature #3853: implement LOG-MANAGER runtime
Greg Shah wrote:
> I have these questions about the content and formatting of the log entries.
>
> * Is @P-999999...
Marian Edu
01:56 AM Feature #3868: customer servlet integration/support
Constantin Asofiei wrote:
> We need a way to force Jetty @WebAppContext@ to use its own jasper libraries, instead of...
Hynek Cihlar

12/03/2019

05:16 PM Feature #3868: customer servlet integration/support
3809e rev 11414 contains changes to add @GenericWebServer@ APIs to load a WAR file in a standalone Jetty server, in t... Constantin Asofiei
05:05 PM Feature #2135: implement COPY-LOB language statement
The changes are in 3809e rev 11414. There are still some issues not addressed (see the TODOs in the code)m and #2135... Constantin Asofiei
01:43 PM Bug #4433: Problem with text concat
I think it is OK to include this in 3820a. Greg Shah
12:15 PM Bug #4433: Problem with text concat
Greg Shah wrote:
> Good point, don't add the @outer:@ label, just add the @inner:@ label and references.
Is it th...
Vladimir Tsichevski
10:09 AM Bug #4433: Problem with text concat
Good point, don't add the @outer:@ label, just add the @inner:@ label and references. Greg Shah
10:08 AM Bug #4433: Problem with text concat
Greg Shah wrote:
> Yes, I think this will work correctly.
>
> Although a careful reading of the code is quite cle...
Vladimir Tsichevski
08:30 AM Bug #4433: Problem with text concat
Yes, I think this will work correctly.
Although a careful reading of the code is quite clear about the behavior, I...
Greg Shah
12:38 PM Feature #3855: implement equivalent support for REST (classic appserver, PASOE REST and WEB trans...
From Constantin:
> We need some help in understanding the @WebHandler@ APIs, but not from the @WebHandler.cls@, he...
Greg Shah
10:26 AM Feature #3853: implement LOG-MANAGER runtime
Consider the following log output examples.... Greg Shah
07:07 PM Bug #4427: Unable to convert keyword input when used to index into an extent
-*This has been fixed in 4207a-11349*- Roger Borrello

12/02/2019

04:55 PM Bug #4433: Problem with text concat
Greg Shah wrote:
> Yes, it would be possible by using @get-string()@ on @memptr@ or @raw@ or with certain forms of s...
Vladimir Tsichevski
03:41 PM Bug #4433: Problem with text concat
Yes, it would be possible by using @get-string()@ on @memptr@ or @raw@ or with certain forms of string literals. See... Greg Shah
03:25 PM Bug #4433: Problem with text concat
Greg Shah wrote:
> In that scenario, the value will be a @BaseDataType@ and if it is the first operand, then the pro...
Vladimir Tsichevski
01:30 PM Bug #4433: Problem with text concat
In that scenario, the value will be a @BaseDataType@ and if it is the first operand, then the proposed change in the ... Greg Shah
01:14 PM Bug #4433: Problem with text concat
Greg Shah wrote:
> I thought we were discussing the approach from #4433-6 in which the code change was not at conver...
Vladimir Tsichevski
01:09 PM Bug #4433: Problem with text concat
I thought we were discussing the approach from #4433-6 in which the code change was not at conversion but only exists... Greg Shah
11:55 AM Bug #4433: Problem with text concat
Greg Shah wrote:
> The first @character@ operand uses @getValue()@ instead of @safeValue()@ in @TextOps.concat()@.
...
Vladimir Tsichevski
11:11 AM Bug #4433: Problem with text concat
The first @character@ operand uses @getValue()@ instead of @safeValue()@ in @TextOps.concat()@. Greg Shah
11:08 AM Bug #4433: Problem with text concat
Greg Shah wrote:
> So then the algorithm needs to be slightly different because the leftmost operand is treated diff...
Vladimir Tsichevski
10:36 AM Bug #4433: Problem with text concat
So then the algorithm needs to be slightly different because the leftmost operand is treated differently than the sub... Greg Shah
10:33 AM Bug #4433: Problem with text concat
Greg Shah wrote:
> I'm asking about in the 4GL. Can the buffer-value sub-expression appear as the leftmost operand ...
Vladimir Tsichevski
08:43 AM Bug #4433: Problem with text concat
I'm asking about in the 4GL. Can the buffer-value sub-expression appear as the leftmost operand of the @+@ concatena... Greg Shah
12:02 PM Bug #4427: Unable to convert keyword input when used to index into an extent
Roger Borrello wrote:
> This same testcase has the issue, so buffers are not the only thing leading to it. It could ...
Roger Borrello
09:16 AM Bug #4424: Additional def var needed to receive table handle when keyword FOR included in def par...
Constantin Asofiei wrote:
> This is fixed in 11347. Please test again.
Both testcases (@tablehandle_parameter_wi...
Roger Borrello
09:07 AM Bug #4424: Additional def var needed to receive table handle when keyword FOR included in def par...
And another reason why @parmrefid@ was also incorrect: a var can be referenced by multiple parameters, not just one. Constantin Asofiei
09:05 AM Bug #4424: Additional def var needed to receive table handle when keyword FOR included in def par...
OK, that works for me. Greg Shah
09:05 AM Bug #4424: Additional def var needed to receive table handle when keyword FOR included in def par...
Greg Shah wrote:
> Code Review Task Branch 4207a Revisions 11346-11347
>
> Overall, the changes look good.
>
>...
Constantin Asofiei
09:01 AM Bug #4424: Additional def var needed to receive table handle when keyword FOR included in def par...
Code Review Task Branch 4207a Revisions 11346-11347
Overall, the changes look good.
One question: in @scope_pro...
Greg Shah
08:13 AM Bug #4424: Additional def var needed to receive table handle when keyword FOR included in def par...
This is fixed in 11347. Please test again. Constantin Asofiei
 

Also available in: Atom