FWD » Core Development » Base Language

05/05/2021

01:50 PM Feature #4350: method overload when they differ by a temp-table, dataset, buffer or object or ext...

I don't recall the @table-handle for@ version, but from what I can see, this case just specifies the real handle var ... Constantin Asofiei

01:35 PM Feature #4350: method overload when they differ by a temp-table, dataset, buffer or object or ext...

Wait, I see 1 difference. The initialization of the @gh@ handle. Is that the only difference that is supposed to be... Greg Shah

01:34 PM Feature #4350: method overload when they differ by a temp-table, dataset, buffer or object or ext...

Constantin: I think the "table-handle for" case has been regressed. Or perhaps I misunderstand the idea.
I found ... Greg Shah

05/04/2021

10:17 AM Feature #4384: Builtin OO Implementation

Branch 4384j was merged into branch 3821c as revision 12363.
Created new branch 4384k from 3821c rev 12363. The n... Greg Shah

08:05 AM Feature #4384: Builtin OO Implementation

Greg Shah wrote:
> It is not merged yet. I just pushed the latest 3821c to xfer (rev 12362). Please post the @bzr ... Marian Edu

07:47 AM Feature #4384: Builtin OO Implementation

It is not merged yet. I just pushed the latest 3821c to xfer (rev 12362). Please post the @bzr send@ of the merged ... Greg Shah

06:05 AM Feature #4384: Builtin OO Implementation

@Greg, did you merged that already and created a new branch that we need to pick-up or not just yet? I have local cha... Marian Edu

04/30/2021

12:33 PM Feature #4384: Builtin OO Implementation

> there are some compatibility and 'business entity' handlers as well as some extra classes I don't remember right no... Greg Shah

12:14 PM Feature #4384: Builtin OO Implementation

Greg Shah wrote:
> > I'm working on dynamic invoke (class/method/ctor) - right now trying to close @ParameterList@
... Marian Edu

12:01 PM Feature #4384: Builtin OO Implementation

> I'm working on dynamic invoke (class/method/ctor) - right now trying to close @ParameterList@
Are the @WebHandle... Greg Shah

09:26 AM Feature #4350: method overload when they differ by a temp-table, dataset, buffer or object or ext...

As part of the shift to a subclass approach for @TableParameter@ and @DataSetParameter@, I'm also making the followin... Greg Shah

04/29/2021

11:04 AM Feature #4384: Builtin OO Implementation

> was that done on purpose, is there a catch or I can just replace that with @BaseDataType.incompatibleTypesOnConvers... Greg Shah

09:14 AM Feature #4350: method overload when they differ by a temp-table, dataset, buffer or object or ext...

Greg Shah wrote:
> Don't we already process parent interfaces before child interfaces and imlemented interfaces be... Constantin Asofiei

08:53 AM Feature #4350: method overload when they differ by a temp-table, dataset, buffer or object or ext...

> But non-override methods will need to not collide with any Java method name from the hierarchy (this includes prope... Greg Shah

08:28 AM Feature #4350: method overload when they differ by a temp-table, dataset, buffer or object or ext...

Hmm... a two-pass approach I think it might work.
But non-override methods will need to not collide with any Java ... Constantin Asofiei

08:17 AM Feature #4350: method overload when they differ by a temp-table, dataset, buffer or object or ext...

My idea was this:
* We already convert the entire parent hierarchy before any child classes.
* In the parent, we ... Greg Shah

02:51 AM Feature #4350: method overload when they differ by a temp-table, dataset, buffer or object or ext...

The main reason this is JVM wide is because I couldn't find a way to solve this case.
You have a @Foo.m1@ and @Foo... Constantin Asofiei

08:24 AM Bug #5296: output parameters are cleared if an argument is another function call

Since we are making this change, we could modify the @wrap()@ to be @outputParm()@ or @inputOututParm()@ and remove t... Greg Shah

08:08 AM Bug #5296: output parameters are cleared if an argument is another function call

It doesn't work to move this registration at @init()@, because the reference needs to change - and in lambda we can't... Constantin Asofiei

07:43 AM Bug #5296: output parameters are cleared if an argument is another function call

Code Review Task Branch 3821c Revision 12345
The changes themselves should do what you intend.
The biggest issu... Greg Shah

05:57 AM Bug #5296: output parameters are cleared if an argument is another function call

The current changes are too aggressive, I need to limit them for only if there are OUTPUT/INPUT-OUTPUT parameters on ... Constantin Asofiei

04/28/2021

05:43 PM Feature #4350: method overload when they differ by a temp-table, dataset, buffer or object or ext...

@SymbolResolver.WorkArea.javaMethodCollisions@ is a JVM-wide map that stores the javaname mapped to a given Java sign... Greg Shah

03:19 PM Bug #5296 (WIP): output parameters are cleared if an argument is another function call

The fix is in 3821c rev 12345
An improvement would be to emit @evaluate(() -> ...)@ only if there are no output/in... Constantin Asofiei

02:10 PM Bug #5296: output parameters are cleared if an argument is another function call

If a call has output/input-output parameters, and also a function call, then the output argument registration is lost... Constantin Asofiei

02:01 PM Bug #5296 (Closed): output parameters are cleared if an argument is another function call

Constantin Asofiei

11:02 AM Bug #5294: parsing problems for assign-style statements with a OO chained lvalue

In OE, is possible to use an OO property or variable as the lvalue for an assign-style-statement. FWD can't parse th... Constantin Asofiei

10:59 AM Bug #5294 (Closed): parsing problems for assign-style statements with a OO chained lvalue

Constantin Asofiei

07:14 AM Feature #4384: Builtin OO Implementation

I'm working on dynamic invoke (class/method/ctor) - right now trying to close @ParameterList@ - and one aspect we're ... Marian Edu

04/27/2021

03:43 AM Feature #4384: Builtin OO Implementation

Marian Edu wrote:
> There should be plenty of calls like @hCall:set-parameter@ in that file, hCall is a handle and t... Marian Edu

03:31 AM Feature #4384: Builtin OO Implementation

Constantin Asofiei wrote:
> I don't see @call:set-parameter@ used here.
There should be plenty of calls like @hCa... Marian Edu

03:21 AM Feature #4384: Builtin OO Implementation

Marian Edu wrote:
> Constantin Asofiei wrote:
> > Marian, please point me to the test which fails.
>
> oo/progre... Constantin Asofiei

03:14 AM Feature #4384: Builtin OO Implementation

Constantin Asofiei wrote:
> Marian, please point me to the test which fails.
oo/progress/lang/parameter_list/test... Marian Edu

03:11 AM Feature #4384: Builtin OO Implementation

Marian, please point me to the test which fails. Constantin Asofiei

01:45 AM Feature #4384: Builtin OO Implementation

Marian Edu wrote:
> It gives "No param_index annotation found"... hmm, looking at it in our tests we also use @set-p... Marian Edu

01:37 AM Feature #4384: Builtin OO Implementation

Constantin, we have an issue with the conversion for tests that uses @Progress.Lang.ParameterList.setParameter@ metho... Marian Edu

04/26/2021

06:11 PM Bug #5288: Some date field character comparisons have runtime incompatibilities during runtime

This use case actually comes back true instead of false, as happens in 4GL:... Roger Borrello

04:33 PM Bug #5288: Some date field character comparisons have runtime incompatibilities during runtime

I think I understand what you are saying. This situations comes up when a new @date@ is created in an effort to perfo... Roger Borrello

01:15 PM Bug #5288: Some date field character comparisons have runtime incompatibilities during runtime

This testcase isn't about regular date processing. It is about polymorphic type processing. All the @buffer-field()... Greg Shah

12:07 PM Bug #5288: Some date field character comparisons have runtime incompatibilities during runtime

This update to the @date(BaseDataType)@ constructor does create @Unknown@ when an empty string is passed in:... Roger Borrello

10:55 AM Bug #5288: Some date field character comparisons have runtime incompatibilities during runtime

Roger Borrello wrote:
> Just swapping the comparison operands so we go into @text.compareTo@ instead of @date.compar... Roger Borrello

09:38 AM Bug #5288: Some date field character comparisons have runtime incompatibilities during runtime

Constantin Asofiei wrote:
> Roger Borrello wrote:
> > Also, still awaiting review of the update mentioned in #5215-... Roger Borrello

09:27 AM Bug #5288: Some date field character comparisons have runtime incompatibilities during runtime

Comparisons of @date@ fields to certain characters have problems. See testcase:... Roger Borrello

09:19 AM Bug #5288 (New): Some date field character comparisons have runtime incompatibilities during runtime

Roger Borrello

08:53 PM Feature #4350: method overload when they differ by a temp-table, dataset, buffer or object or ext...

All of the following cases are converted to @TableParameter@:
* @INPUT TABLE@
* @INPUT-OUTPUT TABLE@
* @OUTPUT T... Greg Shah

04/22/2021

03:28 PM Bug #5278: IMPORT UNFORMATTED raw with a process stream

In OE, you can call @IMPORT UNFORMATTED@ on a raw variable, with a file or process stream. In case of file, it behav... Constantin Asofiei

03:25 PM Bug #5278 (New): IMPORT UNFORMATTED raw with a process stream

Constantin Asofiei

08:44 AM Bug #5276: resolve issues with multi-byte character processing

We need to review our text processing (throughout the FWD runtime) to ensure that multi-byte character processing is ... Greg Shah

08:37 AM Bug #5276 (New): resolve issues with multi-byte character processing

Greg Shah

04/20/2021

07:20 PM Bug #4754 (Closed): DYNAMIC-FUNCTION parsing fails when first parameter is not an expression

Greg Shah

05:53 PM Bug #4754: DYNAMIC-FUNCTION parsing fails when first parameter is not an expression

All is well... at least as far as this task is concerned. Roger Borrello

04:32 PM Bug #4754: DYNAMIC-FUNCTION parsing fails when first parameter is not an expression

No, @DYNAMIC-FUNCTION()@ is not used in that code. If you confirm all is well, I will close it. Greg Shah

04:09 PM Bug #4754: DYNAMIC-FUNCTION parsing fails when first parameter is not an expression

Was this waiting for the large ChUI regression to complete in order to be closed? Roger Borrello

03:39 PM Support #4032: block/transaction processing context-local and other performance improvements

I had previously created the NO_TRANSACTION task in #4149. Greg Shah

12:34 PM Bug #4741 (Closed): RUN statement with a path to a procedure that does not have any extension fai...

Greg Shah

12:04 PM Bug #4741 (Review): RUN statement with a path to a procedure that does not have any extension fai...

I cannot see any reason to leave this task open. Roger Borrello

07:56 AM Feature #4350: method overload when they differ by a temp-table, dataset, buffer or object or ext...

Greg Shah wrote:
> My changes have certainly broken this part.
>
> > Note that for table-handle and dataset-handl... Constantin Asofiei

07:46 AM Feature #4350: method overload when they differ by a temp-table, dataset, buffer or object or ext...

My changes have certainly broken this part.
> Note that for table-handle and dataset-handle, the 4GL argument type... Greg Shah

04/19/2021

03:33 PM Feature #4350: method overload when they differ by a temp-table, dataset, buffer or object or ext...

The dataset-handle vs dataset and table-handle vs table already works in 3821c - I've tested these methods and they c... Constantin Asofiei

03:24 PM Feature #4350: method overload when they differ by a temp-table, dataset, buffer or object or ext...

It looks like we don't handle table paramter or dataset parameter overloading of the method definitions themselves. ... Greg Shah

10:34 AM Feature #4366: support TLS 1.2 and other updated secure socket protocols

Greg Shah wrote:
> My understanding is that this support is needed for the "socket" (CREATE SOCKET) and "server sock... Roger Borrello

09:01 AM Feature #4384: Builtin OO Implementation

Constantin Asofiei wrote:
> The FWD server must be started from @deploy/server@, and if you start it from Eclipse, y... Marian Edu

07:00 AM Feature #4384: Builtin OO Implementation

The FWD server must be started from @deploy/server@, and if you start it from Eclipse, you must use the p2j.jar in yo... Constantin Asofiei

06:57 AM Feature #4384: Builtin OO Implementation

Constantin Asofiei wrote:
> Actually, the @oepas1.goldencode.web@ name is from the @webhandlers.properties@ file, so... Marian Edu

05:12 AM Feature #4384: Builtin OO Implementation

Actually, the @oepas1.goldencode.web@ name is from the @webhandlers.properties@ file, so that is OK. I've uploaded t... Constantin Asofiei

05:03 AM Feature #4384: Builtin OO Implementation

Constantin Asofiei wrote:
> Yes, that's the reason I think. The @file-cvt-list.txt.soap.rest.webhandler@ I mentione... Marian Edu

04:58 AM Feature #4384: Builtin OO Implementation

Yes, that's the reason I think. The @file-cvt-list.txt.soap.rest.webhandler@ I mentioned uses the @./FwdHandler.cls@... Constantin Asofiei

04:54 AM Feature #4384: Builtin OO Implementation

Constantin Asofiei wrote:
> Please upload your fwdhandler.java.
Looking for this?... Marian Edu

04:49 AM Feature #4384: Builtin OO Implementation

The differences you see in directory.xml after each FWD server start are because of some temporary accounts being re-... Constantin Asofiei

04:44 AM Feature #4384: Builtin OO Implementation

Constantin Asofiei wrote:
> Did you convert using the @file-cvt-list.txt.soap.rest.webhandler@ list?
Yes I did, as... Marian Edu

04:26 AM Feature #4384: Builtin OO Implementation

Did you convert using the @file-cvt-list.txt.soap.rest.webhandler@ list? Are you using testcases revision 1042 or lat... Constantin Asofiei

04:16 AM Feature #4384: Builtin OO Implementation

Constantin Asofiei wrote:
> The endpoints in SoapUI were set as these:
> * @https://localhost:7443/web@ for the web... Marian Edu

04:08 AM Feature #4384: Builtin OO Implementation

The endpoints in SoapUI were set as these:
* @https://localhost:7443/web@ for the web handler
* @https://localhost:... Constantin Asofiei

02:44 AM Feature #4384: Builtin OO Implementation

https://localhost:7443/web/fwdHandler gives this:... Marian Edu

02:28 AM Feature #4384: Builtin OO Implementation

Argh, JNI... added jvm.dll to PATH and now this:... Marian Edu

02:16 AM Feature #4384: Builtin OO Implementation

Constantin Asofiei wrote:
> The 'workingDir' must exist and be accessible and writeable by whatever 'systemUser' you... Marian Edu

04/16/2021

01:30 PM Support #4032: block/transaction processing context-local and other performance improvements

During work on some transaction processing issues, we've seen that we are providing notifications for a range of serv... Greg Shah

08:41 AM Feature #4384: Builtin OO Implementation

The 'workingDir' must exist and be accessible and writeable by whatever 'systemUser' you've setup in the directory. Constantin Asofiei

08:29 AM Feature #4384: Builtin OO Implementation

Constantin Asofiei wrote:
> The 'address already in use' is for the FWD server socket - is not related to 7443 port.... Marian Edu

08:01 AM Feature #4384: Builtin OO Implementation

Constantin Asofiei wrote:
> The 'address already in use' is for the FWD server socket - is not related to 7443 port.... Marian Edu

08:00 AM Feature #4384: Builtin OO Implementation

If you haven't already, try @netstat -an@ to see what open ports you have.
Constantin Asofiei

07:45 AM Feature #4384: Builtin OO Implementation

The 'address already in use' is for the FWD server socket - is not related to 7443 port. What command do you use to ... Constantin Asofiei

07:07 AM Feature #4384: Builtin OO Implementation

Constantin Asofiei wrote:
> Marian, see [[p2j:Client_Installation_Windows]] for what is required to build the native... Marian Edu

04/15/2021

03:31 PM Feature #4350: method overload when they differ by a temp-table, dataset, buffer or object or ext...

Greg Shah wrote:
> > We just need to ensure the converted method overloads (which collide via the 'object' parameter... Constantin Asofiei

03:26 PM Feature #4350: method overload when they differ by a temp-table, dataset, buffer or object or ext...

Greg Shah wrote:
> What is this code for:
>
> [...]
For OUTPUT, if the argument is int64 and the -argument- para... Constantin Asofiei

03:09 PM Feature #4350: method overload when they differ by a temp-table, dataset, buffer or object or ext...

What is this code for:... Greg Shah

03:00 PM Feature #4350: method overload when they differ by a temp-table, dataset, buffer or object or ext...

> We just need to ensure the converted method overloads (which collide via the 'object' parameter) have unique names
... Greg Shah

01:47 PM Feature #4350: method overload when they differ by a temp-table, dataset, buffer or object or ext...

Greg Shah wrote:
> I still need some ideas on the object widening/narrowing.
What do you mean here? If is the over... Constantin Asofiei

01:37 PM Feature #4350: method overload when they differ by a temp-table, dataset, buffer or object or ext...

Greg Shah wrote:
> I've put a complete implementation of the fuzzy matching together, including fixes for many laten... Constantin Asofiei

01:15 PM Feature #4350: method overload when they differ by a temp-table, dataset, buffer or object or ext...

Greg Shah wrote:
> Yes, this is what I mean. For example, for a widening match (happens in INPUT mode) from @intege... Constantin Asofiei

01:03 PM Feature #4350: method overload when they differ by a temp-table, dataset, buffer or object or ext...

I still need some ideas on the object widening/narrowing AND on the @FUZZY TYPE EXTENT detected@ case from #4350-31. Greg Shah

01:02 PM Feature #4350: method overload when they differ by a temp-table, dataset, buffer or object or ext...

> BTW, all the fuzzy logic which you do at parsing time to find the proper matching method so it can be directly call... Greg Shah

12:57 PM Feature #4350: method overload when they differ by a temp-table, dataset, buffer or object or ext...

> Sorry, I don't really see what you mean by 'override'.
>
> But if you are referring to do something special with ... Greg Shah

12:41 PM Feature #4350: method overload when they differ by a temp-table, dataset, buffer or object or ext...

Greg Shah wrote:
> > What's the goal here? If the fuzzy match finds the correct method, I don't see what is needed f... Constantin Asofiei

12:32 PM Feature #4350: method overload when they differ by a temp-table, dataset, buffer or object or ext...

>> Buffers cannot match anything other than the same DMO. There is no fuzzy matching for them. I shouldn't have inclu... Greg Shah

11:28 AM Feature #4350: method overload when they differ by a temp-table, dataset, buffer or object or ext...

Greg Shah wrote:
> Buffers cannot match anything other than the same DMO. There is no fuzzy matching for them. I s... Constantin Asofiei

11:03 AM Feature #4350: method overload when they differ by a temp-table, dataset, buffer or object or ext...

> > 4. I need some feedback on what we should be coding for buffers, tables, datasets, table-handles and dataset-hand... Greg Shah

10:50 AM Feature #4350: method overload when they differ by a temp-table, dataset, buffer or object or ext...

> Also, I don't understand how widening/narrowing is involved with OO arguments - if you have two colliding (in terms... Greg Shah

06:02 AM Feature #4350: method overload when they differ by a temp-table, dataset, buffer or object or ext...

Greg Shah wrote:
> 1. Use of @parm.getType() == PARAMETER@.
>
> This is only matched when the parser uses @param_... Constantin Asofiei

09:29 PM Feature #4350: method overload when they differ by a temp-table, dataset, buffer or object or ext...

I've been analyzing @ClassDefinition.annotateCallSignature()@ to determine what I need to record during the fuzzy mat... Greg Shah

01:00 PM Feature #4384: Builtin OO Implementation

Marian Edu wrote:
> > My problem with this idea is method definitions like this in @WebHandler@: @HandleGet( input p... Constantin Asofiei

11:10 AM Feature #4384: Builtin OO Implementation

Marian, see [[p2j:Client_Installation_Windows]] for what is required to build the native part.
I think only libffi... Constantin Asofiei

09:29 AM Feature #4384: Builtin OO Implementation

Constantin Asofiei wrote:

> If you can access the Web client from Windows (a.k.a. you can run @install_spawner.cm... Marian Edu

02:28 AM Feature #4384: Builtin OO Implementation

Constantin Asofiei wrote:
> Marian Edu wrote:
> > Constantin, since the @WebHandler@ is the one that you initialize... Marian Edu

04/14/2021

02:13 PM Feature #4384: Builtin OO Implementation

Marian Edu wrote:
> Constantin, since the @WebHandler@ is the one that you initialize and already expose the "respon... Constantin Asofiei

01:45 PM Feature #4384: Builtin OO Implementation

Marian Edu wrote:
> Marian Edu wrote:
> > Since for our tests we're using a custom @WebResponseWriter@ that redirec... Constantin Asofiei

04/13/2021

03:19 PM Feature #4350: method overload when they differ by a temp-table, dataset, buffer or object or ext...

I've put a complete implementation of the fuzzy matching together, including fixes for many latent problems. I'm now... Greg Shah

08:01 AM Feature #4384: Builtin OO Implementation

Constantin, since the @WebHandler@ is the one that you initialize and already expose the "response" from there for th... Marian Edu

06:17 AM Feature #4384: Builtin OO Implementation

Marian Edu wrote:
> Since for our tests we're using a custom @WebResponseWriter@ that redirects the @web-stream@ to ... Marian Edu

05:49 AM Feature #4384: Builtin OO Implementation

Since for our tests we're using a custom @WebResponseWriter@ that redirects the @web-stream@ to a file in @open@ we c... Marian Edu

04/12/2021

01:42 PM Feature #4384: Builtin OO Implementation

Constantin Asofiei wrote:
> Marian, I think to find out how this web stream works, we need tests which use headers... Marian Edu

01:29 PM Feature #4384: Builtin OO Implementation

Adding a @setHeader@ after the @write@ call is a no-op - the header is discarded.... Constantin Asofiei

12:45 PM Feature #4384: Builtin OO Implementation

Greg Shah wrote:
> What do we need to do to properly implement a compatible @WEB-STREAM@ stream-handle? Unless abso... Marian Edu

09:10 AM Feature #4384: Builtin OO Implementation

What do we need to do to properly implement a compatible @WEB-STREAM@ stream-handle? Unless absolutely needed, I don... Greg Shah

09:02 AM Feature #4384: Builtin OO Implementation

Constantin Asofiei wrote:
> Marian, I think the 'web stream' has the entire message which would be sent over the soc... Marian Edu

08:53 AM Feature #4384: Builtin OO Implementation

Marian, I think the 'web stream' has the entire message which would be sent over the socket to the HTTP response (inc... Constantin Asofiei

07:54 AM Feature #4384: Builtin OO Implementation

Greg Shah wrote:
> > openedge.web.webhandler
> > openedge.web.webresponsewriter
>
> What is needed to finish the... Marian Edu

04/09/2021

04:32 PM Bug #4766: fix CHR and ASC

> chr(-1, "1252", "1252") will actually return a value but it is meaningless (ÿÿÿÿÿÿÿÿ1). Also it seems to alter over... Greg Shah

03:24 PM Bug #4766: fix CHR and ASC

Some work has been done and now 3821c/12257 has improved support for @CHR@ and @ASC@ functions. Both of them will han... Ovidiu Maxiniuc

04/08/2021

10:07 AM Feature #4762: localize system error messages

> This is just the first step toward fully I18n of the error messages. The big switch can be now easily extracted to:... Greg Shah

10:00 AM Feature #4762: localize system error messages

Starting with my work for datasets I added some new APIs in @ErrorManager@ which allows to raise (throw/display) erro... Ovidiu Maxiniuc

06:53 AM Feature #4768 (Closed): finish copy-lob support

Greg Shah

12:12 AM Feature #4768: finish copy-lob support

I found some edge-cases where the @memptr@ behaves differently and adjusted the code accordingly.
The CLOB support w... Ovidiu Maxiniuc

06:52 AM Feature #4378 (Closed): properly handle clob/lonchar assignment, especially the implicit codepage...

Greg Shah

12:06 AM Feature #4378 (WIP): properly handle clob/lonchar assignment, especially the implicit codepage co...

The COPY-LOB issues (conversion and dereferenciation) are fixed in a previous commit 3821c/12222.
Instead of chan... Ovidiu Maxiniuc