Project

General

Profile

Activity

From 05/28/2021 to 06/26/2021

06/25/2021

11:44 AM Bug #5294: parsing problems for assign-style statements with a OO chained lvalue
Code Review Eclipse Diff in #5294-2
1. The @lvalue@ to @chained_object_members@ change makes sense. I suspect the...
Greg Shah

06/22/2021

10:29 AM Feature #4384: Builtin OO Implementation
4384k was merged to 3821c/12558. 3821c/12559 fixes some regressions.
Created 4384l from 3821c/12559.
Constantin Asofiei
09:25 AM Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> Marian, I think we should try to automate running the tests on the xfer repository.
>
...
Marian Edu
07:27 AM Feature #4384: Builtin OO Implementation
> can we push 3821c/12557 to xfer?
Done.
Greg Shah
06:03 AM Feature #4384: Builtin OO Implementation
Marian, I think we should try to automate running the tests on the xfer repository.
For example: I see that you ar...
Constantin Asofiei
05:47 AM Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> There are some regressions related to CALL. I need to fix them before being able to mer...
Marian Edu
05:39 AM Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> Constantin Asofiei wrote:
> > Greg, can we push 3821c/12557 to xfer? The patch doesn't compile ...
Constantin Asofiei
04:22 AM Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> Greg, can we push 3821c/12557 to xfer? The patch doesn't compile and I'd like to have 43...
Marian Edu
04:02 AM Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> You mean the @Progress.Reflect.Property@ and @Progress.Reflect.Variable@? These are n...
Marian Edu
03:50 AM Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> Trying to convert some of the tests made for reflection we see the POLY behavior is not implemen...
Constantin Asofiei
03:44 AM Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> Greg Shah wrote:
> > 3821c revision 12542 is now available on xfer.
>
> Attached the patch f...
Constantin Asofiei
03:26 AM Feature #4384: Builtin OO Implementation
Trying to convert some of the tests made for reflection we see the POLY behavior is not implemented for properties/va... Marian Edu
03:22 AM Feature #4384: Builtin OO Implementation
I'm reviewing your patch now, and these constructs (which were fixed) explain what you see:... Constantin Asofiei
02:43 AM Feature #4384: Builtin OO Implementation
Argh, now that I'm looking at it, it does look like the issue we had with the static 'registry' is the same as what w... Marian Edu
02:33 AM Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> Marian, some findings:
> * for a static OO method, the @BlockManager.function@ first ar...
Marian Edu
02:20 AM Feature #4384: Builtin OO Implementation
Greg Shah wrote:
> 3821c revision 12542 is now available on xfer.
Attached the patch for the 4384k merge. Let me ...
Marian Edu

06/17/2021

08:06 AM Bug #5294: parsing problems for assign-style statements with a OO chained lvalue
Greg, the parser patch is this:... Constantin Asofiei
07:23 AM Feature #4384: Builtin OO Implementation
3821c revision 12542 is now available on xfer. Greg Shah
05:25 AM Feature #4384: Builtin OO Implementation
We will notify here when the proper version of 3821c is available on xfer. Greg Shah
05:24 AM Feature #4384: Builtin OO Implementation
We are about to push a new revision of 3821c to xfer. This will include a large number of changes to the OO built-in... Greg Shah

06/14/2021

09:46 AM Bug #5446: PUT UNFORMATTED performace (stream is flushed on each call)
This testcases executes in 4GL almost immediately:... Constantin Asofiei
09:43 AM Bug #5446 (New): PUT UNFORMATTED performace (stream is flushed on each call)
Constantin Asofiei
07:06 AM Bug #5296 (Closed): output parameters are cleared if an argument is another function call
Greg Shah
06:53 AM Bug #5296: output parameters are cleared if an argument is another function call
Greg Shah wrote:
> Is there anything remaining to do in this task?
No, it can be closed.
Constantin Asofiei
06:51 AM Bug #5296: output parameters are cleared if an argument is another function call
Is there anything remaining to do in this task? Greg Shah
06:39 AM Bug #5296: output parameters are cleared if an argument is another function call
I've fixed the dead code issue and merged 5296a/12535 to 3821c 12531.
5296a was archived.
Constantin Asofiei
06:13 AM Bug #5296: output parameters are cleared if an argument is another function call
You can merge 5296a to 3821c. Greg Shah
06:12 AM Bug #5296: output parameters are cleared if an argument is another function call
Code Review Task Branch 5296a Revisions 12533-12534
I only see one minor issue. In @AbstractParameter.postProcess...
Greg Shah
03:37 AM Bug #5296: output parameters are cleared if an argument is another function call
Rebased 5296a from 3821c rev 12530 - new revision 12534.
In 5296a rev 12533 and 12534 I've fixed some other issues...
Constantin Asofiei
09:16 PM Bug #5203: Temp Table - serialization/transaction scope/pk
Ovidiu Maxiniuc wrote:
> Greg Shah wrote:
> > Is this task complete as of 3821c rev 12222?
> Yes. Now all temporar...
Eric Faulhaber

06/12/2021

04:53 PM Bug #5439: com.goldencode.util.Stack problem
The following tests fail:... Vladimir Tsichevski
03:45 PM Bug #5439 (New): com.goldencode.util.Stack problem
Vladimir Tsichevski

06/09/2021

01:51 PM Bug #5296: output parameters are cleared if an argument is another function call
Thanks, those explanations are helpful. Greg Shah
01:09 PM Bug #5296: output parameters are cleared if an argument is another function call
Greg Shah wrote:
> Overall, the update looks reasonable. Unfortunately, my lack of knowledge of the output/input-ou...
Constantin Asofiei
12:51 PM Bug #5296: output parameters are cleared if an argument is another function call
Code Review Task Branch 5296a Revision 12519
Overall, the update looks reasonable. Unfortunately, my lack of know...
Greg Shah
10:48 AM Bug #5296: output parameters are cleared if an argument is another function call
The changes are in 5296a rev 12519. Hotel GUI works OK (conversion and runtime). Please review.
The fix list is ...
Constantin Asofiei
06:39 AM Bug #5296: output parameters are cleared if an argument is another function call
Created task branch 5296a from 3821c rev 12518. Constantin Asofiei
12:57 PM Feature #4384: Builtin OO Implementation
I found only 4 cases which have null, and need to have this set to the class:... Constantin Asofiei
12:20 PM Feature #4384: Builtin OO Implementation
Marian, some findings:
* for a static OO method, the @BlockManager.function@ first argument must be the class (inste...
Constantin Asofiei

06/08/2021

11:42 AM Bug #5296: output parameters are cleared if an argument is another function call
The good news - the entire list of output/input-output parameters in @p2j.oo@ is short, so no need to automate this; ... Constantin Asofiei
11:17 AM Bug #5296: output parameters are cleared if an argument is another function call
So, something I didn't consider before - the hand-written legacy OO implementations in FWD.
Now, the assigner gets...
Constantin Asofiei
 

Also available in: Atom