FWD » Core Development » Base Language

09/14/2021

05:39 PM Feature #4366: support TLS 1.2 and other updated secure socket protocols

OK... because I am having issues with the below, I'll flip-flop the passwords. I get @Unable to prtocess parameters. ... Roger Borrello

04:52 PM Feature #4366: support TLS 1.2 and other updated secure socket protocols

The problem is here:
> @-Dssl-socket:keystore:password=keystore@
In fact, there are two of them:
# use @password@ ... Ovidiu Maxiniuc

04:31 PM Feature #4366: support TLS 1.2 and other updated secure socket protocols

This is what I did (still resulting in the tampered error).... Roger Borrello

08:31 AM Feature #3817: create resource bundles from string literals and implement optional support for se...

Here are a few notes about building the Adetran project. These are on top of the existing documentation.
h2. Build... Hynek Cihlar

09/13/2021

03:10 PM Feature #4366: support TLS 1.2 and other updated secure socket protocols

Roger,
Your key loads in my test procedure(s). They are the exactly the same from @Socket Handle and Server Socket H... Ovidiu Maxiniuc

01:36 PM Feature #4366: support TLS 1.2 and other updated secure socket protocols

That error I get when the password is somehow incorrect. Can you send me the @default_server.store@ you've generated. Ovidiu Maxiniuc

12:32 PM Feature #4366: support TLS 1.2 and other updated secure socket protocols

Ovidiu, I am trying to follow the wiki, and my server source code is the same as your example (except I am using a va... Roger Borrello

09/10/2021

04:00 PM Feature #4366: support TLS 1.2 and other updated secure socket protocols

Yes, the "working" directory is the right work. I have just updated the wiki. Ovidiu Maxiniuc

03:49 PM Feature #4366: support TLS 1.2 and other updated secure socket protocols

In your text, you mention "This .store container must be located in root directory of the FWD-client" and "trusted-ce... Greg Shah

02:17 PM Feature #4366: support TLS 1.2 and other updated secure socket protocols

Greg Shah wrote:
> Ovidiu: Please document the specific requirements. We may need to make code changes to make it e... Ovidiu Maxiniuc

02:03 PM Feature #4366: support TLS 1.2 and other updated secure socket protocols

Roger Borrello wrote:
> Ovidiu, I was using @SSLCertGenUtil@ to do the generation of the keys into the directory ("s... Ovidiu Maxiniuc

07:04 AM Feature #4366: support TLS 1.2 and other updated secure socket protocols

Passing the output from the SSLCertGenUtil cannot work since it is not encoded as hex.
Ovidiu: Please document t... Greg Shah

07:28 AM Feature #4384: Builtin OO Implementation

Greg Shah wrote:
> > * @SERIALIZABLE@ keyword should probably be used by conversion to make the class implement @Ser... Marian Edu

09/09/2021

06:29 PM Feature #4366: support TLS 1.2 and other updated secure socket protocols

Greg Shah wrote:
> Roger: Please ask Ovidiu specific questions to get help with this configuration. Also, after Ovi... Roger Borrello

09:46 AM Feature #4366: support TLS 1.2 and other updated secure socket protocols

Ovidiu: Please edit [[p2j:Certificates_and_Keys_for_4GL_Language_Features#Socket-Handle-and-Server-Socket-Handle-SSL-... Greg Shah

08:26 AM Feature #4366: support TLS 1.2 and other updated secure socket protocols

If you look at the code for @SymmetricEncryption.decrypt()@, you'll see that in @asBytes()@ it assumes that the input... Greg Shah

08:17 AM Feature #4366: support TLS 1.2 and other updated secure socket protocols

Greg Shah wrote:
> Is that what you expect? If the actual key password has 2 tildes, then you need to double them i... Roger Borrello

07:15 AM Feature #4366: support TLS 1.2 and other updated secure socket protocols

The tilde is an escape char in the 4GL. If your code is this:
@define variable kapw as char init "v~~4l#8ZrkkJwW?... Greg Shah

09/08/2021

06:20 PM Feature #4366: support TLS 1.2 and other updated secure socket protocols

I am back to testing with my testcases...the @ssl-server.p@ has:... Roger Borrello

04:21 PM Feature #4366 (Test): support TLS 1.2 and other updated secure socket protocols

Code Review Task Branch 3821c Revision 12901
The changes look good. Greg Shah

03:27 PM Feature #4366 (Feedback): support TLS 1.2 and other updated secure socket protocols

Please review:... Roger Borrello

08:18 AM Feature #4366: support TLS 1.2 and other updated secure socket protocols

Greg Shah wrote:
> > This is not correct, there is no @LowLevelSocketImpl@ usage for the @WebServiceImpl@ at this ti... Constantin Asofiei

07:33 AM Feature #4366: support TLS 1.2 and other updated secure socket protocols

> This is not correct, there is no @LowLevelSocketImpl@ usage for the @WebServiceImpl@ at this time.
Does anyone k... Greg Shah

04:25 AM Feature #4366: support TLS 1.2 and other updated secure socket protocols

Greg Shah wrote:
> +WEB-SERVICE:CONNECT()+
>
> On the server, a call to @<web_service_handle>:CONNECT()@ will pa... Constantin Asofiei

12:26 PM Feature #5662: add -WSDLAuth and -SSLAuth (and related) connect options for the web-services handle

These connect options (and the key/cert related options) were added after OE 10.2B which was the initial implemented ... Greg Shah

12:24 PM Feature #5662 (New): add -WSDLAuth and -SSLAuth (and related) connect options for the web-service...

Greg Shah

10:08 AM Bug #4766: fix CHR and ASC

Code Review Task Branch 3821c Revision 12898
The changes look good. Greg Shah

08:25 AM Feature #4384: Builtin OO Implementation

> * @SERIALIZABLE@ keyword should probably be used by conversion to make the class implement @Serializable@ so we can... Greg Shah

04:49 AM Feature #4384: Builtin OO Implementation

Going through all tests to see if still passing, update implementation as needed (other changes did impact the test r... Marian Edu

09/07/2021

05:03 PM Feature #4366: support TLS 1.2 and other updated secure socket protocols

> but we still need a way to determine what to pass in the #4366-21 when @LowLevelSocketImpl.initialize@ creates the ... Greg Shah

03:08 PM Feature #4366: support TLS 1.2 and other updated secure socket protocols

Greg Shah wrote:
> I don't know for sure, but I suspect that @LowLevelSocketListenerImpl.enableSSLConnections()@ sho... Roger Borrello

02:34 PM Feature #4366: support TLS 1.2 and other updated secure socket protocols

I don't know for sure, but I suspect that @LowLevelSocketListenerImpl.enableSSLConnections()@ should be using @"SSL"@. Greg Shah

02:23 PM Feature #4366: support TLS 1.2 and other updated secure socket protocols

In examining the difference between the @src/com/goldencode/p2j/util/LowLevelSocketImpl.java@ and @src/com/goldencode... Roger Borrello

10:56 AM Feature #4366: support TLS 1.2 and other updated secure socket protocols

First, let's note that the various versions of SSL are not the same as the various TLS versions. There are slight in... Greg Shah

10:21 AM Feature #4366: support TLS 1.2 and other updated secure socket protocols

Greg Shah wrote:
> Perhaps we should force it to the 1.2 level. Since a v1 or v1.1 peer can negotiate the connectio... Roger Borrello

04:09 PM Bug #4766: fix CHR and ASC

The fix for @chr(0)@ was committed in revision 12898/3821c. Ovidiu Maxiniuc

09:12 AM Bug #4766: fix CHR and ASC

Nice catch. The problem is not actually in @I18nOps@ (which converts @chr(0)@ to @"\0"@) but in @character@ construct... Ovidiu Maxiniuc

08:39 AM Bug #4766: fix CHR and ASC

Ovidiu Maxiniuc wrote:
> Marian Edu wrote:
> > [...] There was previously a condition in @I18nOps@ that returned nu... Marian Edu

08:26 AM Bug #4766: fix CHR and ASC

Marian Edu wrote:
> [...] There was previously a condition in @I18nOps@ that returned null for codes less or equal t... Ovidiu Maxiniuc

08:14 AM Bug #4766: fix CHR and ASC

Marian, please provide the (isolated) testcases you refer to in note #4766-5. Please specify the active CP(s) you are... Ovidiu Maxiniuc

07:06 AM Bug #4766: fix CHR and ASC

This is probably still a work in progress but just mentioned this here since we've found some of our tests in OO impl... Marian Edu

09/06/2021

03:49 PM Bug #5651: conditions raised from a finally block

I think we need to handle all the cases now. We can't know what minor edit will cause new cases to be used tomorrow ... Greg Shah

09:55 AM Bug #5651: conditions raised from a finally block

I just found that another customer application is using @RETURN "<val>"@ from the finally block.
I'll right a repo... Constantin Asofiei

07:27 AM Bug #5651: conditions raised from a finally block

I think you can go ahead with the change. Greg Shah

09/04/2021

05:49 AM Bug #5651: conditions raised from a finally block

Greg Shah wrote:
> Agreed. Please put a new try/finally in like this from @processRetry()@:
>
> [...]
>
> I d... Constantin Asofiei

09/03/2021

02:32 PM Bug #5651: conditions raised from a finally block

Make sure to put your testcases in @testcases/uast/finally/@ and update the readme there. Greg Shah

02:32 PM Bug #5651: conditions raised from a finally block

> My first problem is that I don't see how to distinguish between @undo, leave@ and @leave@, when is caught via @Leav... Greg Shah

01:58 PM Bug #5651 (WIP): conditions raised from a finally block

Looks like the following are consumed from a @finally@ block:... Constantin Asofiei

12:00 PM Bug #5651: conditions raised from a finally block

@TransactionManager.processFinallyBlock@ is not protected at all for conditions raised from within the finally block.... Constantin Asofiei

11:54 AM Bug #5651 (WIP): conditions raised from a finally block

Constantin Asofiei

01:54 PM Feature #4366: support TLS 1.2 and other updated secure socket protocols

Perhaps we should force it to the 1.2 level. Since a v1 or v1.1 peer can negotiate the connection down to the older ... Greg Shah

12:51 PM Feature #4366: support TLS 1.2 and other updated secure socket protocols

Roger Borrello wrote:
> Igor Skornyakov wrote:
> > Roger,
> > As far as I know the TLS versions prior to 1.2 are c... Igor Skornyakov

12:46 PM Feature #4366: support TLS 1.2 and other updated secure socket protocols

Igor Skornyakov wrote:
> Roger,
> As far as I know the TLS versions prior to 1.2 are considered obsolete now. Since... Roger Borrello

10:28 AM Feature #4366: support TLS 1.2 and other updated secure socket protocols

Roger Borrello wrote:
> Ovidiu, Igor, is there any need to allow the custom @SSLProtocolSocketFactory@ defined in th... Igor Skornyakov

10:19 AM Feature #4366: support TLS 1.2 and other updated secure socket protocols

Ovidiu, Igor, is there any need to allow the custom @SSLProtocolSocketFactory@ defined in the @LowLevelSocketImpl.ini... Roger Borrello

09:06 AM Feature #4366: support TLS 1.2 and other updated secure socket protocols

Greg Shah wrote:
> @ThinClient.initializePost()@ is only called once at startup of the session so it is not suitable... Roger Borrello

08:55 AM Feature #4366: support TLS 1.2 and other updated secure socket protocols

Thanks for the tips... I'll take a look. Roger Borrello

07:27 AM Feature #4366: support TLS 1.2 and other updated secure socket protocols

> I have most all of this task coded up, but I am unsure of one aspect. I have added a String protocol parameter that... Greg Shah

09/02/2021

05:33 PM Feature #4366: support TLS 1.2 and other updated secure socket protocols

I have most all of this task coded up, but I am unsure of one aspect. I have added a *String protocol* parameter that... Roger Borrello

03:23 PM Feature #4366: support TLS 1.2 and other updated secure socket protocols

Greg Shah wrote:
> I like your original idea of providing a range of string parameters. If the chosen secure socket... Roger Borrello

02:31 PM Feature #4366: support TLS 1.2 and other updated secure socket protocols

> perhaps we should just have -tls as an additional option, which would generate the TLSv1.2 context?
No, I think ... Greg Shah

02:25 PM Feature #4366: support TLS 1.2 and other updated secure socket protocols

When @-ssl@ is passed in the @ENABLE-CONNECTIONS@ string @LowLevelSocketListerner.enableSSLConnections@ performs:
<p... Roger Borrello

11:46 AM Feature #4366: support TLS 1.2 and other updated secure socket protocols

Ovidiu Maxiniuc wrote:
> Most likely at this point @keyStorePassword@ was an empty @String@.
Thanks, Ovidiu. That... Roger Borrello

07:54 AM Feature #4366: support TLS 1.2 and other updated secure socket protocols

Roger Borrello wrote:
> It's not a question of getting hung up. I would expect that for any algorithm I add, there w... Ovidiu Maxiniuc

09:10 AM Feature #3817: create resource bundles from string literals and implement optional support for se...

The attached is the zipped archive of the https://github.com/gquerret/adetran project sources. I'm also attaching the... Hynek Cihlar

08:48 AM Feature #3817: create resource bundles from string literals and implement optional support for se...

Hynek alerted me to the following interesting articles:
https://knowledgebase.progress.com/articles/Article/Transl... Greg Shah

07:21 AM Feature #3817: create resource bundles from string literals and implement optional support for se...

Yes, but you should base it on 3821c. Greg Shah

07:04 AM Feature #3817: create resource bundles from string literals and implement optional support for se...

Greg, should I create new task branch for the changes? Hynek Cihlar

07:01 AM Feature #3817 (WIP): create resource bundles from string literals and implement optional support ...

Hynek Cihlar

09/01/2021

06:40 PM Feature #4366: support TLS 1.2 and other updated secure socket protocols

Greg Shah wrote:
> Please see #2181 for details on the existing 4GL-compatible SSL socket support. Search on "keyst... Roger Borrello

03:15 PM Feature #4366: support TLS 1.2 and other updated secure socket protocols

Please see #2181 for details on the existing 4GL-compatible SSL socket support. Search on "keystore" and "default_se... Greg Shah

03:08 PM Feature #4366: support TLS 1.2 and other updated secure socket protocols

Constantin Asofiei wrote:
> I suspect the correct location is in the @deploy/client@ folder or wherever the FWD clie... Roger Borrello

02:47 PM Feature #4366: support TLS 1.2 and other updated secure socket protocols

I suspect the correct location is in the @deploy/client@ folder or wherever the FWD client working dir is. Constantin Asofiei

02:45 PM Feature #4366: support TLS 1.2 and other updated secure socket protocols

Actually, the @keyStoreName@ cannot be found. I tried to copy @./deploy/server/standard-private-key.store@ to @defaul... Roger Borrello

02:42 PM Feature #4366: support TLS 1.2 and other updated secure socket protocols

> @KeyStore ks = KeyStore.getInstance("JKS"); <-- I believe this comes back null@
That doesn't so... Greg Shah

01:02 PM Feature #4366: support TLS 1.2 and other updated secure socket protocols

The testcases I found in @uast/sockets@ and @uast/sockets/ssl@ are very helpful. However, I may need a little help co... Roger Borrello

06:39 AM Feature #4366: support TLS 1.2 and other updated secure socket protocols

And which doesn't conflict with existing syntax from the 4GL. Greg Shah

06:38 AM Feature #4366: support TLS 1.2 and other updated secure socket protocols

It is our own syntax. This is a new feature/enhancement. Just make the syntax anything that makes sense and is easy... Greg Shah

08/31/2021

04:59 PM Feature #4366: support TLS 1.2 and other updated secure socket protocols

Does 4GL already have syntax to enable this? Or are we making up our own?
In looking for the best documentation, i... Roger Borrello

08:16 AM Bug #5635: OpenEdge.Core.Util.ConfigBuilder implementation

The current implementation is not fully compatible with 4GL because is is using a @Map@ to store the key/value pairs ... Marian Edu

08:16 AM Bug #5635 (New): OpenEdge.Core.Util.ConfigBuilder implementation

Marian Edu

08/20/2021

12:07 PM Bug #5613: 4GL built-in functions throw IllegalArgumentException

Please make a list of all of the cases you have found. It is OK to just list the names of the 4GL programs in the @t... Greg Shah

11:32 AM Bug #5613: 4GL built-in functions throw IllegalArgumentException

Greg Shah wrote:
> Igor: Let's avoid using the term "UDF" here since that is specific to database WHERE clause execu... Igor Skornyakov

10:52 AM Bug #5613: 4GL built-in functions throw IllegalArgumentException

Igor: Let's avoid using the term "UDF" here since that is specific to database WHERE clause execution. The problem h... Greg Shah

10:50 AM Bug #5613: 4GL built-in functions throw IllegalArgumentException

From Igor:
> Some Java counterparts of 4GL functions which are called directly from the converted code can throw @... Greg Shah

10:50 AM Bug #5613 (New): 4GL built-in functions throw IllegalArgumentException

Greg Shah

11:06 AM Feature #3817: create resource bundles from string literals and implement optional support for se...

Greg Shah wrote:
> The plan is good.
>
> > 3. Implement conversion rules to emit required Java code - any bundle ... Hynek Cihlar

10:59 AM Feature #3817: create resource bundles from string literals and implement optional support for se...

The plan is good.
> 3. Implement conversion rules to emit required Java code - any bundle initialization logic, ge... Greg Shah

10:52 AM Feature #3817: create resource bundles from string literals and implement optional support for se...

In order to estimate the efforts I came up with the following sub tasks:
1. Resolve the unknowns laid out by Greg ... Hynek Cihlar

09:34 AM Feature #3817: create resource bundles from string literals and implement optional support for se...

Greg Shah wrote:
> * The 4GL essentially has resource-bundles that are specific to a single program. This may have ... Hynek Cihlar

09:28 AM Feature #3817: create resource bundles from string literals and implement optional support for se...

Depending on the @CURRENT-LANGUAGE@ scope, the resource bundle will have to be scoped accordingly. The possible outco... Hynek Cihlar

08:08 AM Feature #3817: create resource bundles from string literals and implement optional support for se...

Hynek Cihlar wrote:
> Greg Shah wrote:
> > +FWD Implementation Questions+
> >
> > * To match the behavior of the... Greg Shah

07:51 AM Feature #3817: create resource bundles from string literals and implement optional support for se...

> I assume the scope includes translation of FWD runtime, too. Like error messages. Correct?
No, we will handle th... Greg Shah

03:02 AM Feature #3817: create resource bundles from string literals and implement optional support for se...

Greg Shah wrote:
> +FWD Implementation Questions+
>
> * To match the behavior of the 4GL
Greg, what behavior ... Hynek Cihlar

02:30 AM Feature #3817: create resource bundles from string literals and implement optional support for se...

I assume the scope includes translation of FWD runtime, too. Like error messages. Correct? Hynek Cihlar

08/18/2021

01:01 PM Bug #5608: raw vs memptr parameters

@testcases/uast/memptr/memptr_vs_raw.p@ has some tests where raw/memptr args are passed for memptr/raw parameters. F... Constantin Asofiei

12:56 PM Bug #5608 (New): raw vs memptr parameters

Constantin Asofiei

10:13 AM Bug #2375: fix the memptr initialization (in extent) and memptr parameter processing

Greg Shah wrote:
> In @public raw(byte[] val)@, I think this text needs to be removed from the javadoc: "The passed ... Constantin Asofiei

09:17 AM Bug #2375 (Closed): fix the memptr initialization (in extent) and memptr parameter processing

Code Review Task Branch 3821c Revision 12835
The solution is elegant and it makes sense.
In @public raw(byte[] ... Greg Shah

06:19 AM Bug #2375 (Review): fix the memptr initialization (in extent) and memptr parameter processing

The changes are in 3821c rev 12835. Constantin Asofiei

05:33 AM Bug #2375: fix the memptr initialization (in extent) and memptr parameter processing

The 'memptr is both unknown and not-unknown' seems to not happen in Windows OE 11.6. Do you recall if the #1635-31 w... Constantin Asofiei

02:17 AM Feature #4350: method overload when they differ by a temp-table, dataset, buffer or object or ext...

Greg Shah wrote:
> I'm confused by this code in @symbolResolver.loadConvertedClass()@:
>
> [...]
>
> Why do we... Constantin Asofiei

08/17/2021

03:42 PM Feature #4350: method overload when they differ by a temp-table, dataset, buffer or object or ext...

I'm confused by this code in @SymbolResolver.loadConvertedClass()@:... Greg Shah

08:32 AM Feature #4350: method overload when they differ by a temp-table, dataset, buffer or object or ext...

Greg Shah wrote:
> I think we always have a @ClassDefinition@ instance whenever we also have a @ConvertedClassName@ ... Constantin Asofiei

08:26 AM Feature #4350: method overload when they differ by a temp-table, dataset, buffer or object or ext...

Greg Shah wrote:
> The current implementation splits the conversion of method names between parse time, annotations ... Constantin Asofiei

08:20 AM Feature #4350: method overload when they differ by a temp-table, dataset, buffer or object or ext...

I think we always have a @ClassDefinition@ instance whenever we also have a @ConvertedClassName@ instance. Let me kn... Greg Shah

08/16/2021

03:29 PM Feature #4350: method overload when they differ by a temp-table, dataset, buffer or object or ext...

The current implementation splits the conversion of method names between parse time, annotations prep (@naming.rules@... Greg Shah