Project

General

Profile

Activity

From 09/09/2021 to 10/08/2021

10/08/2021

10:43 AM Feature #3817: create resource bundles from string literals and implement optional support for se...
Hynek, this review is for 3821c revisions 13032,13022,13021,13020,13017:
* The change in @ProcedureManager.addProced...
Constantin Asofiei

10/04/2021

03:25 PM Feature #3817: create resource bundles from string literals and implement optional support for se...
Code Review Task Branch 3821c Revision 13032
It is good.
Greg Shah
03:22 PM Feature #3817: create resource bundles from string literals and implement optional support for se...
Hynek Cihlar wrote:
> Hynek Cihlar wrote:
> > Greg Shah wrote:
> > > 7. In @frame_generator.xml@, I'm worried that...
Hynek Cihlar
06:17 AM Feature #3817: create resource bundles from string literals and implement optional support for se...
Code Review Task Branch 3821c Revision 13022
It looks good.
Greg Shah
03:52 AM Feature #3817: create resource bundles from string literals and implement optional support for se...
Hynek Cihlar wrote:
> Greg Shah wrote:
> >
> > 3. In @annotations/i18n.rules@, why not change @sprintf("%s/%s.%s"...
Hynek Cihlar

10/03/2021

07:17 PM Feature #3817: create resource bundles from string literals and implement optional support for se...
Code Review Task Branch 3821c Revision 13021
The changes are all good.
Greg Shah
03:36 PM Feature #3817: create resource bundles from string literals and implement optional support for se...
3821c revision 13021 adds support for import of the translation data exported from Translation Manager. Please review... Hynek Cihlar

10/02/2021

04:08 PM Feature #3817: create resource bundles from string literals and implement optional support for se...
Hynek Cihlar wrote:
> As a consequence it will be very important to have the TM database up to date with the convert...
Hynek Cihlar
04:05 PM Feature #3817: create resource bundles from string literals and implement optional support for se...
A few notes about the import of Translation Manager translation database.
There are some limitations in the TM's m...
Hynek Cihlar

10/01/2021

03:40 PM Bug #5446: PUT UNFORMATTED performace (stream is flushed on each call)
> The only feasible way I see to make caching the StreamWrapper.putWorker calls work is this
It seems reasonable.
Greg Shah
02:26 PM Bug #5446: PUT UNFORMATTED performace (stream is flushed on each call)
The only feasible way I see to make caching the @StreamWrapper.putWorker@ calls work is this:
* encapsulate all usag...
Constantin Asofiei
01:31 PM Bug #5446: PUT UNFORMATTED performace (stream is flushed on each call)
Greg Shah wrote:
> The downcall case can be handled using state synchronization like we do with the other UI feature...
Constantin Asofiei
12:06 PM Bug #5446: PUT UNFORMATTED performace (stream is flushed on each call)
> Serializing everything (especially FieldEntry instances) ensures we have the correct data to output (and any error... Greg Shah
11:59 AM Bug #5446: PUT UNFORMATTED performace (stream is flushed on each call)
Greg Shah wrote:
> In regard to the avoidance of round trips, we could buffer these on the server side for file stre...
Constantin Asofiei
11:10 AM Bug #5446: PUT UNFORMATTED performace (stream is flushed on each call)
> This is related to any caller of @Stream.putWorker@, which are @PUT@, @PUT CONTROL@, @PUT UNFORMATTED@ and @EXPORT@... Greg Shah
10:58 AM Bug #5446: PUT UNFORMATTED performace (stream is flushed on each call)
Something I need to clarify: this flush in FWD is not a problem just for @PUT UNFORMATTED@ (this is just the statemen... Constantin Asofiei
09:02 AM Bug #5446: PUT UNFORMATTED performace (stream is flushed on each call)
> The question is: is the buffer flush for a PUT statement required in 4GL?
I think we needed to downcall and flus...
Greg Shah
12:17 PM Feature #3817: create resource bundles from string literals and implement optional support for se...
Give it a try. Greg Shah
12:04 PM Feature #3817: create resource bundles from string literals and implement optional support for se...
Greg Shah wrote:
> > > Btw. I also have to modify the TM sources as it doesn't export procedure file names.
> >
>...
Hynek Cihlar
11:50 AM Feature #3817: create resource bundles from string literals and implement optional support for se...
> > Btw. I also have to modify the TM sources as it doesn't export procedure file names.
>
> Perhaps I should cont...
Greg Shah
11:44 AM Feature #3817: create resource bundles from string literals and implement optional support for se...
Hynek Cihlar wrote:
> Btw. I also have to modify the TM sources as it doesn't export procedure file names.
Perhap...
Hynek Cihlar
11:36 AM Feature #3817: create resource bundles from string literals and implement optional support for se...
Greg Shah wrote:
> Code Review Task Branch 3821c Revision 13017
>
> This is very good. I think the result is qui...
Hynek Cihlar
10:54 AM Feature #3817: create resource bundles from string literals and implement optional support for se...
Code Review Task Branch 3821c Revision 13017
This is very good. I think the result is quite elegant and is layere...
Greg Shah
09:27 AM Feature #3817: create resource bundles from string literals and implement optional support for se...
Hynek Cihlar wrote:
> This part is not finished yet. The expected worflow is to export the translations from Thransa...
Hynek Cihlar
08:30 AM Feature #3817: create resource bundles from string literals and implement optional support for se...
Greg Shah wrote:
> Both Constantin and I will review this.
>
> What is the process to export the translation mana...
Hynek Cihlar
08:18 AM Feature #3817: create resource bundles from string literals and implement optional support for se...
Both Constantin and I will review this.
What is the process to export the translation manager database and provide...
Greg Shah
08:11 AM Feature #3817: create resource bundles from string literals and implement optional support for se...
3821c revision 13017 adds core runtime and conversion support.
The conversion support when explicitly enabled gen...
Hynek Cihlar

09/30/2021

08:04 AM Feature #3817: create resource bundles from string literals and implement optional support for se...
> The attached file shows Translation Manager Compile dialog. This is used to compile 4GL sources with the specified ... Greg Shah

09/29/2021

09:24 AM Feature #3817: create resource bundles from string literals and implement optional support for se...
Hynek Cihlar wrote:
> Any untranslatable strings are simply not wrapped by the translation method.
GNU gettext is...
Hynek Cihlar
09:17 AM Feature #3817: create resource bundles from string literals and implement optional support for se...
Greg Shah wrote:
> > Once/if the customer moves away from the 4GL sources the work flow will be a bit different, the...
Hynek Cihlar
09:10 AM Feature #3817: create resource bundles from string literals and implement optional support for se...
> Once/if the customer moves away from the 4GL sources the work flow will be a bit different, the PO files will be ge... Greg Shah
09:02 AM Feature #3817: create resource bundles from string literals and implement optional support for se...
Hynek Cihlar wrote:
> Hynek,
>
> After conversion, is the translation table mapping to 4GL source code line/colum...
Hynek Cihlar
08:59 AM Feature #3817: create resource bundles from string literals and implement optional support for se...
Hynek,
After conversion, is the translation table mapping to 4GL source code line/column numbers? Why is this nee...
Hynek Cihlar
09:13 AM Feature #4384: Builtin OO Implementation
> Probably not that important but thought to mention it as deviation anyway.
Recorded as a separate bug #5691.
Greg Shah
09:13 AM Bug #5691: deviation in error generation for invalid method/property chaining
From Marian in #4384-577:
> When chaining method/properties access on an invalid object in 4GL there are two error...
Greg Shah
09:12 AM Bug #5691 (New): deviation in error generation for invalid method/property chaining
Greg Shah
06:22 AM Bug #5651: conditions raised from a finally block
Greg Shah wrote:
> Are there any known customer issues that are caused by the remaining issues? If not, we will def...
Constantin Asofiei

09/28/2021

04:05 PM Bug #5651: conditions raised from a finally block
Are there any known customer issues that are caused by the remaining issues? If not, we will defer those items. Greg Shah
04:04 PM Bug #5651: conditions raised from a finally block
Code Review Task Branch 3821c Revision 13001
No objections.
Greg Shah

09/27/2021

02:30 PM Feature #3817: create resource bundles from string literals and implement optional support for se...
The attached file shows Translation Manager Compile dialog. This is used to compile 4GL sources with the specified la... Hynek Cihlar
09:33 AM Bug #5651: conditions raised from a finally block
3821c/13001 adds the try/finally protection for TM.processFinallyBlock. Constantin Asofiei
07:27 AM Feature #4384: Builtin OO Implementation
Probably not that important but thought to mention it as deviation anyway.
When chaining method/properties access ...
Marian Edu

09/21/2021

05:43 AM Feature #4384: Builtin OO Implementation
I can't reproduce it with @oo/openedge/core/collections/CloneableString.cls@ either. If you see this again, let us k... Greg Shah
03:05 AM Feature #4384: Builtin OO Implementation
Greg Shah wrote:
> > all using Progress.Lang.*. statements gets converted to @import com.goldencode.testcases.oo.pr...
Marian Edu

09/20/2021

03:33 PM Feature #4384: Builtin OO Implementation
Greg Shah wrote:
> Ovidiu: Please apply the changes needed to work with @fwdspi.jar@ in the new testcases project.
...
Ovidiu Maxiniuc
03:22 PM Feature #4384: Builtin OO Implementation
> all using Progress.Lang.*. statements gets converted to @import com.goldencode.testcases.oo.progress.lang.*;@
A...
Greg Shah
09:59 AM Feature #4384: Builtin OO Implementation
Also after conversion now all @using Progress.Lang.*.@ statements gets converted to @import com.goldencode.testcases.... Marian Edu
07:17 AM Feature #4384: Builtin OO Implementation
Ovidiu: Please apply the changes needed to work with @fwdspi.jar@ in the new testcases project. Greg Shah
02:45 AM Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> I'm getting an error when trying to start the server after last merge:
> [...]
>
> Something...
Marian Edu
02:34 AM Feature #4384: Builtin OO Implementation
You are using H2, right? Copy the @build/lib/fwdspi.jar@ to the JRE's ext folder and delete the previous p2jspi.jar. Constantin Asofiei
02:31 AM Feature #4384: Builtin OO Implementation
I'm getting an error when trying to start the server after last merge:... Marian Edu
02:26 AM Feature #4384: Builtin OO Implementation
Greg Shah wrote:
> Vladimir on our team has resolved the javadoc errors in 3821c rev 12945. You don't need to do th...
Marian Edu
01:06 PM Bug #3020: Add support for the IMMEDIATE-DISPLAY and MULTITASKING-INTERVAL SEEION attributes
Gaps are updated in 3821c/12958. Constantin Asofiei
12:54 PM Bug #3020 (Test): Add support for the IMMEDIATE-DISPLAY and MULTITASKING-INTERVAL SEEION attributes
The changes are in task branch 3821c revision 12957. Greg Shah

09/17/2021

03:27 PM Bug #5651: conditions raised from a finally block
Greg, to answer your question, yes, the unwind can be overridden in the FINALLY (via LEAVE/NEXT/RETRY or even anothe... Constantin Asofiei
11:55 AM Feature #4384: Builtin OO Implementation
Vladimir on our team has resolved the javadoc errors in 3821c rev 12945. You don't need to do this in 4384m. Greg Shah
06:17 AM Feature #4384: Builtin OO Implementation
Greg Shah wrote:
> Marian: In 4384m, would you please resolve these javadoc errors.
>
> [...]
Greg, we can certa...
Marian Edu
05:10 AM Feature #3817: create resource bundles from string literals and implement optional support for se...
Greg Shah wrote:
> Please note that we will need to update the font metrics calculation to process all the translati...
Hynek Cihlar
05:10 AM Feature #3817: create resource bundles from string literals and implement optional support for se...
Greg Shah wrote:
> > As a corollary, an external procedure ran non-persistently, with no outstanding persistent inst...
Hynek Cihlar

09/16/2021

07:16 PM Feature #4366 (Closed): support TLS 1.2 and other updated secure socket protocols
Greg Shah
06:26 PM Feature #4366: support TLS 1.2 and other updated secure socket protocols
What other variety of tests would be helpful? Do these results coincide with expected results? To me it looks like ne... Roger Borrello
01:35 PM Feature #4366: support TLS 1.2 and other updated secure socket protocols
Below are my findings... I hope the table looks OK.
|\2/2. |_\7. Server |
...
Roger Borrello
11:42 AM Feature #4366: support TLS 1.2 and other updated secure socket protocols
Roger Borrello wrote:
> Because I am unworthy! Awesome!
Haha 😀!
> Let me follow-up with a question. If I have a ...
Ovidiu Maxiniuc
10:27 AM Feature #4366: support TLS 1.2 and other updated secure socket protocols
Ovidiu Maxiniuc wrote:
> Why not re-arrange the table as:
Because I am unworthy! Awesome!
Let me follow-up wit...
Roger Borrello
09:02 AM Feature #4366: support TLS 1.2 and other updated secure socket protocols
Roger Borrello wrote:
> I guess there are a limited number of permutations to deal with. Below is my testplan:
Why ...
Ovidiu Maxiniuc
08:50 AM Feature #4366: support TLS 1.2 and other updated secure socket protocols
Roger Borrello wrote:
> There is a pre-configuration step to perform, outside of the programming to generate:
> * t...
Ovidiu Maxiniuc
08:09 AM Feature #4366: support TLS 1.2 and other updated secure socket protocols
> I wanted to check that when the server is setup for ssl and the client is tls, we can still connect, but the data i... Greg Shah
02:33 PM Feature #4384: Builtin OO Implementation
Marian: In 4384m, would you please resolve these javadoc errors.... Greg Shah
10:59 AM Feature #4384: Builtin OO Implementation
Task branch 4384m has been created from 3821c revision 12935. This is available on xfer (@/opt/fwd/4384m/@). Greg Shah
10:28 AM Feature #4384: Builtin OO Implementation
Marian, my only issue is that in @oo.core.Assert@ you've replaced @ObjectOps.load(Assert.class);@ with @ObjectOps.loa... Constantin Asofiei
09:23 AM Feature #4384: Builtin OO Implementation
Greg Shah wrote:
> It is safe to go ahead and make a patch using 12922. We'll merge that back quickly and get you a...
Marian Edu
08:31 AM Feature #4384: Builtin OO Implementation
It is safe to go ahead and make a patch using 12922. We'll merge that back quickly and get you a new branch. Greg Shah
01:12 AM Feature #4384: Builtin OO Implementation
Greg Shah wrote:
> I think we've definitely made many fixes that may affect you. Let's go through the rebase + merg...
Marian Edu
01:56 PM Feature #3817: create resource bundles from string literals and implement optional support for se...
Please note that we will need to update the font metrics calculation to process all the translations. And we will ne... Greg Shah
01:42 PM Feature #3817: create resource bundles from string literals and implement optional support for se...
> As a corollary, an external procedure ran non-persistently, with no outstanding persistent instances, can be invoke... Greg Shah
01:12 PM Feature #3817: create resource bundles from string literals and implement optional support for se...
To support the conversion path for customers using OE translation workflow, the translations can be "dumped" from Tra... Hynek Cihlar
01:07 PM Feature #3817: create resource bundles from string literals and implement optional support for se...
See my findings below. I will update this note as I go.
Greg Shah wrote:
> +Areas to Investigate+
>
> * Write ...
Hynek Cihlar

09/15/2021

06:47 PM Feature #4366: support TLS 1.2 and other updated secure socket protocols
I guess there are a limited number of permutations to deal with. Below is my testplan:
|_. Server |_. Client |_. R...
Roger Borrello
06:04 PM Feature #4366: support TLS 1.2 and other updated secure socket protocols
I can finally accomplish the testing. I wanted to check that when the server is setup for @ssl@ and the client is @tl... Roger Borrello
05:36 PM Feature #4366: support TLS 1.2 and other updated secure socket protocols
Well it was just a matter of time before I figured out what I was doing wrong. I hadn't noticed that there were 2 sep... Roger Borrello
03:36 PM Feature #4366: support TLS 1.2 and other updated secure socket protocols
I run the tests only from my workstation. No network changes required. The parameters look fine, I am positive the fi... Ovidiu Maxiniuc
02:36 PM Feature #4366: support TLS 1.2 and other updated secure socket protocols
I am troubled by the fact that I can use my current configuration with the @sockets/server-connect.p@ and @sockets/cl... Roger Borrello
02:24 PM Feature #4366: support TLS 1.2 and other updated secure socket protocols
Roger Borrello wrote:
> Ovidiu, thank you for all those pointers. Thanks to them, I was successful in making sure th...
Ovidiu Maxiniuc
02:11 PM Feature #4366: support TLS 1.2 and other updated secure socket protocols
> I think that the wiki should be a little more step-by-step with the example, including basic passwords for the stor... Greg Shah
02:00 PM Feature #4366: support TLS 1.2 and other updated secure socket protocols
Ovidiu, thank you for all those pointers. Thanks to them, I was successful in making sure the store password and the ... Roger Borrello
09:33 AM Feature #4366: support TLS 1.2 and other updated secure socket protocols
I understand now. And I have just noticed the "keystore" password commented in your note-57.
The problem is that y...
Ovidiu Maxiniuc
05:30 PM Bug #5651: conditions raised from a finally block
I am willing to postpone the implementation of @NEXT@ in a @FINALLY@. We can put code in to detect this at conversio... Greg Shah
04:43 PM Bug #5651: conditions raised from a finally block
And something I didn't expect: same suite ran in ChUI and GUI (OE 11.6.3) gives different results in ~5% of cases. T... Constantin Asofiei
04:33 PM Bug #5651: conditions raised from a finally block
Ughhh. Supporting @NEXT@ in a finally which overrides a prior @LEAVE@ is an awful "feature" and a terrible idea. Wh... Greg Shah
02:43 PM Bug #5651: conditions raised from a finally block
Greg, there is an issue which is kind of tricky. For looping blocks, the finally can not be processed at the @popSco... Constantin Asofiei
09:26 AM Feature #4384: Builtin OO Implementation
I think we've definitely made many fixes that may affect you. Let's go through the rebase + merge process and then g... Greg Shah
08:45 AM Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> Please try this patch and see if anything changes:
Better, thanks a bunch :)
Marian Edu
08:27 AM Feature #4384: Builtin OO Implementation
Argh, think we need to get to a newer revision as this might be the cause for more other errors we see because the ob... Marian Edu
08:26 AM Feature #4384: Builtin OO Implementation
Please try this patch and see if anything changes:... Constantin Asofiei
08:16 AM Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> What 3821c revision are you on? We had some issues with destructors which were not being...
Marian Edu
08:08 AM Feature #4384: Builtin OO Implementation
What 3821c revision are you on? We had some issues with destructors which were not being called at all, fixed in Obje... Constantin Asofiei
07:53 AM Feature #4384: Builtin OO Implementation
I see a bunch of unexpected errors being thrown when we ran all tests for OpenEdge.Core.Memptr, #1005 (Procedure xxx ... Marian Edu

09/14/2021

05:39 PM Feature #4366: support TLS 1.2 and other updated secure socket protocols
OK... because I am having issues with the below, I'll flip-flop the passwords. I get @Unable to prtocess parameters. ... Roger Borrello
04:52 PM Feature #4366: support TLS 1.2 and other updated secure socket protocols
The problem is here:
> @-Dssl-socket:keystore:password=keystore@
In fact, there are two of them:
# use @password@ ...
Ovidiu Maxiniuc
04:31 PM Feature #4366: support TLS 1.2 and other updated secure socket protocols
This is what I did (still resulting in the tampered error).... Roger Borrello
08:31 AM Feature #3817: create resource bundles from string literals and implement optional support for se...
Here are a few notes about building the Adetran project. These are on top of the existing documentation.
h2. Build...
Hynek Cihlar

09/13/2021

03:10 PM Feature #4366: support TLS 1.2 and other updated secure socket protocols
Roger,
Your key loads in my test procedure(s). They are the exactly the same from @Socket Handle and Server Socket H...
Ovidiu Maxiniuc
01:36 PM Feature #4366: support TLS 1.2 and other updated secure socket protocols
That error I get when the password is somehow incorrect. Can you send me the @default_server.store@ you've generated. Ovidiu Maxiniuc
12:32 PM Feature #4366: support TLS 1.2 and other updated secure socket protocols
Ovidiu, I am trying to follow the wiki, and my server source code is the same as your example (except I am using a va... Roger Borrello

09/10/2021

04:00 PM Feature #4366: support TLS 1.2 and other updated secure socket protocols
Yes, the "working" directory is the right work. I have just updated the wiki. Ovidiu Maxiniuc
03:49 PM Feature #4366: support TLS 1.2 and other updated secure socket protocols
In your text, you mention "This .store container must be located in root directory of the FWD-client" and "trusted-ce... Greg Shah
02:17 PM Feature #4366: support TLS 1.2 and other updated secure socket protocols
Greg Shah wrote:
> Ovidiu: Please document the specific requirements. We may need to make code changes to make it e...
Ovidiu Maxiniuc
02:03 PM Feature #4366: support TLS 1.2 and other updated secure socket protocols
Roger Borrello wrote:
> Ovidiu, I was using @SSLCertGenUtil@ to do the generation of the keys into the directory ("s...
Ovidiu Maxiniuc
07:04 AM Feature #4366: support TLS 1.2 and other updated secure socket protocols
Passing the output from the SSLCertGenUtil cannot work since it is not encoded as hex.
Ovidiu: Please document t...
Greg Shah
07:28 AM Feature #4384: Builtin OO Implementation
Greg Shah wrote:
> > * @SERIALIZABLE@ keyword should probably be used by conversion to make the class implement @Ser...
Marian Edu

09/09/2021

06:29 PM Feature #4366: support TLS 1.2 and other updated secure socket protocols
Greg Shah wrote:
> Roger: Please ask Ovidiu specific questions to get help with this configuration. Also, after Ovi...
Roger Borrello
09:46 AM Feature #4366: support TLS 1.2 and other updated secure socket protocols
Ovidiu: Please edit [[p2j:Certificates_and_Keys_for_4GL_Language_Features#Socket-Handle-and-Server-Socket-Handle-SSL-... Greg Shah
08:26 AM Feature #4366: support TLS 1.2 and other updated secure socket protocols
If you look at the code for @SymmetricEncryption.decrypt()@, you'll see that in @asBytes()@ it assumes that the input... Greg Shah
08:17 AM Feature #4366: support TLS 1.2 and other updated secure socket protocols
Greg Shah wrote:
> Is that what you expect? If the actual key password has 2 tildes, then you need to double them i...
Roger Borrello
07:15 AM Feature #4366: support TLS 1.2 and other updated secure socket protocols
The tilde is an escape char in the 4GL. If your code is this:
@define variable kapw as char init "v~~4l#8ZrkkJwW?...
Greg Shah
 

Also available in: Atom