FWD » Core Development » Base Language

02/22/2023

04:56 PM Bug #7135 (WIP): NPE in conversion of OO looking for oldtype annotation

The app converted successfully with both changes in place!
But there were compilation errors:... Roger Borrello

02/21/2023

02:34 PM Bug #7135 (Review): NPE in conversion of OO looking for oldtype annotation

Committed revision 7135a_14486. Re-running customer app conversion. Roger Borrello

02:10 PM Bug #7135: NPE in conversion of OO looking for oldtype annotation

It is fine for now. Greg Shah

02:06 PM Bug #7135: NPE in conversion of OO looking for oldtype annotation

Roger, please try this patch:... Constantin Asofiei

01:55 PM Bug #7135: NPE in conversion of OO looking for oldtype annotation

This testcase:... Roger Borrello

11:49 AM Bug #7135: NPE in conversion of OO looking for oldtype annotation

Constantin Asofiei wrote:
> Please work on a standalone test and lets use this task for the customer's app issues wi... Roger Borrello

10:50 AM Bug #7135: NPE in conversion of OO looking for oldtype annotation

Please work on a standalone test and lets use this task for the customer's app issues with trunk (conversion or runti... Constantin Asofiei

10:40 AM Bug #7135: NPE in conversion of OO looking for oldtype annotation

Roger Borrello wrote:
> I will see if it is related to the change, versus a different issue.
I see that issue whe... Roger Borrello

09:27 AM Bug #7135 (WIP): NPE in conversion of OO looking for oldtype annotation

Greg Shah wrote:
> If this passes testing, we will merge it to trunk.
There was an issue later in the conversion ... Roger Borrello

07:13 AM Bug #7135: NPE in conversion of OO looking for oldtype annotation

If this passes testing, we will merge it to trunk. Greg Shah

07:13 AM Bug #7135 (Test): NPE in conversion of OO looking for oldtype annotation

Code Review Task Branch 7135a Revision 14485
No objections. Greg Shah

10:05 AM Feature #6410: implement additional built-in OO classes/interfaces

> For ctor's this doesn't seem to work at all
6129b which is now in trunk revision 14484 does have all my previous... Greg Shah

09:46 AM Feature #6410: implement additional built-in OO classes/interfaces

Greg Shah wrote:
> Are you working off of trunk rev 14484?
Conversion was ran with trunk #14483, working on 6129b... Marian Edu

09:36 AM Feature #6410: implement additional built-in OO classes/interfaces

> is there any update on method/ctor resolution during conversion in regard with Java erasure issue caused by the `ob... Greg Shah

09:13 AM Feature #6410: implement additional built-in OO classes/interfaces

Greg, is there any update on method/ctor resolution during conversion in regard with Java erasure issue caused by the... Marian Edu

09:56 AM Feature #6818: analyze the performance of the FWD open client proxy client support

7026a/14497 contains changes for the legacy JavaOpenClient:
* Encapsulated the field and relation metadata in their... Constantin Asofiei

02/20/2023

06:54 PM Bug #7135 (Review): NPE in conversion of OO looking for oldtype annotation

Branch 7135a rev 14485 ready for review. Roger Borrello

04:05 PM Bug #7135: NPE in conversion of OO looking for oldtype annotation

Yes Greg Shah

02:44 PM Bug #7135 (WIP): NPE in conversion of OO looking for oldtype annotation

Running conversion. Should I create a branch 7135a? Roger Borrello

02:17 PM Bug #7135: NPE in conversion of OO looking for oldtype annotation

Roger Borrello wrote:
> Is this a fix I should try against the customer's code?
Yes.
Constantin Asofiei

02:12 PM Bug #7135: NPE in conversion of OO looking for oldtype annotation

That results in a successful conversion. So those warnings are just red-herrings?
Is this a fix I should try again... Roger Borrello

01:47 PM Bug #7135: NPE in conversion of OO looking for oldtype annotation

Roger, please try this patch (on top of trunk rev 14484):... Constantin Asofiei

01:32 PM Bug #7135: NPE in conversion of OO looking for oldtype annotation

The AST is attached: Roger Borrello

01:30 PM Bug #7135: NPE in conversion of OO looking for oldtype annotation

Using this testcase (placed in @uast/oo@:... Roger Borrello

01:26 PM Bug #7135 (Closed): NPE in conversion of OO looking for oldtype annotation

Roger Borrello

04:10 PM Feature #6426 (Closed): implement ERROR-STATUS:CLEAR()

In the short term it is fine. In the longer term we will probably need to fix it. Greg Shah

12:12 PM Feature #6426: implement ERROR-STATUS:CLEAR()

Greg, IMO, I think we are OK with 'doing nothing'. Otherwise, we can treat these cases of invalid attribute/method r... Constantin Asofiei

10:21 AM Feature #6426: implement ERROR-STATUS:CLEAR()

Yes, I noticed it. Do I need to make any changes (e.g. show a warning)? Theodoros Theodorou

08:40 AM Feature #6426: implement ERROR-STATUS:CLEAR()

There is nothing emitted by conversion in @error-status:clear().@, see the standalone @;@ char on a single line. Constantin Asofiei

02/17/2023

02:27 PM Feature #6819: refactor FWD proxy implementation to use ReflectASM instead of Java Method reflection

Constantin Asofiei wrote:
> Greg: we need to consider if we want to make it a policy to discourage Java lambda, th... Eric Faulhaber

12:53 PM Feature #6426: implement ERROR-STATUS:CLEAR()

Post here the .java file for your converted program. Constantin Asofiei

12:53 PM Feature #6426: implement ERROR-STATUS:CLEAR()

I am not sure. I compiled and ran the app using the testcases project without any issues. Theodoros Theodorou

12:00 PM Feature #6426: implement ERROR-STATUS:CLEAR()

I'm confused, how does FWD convert @error-status:clear().@? Constantin Asofiei

11:58 AM Feature #6426: implement ERROR-STATUS:CLEAR()

Yes, the error occurs at runtime... Theodoros Theodorou

10:16 AM Feature #6426: implement ERROR-STATUS:CLEAR()

Hmm, we must have done something special for this case (or for @ERROR-STATUS@ in general).
To confirm, the error... Greg Shah

06:05 AM Feature #6426: implement ERROR-STATUS:CLEAR()

No, FWD does not fail during conversion. FWD and OE both have the same output. The only difference is that OE pops up... Theodoros Theodorou

05:41 AM Feature #6426: implement ERROR-STATUS:CLEAR()

I need to discuss this with the customer.
FWD fails during conversion of this testcase, right? Greg Shah

04:10 AM Feature #6426: implement ERROR-STATUS:CLEAR()

Do I need to do something more for this ticket now? Theodoros Theodorou

06:11 AM Feature #4382: implement configurable directory override for PROGRESS global variable

Can you please elaborate more? Theodoros Theodorou

05:58 AM Feature #4382: implement configurable directory override for PROGRESS global variable

No, this is a reference to the @directory.xml@ used as the configuration source for the FWD application server. Greg Shah

05:57 AM Feature #4382: implement configurable directory override for PROGRESS global variable

I would like to ask for some help. Directory override means changing the working directory on runtime or does it mean... Theodoros Theodorou

02/16/2023

01:54 PM Feature #6426: implement ERROR-STATUS:CLEAR()

True, though we will eventually be implementing a pure handle approach to everything. For example, I expect an @ERRO... Greg Shah

01:44 PM Feature #6426: implement ERROR-STATUS:CLEAR()

In OE 11.6.3 this attribute is not part of the ERROR-STATUS handle.
OE does not do any compile-time strong-type ch... Constantin Asofiei

01:40 PM Feature #6426: implement ERROR-STATUS:CLEAR()

I think it is 11.7.
Perhaps this is just broken code (at runtime) but it compiles. Or perhaps it is a newer (undo... Greg Shah

11:28 AM Feature #6426: implement ERROR-STATUS:CLEAR()

Greg, do you recall which OE version the customer's code was running? Constantin Asofiei

10:45 AM Feature #6426 (WIP): implement ERROR-STATUS:CLEAR()

I read a bit about the @error-status@ but I couldn't find anything online regarding @error-status:clear()@. I tried t... Theodoros Theodorou

07:36 AM Feature #6819: refactor FWD proxy implementation to use ReflectASM instead of Java Method reflection

Constantin Asofiei wrote:
> Review for 7026/rev. 14495. In @NanoTimer@, @UnclosablePreparedStatement@, @ContextLoca... Alexandru Lungu

06:34 AM Feature #6819: refactor FWD proxy implementation to use ReflectASM instead of Java Method reflection

Review for 7026/rev. 14495. In @NanoTimer@, @UnclosablePreparedStatement@, @ContextLocal@, please add history number... Constantin Asofiei

06:08 AM Feature #6819: refactor FWD proxy implementation to use ReflectASM instead of Java Method reflection

Constantin Asofiei wrote:
> Alexandru Lungu wrote:
> > Done!
> Great! Make sure to add history numbers to any chan... Alexandru Lungu

05:48 AM Feature #6819: refactor FWD proxy implementation to use ReflectASM instead of Java Method reflection

Status of the #6819-37 issues:
* @ContextLocal.get()@ - 16.5mm calls, related to JMX, tested with the JMX timer remo... Constantin Asofiei

05:32 AM Feature #6819: refactor FWD proxy implementation to use ReflectASM instead of Java Method reflection

Alexandru Lungu wrote:
> Done!
Great! Make sure to add history numbers to any changed file (just a reminder, histor... Constantin Asofiei

05:28 AM Feature #6819: refactor FWD proxy implementation to use ReflectASM instead of Java Method reflection

Done! Alexandru Lungu

05:16 AM Feature #6819: refactor FWD proxy implementation to use ReflectASM instead of Java Method reflection

Alexandru, please create a patch to fix the ContextLocal.get ( the @Object[] res@) first. This is something we can s... Constantin Asofiei

05:09 AM Feature #6819: refactor FWD proxy implementation to use ReflectASM instead of Java Method reflection

Constantin Asofiei wrote:
> I'll look at the patch, but I don't think allocated a vararg is a good approach. I'll t... Alexandru Lungu

07:17 AM Feature #6421 (Test): finish GENERATE-RANDOM-KEY support

Greg Shah

03:25 AM Feature #6421: finish GENERATE-RANDOM-KEY support

> 1. Didn't you have other changes needed to make the error handling correct?
In the beginning I modified the meth... Theodoros Theodorou

07:15 AM Bug #6399 (Closed): ENCRYPT/DECRYPT built-in function results different than 4GL when IV is short...

Greg Shah

04:56 AM Bug #6399: ENCRYPT/DECRYPT built-in function results different than 4GL when IV is shorter than r...

Thank you Igor for your help regarding the test. I modified it a bit and added it under @testcases/security/security_... Theodoros Theodorou

02/15/2023

02:21 PM Feature #6421: finish GENERATE-RANDOM-KEY support

Greg Shah wrote:
> Igor: Please review.
The changes look good. Igor Skornyakov

01:45 PM Feature #6421: finish GENERATE-RANDOM-KEY support

Code Review Task Branch 6421a Revision 14485
1. Didn't you have other changes needed to make the error handling co... Greg Shah

01:44 PM Feature #6421 (Review): finish GENERATE-RANDOM-KEY support

Igor: Please review. Greg Shah

10:42 AM Feature #6421: finish GENERATE-RANDOM-KEY support

I have recreated the branch 6421a after the branch 6129c was merged to trunk and committed all changes. Please review... Theodoros Theodorou

01:03 PM Feature #7126: replace 'new unknown()' with 'unknown.INSTANCE' in FWD conversion and runtime

Renamed @unknown.INSTANCE@ to @unknown.UNKNOWN@ in 7026a/14493. Constantin Asofiei

08:47 AM Feature #7126: replace 'new unknown()' with 'unknown.INSTANCE' in FWD conversion and runtime

Greg Shah wrote:
> How about if we add @import static com.goldencode.p2j.util.unknown.UNKNOWN;@ and then simply refe... Constantin Asofiei

08:44 AM Feature #7126: replace 'new unknown()' with 'unknown.INSTANCE' in FWD conversion and runtime

Good idea. My only critique is that I want to find a different name than @unknown.INSTANCE@. I think this is a bit ... Greg Shah

08:11 AM Feature #7126: replace 'new unknown()' with 'unknown.INSTANCE' in FWD conversion and runtime

In 7026a rev 14488, @new unknown()@ was replaced with @unknown.INSTANCE@ in parts of FWD runtime which showed up in p... Constantin Asofiei

08:09 AM Feature #7126 (New): replace 'new unknown()' with 'unknown.INSTANCE' in FWD conversion and runtime

Constantin Asofiei

11:51 AM Feature #6819: refactor FWD proxy implementation to use ReflectASM instead of Java Method reflection

Alexandru Lungu wrote:
> From the "statically extract lambda as class member" point of view...
My analysis seems to... Constantin Asofiei

11:46 AM Feature #6819: refactor FWD proxy implementation to use ReflectASM instead of Java Method reflection

I've done a patch, but in a bit of a rush.
There are several complex JMX which need rethinking, as there are > 5 ... Alexandru Lungu

11:39 AM Feature #6819: refactor FWD proxy implementation to use ReflectASM instead of Java Method reflection

Constantin Asofiei wrote:
> Now, after I looked again at the generated lambda code for this task, the lambdas are al... Constantin Asofiei

11:19 AM Feature #6819: refactor FWD proxy implementation to use ReflectASM instead of Java Method reflection

Actually, the inlined lambda Eden space allocations is because of the @Object[] res = new Object[1];@ array. Alexand... Constantin Asofiei

11:11 AM Feature #6819: refactor FWD proxy implementation to use ReflectASM instead of Java Method reflection

I've tried this idea with something like this in @LambdaPerf@:... Constantin Asofiei

10:15 AM Feature #6819: refactor FWD proxy implementation to use ReflectASM instead of Java Method reflection

Greg, if Alexandru's idea is proven successful, then I think the bytecode can be changed from:... Constantin Asofiei

09:08 AM Feature #6819: refactor FWD proxy implementation to use ReflectASM instead of Java Method reflection

Alexandru Lungu wrote:
> Unless my times are due to a Java compilation optimization, cutting down the code altogethe... Constantin Asofiei

09:04 AM Feature #6819: refactor FWD proxy implementation to use ReflectASM instead of Java Method reflection

I've run @LambdaPerf.java@ and I've got similar results. On my computer however, I get Lambda Call time (132.047478) ... Alexandru Lungu

05:47 AM Feature #7122: convert default getter/setter as plain Java methods

For default object property getter and setters, emit a plain Java method with a @return prop.duplicate();@ for a gett... Constantin Asofiei

05:21 AM Bug #7089: sanitize p2j.oo method signature

The current changes are in 7026a rev 14814. Constantin Asofiei

04:46 AM Feature #6826: reduce the BDT usage in FWD runtime

7826a/14811 fixes other cases to reduce BDT usage from within FWD runtime.
Constantin Asofiei

04:17 AM Feature #6820: reduce String.toLowerCase and toUpperCase usage and String instances

Committed to 7026a rev 14810. Constantin Asofiei

02/14/2023

02:22 PM Feature #7122 (WIP): convert default getter/setter as plain Java methods

Constantin Asofiei

09:35 AM Feature #7122: convert default getter/setter as plain Java methods

I don't see any reason to have the @BlockManager.function/procedure@ wrappers for default scalar getter/setter Java m... Constantin Asofiei

09:34 AM Feature #7122 (WIP): convert default getter/setter as plain Java methods

Constantin Asofiei

09:59 AM Bug #6399: ENCRYPT/DECRYPT built-in function results different than 4GL when IV is shorter than r...

I've used the attached program for testing cryptography.
May be it can be useful. Igor Skornyakov

08:57 AM Bug #6399: ENCRYPT/DECRYPT built-in function results different than 4GL when IV is shorter than r...

I'm OK with closing this task. Before we do that, please do/consider the following:
* Gather all of your various ... Greg Shah

08:38 AM Bug #6399: ENCRYPT/DECRYPT built-in function results different than 4GL when IV is shorter than r...

I tried many combinations with @AES_CBC_256@. Some of them can be found below. I keep getting identical results with ... Theodoros Theodorou

02/13/2023

02:26 PM Bug #6399: ENCRYPT/DECRYPT built-in function results different than 4GL when IV is shorter than r...

As far as I rememeber after the Constantin's fix we are 100% binary compatible with 4GL with respect to the encryptio... Igor Skornyakov

02:21 PM Bug #6399: ENCRYPT/DECRYPT built-in function results different than 4GL when IV is shorter than r...

From #5915-40:
>The problem is with @generate-pbe-key@, where @AES_CBC_256@ is used for this key (32 length). There... Constantin Asofiei

01:45 PM Bug #6399: ENCRYPT/DECRYPT built-in function results different than 4GL when IV is shorter than r...

I have read some existing tests under @testcases/security/security_policy@ and I tried to understand them. I tried ma... Theodoros Theodorou

09:28 AM Feature #6820: reduce String.toLowerCase and toUpperCase usage and String instances

Hynek Cihlar wrote:
> And some cleanup:
Great, I'll test this and include it in my larger changes. Constantin Asofiei

09:12 AM Feature #6820: reduce String.toLowerCase and toUpperCase usage and String instances

And some cleanup:... Hynek Cihlar

09:09 AM Feature #6820: reduce String.toLowerCase and toUpperCase usage and String instances

Constantin Asofiei wrote:
> Hynek, what times do you get for @StringHelper.hashCodeCaseInsensitive@ test? Please te... Hynek Cihlar

08:52 AM Feature #6820: reduce String.toLowerCase and toUpperCase usage and String instances

Hynek, what times do you get for @StringHelper.hashCodeCaseInsensitive@ test? Please test what happens if you use so... Constantin Asofiei

08:42 AM Feature #6819: refactor FWD proxy implementation to use ReflectASM instead of Java Method reflection

Greg Shah wrote:
> How many JMX instrumentation locations are there? I'd like to run some non-trivial application c... Constantin Asofiei

08:39 AM Feature #6819: refactor FWD proxy implementation to use ReflectASM instead of Java Method reflection

Try attached testcase in command-line. On devsrv01, the times are these:... Constantin Asofiei

08:17 AM Feature #6819: refactor FWD proxy implementation to use ReflectASM instead of Java Method reflection

How many JMX instrumentation locations are there? I'd like to run some non-trivial application code with and without... Greg Shah

08:06 AM Feature #6819: refactor FWD proxy implementation to use ReflectASM instead of Java Method reflection

Greg Shah wrote:
> > I think we need to add a JVM flag to enable or disable the JMX code, so for production mode it ... Constantin Asofiei

08:04 AM Feature #6819: refactor FWD proxy implementation to use ReflectASM instead of Java Method reflection

> I think we need to add a JVM flag to enable or disable the JMX code, so for production mode it will go via the dire... Greg Shah

02/12/2023

03:14 AM Feature #6819: refactor FWD proxy implementation to use ReflectASM instead of Java Method reflection

I've did more testing and profiling of lambda calls. Even a simple lambda call as we have in @ContextLocal.get(boole... Constantin Asofiei

02/10/2023

12:54 PM Feature #4065: server-side processing of client platform dependencies

> With respect to the anticipated use cases does it make sense to replace these with the managed file system resource... Greg Shah

11:39 AM Feature #4065: server-side processing of client platform dependencies

Greg, I found several places in the client UI where file IO is performed directly. An example is a button widget load... Hynek Cihlar

02/09/2023

01:49 PM Feature #4065: server-side processing of client platform dependencies

Hynek Cihlar wrote:
> Greg, do we want to interpolate the file paths with a set of known variables? Like logged in u... Greg Shah

01:06 PM Feature #4065: server-side processing of client platform dependencies

Greg, do we want to interpolate the file paths with a set of known variables? Like logged in user, application name, ... Hynek Cihlar

11:19 AM Feature #4065: server-side processing of client platform dependencies

Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > I created task branch 4065a based on trunk revision 14477.
> F... Hynek Cihlar

11:16 AM Feature #4065: server-side processing of client platform dependencies

Hynek Cihlar wrote:
> I created task branch 4065a based on trunk revision 14477.
FYI, trunk is on rev 14483. Constantin Asofiei

10:20 AM Feature #4065: server-side processing of client platform dependencies

> > > Should we pursue some kind of EXECUTE permissions on the OS-COMMAND statement?
> >
> > It is a really good i... Greg Shah

10:11 AM Feature #4065: server-side processing of client platform dependencies

Greg Shah wrote:
> > Should we pursue some kind of EXECUTE permissions on the OS-COMMAND statement?
>
> It is a r... Hynek Cihlar

09:49 AM Feature #4065: server-side processing of client platform dependencies

I think you can add this @EXECUTE@ extra bit into the @BitFlagsResource@ directory. Greg Shah

09:48 AM Feature #4065: server-side processing of client platform dependencies

> Except I think we should implicitly deny access when no permission rule is matched.
Agreed. We always should a... Greg Shah

08:55 AM Feature #4065: server-side processing of client platform dependencies

Hynek Cihlar wrote:
> Also we should introduce the EXECUTE permission.
I will rephrase this to a question. Shoul... Hynek Cihlar

08:49 AM Feature #4065: server-side processing of client platform dependencies

Greg Shah wrote:
> > The actual file-system security model will be based on the Linux file-system security model.
>... Hynek Cihlar

08:32 AM Feature #4065: server-side processing of client platform dependencies

> Current FWD security model doesn't have primitives for file-system resources, this will have to be extended.
> The... Greg Shah

08:04 AM Feature #4065: server-side processing of client platform dependencies

I created task branch 4065a based on trunk revision 14477. Hynek Cihlar

07:34 AM Feature #4065: server-side processing of client platform dependencies

I'm currently working on the file-system server-side processing. Here are a few notables:
* Current FWD security m... Hynek Cihlar

09:55 AM Feature #6421 (Feedback): finish GENERATE-RANDOM-KEY support

Theodoros Theodorou

04:01 AM Feature #6421: finish GENERATE-RANDOM-KEY support

> Did you add the unknown value test code?
I added this:... Theodoros Theodorou

09:54 AM Bug #6399 (WIP): ENCRYPT/DECRYPT built-in function results different than 4GL when IV is shorter ...

Theodoros Theodorou

02/08/2023

02:08 PM Bug #7089 (WIP): sanitize p2j.oo method signature

I have the changes to solve the signature inconsistencies in @p2j.oo@, but I'll wait to create a branch after 6129c i... Constantin Asofiei

02:01 PM Feature #6818 (WIP): analyze the performance of the FWD open client proxy client support

I have changes force "schema marshall" to NONE in case of TABLE/DATASET parameters (although I need somehow to force ... Constantin Asofiei

01:06 PM Feature #6421: finish GENERATE-RANDOM-KEY support

Yes. At this time we don't branch testcases, so we have no trunk concept there. Instead of saying pushing to trunk ... Greg Shah

12:33 PM Feature #6421: finish GENERATE-RANDOM-KEY support

> > @sed ...@
>
> These changes should actually be the default in Hotel GUI. Please make the edits and commit the... Theodoros Theodorou

02/07/2023

11:51 AM Feature #6421: finish GENERATE-RANDOM-KEY support

> @rm -rf ~/projects/hotel_gui/abl/*@
I think you should not do this, in general. Try @ant clean.all@ instead.
... Greg Shah

10:33 AM Feature #6421: finish GENERATE-RANDOM-KEY support

I need help running the test with FWD. I tried some things but it didn't work. My project tree is:... Theodoros Theodorou

08:04 AM Feature #6421: finish GENERATE-RANDOM-KEY support

No, I am referring to the Progress 4GL concept of unknown value (which can be represented with the literal constant @... Greg Shah

02:33 AM Feature #6421: finish GENERATE-RANDOM-KEY support

By unknown value, you mean non-ASCII characters? I wasn't able to run the test with FWD yet. I will try to run it tod... Theodoros Theodorou

02/06/2023

09:56 AM Feature #6421: finish GENERATE-RANDOM-KEY support

I think it is good. Just add a test for unknown value. You can't do that one with a preprocessor define, so just ha... Greg Shah

09:30 AM Feature #6421: finish GENERATE-RANDOM-KEY support

Please review the following test. The rest was developed and run on the AWS VM. I also included encryption/decryption... Theodoros Theodorou

02/02/2023

11:15 AM Feature #6421: finish GENERATE-RANDOM-KEY support

Theodoros Theodorou wrote:
> Is this test below a good test? Should I store it at @testcases/security/security-polic... Igor Skornyakov

11:10 AM Feature #6421: finish GENERATE-RANDOM-KEY support

Do you have test code for the error cases that I mentioned in #6421-16?
In your testcase #6421-21, you should avoi... Greg Shah

10:41 AM Feature #6421: finish GENERATE-RANDOM-KEY support

Hello Igor and thank you for your review.
I replaced @getAlgKeyLen()@ with @SecurityPlicyManager.getSymmetricCiper... Theodoros Theodorou

09:58 AM Feature #6410: implement additional built-in OO classes/interfaces

> we can then keep OE11.7 as main target and OE12.2 'extensions/fixes' are only nice to have?
Correct. If there a... Greg Shah

09:41 AM Feature #6410: implement additional built-in OO classes/interfaces

Greg Shah wrote:
> I prefer not to have different FWD branches for different OE versions.
Understood, then only... Marian Edu

09:25 AM Feature #6410: implement additional built-in OO classes/interfaces

11.7 and 12.2 is fine.
> Now, this only has effect at compile time - for FWD will be when the conversion is execut... Greg Shah

03:12 AM Feature #6410: implement additional built-in OO classes/interfaces

Greg Shah wrote:
> Yes, please use @PROVERSION@ and preprocessing to conditionally implement logic by OE version.
... Marian Edu

02/01/2023

02:34 PM Feature #6649: improve the performance or SourceNameMapper runtime

Does @SourceNameMapper.convertName()@ often get called with the same @legacyProgName@ and @lookup@ function? If so, ... Greg Shah

02:34 PM Feature #6649: improve the performance or SourceNameMapper runtime

Code Review Task Branch 6129b Revision 14394
The changes look good. Greg Shah

01:26 PM Feature #6421: finish GENERATE-RANDOM-KEY support

Theodoros Theodorou wrote:
> I read the encryption algorithm by using @SecurityPolicyManager.getSymmetricEncryptionA... Igor Skornyakov

12:55 PM Feature #6421: finish GENERATE-RANDOM-KEY support

Greg Shah wrote:
> The original code in @SecurityOps.generateRandomKey()@ was forced to @AES_CBC_128@. Take a look... Igor Skornyakov

12:47 PM Feature #6421: finish GENERATE-RANDOM-KEY support

The original code in @SecurityOps.generateRandomKey()@ was forced to @AES_CBC_128@. Take a look at trunk. Greg Shah

12:45 PM Feature #6421: finish GENERATE-RANDOM-KEY support

Greg Shah wrote:
> Igor: Please review.
Sorry, I do not understand. As far as I remember and can see from the cod... Igor Skornyakov

12:26 PM Feature #6421: finish GENERATE-RANDOM-KEY support

> Do I need to checkout 6421a from the testcases project or use the main branch?
I'm not exactly sure what you are... Greg Shah

08:45 AM Feature #6421: finish GENERATE-RANDOM-KEY support

Do I need to checkout 6421a from the testcases project or use the main branch?
Then I should include my @test-genr... Theodoros Theodorou

09:39 AM Bug #7089: sanitize p2j.oo method signature

In incremental conversion, it was found that a @RequestBuilder.put@ method's LegacySignature was inconsistent with th... Constantin Asofiei

09:27 AM Bug #7089 (WIP): sanitize p2j.oo method signature

Constantin Asofiei

08:52 AM Feature #6410 (WIP): implement additional built-in OO classes/interfaces

Marian Edu

01/31/2023

09:30 AM Feature #6421: finish GENERATE-RANDOM-KEY support

Yes, except it would be useful to put slightly more detail in the comment. Something like this seems appropriate:
... Greg Shah

09:18 AM Feature #6421: finish GENERATE-RANDOM-KEY support

History entry means to add a comment in the beginning of the file?
Like the following?... Theodoros Theodorou

09:12 AM Feature #6421: finish GENERATE-RANDOM-KEY support

Theodoros Theodorou wrote:
> How to write test cases?
[[p2j:Writing 4GL Testcases]]
[[p2j:Testing_Process#Proje... Greg Shah

09:03 AM Feature #6421: finish GENERATE-RANDOM-KEY support

How to write test cases? I thought that the p2j test cases do not run. Theodoros Theodorou

06:20 AM Feature #6421: finish GENERATE-RANDOM-KEY support

Code Review Task Branch 6421a Revision 14484
1. @generateRandomKey()@ needs complete error handling. Please write... Greg Shah

05:41 AM Feature #6421: finish GENERATE-RANDOM-KEY support

Igor: Please review. Greg Shah

02:06 AM Feature #6421 (Review): finish GENERATE-RANDOM-KEY support

I have committed my changes and the task is ready for review Theodoros Theodorou

02:05 AM Feature #6421: finish GENERATE-RANDOM-KEY support

I have created the branch 6421a Theodoros Theodorou

01/30/2023

10:37 AM Feature #6649: improve the performance or SourceNameMapper runtime

I checked in various performance changes in 6129b revision 14394. Please review. Hynek Cihlar

01/27/2023

01:18 PM Feature #7082: Improve converted call site names

I think we can provide this as an option, though if we do we will want to reduce some of the text (maybe remove the @... Greg Shah

12:57 PM Feature #7082: Improve converted call site names

I suggest to make call site names more readable. E.g. I have to click each of this sites to understand what this code... Stanislav Lomany

12:51 PM Feature #7082 (New): Improve converted call site names

Stanislav Lomany

08:04 AM Feature #3853: implement LOG-MANAGER runtime

I've found a workaround fix for batch writing all @stdout@ through @ErrorWriterBatch#displayError()@, which messed up... Galya B

01/26/2023

10:06 AM Feature #6820: reduce String.toLowerCase and toUpperCase usage and String instances

The use of @String.toLowerCase@ and @toUpperCase@ in @P2JField.computeHash - 90k@ and @Validation.setUniqueQueryPara... Hynek Cihlar

09:58 AM Feature #6820: reduce String.toLowerCase and toUpperCase usage and String instances

The use of @toLowerCase@ and @toUpperCase@ in @h2.Function.getSimpleValue - 178k@ is valid there. Hynek Cihlar

09:04 AM Feature #6421: finish GENERATE-RANDOM-KEY support

Create a task branch (6421a) and you can commit changes there. Greg Shah

08:52 AM Feature #6421: finish GENERATE-RANDOM-KEY support

I read the encryption algorithm by using @SecurityPolicyManager.getSymmetricEncryptionAlgorithm().toStringMessage()@.... Theodoros Theodorou

01/25/2023

04:13 PM Feature #6649: improve the performance or SourceNameMapper runtime

Greg Shah wrote:
> 3821c?
I meant 6129b. 3821c has burned into my cerebral cortex after the years working with th... Hynek Cihlar

04:08 PM Feature #6649: improve the performance or SourceNameMapper runtime

3821c? Greg Shah

03:48 PM Feature #6649: improve the performance or SourceNameMapper runtime

3821c revision 14382 introduces caching of resolved procedure internal entries. It speeds up tests in a large custome... Hynek Cihlar

01:06 PM Feature #3853: implement LOG-MANAGER runtime

I've found an unexpected behavior with batch execution. @stdout@ is displayed using @ErrorManager.displayError(lineOu... Galya B

07:37 AM Bug #7073 (New): Launching non-interactive program creates JNI core dump in process_linux.c due t...

Greg Shah

11:25 PM Bug #7073: Launching non-interactive program creates JNI core dump in process_linux.c due to ncurses

Greg Shah wrote:
> That failing code is not code that is checked in to trunk. It is specific to *your system*. You... Roger Borrello

07:29 PM Bug #7073 (Rejected): Launching non-interactive program creates JNI core dump in process_linux.c ...

That failing code is not code that is checked in to trunk. It is specific to *your system*. Your logging is broken. Greg Shah

01/24/2023

06:57 PM Bug #7073: Launching non-interactive program creates JNI core dump in process_linux.c due to ncurses

With logging added to @process_linux.c@ we see it occur in @ fprintf(fp, "pseudoTerminalWait: move cursor part 2... Roger Borrello

06:56 PM Bug #7073: Launching non-interactive program creates JNI core dump in process_linux.c due to ncurses

@uast/util/process_launch_helper.p@ can be used.
Using Swing, run the program, and pass in any command, like *ls*
... Roger Borrello

06:50 PM Bug #7073 (New): Launching non-interactive program creates JNI core dump in process_linux.c due t...

Roger Borrello

02:53 AM Feature #6649: improve the performance or SourceNameMapper runtime

Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > Constantin Asofiei wrote:
> > > Bellow are the backtraces for ... Hynek Cihlar

02:38 AM Feature #6649: improve the performance or SourceNameMapper runtime

Hynek Cihlar wrote:
> Constantin Asofiei wrote:
> > Bellow are the backtraces for @SourceNameMapper.getInternalEntr... Constantin Asofiei

02:37 AM Feature #6649: improve the performance or SourceNameMapper runtime

Constantin Asofiei wrote:
> Bellow are the backtraces for @SourceNameMapper.getInternalEntry@ - these are reduced af... Hynek Cihlar

02:24 AM Feature #6649: improve the performance or SourceNameMapper runtime

Bellow are the backtraces for @SourceNameMapper.getInternalEntry@ - these are reduced after the InvokeConfig call-sit... Constantin Asofiei