FWD » Core Development » Base Language

03/10/2023

12:00 PM Feature #6497: add equivalent support for the -T command line option

Constantin Asofiei wrote:
> Also, when @-T@ is set, there must be a check if this folder really exists - if it doesn... Constantin Asofiei

11:57 AM Feature #6497: add equivalent support for the -T command line option

Regarding where to save this @-T@ option - @Utils$WorkArea.explicitTempFolder@ should be OK (a better name can be used). Constantin Asofiei

11:56 AM Feature #6497: add equivalent support for the -T command line option

There are some issues here. The @-T@ option in FWD must specify the root folder where client-specific temp folders a... Constantin Asofiei

11:51 AM Feature #6497: add equivalent support for the -T command line option

I found this documentation page: https://proj.goldencode.com/projects/p2j/wiki/Bootstrap_Configuration
As I unders... Theodoros Theodorou

03/09/2023

08:43 AM Bug #7184: Incorrect conversion of concatenated string literals to a LONGCHAR

The code:... Vladimir Tsichevski

08:42 AM Bug #7184 (Closed): Incorrect conversion of concatenated string literals to a LONGCHAR

Vladimir Tsichevski

07:52 AM Feature #6425 (WIP): SESSION handle features

The customer reports that:
* The idea is that this method will return the current text in the message area. They ... Greg Shah

03:29 AM Feature #6425: SESSION handle features

Great, thanks :) Theodoros Theodorou

03/08/2023

04:30 PM Feature #6425: SESSION handle features

I'll ask the customer if they can provide details of what it should do or how to write code to see it in action. Greg Shah

04:21 PM Feature #6425: SESSION handle features

Yes, @MESSAGE-AREA-MSG()@ always returns an empty string.
@security-policy:symmetric-encryption-algorithm@ is a ra... Theodoros Theodorou

09:20 AM Feature #6425: SESSION handle features

I suggest that you should not use the @MESSAGE@ statement while also testing @MESSAGE-AREA-MSG()@. What is returned ... Greg Shah

09:13 AM Feature #6425: SESSION handle features

I tried many combinations like the following without any result.... Theodoros Theodorou

04:08 AM Feature #4382: implement configurable directory override for PROGRESS global variable

Done Theodoros Theodorou

03/07/2023

02:23 PM Feature #4382: implement configurable directory override for PROGRESS global variable

Greg Shah wrote:
> > the path being used is @legacy-system/progress@. Greg, I think we need a @legacy-variables/pro... Constantin Asofiei

02:09 PM Feature #4382: implement configurable directory override for PROGRESS global variable

> the path being used is @legacy-system/progress@. Greg, I think we need a @legacy-variables/progress@, as this is n... Greg Shah

01:31 PM Feature #4382: implement configurable directory override for PROGRESS global variable

Review for 4382a/14498:
* the path being used is @legacy-system/progress@. Greg, I think we need a @legacy-variable... Constantin Asofiei

12:55 PM Feature #4382: implement configurable directory override for PROGRESS global variable

I have recreated the branch 4382a and pushed the changes there Theodoros Theodorou

10:42 AM Feature #4382: implement configurable directory override for PROGRESS global variable

Theodoros Theodorou wrote:
> Oh, my bad. I created the branch 4382a and my intention was to push the changes there, ... Constantin Asofiei

08:23 AM Feature #4382: implement configurable directory override for PROGRESS global variable

I just uncommitted the change from trunk.
We will go through our normal review and testing process. Greg Shah

08:21 AM Feature #4382: implement configurable directory override for PROGRESS global variable

Oh, my bad. I created the branch 4382a and my intention was to push the changes there, not in the trunk. The changes ... Theodoros Theodorou

08:10 AM Feature #4382: implement configurable directory override for PROGRESS global variable

Greg, FWD trunk has a commit for #4382:... Constantin Asofiei

07:13 AM Feature #4382: implement configurable directory override for PROGRESS global variable

Yes, the branch is 4382a. Should I mention it here when I create a branch? Theodoros Theodorou

01:08 PM Feature #6497 (WIP): add equivalent support for the -T command line option

Theodoros Theodorou

08:29 AM Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception

Greg Shah wrote:
> > But, I don't like changing the semantics of @returnNormal@, depending from where it is being ca... Constantin Asofiei

08:17 AM Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception

> But, I don't like changing the semantics of @returnNormal@, depending from where it is being called - as this can b... Greg Shah

04:14 AM Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception

In #7142, we found that @p2j.oo@ code still relies on @returnNormal@ to throw a @ReturnUnwindException@. A fix is in... Constantin Asofiei

08:05 AM Bug #7176: cleanup p2j.oo code considering the #7045 and #7122

With #7045, now @returnNormal@ will not throw a @ReturnUnwindException@ if it's being called from a function. In #71... Constantin Asofiei

08:03 AM Bug #7176 (New): cleanup p2j.oo code considering the #7045 and #7122

Constantin Asofiei

04:51 AM Bug #7175 (Review): substitute: incorrect handling of unknown longchar values

Committed as 3827a rev. 14502. Vladimir Tsichevski

04:47 AM Bug #7175 (WIP): substitute: incorrect handling of unknown longchar values

This patch fixes this issue:... Vladimir Tsichevski

04:44 AM Bug #7175: substitute: incorrect handling of unknown longchar values

An *unknown* @lonchar@ value passed as an formatting parameter for @substitute@ is formatted as @null@ instead of exp... Vladimir Tsichevski

04:42 AM Bug #7175 (Closed): substitute: incorrect handling of unknown longchar values

Vladimir Tsichevski

03/06/2023

06:11 PM Feature #4382: implement configurable directory override for PROGRESS global variable

Did you create a branch for the changes? Greg Shah

05:57 PM Feature #4382 (Review): implement configurable directory override for PROGRESS global variable

Theodoros Theodorou

05:56 PM Feature #4382 (WIP): implement configurable directory override for PROGRESS global variable

Theodoros Theodorou

11:40 AM Feature #6425: SESSION handle features

Trial and error. I would guess that the integer arg is the message "line number" for which to get the current text. ... Greg Shah

11:26 AM Feature #6425: SESSION handle features

You are right, it exists. I tried to run it with many arguments and examples and I found that it takes one integer ar... Theodoros Theodorou

08:18 AM Feature #6425: SESSION handle features

> I tried on a customer AWS VM which has v11.7 and it throws an error. Also, the autocomplete does not show @MESSAGE-... Greg Shah

11:05 AM Bug #7135 (Closed): NPE in conversion of OO looking for oldtype annotation

Greg Shah

10:46 AM Bug #7135 (Test): NPE in conversion of OO looking for oldtype annotation

7135a was merged to trunk as revision 14493. It was archived. Roger Borrello

03/03/2023

11:27 AM Feature #6425 (Review): SESSION handle features

Finished with the startup-parameters. The ticket is ready for review. I should also create a test, right? Theodoros Theodorou

07:00 AM Feature #6821: java collection performance

Greg Shah wrote:
> > Ultimately, we could iterate the tables individually and process (delete/update then invalidate... Alexandru Lungu

02:54 AM Feature #4382: implement configurable directory override for PROGRESS global variable

Theodoros, I think the path should be @runtime/{default|<server ID}@ - look how @widget-descriptors@ are loaded in @W... Constantin Asofiei

02:49 AM Feature #4382: implement configurable directory override for PROGRESS global variable

kind reminder Theodoros Theodorou

03/02/2023

04:35 PM Bug #7135: NPE in conversion of OO looking for oldtype annotation

Not at this time. Greg Shah

04:34 PM Bug #7135: NPE in conversion of OO looking for oldtype annotation

Roger Borrello wrote:
> 7135a has been rebased to trunk_14490.
If there are other customers that might have the s... Roger Borrello

03:45 PM Bug #7135: NPE in conversion of OO looking for oldtype annotation

7135a has been rebased to trunk_14490. Roger Borrello

04:13 PM Feature #6425: SESSION handle features

I tried on a customer AWS VM which has v11.7 and it throws an error. Also, the autocomplete does not show @MESSAGE-AR... Theodoros Theodorou

08:26 AM Feature #6425: SESSION handle features

We believe it exists but it is undocumented. It is possible it only exists in some recent level of OE. Please check... Greg Shah

07:49 AM Feature #6425: SESSION handle features

I think the @SESSION:MESSAGE-AREA-MSG@ does not exist. Can you please confirm? Theodoros Theodorou

03/01/2023

03:39 PM Bug #7135: NPE in conversion of OO looking for oldtype annotation

Constantin Asofiei wrote:
> The patch is permanent.
Thanks... I will pursue the customer checking the patched ver... Roger Borrello

03:15 PM Bug #7135: NPE in conversion of OO looking for oldtype annotation

Roger Borrello wrote:
> Opened task #7146 for the other runtime issue.
>
> Is the patching of the customer app pr... Constantin Asofiei

03:13 PM Bug #7135: NPE in conversion of OO looking for oldtype annotation

Opened task #7146 for the other runtime issue.
Is the patching of the customer app procedures as noted in #7135-34... Roger Borrello

10:50 AM Feature #6425: SESSION handle features

It doesn't matter. Greg Shah

10:26 AM Feature #6425: SESSION handle features

The code @message session:local-version-info@ prints @Progress.Lang.OEVersionInfo...1000@ using FWD and @Progress.Lan... Theodoros Theodorou

02/27/2023

05:41 PM Feature #6425 (WIP): SESSION handle features

Theodoros Theodorou

02/24/2023

12:52 PM Feature #4382: implement configurable directory override for PROGRESS global variable

... Theodoros Theodorou

10:43 AM Bug #7135 (Review): NPE in conversion of OO looking for oldtype annotation

Opened task #7145 to handle the first of the runtime errors. Roger Borrello

05:57 AM Bug #7135: NPE in conversion of OO looking for oldtype annotation

Open bugs for these runtime issues. If conversion works now, we move on and close this task. Greg Shah

10:06 AM Feature #6819: refactor FWD proxy implementation to use ReflectASM instead of Java Method reflection

Greg Shah wrote:
> > With this in mind, I think it shouldn't take too long to change the invocation handler to recei... Constantin Asofiei

10:03 AM Feature #6819: refactor FWD proxy implementation to use ReflectASM instead of Java Method reflection

> With this in mind, I think it shouldn't take too long to change the invocation handler to receive the info for Refl... Greg Shah

06:30 AM Feature #6819: refactor FWD proxy implementation to use ReflectASM instead of Java Method reflection

I've changed the original #6819-3 test so that a new @Object[]@ (for the varargs) is not created on each call (so a s... Constantin Asofiei

07:11 AM Feature #6821: java collection performance

Constantin Asofiei wrote:
> Yes, this was from profiling a customer's application.
Great. Review complete, approved.
Tijs Wickardt

07:10 AM Feature #6821: java collection performance

Tijs Wickardt wrote:
> Did you profile this? (I see #6821-55 but it seems high level).
Yes, this was from profiling... Constantin Asofiei

07:09 AM Feature #6821: java collection performance

Constantin Asofiei wrote:
> The overhead is seen when this code is executed millions of times - I agree that using a... Tijs Wickardt

07:04 AM Feature #6821: java collection performance

Tijs Wickardt wrote:
> Reviewed @p2j 7026a -r14497..14499@ .
> The changes are good.
> Remark on @Avoid the overhe... Constantin Asofiei

07:01 AM Feature #6821 (WIP): java collection performance

Tijs Wickardt

07:00 AM Feature #6821: java collection performance

Reviewed @p2j 7026a -r14497..14499@ .
The changes are good.
Remark on @Avoid the overhead of calculating an empty m... Tijs Wickardt

05:03 AM Feature #6821 (Review): java collection performance

Reviewing. Tijs Wickardt

04:30 AM Feature #6410: implement additional built-in OO classes/interfaces

Greg Shah wrote:
> 6129b which is now in trunk revision 14484 does have all my previous work on method overloading. ... Marian Edu

02/23/2023

05:30 PM Bug #7135: NPE in conversion of OO looking for oldtype annotation

There's a lot of issues. Noted one for the GUI application in #6851-203. The ChUI app gets @** LABEL is not a setable... Roger Borrello

04:35 PM Bug #7135: NPE in conversion of OO looking for oldtype annotation

So the incremental build completed, including the compilation. I will need to do some testing, but this is committed ... Roger Borrello

02:31 PM Bug #7135: NPE in conversion of OO looking for oldtype annotation

Constantin Asofiei wrote:
> Only the ToString which has an argument as @java.util.Map@ needs to change. Do not touc... Roger Borrello

02:16 PM Bug #7135: NPE in conversion of OO looking for oldtype annotation

I've just noticed something in your patch - I mean to change:
> METHOD PUBLIC CHARACTER ToString (INPUT pChartHash A... Constantin Asofiei

02:15 PM Bug #7135: NPE in conversion of OO looking for oldtype annotation

Roger, thanks, that confirms what you posted. Just change the 4GL method definitions in these classes to be @asStrin... Constantin Asofiei

02:13 PM Bug #7135: NPE in conversion of OO looking for oldtype annotation

I see this:... Roger Borrello

02:09 PM Bug #7135: NPE in conversion of OO looking for oldtype annotation

FYI, officially we do not support subclassing 4GL code from Java parent classes or implementing Java interfaces in 4G... Greg Shah

02:01 PM Bug #7135: NPE in conversion of OO looking for oldtype annotation

I think @LabelRenderer@ is part of the FWD's @ChartWidget.labelHash@, which is not implemented at this time. Constantin Asofiei

01:58 PM Bug #7135: NPE in conversion of OO looking for oldtype annotation

Something like this, and @ToString (INPUT pChartHash AS java.util.Map): @ needs to be @asString (INPUT pChartHash AS ... Constantin Asofiei

01:39 PM Bug #7135: NPE in conversion of OO looking for oldtype annotation

So the five 4GL procedures that had issues with @LabelRenderer.toLegacyString@:
# app_7135a-14486_20230215a/src/.../... Roger Borrello

01:19 PM Bug #7135: NPE in conversion of OO looking for oldtype annotation

Roger, as a fast way to solve it: in the 4GL code, can we change all @RenderLabelData.ToString(INPUT pChartHash AS ja... Constantin Asofiei

01:08 PM Bug #7135: NPE in conversion of OO looking for oldtype annotation

Roger, is a little more tricky than this, @NameConverter@ will automatically append an underscore because @toString@ ... Constantin Asofiei

12:53 PM Bug #7135: NPE in conversion of OO looking for oldtype annotation

Constantin Asofiei wrote:
> Roger, sorry, in this case rename toLegacyString in the Java class to toString. That na... Roger Borrello

12:44 PM Bug #7135: NPE in conversion of OO looking for oldtype annotation

Roger, sorry, in this case rename toLegacyString in the Java class to toString. That name was chosen because of the ... Constantin Asofiei

12:40 PM Bug #7135: NPE in conversion of OO looking for oldtype annotation

Yes Greg Shah

12:36 PM Bug #7135: NPE in conversion of OO looking for oldtype annotation

So the 4GL would need to be patched to have @toString@ become @toLegacyString@:... Roger Borrello

12:31 PM Bug #7135: NPE in conversion of OO looking for oldtype annotation

Greg Shah wrote:
> You are proposing that we just hand-edit the 4GL source code to change the names?
Correct. If a... Constantin Asofiei

12:31 PM Bug #7135: NPE in conversion of OO looking for oldtype annotation

You are proposing that we just hand-edit the 4GL source code to change the names? Greg Shah

10:39 AM Bug #7135: NPE in conversion of OO looking for oldtype annotation

Greg, adding the @LegacySignature@ at a Java interface method will not work.
Before 6129c, @toString@ I think had ... Constantin Asofiei

10:35 AM Bug #7135: NPE in conversion of OO looking for oldtype annotation

Look at anything in @com.goldencode.p2j.oo@. Greg Shah

10:29 AM Bug #7135: NPE in conversion of OO looking for oldtype annotation

Greg Shah wrote:
> The @com.goldencode.p2j.ui.chart.LabelRenderer@ does not include the normal legacy signature anno... Roger Borrello

09:25 AM Bug #7135: NPE in conversion of OO looking for oldtype annotation

We are choosing to emit @toString_()@ name instead of @toLegacyString()@ in the child classes.
The @com.goldencode... Greg Shah

09:18 AM Bug #7135: NPE in conversion of OO looking for oldtype annotation

For this class:... Roger Borrello

08:11 AM Bug #7135: NPE in conversion of OO looking for oldtype annotation

This is probably something different. The @toLegacyString(jobject<? extends Map>)@ is our replacement name for @toSt... Greg Shah

12:28 PM Feature #6821: java collection performance

7026a/14499 contains some other improvements:
* Avoid the @LinkedList@ overhead, use @ArrayDeque@ instead, for @Nam... Constantin Asofiei

02/22/2023

04:56 PM Bug #7135 (WIP): NPE in conversion of OO looking for oldtype annotation

The app converted successfully with both changes in place!
But there were compilation errors:... Roger Borrello

02/21/2023

02:34 PM Bug #7135 (Review): NPE in conversion of OO looking for oldtype annotation

Committed revision 7135a_14486. Re-running customer app conversion. Roger Borrello

02:10 PM Bug #7135: NPE in conversion of OO looking for oldtype annotation

It is fine for now. Greg Shah

02:06 PM Bug #7135: NPE in conversion of OO looking for oldtype annotation

Roger, please try this patch:... Constantin Asofiei

01:55 PM Bug #7135: NPE in conversion of OO looking for oldtype annotation

This testcase:... Roger Borrello

11:49 AM Bug #7135: NPE in conversion of OO looking for oldtype annotation

Constantin Asofiei wrote:
> Please work on a standalone test and lets use this task for the customer's app issues wi... Roger Borrello

10:50 AM Bug #7135: NPE in conversion of OO looking for oldtype annotation

Please work on a standalone test and lets use this task for the customer's app issues with trunk (conversion or runti... Constantin Asofiei

10:40 AM Bug #7135: NPE in conversion of OO looking for oldtype annotation

Roger Borrello wrote:
> I will see if it is related to the change, versus a different issue.
I see that issue whe... Roger Borrello

09:27 AM Bug #7135 (WIP): NPE in conversion of OO looking for oldtype annotation

Greg Shah wrote:
> If this passes testing, we will merge it to trunk.
There was an issue later in the conversion ... Roger Borrello

07:13 AM Bug #7135: NPE in conversion of OO looking for oldtype annotation

If this passes testing, we will merge it to trunk. Greg Shah

07:13 AM Bug #7135 (Test): NPE in conversion of OO looking for oldtype annotation

Code Review Task Branch 7135a Revision 14485
No objections. Greg Shah

10:05 AM Feature #6410: implement additional built-in OO classes/interfaces

> For ctor's this doesn't seem to work at all
6129b which is now in trunk revision 14484 does have all my previous... Greg Shah

09:46 AM Feature #6410: implement additional built-in OO classes/interfaces

Greg Shah wrote:
> Are you working off of trunk rev 14484?
Conversion was ran with trunk #14483, working on 6129b... Marian Edu

09:36 AM Feature #6410: implement additional built-in OO classes/interfaces

> is there any update on method/ctor resolution during conversion in regard with Java erasure issue caused by the `ob... Greg Shah

09:13 AM Feature #6410: implement additional built-in OO classes/interfaces

Greg, is there any update on method/ctor resolution during conversion in regard with Java erasure issue caused by the... Marian Edu

09:56 AM Feature #6818: analyze the performance of the FWD open client proxy client support

7026a/14497 contains changes for the legacy JavaOpenClient:
* Encapsulated the field and relation metadata in their... Constantin Asofiei

02/20/2023

06:54 PM Bug #7135 (Review): NPE in conversion of OO looking for oldtype annotation

Branch 7135a rev 14485 ready for review. Roger Borrello

04:05 PM Bug #7135: NPE in conversion of OO looking for oldtype annotation

Yes Greg Shah

02:44 PM Bug #7135 (WIP): NPE in conversion of OO looking for oldtype annotation

Running conversion. Should I create a branch 7135a? Roger Borrello

02:17 PM Bug #7135: NPE in conversion of OO looking for oldtype annotation

Roger Borrello wrote:
> Is this a fix I should try against the customer's code?
Yes.
Constantin Asofiei

02:12 PM Bug #7135: NPE in conversion of OO looking for oldtype annotation

That results in a successful conversion. So those warnings are just red-herrings?
Is this a fix I should try again... Roger Borrello

01:47 PM Bug #7135: NPE in conversion of OO looking for oldtype annotation

Roger, please try this patch (on top of trunk rev 14484):... Constantin Asofiei

01:32 PM Bug #7135: NPE in conversion of OO looking for oldtype annotation

The AST is attached: Roger Borrello

01:30 PM Bug #7135: NPE in conversion of OO looking for oldtype annotation

Using this testcase (placed in @uast/oo@:... Roger Borrello

01:26 PM Bug #7135 (Closed): NPE in conversion of OO looking for oldtype annotation

Roger Borrello

04:10 PM Feature #6426 (Closed): implement ERROR-STATUS:CLEAR()

In the short term it is fine. In the longer term we will probably need to fix it. Greg Shah

12:12 PM Feature #6426: implement ERROR-STATUS:CLEAR()

Greg, IMO, I think we are OK with 'doing nothing'. Otherwise, we can treat these cases of invalid attribute/method r... Constantin Asofiei

10:21 AM Feature #6426: implement ERROR-STATUS:CLEAR()

Yes, I noticed it. Do I need to make any changes (e.g. show a warning)? Theodoros Theodorou

08:40 AM Feature #6426: implement ERROR-STATUS:CLEAR()

There is nothing emitted by conversion in @error-status:clear().@, see the standalone @;@ char on a single line. Constantin Asofiei

02/17/2023

02:27 PM Feature #6819: refactor FWD proxy implementation to use ReflectASM instead of Java Method reflection

Constantin Asofiei wrote:
> Greg: we need to consider if we want to make it a policy to discourage Java lambda, th... Eric Faulhaber

12:53 PM Feature #6426: implement ERROR-STATUS:CLEAR()

Post here the .java file for your converted program. Constantin Asofiei

12:53 PM Feature #6426: implement ERROR-STATUS:CLEAR()

I am not sure. I compiled and ran the app using the testcases project without any issues. Theodoros Theodorou

12:00 PM Feature #6426: implement ERROR-STATUS:CLEAR()

I'm confused, how does FWD convert @error-status:clear().@? Constantin Asofiei

11:58 AM Feature #6426: implement ERROR-STATUS:CLEAR()

Yes, the error occurs at runtime... Theodoros Theodorou

10:16 AM Feature #6426: implement ERROR-STATUS:CLEAR()

Hmm, we must have done something special for this case (or for @ERROR-STATUS@ in general).
To confirm, the error... Greg Shah

06:05 AM Feature #6426: implement ERROR-STATUS:CLEAR()

No, FWD does not fail during conversion. FWD and OE both have the same output. The only difference is that OE pops up... Theodoros Theodorou

05:41 AM Feature #6426: implement ERROR-STATUS:CLEAR()

I need to discuss this with the customer.
FWD fails during conversion of this testcase, right? Greg Shah

04:10 AM Feature #6426: implement ERROR-STATUS:CLEAR()

Do I need to do something more for this ticket now? Theodoros Theodorou

06:11 AM Feature #4382: implement configurable directory override for PROGRESS global variable

Can you please elaborate more? Theodoros Theodorou

05:58 AM Feature #4382: implement configurable directory override for PROGRESS global variable

No, this is a reference to the @directory.xml@ used as the configuration source for the FWD application server. Greg Shah

05:57 AM Feature #4382: implement configurable directory override for PROGRESS global variable

I would like to ask for some help. Directory override means changing the working directory on runtime or does it mean... Theodoros Theodorou

02/16/2023

01:54 PM Feature #6426: implement ERROR-STATUS:CLEAR()

True, though we will eventually be implementing a pure handle approach to everything. For example, I expect an @ERRO... Greg Shah

01:44 PM Feature #6426: implement ERROR-STATUS:CLEAR()

In OE 11.6.3 this attribute is not part of the ERROR-STATUS handle.
OE does not do any compile-time strong-type ch... Constantin Asofiei

01:40 PM Feature #6426: implement ERROR-STATUS:CLEAR()

I think it is 11.7.
Perhaps this is just broken code (at runtime) but it compiles. Or perhaps it is a newer (undo... Greg Shah

11:28 AM Feature #6426: implement ERROR-STATUS:CLEAR()

Greg, do you recall which OE version the customer's code was running? Constantin Asofiei

10:45 AM Feature #6426 (WIP): implement ERROR-STATUS:CLEAR()

I read a bit about the @error-status@ but I couldn't find anything online regarding @error-status:clear()@. I tried t... Theodoros Theodorou

07:36 AM Feature #6819: refactor FWD proxy implementation to use ReflectASM instead of Java Method reflection

Constantin Asofiei wrote:
> Review for 7026/rev. 14495. In @NanoTimer@, @UnclosablePreparedStatement@, @ContextLoca... Alexandru Lungu

06:34 AM Feature #6819: refactor FWD proxy implementation to use ReflectASM instead of Java Method reflection

Review for 7026/rev. 14495. In @NanoTimer@, @UnclosablePreparedStatement@, @ContextLocal@, please add history number... Constantin Asofiei

06:08 AM Feature #6819: refactor FWD proxy implementation to use ReflectASM instead of Java Method reflection

Constantin Asofiei wrote:
> Alexandru Lungu wrote:
> > Done!
> Great! Make sure to add history numbers to any chan... Alexandru Lungu

05:48 AM Feature #6819: refactor FWD proxy implementation to use ReflectASM instead of Java Method reflection

Status of the #6819-37 issues:
* @ContextLocal.get()@ - 16.5mm calls, related to JMX, tested with the JMX timer remo... Constantin Asofiei

05:32 AM Feature #6819: refactor FWD proxy implementation to use ReflectASM instead of Java Method reflection

Alexandru Lungu wrote:
> Done!
Great! Make sure to add history numbers to any changed file (just a reminder, histor... Constantin Asofiei

05:28 AM Feature #6819: refactor FWD proxy implementation to use ReflectASM instead of Java Method reflection

Done! Alexandru Lungu

05:16 AM Feature #6819: refactor FWD proxy implementation to use ReflectASM instead of Java Method reflection

Alexandru, please create a patch to fix the ContextLocal.get ( the @Object[] res@) first. This is something we can s... Constantin Asofiei

05:09 AM Feature #6819: refactor FWD proxy implementation to use ReflectASM instead of Java Method reflection

Constantin Asofiei wrote:
> I'll look at the patch, but I don't think allocated a vararg is a good approach. I'll t... Alexandru Lungu

07:17 AM Feature #6421 (Test): finish GENERATE-RANDOM-KEY support

Greg Shah

03:25 AM Feature #6421: finish GENERATE-RANDOM-KEY support

> 1. Didn't you have other changes needed to make the error handling correct?
In the beginning I modified the meth... Theodoros Theodorou

07:15 AM Bug #6399 (Closed): ENCRYPT/DECRYPT built-in function results different than 4GL when IV is short...

Greg Shah

04:56 AM Bug #6399: ENCRYPT/DECRYPT built-in function results different than 4GL when IV is shorter than r...

Thank you Igor for your help regarding the test. I modified it a bit and added it under @testcases/security/security_... Theodoros Theodorou

02/15/2023

02:21 PM Feature #6421: finish GENERATE-RANDOM-KEY support

Greg Shah wrote:
> Igor: Please review.
The changes look good. Igor Skornyakov

01:45 PM Feature #6421: finish GENERATE-RANDOM-KEY support

Code Review Task Branch 6421a Revision 14485
1. Didn't you have other changes needed to make the error handling co... Greg Shah

01:44 PM Feature #6421 (Review): finish GENERATE-RANDOM-KEY support

Igor: Please review. Greg Shah

10:42 AM Feature #6421: finish GENERATE-RANDOM-KEY support

I have recreated the branch 6421a after the branch 6129c was merged to trunk and committed all changes. Please review... Theodoros Theodorou

01:03 PM Feature #7126: replace 'new unknown()' with 'unknown.INSTANCE' in FWD conversion and runtime

Renamed @unknown.INSTANCE@ to @unknown.UNKNOWN@ in 7026a/14493. Constantin Asofiei

08:47 AM Feature #7126: replace 'new unknown()' with 'unknown.INSTANCE' in FWD conversion and runtime

Greg Shah wrote:
> How about if we add @import static com.goldencode.p2j.util.unknown.UNKNOWN;@ and then simply refe... Constantin Asofiei

08:44 AM Feature #7126: replace 'new unknown()' with 'unknown.INSTANCE' in FWD conversion and runtime

Good idea. My only critique is that I want to find a different name than @unknown.INSTANCE@. I think this is a bit ... Greg Shah

08:11 AM Feature #7126: replace 'new unknown()' with 'unknown.INSTANCE' in FWD conversion and runtime

In 7026a rev 14488, @new unknown()@ was replaced with @unknown.INSTANCE@ in parts of FWD runtime which showed up in p... Constantin Asofiei

08:09 AM Feature #7126 (New): replace 'new unknown()' with 'unknown.INSTANCE' in FWD conversion and runtime

Constantin Asofiei

11:51 AM Feature #6819: refactor FWD proxy implementation to use ReflectASM instead of Java Method reflection

Alexandru Lungu wrote:
> From the "statically extract lambda as class member" point of view...
My analysis seems to... Constantin Asofiei

11:46 AM Feature #6819: refactor FWD proxy implementation to use ReflectASM instead of Java Method reflection

I've done a patch, but in a bit of a rush.
There are several complex JMX which need rethinking, as there are > 5 ... Alexandru Lungu

11:39 AM Feature #6819: refactor FWD proxy implementation to use ReflectASM instead of Java Method reflection

Constantin Asofiei wrote:
> Now, after I looked again at the generated lambda code for this task, the lambdas are al... Constantin Asofiei

11:19 AM Feature #6819: refactor FWD proxy implementation to use ReflectASM instead of Java Method reflection

Actually, the inlined lambda Eden space allocations is because of the @Object[] res = new Object[1];@ array. Alexand... Constantin Asofiei

11:11 AM Feature #6819: refactor FWD proxy implementation to use ReflectASM instead of Java Method reflection

I've tried this idea with something like this in @LambdaPerf@:... Constantin Asofiei

10:15 AM Feature #6819: refactor FWD proxy implementation to use ReflectASM instead of Java Method reflection

Greg, if Alexandru's idea is proven successful, then I think the bytecode can be changed from:... Constantin Asofiei

09:08 AM Feature #6819: refactor FWD proxy implementation to use ReflectASM instead of Java Method reflection

Alexandru Lungu wrote:
> Unless my times are due to a Java compilation optimization, cutting down the code altogethe... Constantin Asofiei

09:04 AM Feature #6819: refactor FWD proxy implementation to use ReflectASM instead of Java Method reflection

I've run @LambdaPerf.java@ and I've got similar results. On my computer however, I get Lambda Call time (132.047478) ... Alexandru Lungu

05:47 AM Feature #7122: convert default getter/setter as plain Java methods

For default object property getter and setters, emit a plain Java method with a @return prop.duplicate();@ for a gett... Constantin Asofiei

05:21 AM Bug #7089: sanitize p2j.oo method signature

The current changes are in 7026a rev 14814. Constantin Asofiei

04:46 AM Feature #6826: reduce the BDT usage in FWD runtime

7826a/14811 fixes other cases to reduce BDT usage from within FWD runtime.
Constantin Asofiei

04:17 AM Feature #6820: reduce String.toLowerCase and toUpperCase usage and String instances

Committed to 7026a rev 14810. Constantin Asofiei

02/14/2023

02:22 PM Feature #7122 (WIP): convert default getter/setter as plain Java methods

Constantin Asofiei

09:35 AM Feature #7122: convert default getter/setter as plain Java methods

I don't see any reason to have the @BlockManager.function/procedure@ wrappers for default scalar getter/setter Java m... Constantin Asofiei

09:34 AM Feature #7122 (WIP): convert default getter/setter as plain Java methods

Constantin Asofiei

09:59 AM Bug #6399: ENCRYPT/DECRYPT built-in function results different than 4GL when IV is shorter than r...

I've used the attached program for testing cryptography.
May be it can be useful. Igor Skornyakov

08:57 AM Bug #6399: ENCRYPT/DECRYPT built-in function results different than 4GL when IV is shorter than r...

I'm OK with closing this task. Before we do that, please do/consider the following:
* Gather all of your various ... Greg Shah

08:38 AM Bug #6399: ENCRYPT/DECRYPT built-in function results different than 4GL when IV is shorter than r...

I tried many combinations with @AES_CBC_256@. Some of them can be found below. I keep getting identical results with ... Theodoros Theodorou

02/13/2023

02:26 PM Bug #6399: ENCRYPT/DECRYPT built-in function results different than 4GL when IV is shorter than r...

As far as I rememeber after the Constantin's fix we are 100% binary compatible with 4GL with respect to the encryptio... Igor Skornyakov

02:21 PM Bug #6399: ENCRYPT/DECRYPT built-in function results different than 4GL when IV is shorter than r...

From #5915-40:
>The problem is with @generate-pbe-key@, where @AES_CBC_256@ is used for this key (32 length). There... Constantin Asofiei

01:45 PM Bug #6399: ENCRYPT/DECRYPT built-in function results different than 4GL when IV is shorter than r...

I have read some existing tests under @testcases/security/security_policy@ and I tried to understand them. I tried ma... Theodoros Theodorou

09:28 AM Feature #6820: reduce String.toLowerCase and toUpperCase usage and String instances

Hynek Cihlar wrote:
> And some cleanup:
Great, I'll test this and include it in my larger changes. Constantin Asofiei

09:12 AM Feature #6820: reduce String.toLowerCase and toUpperCase usage and String instances

And some cleanup:... Hynek Cihlar

09:09 AM Feature #6820: reduce String.toLowerCase and toUpperCase usage and String instances

Constantin Asofiei wrote:
> Hynek, what times do you get for @StringHelper.hashCodeCaseInsensitive@ test? Please te... Hynek Cihlar

08:52 AM Feature #6820: reduce String.toLowerCase and toUpperCase usage and String instances

Hynek, what times do you get for @StringHelper.hashCodeCaseInsensitive@ test? Please test what happens if you use so... Constantin Asofiei

08:42 AM Feature #6819: refactor FWD proxy implementation to use ReflectASM instead of Java Method reflection

Greg Shah wrote:
> How many JMX instrumentation locations are there? I'd like to run some non-trivial application c... Constantin Asofiei

08:39 AM Feature #6819: refactor FWD proxy implementation to use ReflectASM instead of Java Method reflection

Try attached testcase in command-line. On devsrv01, the times are these:... Constantin Asofiei

08:17 AM Feature #6819: refactor FWD proxy implementation to use ReflectASM instead of Java Method reflection

How many JMX instrumentation locations are there? I'd like to run some non-trivial application code with and without... Greg Shah

08:06 AM Feature #6819: refactor FWD proxy implementation to use ReflectASM instead of Java Method reflection

Greg Shah wrote:
> > I think we need to add a JVM flag to enable or disable the JMX code, so for production mode it ... Constantin Asofiei

08:04 AM Feature #6819: refactor FWD proxy implementation to use ReflectASM instead of Java Method reflection

> I think we need to add a JVM flag to enable or disable the JMX code, so for production mode it will go via the dire... Greg Shah

02/12/2023

03:14 AM Feature #6819: refactor FWD proxy implementation to use ReflectASM instead of Java Method reflection

I've did more testing and profiling of lambda calls. Even a simple lambda call as we have in @ContextLocal.get(boole... Constantin Asofiei

02/10/2023

12:54 PM Feature #4065: server-side processing of client platform dependencies

> With respect to the anticipated use cases does it make sense to replace these with the managed file system resource... Greg Shah

11:39 AM Feature #4065: server-side processing of client platform dependencies

Greg, I found several places in the client UI where file IO is performed directly. An example is a button widget load... Hynek Cihlar

02/09/2023

01:49 PM Feature #4065: server-side processing of client platform dependencies

Hynek Cihlar wrote:
> Greg, do we want to interpolate the file paths with a set of known variables? Like logged in u... Greg Shah

01:06 PM Feature #4065: server-side processing of client platform dependencies

Greg, do we want to interpolate the file paths with a set of known variables? Like logged in user, application name, ... Hynek Cihlar

11:19 AM Feature #4065: server-side processing of client platform dependencies

Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > I created task branch 4065a based on trunk revision 14477.
> F... Hynek Cihlar

11:16 AM Feature #4065: server-side processing of client platform dependencies

Hynek Cihlar wrote:
> I created task branch 4065a based on trunk revision 14477.
FYI, trunk is on rev 14483. Constantin Asofiei

10:20 AM Feature #4065: server-side processing of client platform dependencies

> > > Should we pursue some kind of EXECUTE permissions on the OS-COMMAND statement?
> >
> > It is a really good i... Greg Shah

10:11 AM Feature #4065: server-side processing of client platform dependencies

Greg Shah wrote:
> > Should we pursue some kind of EXECUTE permissions on the OS-COMMAND statement?
>
> It is a r... Hynek Cihlar

09:49 AM Feature #4065: server-side processing of client platform dependencies

I think you can add this @EXECUTE@ extra bit into the @BitFlagsResource@ directory. Greg Shah

09:48 AM Feature #4065: server-side processing of client platform dependencies

> Except I think we should implicitly deny access when no permission rule is matched.
Agreed. We always should a... Greg Shah

08:55 AM Feature #4065: server-side processing of client platform dependencies

Hynek Cihlar wrote:
> Also we should introduce the EXECUTE permission.
I will rephrase this to a question. Shoul... Hynek Cihlar

08:49 AM Feature #4065: server-side processing of client platform dependencies

Greg Shah wrote:
> > The actual file-system security model will be based on the Linux file-system security model.
>... Hynek Cihlar

08:32 AM Feature #4065: server-side processing of client platform dependencies

> Current FWD security model doesn't have primitives for file-system resources, this will have to be extended.
> The... Greg Shah

08:04 AM Feature #4065: server-side processing of client platform dependencies

I created task branch 4065a based on trunk revision 14477. Hynek Cihlar

07:34 AM Feature #4065: server-side processing of client platform dependencies

I'm currently working on the file-system server-side processing. Here are a few notables:
* Current FWD security m... Hynek Cihlar

09:55 AM Feature #6421 (Feedback): finish GENERATE-RANDOM-KEY support

Theodoros Theodorou

04:01 AM Feature #6421: finish GENERATE-RANDOM-KEY support

> Did you add the unknown value test code?
I added this:... Theodoros Theodorou

09:54 AM Bug #6399 (WIP): ENCRYPT/DECRYPT built-in function results different than 4GL when IV is shorter ...

Theodoros Theodorou