Activity
From 02/24/2023 to 03/25/2023
03/25/2023
- 08:53 AM Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type
- Fixed source validation for READ-JSON to work with MEMPTR, LONGCHAR and FILE for TEMP-TABLE and rejects STREAM as a s...
- 03:43 AM Feature #6497: add equivalent support for the -T command line option
- In other words, @defaultFwdTempFolder@ needs to be used in both cases, implicit temp folder and explicit '-T' folder;...
- 03:21 AM Feature #6497: add equivalent support for the -T command line option
- Theodoros, this is the review for 6497a/14500:
* please add history entries and javadoc for all new methods or param...
03/24/2023
- 03:51 PM Feature #6497: add equivalent support for the -T command line option
- Kind reminder for a review
- 12:42 PM Bug #7202: 'accum' frame-level widget can have widget options
- 7199a was merged to trunk rev 14514 and archived.
- 12:42 PM Bug #7203: INIT clause for datetime var copied from 'like' phrase
- 7199a was merged to trunk rev 14514 and archived.
- 12:42 PM Bug #7204: method overload with dataset/temp-table parameters uses the index at the parameter sig...
- 7199a was merged to trunk rev 14514 and archived.
- 12:42 PM Bug #7206: shared frame defined with the same name but different widgets
- 7199a was merged to trunk rev 14514 and archived.
- 12:42 PM Bug #7215: 'display v @ ch' - v gets added to the ch's frame
- 7199a was merged to trunk rev 14514 and archived.
- 10:19 AM Feature #4382: implement configurable directory override for PROGRESS global variable
- 4382a was merged to trunk as revision 14510. It was archived.
- 06:44 AM Feature #4382: implement configurable directory override for PROGRESS global variable
- 4382a has been rebased to trunk 14509
- 10:00 AM Feature #6421: finish GENERATE-RANDOM-KEY support
- 6421a was merged to trunk as revision 14509. It was archived.
03/23/2023
- 02:22 PM Feature #6421: finish GENERATE-RANDOM-KEY support
- Thanks, go ahead with merging 6421a to trunk. Please follow the merge steps in #7027-48
- 02:18 PM Feature #6421: finish GENERATE-RANDOM-KEY support
- Done
- 01:59 PM Feature #6421: finish GENERATE-RANDOM-KEY support
- Igor Skornyakov wrote:
> Constantin Asofiei wrote:
> > SecurityOps is missing a history number, like this:
> > [..... - 01:58 PM Feature #6421: finish GENERATE-RANDOM-KEY support
- Constantin Asofiei wrote:
> SecurityOps is missing a history number, like this:
> [...]
I do believe that saying... - 01:53 PM Feature #6421: finish GENERATE-RANDOM-KEY support
- SecurityOps is missing a history number, like this:...
- 01:49 PM Feature #6421: finish GENERATE-RANDOM-KEY support
- 6421a has been rebased to trunk 14508
- 12:42 PM Feature #6421 (Review): finish GENERATE-RANDOM-KEY support
- I've uncommitted rev 14509 from trunk. Let's follow the normal process.
- 12:39 PM Feature #6421: finish GENERATE-RANDOM-KEY support
- I noticed that in my branch 6421a I have accidentally pushed changes from another task and, therefore I recreated the...
03/22/2023
- 11:01 AM Feature #3853: implement LOG-MANAGER runtime
- Note: To check if entry types are case-sensitive in configs.
- 08:59 AM Bug #7204 (Test): method overload with dataset/temp-table parameters uses the index at the parame...
- 04:16 AM Bug #7204: method overload with dataset/temp-table parameters uses the index at the parameter sig...
- Greg Shah wrote:
> Code Review Task Branch 7199a Revision 14509
>
> In @schema.g@ line 1073, please change the na... - 08:58 AM Bug #7203 (Test): INIT clause for datetime var copied from 'like' phrase
- 04:13 AM Bug #7203: INIT clause for datetime var copied from 'like' phrase
- Greg Shah wrote:
> Code Review Task Branch 7199a Revision 14508
>
> In @schema.g@, on line 1703, isn't @content.g... - 08:58 AM Bug #7202 (Test): 'accum' frame-level widget can have widget options
- 03:58 AM Bug #7202: 'accum' frame-level widget can have widget options
- Greg Shah wrote:
> In regard to the @accumulate.rules@ change, what is the @display count with frame f1.@ supposed t...
03/21/2023
- 07:21 PM Bug #7202: 'accum' frame-level widget can have widget options
- Code Review Task Branch 7199a Revision 14512
Overall I don't have an objection.
In regard to the @accumulate.... - 11:33 AM Bug #7202 (Review): 'accum' frame-level widget can have widget options
- This is fixed in 7199a rev 14512.
- 06:32 PM Bug #7206 (Test): shared frame defined with the same name but different widgets
- Code Review Task Branch 7199a Revision 14511
No objections. - 11:25 AM Bug #7206 (Review): shared frame defined with the same name but different widgets
- This is fixed in 7199a rev 14511.
- 03:46 PM Bug #7215 (Test): 'display v @ ch' - v gets added to the ch's frame
- 03:46 PM Bug #7215: 'display v @ ch' - v gets added to the ch's frame
- Code Review Task Branch 7199a Revision 14510
This one is tough to evaluate. On the surface, I want the added bypa... - 11:18 AM Bug #7215 (Review): 'display v @ ch' - v gets added to the ch's frame
- This is fixed in 7199a rev 14510.
- 03:29 PM Bug #7204: method overload with dataset/temp-table parameters uses the index at the parameter sig...
- Code Review Task Branch 7199a Revision 14509
In @schema.g@ line 1073, please change the name of @if@ to something ... - 11:10 AM Bug #7204 (Review): method overload with dataset/temp-table parameters uses the index at the para...
- This is fixed in 7199a rev 14509.
- 03:18 PM Bug #7203: INIT clause for datetime var copied from 'like' phrase
- Code Review Task Branch 7199a Revision 14508
In @schema.g@, on line 1703, isn't @content.getType() == STRING@ alwa... - 11:06 AM Bug #7203 (Review): INIT clause for datetime var copied from 'like' phrase
- This is fixed in 7199a/14508
- 11:43 AM Bug #7198: conversion of empty UPDATE/SET/PROMPT-FOR statements
- Greg Shah wrote:
> Do you want to put this into 7199a instead?
No.
> Should we set this to Review?
There is more ... - 11:36 AM Bug #7198: conversion of empty UPDATE/SET/PROMPT-FOR statements
- Do you want to put this into 7199a instead?
Should we set this to Review?
03/20/2023
- 03:03 PM Bug #7204: method overload with dataset/temp-table parameters uses the index at the parameter sig...
- Another issue is that the index name must be part of the signature.
- 08:20 AM Feature #6497: add equivalent support for the -T command line option
- Yes, it matches the 4GL behavior
- 06:50 AM Feature #6497: add equivalent support for the -T command line option
- Does it match the 4GL behavior?
Constantin: Please review. - 07:10 AM Feature #6425: SESSION handle features
- We are working on the initial creation of our CI/CD environment but it is going to take some weeks before it is in pl...
- 05:04 AM Bug #7215 (WIP): 'display v @ ch' - v gets added to the ch's frame
- In this testcase, 'v' gets added to frame f1, and @input v@ will resolve it from frame f1, instead of frame f2.
<pre... - 05:03 AM Bug #7215 (Closed): 'display v @ ch' - v gets added to the ch's frame
03/18/2023
03/17/2023
- 01:27 PM Bug #7206: shared frame defined with the same name but different widgets
- A recreated bug is this:
* first program defines a shared frame but it doesn't use it:... - 01:13 PM Bug #7206: shared frame defined with the same name but different widgets
- The example programs for this task are incorrect: they both give @This ** Shared frame f1 field v1 must first appear ...
- 10:39 AM Bug #7206 (WIP): shared frame defined with the same name but different widgets
- Greg Shah wrote:
> Is the issue that we need a 2nd frame or just that we are incorrectly using the frame?
I'm not s... - 09:14 AM Bug #7206: shared frame defined with the same name but different widgets
- Is the issue that we need a 2nd frame or just that we are incorrectly using the frame?
- 12:52 PM Feature #6425: SESSION handle features
- I am doing some modifications in the java method @message()@. Is there a way to check that I haven't broken anything?
- 05:35 AM Bug #7204 (WIP): method overload with dataset/temp-table parameters uses the index at the paramet...
- 05:34 AM Bug #7203 (WIP): INIT clause for datetime var copied from 'like' phrase
03/16/2023
- 07:00 AM Bug #7206: shared frame defined with the same name but different widgets
- You can have the same @f1@ shared frame defined in two programs, but with different widgets:
* program A:... - 06:59 AM Bug #7206 (Closed): shared frame defined with the same name but different widgets
- 06:24 AM Bug #7204: method overload with dataset/temp-table parameters uses the index at the parameter sig...
- This class defines two @m1@ methods, and a single @dataset@ parameter. The temp-tables are the same, except @tt1@ ha...
- 06:23 AM Bug #7204 (Closed): method overload with dataset/temp-table parameters uses the index at the para...
- 06:11 AM Bug #7203: INIT clause for datetime var copied from 'like' phrase
- This testcase shows two problems:...
- 06:09 AM Bug #7203 (Closed): INIT clause for datetime var copied from 'like' phrase
- 06:08 AM Bug #7202: 'accum' frame-level widget can have widget options
- This testcase shows that a 'accum' frame widget can have widget options:...
- 06:06 AM Bug #7202 (Closed): 'accum' frame-level widget can have widget options
- 02:07 AM Bug #7193 (WIP): READ-JSON is not supported for the "LONGCHAR" source type
- Created task branch 7193a from the trunk.
03/15/2023
- 01:38 PM Bug #7198: conversion of empty UPDATE/SET/PROMPT-FOR statements
- Greg Shah wrote:
> I thought we already handled this at one point.
I thought so, too, but the only thing I found wa... - 12:53 PM Bug #7198: conversion of empty UPDATE/SET/PROMPT-FOR statements
- I thought we already handled this at one point.
- 12:40 PM Bug #7198 (WIP): conversion of empty UPDATE/SET/PROMPT-FOR statements
- Created task branch 7198a from trunk rev 14506.
7198a/14507 fixes this for UPDATE/SET/PROMPT-FOR. We need to test... - 11:42 AM Bug #7198: conversion of empty UPDATE/SET/PROMPT-FOR statements
- Empty @UPDATE.@, @SET.@ or @PROMPT-FOR.@ statements seem to be a no-op in OE. FWD fails at conversion phase.
Test... - 11:39 AM Bug #7198 (Test): conversion of empty UPDATE/SET/PROMPT-FOR statements
- 01:32 PM Bug #7200: fix INIT and LABEL for LIKE defined fields or variables
- Testcases are checked into old testcases and attached.
Interestingly, the code using the fields as the "model" (@i... - 01:19 PM Bug #7200 (New): fix INIT and LABEL for LIKE defined fields or variables
- 12:52 PM Feature #6425: SESSION handle features
- Hmmm, it requires ChUI.
> I noticed that the progress developer studio (eclipse) opens a different window on the... - 11:32 AM Feature #6425: SESSION handle features
- I usually use the VM1. Today I used VM2 because the VM1 was occupied. I tried to run...
03/14/2023
- 04:52 PM Feature #6497 (Review): add equivalent support for the -T command line option
- I implemented the following functionality:
If a temp directory is is explicitly provided, then I check if it is in... - 09:52 AM Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type
- Greg Shah wrote:
> Then we must already have testcases that fail. Point us to the code that fails.
The attached ... - 09:36 AM Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type
- Igor Skornyakov wrote:
> Greg Shah wrote:
> > Are these testcases checked in to the [[p2j:Testcases]] project? (thi... - 09:35 AM Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type
- That is OK if they fail. We should fix this now.
- 09:35 AM Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type
- Greg Shah wrote:
> Are these testcases checked in to the [[p2j:Testcases]] project? (this is a question for both of ... - 09:30 AM Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type
- Greg Shah wrote:
> Are these testcases checked in to the [[p2j:Testcases]] project? (this is a question for both of ... - 09:26 AM Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type
- Are these testcases checked in to the [[p2j:Testcases]] project? (this is a question for both of you)
- 07:31 AM Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type
- Igor Skornyakov wrote:
> Actually READ-JSON is not supported for "file" source type as well.
> For TEMP-TABLE it ex... - 07:23 AM Bug #7193: READ-JSON is not supported for the "LONGCHAR" source type
- Actually READ-JSON is not supported for "file" source type as well.
For TEMP-TABLE it explicitly reports error 19079... - 07:04 AM Bug #7193 (Closed): READ-JSON is not supported for the "LONGCHAR" source type
03/13/2023
- 04:06 PM Feature #6497: add equivalent support for the -T command line option
- > Also, when @-T@ is set, there must be a check if this folder really exists - if it doesn't exist, log a message and...
- 03:37 PM Feature #6497: add equivalent support for the -T command line option
- ...
- 08:47 AM Feature #6497: add equivalent support for the -T command line option
- > Greg, another idea: we automatically create this root folder if it doesn't exist. Also, permissions should be chec...
03/10/2023
- 12:00 PM Feature #6497: add equivalent support for the -T command line option
- Constantin Asofiei wrote:
> Also, when @-T@ is set, there must be a check if this folder really exists - if it doesn... - 11:57 AM Feature #6497: add equivalent support for the -T command line option
- Regarding where to save this @-T@ option - @Utils$WorkArea.explicitTempFolder@ should be OK (a better name can be used).
- 11:56 AM Feature #6497: add equivalent support for the -T command line option
- There are some issues here. The @-T@ option in FWD must specify the root folder where client-specific temp folders a...
- 11:51 AM Feature #6497: add equivalent support for the -T command line option
- I found this documentation page: https://proj.goldencode.com/projects/p2j/wiki/Bootstrap_Configuration
As I unders...
03/09/2023
- 08:43 AM Bug #7184: Incorrect conversion of concatenated string literals to a LONGCHAR
- The code:...
- 08:42 AM Bug #7184 (Closed): Incorrect conversion of concatenated string literals to a LONGCHAR
- 07:52 AM Feature #6425 (WIP): SESSION handle features
- The customer reports that:
* The idea is that this method will return the current text in the message area. They ... - 03:29 AM Feature #6425: SESSION handle features
- Great, thanks :)
03/08/2023
- 04:30 PM Feature #6425: SESSION handle features
- I'll ask the customer if they can provide details of what it should do or how to write code to see it in action.
- 04:21 PM Feature #6425: SESSION handle features
- Yes, @MESSAGE-AREA-MSG()@ always returns an empty string.
@security-policy:symmetric-encryption-algorithm@ is a ra... - 09:20 AM Feature #6425: SESSION handle features
- I suggest that you should not use the @MESSAGE@ statement while also testing @MESSAGE-AREA-MSG()@. What is returned ...
- 09:13 AM Feature #6425: SESSION handle features
- I tried many combinations like the following without any result....
- 04:08 AM Feature #4382: implement configurable directory override for PROGRESS global variable
- Done
03/07/2023
- 02:23 PM Feature #4382: implement configurable directory override for PROGRESS global variable
- Greg Shah wrote:
> > the path being used is @legacy-system/progress@. Greg, I think we need a @legacy-variables/pro... - 02:09 PM Feature #4382: implement configurable directory override for PROGRESS global variable
- > the path being used is @legacy-system/progress@. Greg, I think we need a @legacy-variables/progress@, as this is n...
- 01:31 PM Feature #4382: implement configurable directory override for PROGRESS global variable
- Review for 4382a/14498:
* the path being used is @legacy-system/progress@. Greg, I think we need a @legacy-variable... - 12:55 PM Feature #4382: implement configurable directory override for PROGRESS global variable
- I have recreated the branch 4382a and pushed the changes there
- 10:42 AM Feature #4382: implement configurable directory override for PROGRESS global variable
- Theodoros Theodorou wrote:
> Oh, my bad. I created the branch 4382a and my intention was to push the changes there, ... - 08:23 AM Feature #4382: implement configurable directory override for PROGRESS global variable
- I just uncommitted the change from trunk.
We will go through our normal review and testing process. - 08:21 AM Feature #4382: implement configurable directory override for PROGRESS global variable
- Oh, my bad. I created the branch 4382a and my intention was to push the changes there, not in the trunk. The changes ...
- 08:10 AM Feature #4382: implement configurable directory override for PROGRESS global variable
- Greg, FWD trunk has a commit for #4382:...
- 07:13 AM Feature #4382: implement configurable directory override for PROGRESS global variable
- Yes, the branch is 4382a. Should I mention it here when I create a branch?
- 01:08 PM Feature #6497 (WIP): add equivalent support for the -T command line option
- 08:29 AM Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
- Greg Shah wrote:
> > But, I don't like changing the semantics of @returnNormal@, depending from where it is being ca... - 08:17 AM Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
- > But, I don't like changing the semantics of @returnNormal@, depending from where it is being called - as this can b...
- 04:14 AM Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
- In #7142, we found that @p2j.oo@ code still relies on @returnNormal@ to throw a @ReturnUnwindException@. A fix is in...
- 08:05 AM Bug #7176: cleanup p2j.oo code considering the #7045 and #7122
- With #7045, now @returnNormal@ will not throw a @ReturnUnwindException@ if it's being called from a function. In #71...
- 08:03 AM Bug #7176 (New): cleanup p2j.oo code considering the #7045 and #7122
- 04:51 AM Bug #7175 (Review): substitute: incorrect handling of unknown longchar values
- Committed as 3827a rev. 14502.
- 04:47 AM Bug #7175 (WIP): substitute: incorrect handling of unknown longchar values
- This patch fixes this issue:...
- 04:44 AM Bug #7175: substitute: incorrect handling of unknown longchar values
- An *unknown* @lonchar@ value passed as an formatting parameter for @substitute@ is formatted as @null@ instead of exp...
- 04:42 AM Bug #7175 (Closed): substitute: incorrect handling of unknown longchar values
03/06/2023
- 06:11 PM Feature #4382: implement configurable directory override for PROGRESS global variable
- Did you create a branch for the changes?
- 05:57 PM Feature #4382 (Review): implement configurable directory override for PROGRESS global variable
- 05:56 PM Feature #4382 (WIP): implement configurable directory override for PROGRESS global variable
- 11:40 AM Feature #6425: SESSION handle features
- Trial and error. I would guess that the integer arg is the message "line number" for which to get the current text. ...
- 11:26 AM Feature #6425: SESSION handle features
- You are right, it exists. I tried to run it with many arguments and examples and I found that it takes one integer ar...
- 08:18 AM Feature #6425: SESSION handle features
- > I tried on a customer AWS VM which has v11.7 and it throws an error. Also, the autocomplete does not show @MESSAGE-...
- 11:05 AM Bug #7135 (Closed): NPE in conversion of OO looking for oldtype annotation
- 10:46 AM Bug #7135 (Test): NPE in conversion of OO looking for oldtype annotation
- 7135a was merged to trunk as revision 14493. It was archived.
03/03/2023
- 11:27 AM Feature #6425 (Review): SESSION handle features
- Finished with the startup-parameters. The ticket is ready for review. I should also create a test, right?
- 07:00 AM Feature #6821: java collection performance
- Greg Shah wrote:
> > Ultimately, we could iterate the tables individually and process (delete/update then invalidate... - 02:54 AM Feature #4382: implement configurable directory override for PROGRESS global variable
- Theodoros, I think the path should be @runtime/{default|<server ID}@ - look how @widget-descriptors@ are loaded in @W...
- 02:49 AM Feature #4382: implement configurable directory override for PROGRESS global variable
- kind reminder
03/02/2023
- 04:35 PM Bug #7135: NPE in conversion of OO looking for oldtype annotation
- Not at this time.
- 04:34 PM Bug #7135: NPE in conversion of OO looking for oldtype annotation
- Roger Borrello wrote:
> 7135a has been rebased to trunk_14490.
If there are other customers that might have the s... - 03:45 PM Bug #7135: NPE in conversion of OO looking for oldtype annotation
- 7135a has been rebased to trunk_14490.
- 04:13 PM Feature #6425: SESSION handle features
- I tried on a customer AWS VM which has v11.7 and it throws an error. Also, the autocomplete does not show @MESSAGE-AR...
- 08:26 AM Feature #6425: SESSION handle features
- We believe it exists but it is undocumented. It is possible it only exists in some recent level of OE. Please check...
- 07:49 AM Feature #6425: SESSION handle features
- I think the @SESSION:MESSAGE-AREA-MSG@ does not exist. Can you please confirm?
03/01/2023
- 03:39 PM Bug #7135: NPE in conversion of OO looking for oldtype annotation
- Constantin Asofiei wrote:
> The patch is permanent.
Thanks... I will pursue the customer checking the patched ver... - 03:15 PM Bug #7135: NPE in conversion of OO looking for oldtype annotation
- Roger Borrello wrote:
> Opened task #7146 for the other runtime issue.
>
> Is the patching of the customer app pr... - 03:13 PM Bug #7135: NPE in conversion of OO looking for oldtype annotation
- Opened task #7146 for the other runtime issue.
Is the patching of the customer app procedures as noted in #7135-34... - 10:50 AM Feature #6425: SESSION handle features
- It doesn't matter.
- 10:26 AM Feature #6425: SESSION handle features
- The code @message session:local-version-info@ prints @Progress.Lang.OEVersionInfo...1000@ using FWD and @Progress.Lan...
02/27/2023
02/24/2023
- 12:52 PM Feature #4382: implement configurable directory override for PROGRESS global variable
- ...
- 10:43 AM Bug #7135 (Review): NPE in conversion of OO looking for oldtype annotation
- Opened task #7145 to handle the first of the runtime errors.
- 05:57 AM Bug #7135: NPE in conversion of OO looking for oldtype annotation
- Open bugs for these runtime issues. If conversion works now, we move on and close this task.
- 10:06 AM Feature #6819: refactor FWD proxy implementation to use ReflectASM instead of Java Method reflection
- Greg Shah wrote:
> > With this in mind, I think it shouldn't take too long to change the invocation handler to recei... - 10:03 AM Feature #6819: refactor FWD proxy implementation to use ReflectASM instead of Java Method reflection
- > With this in mind, I think it shouldn't take too long to change the invocation handler to receive the info for Refl...
- 06:30 AM Feature #6819: refactor FWD proxy implementation to use ReflectASM instead of Java Method reflection
- I've changed the original #6819-3 test so that a new @Object[]@ (for the varargs) is not created on each call (so a s...
- 07:11 AM Feature #6821: java collection performance
- Constantin Asofiei wrote:
> Yes, this was from profiling a customer's application.
Great. Review complete, approved.
- 07:10 AM Feature #6821: java collection performance
- Tijs Wickardt wrote:
> Did you profile this? (I see #6821-55 but it seems high level).
Yes, this was from profiling... - 07:09 AM Feature #6821: java collection performance
- Constantin Asofiei wrote:
> The overhead is seen when this code is executed millions of times - I agree that using a... - 07:04 AM Feature #6821: java collection performance
- Tijs Wickardt wrote:
> Reviewed @p2j 7026a -r14497..14499@ .
> The changes are good.
> Remark on @Avoid the overhe... - 07:01 AM Feature #6821 (WIP): java collection performance
- 07:00 AM Feature #6821: java collection performance
- Reviewed @p2j 7026a -r14497..14499@ .
The changes are good.
Remark on @Avoid the overhead of calculating an empty m... - 05:03 AM Feature #6821 (Review): java collection performance
- Reviewing.
- 04:30 AM Feature #6410: implement additional built-in OO classes/interfaces
- Greg Shah wrote:
> 6129b which is now in trunk revision 14484 does have all my previous work on method overloading. ...
Also available in: Atom