Project

General

Profile

Activity

From 06/19/2023 to 07/18/2023

07/18/2023

02:23 PM Bug #7299: resolution of the target OO method in chained calls with poly arguments
I was thinking that instead of wrapping the POLY expr in a constructor with the expected type, emit a @Parameter.forT... Constantin Asofiei
01:19 PM Bug #7299: resolution of the target OO method in chained calls with poly arguments
The most important part missing in FWD I think is this: at compile time, OpenEdge hard-links the call to invoke the e... Constantin Asofiei
01:17 PM Bug #7299: resolution of the target OO method in chained calls with poly arguments
Constantin Asofiei wrote:
> Marian Edu wrote:
> > Constantin Asofiei wrote:
> > >Please run the test in #7299-30 i...
Constantin Asofiei
01:17 PM Bug #7299: resolution of the target OO method in chained calls with poly arguments
Marian Edu wrote:
> Constantin Asofiei wrote:
> >Please run the test in #7299-30 in your OpenEdge and let me know i...
Constantin Asofiei
01:15 PM Bug #7299: resolution of the target OO method in chained calls with poly arguments
Constantin Asofiei wrote:
>Please run the test in #7299-30 in your OpenEdge and let me know if you see the same erro...
Marian Edu
12:11 PM Bug #7299: resolution of the target OO method in chained calls with poly arguments
Marian Edu wrote:
> It might run fine but it's still wrong, this should not happen - the copile time resolution shou...
Constantin Asofiei
12:08 PM Bug #7299: resolution of the target OO method in chained calls with poly arguments
Constantin Asofiei wrote:
> I'm running with 11.6.3.
Sadly the oldest we have available is @11.7@ and that will pro...
Marian Edu
11:59 AM Bug #7299: resolution of the target OO method in chained calls with poly arguments
Marian Edu wrote:
> Constantin Asofiei wrote:
> > Please run this on your side:
> Not sure, we have the @CTest@ in...
Constantin Asofiei
11:46 AM Bug #7299: resolution of the target OO method in chained calls with poly arguments
Constantin Asofiei wrote:
> Please run this on your side:
Not sure, we have the @CTest@ in @tests.oo.support@ so ha...
Marian Edu
11:38 AM Bug #7299: resolution of the target OO method in chained calls with poly arguments
Please run this on your side:... Constantin Asofiei
11:26 AM Bug #7299: resolution of the target OO method in chained calls with poly arguments
Constantin Asofiei wrote:
> Marian, there is something wrong with the @TestLastMethodReturnTypeChainedCall.testLastO...
Marian Edu
09:29 AM Bug #7299: resolution of the target OO method in chained calls with poly arguments
Marian, there is something wrong with the @TestLastMethodReturnTypeChainedCall.testLastOverloadHasDifferentReturnType... Constantin Asofiei
07:51 AM Bug #7299: resolution of the target OO method in chained calls with poly arguments
Constantin Asofiei wrote:
> -Created task branch 7229b from trunk rev 14661.-
This branch was physically removed, 7...
Constantin Asofiei
05:18 AM Bug #7299 (WIP): resolution of the target OO method in chained calls with poly arguments
-Created task branch 7229b from trunk rev 14661.- Constantin Asofiei
11:47 AM Feature #6410: implement additional built-in OO classes/interfaces
Constantin Asofiei wrote:
> Marian Edu wrote:
> > Constantin Asofiei wrote:
> > > The problem here is that @Legacy...
Marian Edu
11:40 AM Feature #6410: implement additional built-in OO classes/interfaces
Marian Edu wrote:
> Constantin Asofiei wrote:
> > The problem here is that @LegacyClass.invoke@ resolves the target...
Constantin Asofiei
11:33 AM Feature #6410: implement additional built-in OO classes/interfaces
Constantin Asofiei wrote:
> The problem here is that @LegacyClass.invoke@ resolves the target at each invocation, de...
Marian Edu
09:14 AM Feature #6410: implement additional built-in OO classes/interfaces
Marian Edu wrote:
> One question here, I'm looking at the 'invoke' method and that was implemented straight into the...
Constantin Asofiei
09:07 AM Feature #6410: implement additional built-in OO classes/interfaces
One question here, I'm looking at the 'invoke' method and that was implemented straight into the class (LegacyClass) ... Marian Edu
07:48 AM Feature #4855 (Closed): add a 4GL extension SESSION:SESSION-ID attribute which returns a UUID whi...
Greg Shah
12:57 AM Feature #4855 (Test): add a 4GL extension SESSION:SESSION-ID attribute which returns a UUID which...
Task branch 4855a was merged to trunk as rev 14661 and archived. Email sent. Galya B

07/17/2023

03:43 PM Feature #4855: add a 4GL extension SESSION:SESSION-ID attribute which returns a UUID which unique...
You can rebase and merge 4855a to trunk. Greg Shah

07/14/2023

05:25 PM Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
Constantin Asofiei wrote:
> From a large app, NEXT is being called some ~2000 times and LEAVE some ~1000 times. In ...
Greg Shah
02:30 PM Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
From a large app, NEXT is being called some ~2000 times and LEAVE some ~1000 times. In contrast, there are ~20k of @... Constantin Asofiei
01:54 PM Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
Although there is some "low hanging fruit" left to pick, when we consider how expensive it is to use Java exceptions ... Greg Shah
02:17 AM Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
From a large customer application, there are these numbers for a RETURN:
* from within @p2j.oo@ code, which forces a...
Constantin Asofiei

07/13/2023

11:56 AM Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
There is another case which needs to convert to @storeReturnValue@:... Constantin Asofiei

07/12/2023

08:55 AM Feature #6410: implement additional built-in OO classes/interfaces
Constantin Asofiei wrote:
> I think that was meant to be @getQualifiedJavaName@, not @getQualifiedName@.
That did...
Marian Edu
07:48 AM Feature #6410: implement additional built-in OO classes/interfaces
I think that was meant to be @getQualifiedJavaName@, not @getQualifiedName@. Constantin Asofiei
07:41 AM Feature #6410 (WIP): implement additional built-in OO classes/interfaces
Working on implementation of reflection for supporting class's methods, having issues converting some of the test cas... Marian Edu

07/11/2023

01:28 PM Bug #7484 (Test): decimal format - left-side 'balance' must include group separators
Greg Shah
11:59 AM Bug #7484: decimal format - left-side 'balance' must include group separators
7484a was merged to trunk rev 14650 and archived. Constantin Asofiei
11:51 AM Bug #7484: decimal format - left-side 'balance' must include group separators
Go ahead with merge. Greg Shah
07:48 AM Feature #6425: SESSION handle features
The exact implementation of these may not be possible in FWD since we have a different architecture. Each one must b... Greg Shah
07:37 AM Feature #6425: SESSION handle features
From Theodoros in #4938-226:
> I was not able to find the meaning of:
>
> ubpid
> logname
> asid
> ubpropfile...
Greg Shah
07:45 AM Bug #7299: resolution of the target OO method in chained calls with poly arguments
Greg Shah wrote:
> > those tests were not refactored as ABLUnit as far as I can see as it looks those were added aft...
Marian Edu

07/10/2023

03:24 PM Feature #6497: add equivalent support for the -T command line option
The code review for these changes (in branch 4938b) can be seen in #4938-225. Greg Shah
03:24 PM Feature #4391: enhance existing SESSION:STARTUP-PARAMETERS support to honor -H -db -S -ld -N values
The code review for these changes (in branch 4938b) can be seen in #4938-225. Greg Shah
03:24 PM Feature #6425: SESSION handle features
The code review for these changes (in branch 4938b) can be seen in #4938-225. Greg Shah
07:14 AM Bug #7299: resolution of the target OO method in chained calls with poly arguments
> those tests were not refactored as ABLUnit as far as I can see as it looks those were added after we've started the... Greg Shah
07:00 AM Bug #7299: resolution of the target OO method in chained calls with poly arguments
Greg Shah wrote:
> > > > Marian: Please have your team review the documentation on method overloading in #3751-492 a...
Marian Edu

07/07/2023

03:47 PM Bug #7484: decimal format - left-side 'balance' must include group separators
Code Review Task Branch 7484a Revision 14649
No objections.
Greg Shah
03:09 PM Bug #7484 (Review): decimal format - left-side 'balance' must include group separators
Created task branch 7484a from trunk rev 14648. The fix is in rev 14649. Constantin Asofiei
02:45 PM Bug #7484: decimal format - left-side 'balance' must include group separators
OK, go ahead with the change. Greg Shah
02:43 PM Bug #7484: decimal format - left-side 'balance' must include group separators
Greg Shah wrote:
> > > What happens in the case where there is a mixture of @>@ and other digit types (@9@, @z@, @Z@...
Constantin Asofiei
02:37 PM Bug #7484: decimal format - left-side 'balance' must include group separators
> > What happens in the case where there is a mixture of @>@ and other digit types (@9@, @z@, @Z@, @*@)?
> Only the ...
Greg Shah
02:35 PM Bug #7484: decimal format - left-side 'balance' must include group separators
Greg Shah wrote:
> Is the problem that an error 22 is raised in FWD but not in OE?
Correct.
> What happens in th...
Constantin Asofiei
01:52 PM Bug #7484: decimal format - left-side 'balance' must include group separators
Is the problem that an error 22 is raised in FWD but not in OE?
What happens in the case where there is a mixture ...
Greg Shah
02:52 PM Feature #4855: add a 4GL extension SESSION:SESSION-ID attribute which returns a UUID which unique...
We are trying to avoid conversion changes in trunk for a short time, so we may not merge this until later next week. Greg Shah
02:52 PM Feature #4855: add a 4GL extension SESSION:SESSION-ID attribute which returns a UUID which unique...
Code Review Task Branch 4855a Revision 14634
No objections.
Greg Shah
11:41 AM Bug #7299: resolution of the target OO method in chained calls with poly arguments
> > > Marian: Please have your team review the documentation on method overloading in #3751-492 and look at the code ... Greg Shah

07/06/2023

05:30 AM Feature #6410: implement additional built-in OO classes/interfaces
Did reverted back to use BDT instead of Object for `invoke` method, some fixes for `setParameter` in `ParameterList` ... Marian Edu
04:14 AM Feature #6410: implement additional built-in OO classes/interfaces
Constantin Asofiei wrote:
> Marian, please upload a skeleton patch using the latest skeleton project from xfer (rev ...
Marian Edu

07/05/2023

01:11 PM Bug #7484: decimal format - left-side 'balance' must include group separators
This format is valid in OE: @->,>>>,>>9.9<<<<<<<<@.
We have logic in @NumberType.parseFormat@ which computes a @le...
Constantin Asofiei
01:08 PM Bug #7484 (Test): decimal format - left-side 'balance' must include group separators
Constantin Asofiei

07/04/2023

07:13 PM Feature #4391 (Review): enhance existing SESSION:STARTUP-PARAMETERS support to honor -H -db -S -l...
Theodoros Theodorou
07:13 PM Feature #4391 (WIP): enhance existing SESSION:STARTUP-PARAMETERS support to honor -H -db -S -ld -...
Theodoros Theodorou
07:12 PM Feature #6425 (Review): SESSION handle features
Theodoros Theodorou

07/03/2023

01:44 PM Feature #3868 (Test): customer servlet integration/support
The fix is committed to trunk rev 14637 via 7426a.
Any customer application using a jasper version other than FWD'...
Constantin Asofiei
07:10 AM Bug #7299: resolution of the target OO method in chained calls with poly arguments
The same rules used at the conversion to determine the target for a direct call needs to be implemented in @ControlFl... Constantin Asofiei

06/30/2023

11:08 AM Bug #7460: implement Progress.Lang.Class:getMethods
What is the effort to implement this?
I would expect it to go into branch 6410a.
Greg Shah

06/29/2023

05:36 AM Feature #4855 (Review): add a 4GL extension SESSION:SESSION-ID attribute which returns a UUID whi...
4855a r14634 for review Galya B

06/28/2023

10:57 AM Feature #4855: add a 4GL extension SESSION:SESSION-ID attribute which returns a UUID which unique...
In this case, since we already have a keyword and we even have an attribute with that name, there are no changes need... Greg Shah
09:44 AM Feature #4855: add a 4GL extension SESSION:SESSION-ID attribute which returns a UUID which unique...
I want to know what I'm doing, but I don't. Galya B
09:42 AM Feature #4855: add a 4GL extension SESSION:SESSION-ID attribute which returns a UUID which unique...
> I was going with a similar, but not exactly the same keyword, so I'll stick with it.
I don't want to add a keywo...
Greg Shah
09:37 AM Feature #4855: add a 4GL extension SESSION:SESSION-ID attribute which returns a UUID which unique...
I was going with a similar, but not exactly the same keyword, so I'll stick with it. Galya B
09:36 AM Feature #4855: add a 4GL extension SESSION:SESSION-ID attribute which returns a UUID which unique...
If we reuse this keyword, @SESSION-ID@ will need to be extracted to its own interface, specific @handle.unwrap@ added... Constantin Asofiei
09:35 AM Feature #4855: add a 4GL extension SESSION:SESSION-ID attribute which returns a UUID which unique...
I expect we would use the same keyword. There is nothing wrong with that. Greg Shah
09:34 AM Feature #4855: add a 4GL extension SESSION:SESSION-ID attribute which returns a UUID which unique...
Ok, thanks for the explanations, it's just that the new keyword will be quite similar to the old one. Galya B
09:33 AM Feature #4855: add a 4GL extension SESSION:SESSION-ID attribute which returns a UUID which unique...
The @client-principal@ is a kind of 4GL based security-related token that identifies an authenticated identity. It i... Greg Shah
09:33 AM Feature #4855: add a 4GL extension SESSION:SESSION-ID attribute which returns a UUID which unique...
Galya B wrote:
> What is @client-principal:session-id@ https://docs.progress.com/bundle/abl-reference/page/SESSION-I...
Constantin Asofiei
09:06 AM Feature #4855: add a 4GL extension SESSION:SESSION-ID attribute which returns a UUID which unique...
What is @client-principal:session-id@ https://docs.progress.com/bundle/abl-reference/page/SESSION-ID-attribute.html#S... Galya B

06/27/2023

10:26 AM Feature #4855 (WIP): add a 4GL extension SESSION:SESSION-ID attribute which returns a UUID which ...
Branch 4855a created. Galya B
10:23 AM Feature #4855: add a 4GL extension SESSION:SESSION-ID attribute which returns a UUID which unique...
> the unique conversation (with standalone gui/chui/batch processes);
Yes
> the unique connection to appserver ...
Greg Shah
10:18 AM Feature #4855: add a 4GL extension SESSION:SESSION-ID attribute which returns a UUID which unique...
OK, leaving @BaseSession@ aside. A session from 4GL perspective should be:
* the unique conversation (with standalon...
Galya B
10:17 AM Feature #4855: add a 4GL extension SESSION:SESSION-ID attribute which returns a UUID which unique...
> I'm just trying to figure out if there is any case where the id should be stable in different @BaseSession@ objects... Greg Shah
10:12 AM Feature #4855: add a 4GL extension SESSION:SESSION-ID attribute which returns a UUID which unique...
You can have a virtual session while in an active direct session. You cannot have a virtual session on its own, the ... Greg Shah
10:10 AM Feature #4855: add a 4GL extension SESSION:SESSION-ID attribute which returns a UUID which unique...
Actually obviously that's how appserver works. I'm just trying to figure out if there is any case where the id should... Galya B
10:08 AM Feature #4855: add a 4GL extension SESSION:SESSION-ID attribute which returns a UUID which unique...
Can we have multiple "connection" sessions (@DirectSession@ / @VirtualSession@) for one client (not necessarily simul... Galya B
08:51 AM Feature #4855: add a 4GL extension SESSION:SESSION-ID attribute which returns a UUID which unique...
Maybe, but it isn't hard to implement the cleanup of a record using Java code. The initial insertion can be done in ... Greg Shah
08:27 AM Feature #4855: add a 4GL extension SESSION:SESSION-ID attribute which returns a UUID which unique...
The hook seem to be in Java, while the customers want to implement it in 4GL. I think they will come back to us to as... Galya B
08:16 AM Feature #4855: add a 4GL extension SESSION:SESSION-ID attribute which returns a UUID which unique...
I expect that the customer will likely implement their own "licenses in use" table (see #4522) in which one field wil... Greg Shah
07:40 AM Feature #4855: add a 4GL extension SESSION:SESSION-ID attribute which returns a UUID which unique...
How will customers know when older sessions have been ended when implementing licensing rules?
Galya B
09:18 AM Feature #6410: implement additional built-in OO classes/interfaces
We've discussed this POLY issue with extent in #5729. But I can't find if we made a dedicated task for making POLY w... Constantin Asofiei
08:53 AM Feature #6410: implement additional built-in OO classes/interfaces
What do you suggest? Greg Shah
08:41 AM Feature #6410: implement additional built-in OO classes/interfaces
Greg, I've taken a look at 6410a, and the main issue is changing the return type for i.e. @LegacyClass.invoke@, from ... Constantin Asofiei
08:19 AM Feature #6410: implement additional built-in OO classes/interfaces
Marian, please upload a skeleton patch using the latest skeleton project from xfer (rev 116). Constantin Asofiei
07:47 AM Feature #6410: implement additional built-in OO classes/interfaces
Constantin: Have you reviewed 6410a? I'd like to get it into trunk.
Marian: We urgently need the runtime for @Pro...
Greg Shah
09:00 AM Bug #7272 (Closed): RUN ... NO-ERROR must log the 'missing.p was not found' message, always.
Greg Shah

06/26/2023

02:08 PM Feature #6497: add equivalent support for the -T command line option
Please merge 6497a into 4938a. Add/rework support for @-T@ to the @STARTUP-PARAMETERS@. Greg Shah
02:04 PM Feature #6425: SESSION handle features
Did you have a branch 6425a? It is not listed in this task, so it is not clear. I know you have changes. Please me... Greg Shah
02:02 PM Feature #4391: enhance existing SESSION:STARTUP-PARAMETERS support to honor -H -db -S -ld -N values
Please use branch 4938a. Greg Shah
01:25 PM Feature #3853: implement LOG-MANAGER runtime
@QUERY:BASIC-LOGGING@ is already listed in #3853-1. Whether we implement a new set of logging instrumentation for it... Greg Shah
12:02 PM Feature #3853: implement LOG-MANAGER runtime
Greg Shah wrote:
> Galya B wrote:
> > Note: This task should include proper implementation of @basic-logging@ that ...
Galya B
11:25 AM Feature #3853: implement LOG-MANAGER runtime
Galya B wrote:
> Note: This task should include proper implementation of @basic-logging@ that is already supported i...
Greg Shah
11:03 AM Feature #3853: implement LOG-MANAGER runtime
Note: This task should include proper implementation of @basic-logging@ that is already supported in the 4GL syntax. Galya B

06/23/2023

02:37 AM Feature #6410: implement additional built-in OO classes/interfaces
Constantin Asofiei wrote:
> Marian Edu wrote:
> > > Also, 6410a branch is on xfer - do you still have problems usin...
Marian Edu

06/22/2023

03:44 PM Bug #7460: implement Progress.Lang.Class:getMethods
For this task, the priority is the runtime for @progress.lang.class:getMethods@. For current customers, we already h... Constantin Asofiei
03:42 PM Bug #7460: implement Progress.Lang.Class:getMethods
That is a big reason we really need to get 6410a merged into trunk. It at least provides conversion support for all ... Greg Shah
03:35 PM Bug #7460: implement Progress.Lang.Class:getMethods
Marian, can this be implemented 'standalone', without additional APIs from @progress.lang.classs@ (or others)? Constantin Asofiei
03:34 PM Bug #7460: implement Progress.Lang.Class:getMethods
> Greg: is progress.lang.class supposed to be fully implemented in some other task?
Yes, in #6410.
Greg Shah
09:57 AM Bug #7460: implement Progress.Lang.Class:getMethods
A customer project uses @progress.lang.class:getMethods@. We need to implement this.
Greg: is progress.lang.class...
Constantin Asofiei
09:56 AM Bug #7460 (Merge Pending): implement Progress.Lang.Class:getMethods
Constantin Asofiei
 

Also available in: Atom