Activity

From 05/20/2023 to 06/18/2023

06/16/2023

07:16 AM Bug #7438: the label in the UNDO <lbl>, THROW is not validated or used in 4GL: Committed to 7300a rev 14626. ... Constantin Asofiei

06/15/2023

04:13 PM Bug #7438: the label in the UNDO <lbl>, THROW is not validated or used in 4GL: I'm OK with the approach. Go ahead and apply it. Greg Shah
12:50 PM Bug #7438: the label in the UNDO <lbl>, THROW is not validated or used in 4GL: The patch above does not drop the label, but instead 'forces it' even if it can't be resolved, to preserve the AST st... Constantin Asofiei
10:33 AM Bug #7438 (Review): the label in the UNDO <lbl>, THROW is not validated or used in 4GL: This patch solves the issue; I don't see a more elegant solution.... Constantin Asofiei
09:29 AM Bug #7438: the label in the UNDO <lbl>, THROW is not validated or used in 4GL: Greg Shah wrote:
> The label never has meaning?
Correct - it has no meaning, either for the 4GL compiler or the 4GL... Constantin Asofiei
09:27 AM Bug #7438: the label in the UNDO <lbl>, THROW is not validated or used in 4GL: The label never has meaning? Greg Shah
09:23 AM Bug #7438: the label in the UNDO <lbl>, THROW is not validated or used in 4GL: Greg Shah wrote:
> > all behavior was the same in 4GL, until I tried with a 'bogus' label
>
> You mean this was t... Constantin Asofiei
09:15 AM Bug #7438: the label in the UNDO <lbl>, THROW is not validated or used in 4GL: > all behavior was the same in 4GL, until I tried with a 'bogus' label
You mean this was the case after your chang... Greg Shah
08:17 AM Bug #7438: the label in the UNDO <lbl>, THROW is not validated or used in 4GL: Greg Shah wrote:
> Is this really a parsing issue? Maybe @label_reference@ detects this as a @malformed_symbol@ but... Constantin Asofiei
08:10 AM Bug #7438: the label in the UNDO <lbl>, THROW is not validated or used in 4GL: Is this really a parsing issue? Maybe @label_reference@ detects this as a @malformed_symbol@ but it isn't clear that... Greg Shah

06/08/2023

02:11 PM Bug #7247: Dataset:READ-XML does nothing: Ovidiu Maxiniuc wrote:
> Igor,
> I have fixed some formatting issues and enhanced javadoc texts for some methods f... Igor Skornyakov
01:40 PM Bug #7247: Dataset:READ-XML does nothing: Igor,
I have fixed some formatting issues and enhanced javadoc texts for some methods for you in r14623. If you agr... Ovidiu Maxiniuc
06:37 AM Bug #7247: Dataset:READ-XML does nothing: Ovidiu: Is 7247a OK to merge? Greg Shah
05:05 AM Bug #7247: Dataset:READ-XML does nothing: Ovidiu Maxiniuc wrote:
> Review of 7247a/r14621.
>
> Fully unifying the de/serialization of XML and JSON is an am... Igor Skornyakov
09:31 PM Bug #7247: Dataset:READ-XML does nothing: Review of 7247a/r14621.
Fully unifying the de/serialization of XML and JSON is an ambitious task I think of for so... Ovidiu Maxiniuc
08:51 AM Feature #6420: implement the AUDIT-ENABLED() built-in function: The changes are in the p2j branch 6422a Theodoros Theodorou
08:50 AM Feature #6420 (Review): implement the AUDIT-ENABLED() built-in function: Theodoros Theodorou

06/07/2023

06:01 PM Feature #6422: implement auditing support including AUDIT-POLICY and AUDIT-CONTROL: * Added "Session.PK" and made sql string as private static.
* I also wasn't sure about this and I made an easy solut... Theodoros Theodorou
01:54 PM Bug #7247: Dataset:READ-XML does nothing: Ovidiu: Please review 7247a. Greg Shah

06/06/2023

07:57 AM Bug #7299: resolution of the target OO method in chained calls with poly arguments: Greg Shah wrote:
> > Marian: Please have your team review the documentation on method overloading in #3751-492 and l... Marian Edu

06/05/2023

03:18 PM Feature #6422: implement auditing support including AUDIT-POLICY and AUDIT-CONTROL: Code review 6422a/14552-14554:
I reviewed the code from the perspective of persistence and coding standards, but T... Eric Faulhaber
01:12 PM Bug #7299: resolution of the target OO method in chained calls with poly arguments: > Marian: Please have your team review the documentation on method overloading in #3751-492 and look at the code in @... Greg Shah
11:58 AM Bug #7299: resolution of the target OO method in chained calls with poly arguments: Rebased 7299a/14551 from trunk rev 14612 - new rev 14613.
7299a rev 14614 replaces upPath with the token list vers... Constantin Asofiei
10:32 AM Bug #7301 (Closed): pre-scan of a 'DEFINE BUFFER btt1 FOR btt1' from within a method: Greg Shah
10:30 AM Bug #7301: pre-scan of a 'DEFINE BUFFER btt1 FOR btt1' from within a method: 7199c was merged to trunk rev 14610 and archived Constantin Asofiei
10:32 AM Bug #7304 (Closed): UN_MINUS resolves to int64 instead of integer in ExpressionConversionWorker: Greg Shah
10:29 AM Bug #7304: UN_MINUS resolves to int64 instead of integer in ExpressionConversionWorker: 7199c was merged to trunk rev 14610 and archived Constantin Asofiei
10:31 AM Bug #7250 (Closed): PROMPT-FOR with a table field reference resolves to NO-REFERENCE in OpenEdge: Greg Shah
10:29 AM Bug #7250: PROMPT-FOR with a table field reference resolves to NO-REFERENCE in OpenEdge: 7199c was merged to trunk rev 14610 and archived Constantin Asofiei
10:31 AM Bug #7308 (Closed): 4GL does not validate the extent index in a 'DEF VAR ... LIKE v1[100]' case, ...: Greg Shah
10:29 AM Bug #7308: 4GL does not validate the extent index in a 'DEF VAR ... LIKE v1[100]' case, where v1 ...: 7199c was merged to trunk rev 14610 and archived Constantin Asofiei
10:31 AM Bug #7310 (Closed): buffer scope in constructor/destructor is not computed correctly: Greg Shah
10:29 AM Bug #7310: buffer scope in constructor/destructor is not computed correctly: 7199c was merged to trunk rev 14610 and archived Constantin Asofiei
10:31 AM Bug #7311 (Closed): abs(integer) must return int64: Greg Shah
10:29 AM Bug #7311: abs(integer) must return int64: 7199c was merged to trunk rev 14610 and archived Constantin Asofiei
10:31 AM Bug #7312 (Closed): mtime(character) is allowed in 4GL: Greg Shah
10:29 AM Bug #7312: mtime(character) is allowed in 4GL: 7199c was merged to trunk rev 14610 and archived Constantin Asofiei
10:30 AM Bug #7313 (Closed): regression in '<record-phrase> USING FRAME f field': Greg Shah
10:29 AM Bug #7313: regression in '<record-phrase> USING FRAME f field': 7199c was merged to trunk rev 14610 and archived Constantin Asofiei
10:30 AM Bug #7314 (Closed): conversion issue for FIRST-OF(f1) when there is a collision between the field...: Greg Shah
10:28 AM Bug #7314: conversion issue for FIRST-OF(f1) when there is a collision between the field name and...: 7199c was merged to trunk rev 14610 and archived Constantin Asofiei
10:30 AM Feature #6410: implement additional built-in OO classes/interfaces: Constantin Asofiei wrote:
> 7199c rev 14559 contains the implementation for @OpenEdge.Core.System.ArgumentError@. R... Constantin Asofiei
10:30 AM Bug #7315 (Closed): unknown literal passed as an argument to a 'object' parameter: Greg Shah
10:28 AM Bug #7315: unknown literal passed as an argument to a 'object' parameter: 7199c was merged to trunk rev 14610 and archived Constantin Asofiei
10:30 AM Bug #7240: conversion problem related to ENTERED in a IF expr: 7199c was merged to trunk rev 14610 and archived Constantin Asofiei
10:29 AM Bug #7316 (Closed): regression in 'ACCUM ... extVar' expansion - subscript not emitted: Greg Shah
10:28 AM Bug #7316: regression in 'ACCUM ... extVar' expansion - subscript not emitted: 7199c was merged to trunk rev 14610 and archived Constantin Asofiei
10:29 AM Bug #7317 (Closed): accumulator using another accumulator as expression: Greg Shah
10:28 AM Bug #7317: accumulator using another accumulator as expression: 7199c was merged to trunk rev 14610 and archived Constantin Asofiei
10:28 AM Bug #7206: shared frame defined with the same name but different widgets: 7199c was merged to trunk rev 14610 and archived. Constantin Asofiei
10:20 AM Bug #7198 (Test): conversion of empty UPDATE/SET/PROMPT-FOR statements: Greg Shah
10:15 AM Bug #7198: conversion of empty UPDATE/SET/PROMPT-FOR statements: Branch 7198a was merged to trunk rev 14609 and archived. Constantin Asofiei
08:10 AM Bug #7198: conversion of empty UPDATE/SET/PROMPT-FOR statements: You can merge 7198a to trunk after 7395d. Greg Shah
06:04 AM Feature #6649: improve the performance or SourceNameMapper runtime: Hynek Cihlar wrote:
> Joe Davis wrote:
> > The current status is that it's ready for review, but I'm trying to figu... Hynek Cihlar

06/02/2023

11:22 AM Bug #7198: conversion of empty UPDATE/SET/PROMPT-FOR statements: 7198a rev 14507 was rebased from trunk rev 14604 - new rev 14605.
rev 14606 has an adjustment for new downPath(tok... Constantin Asofiei
10:00 AM Bug #7198: conversion of empty UPDATE/SET/PROMPT-FOR statements: Greg Shah wrote:
> > There is more work for ENABLE and any other UI statements. Plus I don't know what happens if t... Constantin Asofiei
09:57 AM Bug #7198: conversion of empty UPDATE/SET/PROMPT-FOR statements: > There is more work for ENABLE and any other UI statements. Plus I don't know what happens if there are @DO WITH FR... Greg Shah

06/01/2023

03:39 PM Feature #6422 (Review): implement auditing support including AUDIT-POLICY and AUDIT-CONTROL: Theodoros Theodorou

05/31/2023

03:41 PM Feature #4065: server-side processing of client platform dependencies: 4065d rebased and merged to trunk as revision 14594. The branch was archived. Hynek Cihlar
03:30 PM Feature #4065: server-side processing of client platform dependencies: Code Review Task Branch 4065d Revision 14593
No objections. You can merge to trunk now. Greg Shah
03:24 PM Feature #4065: server-side processing of client platform dependencies: The regression fix in #4065-150 was checked in 4065d and is ready to be merged to trunk once it passes review. Hynek Cihlar
01:15 PM Feature #4065: server-side processing of client platform dependencies: Greg Shah wrote:
> Is the fix for #4065-150 in a branch?
Not yet AFAIK. I will create task branch 4065d for this.... Hynek Cihlar
08:52 AM Feature #4065: server-side processing of client platform dependencies: Is the fix for #4065-150 in a branch? Greg Shah
11:57 AM Feature #3853: implement LOG-MANAGER runtime: Here are my startup args tests. Now with focus on error thrown or shown. The current impl will have to be revised.
... Galya B
08:57 AM Bug #7247 (Review): Dataset:READ-XML does nothing: Finished.
Committed to 7247a/14597.
Please review.
Thank you.
Igor Skornyakov

05/30/2023

11:12 AM Bug #7247: Dataset:READ-XML does nothing: Added support for inferring DATASET/TEMP-TABLE structure from XML (w/o namespaces)
Committed to 7247a/14596.
Th... Igor Skornyakov

05/29/2023

04:37 PM Bug #7247: Dataset:READ-XML does nothing: Inferring DATASET from XML is almost done.
To be done:
# Inferring RELATIONs
# Supporting attributes
# Supporting... Igor Skornyakov
11:08 AM Feature #6420: implement the AUDIT-ENABLED() built-in function: Greg Shah wrote:
> > I believe the best way to simulate the @proutil ... enableauditing@ functionality is by adding ... Eric Faulhaber
10:21 AM Feature #6420: implement the AUDIT-ENABLED() built-in function: > I believe the best way to simulate the @proutil ... enableauditing@ functionality is by adding a flag in @server/di... Greg Shah
04:20 AM Feature #6420: implement the AUDIT-ENABLED() built-in function: To enable auditing, the following commands should be executed in @proenv@:... Theodoros Theodorou
09:45 AM Feature #4065: server-side processing of client platform dependencies: Greg Shah wrote:
> Hynek Cihlar wrote:
> > Greg Shah wrote:
> > > What is the effort to decouple these so that the... Hynek Cihlar
09:44 AM Feature #4065: server-side processing of client platform dependencies: Hynek Cihlar wrote:
> Greg Shah wrote:
> > What is the effort to decouple these so that the server's inbound connec... Greg Shah
09:43 AM Feature #4065: server-side processing of client platform dependencies: Greg Shah wrote:
> What is the effort to decouple these so that the server's inbound connections do not use the clie... Hynek Cihlar
09:05 AM Feature #4065: server-side processing of client platform dependencies: > Greg, for the process resource, launch will be conducted on the server only when no terminal is needed. That is for... Greg Shah
09:01 AM Feature #4065: server-side processing of client platform dependencies: > I implemented server sockets to be a distinct resource from client sockets. So currently one can define server sock... Greg Shah
06:29 AM Feature #4065: server-side processing of client platform dependencies: Greg, for the process resource, launch will be conducted on the server only when no terminal is needed. That is for t... Hynek Cihlar
04:23 AM Feature #4065: server-side processing of client platform dependencies: Hynek Cihlar wrote:
> For the socket client the key store password is read from the client parameters @ssl-socket:tr... Hynek Cihlar
04:22 AM Feature #4065: server-side processing of client platform dependencies: For the socket client the key store password is read from the client parameters @ssl-socket:truststore:password@. How... Hynek Cihlar

05/28/2023

11:58 AM Feature #4065: server-side processing of client platform dependencies: I implemented server sockets to be a distinct resource from client sockets. So currently one can define server socket... Hynek Cihlar

05/26/2023

03:27 PM Feature #6420: implement the AUDIT-ENABLED() built-in function: > There is already another boolean for the other audit implementation: @security/aduit/enabled@.
No, the two audit... Greg Shah
03:20 PM Feature #6420: implement the AUDIT-ENABLED() built-in function: How should I implement this feature? Should I add a boolean in @server/directory.xml@? There is already another boole... Theodoros Theodorou
07:48 AM Feature #6420: implement the AUDIT-ENABLED() built-in function: When this is implemented, please put it in branch 6422a. Greg Shah
01:21 PM Bug #7247: Dataset:READ-XML does nothing: Greg Shah wrote:
> What is left to do in this task? Please set the %Done. Also, move it to review status if it is ... Igor Skornyakov
01:06 PM Bug #7247: Dataset:READ-XML does nothing: What is left to do in this task? Please set the %Done. Also, move it to review status if it is ready for review. Greg Shah
11:33 AM Bug #7247: Dataset:READ-XML does nothing: Rebased 7247a to trunk/14590.
Pushed up to revision 14592. Igor Skornyakov
11:26 AM Bug #7247: Dataset:READ-XML does nothing: Implemented inferring temp-table structure from XML.
Committed to 7247a/14588. Igor Skornyakov
12:08 PM Feature #6649: improve the performance or SourceNameMapper runtime: Joe Davis wrote:
> Greg Shah wrote:
> > Joe: Where does this work stand? I'd like to get the early review done as ... Hynek Cihlar
11:57 AM Feature #6649: improve the performance or SourceNameMapper runtime: Greg Shah wrote:
> Joe: Where does this work stand? I'd like to get the early review done as well as get an update ... Joe Davis
07:52 AM Feature #7386: predefined auditing events support and a better persistence approach for auditing ...: Implement 4GL auditing capability for predefined events (@event_id < 32000@).
Rework the simplistic persistence ap... Greg Shah
07:50 AM Feature #7386 (New): predefined auditing events support and a better persistence approach for aud...: Greg Shah
07:47 AM Feature #6422: implement auditing support including AUDIT-POLICY and AUDIT-CONTROL: I've confirmed with the customer that they do not need the predefined events support. At this time, let's just get t... Greg Shah

05/25/2023

12:36 PM Feature #4065: server-side processing of client platform dependencies: Constantin Asofiei wrote:
> Constantin Asofiei wrote:
> > Hynek, there is a regression in trunk rev 14580 - this se... Hynek Cihlar
12:36 PM Feature #4065: server-side processing of client platform dependencies: Constantin Asofiei wrote:
> Hynek, there is a regression in trunk rev 14580 - this seems to fix it, I need to finish... Constantin Asofiei
11:45 AM Feature #6649: improve the performance or SourceNameMapper runtime: Joe: Where does this work stand? I'd like to get the early review done as well as get an update on your subsequent o... Greg Shah
10:17 AM Feature #6422: implement auditing support including AUDIT-POLICY and AUDIT-CONTROL: Theodoros Theodorou wrote:
> 5. As Igor stated, we can use @Kafka@ to store these messages and use something like @k... Igor Skornyakov
09:56 AM Feature #6422: implement auditing support including AUDIT-POLICY and AUDIT-CONTROL: Igor/Theodoros: These are good analyses.
> Leave it as it is for now because just 2 commands are adding in this ta... Greg Shah
09:42 AM Feature #6422: implement auditing support including AUDIT-POLICY and AUDIT-CONTROL: I agree with Igor.
I investigated the classes a bit and as I understand they keep some info in memory instead of u... Theodoros Theodorou
08:43 AM Feature #6422: implement auditing support including AUDIT-POLICY and AUDIT-CONTROL: The idea of the optimization of the @_Lock@ and @_Usertablestat@ VST support is to postpone updating the correspondin... Igor Skornyakov
02:14 AM Feature #6422: implement auditing support including AUDIT-POLICY and AUDIT-CONTROL: Eric Faulhaber wrote:
> As 6422a currently is implemented, we are taking a round trip to the database to insert a re... Igor Skornyakov

05/24/2023

03:50 PM Bug #7247: Dataset:READ-XML does nothing: Extracted common code in XmlImport/JsonImport to a base class.
Committed to 7247a/14585. Igor Skornyakov
12:14 PM Feature #4065: server-side processing of client platform dependencies: Hynek, there is a regression in trunk rev 14580 - this seems to fix it, I need to finish ETF testing to confirm.
<pr... Constantin Asofiei
11:09 AM Feature #6422: implement auditing support including AUDIT-POLICY and AUDIT-CONTROL: As 6422a currently is implemented, we are taking a round trip to the database to insert a record into the @meta_aud_a... Eric Faulhaber
06:24 AM Feature #6410: implement additional built-in OO classes/interfaces: Marian Edu wrote:
> > Also, 6410a branch is on xfer - do you still have problems using bzr on xfersrv01? If not, pl... Constantin Asofiei
06:23 AM Feature #6410: implement additional built-in OO classes/interfaces: Constantin Asofiei wrote:
> Marian, something else to note: I'm looking at the patch, and I don't understand somethi... Marian Edu
06:20 AM Feature #6410: implement additional built-in OO classes/interfaces: Constantin Asofiei wrote:
> Marian, what skeleton revision did you use for the skeleton patch? I can't apply it clea... Marian Edu
06:05 AM Feature #6649: improve the performance or SourceNameMapper runtime: Joe Davis wrote:
> Hynek Cihlar wrote:
> > Joe, I see you changed the status of this issue to Review. Are the chang... Hynek Cihlar

05/23/2023

05:59 PM Feature #6649: improve the performance or SourceNameMapper runtime: Hynek Cihlar wrote:
> Joe, I see you changed the status of this issue to Review. Are the changes checked in anywhere... Joe Davis
11:14 AM Feature #6649: improve the performance or SourceNameMapper runtime: Joe, I see you changed the status of this issue to Review. Are the changes checked in anywhere? Hynek Cihlar
03:57 PM Feature #6422: implement auditing support including AUDIT-POLICY and AUDIT-CONTROL: Hello Eric and Ovidiu. Greg asked me to ask for a review regarding my implementation of meta_aud_audit_data. To test ... Theodoros Theodorou
07:04 AM Feature #4065: server-side processing of client platform dependencies: 4065b merged to trunk as revision 14580 and archived. Hynek Cihlar
06:46 AM Feature #4065: server-side processing of client platform dependencies: Greg Shah wrote:
> Go ahead.
In progress. Hynek Cihlar
06:00 AM Feature #4065: server-side processing of client platform dependencies: Go ahead. Greg Shah
03:08 AM Feature #4065: server-side processing of client platform dependencies: Greg, I'd like to merge 4065b to trunk to address the regressions. Hynek Cihlar

05/22/2023

07:01 PM Feature #6649 (Review): improve the performance or SourceNameMapper runtime: Joe Davis
12:26 PM Feature #4065: server-side processing of client platform dependencies: > > Are you working on process launching and server-sockets?
>
> No, I switched to my other priority tasks.
Let... Greg Shah
12:16 PM Feature #4065: server-side processing of client platform dependencies: Greg Shah wrote:
> Are you working on process launching and server-sockets?
No, I switched to my other priority t... Hynek Cihlar
12:14 PM Feature #4065: server-side processing of client platform dependencies: > I named the "resource" just "webservice". It would probably make sense to rename it to @webservice-client@ and dist... Greg Shah
11:45 AM Feature #4065: server-side processing of client platform dependencies: Greg Shah wrote:
> Code Review Task Branch 4065b Revisions 14576 and 14577
>
> 1. Doesn't @ClientSideResourceMana... Hynek Cihlar
08:32 AM Feature #4065: server-side processing of client platform dependencies: Code Review Task Branch 4065b Revisions 14576 and 14577
1. Doesn't @ClientSideResourceManager.initialize()@ need a... Greg Shah
05:03 AM Feature #4065: server-side processing of client platform dependencies: I checked in a fix for another client initialization problem in 4065b revision 14577. @StreamDaemon@ initialization m... Hynek Cihlar

« Previous

Also available in: Atom

Project

General

Profile

FWD » Core Development » Base Language

Activity

Activity

06/16/2023

06/15/2023

06/14/2023

06/12/2023

06/09/2023

06/08/2023

06/07/2023

06/06/2023

06/05/2023

06/02/2023

06/01/2023

05/31/2023

05/30/2023

05/29/2023

05/28/2023

05/26/2023

05/25/2023

05/24/2023

05/23/2023

05/22/2023