Project

General

Profile

Activity

From 06/29/2023 to 07/28/2023

07/28/2023

04:27 PM Bug #7644: load all legacy enums on FWD server startup
The legacy enum values are defined as Java 'static final' - and created in a static constructor. The problem here is... Constantin Asofiei
04:21 PM Bug #7644 (Test): load all legacy enums on FWD server startup
Constantin Asofiei
03:09 PM Bug #7643: memory leak in AssociatedThread
In a large GUI application, in a thread dump @SecurityManager.threadIds@ is reported to have a size of 120k (for refe... Constantin Asofiei
02:58 PM Bug #7643 (Test): memory leak in AssociatedThread
Constantin Asofiei
11:09 AM Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
Constantin Asofiei wrote:
> There is another approach: in a @FOR EACH@ block, is the navigation always done via @que...
Alexandru Lungu
09:55 AM Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
@FOR FIRST@ and @FOR LAST@ get converted to @forBlock@. I think it should work by injecting the @P2JQuery@ instance ... Constantin Asofiei
09:48 AM Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
There is another approach: in a @FOR EACH@ block, is the navigation always done via @query.next()@? If yes, we can:
...
Constantin Asofiei
09:37 AM Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
> introduce a new lambda block between @Init@ and @Body@, namely @Iter@. This will be a boolean supplier. If this boo... Greg Shah
08:59 AM Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
I analyzed the problem and understand most of the issue. I also have designed a solution here. However, I still have ... Alexandru Lungu

07/27/2023

10:56 AM Bug #7604 (Test): Switch does not honor case sensitivity of character
Greg Shah
10:54 AM Bug #7604 (Review): Switch does not honor case sensitivity of character
Merged 7464a in trunk as rev. 14673. Archived 7464a. Alexandru Lungu

07/25/2023

01:04 PM Bug #7460: implement Progress.Lang.Class:getMethods
Did pushed local changes in #6410a - rev 14556, probably missed release notes.
The idea was to directly use the Ja...
Marian Edu
07:41 AM Feature #7045 (WIP): re-implement "normal" (non-abend) stack unwinding to avoid throwing an excep...
Greg Shah

07/24/2023

07:36 AM Support #4032: block/transaction processing context-local and other performance improvements
4032a was created from trunk rev 14668.
4032a rev 14669 contains another batch of context-local improvements.
Constantin Asofiei

07/21/2023

10:47 AM Bug #7604: Switch does not honor case sensitivity of character
Committed on 7464a revision 14664. Eduard Soltan
02:41 AM Bug #7604: Switch does not honor case sensitivity of character
Alexandru Lungu wrote:
> This is quite "cryptic" :) Eduard, please make some second/third rechecks before Redmine po...
Eduard Soltan

07/20/2023

05:14 PM Feature #6497: add equivalent support for the -T command line option
Greg Shah wrote:
> What do you mean by this? Show some 4GL code and output to demonstrate.
> ...
> What do you me...
Theodoros Theodorou
11:17 AM Feature #6497: add equivalent support for the -T command line option
Theodoros Theodorou wrote:
> OE throws an error if the temporary directory provided as a startup parameter is proble...
Constantin Asofiei
11:13 AM Feature #6497: add equivalent support for the -T command line option
> OE throws an error if
What do you mean by this? Show some 4GL code and output to demonstrate.
> It throws an...
Greg Shah
10:26 AM Feature #6497: add equivalent support for the -T command line option
OE throws an error if the temporary directory provided as a startup parameter is problematic (e.g. permission issue o... Theodoros Theodorou
10:44 AM Bug #7604: Switch does not honor case sensitivity of character
> offset and length paramentes from substring function, isCaseInsensitive method for ExpressionConversionWorker.java ... Alexandru Lungu
10:05 AM Bug #7604: Switch does not honor case sensitivity of character
... Eduard Soltan
09:13 AM Bug #7604 (WIP): Switch does not honor case sensitivity of character
Alexandru Lungu
08:17 AM Bug #7604: Switch does not honor case sensitivity of character
Please go ahead and fix this. Greg Shah
07:28 AM Bug #7604: Switch does not honor case sensitivity of character
Tested @switch@ with following cases:
- character variable case-insensitive
- character variable case-sensitive
...
Eduard Soltan
05:49 AM Bug #7604: Switch does not honor case sensitivity of character
... Eduard Soltan
05:34 AM Bug #7604 (Closed): Switch does not honor case sensitivity of character
Eduard Soltan
08:02 AM Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
Greg Shah wrote:
> * Insert code after each persistence call in the converted code which can generate @QueryOffEndEx...
Alexandru Lungu
07:56 AM Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
I know it is late in the month to consider changes to our performance workplan. I do believe that this task has very... Greg Shah

07/19/2023

11:23 AM Bug #7299: resolution of the target OO method in chained calls with poly arguments
Marian, from the @tests/oo@ @@TestSuite@ files I could run in OpenEdge, this one I had to manually change:... Constantin Asofiei
10:27 AM Bug #7299: resolution of the target OO method in chained calls with poly arguments
I've ran @tests.oo.method_resolve.TestSuiteMethodResolve@ in OpenEdge 11.6.3 and the only test that fails is this:
...
Constantin Asofiei
11:05 AM Feature #4855: add a 4GL extension SESSION:SESSION-ID attribute which returns a UUID which unique...
Task branch 4855b was merged to trunk as rev 14665 and archived. Galya B
10:22 AM Feature #4855: add a 4GL extension SESSION:SESSION-ID attribute which returns a UUID which unique...
You can merge to trunk. Greg Shah
08:29 AM Feature #4855: add a 4GL extension SESSION:SESSION-ID attribute which returns a UUID which unique...
Do I merge? Galya B
08:02 AM Feature #4855: add a 4GL extension SESSION:SESSION-ID attribute which returns a UUID which unique...
Review for 4855b/14665 - I'm OK with the changes. Constantin Asofiei
07:22 AM Feature #4855: add a 4GL extension SESSION:SESSION-ID attribute which returns a UUID which unique...
4855b r14665 ready for review.
This is the output of the test proc:...
Galya B
06:53 AM Feature #4855: add a 4GL extension SESSION:SESSION-ID attribute which returns a UUID which unique...
You need this code adjusted for SESSION-ID, in methods-attributes.rules, the section for SESSION handle:... Constantin Asofiei
05:26 AM Feature #4855: add a 4GL extension SESSION:SESSION-ID attribute which returns a UUID which unique...
4855b r14663-14664 I can't make it work:... Galya B
03:23 AM Feature #4855: add a 4GL extension SESSION:SESSION-ID attribute which returns a UUID which unique...
This test needs to work properly to validate the fix:... Constantin Asofiei
03:05 AM Feature #4855: add a 4GL extension SESSION:SESSION-ID attribute which returns a UUID which unique...
Can I now have a different keyword like I wanted, or we'll make it writable although it makes no sense? Galya B
03:03 AM Feature #4855: add a 4GL extension SESSION:SESSION-ID attribute which returns a UUID which unique...
@SESSION:SESSION-ID@ will become writable. Galya B
02:58 AM Feature #4855: add a 4GL extension SESSION:SESSION-ID attribute which returns a UUID which unique...
Do I need to invent something or you can point me to an example or programming principle? Galya B
01:26 AM Feature #4855: add a 4GL extension SESSION:SESSION-ID attribute which returns a UUID which unique...
The changes in trunk rev 14661 are not OK. As SESSION-ID exists now at both CLIENT-PRINCIPAL and SESSION, we need th... Constantin Asofiei

07/18/2023

02:23 PM Bug #7299: resolution of the target OO method in chained calls with poly arguments
I was thinking that instead of wrapping the POLY expr in a constructor with the expected type, emit a @Parameter.forT... Constantin Asofiei
01:19 PM Bug #7299: resolution of the target OO method in chained calls with poly arguments
The most important part missing in FWD I think is this: at compile time, OpenEdge hard-links the call to invoke the e... Constantin Asofiei
01:17 PM Bug #7299: resolution of the target OO method in chained calls with poly arguments
Constantin Asofiei wrote:
> Marian Edu wrote:
> > Constantin Asofiei wrote:
> > >Please run the test in #7299-30 i...
Constantin Asofiei
01:17 PM Bug #7299: resolution of the target OO method in chained calls with poly arguments
Marian Edu wrote:
> Constantin Asofiei wrote:
> >Please run the test in #7299-30 in your OpenEdge and let me know i...
Constantin Asofiei
01:15 PM Bug #7299: resolution of the target OO method in chained calls with poly arguments
Constantin Asofiei wrote:
>Please run the test in #7299-30 in your OpenEdge and let me know if you see the same erro...
Marian Edu
12:11 PM Bug #7299: resolution of the target OO method in chained calls with poly arguments
Marian Edu wrote:
> It might run fine but it's still wrong, this should not happen - the copile time resolution shou...
Constantin Asofiei
12:08 PM Bug #7299: resolution of the target OO method in chained calls with poly arguments
Constantin Asofiei wrote:
> I'm running with 11.6.3.
Sadly the oldest we have available is @11.7@ and that will pro...
Marian Edu
11:59 AM Bug #7299: resolution of the target OO method in chained calls with poly arguments
Marian Edu wrote:
> Constantin Asofiei wrote:
> > Please run this on your side:
> Not sure, we have the @CTest@ in...
Constantin Asofiei
11:46 AM Bug #7299: resolution of the target OO method in chained calls with poly arguments
Constantin Asofiei wrote:
> Please run this on your side:
Not sure, we have the @CTest@ in @tests.oo.support@ so ha...
Marian Edu
11:38 AM Bug #7299: resolution of the target OO method in chained calls with poly arguments
Please run this on your side:... Constantin Asofiei
11:26 AM Bug #7299: resolution of the target OO method in chained calls with poly arguments
Constantin Asofiei wrote:
> Marian, there is something wrong with the @TestLastMethodReturnTypeChainedCall.testLastO...
Marian Edu
09:29 AM Bug #7299: resolution of the target OO method in chained calls with poly arguments
Marian, there is something wrong with the @TestLastMethodReturnTypeChainedCall.testLastOverloadHasDifferentReturnType... Constantin Asofiei
07:51 AM Bug #7299: resolution of the target OO method in chained calls with poly arguments
Constantin Asofiei wrote:
> -Created task branch 7229b from trunk rev 14661.-
This branch was physically removed, 7...
Constantin Asofiei
05:18 AM Bug #7299 (WIP): resolution of the target OO method in chained calls with poly arguments
-Created task branch 7229b from trunk rev 14661.- Constantin Asofiei
11:47 AM Feature #6410: implement additional built-in OO classes/interfaces
Constantin Asofiei wrote:
> Marian Edu wrote:
> > Constantin Asofiei wrote:
> > > The problem here is that @Legacy...
Marian Edu
11:40 AM Feature #6410: implement additional built-in OO classes/interfaces
Marian Edu wrote:
> Constantin Asofiei wrote:
> > The problem here is that @LegacyClass.invoke@ resolves the target...
Constantin Asofiei
11:33 AM Feature #6410: implement additional built-in OO classes/interfaces
Constantin Asofiei wrote:
> The problem here is that @LegacyClass.invoke@ resolves the target at each invocation, de...
Marian Edu
09:14 AM Feature #6410: implement additional built-in OO classes/interfaces
Marian Edu wrote:
> One question here, I'm looking at the 'invoke' method and that was implemented straight into the...
Constantin Asofiei
09:07 AM Feature #6410: implement additional built-in OO classes/interfaces
One question here, I'm looking at the 'invoke' method and that was implemented straight into the class (LegacyClass) ... Marian Edu
07:48 AM Feature #4855 (Closed): add a 4GL extension SESSION:SESSION-ID attribute which returns a UUID whi...
Greg Shah
12:57 AM Feature #4855 (Test): add a 4GL extension SESSION:SESSION-ID attribute which returns a UUID which...
Task branch 4855a was merged to trunk as rev 14661 and archived. Email sent. Galya B

07/17/2023

03:43 PM Feature #4855: add a 4GL extension SESSION:SESSION-ID attribute which returns a UUID which unique...
You can rebase and merge 4855a to trunk. Greg Shah

07/14/2023

05:25 PM Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
Constantin Asofiei wrote:
> From a large app, NEXT is being called some ~2000 times and LEAVE some ~1000 times. In ...
Greg Shah
02:30 PM Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
From a large app, NEXT is being called some ~2000 times and LEAVE some ~1000 times. In contrast, there are ~20k of @... Constantin Asofiei
01:54 PM Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
Although there is some "low hanging fruit" left to pick, when we consider how expensive it is to use Java exceptions ... Greg Shah
02:17 AM Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
From a large customer application, there are these numbers for a RETURN:
* from within @p2j.oo@ code, which forces a...
Constantin Asofiei

07/13/2023

11:56 AM Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
There is another case which needs to convert to @storeReturnValue@:... Constantin Asofiei

07/12/2023

08:55 AM Feature #6410: implement additional built-in OO classes/interfaces
Constantin Asofiei wrote:
> I think that was meant to be @getQualifiedJavaName@, not @getQualifiedName@.
That did...
Marian Edu
07:48 AM Feature #6410: implement additional built-in OO classes/interfaces
I think that was meant to be @getQualifiedJavaName@, not @getQualifiedName@. Constantin Asofiei
07:41 AM Feature #6410 (WIP): implement additional built-in OO classes/interfaces
Working on implementation of reflection for supporting class's methods, having issues converting some of the test cas... Marian Edu

07/11/2023

01:28 PM Bug #7484 (Test): decimal format - left-side 'balance' must include group separators
Greg Shah
11:59 AM Bug #7484: decimal format - left-side 'balance' must include group separators
7484a was merged to trunk rev 14650 and archived. Constantin Asofiei
11:51 AM Bug #7484: decimal format - left-side 'balance' must include group separators
Go ahead with merge. Greg Shah
07:48 AM Feature #6425: SESSION handle features
The exact implementation of these may not be possible in FWD since we have a different architecture. Each one must b... Greg Shah
07:37 AM Feature #6425: SESSION handle features
From Theodoros in #4938-226:
> I was not able to find the meaning of:
>
> ubpid
> logname
> asid
> ubpropfile...
Greg Shah
07:45 AM Bug #7299: resolution of the target OO method in chained calls with poly arguments
Greg Shah wrote:
> > those tests were not refactored as ABLUnit as far as I can see as it looks those were added aft...
Marian Edu

07/10/2023

03:24 PM Feature #6497: add equivalent support for the -T command line option
The code review for these changes (in branch 4938b) can be seen in #4938-225. Greg Shah
03:24 PM Feature #4391: enhance existing SESSION:STARTUP-PARAMETERS support to honor -H -db -S -ld -N values
The code review for these changes (in branch 4938b) can be seen in #4938-225. Greg Shah
03:24 PM Feature #6425: SESSION handle features
The code review for these changes (in branch 4938b) can be seen in #4938-225. Greg Shah
07:14 AM Bug #7299: resolution of the target OO method in chained calls with poly arguments
> those tests were not refactored as ABLUnit as far as I can see as it looks those were added after we've started the... Greg Shah
07:00 AM Bug #7299: resolution of the target OO method in chained calls with poly arguments
Greg Shah wrote:
> > > > Marian: Please have your team review the documentation on method overloading in #3751-492 a...
Marian Edu

07/07/2023

03:47 PM Bug #7484: decimal format - left-side 'balance' must include group separators
Code Review Task Branch 7484a Revision 14649
No objections.
Greg Shah
03:09 PM Bug #7484 (Review): decimal format - left-side 'balance' must include group separators
Created task branch 7484a from trunk rev 14648. The fix is in rev 14649. Constantin Asofiei
02:45 PM Bug #7484: decimal format - left-side 'balance' must include group separators
OK, go ahead with the change. Greg Shah
02:43 PM Bug #7484: decimal format - left-side 'balance' must include group separators
Greg Shah wrote:
> > > What happens in the case where there is a mixture of @>@ and other digit types (@9@, @z@, @Z@...
Constantin Asofiei
02:37 PM Bug #7484: decimal format - left-side 'balance' must include group separators
> > What happens in the case where there is a mixture of @>@ and other digit types (@9@, @z@, @Z@, @*@)?
> Only the ...
Greg Shah
02:35 PM Bug #7484: decimal format - left-side 'balance' must include group separators
Greg Shah wrote:
> Is the problem that an error 22 is raised in FWD but not in OE?
Correct.
> What happens in th...
Constantin Asofiei
01:52 PM Bug #7484: decimal format - left-side 'balance' must include group separators
Is the problem that an error 22 is raised in FWD but not in OE?
What happens in the case where there is a mixture ...
Greg Shah
02:52 PM Feature #4855: add a 4GL extension SESSION:SESSION-ID attribute which returns a UUID which unique...
We are trying to avoid conversion changes in trunk for a short time, so we may not merge this until later next week. Greg Shah
02:52 PM Feature #4855: add a 4GL extension SESSION:SESSION-ID attribute which returns a UUID which unique...
Code Review Task Branch 4855a Revision 14634
No objections.
Greg Shah
11:41 AM Bug #7299: resolution of the target OO method in chained calls with poly arguments
> > > Marian: Please have your team review the documentation on method overloading in #3751-492 and look at the code ... Greg Shah

07/06/2023

05:30 AM Feature #6410: implement additional built-in OO classes/interfaces
Did reverted back to use BDT instead of Object for `invoke` method, some fixes for `setParameter` in `ParameterList` ... Marian Edu
04:14 AM Feature #6410: implement additional built-in OO classes/interfaces
Constantin Asofiei wrote:
> Marian, please upload a skeleton patch using the latest skeleton project from xfer (rev ...
Marian Edu

07/05/2023

01:11 PM Bug #7484: decimal format - left-side 'balance' must include group separators
This format is valid in OE: @->,>>>,>>9.9<<<<<<<<@.
We have logic in @NumberType.parseFormat@ which computes a @le...
Constantin Asofiei
01:08 PM Bug #7484 (Test): decimal format - left-side 'balance' must include group separators
Constantin Asofiei

07/04/2023

07:13 PM Feature #4391 (Review): enhance existing SESSION:STARTUP-PARAMETERS support to honor -H -db -S -l...
Theodoros Theodorou
07:13 PM Feature #4391 (WIP): enhance existing SESSION:STARTUP-PARAMETERS support to honor -H -db -S -ld -...
Theodoros Theodorou
07:12 PM Feature #6425 (Review): SESSION handle features
Theodoros Theodorou

07/03/2023

01:44 PM Feature #3868 (Test): customer servlet integration/support
The fix is committed to trunk rev 14637 via 7426a.
Any customer application using a jasper version other than FWD'...
Constantin Asofiei
07:10 AM Bug #7299: resolution of the target OO method in chained calls with poly arguments
The same rules used at the conversion to determine the target for a direct call needs to be implemented in @ControlFl... Constantin Asofiei

06/30/2023

11:08 AM Bug #7460: implement Progress.Lang.Class:getMethods
What is the effort to implement this?
I would expect it to go into branch 6410a.
Greg Shah

06/29/2023

05:36 AM Feature #4855 (Review): add a 4GL extension SESSION:SESSION-ID attribute which returns a UUID whi...
4855a r14634 for review Galya B
 

Also available in: Atom