Activity

From 10/19/2023 to 11/17/2023

11/18/2023

07:33 PM Feature #6431: implement support to allow CPINTERNAL set to UTF-8 and CP936: Marian Edu wrote:
> Hi Theodoros, just pushed the i18n tests on testcases (rev#1514), we're still working one some c... Theodoros Theodorou

11/17/2023

08:47 AM Feature #6431: implement support to allow CPINTERNAL set to UTF-8 and CP936: Theodoros Theodorou wrote:
> Hello Marian. Greg asked me to coordinate with you that we do not do the same effort tw... Marian Edu
07:41 AM Feature #6431: implement support to allow CPINTERNAL set to UTF-8 and CP936: Hello Marian. Greg asked me to coordinate with you that we do not do the same effort twice. Please have a look at @te... Theodoros Theodorou
07:11 AM Feature #6431: implement support to allow CPINTERNAL set to UTF-8 and CP936: Yes, it needs to be fixed. Such conversions should yield identical results. It seems likely that the cause is relat... Greg Shah
08:23 AM Feature #6649: improve the performance or SourceNameMapper runtime: Alexandru Lungu wrote:
> Mind that the search-path cache is not synchronized. Please add @synchronize@ to that acces... Dănuț Filimon
08:13 AM Feature #6649: improve the performance or SourceNameMapper runtime: *Review of 6649b/rev.14808*
Mind that the search-path cache is not synchronized. Please add @synchronize@ to that ... Alexandru Lungu
08:03 AM Feature #6649: improve the performance or SourceNameMapper runtime: Alexandru Lungu wrote:
> Some extra ideas:
>
> * Also, what about @convertedNames@? Can't it possible leak as we ... Dănuț Filimon
07:33 AM Feature #6649: improve the performance or SourceNameMapper runtime: Alexandru Lungu wrote:
> Danut please fix #6649-131 - I am planning to start performance testing with 6649a as soon ... Dănuț Filimon
07:08 AM Feature #6649: improve the performance or SourceNameMapper runtime: Some extra ideas:
* Also, what about @convertedNames@? Can't it possible leak as we are constantly adding to it th... Alexandru Lungu
06:26 AM Feature #6649: improve the performance or SourceNameMapper runtime: I've done some tests, and there were no obvious problems. I am moving this to the profiler asap.
However, I want t... Alexandru Lungu
04:04 AM Feature #6649: improve the performance or SourceNameMapper runtime: I converted a large application and generated a @name_map.xml@ with ~39k (~7k of OO classes) class-mappings and only ... Alexandru Lungu

11/16/2023

06:03 PM Feature #6431: implement support to allow CPINTERNAL set to UTF-8 and CP936: Hello, I wrote a small test (chr_and_asc.p) which tests the conversion of a character from one code page to another (... Theodoros Theodorou
12:40 AM Feature #6649: improve the performance or SourceNameMapper runtime: *Committed 6649b/rev.14807*. Fixed a NPE when there are no path-mapping nodes in name_map.xml. Dănuț Filimon

11/15/2023

08:12 AM Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception: Understood. For such extensive changes to our control flow, it seems necessary. Greg Shah
08:09 AM Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception: Greg, I can do that for POC, but it will take me a day to have it converted. Also mind that I am already reconverting... Alexandru Lungu
07:31 AM Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception: If you think it is ready, let's get ChUI regression tests, ETF and the big POC tested. Greg Shah
03:40 AM Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception: Converted and setup a large customer application using 7045b branch, and used it for a bit. Did not noticed any major... Eduard Soltan

11/13/2023

05:16 AM Feature #6649 (Internal Test): improve the performance or SourceNameMapper runtime: Dănuț Filimon
05:09 AM Feature #6649: improve the performance or SourceNameMapper runtime: I also tried to find out the cause of the incremental version where nodes are duplicated but after running a @./gradl... Dănuț Filimon
05:06 AM Feature #6649 (WIP): improve the performance or SourceNameMapper runtime: *Committed 6649b/rev.14805 and 6649b/rev.14806*:
* Made @sourceCache@ configurable through @CacheManager@. I previou... Dănuț Filimon

11/12/2023

04:29 AM Feature #6649: improve the performance or SourceNameMapper runtime: Code review 6649b revision 14804.
@initializationPaths.size() == 0@ in @createSourceCacheEntry@ should be protecte... Hynek Cihlar

11/10/2023

09:56 AM Feature #6819: refactor FWD proxy implementation to use ReflectASM instead of Java Method reflection: That code resolves the @MethodAccess@ target for a @java.lang.reflect.Method@. @Method@ instances are not singleton,... Constantin Asofiei
09:50 AM Feature #6819: refactor FWD proxy implementation to use ReflectASM instead of Java Method reflection: Constantin, I reached quite randomly in @Utils.invoke@ and saw the double map access on @METHOD_DATA@ and @methodAcce... Alexandru Lungu
09:02 AM Feature #6649 (Review): improve the performance or SourceNameMapper runtime: *Committed 6649b/rev.14804*.
* After solving the path-mapping node duplication problem, I reverted the changes from ... Dănuț Filimon
03:23 AM Feature #6410: implement additional built-in OO classes/interfaces: Marian, please remind me of your issues - I plan to look at them over the next week. Also, point me to any test repr... Constantin Asofiei

11/09/2023

09:31 AM Feature #6649: improve the performance or SourceNameMapper runtime: > The number look good on the paper. The question is how will it perform in the actual customer scenario.
I can ta... Alexandru Lungu
09:26 AM Feature #6649: improve the performance or SourceNameMapper runtime: Dănuț Filimon wrote:
> I retested the performance of the cache after saving the @fastConvertName@ results of program... Hynek Cihlar
06:17 AM Feature #6649: improve the performance or SourceNameMapper runtime: I retested the performance of the cache after saving the @fastConvertName@ results of program names that are not foun... Dănuț Filimon
02:23 AM Feature #6649: improve the performance or SourceNameMapper runtime: Dănuț Filimon wrote:
> Got it, I went and deleted @checkSourceCache@ and integrated it's functionality in @fastConve... Hynek Cihlar
01:01 AM Feature #6649: improve the performance or SourceNameMapper runtime: Got it, I went and deleted @checkSourceCache@ and integrated it's functionality in @fastConvertName@, this was the be... Dănuț Filimon
03:59 AM Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception: I rebased 7045b to latest trunk. It is now at rev. 14833.
Eduard, please double-check: @RecordBuffer@ (especially @s... Alexandru Lungu

11/08/2023

10:50 AM Feature #6649: improve the performance or SourceNameMapper runtime: Dănuț Filimon wrote:
> The problem is that I can't differentiate between which case is executed. I am still thinking... Hynek Cihlar
08:15 AM Feature #6649: improve the performance or SourceNameMapper runtime: Hynek Cihlar wrote:
> The cache should eliminate 100% of the heavy execution of @fastConvertName@ for all the encoun... Dănuț Filimon
08:06 AM Feature #6649: improve the performance or SourceNameMapper runtime: Dănuț Filimon wrote:
> * The number of cache hits (when cache returned a value) was *21288* from the total *35971* @... Hynek Cihlar
07:22 AM Feature #6649 (WIP): improve the performance or SourceNameMapper runtime: Dănuț Filimon
07:21 AM Feature #6649: improve the performance or SourceNameMapper runtime: Hynek Cihlar wrote:
> Code review 6649b revisions 14800..14803.
>
> Saving the RUN entries should be saved in a s... Dănuț Filimon
04:03 AM Feature #6649: improve the performance or SourceNameMapper runtime: Hynek Cihlar wrote:
> Does it mean that the non-program files don't require the additional @fastConvertName@ logic (... Dănuț Filimon
03:37 AM Feature #6649: improve the performance or SourceNameMapper runtime: Dănuț Filimon wrote:
> Hynek Cihlar wrote:
> > Dănuț Filimon wrote:
> > > In my opinion, adding images to @path-ma... Hynek Cihlar
03:15 AM Feature #6649: improve the performance or SourceNameMapper runtime: Code review 6649b revisions 14800..14803.
Saving the RUN entries should be saved in a set rather than saving direc... Hynek Cihlar
02:35 AM Feature #6649: improve the performance or SourceNameMapper runtime: Hynek Cihlar wrote:
> Dănuț Filimon wrote:
> > In my opinion, adding images to @path-mappings@ will just slow down ... Dănuț Filimon
09:55 AM Feature #6410: implement additional built-in OO classes/interfaces: 6410b rev 14794 was rebased from trunk rev 14824 - new rev 14828. Constantin Asofiei
09:52 AM Feature #6410: implement additional built-in OO classes/interfaces: Starting rebase now. Constantin Asofiei
08:55 AM Feature #6410: implement additional built-in OO classes/interfaces: Constantin Asofiei wrote:
> OK, let me know when it's done.
All done what I've could get 'proper' enough... rev #14... Marian Edu
07:21 AM Feature #6410: implement additional built-in OO classes/interfaces: Marian Edu wrote:
> Constantin Asofiei wrote:
>
> > If you have nothing else to commit, I'll rebase.
> Give me 1... Constantin Asofiei
07:18 AM Feature #6410: implement additional built-in OO classes/interfaces: Constantin Asofiei wrote:
> If you have nothing else to commit, I'll rebase.
Give me 10-15 mins please to commit ... Marian Edu
07:14 AM Feature #6410: implement additional built-in OO classes/interfaces: I see these commits on xfer/6410b:... Constantin Asofiei
07:08 AM Feature #6410: implement additional built-in OO classes/interfaces: Constantin Asofiei wrote:
> Marian, see another patch - please integrate it also in 6410b.
>
Had to manually appl... Marian Edu
09:25 AM Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception: Eduard, mind setting up some large customer applications and do some smoke tests. I will take the changes and do on s... Alexandru Lungu
03:30 AM Feature #6819: refactor FWD proxy implementation to use ReflectASM instead of Java Method reflection: For a while, I've been looking through videos, blog posts and other info I could get my hands on, related to lambdas.... Constantin Asofiei

11/07/2023

10:17 AM Feature #6649: improve the performance or SourceNameMapper runtime: Dănuț Filimon wrote:
> In my opinion, adding images to @path-mappings@ will just slow down the creation process.
... Hynek Cihlar
09:49 AM Feature #6649 (Review): improve the performance or SourceNameMapper runtime: *Committed 6649b/rev.14803*.
* Used AssociatedThread to initialize caches for each new propath;
* Added missing doc... Dănuț Filimon
08:15 AM Feature #6649: improve the performance or SourceNameMapper runtime: My mistake, I just wanted to make an edit on my previous post. Dănuț Filimon
04:37 AM Feature #6649: improve the performance or SourceNameMapper runtime: AFAIK about paths to images, @FileSystemOps.searchPath@ is used when searching any file and reaches @fastConvertName@... Dănuț Filimon
04:22 AM Feature #6649: improve the performance or SourceNameMapper runtime: Alexandru Lungu wrote:
> Danut, please check if the number of entries is right. I expected to have >10k (at least th... Dănuț Filimon
04:11 AM Feature #6649: improve the performance or SourceNameMapper runtime: Danut, please check if the number of entries is right. I expected to have >10k (at least the number of files, but als... Alexandru Lungu
03:20 AM Feature #6649: improve the performance or SourceNameMapper runtime: I've finally got the results of the testing:
* The initial thread that firstly initializes the @sourceCache@ took *5... Dănuț Filimon
07:55 AM Feature #6410: implement additional built-in OO classes/interfaces: Constantin Asofiei wrote:
> Marian Edu wrote:
> > ... because of the block added to @invoke@ this is 'polluting' th... Marian Edu
06:33 AM Feature #6410: implement additional built-in OO classes/interfaces: Marian Edu wrote:
> ... because of the block added to @invoke@ this is 'polluting' the call-stack
Was this block ad... Constantin Asofiei
05:10 AM Feature #6410: implement additional built-in OO classes/interfaces: Constantin Asofiei wrote:
> Hmm... this may mean that OpenEdge does not report the internal classes in the callsta... Marian Edu
04:36 AM Feature #6410: implement additional built-in OO classes/interfaces: Marian, see another patch - please integrate it also in 6410b.
> I'm trying to fight a case when invalid parameter... Constantin Asofiei
02:50 AM Feature #6410: implement additional built-in OO classes/interfaces: Constantin Asofiei wrote:
> Marian, I have this patch to properly report datasethandle/tablehandle vs dataset/table ... Marian Edu

11/06/2023

02:23 PM Feature #6410: implement additional built-in OO classes/interfaces: I'd like to get the next phase of #6410 support into code review if it is far enough along. Greg Shah
01:22 PM Feature #6410: implement additional built-in OO classes/interfaces: Marian, I have this patch to properly report datasethandle/tablehandle vs dataset/table - please review. I plan to i... Constantin Asofiei
09:10 AM Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception: Alexandru Lungu wrote:
> I've reviewed the changes. I intend to change several things, but I will list them here for... Eduard Soltan
08:48 AM Bug #8008: read-json on a 1252 longchar should convert to utf-8 automatically before hydrating te...: Additional information:
# It is expected that @cpinternal iso-8859-15@ will show the same behavior with the (verbati... Tijs Wickardt
08:33 AM Bug #8008: read-json on a 1252 longchar should convert to utf-8 automatically before hydrating te...: This task should be picked up *after* customer task #7944 is completed.
The customer task #7944 has a special condit... Tijs Wickardt
08:32 AM Bug #8008 (New): read-json on a 1252 longchar should convert to utf-8 automatically before hydrat...: Tijs Wickardt
08:47 AM Feature #6649: improve the performance or SourceNameMapper runtime: > > The long init time could be brought down with splitting the entries processing on multiple threads.
>
> And by... Greg Shah
07:28 AM Feature #6649: improve the performance or SourceNameMapper runtime: While testing, the cache is initialized with the default propath, but when a client is connecting, another propath is... Dănuț Filimon
06:23 AM Feature #6649: improve the performance or SourceNameMapper runtime: Hynek Cihlar wrote:
> The long init time could be brought down with splitting the entries processing on multiple thr... Hynek Cihlar
04:51 AM Feature #6649: improve the performance or SourceNameMapper runtime: The long init time could be brought down with splitting the entries processing on multiple threads. But for now let's... Hynek Cihlar
04:39 AM Feature #6649: improve the performance or SourceNameMapper runtime: Alexandru Lungu wrote:
> Danut, can you script the duplicates out for now, so you don't have to wait too much? This ... Dănuț Filimon
04:38 AM Feature #6649: improve the performance or SourceNameMapper runtime: Danut, can you script the duplicates out for now, so you don't have to wait too much? This is just for the performanc... Alexandru Lungu
04:28 AM Feature #6649: improve the performance or SourceNameMapper runtime: Hynek Cihlar wrote:
> Danut, any numbers on the actual runtime performance with the cache in place?
Not yet, I will... Dănuț Filimon
04:22 AM Feature #6649: improve the performance or SourceNameMapper runtime: Danut, any numbers on the actual runtime performance with the cache in place? Hynek Cihlar
04:17 AM Feature #6649: improve the performance or SourceNameMapper runtime: It would be the best if we can have a working thread by using @ContextAwareThread@. Until the thread discussion is so... Dănuț Filimon

11/03/2023

12:54 PM Feature #6649: improve the performance or SourceNameMapper runtime: Dănuț Filimon wrote:
> Hynek Cihlar wrote:
> > You won't be able to access the security context from the worker thr... Hynek Cihlar
09:13 AM Feature #6649: improve the performance or SourceNameMapper runtime: Hynek Cihlar wrote:
> You won't be able to access the security context from the worker thread, so you will have to p... Dănuț Filimon
07:09 AM Feature #6649: improve the performance or SourceNameMapper runtime: Dănuț Filimon wrote:
> I've tried to use a thread to create a cache but I get the following error:
You won't be a... Hynek Cihlar
05:43 AM Feature #6649: improve the performance or SourceNameMapper runtime: I've tried to use a thread to create a cache but I get the following error:... Dănuț Filimon

11/02/2023

09:16 AM Feature #6649: improve the performance or SourceNameMapper runtime: *Committed 6649b/rev.14802*.
* Managed to write all the data to @name_map.xml@, avoided creating @path_map.txt@. I m... Dănuț Filimon

11/01/2023

03:17 PM Feature #6431: implement support to allow CPINTERNAL set to UTF-8 and CP936: Marian, I am trying to run something like @asc(chr(i, 'CodePageA', 'CodePageB'))@. Which parameters should I change? ... Theodoros Theodorou
11:21 AM Feature #6431: implement support to allow CPINTERNAL set to UTF-8 and CP936: Marian Edu wrote:
> Since you're not using the @-ttwrdrul@ parameter anyway I would say this is exactly the case fro... Theodoros Theodorou
04:06 AM Feature #6431: implement support to allow CPINTERNAL set to UTF-8 and CP936: Greg Shah wrote:
> From Theodoros:
>
> The program which creates the data in files looks like this:
Strings/ch... Marian Edu
03:56 AM Feature #6431: implement support to allow CPINTERNAL set to UTF-8 and CP936: Theodoros Theodorou wrote:

> I think @-rcodein@ is required too.
Generally speaking all codepages used must be ... Marian Edu
08:41 PM Feature #6431: implement support to allow CPINTERNAL set to UTF-8 and CP936: From Theodoros:
The program which creates the data in files looks like this:... Greg Shah
08:26 PM Feature #6431: implement support to allow CPINTERNAL set to UTF-8 and CP936: I think the @-cpterm@ and @-cpstream@ options are purely to avoid an unexpected conversion when you output data to a ... Greg Shah
09:05 AM Feature #6649: improve the performance or SourceNameMapper runtime: Dănuț Filimon wrote:
> At this point I want to ask why does the propath need to be a member of @SourceNameMapperCach... Hynek Cihlar
08:25 AM Feature #6649: improve the performance or SourceNameMapper runtime: As mentioned in #6649-83, please do not create the extra @path_map.txt@. Add the data into @name_map.xml@. Greg Shah
08:06 AM Feature #6649: improve the performance or SourceNameMapper runtime: Here's an update of the implementation progress:
# Managed to extract filenames from RUN statements and write them t... Dănuț Filimon
07:30 AM Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception: P.S. please look into @errorIfNull@ flag. This will save us from detecting cases where we need / we don't need to gen... Alexandru Lungu
07:29 AM Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception: I've reviewed the changes. I intend to change several things, but I will list them here for further advice:
* What... Alexandru Lungu
06:09 AM Bug #7299: resolution of the target OO method in chained calls with poly arguments: 7299d was merged to trunk as revision 14809 and archived. Constantin Asofiei

10/31/2023

05:45 PM Feature #6431: implement support to allow CPINTERNAL set to UTF-8 and CP936: Marian Edu wrote:
> If it's a character mode client set the @-cpterm@ and maybe also @-cpstream@ to @cp936@ otherw... Theodoros Theodorou
07:06 AM Feature #6431: implement support to allow CPINTERNAL set to UTF-8 and CP936: Greg Shah wrote:
> > I also wanted to ask how to run an application using @-cpinternal CP936@. I get the error messa... Marian Edu
06:59 AM Feature #6431: implement support to allow CPINTERNAL set to UTF-8 and CP936: > I also wanted to ask how to run an application using @-cpinternal CP936@. I get the error message @Code page conver... Greg Shah
01:57 PM Bug #7299: resolution of the target OO method in chained calls with poly arguments: 7299d was rebased from trunk rev 14799 - new rev 14802. Constantin Asofiei
11:35 AM Bug #7299: resolution of the target OO method in chained calls with poly arguments: Greg Shah wrote:
> It can merge after 7650a.
I was wrong - I need to do a round of conversion testing with 7299d, I... Constantin Asofiei
11:10 AM Bug #7299: resolution of the target OO method in chained calls with poly arguments: It can merge after 7650a. Greg Shah
10:57 AM Bug #7299: resolution of the target OO method in chained calls with poly arguments: Greg Shah wrote:
> Is any more testing needed before merge?
No, it can be queued for merge. Constantin Asofiei
10:57 AM Bug #7299: resolution of the target OO method in chained calls with poly arguments: Is any more testing needed before merge? Greg Shah
10:57 AM Bug #7299: resolution of the target OO method in chained calls with poly arguments: Code Review Task Branch 7299d Revision 14794
No objections. Greg Shah
05:41 AM Bug #7299: resolution of the target OO method in chained calls with poly arguments: Greg Shah wrote:
> In @oo_references.rules@ line 453, don't we need to remove the double quotes around the classname... Constantin Asofiei
01:34 PM Bug #7990: investigate what can be improved after 7494a adds BlockDefinition instance to Scopeabl...: With #7494, @scopeStart@ knows the exact @BlockDefinition@ instance which is notified. The same can be added to @sco... Constantin Asofiei
01:32 PM Bug #7990 (New): investigate what can be improved after 7494a adds BlockDefinition instance to Sc...: Constantin Asofiei
11:08 AM Feature #6649: improve the performance or SourceNameMapper runtime: Rebased 6649b to latest trunk. It is now at rev. 14801. Alexandru Lungu
10:57 AM Feature #6649: improve the performance or SourceNameMapper runtime: Greg Shah wrote:
> > Both @deleteFile@ and @openStream@ result in the same error.
> > [...]
>
> The @outputFilen... Dănuț Filimon
10:38 AM Feature #6649: improve the performance or SourceNameMapper runtime: > Both @deleteFile@ and @openStream@ result in the same error.
> [...]
The @outputFilename@ variable needs to be ... Greg Shah
09:43 AM Feature #6649: improve the performance or SourceNameMapper runtime: > Consider that if you emit a separate/new artifact, that must now be documented and managed forever as an extra set ... Alexandru Lungu
09:02 AM Feature #6649: improve the performance or SourceNameMapper runtime: Greg Shah wrote:
> Consider that if you emit a separate/new artifact, that must now be documented and managed foreve... Dănuț Filimon
08:45 AM Feature #6649: improve the performance or SourceNameMapper runtime: > I've analyzed how @name_map.xml@ is created and took in consideration writing to a @.txt@ file which should be simp... Greg Shah
08:34 AM Feature #6649: improve the performance or SourceNameMapper runtime: Hynek Cihlar wrote:
> Regarding @CACHE_SIZE@, why would you want to limit the number of entries?
This should be t... Alexandru Lungu
08:14 AM Feature #6649: improve the performance or SourceNameMapper runtime: I've analyzed how @name_map.xml@ is created and took in consideration writing to a @.txt@ file which should be simple... Dănuț Filimon
04:41 AM Feature #6649: improve the performance or SourceNameMapper runtime: Perhaps also some at least basic runtime metrics should be gathered with our JMX infrastructure.
Hynek Cihlar
04:34 AM Feature #6649: improve the performance or SourceNameMapper runtime: Alexandru Lungu wrote:
> ** *Hynek*, in case the PROPATH changes, should we have @SourceNameMapperCache@ empty or po... Hynek Cihlar
04:02 AM Bug #6570 (WIP): stale procedure leak when appservers are used: Alexandru Lungu

10/30/2023

07:25 PM Feature #6431: implement support to allow CPINTERNAL set to UTF-8 and CP936: Greg Shah wrote:
> Theodoros: Please document your findings so far. Help to ensure that the tests written by Daniel... Theodoros Theodorou
07:30 AM Feature #6431: implement support to allow CPINTERNAL set to UTF-8 and CP936: If there is a reasonably small data set, then keeping it in the source code should be the standard approach. I agree... Greg Shah
06:54 AM Feature #6431: implement support to allow CPINTERNAL set to UTF-8 and CP936: BTW, Daniel is working on something more or less the same for the I18N part of the base language unit tests - not spe... Marian Edu
06:51 AM Feature #6431: implement support to allow CPINTERNAL set to UTF-8 and CP936: Theodoros Theodorou wrote:
> Greg Shah wrote:
> I prefer if that data is coded into the 4GL source, rather than as ... Marian Edu
03:48 PM Bug #7299: resolution of the target OO method in chained calls with poly arguments: Code Review Task Branch 7299d Revisions 14792 and 14793
In @oo_references.rules@ line 453, don't we need to remove... Greg Shah
03:04 PM Bug #7299: resolution of the target OO method in chained calls with poly arguments: The fixes for #7299-64 and #7976 are in 7299d rev 14793 - please review.
I'll need to go through conversion testin... Constantin Asofiei
11:48 AM Feature #6649: improve the performance or SourceNameMapper runtime: The first one is an expression, so a dynamic way to run a procedure. It can be disregarded for now. The following I t... Alexandru Lungu
10:24 AM Feature #6649: improve the performance or SourceNameMapper runtime: A few cases that I found while running a Hotel_GUI conversion and should be mentioned:
- @RUN VALUE(possiblePath) PE... Dănuț Filimon
08:41 AM Feature #6649: improve the performance or SourceNameMapper runtime: Danut:
* Not only RUN statements should be analyzed. Also anything that is going to be a path (like Hynek stated, IM... Alexandru Lungu
08:34 AM Feature #6649: improve the performance or SourceNameMapper runtime: A new @path_map.xml@ file should be created, similar to @name_map.xml@, with nodes that specify the paths for each RU... Dănuț Filimon
06:30 AM Feature #6649: improve the performance or SourceNameMapper runtime: Hynek Cihlar wrote:
> Unless I'm missing something using @RUN_CALL_SITE_*@ for the caching/precalculation isn't opti... Alexandru Lungu

10/27/2023

04:37 PM Feature #6431: implement support to allow CPINTERNAL set to UTF-8 and CP936: Greg Shah wrote:
I prefer if that data is coded into the 4GL source, rather than as a data file. Data file access a... Theodoros Theodorou
11:10 AM Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception: The NPE is fixed now, but the regression tests I have still fail. Again, I don't have a replicate (just that the expe... Alexandru Lungu

10/26/2023

02:31 PM Bug #7299: resolution of the target OO method in chained calls with poly arguments: Created task branch 7299d from trunk rev 14791.
7299d rev 14792 contains a regression fix for static poly calls - ... Constantin Asofiei

10/25/2023

12:47 PM Feature #6410: implement additional built-in OO classes/interfaces: 6410b is now on trunk rev 14790 and was pushed to xfer. Constantin Asofiei
12:34 PM Feature #6410: implement additional built-in OO classes/interfaces: Constantin Asofiei wrote:
> Marian, please let me know when you have everything committed to 6410b, so I can get it ... Marian Edu
10:13 AM Feature #6410: implement additional built-in OO classes/interfaces: Marian, please let me know when you have everything committed to 6410b, so I can get it from xfer, to rebase it. Constantin Asofiei
09:47 AM Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception: Eduard, I see you fixed this (#7045-62) in a new revision. I will need to recompile the project I use for test in ord... Alexandru Lungu
04:27 AM Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception: PS: good news, a large customer application converted (~17 hours) and compiled (~1 hour) correctly. Also, it passed s... Alexandru Lungu
04:26 AM Feature #7045 (WIP): re-implement "normal" (non-abend) stack unwinding to avoid throwing an excep...: Eduard, I am facing some regressions with @CompoundQuery.retrieveImpl@ (mostly NPE). I see there is a duplicate code ... Alexandru Lungu

10/24/2023

09:33 AM Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception: > Eric: Please review.
The changes are quite extensive, so the review will take a bit :) I am converting a big app... Alexandru Lungu
09:28 AM Feature #7045 (Review): re-implement "normal" (non-abend) stack unwinding to avoid throwing an ex...: Greg Shah
09:27 AM Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception: Eric: Please review. Greg Shah
03:20 AM Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception: Committed on 7045b, revision 14683.
Also tested changes to @forBlock@, @forEach@ blocks and also to @next@, @last@,... Eduard Soltan

10/23/2023

03:07 PM Bug #7299: resolution of the target OO method in chained calls with poly arguments: 7299c was merged to trunk as rev. 14787 and archived. Constantin Asofiei
03:02 PM Bug #7299: resolution of the target OO method in chained calls with poly arguments: Code Review Task Branch 7299c Revision 14787
No objection. This seems pretty safe. Do you think it can be merged... Greg Shah
11:16 AM Bug #7299: resolution of the target OO method in chained calls with poly arguments: Created task branch 7299c from trunk rev 14786.
7299c rev 14787 fixed another regression in trunk rev 14770, for u... Constantin Asofiei

10/20/2023

11:34 AM Bug #7299: resolution of the target OO method in chained calls with poly arguments: Branch 7299b was merged to trunk rev 14779 and archived Constantin Asofiei
10:15 AM Bug #7299: resolution of the target OO method in chained calls with poly arguments: Code Review Task Branch 7299b Revisions 14778 through 14780
The changes are good. Greg Shah
08:31 AM Feature #6649: improve the performance or SourceNameMapper runtime: Alexandru Lungu wrote:
> For the conversion side, do you mean preprocessing the path when converting to extract the ... Hynek Cihlar
08:25 AM Feature #6649: improve the performance or SourceNameMapper runtime: I've *committed 6649b/rev.14743* with the following changes:
* renamed @convertNameDynamically@ to @fastConvertName@... Dănuț Filimon
07:30 AM Feature #6649: improve the performance or SourceNameMapper runtime: For the conversion side, do you mean preprocessing the path when converting to extract the base name (@a.p@ from @x/y... Alexandru Lungu
07:28 AM Feature #6649: improve the performance or SourceNameMapper runtime: Hynek Cihlar wrote:
> Another idea I'm not sure you already considered is precalculating the denormalized Progress n... Dănuț Filimon
06:06 AM Feature #6649: improve the performance or SourceNameMapper runtime: Hynek Cihlar wrote:
> The precalculated map would be stored per session and would have to be recalculated on input c... Hynek Cihlar
06:04 AM Feature #6649: improve the performance or SourceNameMapper runtime: Another idea I'm not sure you already considered is precalculating the denormalized Progress names passed in to the c... Hynek Cihlar
05:32 AM Feature #6649: improve the performance or SourceNameMapper runtime: Hynek Cihlar wrote:
> I'm not that familiar with the anticipated test cases, but wouldn't the cache still be benefic... Dănuț Filimon

10/19/2023

11:38 AM Feature #6649: improve the performance or SourceNameMapper runtime: Dănuț Filimon wrote:
> Hynek Cihlar wrote:
> It seems that currently the @convertName@ method calls @getLegacyCaseS... Hynek Cihlar
09:51 AM Feature #6649: improve the performance or SourceNameMapper runtime: Hynek Cihlar wrote:
> *convertNameDynamically:*
> * instead of
> [...]
> it would be more efficient to store cas... Dănuț Filimon
10:05 AM Bug #7299: resolution of the target OO method in chained calls with poly arguments: Greg, please review 7299b (revs 14778 - 14780) - this contains regression fixes for #6501-359 and #7929 Constantin Asofiei
07:15 AM Bug #7299: resolution of the target OO method in chained calls with poly arguments: 7299b rev 14776 will show linkage errors when resolving Java class names during conversion. The problem here is that... Constantin Asofiei

« Previous

Also available in: Atom

Project

General

Profile

FWD » Core Development » Base Language

Activity

Activity

11/18/2023

11/17/2023

11/16/2023

11/15/2023

11/13/2023

11/12/2023

11/10/2023

11/09/2023

11/08/2023

11/07/2023

11/06/2023

11/03/2023

11/02/2023

11/01/2023

10/31/2023

10/30/2023

10/27/2023

10/26/2023

10/25/2023

10/24/2023

10/23/2023

10/20/2023

10/19/2023