Project

General

Profile

Activity

From 02/09/2015 to 03/10/2015

03/10/2015

03:28 PM Bug #2535: enhancing datatype conversion functions
Ovidiu Maxiniuc wrote:
> I guess we should keep the new constructor and replace the return line like:
> ...
Eric Faulhaber
02:53 PM Bug #2535: enhancing datatype conversion functions
The generated @evaluate@ method for @WhereExpression@ @whereExpr0@ looks currently like this:... Ovidiu Maxiniuc
02:39 PM Bug #2535: enhancing datatype conversion functions
You are right: we don't want to mask this error always, because there may be times when it represents a legitimate er... Eric Faulhaber
01:35 PM Bug #2535: enhancing datatype conversion functions
Eric,
I have an issue regarding the implementation of these methods. At first I implemented as simple as this:
<...
Ovidiu Maxiniuc
11:57 AM Bug #2535: enhancing datatype conversion functions
I just discovered that we don't cover all the conversions between datatypes. We need to implement additional construc... Ovidiu Maxiniuc
11:34 AM Bug #2535 (Closed): enhancing datatype conversion functions
Ovidiu Maxiniuc

03/06/2015

05:56 PM Bug #2488: replace runtime compilation of dynamic queries
Code review 0306a:
Looks good. I'll run tests with this update and let you know how it goes.
Eric Faulhaber
01:31 PM Bug #2488: replace runtime compilation of dynamic queries
The strings literals are generated as ready-to-be-written to java source files and the escape sequences must be proce... Ovidiu Maxiniuc

03/04/2015

06:45 AM Bug #2524: missing support for NEXT-SIBLING attribute for buffer handles
Ovidiu Maxiniuc wrote:
> Constantin Asofiei wrote:
> > Ovidiu, about HandleChain changes: the buffer-specific code ...
Constantin Asofiei
05:43 AM Bug #2524: missing support for NEXT-SIBLING attribute for buffer handles
Constantin Asofiei wrote:
> Ovidiu, about HandleChain changes: the buffer-specific code I think should reside in ove...
Ovidiu Maxiniuc
05:37 AM Bug #2524: missing support for NEXT-SIBLING attribute for buffer handles
Ovidiu, about HandleChain changes: the buffer-specific code I think should reside in overridden methods in the Buffer... Constantin Asofiei
05:17 AM Bug #2524: missing support for NEXT-SIBLING attribute for buffer handles
Eric Faulhaber wrote:
> Ovidiu: please rename the testcase to something more descriptive (you can keep "2524" as par...
Ovidiu Maxiniuc

03/03/2015

05:28 PM Bug #2524: missing support for NEXT-SIBLING attribute for buffer handles
One more thing: please make the @BufferImpl@ constructor you added @protected@ instead of @public@. As an implementat... Eric Faulhaber
03:29 PM Bug #2524: missing support for NEXT-SIBLING attribute for buffer handles
Code review 0303c:
You added a call to @release()@ at @TemporaryBuffer@:3411, which seems unrelated to the remaini...
Eric Faulhaber
12:26 PM Bug #2524: missing support for NEXT-SIBLING attribute for buffer handles
The attached update fixes the management of dynamic buffer handles. Ovidiu Maxiniuc
11:55 AM Bug #2533 (WIP): management of dynamic buffer handles
Ovidiu Maxiniuc

02/27/2015

08:37 AM Bug #2526: Records preserving its position in the sorting index for adaptive query
As for initial analysis: currently we use record snapshots as the base to find the next record in the index using an ... Stanislav Lomany
08:28 AM Bug #2526: Records preserving its position in the sorting index for adaptive query
This problem was noticed in an editable browse which easily exposes this bug. Assigning a value to a field of the ind... Stanislav Lomany
08:17 AM Bug #2526 (New): Records preserving its position in the sorting index for adaptive query
Stanislav Lomany

02/26/2015

12:49 PM Bug #2488: replace runtime compilation of dynamic queries
I found a test case that fails to convert properly.... Ovidiu Maxiniuc

02/25/2015

03:53 PM Bug #2524: missing support for NEXT-SIBLING attribute for buffer handles
The reference pdf states that the SESSION:FIRST-BUFFER is the head of the linked list of _"handles for the dynamic bu... Ovidiu Maxiniuc

02/24/2015

03:14 PM Bug #2524 (WIP): missing support for NEXT-SIBLING attribute for buffer handles
Ovidiu Maxiniuc
03:11 PM Bug #2524: missing support for NEXT-SIBLING attribute for buffer handles
I noticed the following message printed in the app-server 'client' log after each executed request.... Ovidiu Maxiniuc
02:44 PM Bug #2524 (Closed): missing support for NEXT-SIBLING attribute for buffer handles
Ovidiu Maxiniuc

02/19/2015

03:04 PM Bug #2488: replace runtime compilation of dynamic queries
Ovidiu Maxiniuc wrote:
> The generated code is unchanged for majic. The attached update passed the conversion test.
...
Eric Faulhaber
12:01 PM Bug #2488: replace runtime compilation of dynamic queries
The generated code is unchanged for majic. The attached update passed the conversion test. Ovidiu Maxiniuc
09:44 AM Bug #2488: replace runtime compilation of dynamic queries
Eric Faulhaber wrote:
> Where did the need to improve the predicate prep come from? What is the rationale behind the...
Ovidiu Maxiniuc

02/18/2015

03:40 PM Bug #2488: replace runtime compilation of dynamic queries
Code review 0218a:
Where did the need to improve the predicate prep come from? What is the rationale behind the cu...
Eric Faulhaber
02:40 PM Bug #2488: replace runtime compilation of dynamic queries
Added support for @LogicalExpression@ anon c'tor.
Refactored some method names to better fit their implementation.
Ovidiu Maxiniuc
02:41 PM Bug #2514: incorrect return values for get{First|Next|Last|Previous} methods
This update should fix the return values for respective methods. Ovidiu Maxiniuc

02/17/2015

03:34 PM Bug #2488: replace runtime compilation of dynamic queries
Oops, I forgot the update. here it is. Ovidiu Maxiniuc
03:33 PM Bug #2488: replace runtime compilation of dynamic queries
Changes since 0210a:
* Improved @preparePredicate()@ for OPEN QUERY predicates to
- allow one level nested quotes
- a...
Ovidiu Maxiniuc
10:21 PM Bug #2488: replace runtime compilation of dynamic queries
Code review 0210a:
The version of @DynamicQueryHelper@ in the update shows no difference from the latest version i...
Eric Faulhaber

02/13/2015

02:32 PM Bug #2514: incorrect return values for get{First|Next|Last|Previous} methods
Alternative working form for ... Ovidiu Maxiniuc
07:46 AM Bug #2514: incorrect return values for get{First|Next|Last|Previous} methods
The set of get{First|Next|Last|Previous} methods should return:
* @?@ (unknown) if the query object handle is invali...
Ovidiu Maxiniuc
07:38 AM Bug #2514 (Closed): incorrect return values for get{First|Next|Last|Previous} methods
Ovidiu Maxiniuc

02/11/2015

06:56 AM Bug #2488: replace runtime compilation of dynamic queries
The problem reported in note-62 is fixed by adding the @methods_attributes.rules@ to runtime conversion. With this oc... Ovidiu Maxiniuc

02/10/2015

02:41 PM Bug #2488: replace runtime compilation of dynamic queries
The attached update should handle the @WhereExpressions@.
There are a few other issues that must be solved first:
*...
Ovidiu Maxiniuc
02:07 PM Bug #2488: replace runtime compilation of dynamic queries
Eric Faulhaber wrote:
> At a glance, yes, that looks wrong. Have you converted the static form of the same query? Thi...
Ovidiu Maxiniuc
01:57 PM Bug #2488: replace runtime compilation of dynamic queries
At a glance, yes, that looks wrong. Have you converted the static form of the same query? This will tell you if the p... Eric Faulhaber
01:52 PM Bug #2488: replace runtime compilation of dynamic queries
Eric,
I almost finished implementing support for 'extending' and interpreting the client-side @WhereExpression@ but ...
Ovidiu Maxiniuc

02/09/2015

02:16 PM Bug #2488: replace runtime compilation of dynamic queries
Eric Faulhaber wrote:
> If we cannot come up with a single test case which would result in client-side where clause ...
Ovidiu Maxiniuc
01:25 PM Bug #2488: replace runtime compilation of dynamic queries
IIRC the point is that there can be multiple dynamic buffers with the same name in the same scope and some P2J struct... Stanislav Lomany
01:13 PM Bug #2488: replace runtime compilation of dynamic queries
Stanislav Lomany wrote:
> Eric, are you basically asking why suffixes are added to the names of dynamic buffers?
Ye...
Eric Faulhaber
01:08 PM Bug #2488: replace runtime compilation of dynamic queries
Eric, are you basically asking why suffixes are added to the names of dynamic buffers? Stanislav Lomany
12:17 PM Bug #2488: replace runtime compilation of dynamic queries
Stanislav, I don't fully understand the following comment, from @DynamicQueryHelper@:763:... Eric Faulhaber
10:36 AM Bug #2488: replace runtime compilation of dynamic queries
If we cannot come up with a single test case which would result in client-side where clause processing (all so far se... Eric Faulhaber
09:24 AM Bug #2488: replace runtime compilation of dynamic queries
Regarding the user-defined functions. I was thinking too ahead. At this moment the @ProgressParser@ cannot handle UDF... Ovidiu Maxiniuc
08:25 AM Bug #2488: replace runtime compilation of dynamic queries
Eric Faulhaber wrote:
> The result of this evaluation would be fed into an adapter subclass of the @WhereExpression@...
Ovidiu Maxiniuc
04:15 AM Bug #2488: replace runtime compilation of dynamic queries
Eric,
I tried such constructs on windev01.
*CAN-FIND*: P2J parses and successfully converts them in java code, ...
Ovidiu Maxiniuc
 

Also available in: Atom