Project

General

Profile

Activity

From 07/13/2016 to 08/11/2016

08/11/2016

11:45 PM Feature #3011 (Rejected): try H2 internal connection pool instead of UnpooledConnectionProvider
Tried this. It went very badly. We need to maintain the existing mechanism of holding open connections for as long as... Eric Faulhaber
10:00 PM Bug #1914: database conversion requires Internet connectivity
The server startup issue was addressed per notes 9-10, so I'm changing the subject back to reflect that this is only ... Eric Faulhaber

07/26/2016

11:39 AM Feature #3145 (Closed): implement _File._Template metadata support
Eric Faulhaber
11:33 AM Feature #3145: implement _File._Template metadata support
The task branch was merged to trunk as revision 11074.
The test results and branch were archived and notification wa...
Ovidiu Maxiniuc
10:54 AM Feature #3145: implement _File._Template metadata support
Great! Please merge to trunk. Eric Faulhaber
10:43 AM Feature #3145: implement _File._Template metadata support
The revision 11082 has passed all test (devsrv01 and ETF). The only issue was gso231 because my test framework was no... Ovidiu Maxiniuc

07/25/2016

04:34 PM Feature #3145: implement _File._Template metadata support
Ovidiu Maxiniuc wrote:
> The reason for this method is not to synchronize access to internal but rather to check if ...
Eric Faulhaber
03:51 PM Feature #3145: implement _File._Template metadata support
Eric Faulhaber wrote:
> Code review 3145a/11081:
Thanks for the review. I will do the required changes. I am in the...
Ovidiu Maxiniuc
03:26 PM Feature #3145: implement _File._Template metadata support
Code review 3145a/11081:
@HQLHelper.isFindTemplate@ should be package private and be moved to the appropriate loca...
Eric Faulhaber

07/22/2016

04:23 PM Feature #3145: implement _File._Template metadata support
Copy/pasted from mail conversation. Please read in timestamp (reverse) order:
# To check meta support, I will add ...
Ovidiu Maxiniuc

07/21/2016

12:38 PM Feature #3145: implement _File._Template metadata support
Ovidiu Maxiniuc wrote:
> I tried to isolate only the simple queries that expressly seek the template record. These q...
Eric Faulhaber
12:28 PM Feature #3145: implement _File._Template metadata support
Eric Faulhaber wrote:
>
> The changes to @PreselectQuery@ I think need some attention, but not at this time. Note ...
Ovidiu Maxiniuc
09:16 AM Feature #3145: implement _File._Template metadata support
Code review 3145a/11077:
Sorry I didn't get to this yesterday. From my understanding of the template record featur...
Eric Faulhaber

07/20/2016

04:27 PM Feature #3145: implement _File._Template metadata support
I implemented support for loading template records in simple @PreselectQuery@. The trick was to intercept the templat... Ovidiu Maxiniuc

07/19/2016

11:39 AM Feature #3145: implement _File._Template metadata support
Ovidiu Maxiniuc wrote:
> I will review the @setCurrentRecord@ and add supplementary conditionals so that the templat...
Eric Faulhaber
11:07 AM Feature #3145: implement _File._Template metadata support
Thanks for review, Eric!
Eric Faulhaber wrote:
> Code review 3145a/11072:
>
> Please help me understand the purp...
Ovidiu Maxiniuc
10:35 AM Feature #3145: implement _File._Template metadata support
Code review 3145a/11072:
Please help me understand the purpose of the @variable_references.rules@ change. Aren't w...
Eric Faulhaber

07/18/2016

04:32 PM Feature #3145: implement _File._Template metadata support
Eric Faulhaber wrote:
> I think we just have to accept that a FIND by RECID/ROWID is a special case. Do we behave th...
Ovidiu Maxiniuc
02:17 PM Feature #3145: implement _File._Template metadata support
Ovidiu Maxiniuc wrote:
> I have created the task branch 3145a. The last revision is 11072.
>
> I discovered that ...
Eric Faulhaber

07/15/2016

04:14 PM Feature #3145: implement _File._Template metadata support
I have created the task branch 3145a. The last revision is 11072.
I discovered that any 'find by rowid/recid' first/...
Ovidiu Maxiniuc

07/14/2016

10:08 PM Feature #3145: implement _File._Template metadata support
Ovidiu Maxiniuc wrote:
> I started the implementation. To correctly identify the searched by RECID/ROWID I adjusted ...
Eric Faulhaber

07/13/2016

05:25 PM Feature #3145: implement _File._Template metadata support
I started the implementation. To correctly identify the searched by RECID/ROWID I adjusted the @HQLPreprocessor.check... Ovidiu Maxiniuc
04:01 PM Feature #3145: implement _File._Template metadata support
Eric Faulhaber wrote:
> > Some additional pieces of information:
> > * the @_template@ seems to be not unknown, but...
Ovidiu Maxiniuc
03:44 PM Feature #3145: implement _File._Template metadata support
Ovidiu Maxiniuc wrote:
> [...]
> Because of these issues, I think we will stick to '-1' approach.
Agreed, this sho...
Eric Faulhaber
01:54 PM Feature #3145 (WIP): implement _File._Template metadata support
Probably the correct way to implement this to match P4GL behaviour is at import time. Or maybe an intermediary step i... Ovidiu Maxiniuc
11:27 AM Feature #3145: implement _File._Template metadata support
In terms of implementing this feature in P2J, it seems the @_File._Template@ field could always contain -1 for table ... Eric Faulhaber
11:25 AM Feature #3145: implement _File._Template metadata support
The @MetaFile@ DMO is converted from the @_File@ metadata table. It is populated at server startup with read-only dat... Eric Faulhaber
11:12 AM Feature #3145 (Closed): implement _File._Template metadata support
Eric Faulhaber
 

Also available in: Atom