FWD » Core Development » Database

05/20/2024

03:20 PM Bug #7473: rewrite toString() implementation for Dataset, StaticTempTable and TempTableBuilder to...

Review of 7473a, r15210.
The majority of the issues from previous review were addressed, I have not seen any logic... Ovidiu Maxiniuc

02:32 PM Bug #8593 (Internal Test): H2 performance improvement for table 'truncate by multiplex'

The changes seem logical. I think the code is OK. Ovidiu Maxiniuc

10:24 AM Bug #8593: H2 performance improvement for table 'truncate by multiplex'

Ovidiu: Please review. Greg Shah

03:46 AM Bug #8593: H2 performance improvement for table 'truncate by multiplex'

8593d needs a review first. Alexandru Lungu

05/17/2024

12:29 PM Bug #8593: H2 performance improvement for table 'truncate by multiplex'

Is there any further review needed for this or do we just need testing? Greg Shah

05:13 AM Bug #8593: H2 performance improvement for table 'truncate by multiplex'

Committed 8593d/rev. 15206 to fix #8593-54. It contains the patch from #8593-56.
Recap: there was an issue on datas... Alexandru Lungu

05/15/2024

04:12 PM Bug #8593: H2 performance improvement for table 'truncate by multiplex'

Greg Shah wrote:
> This resolves the regression documented in #7143-900?
Yes Constantin Asofiei

03:53 PM Bug #8593: H2 performance improvement for table 'truncate by multiplex'

This resolves the regression documented in #7143-900? Greg Shah

03:07 PM Bug #8593: H2 performance improvement for table 'truncate by multiplex'

Branch 8593c was merged to trunk revision 15212 and archived.
Branch 8593c_h2 was merged to fwd-h2 trunk revision ... Constantin Asofiei

02:55 PM Bug #8593: H2 performance improvement for table 'truncate by multiplex'

Greg Shah wrote:
> You can merge to trunk now.
Starting. Constantin Asofiei

02:53 PM Bug #8593: H2 performance improvement for table 'truncate by multiplex'

You can merge to trunk now. Greg Shah

02:52 PM Bug #8593: H2 performance improvement for table 'truncate by multiplex'

ETF testing passed, the original #7143-903 is fixed, and another app works OK with this. Constantin Asofiei

04:17 AM Bug #8593: H2 performance improvement for table 'truncate by multiplex'

Reset %Done. Alexandru Lungu

05:55 AM Bug #7473: rewrite toString() implementation for Dataset, StaticTempTable and TempTableBuilder to...

The modified version of
@RecordBuffer.java - sqlTableContentJson@... Eduard Baciu

03:32 AM Bug #7473: rewrite toString() implementation for Dataset, StaticTempTable and TempTableBuilder to...

Rebased branch 7473a to trunk rev. 15208. Current revision at 15209. Andrei Iacob

05/14/2024

04:31 PM Bug #7473: rewrite toString() implementation for Dataset, StaticTempTable and TempTableBuilder to...

I have just notice that a branch 7473a already exists. It was not mentioned in the task so I assumed the changes are ... Ovidiu Maxiniuc

03:00 PM Bug #7473: rewrite toString() implementation for Dataset, StaticTempTable and TempTableBuilder to...

Review of code from #7473-12:
* the overall implementation is good. Nearly all of the notes below are either to incr... Ovidiu Maxiniuc

02:32 PM Bug #8769 (New): BIND argument passing for DATASET, TABLE, DATASET-HANDLE, TABLE-HANDLE arguments...

Constantin Asofiei

02:11 PM Bug #8593: H2 performance improvement for table 'truncate by multiplex'

I've uploaded 1.48 to projsrv01 and upgraded the version in rev 15206.
I'll run ETF and test with another customer... Constantin Asofiei

01:52 PM Bug #8593: H2 performance improvement for table 'truncate by multiplex'

I have reviewed the changes from 8593c/rev. 15205. Good job!
Is there a reason for downgrading the percentage done... Ovidiu Maxiniuc

09:33 AM Bug #8593: H2 performance improvement for table 'truncate by multiplex'

Committed 8593c/rev. 15205 assessing the review from Ovidiu. Alexandru Lungu

09:10 AM Bug #8593: H2 performance improvement for table 'truncate by multiplex'

Constantin, please review 8593c_h2 changes. If they are OK, please upload it to the GCD repository.
Alexandru Lungu

05/13/2024

03:34 PM Bug #8593: H2 performance improvement for table 'truncate by multiplex'

Greg Shah wrote:
> Ovidiu/Eric: Please review 8593c.
I am OK with the code. A few of notes (cleanup/low priority)... Ovidiu Maxiniuc

03:10 PM Bug #8593: H2 performance improvement for table 'truncate by multiplex'

These are the changes that unblocked me:... Alexandru Lungu

02:51 PM Bug #8593: H2 performance improvement for table 'truncate by multiplex'

Alexandru, I don't like leaving 'allocated records' with no meaning in H2. Can we explicitly clear the primary key f... Constantin Asofiei

02:40 PM Bug #8593: H2 performance improvement for table 'truncate by multiplex'

I am also having a hard time tracking down an issue with the truncate now (not related to my changes in 8593c/8593c_h... Alexandru Lungu

01:27 PM Bug #8593: H2 performance improvement for table 'truncate by multiplex'

I committed 8593c_h2/rev. 50: Allowing forced reclaiming only for NO-UNDO tables. Otherwise, on a rollback, we may ha... Alexandru Lungu

12:15 PM Bug #8593: H2 performance improvement for table 'truncate by multiplex'

Eric, I am starting the review process in the next minutes. Please let me know if you are already in the process. Ovidiu Maxiniuc

09:50 AM Bug #8593: H2 performance improvement for table 'truncate by multiplex'

I committed now 8593c/rev. 15204. This includes a requirement to use in-DB PK mapping if the table has normalized ext... Alexandru Lungu

09:14 AM Bug #8593: H2 performance improvement for table 'truncate by multiplex'

Ovidiu/Eric: Please review 8593c.
This is quite Urgent since it is to resolve a regression in a customer applicati... Greg Shah

10:26 AM Feature #8756: Modifyable database comment string must support double quoted values

Modifyable database comment string must support double quoted values.
This is needed, because for example Label, Col... Tijs Wickardt

10:16 AM Feature #8756 (New): Modifyable database comment string must support double quoted values

Tijs Wickardt

04:34 AM Bug #7473: rewrite toString() implementation for Dataset, StaticTempTable and TempTableBuilder to...

Ovidiu, please provide a second review for the changes. Alexandru Lungu

05/12/2024

02:38 PM Bug #8593 (Review): H2 performance improvement for table 'truncate by multiplex'

Committed 8593c_h2/rev. 48 and 8593c/rev. 15203. Contains the following:
* H2 support for @NEXT PK FOR (<table-nam... Alexandru Lungu

05/08/2024

10:46 AM Bug #8593: H2 performance improvement for table 'truncate by multiplex'

Constantin Asofiei wrote:
> This is a test where it gets into an infinite loop:
> [...]
>
> This can be expanded... Alexandru Lungu

09:56 AM Bug #8593: H2 performance improvement for table 'truncate by multiplex'

This is a test where it gets into an infinite loop:... Constantin Asofiei

09:38 AM Bug #8593 (WIP): H2 performance improvement for table 'truncate by multiplex'

Timeline:
1. I was thinking of replacing the sequence based PK generator used by @FastCopyHelper@ with a more cust... Alexandru Lungu

05/02/2024

03:56 PM Bug #8593 (Test): H2 performance improvement for table 'truncate by multiplex'

Branch 8593b was merged to trunk rev 15189 and archived. Constantin Asofiei

03:33 PM Bug #8593 (Merge Pending): H2 performance improvement for table 'truncate by multiplex'

You can merge to trunk. Greg Shah

03:30 PM Bug #8593: H2 performance improvement for table 'truncate by multiplex'

8593b passed ETF testing. Constantin Asofiei

01:49 PM Bug #8593: H2 performance improvement for table 'truncate by multiplex'

Code Review Task Branch 8593b.
I do not see anything wrong with the code (r15187-). Ovidiu Maxiniuc

12:47 PM Bug #8593: H2 performance improvement for table 'truncate by multiplex'

Code Review Task Branch 8593b Revision 15179
The @LowLevelSocketImpl@ changes look good.
Eric/Ovidiu: Please lo... Greg Shah

10:49 AM Bug #8593 (Internal Test): H2 performance improvement for table 'truncate by multiplex'

Created task branch 8593b from trunk rev 15186. Contains regression fixes (mixed):
* revno: 15190 - Fixed regressi... Constantin Asofiei

04/29/2024

03:16 PM Bug #8703: NO-UNDO option at DMO must be removed

Super cool if it works.
As I wrote in #8703-6 I agree that "the attribute must be removed from the DMO". Luckily, ... Ovidiu Maxiniuc

02:34 PM Bug #8703: NO-UNDO option at DMO must be removed

Ovidiu Maxiniuc wrote:
> Note that this method already exists. We only need to emit the right parameter. And test wh... Constantin Asofiei

02:32 PM Bug #8703: NO-UNDO option at DMO must be removed

Constantin Asofiei wrote:
> The @DmoMeta.noUndo@ option needs to be refactored so that it uses the actual temp-table... Ovidiu Maxiniuc

10:59 AM Bug #8703: NO-UNDO option at DMO must be removed

Assume you have this test:... Constantin Asofiei

10:51 AM Bug #8703 (New): NO-UNDO option at DMO must be removed

Constantin Asofiei

04/26/2024

07:52 AM Bug #8593 (Test): H2 performance improvement for table 'truncate by multiplex'

8593a was merged to trunk rev 15169 and archived.
8593a_h2 was merged to fwd-h2 rev 46 and archived. Constantin Asofiei

07:39 AM Bug #8593: H2 performance improvement for table 'truncate by multiplex'

You can go ahead with the merge of 8593a and 8636g. Greg Shah

02:37 AM Bug #8593 (Merge Pending): H2 performance improvement for table 'truncate by multiplex'

Constantin Asofiei

02:06 AM Bug #8593 (Internal Test): H2 performance improvement for table 'truncate by multiplex'

Yes. I had to upgrade to latest 6667i (after recent rebase), reconvert are set a new baseline. After, I patched @(859... Alexandru Lungu

04/25/2024

07:17 PM Bug #8683: SQL operations not saved when session is closed

In a customer application we encountered a case when SQL statements which apparently were executed were not actually ... Ovidiu Maxiniuc

07:04 PM Bug #8683 (New): SQL operations not saved when session is closed

Ovidiu Maxiniuc

06:48 PM Bug #6492: problems with dynamic queries for meta tables

This particular issue was fixed in 8437b/15175, by qualifying the table name with its database (except for temporary ... Ovidiu Maxiniuc

04:27 PM Bug #8593: H2 performance improvement for table 'truncate by multiplex'

Alexandru, please let me know if you managed to run ChUI - I'd like to merge these tomorrow. Constantin Asofiei

05:30 AM Bug #8593: H2 performance improvement for table 'truncate by multiplex'

You can test them both (8593a + 8636g). I've uploaded fwd-h2 1.46 and 8593a rev 15161 has the change in build.gradle... Constantin Asofiei

05:00 AM Bug #8593: H2 performance improvement for table 'truncate by multiplex'

> ETF testing passed. Alexandru, if you can run a ChUI regression testing with this and 8363g, please let me know.
... Alexandru Lungu

03:18 AM Bug #8593: H2 performance improvement for table 'truncate by multiplex'

Constantin Asofiei wrote:
> Alexandru, please review 8593a_h2 rev 49/50 and 8593a rev 15158. I'll need to re-test t... Constantin Asofiei

04/24/2024

10:51 AM Bug #8593: H2 performance improvement for table 'truncate by multiplex'

Alexandru, please review 8593a_h2 rev 49/50 and 8593a rev 15158. I'll need to re-test these changes. Constantin Asofiei

08:36 AM Bug #8593: H2 performance improvement for table 'truncate by multiplex'

Alexandru Lungu wrote:
> This is a huge thing. Removing a batch will make the @MultiplexScanIndex@ quite unstable. I... Constantin Asofiei

08:30 AM Bug #8593: H2 performance improvement for table 'truncate by multiplex'

Constantin Asofiei wrote:
> I need to double-check for undoable temp-tables. The case I'm thinking is a @empty-temp... Alexandru Lungu

07:45 AM Bug #8593: H2 performance improvement for table 'truncate by multiplex'

Alexandru Lungu wrote:
> Oh, the invariant I was talking about is @removed.cardinality == 0@ when killing a multiple... Constantin Asofiei

04:24 AM Bug #8593: H2 performance improvement for table 'truncate by multiplex'

Constantin Asofiei wrote:
> Alexandru Lungu wrote:
> > Do you mean that the invariant was broken and now it was fix... Alexandru Lungu

04:10 AM Bug #8593: H2 performance improvement for table 'truncate by multiplex'

Alexandru Lungu wrote:
> Do you mean that the invariant was broken and now it was fixed by @clearPrimaryKey@? I unde... Constantin Asofiei

03:46 AM Bug #8593: H2 performance improvement for table 'truncate by multiplex'

Constantin Asofiei wrote:
> > * @rowCount -= removed.cardinality;@ is something that is theoretical irrelevant. The ... Alexandru Lungu

02:19 AM Bug #8593: H2 performance improvement for table 'truncate by multiplex'

Alexandru Lungu wrote:
> The FWD direct-access changes are OK!
> Also, getting rid of the @forceDelete@ is good, bu... Constantin Asofiei

04/23/2024

10:47 AM Bug #8593: H2 performance improvement for table 'truncate by multiplex'

The FWD direct-access changes are OK!
Also, getting rid of the @forceDelete@ is good, but requires extensive testing... Alexandru Lungu

09:11 AM Feature #7960: Allow query logs to be collected in a H2 database

Changes are now on branch 7960a, rev 15157.
Regarding your concern: *Make sure that this kind of logging is not happ... Ioana-Cristina Prioteasa

06:28 AM Feature #7960: Allow query logs to be collected in a H2 database

Review of 7960a:
* For @P2JLoggingDatabaseHelper@ construct:
** Separate the connection from statement execution:... Alexandru Lungu

06:05 AM Feature #7960 (Review): Allow query logs to be collected in a H2 database

Ioana-Cristina Prioteasa

06:05 AM Feature #7960 (WIP): Allow query logs to be collected in a H2 database

Ioana-Cristina Prioteasa

06:04 AM Feature #7960: Allow query logs to be collected in a H2 database

I added the necessary modifications to support this feature, changes are now on branch 7960a, rev 15156. Ioana-Cristina Prioteasa

04:25 AM Feature #7366: improve performance of buffer.fill

Ovidiu Maxiniuc wrote:
> I think I understand the idea: if the same query can be reused for a child buffer, it does ... Constantin Asofiei

04/22/2024

12:36 PM Feature #7366: improve performance of buffer.fill

Review of 8363g, r15157/8.
I think I understand the idea: if the same query can be reused for a child buffer, it d... Ovidiu Maxiniuc

09:20 AM Feature #7366: improve performance of buffer.fill

Eric/Ovidiu: please review 8363g rev 15158. Constantin Asofiei

08:03 AM Feature #7366: improve performance of buffer.fill

Changes related to this are in 8363g rev 15158: Allow the query to be reset to its initialization state, so the same ... Constantin Asofiei

09:01 AM Bug #7473 (Review): rewrite toString() implementation for Dataset, StaticTempTable and TempTableB...

I modified the code following your advices and managed to implement "getDataAsJson" method for "DataSet" as well.
... Eduard Baciu

02:44 AM Bug #8593 (Review): H2 performance improvement for table 'truncate by multiplex'

Created task branch 8593a from trunk rev 15157, with:
* For a NEW temp record which was not flushed and is being del... Constantin Asofiei