Activity
From 05/12/2014 to 06/10/2014
06/10/2014
- 11:20 AM Feature #1789: implement the toggle-box widget
- Code Review 0610a
It looks good. - 11:17 AM Feature #1789: implement the toggle-box widget
- Implemented error message and clearing other questions.
Start planning to implement runtime processing. - 10:30 AM Feature #1789: implement the toggle-box widget
- Code Review 0609b
1. The GenericWidget.isChecked()/setChecked() methods should simply execute: @throw new RuntimeE...
06/09/2014
- 07:02 PM Feature #1789: implement the toggle-box widget
- Added stubs for compiling the converted code. The message for @UNKNOWN@ set value is not added yet.
The question:
... - 05:54 PM Feature #1789: implement the toggle-box widget
- > Please test how unknown value works for the CHECKED attribute and implement it in ToggleBoxWidget.setChecked(logica...
- 04:41 PM Feature #1789: implement the toggle-box widget
- Code Review 0609a
Please test how unknown value works for the CHECKED attribute and implement it in @ToggleBoxWidg... - 04:40 PM Feature #1789: implement the toggle-box widget
- > 1. To define isChecked() to the CommonWidget interface
Yes, you certainly need to add stubbed support for the CH... - 04:30 PM Feature #1789: implement the toggle-box widget
- Yes, partially the conversion has already been implemented. Except handling of the @R/W@ attribute @CHECKED@. I have ...
- 03:04 PM Feature #1789: implement the toggle-box widget
- > CHUI does not make the extra space. I think in theory it is possible to simulate [ ] label layout in CHUI by defini...
- 12:01 PM Feature #2252: implement GUI client support
- Related to fonts: I've managed to find the formula used by 4GL to compute the @pixels-per-row@ and @pixels-per-column...
06/07/2014
- 07:44 AM Feature #1805: add missing UI method support
- Haste makes waste - It's about me in this case. I'm sorry.
I'm working on your notes. I'm really forgot about fie...
06/06/2014
- 07:57 PM Feature #1790: implement menu support
- For now, we can only do the ChUI version but it should be designed to add GUI later. There will be work on both conv...
- 07:53 PM Feature #1789: implement the toggle-box widget
- Testcases have been committed in bzr as 1146.
- 07:39 PM Feature #1789: implement the toggle-box widget
- The attached screens are to illustrate point #1 and #2 above. The @ATTR-SPACE@ does not affect the @TOGGLE-BOX@ looki...
- 01:28 PM Feature #1789: implement the toggle-box widget
- ATTR-SPACE can be put into the frame phrase:...
- 12:37 PM Feature #1789: implement the toggle-box widget
- > 1. Check if @ATTR-SPACE@ or other options can have an impact on the label positioning. All the labels in your examp...
- 10:20 AM Feature #1805: add missing UI method support
- Vadim Gindin wrote:
> The update passed regression testing and have committed to bzr. Rev #10545
Some issues about ... - 09:47 AM Feature #1805: add missing UI method support
- The update passed regression testing and have committed to bzr. Rev #10545
- 10:06 AM Feature #2146 (Closed): add support for FIRST-TAB-ITEM/NEXT-TAB-ITEM attributes (needed for server)
- 09:49 AM Feature #2146: add support for FIRST-TAB-ITEM/NEXT-TAB-ITEM attributes (needed for server)
- The update passed regression testing and have committed to bzr. Rev #10545
- 10:06 AM Feature #2144 (Closed): add minimum runtime support for methods (server)
06/05/2014
- 09:55 AM Feature #1789: implement the toggle-box widget
- Please add tests for the following cases:
1. Check if ATTR-SPACE or other options can have an impact on the label ... - 07:03 AM Feature #1789: implement the toggle-box widget
- After analyzing of the @ABL Reference@ book the testcases to demonstrate the behavior in all possible options accordi...
06/03/2014
- 02:33 AM Feature #1805: add missing UI method support
- PS: make sure to merge your update with the latest bzr version.
- 02:31 AM Feature #1805: add missing UI method support
- Review for 0602a:
# when we have APIs exposed via network servers (i.e. ClientExports), is best to avoid (de)seriali...
06/02/2014
- 05:20 PM Feature #2252: implement GUI client support
- Code Review 0602a
The code looks good. There are a few files that are missing the standard headers and so forth, ... - 03:20 AM Feature #2252: implement GUI client support
- Merged with the latest P2J updates (rules files).
- 05:02 PM Feature #1805: add missing UI method support
- I corrected implementation corresponding to the last notes. Please take a look.
- 09:32 AM Feature #1806 (Closed): implement UNLESS-HIDDEN
- 09:20 AM Feature #1806: implement UNLESS-HIDDEN
- The regression tasting has been passed. The update @...0530a@ has been committed in bzr as 10540.
- 09:15 AM Feature #1806: implement UNLESS-HIDDEN
- The CTRL-C testing has been completed. There are no regressions found. Had to run 3-way tests in a separate session t...
05/31/2014
- 08:37 PM Feature #1806: implement UNLESS-HIDDEN
- Code Review 0530a
I agree, the changes are safe. No additional testing is needed.
05/30/2014
- 07:38 PM Feature #1806: implement UNLESS-HIDDEN
- This update merges @UNLESS-HIDDEN@ changed with the recent code base. I think the tasks are pretty independent and me...
- 03:49 PM Feature #1806: implement UNLESS-HIDDEN
- The main part has been completed without regressions in two rounds. Continue with the CTRL-C part.
- 08:06 AM Feature #1789: implement the toggle-box widget
- For now, we don't have GUI support yet in the rest of the client. So you can only implement ChUI right now. Later o...
05/29/2014
- 05:54 PM Feature #1806: implement UNLESS-HIDDEN
- The conversion testing has been completed without any differences in converted Java code. Started the regression test...
- 04:26 PM Feature #1806: implement UNLESS-HIDDEN
- Code Review 0529a
The changes look good. Please get them regression tested. - 01:09 PM Feature #1806: implement UNLESS-HIDDEN
- Finally I have got all local tests passed. The new changes in update for review includes:
1. Removing @LabelImpl@ cl... - 05:52 PM Feature #1789: implement the toggle-box widget
- > Start by writing testcases to demonstrate the toggle-box behavior and all its options.
Do we need to cover only ... - 01:11 PM Feature #1805: add missing UI method support
- Vadim Gindin wrote:
> Constantin, thank you for the good test. It really will be useful.
>
> Here are the problem... - 07:26 AM Feature #1805: add missing UI method support
- Constantin, thank you for the good test. It really will be useful.
Here are the problems I can formulate at this mom...
05/28/2014
- 04:21 PM Feature #1806: implement UNLESS-HIDDEN
- > If everything is working in your local tests, then you can go into regression testing (both conversion and runtime)...
- 03:37 PM Feature #1806: implement UNLESS-HIDDEN
- > The changes are good, except that the @hidden()@ method should be removed from @LabeledWidget@ instead of being com...
- 03:29 PM Feature #1806: implement UNLESS-HIDDEN
- Code Review 0528b
The changes are good, except that the @hidden()@ method should be removed from @LabeledWidget@ i... - 02:59 PM Feature #1806: implement UNLESS-HIDDEN
- > Yes, please do explicitly cast it. Otherwise it is confusing to future readers/maintainers of the code.
OK. The ... - 01:49 PM Feature #1806: implement UNLESS-HIDDEN
- > If not add hidden() to LabeledWidget - we will need explicit casting fin to some class that have hidden() inside th...
- 01:42 PM Feature #1806: implement UNLESS-HIDDEN
- > 1. The hidden() method of LabeledWidget is already present in the Widget interface. LabeledDataContainer extends Fi...
- 12:49 PM Feature #1806: implement UNLESS-HIDDEN
- Code Review 0528a
I like the approach. My only questions:
1. The @hidden()@ method of @LabeledWidget@ is alrea... - 10:35 AM Feature #1806: implement UNLESS-HIDDEN
- The fix for hidden widgets has been added to the update.
The goal is to suppress label text drawing for hidden wid... - 03:54 PM Feature #1789: implement the toggle-box widget
- Start by writing testcases to demonstrate the toggle-box behavior and all its options.
Then add conversion support... - 12:58 PM Feature #1805: add missing UI method support
- Vadim Gindin wrote:
> Actually I found that FrameWidget has the frame property, that can be used for that case. I on...
05/27/2014
- 04:34 PM Feature #1806: implement UNLESS-HIDDEN
- Code Review 0523a
The changes look good.
> So this is the general bug in DISPLAY statement handling and if ther... - 04:15 PM Feature #1805: add missing UI method support
- First of all I actualized testcases. See folders MOVE_BEFORE_TAB_ITEM and first_tab_item.
Constantin Asofiei wrote... - 01:35 PM Feature #1805: add missing UI method support
- Vadim Gindin wrote:
> Here is the first working variant. It works for simple cases (without nested frames and with o...
05/26/2014
- 04:25 PM Feature #1805: add missing UI method support
- Here is the first working variant. It works for simple cases (without nested frames and with only one field-group). F...
05/23/2014
- 04:32 PM Feature #1806: implement UNLESS-HIDDEN
- Updated testcases for @DISPLAY@ statement. Looks like the problem with @DISPLAY UNLESS-HIDDEN@ is not related to @UNL...
- 03:07 PM Feature #1806: implement UNLESS-HIDDEN
- Update for review with adding minimum level of safety checking. The modified widget list will be passed to the usual ...
- 07:34 AM Feature #2252: implement GUI client support
- The package contains the changes and new classes used to implements CREATE WINDOW statement. So far the following iss...
05/22/2014
- 07:05 PM Feature #1806: implement UNLESS-HIDDEN
- Reattached the srceen shot for issue.
- 07:01 PM Feature #1806: implement UNLESS-HIDDEN
- > Make sure to implement this too if we don't already support it.
OK. The second drop for today contains runtime m... - 02:59 PM Feature #1806: implement UNLESS-HIDDEN
- Code Review 0522a
The changes look good.
> Also the statement ENABLE ALL WITH FRAME... sets the HIDDEN flag to ... - 01:13 PM Feature #1806: implement UNLESS-HIDDEN
- This fix for your review is conversion rule change that allow the @UNLESS-HIDDEN@ option to be properly converted for...
- 12:00 PM Feature #1806: implement UNLESS-HIDDEN
- Currently only @DISPLAY@ and @ENABLE@ are supported with @UNLESS-HIDDEN@ option on the conversion level. For other st...
- 10:16 AM Feature #1806: implement UNLESS-HIDDEN
- The testcases executed in 4GL under Linux and screenshots uploaded. Yes, you are right, the @HIDDEN@ flag as @TRUE@ e...
- 10:07 AM Feature #2252: implement GUI client support
- Code Review 0522b
It looks good.
> 2. Could you please offer more details? What means "implement the WindowGuiI... - 09:59 AM Feature #2252: implement GUI client support
- For ChUI interface the status and message area are implemented as widgets (StatusLine instances)
To keep the compati... - 03:55 AM Feature #2252: implement GUI client support
- 1. The GuiScreen interface extends ScreenDriver interface.
2. Could you please offer more details? What means "imp... - 08:25 AM Feature #2308: remote client launch
- Doesn't the 4GL appserver implementation have some features in this regard? We should at least document their basic ...
- 02:57 AM Feature #2308: remote client launch
- The P2J Server should have no configuration/restriction on how many P2J clients act as remote launchers and the machi...
- 02:15 AM Feature #1805: add missing UI method support
- Greg Shah wrote:
> > I don't recall and can't find a way of jumping from frame F1 to frame F2 (both with enabled wid...
05/21/2014
- 02:30 PM Feature #1805: add missing UI method support
- > I don't recall and can't find a way of jumping from frame F1 to frame F2 (both with enabled widgets) just by pressi...
- 02:09 PM Feature #1805: add missing UI method support
- Vadim, some thoughts:
# I don't recall and can't find a way of jumping from frame F1 to frame F2 (both with enabled ... - 09:13 AM Feature #1805: add missing UI method support
- > At this moment I didn't find such test case.
That is good news.
> I don't feel free with terms. Could you des... - 02:23 PM Feature #1783 (Closed): properly handle empty UNDERLINE statements
- 02:15 PM Feature #1783: properly handle empty UNDERLINE statements
- The update @0516a@ has been committed to bzr as 10536.
- 01:56 PM Feature #1783: properly handle empty UNDERLINE statements
- Finally I have finished @CTRL-C@ testing with all passed results. Not in single run.due to multiple false negative re...
- 12:40 PM Feature #2252: implement GUI client support
- Code Review 0521a
Wow! Very cool. I like it.
Some thoughts:
1. I would like the GUI screen driver to be desi... - 11:55 AM Feature #2252: implement GUI client support
- I've implemented a first skeleton version for drawing WINDOW widgets in GUI interfaces.
I attached a picture with th... - 10:38 AM Feature #2308: remote client launch
- To be clear, this special launcher client would be started on the remove system and it would be configured to connect...
- 10:19 AM Feature #2308: remote client launch
- Create a special P2J client that is a dedicated client process launcher. This client must be able to run on any arbi...
- 10:14 AM Feature #2308 (Closed): remote client launch
- 10:13 AM Feature #2307: enable skinning of the web client login page
- The ui/client/chui/driver/web/chui_web.html needs to allow some basic customization by a customer. The following sho...
- 10:01 AM Feature #2307 (New): enable skinning of the web client login page
- 09:58 AM Feature #2306: add copy/paste support to the web client
- This is not a 4GL feature, but rather it is meant to provide a mechanism that duplicates what is possible in normal t...
- 09:54 AM Feature #2306 (Closed): add copy/paste support to the web client
- 09:27 AM Feature #1806: implement UNLESS-HIDDEN
- The UNLESS-HIDDEN option should be fully implemented for the following language statements:
DISABLE
DISPLAY
ENAB...
05/20/2014
- 04:40 PM Feature #1805: add missing UI method support
- At this moment I didn't find such test case. I don't feel free with terms. Could you describe how do you define z-ord...
- 11:35 AM Feature #1805: add missing UI method support
- Before you spend additional time on implementation, please post a testcase here which would break in P2J because the ...
- 02:17 PM Feature #2252: implement GUI client support
- On CTRL-C the entire set of Windows are cleared in GUI.
- 12:27 PM Feature #2252: implement GUI client support
- > I think that a best idea is to clear also the windowRegistry whenever the DEFAULT_WINDOW is create (default constru...
- 12:06 PM Feature #2252: implement GUI client support
- Initially Window class had only the default constructor. The init() method was initially the body of the default cons...
- 11:26 AM Feature #2252: implement GUI client support
- Code Review 0516b
The changes look good. I only have one question: why were the @local.set(null);@ and @config = ...
05/19/2014
- 08:20 AM Feature #1783: properly handle empty UNDERLINE statements
- Code Review 0516a
I am fine with the changes. When CTRL-C processing passes, please check it in and distribute it.
05/18/2014
- 09:09 AM Feature #1805: add missing UI method support
- I don't fully understand the real link between z-order and tab order. Definitely it really exists and it complex. I ...
- 11:07 PM Feature #1783: properly handle empty UNDERLINE statements
- The main part completed without regressions in a single run. Continue testing with @CTRL-C@ part.
05/17/2014
- 08:39 PM Feature #1783: properly handle empty UNDERLINE statements
- Sorry, the suggested fix does not work. Need to check @ThinClient@ redirection, not simple @Frame@ one. The fix has b...
05/16/2014
- 07:52 PM Feature #1783: properly handle empty UNDERLINE statements
- The regression has been found. Testcase TC-ITEM-MASTER-103 the difference in page size for report generation. The exp...
- 02:30 PM Feature #1783: properly handle empty UNDERLINE statements
- The conversion test completed. The converted sources are binary equal. Continue with runtime regression testing.
- 11:47 AM Feature #1783: properly handle empty UNDERLINE statements
- > So we can start the regression testing and fix the problems with UP(discovered in note 25) as another task. What d...
- 10:48 AM Feature #1783: properly handle empty UNDERLINE statements
- Greg Shah wrote:
...
>
> The primary issue here is that you are not really exercising the new code very much. Tr... - 08:30 AM Feature #1783: properly handle empty UNDERLINE statements
- > The only exception is P2J does not display the warning message that the Y coord can not be negative while 4GL displ...
- 08:47 PM Feature #1783: properly handle empty UNDERLINE statements
- Well, the testcase to partially break implementation:...
- 02:23 PM Feature #2252: implement GUI client support
- When a WindowWidget option is changed the window configuration file should be send down to the client via LogicalTerm...
- 01:08 PM Feature #2252: implement GUI client support
- > in Windows, is there a way to intercept gdi32.dll API calls?
Yes, there are some tools out there. For example:
... - 10:52 AM Feature #2252: implement GUI client support
- Greg, I keep forgetting to mention something about font metrics, so here it is: in Windows, is there a way to interce...
- 10:04 AM Feature #2252: implement GUI client support
- Here are my latest changes:
1. On server side I used ID's from the same address space like frames. This offer a wi... - 01:18 PM Bug #2303: Incorrect UP statement handling with underlined widgets
- The @UP@ command for down frames with underlined widgets works incorrectly in P2J. The 4GL screens step by step and t...
- 01:16 PM Bug #2303 (New): Incorrect UP statement handling with underlined widgets
- 11:55 AM Feature #2302: Warning message when setting widget row to negative value
- The 4GL displays the warning message when setting row to the negative value is requested. The testcase and screenshot...
- 11:52 AM Feature #2302 (New): Warning message when setting widget row to negative value
- 03:44 AM Feature #1805: add missing UI method support
- 1. Methods @moveToTop@ and @moveToBottom@ change the real place of the widget in the displaying order. They really mo...
05/15/2014
- 06:06 PM Feature #1783: properly handle empty UNDERLINE statements
- I have tested two possibilities:
- perform @UP@ command for the first row in down frame several times.
- manual set... - 11:14 AM Feature #1783: properly handle empty UNDERLINE statements
- > In other words: try to break this implementation. Report your results here. If you cannot break it, then go ahead i...
- 10:57 AM Feature #1783: properly handle empty UNDERLINE statements
- > can produce screen mess
If our clipping implementation is working properly, then a negative y value should not ... - 10:41 AM Feature #1783: properly handle empty UNDERLINE statements
- > I do wonder what happens if the Point.y value of the widget becomes negative during @relocateComponent()@. Are ther...
- 10:23 AM Feature #1783: properly handle empty UNDERLINE statements
- Code Review 0514a
The changes look good. I do wonder what happens if the Point.y value of the widget becomes nega... - 08:10 PM Feature #1783: properly handle empty UNDERLINE statements
- The suggested fix for you to review merged with the recent code base. The idea is to make full down processing on the...
- 01:53 PM Feature #2252: implement GUI client support
- Indeed windows are like other widgets and on the client side we could use the WidgetRegistry to register dynamic wind...
- 12:20 PM Feature #2252: implement GUI client support
- Code Review 0515a
My only concern is in regard to the ID processing (and the new @WindowRegistry@ class). Today, ... - 11:08 AM Feature #2252: implement GUI client support
- I designed a flow the assign unique ID's to a window dynamic created and register the new created window on server si...
- 04:37 AM Feature #2252: implement GUI client support
- Marius Gligor wrote:
> Should We move the implementation for setParentHandle and getParentHandle to BaseEntity?
Fro... - 08:46 AM Feature #1805: add missing UI method support
- > I think It would be wrong to use @AbstractContainer.widgets@ order for the focus management.
Perhaps. But the c... - 03:15 AM Feature #1805: add missing UI method support
- I think It would be wrong to use @AbstractContainer.widgets@ order for the focus management. We really have two order...
05/14/2014
- 06:51 PM Feature #1783: properly handle empty UNDERLINE statements
- Finally I have the fix. The client side modification is not enough. We need to perform implicit @down@ processing on ...
- 04:12 PM Feature #2252: implement GUI client support
- > Should We move the implementation for setParentHandle and getParentHandle to BaseEntity?
I will let Constantin r... - 04:03 PM Feature #2252: implement GUI client support
- Code Review 0514a
Everything looks good. - 09:36 AM Feature #2252: implement GUI client support
- I added a new layer of inheritance PaneEntity and PaneConfig which holds shared options for DIALOG, FRAME and WINDOW ...
- 09:33 AM Feature #2286: design and implement basic GUI window widget support
- I added a new layer of inheritance PaneEntity and PaneConfig which holds shared options for DIALOG, FRAME and WINDOW ...
05/13/2014
- 03:50 PM Feature #1783: properly handle empty UNDERLINE statements
- > Do you have an update on this? It seems like you should be pretty close to a solution, based on your findings.
Y... - 03:10 PM Feature #1783: properly handle empty UNDERLINE statements
- Do you have an update on this? It seems like you should be pretty close to a solution, based on your findings.
- 02:19 PM Feature #2252: implement GUI client support
- Greg Shah wrote:
> 2. Constantin: is there any issue with the changing of the @setParent(Object)@ signature to @setP... - 11:20 AM Feature #2252: implement GUI client support
- Code Review 0513a
This is really good. Some feedback:
1. Some of the changes in BaseConfig are only shared bet... - 10:35 AM Feature #2252: implement GUI client support
- 1. Here are the changes that I made so far to implements the CREATE WINDOW on server side.
On each option assigned t... - 10:18 AM Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
- > Greg: I think we should wait for the delivery of the GUI sources before continuing, and run the reports on that; be...
- 10:14 AM Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
- Vadim, some more thoughts about how current P2J works and what is missing (for down frames). Calling frame.<widget-n...
- 05:38 AM Feature #1805: add missing UI method support
- Added additional tests, 08-16 for the case with nested frames. All works as expected
Also available in: Atom