FWD » Core Development » User Interface

09/12/2014

04:34 PM Feature #2252: implement GUI client support

Constantin Asofiei wrote:
> Vadim Gindin wrote:
> >I'm sure about all of them except "statusStack". Could you pleas... Vadim Gindin

03:56 PM Feature #2252: implement GUI client support

Hynek Cihlar wrote:
> // At the moment it is unknown to me whether the coordinate conversion and
> ... Constantin Asofiei

03:20 PM Feature #2252: implement GUI client support

Greg Shah wrote:
> > Should the flag be then somehow cached? The most logical place should probably be the widget in... Hynek Cihlar

01:58 PM Feature #2252: implement GUI client support

Greg Shah wrote:
> The only issue with this is that every call takes a trip down to the client to call @OutputManage... Constantin Asofiei

01:54 PM Feature #2252: implement GUI client support

> (1) In the change set in the file Coordinate.java - // TODO: #2323 implement GUI coordinate rounding.
> GUI roundi... Greg Shah

01:22 PM Feature #2252: implement GUI client support

Code Review 0911a
The changes look good. Greg Shah

12:45 PM Feature #2252: implement GUI client support

I am attaching update to the work in progress of #2323. The change set resolves comments from review, resolves resolv... Hynek Cihlar

04:36 AM Feature #2252: implement GUI client support

Vadim Gindin wrote:
>I'm sure about all of them except "statusStack". Could you please describe its function and may... Constantin Asofiei

09/11/2014

07:02 PM Feature #2252: implement GUI client support

I'm working on status methods implementation. I'm going to move some fields from ThinClient to Window (or TitledWindo... Vadim Gindin

12:13 AM Feature #2252: implement GUI client support

Committed to revision 10606. Vadim Gindin

09:26 AM Feature #2333 (WIP): implement the GUI status line widget

Marius Gligor

09/10/2014

05:31 PM Feature #2252: implement GUI client support

Code Review 0905a
I am fine with the changes.
> But there was an exception. See error log (client_vig_26776.log... Greg Shah

05:01 PM Feature #2252: implement GUI client support

I was running regression testing several times. Made some fix. Here is the latest update. It passes regression testin... Vadim Gindin

12:26 PM Feature #2252: implement GUI client support

In regard to task #2333 (finish status area support), the following needs to be done:
* proper font/color usage
*... Greg Shah

09/08/2014

12:55 PM Feature #2252: implement GUI client support

> 1. In many places in this update, you are moving back to @int@ from @double@. A good example is @src/com/goldencod... Hynek Cihlar

10:34 AM Feature #2252: implement GUI client support

Code Review hc_upd20140907a.zip
I like the new @Coordinate@ helper class. Use of it makes clear to the reader tha... Greg Shah

09/07/2014

04:31 PM Feature #2252: implement GUI client support

Attached is the update of hc_upd20140831a. It resolves the issues from review at notes 184 and 188.
The most impo... Hynek Cihlar

09/05/2014

08:56 AM Feature #1791: implement dynamic UI support

> Sorry, that I'm meddling.
You are not meddling. You are CONTRIBUTING. Your questions help us make this project... Greg Shah

08:24 AM Feature #1791: implement dynamic UI support

Code Review 0904a
I'm fine with the changes. Greg Shah

04:48 AM Feature #1791: implement dynamic UI support

Sorry, that I'm meddling. Why your updates does not change @handle.getResourceId@ static method (and corresponding @R... Vadim Gindin

09/04/2014

07:49 PM Feature #1791: implement dynamic UI support

The today update for review includes:
1. Merge with the recent code base.
2. Fix for shared frame importing @Screen... Eugenie Lyzenko

10:31 AM Feature #2286 (Closed): design and implement basic GUI window widget support

Greg Shah

10:16 AM Feature #1793 (Closed): improve color support

Greg Shah

10:08 AM Feature #1793: improve color support

0904c Passed conversion and regression tests. Committed revision 10605. Marius Gligor

09:46 AM Feature #1793: improve color support

Code Review 0904c
It is good. Go ahead and check it in/distribute it. Greg Shah

09:31 AM Feature #1793: improve color support

Done. Marius Gligor

09:03 AM Feature #1793: improve color support

Code Review 0904b
I am OK with the changes and I do think they are safe enough to avoid further testing.
I have... Greg Shah

08:03 AM Feature #1793: improve color support

A minor change to log a message whenever colors cannot be mapped and are mapped by default to a 0 RGB value. Marius Gligor

07:44 AM Feature #1793: improve color support

The changes in 0903b passed both conversion and regression tests. However I didn't do the commits and distributions y... Marius Gligor

09/03/2014

07:26 PM Feature #1791: implement dynamic UI support

>My only question is whether the @ScreenBuffer(int frameId, int numWidgets)@ constructor is ever safe to use in the n... Eugenie Lyzenko

07:22 PM Feature #1791: implement dynamic UI support

Status update.
The next regression I've faced is in PO adding screen. This is the serious issue with shared frames... Eugenie Lyzenko

09:05 AM Feature #1791: implement dynamic UI support

Code Review 0901b
The changes look good and they do look more correct.
My only question is whether the @ScreenB... Greg Shah

04:54 PM Feature #2252: implement GUI client support

Greg Shah wrote:
> Code Review vig_upd20140901a.zip
>
> I am generally fine with this as an interim update.
>
... Vadim Gindin

09:15 AM Feature #2252: implement GUI client support

> 1. Place a standardized marker in a comment, which can be searched on to find all these places again. Something li... Hynek Cihlar

08:58 AM Feature #2252: implement GUI client support

Hynek Cihlar wrote:
> Greg Shah wrote:
> > Code Review hc_upd20140831a
> >
> > Wow, that is a lot of work! It to... Greg Shah

08:53 AM Feature #2252: implement GUI client support

> It shows window button on the task bar but does not show the window itself. Testcase window_parenting/pause.p. Bod... Greg Shah

08:48 AM Feature #2252: implement GUI client support

Code Review vig_upd20140901a.zip
I am generally fine with this as an interim update.
1. Can we make the window ... Greg Shah

12:12 PM Feature #1793: improve color support

> I have no other works to do on this task.
OK, please get this regression tested (both conversion and runtime).
... Greg Shah

11:58 AM Feature #1793: improve color support

I have no other works to do on this task.
Nevertheless they are other issues to implements like LOAD, USE, UNLOAD, ... Marius Gligor

11:49 AM Feature #1793: improve color support

Code Review 0903b
The changes look good. I like the more general approach to reading color tables from the server... Greg Shah

11:00 AM Feature #1793: improve color support

I fixed the issues reported on Code Review 0903a (note 39) Marius Gligor

10:04 AM Feature #1793: improve color support

Code Review 0903a
The changes look good.
1. WindowConfig is missing a history entry.
2. The call from the cl... Greg Shah

06:01 AM Feature #1793: improve color support

I did some changes inside @ColorTable@ class to load colors on a per user manner.
I've fixed also some javadoc texts. Marius Gligor

12:07 PM Feature #2384: implement custom color overrides for ChUI

This task is meant to allow the configuration of custom colors for ChUI as is possible in the 4GL using the protermca... Greg Shah

12:05 PM Feature #2384 (New): implement custom color overrides for ChUI

Greg Shah

09/02/2014

11:40 AM Feature #1793 (Review): improve color support

Here are my latest changes on color improvements:
- synchronization state between server and client.
- default syst... Marius Gligor

09:59 AM Feature #2252: implement GUI client support

Greg Shah wrote:
> Code Review hc_upd20140831a
>
> Wow, that is a lot of work! It took me many hours to review th... Hynek Cihlar

09:49 PM Feature #2252: implement GUI client support

Code Review hc_upd20140831a
Wow, that is a lot of work! It took me many hours to review that update. Generally, I... Greg Shah

09/01/2014

05:04 PM Feature #1791: implement dynamic UI support

Another update today for review. I've faced another issues with lost @UNINITIALIZED@ state. In this update all constr... Eugenie Lyzenko

02:21 PM Feature #1791: implement dynamic UI support

Code Review 0829a/b and 0901a
I am fine with the changes. Greg Shah

04:03 AM Feature #1791: implement dynamic UI support

The next update for your review.
Looks like I've found the issue resolution. We need to initialize the state map f... Eugenie Lyzenko

02:10 PM Feature #2252: implement GUI client support

I'm trying to test the following update with the last remarks and got strange behavior. It shows window button on the... Vadim Gindin

08/31/2014

06:06 PM Feature #2252: implement GUI client support

Attached are changes related to #2323 - refactor coordinate system and implement GUI coordinate support.
What's in... Hynek Cihlar

02:29 PM Feature #2252: implement GUI client support

I retested implicit pause cases and PAUSE BEFORE HIDE statement to research behavior of THIS-PROCEDURE:CURRENT-WINDOW... Vadim Gindin

08/29/2014

06:09 PM Feature #1791: implement dynamic UI support

Unfortunately at least one regression I have already found. Consider pressing 'V' from main menu.
The current screen... Eugenie Lyzenko

05:54 PM Feature #1791: implement dynamic UI support

These two updates for review contain fixed login related classes, including one from timco majic related sources. I m... Eugenie Lyzenko

09:17 AM Feature #1791: implement dynamic UI support

Code Review 0828a
I am fine with the changes. Greg Shah

09:09 AM Feature #1791: implement dynamic UI support

> all we need is to properly clean up after finish, correct?
You may also need these widgets to be in the @WidgetR... Greg Shah

08:05 PM Feature #1791: implement dynamic UI support

Update for review includes:
1. Renaming @ScreenBuffer@ helper method to bitwise AND the state.
2. Adding helper met... Eugenie Lyzenko

12:27 PM Feature #1793: improve color support

> I think that we have do some changes here in order to accommodate our needs for GUI drivers perhaps on another Redm... Greg Shah

12:18 PM Feature #1793: improve color support

1. The P2J implementation for LOAD, USE and UNLOAD statements is conforming with OpenEdge manual.
It works only if ... Marius Gligor

09:01 AM Feature #2252: implement GUI client support

Code Review 0827a
1. In @GuiOutputManager@ you ask @// TODO added to try. Fix this later. Was WindowConfig.SESSION... Greg Shah

08/28/2014

05:18 PM Feature #1791: implement dynamic UI support

> Please check all Authenticator implementations for how the widget IDs are computed.
Except GenericFrame(server s... Eugenie Lyzenko

02:29 PM Feature #1791: implement dynamic UI support

Eugenie Lyzenko wrote:
> 1. Consider the code @src/aero/timco/majic/security/LoginClient.java@.
Please check all A... Constantin Asofiei

11:48 AM Feature #1791: implement dynamic UI support

>3. Why do you have buffer.size() < size as a condition in ScreenBuffer.isValidId()?
Yes I had to put the describi... Eugenie Lyzenko

11:19 AM Feature #1791: implement dynamic UI support

> It has ID assignments completely different from new approach(and moreover it differs from old one too).
LoginCli... Greg Shah

11:03 AM Feature #1791: implement dynamic UI support

Code Review 0827a
1. In @ScreenBuffer@, you chose to start with an empty state map instead of one populated by UNI... Greg Shah

10:05 PM Feature #1791: implement dynamic UI support

Found a way to debug login screen locally by tunneling server port @3434@ and using @-i1@ instance to remote connecti... Eugenie Lyzenko

04:19 PM Feature #2252: implement GUI client support

6) StatusLineGuiImpl.draw is not called at all and message string is not displayed in the status line of any open win... Vadim Gindin

04:17 PM Feature #2252: implement GUI client support

I faced with the following problems.
1) We probably do not need to use contsant session window ID everywhere or we... Vadim Gindin

03:48 PM Feature #1793: improve color support

> Because system colors are not part of 4GL environment I think that system color table should be stored on server di... Greg Shah

03:32 PM Feature #1793: improve color support

Code Review 0828a
The code is fine. I like the direction it is moving. Greg Shah

12:55 PM Feature #1793: improve color support

> we need to ensure that .ini files can be specified for normal users, batch processes and appserver agents
Yes.
... Greg Shah

09:08 AM Feature #1793: improve color support

Here are my latest changes for COLOR-TABLE implementation.

1. The management of COLOR-TABLE is done now on server... Marius Gligor

04:30 AM Feature #1793: improve color support

Greg Shah wrote:
> As you note, there is no reason we can't use stanza-based INI files on non-Windows platforms. In... Constantin Asofiei

08/27/2014

06:51 PM Feature #1791: implement dynamic UI support

Some considerations and questions to discuss for inline widget ID calculation in current code. I have found new place... Eugenie Lyzenko

05:40 PM Feature #1791: implement dynamic UI support

This update for review includes:
1. Several fixes for @ThinClient.(get|set)ScreenBuffer()@ and @GenericFrame.getScre... Eugenie Lyzenko

09:56 AM Feature #1793: improve color support

Constantin Asofiei wrote:
> Marius Gligor wrote:
> > I found a conversion problem and cannot fix it. Both @COLOR-TA... Marius Gligor

07:06 AM Feature #1793: improve color support

Marius Gligor wrote:
> I found a conversion problem and cannot fix it. Both @COLOR-TABLE@ and @FONT-TBALE@ have a @N... Constantin Asofiei

06:34 AM Feature #1793: improve color support

I found a conversion problem and cannot fix it. Both @COLOR-TABLE@ and @FONT-TBALE@ have a @NUM-ENTRIES@ attribute.
... Marius Gligor

08/26/2014

05:46 AM Feature #2252: implement GUI client support

Greg Shah wrote:
> > About ca_upd20140808c.zip: as code touched by this update seems to be affected by other tasks, ... Constantin Asofiei

02:31 AM Feature #2381: implement PUT-KEY-VALUE COLOR (n | ALL)

Marius Gligor wrote:
> PUT-KEY-VALUE COLOR (n | ALL) is used to save COLOR-TABLE of current environment on a persist... Marius Gligor

02:28 AM Feature #2381 (New): implement PUT-KEY-VALUE COLOR (n | ALL)

Marius Gligor

08/25/2014

03:29 PM Feature #1793: improve color support

> 5. In P2J the COLOR-TABLE management is done on each environment on the client side. That's why all server API for ... Greg Shah

03:16 PM Feature #1793: improve color support

Code Review 0825a
I'm fine with the changes. Greg Shah

03:05 PM Feature #1793: improve color support

Code Review 0822b
1. Minor javadoc changes to @getLegacyPlatform()@:
@specify a legacy platform regarding the r... Greg Shah

02:47 PM Feature #1793: improve color support

If we decide to load and store custom environments also on server side like default environment we could move the cod... Marius Gligor

02:18 PM Feature #1793: improve color support

> In conclusion I think that we have to follow the same behaviour and implements a mechanism to save COLOR-TABLE some... Greg Shah

10:47 AM Feature #1793: improve color support

Here are my changes after your code review for 0814a on note 9.
Also I did new tests this time using @LOAD@ @USE@ an... Marius Gligor

10:58 AM Feature #1791: implement dynamic UI support

> The suggested fix is:
I don't see any reason to enter the @synchronized@ block. Entering it obtains the lock fo... Greg Shah

10:25 AM Feature #2252: implement GUI client support

> any widget resource requiring access to these attributes (from either server or client side) will interrogate the c... Greg Shah

10:09 AM Feature #2252: implement GUI client support

> About ca_upd20140808c.zip: as code touched by this update seems to be affected by other tasks, I think I should rel... Greg Shah

08/22/2014

04:14 PM Feature #1791: implement dynamic UI support

Two more issues has been found during testing:
1. NullPointer exception in code @LogicalTerminal.deregisterFrameCont... Eugenie Lyzenko

08:27 AM Feature #1791: implement dynamic UI support

Code Review 0821a
I'm fine with the changes. Let's get this through testing. You can fix the memory leak in the ... Greg Shah

06:42 AM Feature #1791: implement dynamic UI support

Greg Shah wrote:
> # @LT.releaseSharedFrame()@ is the only way that shared frames actually "go away" permanently. U... Constantin Asofiei

08:49 PM Feature #1791: implement dynamic UI support

Looks like I've found the root cause. It really the interference of new ID approach and old one. The method is @Widge... Eugenie Lyzenko

02:28 PM Feature #2252: implement GUI client support

About ca_upd20140808c.zip: as code touched by this update seems to be affected by other tasks, I think I should relea... Constantin Asofiei

02:26 PM Feature #2252: implement GUI client support

About note 157/158, the work for #2254 and sync'ing the server and client-side widget states. Unfortunately, there i... Constantin Asofiei

12:43 PM Feature #1793: improve color support

The attached archive @0822b@ contains implementation of @EnvironmentOps.getLegacyPlatform()@ Marius Gligor

11:03 AM Feature #1793: improve color support

Digging in the customer's @OE 10.2b@ environment I found the configuration file progress.ini which contains among oth... Marius Gligor

08:53 AM Feature #1793: improve color support

Code Review 0822a
The changes are fine.
> the code inside ColorSpec class is running only on the server side, ... Greg Shah

07:17 AM Feature #1793: improve color support

Here are my changes for COLOR phrase implementation as a result of your code review.
1. Regarding platform detecti... Marius Gligor

08/21/2014

01:38 PM Feature #2252: implement GUI client support

Committed to bzr with rev 10600. Vadim Gindin

01:17 PM Feature #2252: implement GUI client support

> Previous update passed regression testing. Can I commit it?
Yes, please do. Greg Shah

01:16 PM Feature #2252: implement GUI client support

Previous update passed regression testing. Can I commit it? Vadim Gindin

08:42 AM Feature #2252: implement GUI client support

Code Review 0821a
I like the way this is going. Moving the @Window@ functionality from @static@ to non-@static@ i... Greg Shah

04:35 AM Feature #2252: implement GUI client support

> What happens if CURRENT-WINDOW is unrealized?
DEFAULT-WINDOW is used
I've added some client implementation for ... Vadim Gindin

11:42 AM Feature #1793: improve color support

Code Review 0821a
I like the result. Some minor feedback:
1. All data members should be at the top of the clas... Greg Shah

11:17 AM Feature #1793: improve color support

I've created #2379 to capture the work item for adding color support to the native Windows console (ChUI) client. We... Greg Shah

10:58 AM Feature #1793: improve color support

The attached archive contains my changes which I made to implements COLOR phrase for ChUI interfaces.
The @protermca... Marius Gligor

11:16 AM Feature #2379 (New): implement color support in the Windows native console (ChUI) client

Greg Shah

11:15 AM Feature #2378: implements dos-hex-attribute of COLOR phrase

See notes 11 and 12 in #1793 for details of previous research. Greg Shah

08/20/2014

05:47 PM Feature #1793: improve color support

Enums have the advantage of being very concise in syntax and being easy to read/understand/use. The down side of usi... Greg Shah

05:44 PM Feature #1793: improve color support

Question from MAG:
ColorPalette should holds multiple entries depending on platform Linux or Windows. ColorPalette... Greg Shah

04:18 PM Feature #1791: implement dynamic UI support

The update certainly has a regressions in frame ID handling(on client side I guess). After main syman menu displaying... Eugenie Lyzenko

10:32 AM Feature #1791: implement dynamic UI support

Sorry, I did not remove @ClientIdHelper@ from old location, so 0820a has two files with same class. Repackaged in 082... Eugenie Lyzenko

09:46 AM Feature #1791: implement dynamic UI support

Code Review 0820a
I like the changes. Well done.
> If you do not mind I'll start the runtime regression testin... Greg Shah

09:42 AM Feature #1791: implement dynamic UI support

This update for your review moves the @INPUT_FRAME_ID@ constant to @WidgetId@ class. The @WIDGET_ID_RANGE_BEGIN@ now ... Eugenie Lyzenko

08:18 AM Feature #1791: implement dynamic UI support

> I think these widgets do not have the server side counterpart because they exist only at editing time.
Yes.
>... Greg Shah

09:15 AM Feature #2252: implement GUI client support

Code Review 0820a
The changes look fine.
> Implicit Pause behaves exactly as explicit: uses CURRENT-WINDOW.
... Greg Shah

02:27 AM Feature #2252: implement GUI client support

I've tested implicit pause cases, listed in the note №160. Implicit Pause behaves exactly as explicit: uses CURRENT-W... Vadim Gindin

08/19/2014

06:54 PM Feature #1791: implement dynamic UI support

Also I guess this artificial frame and fill-in will neither be in widget registry not the part of server side frame. ... Eugenie Lyzenko

06:46 PM Feature #1791: implement dynamic UI support

>Does it work? :) Please test it with standalone testcases, including shared frames.
Yes, but there is one little ... Eugenie Lyzenko

05:32 PM Feature #1791: implement dynamic UI support

Code Review 0819a
I like it.
Does it work? :) Please test it with standalone testcases, including shared fra... Greg Shah

03:42 PM Feature #1791: implement dynamic UI support

This update for your review includes:
1. Methods renaming for @registerWidgetIdObject()@, @deregisterWidgetIdObject(... Eugenie Lyzenko

05:55 AM Feature #1791: implement dynamic UI support

Eugenie Lyzenko wrote:
> >We can remove the @LT.activateSharedFrame()@ method completely.
>
> In this case we nee... Greg Shah

05:37 AM Feature #1791: implement dynamic UI support

>We can remove the @LT.activateSharedFrame()@ method completely.
In this case we need to move the work this method... Eugenie Lyzenko

10:41 PM Feature #1791: implement dynamic UI support

> The problem here is sharedframereg is a map of <id, GenericFrame> while widget registry is a map of <id, GenericWid... Greg Shah

01:41 PM Feature #2378 (New): implements dos-hex-attribute of COLOR phrase

Marius Gligor

12:53 PM Feature #1793: improve color support

These are very good findings.
> 8. I could not do tests using dos-hex-attribute on Windows ChUI (see 2-b) However ... Greg Shah

12:07 PM Feature #1793: improve color support

Here are my conclusion doing some "researches" on color implementation for ChUI and GUI interfaces on Linux OS/ Windo... Marius Gligor

08:37 PM Feature #1793: improve color support

> The valuse are stored on Windows registry and are used by Windows GUI widgets.
> I think that our GUI implementati... Greg Shah

08:34 PM Feature #1793: improve color support

Code Review 0814a
1. Line 463 of language_statements.rules has a reference to KW_FONT.
2. The progress.g change... Greg Shah

08/18/2014

07:45 PM Feature #1791: implement dynamic UI support

>The processing of LT.replaceFrame() probably needs to remap the new frame's contained widgets into the widget regist... Eugenie Lyzenko

07:22 PM Feature #1791: implement dynamic UI support

>11. Once the client has actually hidden the frame, it will notify the server and in the LT.applyChanges() method, ... Eugenie Lyzenko

05:43 PM Feature #1791: implement dynamic UI support

>I think the sharedframereg is NOT needed after your changes. It is only used to make sure that shared frame IDs are ... Eugenie Lyzenko

04:37 PM Feature #1791: implement dynamic UI support

Eugenie Lyzenko wrote:
> >5. The deregisterFrameContent() code should still have the locking implemented...
>
> Y... Greg Shah

04:35 PM Feature #1791: implement dynamic UI support

In regard to the shared frame processing, it is quite complex. I'm not sure that our basic approach is 100% correct.... Greg Shah

04:16 PM Feature #1791: implement dynamic UI support

>5. The deregisterFrameContent() code should still have the locking implemented...
You mean @private deregisterFra... Eugenie Lyzenko

01:10 PM Feature #1791: implement dynamic UI support

Code Review 0818a
1. Please rename the following:
@registerWidgetIdObject()@ to @registerWidget()@
@deregister... Greg Shah

09:51 AM Feature #1791: implement dynamic UI support

Adding some improvements in this update:
1. Deregister frame when it is destroyed
2. Adding static method to deregi... Eugenie Lyzenko

07:49 AM Feature #1791: implement dynamic UI support

Checking the code with frame related testcases I have found potential issues with widget registry. This is related to... Eugenie Lyzenko

04:50 PM Feature #2252: implement GUI client support

Code Review vig_upd20140815a.zip
The only thing I would like to see changed is to move the common @hWin@ processin... Greg Shah

12:57 PM Feature #2252: implement GUI client support

Greg Shah wrote:
> I will handle the code review for vig_upd20140815a.zip shortly.
>
> > Only following statement... Vadim Gindin

12:28 PM Feature #2252: implement GUI client support

I will handle the code review for vig_upd20140815a.zip shortly.
> Only following statements with BEFORE-HIDE are c... Greg Shah

08:01 AM Feature #2252: implement GUI client support

Greg Shah wrote:
>
> Also, do check in your testcases.
Due to the customer server outage I have committed the t... Hynek Cihlar

08/16/2014

06:24 PM Feature #1791: implement dynamic UI support

This update adds more cleanup for frame deregistration. Looks like we need to remove widgets even when the frame is m... Eugenie Lyzenko