FWD » Core Development » User Interface

09/24/2014

05:34 PM Feature #1791: implement dynamic UI support

> If something is not supported on conversion level(like RADIO-BUTTONS attribute for RADIO-SET widget) I can postpone... Greg Shah

05:13 PM Feature #1791: implement dynamic UI support

> OK, this all sounds like a reasonable approach. How quickly can you implement the necessary changes?
I guess if... Eugenie Lyzenko

04:41 PM Feature #1791: implement dynamic UI support

OK, this all sounds like a reasonable approach. How quickly can you implement the necessary changes? Greg Shah

01:11 PM Feature #1791: implement dynamic UI support

From the testing I did I can tell we certainly need tp change the @ScreenBuffer@ class. To be able to extent the cont... Eugenie Lyzenko

04:46 PM Feature #2323 (Closed): refactor coordinate system and implement GUI coordinate support

Greg Shah

02:19 PM Feature #2252: implement GUI client support

Greg Shah wrote:
> I agree. I will close #2323 unless you believe there is something else to do (outside of the add... Hynek Cihlar

10:49 AM Feature #2252: implement GUI client support

Code Review hc_upd20140924a.zip
Wow! Great work. That is a huge amount of change. Please go ahead and check it ... Greg Shah

10:31 AM Feature #2252: implement GUI client support

Code Review vig_upd20140924a.zip
The overall approach is correct. Eventually, some of this logic may be moved to ... Greg Shah

10:19 AM Feature #2252: implement GUI client support

For the #2323 please review the attached file.
- fixed initialization of GUI mode
- fixed AlertBox positioning in... Hynek Cihlar

04:43 AM Feature #2252: implement GUI client support

Here is the update with multi-window support for message methods. Following methods was moved from @ThinClient@ to @W... Vadim Gindin

09/23/2014

06:13 PM Feature #2334: implement the GUI message line widget

> 1. The implementation of GUI widgets still depends on coordinate conversion between pixels units and character unit... Greg Shah

06:07 PM Feature #2334: implement the GUI message line widget

Code Review 0923a
1. In @WindowGuiImpl@ do we need to keep the hard coded message output (e.g. @line 1@...)? Even... Greg Shah

01:33 PM Feature #2334: implement the GUI message line widget

A first implementation of GUI message area. I implemented a scroll bar widget a scroll pane widget and a scrollable l... Marius Gligor

03:23 PM Feature #1791: implement dynamic UI support

Eugenie, you can ignore these for now. Your support for dynamic widget creation should be generic enough to be able ... Constantin Asofiei

03:02 PM Feature #1791: implement dynamic UI support

There is an issues creating something other than fill-in widget. Consider the following code in @DynamicWidgetFactory... Eugenie Lyzenko

01:41 PM Feature #1791: implement dynamic UI support

How much testing have you done and what are your findings? Greg Shah

11:41 AM Feature #2252: implement GUI client support

This is the priority order for implementation of multi-window support (please edit this entry over time to mark off w... Greg Shah

09/22/2014

10:16 AM Feature #2252: implement GUI client support

Please see the "Source Management" section of the timco.html document for details on how to deal with check-out/check... Greg Shah

09:18 AM Feature #2252: implement GUI client support

Vadim Gindin wrote:
> These errors correlate with my update not with Eugenys.
I guess your changes affect MAJIC cod... Constantin Asofiei

08:57 AM Feature #2252: implement GUI client support

These errors correlate with my update not with Eugenys. Vadim Gindin

08:22 AM Feature #2252: implement GUI client support

Eugenie (EVL) sent a recent update email that notified that there were MAJIC changes to match his recent check-in:
... Greg Shah

08:02 AM Feature #2252: implement GUI client support

Tried to run regression testing and faced with the problem: majic is not builded because of compile errors:... Vadim Gindin

09/20/2014

12:14 PM Feature #2252: implement GUI client support

Greg Shah wrote:
> Would you please add a task documenting the problem? It should be added to the "Harness" project... Hynek Cihlar

08:32 AM Feature #2252: implement GUI client support

> The mystery resolved! Harness reporting doesn't HTML-escape the HTML outputs, that is the reason the button is not ... Greg Shah

08:30 AM Feature #2252: implement GUI client support

Code Review vig_upd20140920a.zip
1. @THIS-PROCEDURE:CURRENT-WINDOW@ is not handled via state sync but you previous... Greg Shah

08:04 AM Feature #2252: implement GUI client support

The mystery resolved! Harness reporting doesn't HTML-escape the HTML outputs, that is the reason the button is not vi... Hynek Cihlar

09/19/2014

04:18 PM Feature #2252: implement GUI client support

I made corrections. Have a look please. Vadim Gindin

08:08 AM Feature #2252: implement GUI client support

Code Review vig_upd20140919c.zip
This is moving in the right direction. Greg Shah

08:07 AM Feature #2252: implement GUI client support

> > Perhaps it should be kept in a context-local static var so it is shared between all @Window@ instances for this c... Greg Shah

05:32 AM Feature #2252: implement GUI client support

Next update with the latest corrections except StatusStack move from ThinClient. See below.
Greg Shah wrote (note ... Vadim Gindin

02:43 PM Feature #1791: implement dynamic UI support

> If 1-3 will work fine I think we do not need any special processing for dynamic widgets on the client side. What do... Greg Shah

01:37 PM Feature #1791: implement dynamic UI support

>One area I wonder about is whether the client-side WidgetRegistry needs to add/remove dynamic widgets differently.
... Eugenie Lyzenko

11:32 AM Feature #1791: implement dynamic UI support

OK, go ahead and commit/distribute evl_upd20140919a.zip.
> >No, there is no such thing as a NEW GLOBAL SHARED frame.... Greg Shah

11:16 AM Feature #1791: implement dynamic UI support

>Let me take one last look first.
OK.
>No, there is no such thing as a NEW GLOBAL SHARED frame. You can only cr... Eugenie Lyzenko

11:06 AM Feature #1791: implement dynamic UI support

Let me take one last look first. Greg Shah

11:05 AM Feature #1791: implement dynamic UI support

The CTRL-C testing finished without regressions. I had to run 3-way tests in standalone session and they are OK too.
... Eugenie Lyzenko

09:57 AM Feature #1791: implement dynamic UI support

The only change in this update is removed TODO from @GenericWidget.resourceDelete()@.
Is it OK to commit and distr... Eugenie Lyzenko

06:24 AM Feature #1791: implement dynamic UI support

>This memory leak already exists in P2J. So we can go forward with your change anyway. But I do want to fix this some... Eugenie Lyzenko

11:56 AM Bug #2396: memory leak when using shared frames

In #1791 we found that using shared frames results in a memory leak because we never fully remove shared frames from ... Greg Shah

11:28 AM Bug #2396 (New): memory leak when using shared frames

Greg Shah

09/18/2014

05:32 PM Feature #2252: implement GUI client support

Code Review vig_upd20140919b.zip
This mostly is moving in the right direction.
1. The @statusStack@, @StatusD... Greg Shah

05:17 PM Feature #2252: implement GUI client support

> 1. Why it is necessary to hold the stack of statuses even for one-window UI?
Because you can have nested WAIT-FO... Greg Shah

04:50 PM Feature #2252: implement GUI client support

Fixed 2 files (compile errors) Vadim Gindin

02:34 PM Feature #2252: implement GUI client support

I've made corrections with status stack, but I have some doubts.
1. Why it is necessary to hold the stack of statu... Vadim Gindin

12:16 PM Feature #2252: implement GUI client support

Details for #2388:
I have created a test suite that explores the behavior of window move/positioning. #2388 is int... Greg Shah

05:01 PM Feature #1791: implement dynamic UI support

> On the other hand I think the shared frame in 4GL approach has memory leak bomb initially. We never know at this ti... Greg Shah

01:53 PM Feature #1791: implement dynamic UI support

>1. The changes to LT bring back that memory leak of shared frames, right? I understand it may be needed to defer the... Eugenie Lyzenko

01:30 PM Feature #1791: implement dynamic UI support

>2. Can the TODO from @GenericWidget.resourceDelete()@ be removed now?
I think we can remove. This is not my TODO ... Eugenie Lyzenko

12:32 PM Feature #1791: implement dynamic UI support

Code Review 0918a
I only have the following concerns:
1. The changes to LT bring back that memory leak of share... Greg Shah

11:57 AM Feature #1791: implement dynamic UI support

>Your top priority is getting the new widget ID implementation through regression testing and checked in.
OK.
>Ho... Eugenie Lyzenko

10:43 AM Feature #1791: implement dynamic UI support

Your top priority is getting the new widget ID implementation through regression testing and checked in.
However, ... Greg Shah

10:41 AM Feature #1791: implement dynamic UI support

Yes, it must build upon (add to) that code. Greg Shah

10:39 AM Feature #1791: implement dynamic UI support

>Get this update prepared and uploaded for review ASAP. Please also test it with a variety of dynamic widget cases to... Eugenie Lyzenko

09:46 AM Feature #1791: implement dynamic UI support

I am fine with the proposed approach. Some thoughts:
1. The use of reflection (to lookup the constructor) needs s... Greg Shah

08:29 AM Feature #1791: implement dynamic UI support

Now at least two issues/regressions remain:
- one for NullPointerException.
- other with shared variable missing.
... Eugenie Lyzenko

12:02 PM Feature #2388: finish GUI window move/position support

This is just for time tracking. Please put all history in the parent task #2252. Greg Shah

12:01 PM Feature #2388 (Closed): finish GUI window move/position support

Greg Shah

09/17/2014

07:33 PM Feature #1791: implement dynamic UI support

Code Review 0917a
I am fine with the changes.
Besides the testing, how soon can you make a list of the changes ... Greg Shah

02:58 PM Feature #1791: implement dynamic UI support

The regression testing has regression. The next update will be tested as fix. What is in the update:
1. Merge with... Eugenie Lyzenko

07:23 PM Feature #2252: implement GUI client support

> WAIT-FOR always has widget specification. This widget uniquely identify the window it belongs. Assuming we have 2 w... Greg Shah

06:40 PM Feature #2252: implement GUI client support

Greg Shah wrote:
> I think the more important question is how does the @statusStack@ need to be implemented in a mul... Vadim Gindin

02:05 PM Feature #2252: implement GUI client support

> I am wondering how is the test runner interacting with the application and whether it may cause a different path of... Greg Shah

01:45 PM Feature #2252: implement GUI client support

Regarding #2323 please advice with runtime regression results. Several test cases fail with an alert box missing butt... Hynek Cihlar

10:35 AM Feature #2333: implement the GUI status line widget

I am keeping this open only because we still have the drawing differences between Windows and Linux. When the #2323 ... Greg Shah

10:17 AM Feature #2333 (Review): implement the GUI status line widget

Marius Gligor

10:16 AM Feature #2333: implement the GUI status line widget

0916a passed regression tests. Committed revision 10613. Marius Gligor

07:29 AM Feature #2334: implement the GUI message line widget

In @OpenEdge@ GUI the message area is a reserved region at the bottom of window above status bar implemented as a scr... Marius Gligor

01:42 AM Feature #2334 (WIP): implement the GUI message line widget

Marius Gligor

09/16/2014

02:25 PM Feature #2252: implement GUI client support

> I asked more about popStatus and pushStatus, rather then nesting. Do you mean I should stay these methods in ThinCl... Greg Shah

01:59 PM Feature #2252: implement GUI client support

I asked more about popStatus and pushStatus, rather then nesting. Do you mean I should stay these methods in ThinClient? Vadim Gindin

01:38 PM Feature #2252: implement GUI client support

> Recalling, I'm going to move these methods (pop and push) to Window. What window to apply these methods for? May be... Greg Shah

01:15 PM Feature #2252: implement GUI client support

I have the following question about methods @pushStatus@ and @popStatus@ (ThinClient). They are called from applyChan... Vadim Gindin

10:55 AM Feature #2252: implement GUI client support

In regard to task #2334 (finish message area support), the following needs to be done:
* create a proper scrollabl... Greg Shah

11:15 AM Feature #2333: implement the GUI status line widget

OK, the failure is actually on the client side and it is just that our GUI support does not yet handle frames. So wh... Greg Shah

11:12 AM Feature #2333: implement the GUI status line widget

[09/16/2014 18:11:26 EEST] (StandardServer.invoke:SEVERE) {00000005:00000016:bogus} Abnormal end!
java.lang.reflect.... Marius Gligor

11:10 AM Feature #2333: implement the GUI status line widget

Please post the full stack trace. Greg Shah

11:09 AM Feature #2333: implement the GUI status line widget

I found the following error: @Attempt to instantiate classclass com.goldencode.p2j.ui.client.Frame which has no prope... Marius Gligor

11:05 AM Feature #2333: implement the GUI status line widget

What causes the server-side crash? Greg Shah

11:03 AM Feature #2333: implement the GUI status line widget

When GUI client starts after authentication the @Ask.p@ is tried to be executed on server side but crash in @Standard... Marius Gligor

10:50 AM Feature #2333: implement the GUI status line widget

Code Review 0916a
The changes look good. Please go ahead into runtime regression testing.
> In conclusions all... Greg Shah

10:20 AM Feature #2333: implement the GUI status line widget

1. Insets could be used by other widgets as well like message area, window title bar.
Even window widgets could ... Marius Gligor

09/15/2014

04:20 PM Feature #2252: implement GUI client support

> I'm just recalling that the client-side implementation is not finished yet. Status line does not display a value.
... Greg Shah

03:35 PM Feature #2252: implement GUI client support

Greg Shah wrote:
>..
> Is there anything else that remains to be done to finish multi-window status support?
I'm... Vadim Gindin

11:38 AM Feature #2252: implement GUI client support

Code Review vig_upd20140912a.zip
In general, the changes are really good. I do want to make some slight changes t... Greg Shah

10:01 AM Feature #2252: implement GUI client support

> Considering that if i.e. char metrics are set, the pixel metrics automatically change, I'm inclined to let the clie... Greg Shah

03:17 PM Feature #2333: implement the GUI status line widget

Code Review 0915a
The changes look very good.
1. Are the @GuiOptions@ insets only useful for the status line? ... Greg Shah

11:47 AM Feature #2333: implement the GUI status line widget

Here are the changes which I did so far. Some of the changes like color inheritance could be applied to other widget... Marius Gligor

02:42 PM Feature #1791: implement dynamic UI support

OK, we will keep going with the current plan. Hopefully it will pass testing and get checked in tomorrow. Greg Shah

02:34 PM Feature #1791: implement dynamic UI support

Greg Shah wrote:
> This update just puts the new ID infrastructure into place. It doesn't solve any of the other dy... Constantin Asofiei

02:31 PM Feature #1791: implement dynamic UI support

> My goal is to separate the widget's config (and in the end the runtime state) from its concrete implementation, so... Greg Shah

01:49 PM Feature #1791: implement dynamic UI support

On a side note, do you now how much work is left on this task? I want to integrate this with my changes. Constantin Asofiei

01:33 PM Feature #1791: implement dynamic UI support

Greg Shah wrote:
> How many of these cases can act like "real" widgets? In other words, many of these are not treat... Constantin Asofiei

12:57 PM Feature #1791: implement dynamic UI support

How many of these cases can act like "real" widgets? In other words, many of these are not treated as widgets by the... Greg Shah

11:49 AM Feature #1791: implement dynamic UI support

Greg Shah wrote:
> > there are some widgets created on client-side which don't have a server-side counterpart
>
>... Constantin Asofiei

11:43 AM Feature #1791: implement dynamic UI support

> there are some widgets created on client-side which don't have a server-side counterpart
Please provide more det... Greg Shah

10:11 AM Feature #1791: implement dynamic UI support

Greg/Eugenie: there are some widgets created on client-side which don't have a server-side counterpart. Looking at t... Constantin Asofiei

09/12/2014

04:34 PM Feature #2252: implement GUI client support

Constantin Asofiei wrote:
> Vadim Gindin wrote:
> >I'm sure about all of them except "statusStack". Could you pleas... Vadim Gindin

03:56 PM Feature #2252: implement GUI client support

Hynek Cihlar wrote:
> // At the moment it is unknown to me whether the coordinate conversion and
> ... Constantin Asofiei

03:20 PM Feature #2252: implement GUI client support

Greg Shah wrote:
> > Should the flag be then somehow cached? The most logical place should probably be the widget in... Hynek Cihlar

01:58 PM Feature #2252: implement GUI client support

Greg Shah wrote:
> The only issue with this is that every call takes a trip down to the client to call @OutputManage... Constantin Asofiei

01:54 PM Feature #2252: implement GUI client support

> (1) In the change set in the file Coordinate.java - // TODO: #2323 implement GUI coordinate rounding.
> GUI roundi... Greg Shah

01:22 PM Feature #2252: implement GUI client support

Code Review 0911a
The changes look good. Greg Shah

12:45 PM Feature #2252: implement GUI client support

I am attaching update to the work in progress of #2323. The change set resolves comments from review, resolves resolv... Hynek Cihlar

04:36 AM Feature #2252: implement GUI client support

Vadim Gindin wrote:
>I'm sure about all of them except "statusStack". Could you please describe its function and may... Constantin Asofiei

09/11/2014

07:02 PM Feature #2252: implement GUI client support

I'm working on status methods implementation. I'm going to move some fields from ThinClient to Window (or TitledWindo... Vadim Gindin

12:13 AM Feature #2252: implement GUI client support

Committed to revision 10606. Vadim Gindin

09:26 AM Feature #2333 (WIP): implement the GUI status line widget

Marius Gligor

09/10/2014

05:31 PM Feature #2252: implement GUI client support

Code Review 0905a
I am fine with the changes.
> But there was an exception. See error log (client_vig_26776.log... Greg Shah

05:01 PM Feature #2252: implement GUI client support

I was running regression testing several times. Made some fix. Here is the latest update. It passes regression testin... Vadim Gindin

12:26 PM Feature #2252: implement GUI client support

In regard to task #2333 (finish status area support), the following needs to be done:
* proper font/color usage
*... Greg Shah

09/08/2014

12:55 PM Feature #2252: implement GUI client support

> 1. In many places in this update, you are moving back to @int@ from @double@. A good example is @src/com/goldencod... Hynek Cihlar

10:34 AM Feature #2252: implement GUI client support

Code Review hc_upd20140907a.zip
I like the new @Coordinate@ helper class. Use of it makes clear to the reader tha... Greg Shah

09/07/2014

04:31 PM Feature #2252: implement GUI client support

Attached is the update of hc_upd20140831a. It resolves the issues from review at notes 184 and 188.
The most impo... Hynek Cihlar

09/05/2014

08:56 AM Feature #1791: implement dynamic UI support

> Sorry, that I'm meddling.
You are not meddling. You are CONTRIBUTING. Your questions help us make this project... Greg Shah

08:24 AM Feature #1791: implement dynamic UI support

Code Review 0904a
I'm fine with the changes. Greg Shah

04:48 AM Feature #1791: implement dynamic UI support

Sorry, that I'm meddling. Why your updates does not change @handle.getResourceId@ static method (and corresponding @R... Vadim Gindin

09/04/2014

07:49 PM Feature #1791: implement dynamic UI support

The today update for review includes:
1. Merge with the recent code base.
2. Fix for shared frame importing @Screen... Eugenie Lyzenko

10:31 AM Feature #2286 (Closed): design and implement basic GUI window widget support

Greg Shah

10:16 AM Feature #1793 (Closed): improve color support

Greg Shah

10:08 AM Feature #1793: improve color support

0904c Passed conversion and regression tests. Committed revision 10605. Marius Gligor

09:46 AM Feature #1793: improve color support

Code Review 0904c
It is good. Go ahead and check it in/distribute it. Greg Shah

09:31 AM Feature #1793: improve color support

Done. Marius Gligor

09:03 AM Feature #1793: improve color support

Code Review 0904b
I am OK with the changes and I do think they are safe enough to avoid further testing.
I have... Greg Shah

08:03 AM Feature #1793: improve color support

A minor change to log a message whenever colors cannot be mapped and are mapped by default to a 0 RGB value. Marius Gligor

07:44 AM Feature #1793: improve color support

The changes in 0903b passed both conversion and regression tests. However I didn't do the commits and distributions y... Marius Gligor

09/03/2014

07:26 PM Feature #1791: implement dynamic UI support

>My only question is whether the @ScreenBuffer(int frameId, int numWidgets)@ constructor is ever safe to use in the n... Eugenie Lyzenko

07:22 PM Feature #1791: implement dynamic UI support

Status update.
The next regression I've faced is in PO adding screen. This is the serious issue with shared frames... Eugenie Lyzenko

09:05 AM Feature #1791: implement dynamic UI support

Code Review 0901b
The changes look good and they do look more correct.
My only question is whether the @ScreenB... Greg Shah

04:54 PM Feature #2252: implement GUI client support

Greg Shah wrote:
> Code Review vig_upd20140901a.zip
>
> I am generally fine with this as an interim update.
>
... Vadim Gindin

09:15 AM Feature #2252: implement GUI client support

> 1. Place a standardized marker in a comment, which can be searched on to find all these places again. Something li... Hynek Cihlar

08:58 AM Feature #2252: implement GUI client support

Hynek Cihlar wrote:
> Greg Shah wrote:
> > Code Review hc_upd20140831a
> >
> > Wow, that is a lot of work! It to... Greg Shah

08:53 AM Feature #2252: implement GUI client support

> It shows window button on the task bar but does not show the window itself. Testcase window_parenting/pause.p. Bod... Greg Shah

08:48 AM Feature #2252: implement GUI client support

Code Review vig_upd20140901a.zip
I am generally fine with this as an interim update.
1. Can we make the window ... Greg Shah

12:12 PM Feature #1793: improve color support

> I have no other works to do on this task.
OK, please get this regression tested (both conversion and runtime).
... Greg Shah

11:58 AM Feature #1793: improve color support

I have no other works to do on this task.
Nevertheless they are other issues to implements like LOAD, USE, UNLOAD, ... Marius Gligor

11:49 AM Feature #1793: improve color support

Code Review 0903b
The changes look good. I like the more general approach to reading color tables from the server... Greg Shah

11:00 AM Feature #1793: improve color support

I fixed the issues reported on Code Review 0903a (note 39) Marius Gligor

10:04 AM Feature #1793: improve color support

Code Review 0903a
The changes look good.
1. WindowConfig is missing a history entry.
2. The call from the cl... Greg Shah

06:01 AM Feature #1793: improve color support

I did some changes inside @ColorTable@ class to load colors on a per user manner.
I've fixed also some javadoc texts. Marius Gligor

12:07 PM Feature #2384: implement custom color overrides for ChUI

This task is meant to allow the configuration of custom colors for ChUI as is possible in the 4GL using the protermca... Greg Shah

12:05 PM Feature #2384 (New): implement custom color overrides for ChUI

Greg Shah

09/02/2014

11:40 AM Feature #1793 (Review): improve color support

Here are my latest changes on color improvements:
- synchronization state between server and client.
- default syst... Marius Gligor

09:59 AM Feature #2252: implement GUI client support

Greg Shah wrote:
> Code Review hc_upd20140831a
>
> Wow, that is a lot of work! It took me many hours to review th... Hynek Cihlar

09:49 PM Feature #2252: implement GUI client support

Code Review hc_upd20140831a
Wow, that is a lot of work! It took me many hours to review that update. Generally, I... Greg Shah

09/01/2014

05:04 PM Feature #1791: implement dynamic UI support

Another update today for review. I've faced another issues with lost @UNINITIALIZED@ state. In this update all constr... Eugenie Lyzenko

02:21 PM Feature #1791: implement dynamic UI support

Code Review 0829a/b and 0901a
I am fine with the changes. Greg Shah

04:03 AM Feature #1791: implement dynamic UI support

The next update for your review.
Looks like I've found the issue resolution. We need to initialize the state map f... Eugenie Lyzenko

02:10 PM Feature #2252: implement GUI client support

I'm trying to test the following update with the last remarks and got strange behavior. It shows window button on the... Vadim Gindin

08/31/2014

06:06 PM Feature #2252: implement GUI client support

Attached are changes related to #2323 - refactor coordinate system and implement GUI coordinate support.
What's in... Hynek Cihlar

02:29 PM Feature #2252: implement GUI client support

I retested implicit pause cases and PAUSE BEFORE HIDE statement to research behavior of THIS-PROCEDURE:CURRENT-WINDOW... Vadim Gindin

08/29/2014

06:09 PM Feature #1791: implement dynamic UI support

Unfortunately at least one regression I have already found. Consider pressing 'V' from main menu.
The current screen... Eugenie Lyzenko

05:54 PM Feature #1791: implement dynamic UI support

These two updates for review contain fixed login related classes, including one from timco majic related sources. I m... Eugenie Lyzenko

09:17 AM Feature #1791: implement dynamic UI support

Code Review 0828a
I am fine with the changes. Greg Shah

09:09 AM Feature #1791: implement dynamic UI support

> all we need is to properly clean up after finish, correct?
You may also need these widgets to be in the @WidgetR... Greg Shah

08:05 PM Feature #1791: implement dynamic UI support

Update for review includes:
1. Renaming @ScreenBuffer@ helper method to bitwise AND the state.
2. Adding helper met... Eugenie Lyzenko

12:27 PM Feature #1793: improve color support

> I think that we have do some changes here in order to accommodate our needs for GUI drivers perhaps on another Redm... Greg Shah

12:18 PM Feature #1793: improve color support

1. The P2J implementation for LOAD, USE and UNLOAD statements is conforming with OpenEdge manual.
It works only if ... Marius Gligor

09:01 AM Feature #2252: implement GUI client support

Code Review 0827a
1. In @GuiOutputManager@ you ask @// TODO added to try. Fix this later. Was WindowConfig.SESSION... Greg Shah

08/28/2014

05:18 PM Feature #1791: implement dynamic UI support

> Please check all Authenticator implementations for how the widget IDs are computed.
Except GenericFrame(server s... Eugenie Lyzenko

02:29 PM Feature #1791: implement dynamic UI support

Eugenie Lyzenko wrote:
> 1. Consider the code @src/aero/timco/majic/security/LoginClient.java@.
Please check all A... Constantin Asofiei

11:48 AM Feature #1791: implement dynamic UI support

>3. Why do you have buffer.size() < size as a condition in ScreenBuffer.isValidId()?
Yes I had to put the describi... Eugenie Lyzenko

11:19 AM Feature #1791: implement dynamic UI support

> It has ID assignments completely different from new approach(and moreover it differs from old one too).
LoginCli... Greg Shah

11:03 AM Feature #1791: implement dynamic UI support

Code Review 0827a
1. In @ScreenBuffer@, you chose to start with an empty state map instead of one populated by UNI... Greg Shah

10:05 PM Feature #1791: implement dynamic UI support

Found a way to debug login screen locally by tunneling server port @3434@ and using @-i1@ instance to remote connecti... Eugenie Lyzenko

04:19 PM Feature #2252: implement GUI client support

6) StatusLineGuiImpl.draw is not called at all and message string is not displayed in the status line of any open win... Vadim Gindin

04:17 PM Feature #2252: implement GUI client support

I faced with the following problems.
1) We probably do not need to use contsant session window ID everywhere or we... Vadim Gindin

03:48 PM Feature #1793: improve color support

> Because system colors are not part of 4GL environment I think that system color table should be stored on server di... Greg Shah

03:32 PM Feature #1793: improve color support

Code Review 0828a
The code is fine. I like the direction it is moving. Greg Shah

12:55 PM Feature #1793: improve color support

> we need to ensure that .ini files can be specified for normal users, batch processes and appserver agents
Yes.
... Greg Shah

09:08 AM Feature #1793: improve color support

Here are my latest changes for COLOR-TABLE implementation.

1. The management of COLOR-TABLE is done now on server... Marius Gligor

04:30 AM Feature #1793: improve color support

Greg Shah wrote:
> As you note, there is no reason we can't use stanza-based INI files on non-Windows platforms. In... Constantin Asofiei

08/27/2014

06:51 PM Feature #1791: implement dynamic UI support

Some considerations and questions to discuss for inline widget ID calculation in current code. I have found new place... Eugenie Lyzenko

05:40 PM Feature #1791: implement dynamic UI support

This update for review includes:
1. Several fixes for @ThinClient.(get|set)ScreenBuffer()@ and @GenericFrame.getScre... Eugenie Lyzenko

09:56 AM Feature #1793: improve color support

Constantin Asofiei wrote:
> Marius Gligor wrote:
> > I found a conversion problem and cannot fix it. Both @COLOR-TA... Marius Gligor

07:06 AM Feature #1793: improve color support

Marius Gligor wrote:
> I found a conversion problem and cannot fix it. Both @COLOR-TABLE@ and @FONT-TBALE@ have a @N... Constantin Asofiei

06:34 AM Feature #1793: improve color support

I found a conversion problem and cannot fix it. Both @COLOR-TABLE@ and @FONT-TBALE@ have a @NUM-ENTRIES@ attribute.
... Marius Gligor

08/26/2014

05:46 AM Feature #2252: implement GUI client support

Greg Shah wrote:
> > About ca_upd20140808c.zip: as code touched by this update seems to be affected by other tasks, ... Constantin Asofiei

02:31 AM Feature #2381: implement PUT-KEY-VALUE COLOR (n | ALL)

Marius Gligor wrote:
> PUT-KEY-VALUE COLOR (n | ALL) is used to save COLOR-TABLE of current environment on a persist... Marius Gligor

02:28 AM Feature #2381 (New): implement PUT-KEY-VALUE COLOR (n | ALL)

Marius Gligor