Activity
From 10/25/2014 to 11/23/2014
11/23/2014
- 05:30 PM Feature #2252: implement GUI client support
- Code Review ca_upd20141123c.zip
There is quite a bit of important clean-up being done here. It is good stuff. Un... - 02:32 PM Feature #2252: implement GUI client support
- This update fixes the following:
> 1. Incomplete dynamic widget/create window support. I know that GuiWidgetFactory... - 09:06 AM Feature #2252: implement GUI client support
- -------- Original Message --------
Subject: Re: next steps for GUI and an upcoming trip/demo
Date: Sat, 22 Nov 20... - 09:06 AM Feature #2252: implement GUI client support
- > I will leave this after the customer demo and for now assume one display.
Good idea.
11/22/2014
- 01:18 PM Feature #2252: implement GUI client support
- Greg, also unless you think otherwise, I will leave this after the customer demo and for now assume one display.
H... - 01:15 PM Feature #2252: implement GUI client support
- Ok. The test will require the windows to be moved around manually. But it should be easy to follow if the instruction...
- 11:58 AM Feature #2252: implement GUI client support
- Send an email to Guy Mills describing the testing you need. Ask him if they have any installations that would be sui...
- 09:39 AM Feature #2252: implement GUI client support
- I need to test the behavior of the following attributes on multi-display setup. Any idea how?
SESSION:HEIGHT-CHARS...
11/21/2014
- 05:41 PM Feature #2252: implement GUI client support
- The update @evl_upd20141120a.zip@ has been committed in bzr as 10662.
- 05:13 PM Feature #2252: implement GUI client support
- Testing completed. No regressions found, the results are in @10660_e83af3b_20141121_evl.zip@. Had to run 3-way CTRL-C...
- 03:38 PM Feature #2252: implement GUI client support
- The main part completed without regressions. The CTRL-C part has been started. In a expected no problem case I'll che...
- 03:32 PM Feature #1790: implement menu support
- > 1. They are equal, i.e. MenuDefinitionMen1.jast contains definition of menu2. In other words it was overwritten. Al...
- 03:02 PM Feature #1790: implement menu support
- I have 2 questions. I have simple testcase containing 2 @define menu@ statements and I'm expecting 2 menu definition ...
11/20/2014
- 05:07 PM Feature #2252: implement GUI client support
- Greg Shah wrote:
> Code Review evl_upd20141120a.zip
>
> If this passes testing, please do check it in and distrib... - 04:57 PM Feature #2252: implement GUI client support
- Code Review evl_upd20141120a.zip
If this passes testing, please do check it in and distribute it.
You don't nee... - 04:30 PM Feature #2252: implement GUI client support
- This is merge with @10660@. The testing will be started shortly.
- 03:00 PM Feature #2252: implement GUI client support
- The main part of testing for @evl_upd20141119b.zip@ completed without regressions. Waiting for CTRL-C part to be done.
- 02:55 PM Feature #2252: implement GUI client support
- Greg Shah wrote:
> Code Review ca_upd20141120c.zip
Passed testing, released to rev 10660 - 10:11 AM Feature #2252: implement GUI client support
- Code Review ca_upd20141120c.zip
Everything is fine. Check it in when it passes. - 09:31 AM Feature #2252: implement GUI client support
- Advancing with MAJIC regression fixes... no new issues found, only some failures from an early failed driver thread, ...
- 07:50 PM Feature #2252: implement GUI client support
- The main part of the regression cycle for @evl_upd20141119b.zip@ has been started.
- 07:40 PM Feature #2252: implement GUI client support
- >> Moreover this can be changed when application is running.
>
>How does the user cause this to occur?
>
>When... - 07:36 PM Feature #2252: implement GUI client support
- TODO list for GUI rectangle widget.
1. Turn on clipping and verify it is working properly.
2. Find out what coord... - 03:29 PM Feature #1790: implement menu support
- Please consider emitting the most common settings into the @SubMenuWidget/MenuItemWidget@ constructor. The unchanged...
- 01:25 PM Feature #1790: implement menu support
- Sorry, I got it: @BOOL_FALSE@
- 01:16 PM Feature #1790: implement menu support
- I'm trying to generate the field @MenuItemWidget menu = new MenuItemWidget(false)@ and faced with the following probl...
- 11:53 AM Feature #2422: add features to BROWSE
- I think that OVERLAY, CENTERED and SCROLLABLE options are silently ignored.
OVERLAY - I thought that it might be ... - 11:34 AM Feature #2422: add features to BROWSE
- (Greg) Here is a list of those features needed:
methods DESELECT-FOCUSED-ROW, DESELECT-SELECTED-ROW, DELETE-CURREN... - 10:54 AM Feature #2445 (Rejected): implement GUI button widget runtime support
- 10:30 AM Feature #2445: implement GUI button widget runtime support
- This task is for time tracking only. All history should be placed in the parent task #2252.
- 10:28 AM Feature #2445 (Rejected): implement GUI button widget runtime support
- 10:44 AM Feature #2446: implement BUTTON and IMAGE GUI widgets (runtime and conversion support)
- This task is for time tracking only. All history should be placed in the parent task #2252.
- 10:39 AM Feature #2446 (Closed): implement BUTTON and IMAGE GUI widgets (runtime and conversion support)
- 08:45 AM Feature #2423: add proper key-to-event mappings in GUI
- > We have two choices: either allow STOP condition to be raised by CTRL-CTRL-S (and maybe translate this into 541?) o...
- 07:35 AM Feature #2423: add proper key-to-event mappings in GUI
- More findings: on linux, the PAUSE/BREAK key emits the CTRL-S key (code 9). I think CTRL-BREAK (code 541) might be a...
- 06:27 AM Feature #2423: add proper key-to-event mappings in GUI
- In GUI, according to official manual, the CTRL-C equivalent is CTRL-BREAK. This has a key-code of 541, but pressing ...
11/19/2014
- 05:43 PM Feature #2252: implement GUI client support
- Greg Shah wrote:
> Code Review evl_upd20141119b.zip
>
> It looks good.
>
> Is this in a good state for regress... - 04:42 PM Feature #2252: implement GUI client support
- Code Review evl_upd20141119b.zip
It looks good.
Is this in a good state for regression testing? It seems like ... - 04:34 PM Feature #2252: implement GUI client support
- Reworked to use system color table to get light/dark colors.
- 02:57 PM Feature #2252: implement GUI client support
- Greg Shah wrote:
> Code Review evl_upd20141119a.zip
>
> 2. Does GROUP-BOX = TRUE really override EDGE-PIXELS?
... - 01:27 PM Feature #2252: implement GUI client support
- Code Review evl_upd20141119a.zip
1. The @drawShadedDoubleLineBorder()@ should not be using hard coded colors. I s... - 12:14 PM Feature #2252: implement GUI client support
- The update for review includes complete support for @GROUP-BOX@ attribute. Classic theme requires special rectangle s...
- 10:37 AM Feature #2252: implement GUI client support
- OK, that makes sense. Please add that explanation as a comment in that code.
- 10:31 AM Feature #2252: implement GUI client support
- Greg Shah wrote:
> When moving frames between windows in @ThinClient.viewWorker()@, why is the repaint triggered bef... - 10:28 AM Feature #2252: implement GUI client support
- Code Review ca_upd20141119d.zip
The changes look good.
When moving frames between windows in @ThinClient.viewWo... - 10:03 AM Feature #2252: implement GUI client support
- Replacement of ca_upd20141113c.zip. Does not contain the PARENT attribute changes (these will be a separate update, o...
- 02:48 PM Feature #1790: implement menu support
- Vadim Gindin wrote:
> 1. "JAST is not emitted". I expected that there will be separate field in MenuDefinitionM clas... - 02:39 PM Feature #1790: implement menu support
- 1. "JAST is not emitted". I expected that there will be separate field in MenuDefinitionM class for each menu-item. @...
- 02:26 PM Feature #1790: implement menu support
- Code Review vig_upd20141120a.zip
1. About frames versus menus:
> In a frames it happens more complex with sever... - 01:25 PM Feature #1790: implement menu support
- The next update. menu-items are still not generated. I tried to do it on fly, but unsuccessful. In a frames it happen...
- 10:06 AM Feature #2412: Implement widget browser
- Committed to bzr revision 10659.
- 09:57 AM Feature #2412: Implement widget browser
- True. I will rename it to hashcode then.
- 09:53 AM Feature #2412: Implement widget browser
- I understand. My concern is that the result is just a number, which could easily be confused with "the" widget ID. ...
- 09:47 AM Feature #2412: Implement widget browser
- Greg Shah wrote:
> 1. How about changing the name of the new "id" property to "hashcode"? That way, it is less li... - 08:54 AM Feature #2412: Implement widget browser
- Code Review hc_upd20141118a.zip
The changes look good.
1. How about changing the name of the new "id" property ...
11/18/2014
- 06:11 PM Feature #2412: Implement widget browser
- The attached update
* adds the object identity property,
* fixes widget highlight - the coordinates are now relativ... - 05:18 PM Feature #2252: implement GUI client support
- Constantin Asofiei wrote:
>
> Basically, instead of calling @clipRectangle(origin, dim)@, call @clipRectangle(orig... - 04:26 PM Feature #2252: implement GUI client support
- Constantin Asofiei wrote:
> And the update for note 580..
This does not work for clipping. Nothing changed for cl... - 04:18 PM Feature #2252: implement GUI client support
- > we can use something like "windows-os-ui-theme". What do you think? Moreover this can be changed when application i...
- 04:12 PM Feature #2252: implement GUI client support
- >> 1. The clipping is turned off due to incorrect clip rectangle calculation.
>Is this related to the known issue... - 04:08 PM Feature #2252: implement GUI client support
- >The most important theme initially is Windows 7. You can allow the Windows XP as a choice too, but I don't think we ...
- 03:01 PM Feature #2252: implement GUI client support
- And the update for note 580..
- 03:00 PM Feature #2252: implement GUI client support
- Eugenie Lyzenko wrote:
> 1. The clipping is turned off due to incorrect clip rectangle calculation.
Please try this... - 02:53 PM Feature #2252: implement GUI client support
- > 1. The clipping is turned off due to incorrect clip rectangle calculation.
Is this related to the known issues i... - 02:40 PM Feature #2252: implement GUI client support
- Code Review evl_upd20141118a.zip
This is a good step forward.
Please change the code in @RectangleGuiImpl.fillR... - 01:59 PM Feature #2252: implement GUI client support
- This updates for review integrates @ScrollGuiContainer@ into GUI hierarchy. The appropriate container now creates by ...
- 01:06 PM Feature #2252: implement GUI client support
- Hynek Cihlar wrote:
> Constantin Asofiei wrote:
> > OK, then I think my changes fix this in the proper way. Part o... - 12:56 PM Feature #2252: implement GUI client support
- Constantin Asofiei wrote:
> OK, then I think my changes fix this in the proper way. Part of the window-visibility w... - 12:41 PM Feature #2252: implement GUI client support
- Hynek Cihlar wrote:
> Constantin Asofiei wrote:
> > Hynek, do you have a state for GSO 334? Because I think it got ... - 12:29 PM Feature #2252: implement GUI client support
- Constantin Asofiei wrote:
> Hynek, do you have a state for GSO 334? Because I think it got fixed by my changes, unin... - 11:06 AM Feature #2252: implement GUI client support
- Hynek, do you have a state for GSO 334? Because I think it got fixed by my changes, unintentionally. Please provide ...
- 09:24 PM Feature #2252: implement GUI client support
- Eugenie Lyzenko wrote:
> Hynek,
>
> What if the coordinates can not be defined on the server side? For example if... - 08:53 PM Feature #2252: implement GUI client support
- Hynek,
What if the coordinates can not be defined on the server side? For example if the widget layout must be don... - 08:35 PM Feature #2252: implement GUI client support
- Eugenie Lyzenko wrote:
> The coordinates for GUI primitives require pixels, not chars.
Although I don't know you... - 07:27 PM Feature #2252: implement GUI client support
- OK. I've found the files in correct @mag_upd20141028a.zip@.
>Please provide more details. Hynek is working on chan... - 04:39 PM Feature #1790: implement menu support
- Make sure you have the proper setup in the @ConversionDriver@. Here is the @generateFrames()@:...
- 04:23 PM Feature #1790: implement menu support
- Only @.java@ is missing.
- 04:20 PM Feature #1790: implement menu support
- Is it just the @.java@ code that is missing? Or are both the @.jast@ and @.java@ missing?
- 04:17 PM Feature #1790: implement menu support
- Greg, I'm trying to create separate rules as you wrote. I faced with the following problem. @MenuDefinitionM@ class i...
- 05:45 AM Feature #2422: add features to BROWSE
- It is P2J bug(s).
11/17/2014
- 06:04 PM Feature #2252: implement GUI client support
- Eugenie Lyzenko wrote:
> Greg, please clarify, I can not find the file @src/com/goldencode/p2j/ui/client/gui/ScrollG... - 05:51 PM Feature #2252: implement GUI client support
- Greg, please clarify, I can not find the file @src/com/goldencode/p2j/ui/client/gui/ScrollGuiContainer.java@ neither ...
- 05:26 PM Feature #2252: implement GUI client support
- Code Review evl_upd20141117a.zip
I like the changes. The only thing I want to point out is that the mag_upd201410... - 02:06 PM Feature #2252: implement GUI client support
- The next update for your review implements @ROUNDED@ feature. The debugging is still required because the tests shows...
- 06:00 PM Feature #2422: add features to BROWSE
- Stanislav Lomany wrote:
> Bug 2.
> If an editable browse has another browse as a sibling, it is practically unusabl... - 02:27 PM Feature #2422: add features to BROWSE
- Bug 2.
If an editable browse has another browse as a sibling, it is practically unusable.
See @uast/browse/brws-no-... - 05:59 PM Feature #1790: implement menu support
- Code Review vig_upd20141117a.zip
1. @MenuDefinition@ does NOT need to extend @InvocationHandler@ and it needs no @... - 05:30 PM Feature #1790: implement menu support
- As part of your recent status report, you mention:
> By the way I don't know how to implement InvocationHandler, t... - 02:45 AM Feature #1790: implement menu support
- Following update generates separate Menu definition class, that is extended from @MenuDefinition@ and adds setup meth...
11/16/2014
- 11:21 AM Feature #2252: implement GUI client support
- This is the first step for you to review to the runtime implementation. The rectangle wiget is creating and drawing w...
11/14/2014
- 08:50 AM Feature #2422: add features to BROWSE
- Please see ~/secure/clients/<customer_name>/reports/<app_name>_cut_down_gui_reports_2010A08_06_20141015.zip. Inside,...
- 08:05 AM Feature #2422: add features to BROWSE
- Can I have a look at the code which uses NO-ASSIGN option? This option is intended for use with user-defined triggers...
11/13/2014
- 04:45 PM Feature #1790: implement menu support
- Code Review vig_upd20141114a.zip
1. Lines 104 and 105 of @annotations/variable_definitions.rules@ contain duplicat... - 02:43 PM Feature #1790: implement menu support
- The next update, that generates @MenuWidget@ field in procedure class file.
Questions.
1. I'm not sure, that thi... - 01:11 PM Feature #2412: Implement widget browser
- Hynek, I think we need one more property to the widget details: the object's identity hash code, retrieved either by ...
- 10:54 AM Feature #2412: Implement widget browser
- Looking in the code I think you are right. I forgot to offset the @NativePoint loc@ in @WidgetBrowserAspect.highlight...
- 10:42 AM Feature #2412: Implement widget browser
- Hynek, a small problem related to highlightning the container's inner widgets: the coordinates of the child widgets a...
- 12:59 PM Feature #2252: implement GUI client support
- Greg Shah wrote:
> 1. @ThinClient.postOSEvent()@ double-posts the same event to the @EventManager@. Is that intenti... - 12:43 PM Feature #2252: implement GUI client support
- Code Review ca_upd20141113c.zip
That is a lot of change. It is very good. I shouldn't be surprised (but I was) a... - 09:22 AM Feature #2252: implement GUI client support
- Hynek Cihlar wrote:
> Constantin Asofiei wrote:
> > Hynek, you can take a look too; btw, can you tell me which font... - 09:20 AM Feature #2252: implement GUI client support
- Constantin Asofiei wrote:
> Hynek, you can take a look too; btw, can you tell me which fonts you used as default for... - 09:00 AM Feature #2252: implement GUI client support
- Greg, this is the first pass at fixing the runtime for multiple windows. What are WIP at this time:
* frame placeme... - 06:01 AM Feature #2252: implement GUI client support
- Hynek Cihlar wrote:
> Constantin Asofiei wrote:
> > Hynek, can you give me an example why the window needs to be ad... - 03:52 AM Feature #2252: implement GUI client support
- Constantin Asofiei wrote:
> Hynek, can you give me an example why the window needs to be added to the widget registr... - 02:55 AM Feature #2252: implement GUI client support
- Hynek, can you give me an example why the window needs to be added to the widget registry, too (and not only to the w...
11/12/2014
- 09:43 AM Feature #2252: implement GUI client support
- The update @evl_upd20141111b.zip@ has been committed in bzr as 10652.
- 09:36 AM Feature #2252: implement GUI client support
- Finally the main part completed without regressions(except GSO 334). The @TC-CODES-EMPLOYEES-021@ is also OK. The rep...
- 05:38 AM Feature #2252: implement GUI client support
- Eugenie Lyzenko wrote:
> > > OK. What about GSO 334 regression? Just ignore it for now?
> >
> > Yes. As long as ... - 05:17 AM Feature #2252: implement GUI client support
> > OK. What about GSO 334 regression? Just ignore it for now?
>
> Yes. As long as it fails the same way as now...
11/11/2014
- 02:19 PM Feature #2252: implement GUI client support
- Conversion testing has passed. Generated code are identical. Continue with runtime testing.
- 12:44 PM Feature #2252: implement GUI client support
- Code Review evl_upd20141111b.zip
It looks good.
> If no objections - I'll start testing for this update.
Ple... - 12:30 PM Feature #2252: implement GUI client support
- Fix for @DCOLOR@ attribute in rule file. In addition to implementing @getDColor()@ I added @getPfColor()@ which was n...
- 11:45 AM Feature #2252: implement GUI client support
- > OK. What about GSO 334 regression? Just ignore it for now?
Yes. As long as it fails the same way as now, ignore... - 11:36 AM Feature #2252: implement GUI client support
- >
> Please merge up with bzr 10651 and get that tested. If it passes, please go ahead and check it in. You do NOT... - 09:47 AM Feature #2252: implement GUI client support
- About #2425:
Please merge up with bzr 10651 and get that tested. If it passes, please go ahead and check it in. ... - 09:44 AM Feature #2422: add features to BROWSE
- I decided to finish with the MAJIC task first.
- 09:38 AM Feature #2422: add features to BROWSE
- I realized that I missed something in the code review. All the new attribute/method interfaces needed to be added to...
- 05:03 AM Feature #2422: add features to BROWSE
- svl_upd20141107b.zip was committed to bzr rev 10651.
11/10/2014
- 10:24 AM Feature #2422: add features to BROWSE
- Conversion part is OK, runtime is still not complete, it hung last time.
- 09:48 AM Feature #2422: add features to BROWSE
- Good summary.
How is regression testing going? Eugenie and I both have updates dependent upon yours, so it will b... - 09:45 AM Feature #1797 (Closed): implement multiple window support
- 09:44 AM Feature #2229 (Closed): implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles...
- 05:40 AM Feature #2252: implement GUI client support
- Constantin Asofiei wrote:
> Hynek, rev 10648 / hc_upd20141106c.zip has a regression in GSO 334... the PUT SCREEN is... - 04:05 AM Feature #2252: implement GUI client support
- Hynek, rev 10648 / hc_upd20141106c.zip has a regression in GSO 334... the PUT SCREEN is cleared for some reason on s...
11/09/2014
- 11:49 AM Feature #2422: add features to BROWSE
- Forgot to post. My separation list of attributes that can be implemented for ChUI now or are GUI-only:
NO-ASSIGN -... - 07:57 AM Feature #2252: implement GUI client support
- The change @evl_upd20141106d@ passed the regression testing. This update is merge with the recent code base(not yet m...
11/07/2014
- 01:46 PM Feature #2252: implement GUI client support
- Code Review ca_upd20141107c.zip
Everything looks fine. - 01:03 PM Feature #2252: implement GUI client support
- This is replacement of ca_upd20141106c.zip and is merged with rev 10649. I'm putting it through testing again. I do...
- 09:56 AM Feature #2252: implement GUI client support
- >
> Unfortunately, the rules files are the ones with the most conflicts.
OK. Not a problem. - 09:54 AM Feature #2252: implement GUI client support
- > What about conversion testing? If the rule files were not involved can we skip this step?
Unfortunately, the rul... - 09:53 AM Feature #2252: implement GUI client support
- OK. What about conversion testing? If the rule files were not involved can we skip this step?
- 09:48 AM Feature #2252: implement GUI client support
- > I guess it will be safe just merge my code with the recent update if testing will be OK. But if this is not accept...
- 09:12 AM Feature #2252: implement GUI client support
- The question. The changes in @hc_upd20141106c.zip@ touch the update I'm currently testing. I guess it will be safe ju...
- 04:00 AM Feature #2252: implement GUI client support
- In regard to #2388.
Regression testing of hc_upd20141106c.zip passed and the changes were committed to trunk in re... - 08:20 PM Feature #2252: implement GUI client support
- The conversion testing has been completed. The generated code is the binary same before and after update. Starting th...
- 09:45 AM Feature #2422: add features to BROWSE
- Code Review svl_upd20141107b.zip
The changes look good. Please get them regression tested (conversion and runtime). - 07:11 AM Feature #2422: add features to BROWSE
- Merged with the latest version.
- 08:17 PM Feature #2422: add features to BROWSE
- Update for review. Fixed noted flaws and re-merged.
- 08:52 AM Feature #2028 (Closed): complete runtime support for dynamic UI
- 08:22 AM Feature #2388 (Closed): finish GUI window move/position support
- 04:13 AM Feature #2388 (Review): finish GUI window move/position support
11/06/2014
- 05:02 PM Feature #2252: implement GUI client support
- Code Review hc_upd20141106c.zip
It looks good. - 04:55 PM Feature #2252: implement GUI client support
- Hynek Cihlar wrote:
> In regard to #2388.
>
> Also I fixed the javadoc errors I introduced (by other Redmine issu... - 04:31 PM Feature #2252: implement GUI client support
- In regard to #2388.
The attached file resolves the issues raised in the previous review of hc_upd20141104a.zip. In... - 04:19 PM Feature #2252: implement GUI client support
- Code Review evl_upd20141106d.zip
Looks good. - 04:18 PM Feature #2252: implement GUI client support
- OK, fixed. The testing will start shortly for attached update.
- 04:10 PM Feature #2252: implement GUI client support
- Code Review evl_upd20141106c.zip
Very good. One minor issue:... - 04:06 PM Feature #2252: implement GUI client support
- The updates reverts @EDGE-CHARS@ internal storage to double and changes setter signature to @NumberType@.
- 04:03 PM Feature #2252: implement GUI client support
- The rectangle testcases has been committed in bzr as 1225.
- 03:24 PM Feature #2252: implement GUI client support
- Code Review evl_upd20141106b.zip
Everything is good, except for some confusion that I caused. In my previous code... - 03:06 PM Feature #2252: implement GUI client support
- This updates for your review fixes the notes for previous one.
- 11:45 AM Feature #2252: implement GUI client support
- > The runtime to create the dynamic windows is buggy at this time. I will focus on making this to work properly, plus...
- 11:34 AM Feature #2252: implement GUI client support
- Greg Shah wrote:
> I do worry that there will be issues in focus processing and in the implicit window selection.
T... - 11:20 AM Feature #2252: implement GUI client support
- > Also the testcases update attached.
Please check in your testcases as you go. It is good that you are posting t... - 11:19 AM Feature #2252: implement GUI client support
- Code Review evl_upd20141106a.zip
1. EDGE-CHARS should be DECIMAL instead of INTEGER.
2. @RectangleConfig@ needs... - 11:02 AM Feature #2252: implement GUI client support
- The update for review contains conversion support for rectangle widget(including @define rectangle@ statement). It is...
- 10:52 AM Feature #2252: implement GUI client support
- Constantin Asofiei wrote:
> Greg Shah wrote:
> > Otherwise I don't really know of something to do. I must have miss... - 10:46 AM Feature #2252: implement GUI client support
- Greg Shah wrote:
> Otherwise I don't really know of something to do. I must have missed it. What is still open in t... - 10:17 AM Feature #2252: implement GUI client support
- > I think we need the runtime for multiple windows (CREATE WINDOW statement) completed before adding support for this...
- 09:37 AM Feature #2252: implement GUI client support
- Greg Shah wrote:
> When do you suggest we resolve the new TODOs in @ThinClient.viewWorker()@ (the ones related to mo... - 09:25 AM Feature #2252: implement GUI client support
- Code Review ca_upd20141106c.zip
The changes look good.
When do you suggest we resolve the new TODOs in @ThinCli... - 08:01 AM Feature #2252: implement GUI client support
- This is for #2229, IN WINDOW clause support for these statements:PROMPT-FOR/SET/UPDATE/INSERT.
The following state...
11/05/2014
- 03:06 PM Feature #2423 (Closed): add proper key-to-event mappings in GUI
- 02:57 PM Feature #2423: add proper key-to-event mappings in GUI
- ca_upd20141105c.zip was committed to bzr rev 10646.
- 09:09 AM Feature #2423: add proper key-to-event mappings in GUI
- This one fixes a regression related to keyboard (was not being re-initialized properly after a reset). Built on top o...
- 03:06 PM Feature #2416 (Closed): implement frame widget support for GUI
- 02:59 PM Feature #2252: implement GUI client support
- Greg Shah wrote:
> The history entry in @BaseEntity@ references the removal of @set/getHeight@ but the methods remov... - 01:17 PM Feature #2252: implement GUI client support
- Code Review ca_upd20141105a.zip
Everything looks good. That browse bug seems like it was subtle (and it was possi... - 01:03 PM Feature #2252: implement GUI client support
- In regard to #2425:
I forgot to mention that as part of this task we need to support the DEFINE RECTANGLE widget o... - 09:28 AM Feature #2252: implement GUI client support
- This is correct rectangle tests, sorry.
- 09:16 AM Feature #2252: implement GUI client support
- This is replacement of mag_upd20141031b.zip (for #2416). One more regression testing is running - should be clear.
... - 08:09 AM Feature #2252: implement GUI client support
- OK. Working on conversion stubs. The attachment contains the testcases I used to check the rule changes consistency.
- 06:25 AM Feature #2252: implement GUI client support
- Code Review evl_upd20141104a.zip
The changes are good. Please focus next on getting the stubs in the runtime so t... - 09:38 PM Feature #2252: implement GUI client support
- This is the conversion support for rectangle widget attributes: @EDGE-CHARS, EDGE-PIXELS, FILLED, GRAPHIC-EDGE, GROUP...
- 02:34 PM Feature #2422: add features to BROWSE
- > A question is what Progress does when both expandable and fit-last-column are used on the same browse.
It is forb... - 02:28 PM Feature #2422: add features to BROWSE
- >> 5. Did you remove expandable from BrowseConfig on purpose?
>
> Yes, EXPANDABLE was replaced in Progress by FIT-L... - 02:14 PM Feature #2422: add features to BROWSE
- > 3. I assume you found NO-COLUMN-SCROLLING is a valid attribute through your testcases?
Yes.
> 5. Did you remove...
11/04/2014
- 06:04 PM Feature #1790: implement menu support
- Code Review vig_upd20141105a.zip
The changes are a good start. Some thoughts:
1. Your @progress.g@ changes are ... - 05:53 PM Feature #1790: implement menu support
- > I made for DEFINE MENU good AST similar to DEFINE BUTTON except the nested KW_MENU. I tried to find that place wher...
- 05:17 PM Feature #1790: implement menu support
- I made for DEFINE MENU good AST similar to DEFINE BUTTON except the nested KW_MENU. I tried to find that place where ...
- 05:35 PM Feature #2252: implement GUI client support
- Code Review hc_upd20141104a.zip
It looks really good.
1. Should @LogicalTerminalConversionParams@ store the res... - 04:58 PM Feature #2252: implement GUI client support
- In reference to #2388.
The attached file fixes regressions found during regression testing.
Also the regressio... - 04:59 PM Feature #2424 (WIP): GUI window sizing and scrollbar/viewport handling
- 07:15 AM Feature #2412 (Closed): Implement widget browser
11/03/2014
- 05:39 PM Feature #2412: Implement widget browser
- Committed to bzr revision 10641.
- 12:50 PM Feature #2412: Implement widget browser
- Code Review 1103a
The changes look good.
Since there are no conversion changes and the runtime changes are spec... - 03:10 AM Feature #2412: Implement widget browser
- Good idea with the ant script. I believe I resolved all the comments. In regards to AspectJ I think we share the same...
- 04:34 PM Feature #1790: implement menu support
- > 1. Is comparison with frames correct and will it be right to create similar rules?
No, I don't think so.
Menu... - 03:53 PM Feature #1790: implement menu support
- The more I'm investigating menus, more I'm founding that they are very similar to frames.
1. Definition of menu con... - 03:19 PM Feature #2422: add features to BROWSE
- Code Review 1102a part 2
Looking more carefully, I see that most of the new attributes and methods don't belong to... - 03:03 PM Feature #2422: add features to BROWSE
- Code Review 1102a
In general, this is really good.
1. The kw_dcolor attribute now has a duplicate entry in the ... - 03:26 AM Feature #2422: add features to BROWSE
- Conversion part for review.
10/31/2014
- 01:15 PM Feature #2252: implement GUI client support
- @CTRL-C@ runtime test passed without any error! Now the @MAIN@ part is running.
- 11:26 AM Feature #2252: implement GUI client support
- @Majic@ conversion ended. No errors. I started regression tests.
- 10:33 AM Feature #2252: implement GUI client support
- I have no special test cases. So far I started from empty frame test case and I added a rectangle. ...
- 10:18 AM Feature #2252: implement GUI client support
- In regard to #2425:
1. Do you have testcases to check in? If so, please put them in @testcases/uast/rect/@.
2.... - 10:16 AM Feature #2252: implement GUI client support
- Copied here from #2425:
Here are my changes that I did so far for rectangle implementation. @ScrollGuiContainer@ i... - 09:39 AM Feature #2252: implement GUI client support
- OK Greg. Here are the reverted changes. I'm going to put these on conversion and runtime tests.
- 09:32 AM Feature #2252: implement GUI client support
- Let's avoid the @SkipEntity@ changes and back out the related change to @frame_generator.xml@.
- 09:16 AM Feature #2252: implement GUI client support
- I found that @SkipEntity@ is used also by @Majic@ classes so further changes should be made in @Majic@ project.
I'm ... - 08:48 AM Feature #2252: implement GUI client support
- I restarted @Majic@ conversion. Now it works again.
- 08:00 AM Feature #2252: implement GUI client support
- Constantin Asofiei wrote:
> Marius Gligor wrote:
> > The @CTRL-C@ test is running from about 3 hours. I downloaded ... - 07:44 AM Feature #2252: implement GUI client support
- Marius Gligor wrote:
> The @CTRL-C@ test is running from about 3 hours. I downloaded server log and I found many err... - 07:14 AM Feature #2252: implement GUI client support
- The @CTRL-C@ test is running from about 3 hours. I downloaded server log and I found many errors (see attached log).
... - 11:46 AM Feature #2412: Implement widget browser
- Code Review 1031a
This is super useful and well done. Most of the feedback is really minor style stuff.
1. I h... - 10:52 AM Feature #2412 (Review): Implement widget browser
- 10:51 AM Feature #2412: Implement widget browser
- Attached is the finished implementation. Supported are both GUI and ChUI while highlighting was implemented only for ...
- 08:17 AM Feature #2425: implement GUI rectangle widget
- Here are my changes that I did so far for rectangle implementation. @ScrollGuiContainer@ is the GUI implementation of...
- 05:31 AM Bug #2432: investigate and fix collisions related to event/key codes reported by KEY-CODE and LAS...
- From #2423 note 7:
> Another frustrating fact about events: although the @WINDOW-*@ events are reporting LAST-EVENT... - 05:30 AM Bug #2432 (New): investigate and fix collisions related to event/key codes reported by KEY-CODE a...
- 05:25 AM Feature #2423: add proper key-to-event mappings in GUI
- This one is merged with mag_upd20141030b.zip from #2252. Testing passed, release is pending.
10/30/2014
- 02:34 PM Feature #2252: implement GUI client support
- I think is not necessary. I checked and I found that I have indeed other files with history from 2013.
- 02:31 PM Feature #2252: implement GUI client support
- I download the entire @Majic@ project, all sources. I didn't applied my changes but is compiled with errors using ant...
- 02:26 PM Feature #2252: implement GUI client support
- Marius Gligor wrote:
> - I created a folder @test@ on my home directory on @devsrv01@.
> - Inside this directory I ... - 02:21 PM Feature #2252: implement GUI client support
- - I created a folder @test@ on my home directory on @devsrv01@.
- Inside this directory I did: @git clone /opt/secur... - 01:48 PM Feature #2252: implement GUI client support
- Marius Gligor wrote:
> As I remember I use staging branch:
>
> [...]
>
> Should I do other git commands?
The ... - 01:43 PM Feature #2252: implement GUI client support
- As I remember I use staging branch:...
- 01:34 PM Feature #2252: implement GUI client support
- Marius Gligor wrote:
> The @Majic@ conversion ended but with strange compile errors. I have no errors for set/get Wi... - 01:13 PM Feature #2252: implement GUI client support
- The @Majic@ conversion ended but with strange compile errors. I have no errors for set/get Width/Height but instead o...
- 11:40 AM Feature #2252: implement GUI client support
- I changed @Majic@ classes by replacing get/set Width/Height with get/set WidthChars/HeightChars. I tried to compile @...
- 10:20 AM Feature #2252: implement GUI client support
- I deleted the MAJIC code since this is a customer's confidential material which we can't post in an "open" project th...
- 10:18 AM Feature #2252: implement GUI client support
- Code Review mag_upd20141030b.zip
The changes look fine. When you have the hand-coded MAJIC changes done, please d... - 08:43 AM Feature #2252: implement GUI client support
- I the mean time I will do the changes "by hand" and I will test first on my machine when conversion is done.
- 08:39 AM Feature #2252: implement GUI client support
- Unfortunately I have no @Majic@ jars so I'm going to start a conversion without my changes.
- 08:27 AM Feature #2252: implement GUI client support
- Marius Gligor wrote:
> I did @git clone /opt/secure/code/majic_repo/majic.git@ on a new folder then @git checkout -b... - 08:25 AM Feature #2252: implement GUI client support
- I did @git clone /opt/secure/code/majic_repo/majic.git@ on a new folder then @git checkout -b staging@
I downloaded ... - 07:41 AM Feature #2252: implement GUI client support
- Marius Gligor wrote:
> Conversion of @Majic@ fails using my changes (41 compile errors). I did a small change in rul... - 07:25 AM Feature #2252: implement GUI client support
- Conversion of @Majic@ fails using my changes (41 compile errors). I did a small change in rules but failed again. It'...
- 03:47 AM Feature #2252: implement GUI client support
- I found and fixed the @repaint()@ issue. The problem is @Frame.getClipRect()@ which is @ChUI@ specific because it cou...
- 01:12 PM Feature #2422: add features to BROWSE
- > Should I create some common interface for BrowseWidget and BrowseColumnWidget so I'll be able to unwrap calls like....
- 12:14 PM Feature #2422: add features to BROWSE
- @LABEL-BGCOLOR@ attribute can be applied to a browse or a browse column. Should I create some common interface for @B...
- 09:53 AM Feature #2423: add proper key-to-event mappings in GUI
- > I suggest to defer it... it requires more analysis on how the PROGRESS/KEYPRESS events are managed by 4GL. My theor...
- 09:49 AM Feature #2423: add proper key-to-event mappings in GUI
- Greg Shah wrote:
> Code Review ca_upd20141030b.zip
>
> I'm good with the changes. It is a decent approach. The ... - 09:42 AM Feature #2423: add proper key-to-event mappings in GUI
- Code Review ca_upd20141030b.zip
I'm good with the changes. It is a decent approach. The unavoidable 4GL nastines... - 02:41 AM Feature #2423: add proper key-to-event mappings in GUI
- Fixed a regression and javadoc issues.
- 09:44 AM Feature #2412: Implement widget browser
- This is going to be invaluable! Well done.
10/29/2014
- 07:48 PM Feature #2412: Implement widget browser
- The task is nearly finished. I am attaching a screenshot of the browser in action.
I got a little stuck with the h... - 03:58 PM Feature #2252: implement GUI client support
- Marius Gligor wrote:
> I fixed the issue by using @ancestor().repaint()@ instead @repaint()@ in @ScrollBarGuiImpl.re... - 03:24 PM Feature #2252: implement GUI client support
- Greg Shah wrote:
> Code Review ca_upd20141029a.zip
>
> The changes look good. Please check them in when testing ... - 02:19 PM Feature #2252: implement GUI client support
- I fixed the issue by using @ancestor().repaint()@ instead @repaint()@ in @ScrollBarGuiImpl.refersh()@ and @ScrollBarG...
- 01:53 PM Feature #2252: implement GUI client support
- I just checked and mouse detection works fine but the window is not updated after drawing in this case.
If I resize... - 01:40 PM Feature #2252: implement GUI client support
- @NativeDimension@ was changed for testing purposes and I reverted the changes.
Unfortunately I found another problem... - 01:34 PM Feature #2252: implement GUI client support
- Code Review mag_upd20141029a.zip
The code changes look good. Please add a history entry to @NativeDimension@, @Gu... - 12:33 PM Feature #2252: implement GUI client support
- Here are my today changes. What I fixed so far from code review 2810a:
1. I changed @GuiDriver.draw()@ to manage c... - 11:21 AM Feature #2252: implement GUI client support
- Another frustrating fact about events: although the @WINDOW-*@ events are reporting LAST-EVENT:CODE values (other tha...
- 10:48 AM Feature #2252: implement GUI client support
- Code Review ca_upd20141029a.zip
The changes look good. Please check them in when testing passes.
There is one ... - 10:08 AM Feature #2252: implement GUI client support
- This is for #2229 (replacement for ca_upd20141027a.zip / vig_upd20141027a.zip). It passed runtime/conversion testing,...
- 03:49 PM Feature #2423: add proper key-to-event mappings in GUI
- This is replacement for 1029b.zip (merged with rev 10638) and is going into regression testing. Note 7 still applies.
- 02:58 PM Feature #2423: add proper key-to-event mappings in GUI
- PS: the issue in note 7 is not yet fixed.
- 02:57 PM Feature #2423: add proper key-to-event mappings in GUI
- This is a implementation of keyboards compatible with ChUI (linux/windows) and GUI (windows). When working on GUI mo...
- 02:57 PM Feature #2423: add proper key-to-event mappings in GUI
- Another frustrating fact about events: although the @WINDOW-*@ events are reporting LAST-EVENT:CODE values (other tha...
- 08:58 AM Feature #1790: implement menu support
- > Why the global read_only_attribute function is necessary?
Progress doesn't detect assignments to read-only attri...
10/28/2014
- 06:24 PM Feature #1790: implement menu support
- Thanks, it is little unexpected. Why the global @read_only_attribute@ function is necessary?
The next conversion p... - 02:25 PM Feature #2252: implement GUI client support
- Marius Gligor wrote:
> Regarding generation of @openScope@ on conversion I provided a solution some time ago but was... - 01:58 PM Feature #2252: implement GUI client support
- > 2. screen().sync() was taken from ChUI implementation and I don't know if in GUI should be used. If not I will elim...
- 01:52 PM Feature #2252: implement GUI client support
- Regarding generation of @openScope@ on conversion I provided a solution some time ago but was not accepted.
I will t... - 01:49 PM Feature #2252: implement GUI client support
- Regarding scrolling message are via UP/DOWN cursor key is easy to implements seems the code has more in common with m...
- 01:45 PM Feature #2252: implement GUI client support
- Marius Gligor wrote:
> Basically the GUI empty frame implementation could be considered done.
Please check this sce... - 01:44 PM Feature #2252: implement GUI client support
- OK I will do the changes in @GuiDriver.draw()@. Here I have a question.
Should we create another @GuiDriver.draw()@... - 01:30 PM Feature #2252: implement GUI client support
- > My implementation contains changes in clip rectangle management which differs than current implementation.
Good ... - 11:31 AM Feature #2252: implement GUI client support
- Basically the GUI empty frame implementation could be considered done.
My implementation contains changes in clip re... - 11:24 AM Feature #2252: implement GUI client support
- Code Review mag_upd20141028a.zip
The changes look good.
Is there anything else needed before this first pass at... - 10:45 AM Feature #2252: implement GUI client support
- Here are my today changes.
1. I fixed mouse wheel events issue and I implemented mouse wheel event handler for scr... - 08:24 AM Feature #2252: implement GUI client support
- Code Review mag_upd20141027a.zip
The code looks good. The only thing I see is this:
@ScrollBarGuiImpl.REAPEAT@...
10/27/2014
- 04:36 PM Feature #1790: implement menu support
- You need to add @ftype == prog.kw_menu_bar ||@ to the list in the @read_only_attribute@ function in @include/common-...
- 04:22 PM Feature #1790: implement menu support
- I tried to work on conversion of @current-window:menubar = menu mbar:handle@.
I added the following rule to method-a... - 08:29 AM Feature #1790: implement menu support
- Please upload your latest changes here.
Please check in all your testcases to @testcases/uast/menu/@.
I need to... - 02:13 PM Feature #2252: implement GUI client support
- Here are my today changes. I fixed the following issues:
1. Test case testcases/uast/window_events/mouseevts.p is ... - 09:50 AM Feature #2252: implement GUI client support
- Vadim, please create a task in the Majic Conversion project and upload there the MAJIC changes required for your 1027...
- 08:25 AM Feature #2252: implement GUI client support
- Fixed remained -1.
- 08:01 AM Feature #2252: implement GUI client support
- Testing results of vig_upd20141025a.zip are following....
- 04:40 AM Feature #2252: implement GUI client support
- Vadim Gindin wrote:
> > * @LogicalTerminal.getWindowById@ - why do you explicitly check for active/current/default-w... - 09:51 AM Feature #1791: implement dynamic UI support
- Committed in bzr as 10636. Will be distributed soon.
- 07:50 AM Feature #1791: implement dynamic UI support
- Go ahead and check in/distribute.
10/26/2014
- 02:50 PM Feature #1791: implement dynamic UI support
- The @CTRL-C@ part has been completed without regressions, had to start 3-way tests separately to have positive result...
- 03:05 AM Feature #1791: implement dynamic UI support
- The main part completed without regressions. Waiting for @CTRL-C@ one to be done.
Also available in: Atom