FWD » Core Development » User Interface

01/02/2015

04:56 PM Feature #2474: dynamically execute applhelp.p instead of driving it from a static directory entry

Today P2J can only have a static @applhelp.p@ equivalent, but in the 4GL the propath is searched dynamically to find ... Greg Shah

04:55 PM Feature #2474 (New): dynamically execute applhelp.p instead of driving it from a static directory...

Greg Shah

02:52 PM Bug #2473: ENABLE/DISABLE by themselves don't define frames (but they do add to them if the frame...

Consider these cases:
+Case 1+... Greg Shah

02:47 PM Bug #2473 (New): ENABLE/DISABLE by themselves don't define frames (but they do add to them if the...

Greg Shah

12/31/2014

01:56 PM Feature #1790: implement menu support

The parser will be connecting the @##@ node to the rest of the tree AFTER the @def_menu_stmt@ is done processing. So... Greg Shah

01:19 PM Feature #1790: implement menu support

I'm calling @sym.addMenuLike(#m.getText(), like_name, ##);@ in the end of @def_menu_stmt@ rule in @progress.g@. Insid... Vadim Gindin

01:02 PM Feature #1790: implement menu support

I don't really understand what you are doing. If @getParent()@ returns @null@, then that subtree hasn't yet been gra... Greg Shah

12:34 PM Feature #1790: implement menu support

How to hide/remove unnecessary AST nodes? I need to replace @DEFINE MENU m1 LIKE m@ with @DEFINE MENU m ....@. I've t... Vadim Gindin

09:30 AM Feature #1790: implement menu support

The @copyDefaultOptions()@ only saves a reference (inside the @Variable@ instance) to the copied subtree. It does no... Greg Shah

09:21 AM Feature #1790: implement menu support

My method is the following... Vadim Gindin

08:54 AM Feature #1790: implement menu support

Now I understand. Thank you! Vadim Gindin

08:45 AM Feature #1790: implement menu support

Vadim Gindin wrote:
> Thank you for quick answer. I've seen this method earlier and decided to write separate method... Greg Shah

08:39 AM Feature #1790: implement menu support

Thank you for quick answer. I've seen this method earlier and decided to write separate method @addMenuLike@ for menu... Vadim Gindin

08:17 AM Feature #1790: implement menu support

Vadim Gindin wrote:
> Greg, I don't understand about LIKE. Lets look at simple statement @define menu m like m1@. As... Greg Shah

08:04 AM Feature #1790: implement menu support

I thought so until now, but I just didn't find the place where the copying is happen. Vadim Gindin

08:00 AM Feature #1790: implement menu support

Greg, I don't understand about LIKE. Lets look at simple statement @define menu m like m1@. As a result, Do I need to... Vadim Gindin

12/30/2014

02:27 PM Feature #1790: implement menu support

Vadim Gindin wrote:
> The question about SHARED menus implementation. How about @MenuWidget.createStaticSharedMenu@?... Greg Shah

01:53 PM Feature #1790: implement menu support

The question about SHARED menus implementation. How about @MenuWidget.createStaticSharedMenu@? Is its implementation ... Vadim Gindin

12:14 PM Feature #1790: implement menu support

> The difficulty here is the fact, that already existing menu-item or sub-menu can be a part of DEFINE MENU/SUB-MENU ... Greg Shah

11:57 AM Feature #1790: implement menu support

Greg Shah wrote:
> Vadim Gindin wrote:
> > About ambiguity with DOTs. I've made additional testing and found the fo... Vadim Gindin

11:54 AM Feature #1790: implement menu support

Code Review vig_upd20141225a.zip
This looks pretty good.
1. Does referencing @convert/methods_attributes.rules@... Greg Shah

10:33 AM Feature #1790: implement menu support

Vadim Gindin wrote:
> About ambiguity with DOTs. I've made additional testing and found the following.
> # This amb... Greg Shah

10:31 AM Feature #1790: implement menu support

> About LIKE clause. I didn't find conversion implementation of LIKE in other statements for example DEFINE VARIABLE,... Greg Shah

12/29/2014

04:47 PM Feature #2422: add features to BROWSE

OK, sounds good to me. Eric Faulhaber

01:55 PM Feature #2422: add features to BROWSE

Eric, I'm not going to cache all rows, I'm only going to additionally cache row numbers and number of @rows + row num... Stanislav Lomany

01:15 PM Feature #2422: add features to BROWSE

Greg Shah wrote:
> > Considering all of the above I suggest to cache rows on the client side together with their row... Eric Faulhaber

08:14 AM Feature #2422: add features to BROWSE

> Windows version of Progress has bugs - in case of record deletion cursor may jump, some extra records may be missin... Greg Shah

04:29 PM Feature #1790: implement menu support

About ambiguity with DOTs. I've made additional testing and found the following.
# This ambiguity also appears for S... Vadim Gindin

03:03 PM Feature #1790: implement menu support

About LIKE clause. I didn't find conversion implementation of LIKE in other statements for example DEFINE VARIABLE, D... Vadim Gindin

08:40 AM Feature #1790: implement menu support

I will respond with a code review later, but for now I am responding to your parser ambiguity issue.
> In the curr... Greg Shah

12/28/2014

12:11 PM Feature #2252: implement GUI client support

The changes passed regression testing. They are checked in as follows:
# ges_upd20141222a.zip - bzr rev 10688
# ... Greg Shah

09:46 AM Feature #2252: implement GUI client support

Eugenie: on second thought, please hold off of checking in and distributing the @evl_upd20141222a.zip@. I have been ... Greg Shah

08:20 AM Feature #2252: implement GUI client support

There is no need to wait for the fix. Please check in and distribute evl_upd20141222a.zip. Greg Shah

12/27/2014

05:38 PM Feature #2422: add features to BROWSE

Some thoughts:
* Uncommitted deletions are deleted from the result list if records failed to load into a view. Row n... Stanislav Lomany

12/26/2014

12:03 PM Feature #2252: implement GUI client support

The runtime testing for @evl_upd20141222a.zip@ has been completed. All including CTRL-C tests are OK.
The only exc... Eugenie Lyzenko

10:44 AM Feature #1790: implement menu support

Just for documenting purposes. The parser problem of ambiguity is in @def_menu_stmt@ rule from @progress.g@:... Vadim Gindin

12/25/2014

05:55 PM Feature #1790: implement menu support

The next update containing following changes
* fixed and tested conversion of menu widgets references, based on "fin... Vadim Gindin

12/24/2014

08:28 AM Feature #2422: add features to BROWSE

I was intended to check if BROWSE browsing is based on row numbers as it is implemented in P2J (not, say, on record i... Stanislav Lomany

07:22 AM Feature #2252: implement GUI client support

The conversion testing for @evl_upd20141222a.zip@ completed. The generated sources are identical.
Continue with ru... Eugenie Lyzenko

07:05 PM Feature #2252: implement GUI client support

> Code Review evl_upd20141222a.zip
>
> Please finish your manual testing. If no changes are needed, you can put i... Eugenie Lyzenko

12/23/2014

03:16 PM Feature #2252: implement GUI client support

Code Review evl_upd20141222a.zip
I'm fine with the changes. It looks good!
Please finish your manual testing. ... Greg Shah

09:32 PM Feature #2252: implement GUI client support

This update for review includes resolution for previous notes including tooltip deregistration on demand and moving s... Eugenie Lyzenko

02:43 PM Feature #1790: implement menu support

> I.e. adding new method findMenuItem to the MenuDefinition class.
Almost. I was thinking that @m@ is really an i... Greg Shah

01:54 PM Feature #1790: implement menu support

I.e. adding new method @findMenuItem@ to the @MenuDefinition@ class. Vadim Gindin

01:48 PM Feature #1790: implement menu support

The reference @menu-item mi in menu m@ would probably be converted to @m.findMenuItem("mi")@. Is that what you mean?... Vadim Gindin

01:31 PM Feature #1790: implement menu support

This doesn't seem right. Wouldn't the 4GL do this "lookup" at runtime instead of at compile time? In other words, c... Greg Shah

12:12 PM Feature #1790: implement menu support

Just for documenting purposes.
One SUB-MENU can appear in one MENU tree only once. Therefore when we have a refere... Vadim Gindin

07:56 PM Feature #2422: add features to BROWSE

Interesting findings.
It seems to me that some basic differences in the core caching mechanism could lead to many ... Greg Shah

12/22/2014

04:30 PM Feature #1790: implement menu support

OK, let's go with your plan. Greg Shah

03:40 PM Feature #1790: implement menu support

I think that procedure class is better place because concrete reference could be a part of some logic in that procedu... Vadim Gindin

04:25 PM Feature #2422: add features to BROWSE

For a note: there is a number of issues related to how records are loaded into browse, for example:
1. P2J caches mo... Stanislav Lomany

12:03 PM Feature #2252: implement GUI client support

1221c committed to bzr revision 10687.
Greg Shah wrote:
> Code Review hc_upd20141221c.zip
>
> I'm fine with th... Hynek Cihlar

11:45 AM Feature #2252: implement GUI client support

Code Review hc_upd20141221c.zip
I'm fine with the changes. Please check them in. Greg Shah

11:39 AM Feature #2252: implement GUI client support

The attached file adds merge with trunk and removes the .classpath file. It has passed regression testing.
Please ... Hynek Cihlar

11:44 AM Feature #2412: Implement widget browser

1221a committed to bzr revision 10686. Hynek Cihlar

09:05 AM Feature #2412: Implement widget browser

Code Review hc_upd20141221a.zip
Nice improvements! Please check these in. Greg Shah

12/21/2014

06:31 PM Feature #2412: Implement widget browser

The attached updates adds a couple of new features:
* property table now contains all widget and its associated con... Hynek Cihlar

06:06 AM Feature #2252: implement GUI client support

Greg Shah wrote:
> Code Review ca_upd20141220b.zip
>
> This is really good. If I understand correctly, it has pa... Constantin Asofiei

12/20/2014

02:10 PM Feature #2252: implement GUI client support

Constantin,
> This link has some constants related to the win32 @GetSysColor@ API: http://msdn.microsoft.com/en-us... Eugenie Lyzenko

01:28 PM Feature #2252: implement GUI client support

Code Review ca_upd20141220b.zip
This is really good. If I understand correctly, it has passed testing. I'm OK fo... Greg Shah

11:36 AM Feature #2252: implement GUI client support

> does anyone know where the color names from SysColor class were captured?
I believe Marius pulled those from the... Greg Shah

11:29 AM Feature #2252: implement GUI client support

Attached version is for #2451 , implementation for FILL-IN/TEXT/LITERAL in GUI. Remaining work:
# GUI fill-in width ... Constantin Asofiei

06:53 AM Feature #2252: implement GUI client support

Guys, does anyone know where the color names from @SysColor@ class were captured? I can't find any reference in redmi... Constantin Asofiei

07:28 PM Feature #2252: implement GUI client support

>I think so, otherwise the handlers will execute and slow down the system (at least slightly).
OK. Eugenie Lyzenko

07:18 PM Feature #2252: implement GUI client support

> The current P2J will not display them in this case(but the handlers remain registered). If we will deregister all h... Greg Shah

12/19/2014

06:45 PM Feature #2252: implement GUI client support

>Is this how the 4GL does it? I suspect that if the application sets SESSION:TOOLTIPS to false, that no more tooltips... Eugenie Lyzenko

06:42 PM Feature #2252: implement GUI client support

Code Review hc_upd20141218c.zip
The code looks good. The only note is that there is a @.classpath@ included which... Greg Shah

06:21 PM Feature #2252: implement GUI client support

> >1. Shouldn't the SwingGuiDriver.registerPendingTooltipWorkers() deregister the workers if the SESSION:TOOLTIPS cha... Greg Shah

03:51 PM Feature #2252: implement GUI client support

>1. Shouldn't the SwingGuiDriver.registerPendingTooltipWorkers() deregister the workers if the SESSION:TOOLTIPS chang... Eugenie Lyzenko

02:47 PM Feature #2252: implement GUI client support

Code Review evl_upd20141218b.zip
1. Shouldn't the @SwingGuiDriver.registerPendingTooltipWorkers()@ deregister the ... Greg Shah

08:15 PM Feature #2252: implement GUI client support

This is the bug fixing for recent update after new features testing:
1. When setting tooltip to unknown we need to... Eugenie Lyzenko

07:17 PM Feature #2252: implement GUI client support

In regard to #2424.
The attached update resolves all the discovered regressions, i.e. appserver/batch mode unhandl... Hynek Cihlar

04:02 PM Feature #2422: add features to BROWSE

svl_upd20141218a.zip was committed into bzr rev 10684. Stanislav Lomany

03:17 PM Feature #2422: add features to BROWSE

Code Review svl_upd20141218a.zip
It looks good. Please do check it in. Greg Shah

02:29 PM Feature #2422: add features to BROWSE

Just for the case, please review the update which passed regression testing so I can check it in. Stanislav Lomany

11:25 AM Feature #2422: add features to BROWSE

Stanislav Lomany wrote:
> No, the same effect may by achieved by updating browse records in background.
OK. Plea... Greg Shah

10:49 AM Feature #2422: add features to BROWSE

No, the same effect may by achieved by updating browse records in background. Stanislav Lomany

08:42 AM Feature #2422: add features to BROWSE

Stanislav Lomany wrote:
> About NO-ASSIGN option - in 4GL when a value wasn't assigned, the cell screen value is rev... Greg Shah

08:29 AM Feature #2422: add features to BROWSE

About NO-ASSIGN option - in 4GL when a value wasn't assigned, the cell screen value is reverted to its database value... Stanislav Lomany

12:04 PM Feature #1790: implement menu support

> The reference @menu-item mi:label in sub-menu sm@ must be converted to the following code @sm.mi.setLabel("New mi l... Greg Shah

12/18/2014

03:17 PM Feature #2252: implement GUI client support

This update for review contains project of the complete tooltip solution. If there is no tooltips or session based @T... Eugenie Lyzenko

02:41 PM Feature #1790: implement menu support

Vadim Gindin wrote:
> ... Is it because every widget is already annotated with "frame-id"?
Yes.
You should find ... Constantin Asofiei

02:33 PM Feature #1790: implement menu support

Constantin, about @IN ...@ clauses. I've converted simple test for frames with the trigger... Vadim Gindin

12:17 PM Feature #1790: implement menu support

I'm working with non-standard type of menu-item reference @menu-item mi in sub-menu sm@. Peculiarity of this referenc... Vadim Gindin

12/17/2014

03:53 PM Feature #1790: implement menu support

Oh..
Sorry.
Constantin, thank you too. I'll process your remarks. Vadim Gindin

03:34 PM Feature #1790: implement menu support

You have a syntax problem with your code @<action> on="false">@. There is an extra @>@ there.
Also, you can remov... Greg Shah

03:33 PM Feature #1790: implement menu support

Vadim, some questions:
# what is the expected converted form for the @menu-item mi:label in menu m = "MMMM".@ code? ... Constantin Asofiei

03:04 PM Feature #1790: implement menu support

I have some difficulty working with references. I've added the following rule to @widget_references.rules@:... Vadim Gindin

12:36 PM Feature #2252: implement GUI client support

>
> It is very good. My only suggestion is that @SessionUtils.setSessionTooltips()@ needs to handle @null@ and unk... Eugenie Lyzenko

12:19 PM Feature #2252: implement GUI client support

Code Review evl_upd20141217a.zip
It is very good. My only suggestion is that @SessionUtils.setSessionTooltips()@ ... Greg Shah

11:57 AM Feature #2252: implement GUI client support

This update for review is not yet completed for tooltip implementation and image integration into button. But it pres... Eugenie Lyzenko

12/16/2014

04:26 PM Feature #2252: implement GUI client support

The @evl_upd20141215b.zip@ has been committed in bzr as 10681. Eugenie Lyzenko

04:11 PM Feature #2252: implement GUI client support

The CTRL-C part passed in a single round. The test results is @10680_532468b_20141216_evl.zip@ - on the shared direct... Eugenie Lyzenko

02:18 PM Feature #2252: implement GUI client support

The main part of the @evl_upd20141215b.zip@ runtime testing completed without regressions. Continue testing for CTRL-... Eugenie Lyzenko

10:47 AM Feature #2252: implement GUI client support

> 1. The server side code will be located in p2j/util/SessionUtils class. Here we call current client session via LT.... Greg Shah

09:51 AM Feature #2252: implement GUI client support

>1. Please add support for the SESSION:TOOLTIPS attribute to enable/disable tooltips in the client.
The implementa... Eugenie Lyzenko

09:08 AM Feature #2252: implement GUI client support

>My only question is about the new constructor in @Image.java@. It ignores the passed in @ImageConfig@ instance. Is t... Eugenie Lyzenko

08:48 AM Feature #2252: implement GUI client support

Code Review evl_upd20141215b.zip
My only question is about the new constructor in @Image.java@. It ignores the pa... Greg Shah

08:20 PM Feature #2252: implement GUI client support

The conversion testing completed. The generated codes are identical. Starting the runtime testing. Eugenie Lyzenko

04:00 PM Feature #2422: add features to BROWSE

I'll just put here the list of remaining features to implement:
NO-ASSIGN - implement
DELETE-SELECTED-ROW - imp... Stanislav Lomany

11:45 AM Feature #2422: add features to BROWSE

After you have this update finalized and into testing, please work on the rest of the non-GUI features in the origina... Greg Shah

11:42 AM Feature #2422: add features to BROWSE

Code Review svl_upd20141216a.zip
1. @Browse@, @BrowseImpl@ and @BrowseWidgetb@ should only have a single history e... Greg Shah

11:09 AM Feature #2422: add features to BROWSE

Update for review. Implements NUM-LOCKED-COLUMNS. Based on svl_upd20141210a.zip. Stanislav Lomany

02:56 PM Feature #1790: implement menu support

The only way to use "imported" shared menu reference is LIKE clause in DEFINE MENU or DEFINE SUB-MENU statements, for... Vadim Gindin

01:18 PM Feature #1790: implement menu support

OK, then it seems shared menus are in fact like shared variables. There is really just 1 instance and "importing" sh... Greg Shah

12:49 PM Feature #1790: implement menu support

Yes, it does. Vadim Gindin

12:09 PM Feature #1790: implement menu support

> > Do all the menu-items and sub-menus defined in the calling procedure still appear and work? If so, I assume they... Greg Shah

12:02 PM Feature #1790: implement menu support

Greg Shah wrote:
..
> Are the changes made in the called procedure also visible in the calling procedure? Can the... Vadim Gindin

10:26 AM Feature #1790: implement menu support

Vadim Gindin wrote:
> 2 questions about MENU-ITEM references or SUB-MENU references.
> # Such objects are emitted ... Greg Shah

10:24 AM Feature #1790: implement menu support

> > > I changed labels in external procedure for shared menu created in main procedure. It was changed.
> >
> > Do... Greg Shah

09:32 AM Feature #1790: implement menu support

2 questions about MENU-ITEM references or SUB-MENU references.
# Such objects are emitted as fields of menu (or sub... Vadim Gindin

01:47 AM Feature #1790: implement menu support

Greg Shah wrote:
> > I changed labels in external procedure for shared menu created in main procedure. It was change... Vadim Gindin

12/15/2014

06:41 PM Feature #2252: implement GUI client support

> Code Review evl_upd20141215a.zip
>
> It looks good. You can check it in if it passes testing.
Really I've lo... Eugenie Lyzenko

05:28 PM Feature #2252: implement GUI client support

Code Review evl_upd20141215a.zip
It looks good. You can check it in if it passes testing. Greg Shah

05:26 PM Feature #2252: implement GUI client support

>> 3. In ButtonGuiImpl.initialize(), should we always call registerTooltipWorker() unconditionally? What if SESSION:T... Greg Shah

04:59 PM Feature #2252: implement GUI client support

>1. Please add support for the SESSION:TOOLTIPS attribute to enable/disable tooltips in the client.
OK.
>2. I s... Eugenie Lyzenko

04:14 PM Feature #2252: implement GUI client support

The attached update is will be tested shortly for conversion and runtime regressions. Eugenie Lyzenko

01:36 PM Feature #2252: implement GUI client support

Code Review evl_upd20141212a.zip
1. Please add support for the @SESSION:TOOLTIPS@ attribute to enable/disable tool... Greg Shah

01:23 PM Feature #2252: implement GUI client support

Code Review evl_upd20141209a.zip
This is good. Please make the changes listed below and get this tested.
1. Th... Greg Shah

05:36 PM Feature #2422: add features to BROWSE

There is a minor issue for editable browse remains, I expect to fix it and send the update tomorrow. Stanislav Lomany

01:56 PM Feature #2422: add features to BROWSE

Code Review svl_upd20141210a.zip
The changes look very good.
When can I expect the final update? I'd like to g... Greg Shah

04:26 PM Feature #1790: implement menu support

> I changed labels in external procedure for shared menu created in main procedure. It was changed.
Does this mean... Greg Shah

04:06 PM Feature #1790: implement menu support

I've tested shared menus. As far as I can understand there are one instance of menu is used for created shared menu a... Vadim Gindin

11:52 AM Feature #1790: implement menu support

Code Review vig_upd20141213a.zip
I generally like the changes.
1. Removing the @on="false"@ from line 511 of @l... Greg Shah

11:26 AM Feature #1790: implement menu support

> But I have one difficulty here: literals was removed but semicolons are stayed. Could you help me?
I suspect tha... Greg Shah

11:18 AM Feature #1790: implement menu support

> 1. I missed one attribute in @MenuItemWidget@ called "SUBTYPE". It has character type and can contain one of follow... Greg Shah

09:54 AM Feature #1790: implement menu support

I am working my way through the pending updates and questions.
While I am doing that, I wanted to answer your ques... Greg Shah

04:33 AM Feature #1790: implement menu support

The question about shared menus. The problem is in try to generate menu definition second time when DEFINE SHARED MEN... Vadim Gindin

12/13/2014

05:34 AM Feature #1790: implement menu support

Another remained issues.
* TITLE attribute of the Menu
* LIKE clauses Vadim Gindin

12/12/2014

05:30 PM Feature #1790: implement menu support

The next update contains corrections of previous notes and dynamic menus creation support.
* About literals, that ar... Vadim Gindin

10:46 AM Feature #1790: implement menu support

Greg, I have some difficulties with dynamic menus.
1. I missed one attribute in @MenuItemWidget@ called "SUBTYPE". I... Vadim Gindin

10:46 AM Feature #2252: implement GUI client support

This update for review contains reworked tooltip implementation. Now it is not associated with button so can easily b... Eugenie Lyzenko

10:13 AM Feature #2422: add features to BROWSE

About NUM-LOCKED-COLUMNS. It may be the case for an editing browse that available (non-locked) width is less than the... Stanislav Lomany

12/10/2014

09:45 AM Feature #2422: add features to BROWSE

Update for review. Contains functions listed in note 27 except NUM-LOCKED-COLUMNS. Stanislav Lomany

12/09/2014

06:49 AM Feature #2252: implement GUI client support

Merged with recent changes. Eugenie Lyzenko

08:37 PM Feature #2252: implement GUI client support

This update for review is first step for image widget conversion and runtime support. But enough to see the screen sh... Eugenie Lyzenko

12/08/2014

02:12 PM Feature #2252: implement GUI client support

Constantin Asofiei wrote:
> Constantin Asofiei wrote:
> > I'll try to re-write the calc app without relying on the ... Constantin Asofiei

11:45 AM Feature #2252: implement GUI client support

Constantin Asofiei wrote:
> I'll try to re-write the calc app without relying on the X/Y coordinates in the mean tim... Constantin Asofiei

11:19 AM Feature #2252: implement GUI client support

Hynek,
My attached update is built on top of your 1208b.zip update (is still unfinished, but it doesn't have any C... Constantin Asofiei

08:11 AM Feature #2252: implement GUI client support

Hynek Cihlar wrote:
> There was no reason to differentiate ChUI/non-ChUI for LT.getHeightChars, and this was fixed.... Constantin Asofiei

07:59 AM Feature #2252: implement GUI client support

Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > Please review the attached changes. All points from the review ... Hynek Cihlar

07:33 AM Feature #2252: implement GUI client support

Hynek Cihlar wrote:
> Please review the attached changes. All points from the review addressed, except for the @load... Constantin Asofiei

07:09 AM Feature #2252: implement GUI client support

Please review the attached changes. All points from the review addressed, except for the @load_descriptors@ in method... Hynek Cihlar

12/07/2014

06:39 PM Feature #2252: implement GUI client support

Constantin, thanks for the inputs. I will finish your suggestions in the morning. Btw. the regression testing goes we... Hynek Cihlar

06:24 PM Feature #2252: implement GUI client support

Hynek Cihlar wrote:
> Constantin Asofiei wrote:
> > Have you done some performance tests?
>
> Yes, but so far o... Constantin Asofiei

06:10 PM Feature #2252: implement GUI client support

Pls ignore hc_upd20141207e.zip, it didn't contain the changes in @SwingGuiPrimitives@. See the attached instead. Hynek Cihlar

06:07 PM Feature #2252: implement GUI client support

Constantin Asofiei wrote:
> Have you done some performance tests?
Yes, but so far only in ChUI. The performance ... Hynek Cihlar

04:56 PM Feature #2252: implement GUI client support

Hynek, I don't see anything wrong with the logic. BTW, I like the idea using the withinClientPoint to reduce the aspe... Constantin Asofiei

03:07 PM Feature #2252: implement GUI client support

This is for #2424.
The attached file includes changes for review and contains the following.
- Implemented synchron... Hynek Cihlar

07:42 AM Feature #1811: implement the AJAX client driver

Constantin Asofiei wrote:
> Fixes a starvation problem while reading keys via the web client driver. Will runtime te... Constantin Asofiei

12/06/2014

03:28 PM Feature #1811: implement the AJAX client driver

Fixes a starvation problem while reading keys via the web client driver. Will runtime test it. Constantin Asofiei

02:17 PM Feature #2252: implement GUI client support

My latest update merged with bzr rev 10677. Greg Shah

12:59 PM Feature #2252: implement GUI client support

Greg Shah wrote:
> Code Review ca_upd20141206b.zip
>
> It looks good, release it.
Released to bzr rev 10677. Constantin Asofiei

12:56 PM Feature #2252: implement GUI client support

Code Review ca_upd20141206b.zip
It looks good, release it. Greg Shah

12:51 PM Feature #2252: implement GUI client support

Greg, I want to reduce the load on the changes I need to maintain; following is a GUI-only subset of 1205e.zip which ... Constantin Asofiei

12:07 PM Feature #2252: implement GUI client support

The update @evl_upd20141206a.zip@ committed in bzr as 10676. Eugenie Lyzenko

12:00 PM Feature #2252: implement GUI client support

Simple navigation tests for @evl_upd20141206a.zip@ show no regression. So I'm starting to commit and release this upd... Eugenie Lyzenko

11:35 AM Feature #2252: implement GUI client support

The update @evl_upd20141205b.zip@ has been committed in bzr as 10675. Eugenie Lyzenko

11:22 AM Feature #2252: implement GUI client support

Greg Shah wrote:
> I don't think we need to wait for @CTRL-C@ in this case. The changes are quite far away. Please... Eugenie Lyzenko

11:16 AM Feature #2252: implement GUI client support

I don't think we need to wait for @CTRL-C@ in this case. The changes are quite far away. Please go ahead and check ... Greg Shah

11:14 AM Feature #2252: implement GUI client support

The main part for @evl_upd20141205b.zip@ completed without regressions. Waiting for CTRL-C to be done. Eugenie Lyzenko

09:27 AM Feature #2252: implement GUI client support

>Eugenie, please do only a simple test in MAJIC: apply your update, start the server and do some simple navigation wi... Eugenie Lyzenko

09:19 AM Feature #2252: implement GUI client support

Greg Shah wrote:
> Code Review evl_upd20141206a.zip
>
> It looks good. Off the top of my head I think the color-... Constantin Asofiei

09:12 AM Feature #2252: implement GUI client support

Code Review ca_upd20141205e.zip
This is awesome! I'm blown away that you've been able to get so far in editing wi... Greg Shah

08:40 AM Feature #2252: implement GUI client support

Code Review evl_upd20141206a.zip
It looks good. Off the top of my head I think the color-table support is only re... Greg Shah

08:30 AM Feature #2252: implement GUI client support

>In what class do you propose to define these values? This should be separate from the loading code (like how we stor... Eugenie Lyzenko

08:22 AM Feature #2252: implement GUI client support

In what class do you propose to define these values? This should be separate from the loading code (like how we stor... Greg Shah

08:29 PM Feature #2252: implement GUI client support

Default Progress color table(always exists in Windows)... Eugenie Lyzenko

07:47 PM Feature #2252: implement GUI client support

Greg,
This version (although needs more cleanup/javadocs) is under regression testing. Please take a look, if you... Constantin Asofiei

07:28 PM Feature #2252: implement GUI client support

The conversion testing for @evl_upd20141205b.zip@ completed. The generated files are identical.
Started the runtim... Eugenie Lyzenko

12/05/2014

06:20 PM Feature #1790: implement menu support

Code Review vig_upd20141206a.zip
1. @WindowWidget.setMenubar(handle)@ should check for null and unknown can take t... Greg Shah

04:31 PM Feature #1790: implement menu support

I added @menu-item@ attributes conversion and fixed @menubar@ conversion.
The question. Although I added @relative... Vadim Gindin

04:25 PM Feature #2252: implement GUI client support

Eugenie Lyzenko wrote:
> >unfortunately there is one more regression: the window scrollbars are no longer responsive... Constantin Asofiei

04:14 PM Feature #2252: implement GUI client support

>unfortunately there is one more regression: the window scrollbars are no longer responsive after H003/H004 in Window... Eugenie Lyzenko

03:54 PM Feature #2252: implement GUI client support

Greg Shah wrote:
> Code Review ca_upd20141205d.zip
>
> Its good. Release it.
Released to rev 10674. Constantin Asofiei

03:53 PM Feature #2252: implement GUI client support

Greg Shah wrote:
> Code Review evl_upd20141205b.zip
>
> I like it. Please get it tested.
OK. The conversion t... Eugenie Lyzenko

03:47 PM Feature #2252: implement GUI client support

Eugenie Lyzenko wrote:
> > 2. in ButtonGuiImpl, you were calling drawing code directly from mouse events.
>
> Wha... Constantin Asofiei

03:43 PM Feature #2252: implement GUI client support

>unfortunately there is one more regression: the window scrollbars are no longer responsive after H003/H004 in Window... Eugenie Lyzenko

03:39 PM Feature #2252: implement GUI client support

Code Review evl_upd20141205b.zip
I like it. Please get it tested. Greg Shah

03:37 PM Feature #2252: implement GUI client support

Code Review ca_upd20141205d.zip
Its good. Release it. Greg Shah

03:26 PM Feature #2252: implement GUI client support

> 2. in ButtonGuiImpl, you were calling drawing code directly from mouse events.
What do you mean? Except show/hid... Eugenie Lyzenko

03:13 PM Feature #2252: implement GUI client support

>...Doesn't @FileSystemOps.searchPath()@ already have the functionality to honor/mimic the source system's case sensi... Eugenie Lyzenko

03:09 PM Feature #2252: implement GUI client support

Greg, this is for the "ghost" drawing problems. It affects only the GUI code, so it can be released.
Eugenie:
* ... Constantin Asofiei

02:30 PM Feature #2252: implement GUI client support

Code Review evl_upd20141205a.zip
This is a really good update. My only concern is that @LogicalTerminal.loadImage(... Greg Shah

11:25 AM Feature #2252: implement GUI client support

Greg Shah wrote:
> Code Review ca_upd20141204d.zip
>
> The changes look good. Please get it tested.
Passed runt... Constantin Asofiei

11:01 AM Feature #2252: implement GUI client support

This update for review includes all required to work with icon loading into window title bar. Including testcases to ... Eugenie Lyzenko

08:15 PM Feature #2252: implement GUI client support

This update for review includes conversion and runtime support for methods @LOAD-ICON@ and @LOAD-SMALL-ICON@ for wind... Eugenie Lyzenko

12/04/2014

05:11 PM Feature #2252: implement GUI client support

Code Review ca_upd20141204d.zip
The changes look good. Please get it tested. Greg Shah

05:04 PM Feature #2252: implement GUI client support

Some NPE fixes related to client restart on CTRL-C (or restart caused by other unrelated abends). Constantin Asofiei

04:38 PM Feature #1790: implement menu support

This is a good question. The answer is that we don't actually create a @new handle()@ constructor for the @ATTR_HAND... Greg Shah

03:47 PM Feature #1790: implement menu support

How about menu handle? I need that @menu m1:handle@ will be converted to @new handle(m1)@. Where it happens with fram... Vadim Gindin

02:50 PM Feature #1790: implement menu support

> Now I think that menu_generator.xml is better place because fixups/post_parse_fixups.xml is too early (there was n... Greg Shah

12:29 PM Feature #1790: implement menu support

Greg Shah wrote:
>..
> I see you tried to use @evalLib('methods_and_attributes')@. @evalLib()@ and @execLib()@ are... Vadim Gindin

10:08 AM Feature #1790: implement menu support

> I found @widget_reference.rules@ and tried to add the following rules
As I mentioned in note 56 above, you just ... Greg Shah

05:48 AM Feature #2412: Implement widget browser

Hynek Cihlar wrote:
> The attached file was committed to bzr revision 10671.
>
> It contains the following change... Hynek Cihlar

05:44 AM Feature #2412: Implement widget browser

The attached file was committed to bzr revision 10671.
It contains the following changes to Widget browser.
- W... Hynek Cihlar