Activity
From 02/04/2016 to 03/04/2016
03/04/2016
- 05:27 PM Bug #2914 (Closed): Fix errors in window_sizing/test_runner.p
- 05:26 PM Bug #2914: Fix errors in window_sizing/test_runner.p
- Greg Shah wrote:
> I can close this task, right?
Yes, please. - 05:12 PM Bug #2914: Fix errors in window_sizing/test_runner.p
- I can close this task, right?
- 05:10 PM Bug #2914: Fix errors in window_sizing/test_runner.p
- 2914a committed to trunk as rev 10979 and archived.
- 04:58 PM Bug #2914: Fix errors in window_sizing/test_runner.p
- Code Review Task Branch 2914a Revision 10998
The changes are good.
Please merge this to trunk. - 04:56 PM Bug #2914: Fix errors in window_sizing/test_runner.p
- 2914a passed ChUI regression tests. Note that the regression fix in 10998 only affects GUI code.
- 04:53 PM Bug #2914: Fix errors in window_sizing/test_runner.p
- Greg Shah wrote:
> Code Review Task Branch 2914a Revision 10997
>
> You're right, I had not reverted. It was my ... - 04:49 PM Bug #2914: Fix errors in window_sizing/test_runner.p
- Code Review Task Branch 2914a Revision 10997
You're right, I had not reverted. It was my mistake, sorry.
Pleas... - 04:43 PM Bug #2914: Fix errors in window_sizing/test_runner.p
- Greg Shah wrote:
> Code Review Task Branch 2914a Revision 10997
>
> This revision is not compilable.
>
> 1. Th... - 04:16 PM Bug #2914: Fix errors in window_sizing/test_runner.p
- Code Review Task Branch 2914a Revision 10997
This revision is not compilable.
1. There are merge problems with ... - 08:57 AM Bug #2914: Fix errors in window_sizing/test_runner.p
- Please review 2914a rev 10997. It is a release candidate with all the required changes for this issue.
Note that Ch... - 05:23 PM Bug #3013: The mouse wheel doesn't work if the mouse pointer is over scrollbars
- Greg Shah wrote:
> I don't understand. Does note 19 describe a bug or not?
>
> At a minimum, there is confusion ... - 05:18 PM Bug #3013: The mouse wheel doesn't work if the mouse pointer is over scrollbars
- I don't understand. Does note 19 describe a bug or not?
At a minimum, there is confusion here so perhaps some cla... - 05:12 PM Bug #3013: The mouse wheel doesn't work if the mouse pointer is over scrollbars
- Greg Shah wrote:
> > This is actually a bad wording in the test plan.
>
> Igor: please update the test plan to b... - 04:54 PM Bug #3013: The mouse wheel doesn't work if the mouse pointer is over scrollbars
- > This is actually a bad wording in the test plan.
Igor: please update the test plan to be accurate. - 04:54 PM Bug #3013: The mouse wheel doesn't work if the mouse pointer is over scrollbars
- I like the approach (in 3013_2.txt), please go ahead.
- 04:53 PM Bug #3013: The mouse wheel doesn't work if the mouse pointer is over scrollbars
- Sergey Ivanovskiy wrote:
> In p2j trunc version @uast/mouse/load-mouse-pointer.p@ doesn't pass the 1 test
> [...]
... - 04:30 PM Bug #3013: The mouse wheel doesn't work if the mouse pointer is over scrollbars
- Planning to commit this diff that moves 1811t to be the same as p2j, but it doesn't fix these bugs, because there are...
- 04:18 PM Bug #3013: The mouse wheel doesn't work if the mouse pointer is over scrollbars
- In p2j trunc version @uast/mouse/load-mouse-pointer.p@ doesn't pass the 1 test...
- 01:06 PM Bug #3013: The mouse wheel doesn't work if the mouse pointer is over scrollbars
- Another reason with @AbstractContainer.findMouseSource@ it can impact the focus management.
- 11:47 AM Bug #3013: The mouse wheel doesn't work if the mouse pointer is over scrollbars
- The things are very complicated because I suspect the test 1 for p2j trunc in the case of COMBO-BOX SIMPLE
because if... - 10:53 AM Bug #3013: The mouse wheel doesn't work if the mouse pointer is over scrollbars
- I understand the great work has been done with custom cursors, this test is really complicated and it looks that thes...
- 09:54 AM Bug #3013: The mouse wheel doesn't work if the mouse pointer is over scrollbars
- Igor Skornyakov wrote:
> Sergey Ivanovskiy wrote:
> > Do you have some tests to check it?
>
> The test for the c... - 09:53 AM Bug #3013: The mouse wheel doesn't work if the mouse pointer is over scrollbars
- Sergey Ivanovskiy wrote:
> Do you have some tests to check it?
The test for the custom cursor functionality is @u... - 09:51 AM Bug #3013: The mouse wheel doesn't work if the mouse pointer is over scrollbars
- Igor: please explain to Sergey, how to test the custom cursor for combo-box.
Sergey: If it is broken, please find ... - 09:50 AM Bug #3013: The mouse wheel doesn't work if the mouse pointer is over scrollbars
- Igor Skornyakov wrote:
> Sergey Ivanovskiy wrote:
> > I have check the behavior of the default cursor with combo bo... - 09:47 AM Bug #3013: The mouse wheel doesn't work if the mouse pointer is over scrollbars
- Sergey Ivanovskiy wrote:
> I have check the behavior of the default cursor with combo box, but how it can be if the ... - 09:44 AM Bug #3013: The mouse wheel doesn't work if the mouse pointer is over scrollbars
- I have check the behavior of the default cursor with combo box, but how it can be if the custom don't work while the ...
- 09:40 AM Bug #3013: The mouse wheel doesn't work if the mouse pointer is over scrollbars
- Igor Skornyakov wrote:
> Greg Shah wrote:
> > Code Review Task Branch 1811t Revision 11051
> >
> > I'm fine with... - 09:31 AM Bug #3013: The mouse wheel doesn't work if the mouse pointer is over scrollbars
- Greg Shah wrote:
> Code Review Task Branch 1811t Revision 11051
>
> I'm fine with the changes.
>
> My only con... - 09:11 AM Bug #3013: The mouse wheel doesn't work if the mouse pointer is over scrollbars
- > Code Review Task Branch 1811t Revision 11051
>
> My only concern is that the changes were put there for a specif... - 08:58 AM Bug #3013: The mouse wheel doesn't work if the mouse pointer is over scrollbars
- Code Review Task Branch 1811t Revision 11051
I'm fine with the changes.
My only concern is that the changes wer... - 04:56 PM Support #2672: GUI web client performance improvements
- > So, the runtime will have just a flag check - the overall impact will be minimal, no reflection involved.
Good i... - 04:52 PM Support #2672: GUI web client performance improvements
- Greg Shah wrote:
> On the other hand, if most APIs are safe for the bypass, then I wouldn't want to edit all of them... - 04:44 PM Support #2672: GUI web client performance improvements
- > But the other idea - to discard the StateSync part from the message completely (thus don't even call getChanges or ...
- 04:38 PM Support #2672: GUI web client performance improvements
- Greg Shah wrote:
> > I will document them here (and in the P2J code, where the attributes are defined).
>
> Good... - 04:37 PM Support #2672: GUI web client performance improvements
- Greg Shah wrote:
> I'm surprised that this would be possible. I thought that we have cases where we allow changes t... - 04:24 PM Support #2672: GUI web client performance improvements
- > I will document them here (and in the P2J code, where the attributes are defined).
Good.
If you want to merg... - 04:23 PM Support #2672: GUI web client performance improvements
- > I think is better a reverse approach: mark only the APIs which actually affect the UI. Because there are other sta...
- 04:10 PM Support #2672: GUI web client performance improvements
- Greg Shah wrote:
> > For cases like ServerExports or ClientExports APIs which need only get some server-side state o... - 03:59 PM Support #2672: GUI web client performance improvements
- Greg Shah wrote:
> My only question: what was the process that you used to determine these attributes were safe to t... - 03:56 PM Support #2672: GUI web client performance improvements
- Code Review Task Branch 2672a Revision 10980
I'm OK with the changes.
My only question: what was the process th... - 03:02 PM Support #2672: GUI web client performance improvements
- Greg Shah wrote:
> > 2672a revision 10980 adds no-op for attribute setters which allow this, but the impact is not s... - 01:53 PM Support #2672: GUI web client performance improvements
- > For cases like ServerExports or ClientExports APIs which need only get some server-side state or data (and are non-...
- 12:40 PM Support #2672: GUI web client performance improvements
- In a BROWSE widget, for a single mouse click in a row, there are 6 client-server trips for just this row selection. ...
- 12:25 PM Support #2672: GUI web client performance improvements
- 1811t rev 11053 compacts the "enable OS events" calls for the web driver, in a single call: all window IDs are passed...
- 04:33 PM Bug #2849: implement and/or fix the default popup menus for all widgets
- Vadim, please rebase the branch to latest trunk.
- 02:22 PM Bug #2849: implement and/or fix the default popup menus for all widgets
- > I've fixed the first remark... What about others?
As Hynek notes, we have some significant changes coming for th... - 02:19 PM Bug #2849: implement and/or fix the default popup menus for all widgets
- > Some items in window title bar popup have icons, such as Close, Maximize, Minimize, Restore. Should I implement ico...
- 07:37 AM Bug #2849: implement and/or fix the default popup menus for all widgets
- I've fixed the first remark... What about others?
- 05:26 AM Bug #2849: implement and/or fix the default popup menus for all widgets
- Vadim Gindin wrote:
> I've fixed popup imlementation for dialog boxes. Please review. Revision 11005.
* @MousePop... - 03:45 AM Bug #2849: implement and/or fix the default popup menus for all widgets
- I've fixed popup imlementation for dialog boxes. Please review. Revision 11005.
Some items in window title bar pop... - 02:33 PM Feature #2564: implement GUI BROWSE widget
- Rebased task branch 2564f from P2J trunk revision 10988.
- 01:14 PM Bug #3015: Frame scrolling is broken
- When frame content is scrolled, it is redrawn with artifacts. This can be reproduced in @uast/demo/demo_widgets.p@.
- 01:12 PM Bug #3015 (New): Frame scrolling is broken
- 09:48 AM Bug #2954: Focus is not put on the expected widget when window activated
- Yes, correct. I don't think the other modules need to use it. The message types should be hidden inside @p2j.socket...
- 09:17 AM Bug #2954: Focus is not put on the expected widget when window activated
- Greg Shah wrote:
> To be clear, I'm suggesting that all the constants should be in a private var inside @p2j.sockets... - 09:15 AM Bug #2954: Focus is not put on the expected widget when window activated
- To be clear, I'm suggesting that all the constants should be in a private var inside @p2j.sockets.js@.
- 09:13 AM Bug #2954: Focus is not put on the expected widget when window activated
- Code Review Task Branch 1811t Revision 11052
I don't see the need to expose all of these constants as public data....
03/03/2016
- 04:48 PM Bug #2914: Fix errors in window_sizing/test_runner.p
- Rebased task branch 2914a against trunk revision 10978. 2914a is now at revision 10996.
- 03:46 PM Bug #2914: Fix errors in window_sizing/test_runner.p
- During frame setup when a client remote call is performed the frame may be considered dead and removed from the clien...
- 02:23 PM Bug #2954: Focus is not put on the expected widget when window activated
- Greg, please review committed revision 11052 that adds named constants @p2j.constants.js@.
- 08:09 AM Bug #2954: Focus is not put on the expected widget when window activated
- Sergey Ivanovskiy wrote:
> Constantin, could you help to explain the issue in note 23? It is important to fix its re... - 06:22 AM Bug #2954: Focus is not put on the expected widget when window activated
- I need to extend its definition as ...
- 06:10 AM Bug #2954: Focus is not put on the expected widget when window activated
- Igor Skornyakov wrote:
> Sergey Ivanovskiy wrote:
> > I don't understand what is @AbstractContainer.findMouseSource... - 06:06 AM Bug #2954: Focus is not put on the expected widget when window activated
- Sergey Ivanovskiy wrote:
> I don't understand what is @AbstractContainer.findMouseSource@. I need the answer to fix ... - 05:59 AM Bug #2954: Focus is not put on the expected widget when window activated
- Igor Skornyakov wrote:
> Sergey Ivanovskiy wrote:
> > To be more concrete please look at these changes and the functi... - 02:50 AM Bug #2954: Focus is not put on the expected widget when window activated
- Sergey Ivanovskiy wrote:
> To be more concrete please look at these changes and the function definition
> [...]
> ... - 01:06 AM Bug #2954: Focus is not put on the expected widget when window activated
- To be more concrete please look at these changes and the function definition...
- 12:00 AM Bug #2954: Focus is not put on the expected widget when window activated
- Sergey Ivanovskiy wrote:
> Ok, the previous 1811t code have able to detect if the mouse is over the scroll bars but n... - 01:16 PM Bug #3013: The mouse wheel doesn't work if the mouse pointer is over scrollbars
- Sergey Ivanovskiy wrote:
> Web client - For the old version 1811t if the mouse pointer is over the scroll bars, then... - 01:00 PM Bug #3013: The mouse wheel doesn't work if the mouse pointer is over scrollbars
- Web client - For the old version 1811t if the mouse pointer is over the scroll bars, then the target scroll bar gets ...
- 11:15 AM Bug #3013: The mouse wheel doesn't work if the mouse pointer is over scrollbars
- Greg, please review committed revision 11051. It fixed the part 1). Tested with Swing and Web clients. The rest part ...
- 09:59 AM Bug #3013: The mouse wheel doesn't work if the mouse pointer is over scrollbars
- The code from @AbstractWidget@ implements this function unconditionally to a possible widget id....
- 09:44 AM Bug #3013: The mouse wheel doesn't work if the mouse pointer is over scrollbars
- 1) in ./demo/demo_widgets.p (com.goldencode.testcases.demo.DemoWidgets.execute) the editor doesn't scroll its content...
- 09:36 AM Bug #3013 (Closed): The mouse wheel doesn't work if the mouse pointer is over scrollbars
- 09:06 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- It is a good idea. I'll add it.
- 03:57 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- Greg.
I've added the test for the LOAD-MOUSE-CURSOR and the test plan (@uast/mouse/load-mouse-pointer.p@ and @uast/m... - 05:39 AM Bug #2849: implement and/or fix the default popup menus for all widgets
- Vadim Gindin wrote:
> I faced with the following problem. Window title popup menu is always shown under title bar fo... - 05:12 AM Bug #2849: implement and/or fix the default popup menus for all widgets
- I faced with the following problem. Window title popup menu is always shown under title bar for @DialogBoxWindow@. I'...
03/02/2016
- 01:58 PM Bug #2954: Focus is not put on the expected widget when window activated
- Ok, the previous 1811t code have able to detect if the mouse is over the scroll bars but now all events are delivered...
- 01:33 PM Bug #2954: Focus is not put on the expected widget when window activated
- Sergey Ivanovskiy wrote:
> Yes, it is a regression in 1811t. The complexity here appears due to the GUI classes hier... - 01:30 PM Bug #2954: Focus is not put on the expected widget when window activated
- Yes, it is a regression in 1811t. The complexity here appears due to the GUI classes hierarchy of ScrollPane and Scro...
- 01:21 PM Bug #2954: Focus is not put on the expected widget when window activated
- Sergey Ivanovskiy wrote:
> Found a regression in @./demo/demo_widgets.p@ (@com.goldencode.testcases.demo.DemoWidgets... - 01:16 PM Bug #2954: Focus is not put on the expected widget when window activated
- Planning to do it. Found a regression in @./demo/demo_widgets.p@ (@com.goldencode.testcases.demo.DemoWidgets.execute@...
- 12:54 PM Bug #2954: Focus is not put on the expected widget when window activated
- > I think that such kind of errors can be eliminated if names are used instead of numeric constants in p2j.socket.js...
- 12:41 PM Bug #2954: Focus is not put on the expected widget when window activated
- Committed revision 11050. Now 1811t is safe to use. I think that such kind of errors can be eliminated if names are u...
- 12:30 PM Bug #2954: Focus is not put on the expected widget when window activated
- Sorry, it is due to messages constants.
- 12:27 PM Bug #2954: Focus is not put on the expected widget when window activated
- Please, don't update from 1811t. After rebase the web client doesn't work. Investigating the reasons. The swing clien...
- 11:24 AM Bug #2954: Focus is not put on the expected widget when window activated
- Now 1811t grows from the current trunc. Encountered trivial history conflicts and the WebClientMessageTypes changes r...
- 09:01 AM Bug #2954: Focus is not put on the expected widget when window activated
- Sergey Ivanovskiy wrote:
> Igor, could you help I found this code in the trunc src/com/goldencode/p2j/ui/client/driv... - 09:00 AM Bug #2954: Focus is not put on the expected widget when window activated
- Igor, could you help I found this code in the trunc src/com/goldencode/p2j/ui/client/driver/web/res/p2j.socket.js (pl...
- 08:32 AM Bug #2954: Focus is not put on the expected widget when window activated
- Yes, it should be fixed.
- 08:10 AM Bug #2954: Focus is not put on the expected widget when window activated
- According to this diff from the trunk bzr diff -c10976 > 10976.txt...
- 08:02 AM Bug #2954: Focus is not put on the expected widget when window activated
- Misspelled history number was found in the current trunc in this module @src/com/goldencode/p2j/ui/client/gui/driver/...
- 07:01 AM Bug #2954: Focus is not put on the expected widget when window activated
- Planning to rebase 1811t from latest trunk.
- 08:41 AM Bug #2849: implement and/or fix the default popup menus for all widgets
- Vadim Gindin wrote:
> What window the method @GuiDriver.selectWindow(int windowId)@ can accept? Can it be @DialogBox... - 08:29 AM Bug #2849: implement and/or fix the default popup menus for all widgets
- What window the method @GuiDriver.selectWindow(int windowId)@ can accept? Can it be @DialogBox@ or only @Window@ id?
...
03/01/2016
- 04:12 PM Bug #2969 (Closed): websocket keep-alive
- 03:42 PM Bug #2969: websocket keep-alive
- It is done in 1811t.
- 04:11 PM Bug #2968: disconnect/reconnect and manual reload must re-establish the websocket connection, nee...
- > 3 Watchdog timer does the same, System.exit() is used to kill the spawn process in order to be able to create a new...
- 03:31 PM Bug #2968: disconnect/reconnect and manual reload must re-establish the websocket connection, nee...
- > Code Review Task Branch 1811t Revision 11038
Committed revision 11040, 11041 fixes 1,2,4.
3 Watchdog timer does the... - 10:15 AM Bug #2968: disconnect/reconnect and manual reload must re-establish the websocket connection, nee...
- Greg Shah wrote:
> Code Review Task Branch 1811t Revision 11038
>
> 1. With your fix to resolve the 2 hander issu... - 10:02 AM Bug #2968: disconnect/reconnect and manual reload must re-establish the websocket connection, nee...
- Code Review Task Branch 1811t Revision 11038
1. With your fix to resolve the 2 hander issue, reload should work fo... - 12:56 AM Bug #2968: disconnect/reconnect and manual reload must re-establish the websocket connection, nee...
- Sergey Ivanovskiy wrote:
> Greg Shah wrote:
> > Do NOT implement JS caching. It adds too many potential problems a... - 04:01 PM Bug #2956: When switching windows with Web GUI task bar the source window is not deactivated
- Is there anything left to do on this task?
- 01:05 PM Feature #2565 (Closed): implement runtime support for the SET-WAIT-STATE method
- 01:03 PM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- The task branch 2565a has been archived
- 12:44 PM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- The task branch 2565a revison 11068 has been merged to the trunk and committed as revision 10976.
- 12:35 PM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- Greg Shah wrote:
> Yes. I think your changes (since the last time CTRL-C testing passed) are safe enough.
OK. ac... - 12:34 PM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- Yes. I think your changes (since the last time CTRL-C testing passed) are safe enough.
- 12:27 PM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- Greg Shah wrote:
> Great!
>
> Please merge task branch 2565a revision 11068 to trunk and archive the branch.
W... - 12:26 PM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- Great!
Please merge task branch 2565a revision 11068 to trunk and archive the branch. - 12:25 PM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- Greg Shah wrote:
> OK, please run it in single mode or manually to see if it will work. The problem is probably not... - 12:16 PM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- OK, please run it in single mode or manually to see if it will work. The problem is probably not due to your changes...
- 12:14 PM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- Greg Shah wrote:
> What is the expected text?... - 12:12 PM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- What is the expected text?
- 12:11 PM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- Greg Shah wrote:
> > > Only @tc_codes_employees_021@
> >
> > Unfortunately this one is not expected to be failed ... - 12:10 PM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- > The regression test restated.
We don't want to do a full regression testing run to see if this will pass. Pleas... - 12:08 PM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- Eugenie Lyzenko wrote:
> Igor Skornyakov wrote:
> > Only @tc_codes_employees_021@
>
> Unfortunately this one is ... - 12:08 PM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- > > Only @tc_codes_employees_021@
>
> Unfortunately this one is not expected to be failed - need to get it passed ... - 12:06 PM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- Igor Skornyakov wrote:
> Only @tc_codes_employees_021@
Unfortunately this one is not expected to be failed - need... - 12:00 PM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- Igor Skornyakov wrote:
> BTW: selection on mouse drag for @FILL-IN@ doesn't work neither in trunk nor on 2565a.
Mou... - 11:59 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- Only @tc_codes_employees_021@ and @tc_job_002@ failed in two runs of the main part.
- 11:14 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- Constantin Asofiei wrote:
> Otherwise, I'm still a little worried about @AbstractContainer.findMouseSource@ change: i... - 11:05 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- Greg Shah wrote:
> Please post the @findMouseSource()@ testing results when you have them.
Gentlemen, I don't mea... - 10:52 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- Greg Shah wrote:
> Please post the @findMouseSource()@ testing results when you have them.
Sure. - 10:52 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- Please post the @findMouseSource()@ testing results when you have them.
- 10:34 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- Constantin Asofiei wrote:
> Review for 2565a rev 11067:
> # @Boolean ClientExports.setWaitState@ - please review al... - 09:47 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- Eugenie Lyzenko wrote:
> Igor Skornyakov wrote:
> > All @gso_ctrlc_tests@ passed, all @gso_ctrlc_3way_tests@ failed... - 09:46 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- Igor Skornyakov wrote:
> All @gso_ctrlc_tests@ passed, all @gso_ctrlc_3way_tests@ failed.
To simplify 3-way tests... - 09:40 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- Constantin Asofiei wrote:
> Review for 2565a rev 11067:
> # @Boolean ClientExports.setWaitState@ - please review al... - 09:37 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- Review for 2565a rev 11067:
# @Boolean ClientExports.setWaitState@ - please review all usage of this API; if the API... - 09:37 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- Greg Shah wrote:
> Are you confident that you have not lost any of Eugenie's javadoc changes?
I hope so. There wh... - 09:33 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- Are you confident that you have not lost any of Eugenie's javadoc changes?
- 09:32 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- All @gso_ctrlc_tests@ passed, all @gso_ctrlc_3way_tests@ failed.
- 08:23 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- Greg Shah wrote:
> How is MAJIC regression testing going?
The night run ended with a lot of connection failures a... - 08:17 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- How is MAJIC regression testing going?
- 05:39 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- Manual Web GUI tests passed OK
- 04:49 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- Manual Swing GUI tests passed OK.
- 01:04 PM Feature #2566 (Closed): implement LOAD-MOUSE-POINTER method
- The implementation is now present in trunk revision 10976 (merged from 2565a).
- 01:02 PM Bug #2792: image loading issues
- The recently noted issues are resolved by trunk revision 10976 (merged from 2565a).
- 01:01 PM Bug #2995 (Closed): if the first mouse after app startup is on a combo-box, then an abend occurs
- Resolved by trunk revision 10976 (merged from 2565a).
- 01:00 PM Bug #2996 (Closed): Cursor change at the window border
- 12:59 PM Bug #2996: Cursor change at the window border
- Resolved by trunk revision 10976 (merged from 2565a).
- 01:00 PM Bug #2982 (Closed): in Web client, overlay window must not be "resizeable"
- Resolved by trunk revision 10976 (merged from 2565a).
- 09:49 AM Bug #2914: Fix errors in window_sizing/test_runner.p
- > As this IMHO has small negative impact I would create new issue and deal with this later. Greg, what do you think?
... - 09:27 AM Bug #2914: Fix errors in window_sizing/test_runner.p
- In 4GL window HEIGHT attribute can be assigned to smaller values than the smallest physical window size. So we end up...
02/29/2016
- 03:52 PM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- Fixed javadocs
Committed to the task branch 2565a revno 11067.
- 03:27 PM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- Rebased task branch 2565a from P2J trunk rev 10975. The latest revision is now 11066.
The only conflicts during re... - 03:01 PM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- Greg Shah wrote:
> Before you do this testing, please rebase. It should be the last one before your merge.
>
> A... - 03:00 PM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- Before you do this testing, please rebase. It should be the last one before your merge.
Although I'd prefer not t... - 02:50 PM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- Greg Shah wrote:
> There has been a substantial amount of change in GUI code since then. I think it is important to... - 02:44 PM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- > > In what revision did your manual testing of the Swing GUI client pass all standalone GUI tests?
>
> It was rev... - 02:28 PM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- As far as I can see FSD tests passed OK after adding the following to the @directory.xml@:...
- 02:21 PM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- Greg Shah wrote:
> In what revision did your manual testing of the Swing GUI client pass all standalone GUI tests?
... - 02:15 PM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- In what revision did your manual testing of the Swing GUI client pass all standalone GUI tests?
- 01:43 PM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- The issue from the note 285 is fixed.
Committed to the task branch 2565a revno 11063.
What's remained is the ma... - 12:47 PM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- As far as I can see all standard manual GUI tests run identically in 2565a and trunk (WebGUI) with one exception: the...
- 11:55 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- Constantin Asofiei wrote:
> Does @IBEAM@ still work in your tests? I was testing @IBEAM@ for a combo-box in @demo-wi... - 11:46 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- Igor Skornyakov wrote:
> Constantin Asofiei wrote:
> > Please check the @LOAD-MOUSE-POINTER@ for combo-box/button -... - 10:19 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- Greg Shah wrote:
> Code Review Task Branch 2565a Revision 11059
Fixed. Committed to the task branch 2565a revno 1... - 09:39 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- Code Review Task Branch 2565a Revision 11059
1. Are you intending to assign @me.currentHovered@ and @me.currentMou... - 08:20 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- The issue with mouse drug is fixed.
Committed to the task branch 2565a revno 11059
Only JS code was affected.
... - 02:44 PM Support #2961: list of differences between the Swing GUI client and the original 4GL Windows GUI ...
- 5. Window cannot be moved outside of screen bounds in Swing GUI. See #3008.
- 02:42 PM Bug #3008: Window in Swing GUI cannot be moved outside of screen bounds
- Top-level window in Swing GUI, smaller than screen size, cannot be moved outside of screen bounds. When mouse-draggin...
- 02:32 PM Bug #3008 (New): Window in Swing GUI cannot be moved outside of screen bounds
- 02:17 PM Bug #2914: Fix errors in window_sizing/test_runner.p
- Greg Shah wrote:
> > When the window fits fully on the screen, calling java.awt.Window.setLocation() doesn't allow t... - 12:18 PM Bug #2914: Fix errors in window_sizing/test_runner.p
- > When the window fits fully on the screen, calling java.awt.Window.setLocation() doesn't allow the window to move ou...
- 10:11 AM Bug #2914: Fix errors in window_sizing/test_runner.p
- Rebased task branch 2914a against trunk revision 10974. 2914a is now at revision 10988.
- 12:09 PM Bug #2968: disconnect/reconnect and manual reload must re-establish the websocket connection, nee...
- Greg Shah wrote:
> Do NOT implement JS caching. It adds too many potential problems and too much complexity.
>
>... - 12:08 PM Bug #2968: disconnect/reconnect and manual reload must re-establish the websocket connection, nee...
- Constantin Asofiei wrote:
> Other questions:
> # What happens if the user hits "refresh page" while the JS side is ... - 11:53 AM Bug #2968: disconnect/reconnect and manual reload must re-establish the websocket connection, nee...
- Do NOT implement JS caching. It adds too many potential problems and too much complexity.
At this point, if it is... - 11:40 AM Bug #2968: disconnect/reconnect and manual reload must re-establish the websocket connection, nee...
- Other questions:
# What happens if the user hits "refresh page" while the JS side is in the middle of processing som... - 11:32 AM Bug #2968: disconnect/reconnect and manual reload must re-establish the websocket connection, nee...
- Sergey Ivanovskiy wrote:
> Constantin Asofiei wrote:
> > We need to consider that all the JS-side data is lost, if th... - 11:29 AM Bug #2968: disconnect/reconnect and manual reload must re-establish the websocket connection, nee...
- Yes, mouse regions, icons, drawings, all required fields for each JS module if we will save the JS client state.
- 11:25 AM Bug #2968: disconnect/reconnect and manual reload must re-establish the websocket connection, nee...
- Sergey Ivanovskiy wrote:
> I used the @localStorage@ and did't save the icons caches and mouse regions and drawings.... - 11:24 AM Bug #2968: disconnect/reconnect and manual reload must re-establish the websocket connection, nee...
- Constantin Asofiei wrote:
> We need to consider that all the JS-side data is lost, if the web page is reloaded. If ... - 11:21 AM Bug #2968: disconnect/reconnect and manual reload must re-establish the websocket connection, nee...
- No, I used to save this state on reload the web page. But I understand it is complex because many fields and variable...
- 11:17 AM Bug #2968: disconnect/reconnect and manual reload must re-establish the websocket connection, nee...
- Sergey Ivanovskiy wrote:
> It may be more complex task in compare with saving the JS client state. Because I am almo... - 11:16 AM Bug #2968: disconnect/reconnect and manual reload must re-establish the websocket connection, nee...
- Constantin Asofiei wrote:
> Greg Shah wrote:
> > I the issue in note 6 present with the web ChUI too? We had the w... - 11:10 AM Bug #2968: disconnect/reconnect and manual reload must re-establish the websocket connection, nee...
- Sergey Ivanovskiy wrote:
> Constantin, you are not right, because this token is used only once to generate the autho... - 11:08 AM Bug #2968: disconnect/reconnect and manual reload must re-establish the websocket connection, nee...
- Constantin Asofiei wrote:
> Sergey Ivanovskiy wrote:
> > > > Thus the second handler has an uninitialized state tha... - 11:04 AM Bug #2968: disconnect/reconnect and manual reload must re-establish the websocket connection, nee...
- Sergey Ivanovskiy wrote:
> > > Thus the second handler has an uninitialized state that is inconsistent with the curr... - 11:02 AM Bug #2968: disconnect/reconnect and manual reload must re-establish the websocket connection, nee...
- Greg Shah wrote:
> I the issue in note 6 present with the web ChUI too? We had the web ChUI reload case working pro... - 10:53 AM Bug #2968: disconnect/reconnect and manual reload must re-establish the websocket connection, nee...
- I don't like this approach but it is possible to save the current JS client state in the file on the java side and on...
- 10:37 AM Bug #2968: disconnect/reconnect and manual reload must re-establish the websocket connection, nee...
- Greg Shah wrote:
> > Due to this issue I would like to create a new perspective task to do the web application accor... - 10:18 AM Bug #2968: disconnect/reconnect and manual reload must re-establish the websocket connection, nee...
- > I don't want to implement any kind of caching, local storage or index db. Can we just make the reload work by forc...
- 09:31 AM Bug #2968: disconnect/reconnect and manual reload must re-establish the websocket connection, nee...
- Fonts are cached separately.
- 09:30 AM Bug #2968: disconnect/reconnect and manual reload must re-establish the websocket connection, nee...
- Refresh/reopen requires to redraw all windows, to restore embedded fonts and mouse widgets regions. I tried to restor...
- 09:09 AM Bug #2968: disconnect/reconnect and manual reload must re-establish the websocket connection, nee...
- The web ChUI has the same problem. I don't know how to repeat all window drawings. How can we restore the embedded fo...
- 09:01 AM Bug #2968: disconnect/reconnect and manual reload must re-establish the websocket connection, nee...
- > Due to this issue I would like to create a new perspective task to do the web application according to a standard w...
- 08:55 AM Bug #2968: disconnect/reconnect and manual reload must re-establish the websocket connection, nee...
- I don't want to implement any kind of caching, local storage or index db. Can we just make the reload work by forcin...
- 12:59 AM Support #2672: GUI web client performance improvements
- Some remarks to discuss are
There are differences in the web performance depending on the used strategy to do cachin...
02/28/2016
- 03:06 PM Bug #2968: disconnect/reconnect and manual reload must re-establish the websocket connection, nee...
- The picture result is probably due to the current clipping region on the Web java side. It adds a complexity to the t...
- 02:36 PM Bug #2968: disconnect/reconnect and manual reload must re-establish the websocket connection, nee...
- I encountered the problems to restore the web application if the application web page is reloaded or reopened.
There ... - 08:56 AM Support #2672: GUI web client performance improvements
- Constantin, according to the test @getImageData@ and @putImageData@ are expensive operations. Did you compare the web...
02/27/2016
- 11:14 AM Bug #2914: Fix errors in window_sizing/test_runner.p
- Hynek Cihlar wrote:
> Hynek Cihlar wrote:
> > Greg Shah wrote:
> > > What is left to do on this task?
> >
> > I... - 11:09 AM Bug #2914: Fix errors in window_sizing/test_runner.p
- Hynek Cihlar wrote:
> Greg Shah wrote:
> > What is left to do on this task?
>
> I also found two new trunk regre... - 09:10 PM Bug #2914: Fix errors in window_sizing/test_runner.p
- I can confirm the window size performance problem exists in Web GUI, too. I was able to reach the max window size of ...
- 07:51 PM Bug #2914: Fix errors in window_sizing/test_runner.p
- Task branch 2914a revision 10984 passed conversion testing.
02/26/2016
- 05:52 PM Bug #2968: disconnect/reconnect and manual reload must re-establish the websocket connection, nee...
- Planing to finish this task this weekend due to the tests to restore the document tree with the embedded fonts and th...
- 11:48 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- OK, thanks.
When you have the fix for the GUI issue, we will evaluate if the changes needed will require a new rou... - 11:45 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- At the last run only the following regression tests failed:...
- 09:50 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- Greg Shah wrote:
> Code Review Task Branch 2565a Revision 11057
>
> In @ChuiWidgetFactory@ please search on the t... - 09:45 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- Code Review Task Branch 2565a Revision 11057
In @ChuiWidgetFactory@ please search on the text "GUI" and change it ... - 09:42 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- Greg Shah wrote:
> Code Review Task Branch 2565a Revision 11055
Sorry. Fixed now. I've also removed obsolete meth... - 09:33 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- > There is a number of methods in the WidgetFactoryAdapter which just throw new RuntimeException("Not implemented.") ...
- 09:32 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- Code Review Task Branch 2565a Revision 11055
The javadoc changes requested in note 268 were not done.
> clean u... - 09:26 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- There is a number of methods in the @WidgetFactoryAdapter@ which just throw @new RuntimeException("Not implemented.")...
- 09:21 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- Greg Shah wrote:
> Code Review Task Branch 2565a Revision 11054
>
> 1. The GUI-specific additions to @ChuiWidgetF... - 09:16 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- Greg Shah wrote:
> What issues remain to be fixed from manual testing or automated regression testing?
I have goo... - 09:14 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- What issues remain to be fixed from manual testing or automated regression testing?
- 09:12 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- Code Review Task Branch 2565a Revision 11054
1. The GUI-specific additions to @ChuiWidgetFactory@ are inappropriat... - 07:59 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- Fixed a bug revealed by automated regression testeting
Committed to a task branch 2565a revno 11054
Regression te... - 03:50 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- Fixed a bug revealed by automated regression testeting
Committed to a task branch 2565a revno 11053
Regression te... - 10:59 AM Bug #2914: Fix errors in window_sizing/test_runner.p
- Greg Shah wrote:
> What is left to do on this task?
I also found two new trunk regressions.
* Window cannot be... - 10:56 AM Bug #2914: Fix errors in window_sizing/test_runner.p
- Greg Shah wrote:
> Code Review Task Branch 2914a Revision 10984
>
> 1. Is the @ClientBuilder.localStart()@ change... - 10:38 AM Bug #2914: Fix errors in window_sizing/test_runner.p
- Code Review Task Branch 2914a Revision 10984
1. Is the @ClientBuilder.localStart()@ change (to redirect STDOUT) so... - 10:28 AM Bug #2914: Fix errors in window_sizing/test_runner.p
- Greg Shah wrote:
> I will do a code review shortly.
>
> What is left to do on this task?
There are some unresolved ... - 09:58 AM Bug #2914: Fix errors in window_sizing/test_runner.p
- I will do a code review shortly.
What is left to do on this task?
Have you handled the web client as well? - 09:33 AM Bug #2914: Fix errors in window_sizing/test_runner.p
- I have committed the solution for the large window sizes in Swing, see task branch 2914a revision 10984.
I improve...
02/25/2016
- 06:06 PM Bug #2968: disconnect/reconnect and manual reload must re-establish the websocket connection, nee...
- The following problem appears if the application webpage is reloaded or refreshed on F5. We have two WebPageHandlers....
- 05:42 PM Bug #3006: paste operation doesn't work properly
- I've noticed the following issue with @ask-gui.p@. If I try to paste a file name into the entry field right after the...
- 05:40 PM Bug #3006 (New): paste operation doesn't work properly
- 04:36 PM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- The results of the regression testing:
1. All ctrl-C tests passed.
2. The following main tests failed in 3 runs... - 06:54 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- Igor Skornyakov wrote:
> The regression found: the additional window opened in the @./demo/calc-static-chars.p@ is n... - 06:40 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- Constantin Asofiei wrote:
> Please check the @LOAD-MOUSE-POINTER@ for combo-box/button - is not working anymore, in ... - 06:20 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- Constantin Asofiei wrote:
> Please check the @LOAD-MOUSE-POINTER@ for combo-box/button - is not working anymore, in ... - 06:20 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- The regression found: the additional window opened in the @./demo/calc-static-chars.p@ is not movable/resizable in 25...
- 06:19 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- Please check the @LOAD-MOUSE-POINTER@ for combo-box/button - is not working anymore, in rev 11052.
02/24/2016
- 05:55 PM Bug #2968: disconnect/reconnect and manual reload must re-establish the websocket connection, nee...
- Committed revision 11033, 11034 implemented 1,2,3 except of the usecase "to reload/to close the application web page".
- 04:08 PM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- Greg Shah wrote:
> OK, it looks fine, except for the @ClientExports.loadMousePointer()@ which still has a ptrName ja... - 03:52 PM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- OK, it looks fine, except for the @ClientExports.loadMousePointer()@ which still has a ptrName javadoc parameter.
... - 03:32 PM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- Fixed items 14-16 from note 235?
Committed to the task branch 2565a revno 11051, - 02:46 PM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- I'm comparing 2565a with the trunk. This is the only way to see what I messed up.
- 02:43 PM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- Code Review Task Branch 2565a Revision 11050
@ClientExports.loadMousePointer()@ still has a ptrName javadoc parame... - 02:34 PM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- Greg Shah wrote:
> Code Review Task Branch 2565a Revision 11047
>
> This is substantially better.
>
> 1. @ThinClien... - 02:18 PM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- Code Review Task Branch 2565a Revision 11047
This is substantially better.
1. @ThinClient/ClientExports.loadMou... - 12:47 PM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- Greg Shah wrote:
> Code Review Task Branch 2565a Revision 11042
All issues except 14-16 have been addressed.
C... - 09:36 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- Fixed the issue with @MOUSE_WHEEL@/@MOUSE_DRAGGED@ in the @EDITOR@ (Swing). Many thanks to Constantin for a clue.
... - 07:55 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- Greg Shah wrote:
> > The idea of the @filename@ field in the @MousePointer@ is to have some place where the name of ... - 07:30 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- > The idea of the @filename@ field in the @MousePointer@ is to have some place where the name of the file with cursor...
- 07:28 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- My guess is that the root of the problem is that the @findMouseSource@ method doesn't take into account the type of t...
- 07:13 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- Constantin Asofiei wrote:
> I understand what you say here. But in the @SwingMouseHandler$WorkArea.actions@ map the... - 07:11 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- Greg, I've reworked @MousePonter@/@MousePtrWrapper@ (committed to the task branch 25652 revno 11045).
I've also remo... - 07:09 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- Igor Skornyakov wrote:
> > Beside this, for widgets which don't have a custom cursor, we don't need to register a @M... - 05:47 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- Constantin Asofiei wrote:
> The @MouseHoverAction@ in case of a drop-down is registered with a @ScrollPaneGuiImpl@, ... - 05:36 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- The @MouseHoverAction@ in case of a drop-down is registered with a @ScrollPaneGuiImpl@, as we need a widget with an I...
- 04:08 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- Constantin Asofiei wrote:
> The changes in this diff solve the EDITOR problem in 2565a:
> [...]
Thank you Constant... - 04:03 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- The changes in this diff solve the EDITOR problem in 2565a:...
- 03:58 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- Constantin Asofiei wrote:
> Igor Skornyakov wrote:
> > With SwingGUI I've noticed only one difference while running... - 03:49 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- Igor Skornyakov wrote:
> With SwingGUI I've noticed only one difference while running tests mentioned in the note 22... - 03:39 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- Igor Skornyakov wrote:
>
> Thank you Eugenie. Unfortunately the approaches you described seem to be not completely... - 03:28 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- Eugenie Lyzenko wrote:
> >I'm a little confused. The method mouseWheelMoved exist both in MouseWheelListener (invoke... - 09:38 PM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- >I'm a little confused. The method mouseWheelMoved exist both in MouseWheelListener (invoked from the MouseHandler.ap...
- 07:20 PM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- Code Review Task Branch 2565a Revision 11042
1. As mentioned previously, the UI system is designed as a series of ... - 08:44 AM Bug #2914: Fix errors in window_sizing/test_runner.p
- Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > Another solution I see would be to avoid double-buffering from ... - 08:14 AM Bug #2914: Fix errors in window_sizing/test_runner.p
- Greg Shah wrote:
> > I can make the limit configurable and make the app logic report the assigned (and possibly larg... - 07:40 AM Bug #2914: Fix errors in window_sizing/test_runner.p
- Hynek Cihlar wrote:
> Another solution I see would be to avoid double-buffering from a certain (configurable) window... - 07:37 AM Bug #2914: Fix errors in window_sizing/test_runner.p
- > I can make the limit configurable and make the app logic report the assigned (and possibly larger size) as you sugg...
- 03:26 AM Feature #2967: web socket message sizes are limited to 32K, make sure that drawing ops and images...
- Actually, the PASTE in GUI 4GL doesn't invoke triggers at all, regardless of the widget. We need a generic approach ...
- 03:00 AM Feature #2967: web socket message sizes are limited to 32K, make sure that drawing ops and images...
- Sergey Ivanovskiy wrote:
> I don't know it will be correct if the triggers on the inserted text will be invoked befo... - 12:55 AM Feature #2967: web socket message sizes are limited to 32K, make sure that drawing ops and images...
- Constantin Asofiei wrote:
> For editor, we need to consider if pasting text into it may or may not result in invoking...
02/23/2016
- 04:58 PM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- I'm a little confused. The method @mouseWheelMoved@ exist both in @MouseWheelListener@ (invoked from the @MouseHandle...
- 01:18 PM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- Constantin Asofiei wrote:
> Igor Skornyakov wrote:
> > With SwingGUI I've noticed only one difference while running... - 01:17 PM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- Igor Skornyakov wrote:
> With SwingGUI I've noticed only one difference while running tests mentioned in the note 22... - 01:16 PM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- With SwingGUI I've noticed only one difference while running tests mentioned in the note 222:
@/demo/demo_widgets.p@... - 11:45 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- > According to the Firebug profiler setting a custom cursor (from the file) take 7+ times less time than e.g. @foundM...
- 04:44 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- According to the Firebug profiler setting a custom cursor (from the file) take 7+ times less time than e.g. @foundMou...
- 01:13 PM Feature #2967: web socket message sizes are limited to 32K, make sure that drawing ops and images...
- Constantin Asofiei wrote:
> > for editor, let the driver parse the text and split it into lines. This way there will... - 01:11 PM Feature #2967: web socket message sizes are limited to 32K, make sure that drawing ops and images...
- Sergey Ivanovskiy wrote:
> We need to block the JS client mouse listeners if the text processing is not finished
I... - 12:04 PM Feature #2967: web socket message sizes are limited to 32K, make sure that drawing ops and images...
- > Code Review Task Branch 1811t Revision 11029
>
> 1. I prefer not to create the temp dir for every client. This su... - 10:17 AM Feature #2967: web socket message sizes are limited to 32K, make sure that drawing ops and images...
- The same thread issue can be reproduced for @./demo/movie-ratings-dynamic.p com.goldencode.testcases.demo.MovieRating...
- 09:07 AM Feature #2967: web socket message sizes are limited to 32K, make sure that drawing ops and images...
- This thread issue can be observed in the case if the pasted text has no more than hundreds lines and @WebClientProtoc...
- 08:01 AM Feature #2967: web socket message sizes are limited to 32K, make sure that drawing ops and images...
- Sergey Ivanovskiy wrote:
> I encountered the thread lock in the case of the large paste data in the editor, the main... - 01:53 AM Feature #2967: web socket message sizes are limited to 32K, make sure that drawing ops and images...
- #33 has been deleted due to the fact @MSG_PASTE@ is handled by @GuiWebSocket@ like it has been described.
LE: GES pu... - 12:34 PM Bug #2914: Fix errors in window_sizing/test_runner.p
- Greg Shah wrote:
> Yikes!
>
> I think we need to put some basic protections into place as a default. The custome... - 10:19 AM Bug #2914: Fix errors in window_sizing/test_runner.p
- Yikes!
I think we need to put some basic protections into place as a default. The customer should be able to over... - 11:44 AM Support #2672: GUI web client performance improvements
- Custom cursor support in JS is currently implemented without any caching of the resulting prepared cursor. In other ...
02/22/2016
- 05:17 PM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- @SET-WAIT-STATE@ re-worked
Committed to the task branch 2565a revno 11042.
The only remaining issue is optimize... - 02:07 PM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- Greg Shah wrote:
> Eugenie: don't we have non-gui testcases for FSD in @testcases/uast/@ already?
Honestly I do not... - 01:55 PM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- Yes, we would want to have automated tests for this. My only concern is the time it would take to create these. I d...
- 12:06 PM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- >Thank you Eugenie. Please note however that FileSystemDaemon is a collection of non-UI utility classes with well-def...
- 10:39 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- Eugenie Lyzenko wrote:
> Greg Shah wrote:
> >
> > Eugenie: Please make a list of the important testcases to run f... - 10:17 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- Greg Shah wrote:
> This is the standard test list:
Thank you Greg. This looks not that much as I anticipated. - 10:16 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- This is the standard test list:
./ask-gui.p
./hello.p
./demo/calc.p
./demo/calc-static.p
./demo/calc-static-ch... - 10:01 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- Greg Shah wrote:
> Your changes are extensive and even without these specific changes, you will have to run all of t... - 09:54 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- > Greg, this code is in the GuiWebDriver so it affects Web GUI only. I do not think that it is feasible to run all GU...
- 09:52 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- Greg Shah wrote:
>
> Eugenie: Please make a list of the important testcases to run for testing of this area.
1.... - 09:44 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- Greg Shah wrote:
> Pretty soon, you will be ready for regression testing. Since you have changed code that affects ... - 09:10 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- Igor Skornyakov wrote:
> Greg Shah wrote:
> > Code Review Task Branch 2565a Revision 11031
> >
> > This is part ... - 09:04 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- > Anyway - you will need to run testcases(at least all known at this time for the area the FileSytemDaemon is involve...
- 08:27 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- Re-worked custom cursor load from a file. Added server-side load.
Committed to the task branch 2565a revno 11041 - 03:42 PM Feature #2967: web socket message sizes are limited to 32K, make sure that drawing ops and images...
- I encountered the thread lock in the case of the large paste data in the editor, the main thread and the web task thr...
- 01:52 PM Feature #2967: web socket message sizes are limited to 32K, make sure that drawing ops and images...
- > please approve that we only need to support MSG_PASTE. In this case we aren't required to save partial messages and...
- 01:29 PM Feature #2967: web socket message sizes are limited to 32K, make sure that drawing ops and images...
- I found the positive usage of the fast timer. It looks that the JS client reacts more rapidly if the setTimeout is re...
- 01:27 PM Feature #2967: web socket message sizes are limited to 32K, make sure that drawing ops and images...
- Greg, please approve that we only need to support MSG_PASTE. In this case we aren't required to save partial messages...
- 10:11 AM Feature #2967: web socket message sizes are limited to 32K, make sure that drawing ops and images...
- Code Review Task Branch 1811t Revision 11029
1. I prefer not to create the temp dir for every client. This suppor... - 09:40 AM Feature #2967: web socket message sizes are limited to 32K, make sure that drawing ops and images...
- I'm reviewing the code now. However, I don't want to support the file upload at this time. As mentioned in note 22,...
- 04:52 AM Feature #2967: web socket message sizes are limited to 32K, make sure that drawing ops and images...
- Committed revision 11029 takes into account that a file size can be larger than the JVM heap size and fixes the close...
- 11:57 AM Bug #2968: disconnect/reconnect and manual reload must re-establish the websocket connection, nee...
- The watch dog timeout is given by this directory configuration path "webClient/watchdogTimeout@value" with the defaul...
- 11:47 AM Bug #2914: Fix errors in window_sizing/test_runner.p
- Greg Shah wrote:
> > Also, with the default client Java heap setup, there are out of memory exceptions when attempti... - 08:40 AM Bug #2914: Fix errors in window_sizing/test_runner.p
- > Also, with the default client Java heap setup, there are out of memory exceptions when attempting to resize the win...
- 10:22 AM Bug #2925: EDITOR widget is invisible in presence of the BROWSE one.
- In addition. When I run the converted attached test (w/o @BROWSE@) then all drop-down lists at the top of the window ...
- 08:49 AM Bug #2787: implement mnemonics/accelerator key support for button
- That still sounds like we can have common code and just differentiate the use cases with a flag.
- 07:40 AM Bug #2787: implement mnemonics/accelerator key support for button
- Yes, buttons use the same algorithm, but I've found a small difference: button labels do not use first character of a...
- 07:11 AM Bug #2849: implement and/or fix the default popup menus for all widgets
- Vadim I believe the problem with the popup offset is in @TopLevelWindow.initEditorPopup()@. The mouse event point is ...
- 05:49 AM Bug #2849: implement and/or fix the default popup menus for all widgets
- Hynek, sorry. I forgot to commit my current changes to 2849a. That also means that the reason could be in some of my ...
- 03:45 AM Bug #2849: implement and/or fix the default popup menus for all widgets
- Vadim Gindin wrote:
> Hynek Cihlar wrote:
> > ..
> > I did a quick test, created a simple frame in a regular windo... - 02:48 AM Bug #2849: implement and/or fix the default popup menus for all widgets
- Hynek Cihlar wrote:
> ..
> I did a quick test, created a simple frame in a regular window and in a DIALOG-BOX. Clic...
02/20/2016
- 02:26 PM Bug #2914: Fix errors in window_sizing/test_runner.p
- There is a technical limit of the max window size in Swing GUI driver. The screen buffer implemented by @BufferedImag...
- 07:13 PM Bug #2914: Fix errors in window_sizing/test_runner.p
- Thanks for the inputs. I have reverted my changes except of the fix of Case 1 and applied Constantin's changes. The r...
- 01:18 PM Feature #2967: web socket message sizes are limited to 32K, make sure that drawing ops and images...
- Greg, please review the committed revision 11027.
- 04:52 AM Bug #2849: implement and/or fix the default popup menus for all widgets
- Vadim Gindin wrote:
> I'm trying to fix the following bug:
> When I open popup menu in EDITOR in a standard WINDOW ... - 08:53 PM Bug #2849: implement and/or fix the default popup menus for all widgets
- >Eugenie, does it ring a bell?
?
>If I remember correctly you were solving some mouse-click offset issues when impl... - 07:32 PM Bug #2849: implement and/or fix the default popup menus for all widgets
- Vadim Gindin wrote:
> I'm trying to fix the following bug:
> When I open popup menu in EDITOR in a standard WINDOW ...
02/19/2016
- 04:57 PM Bug #2914: Fix errors in window_sizing/test_runner.p
- For the third case, the @chp_wrapper=decimal@ annotation is emitted at the COLON node:...
- 04:48 PM Bug #2914: Fix errors in window_sizing/test_runner.p
- From previous note, changing the code to:...
- 04:37 PM Bug #2914: Fix errors in window_sizing/test_runner.p
- Hynek, the first case looks like an incorrect wrapping; the AST for the right-side value has a @no_wrap=true@ annotat...
- 01:36 PM Bug #2914: Fix errors in window_sizing/test_runner.p
- Code Review Task Branch 2914a Revision 10974
The @literals.rules@ change is fine.
The @functions_procedures.rul... - 09:12 AM Bug #2914: Fix errors in window_sizing/test_runner.p
- I have found three conversion errors related to type conversion.
Case 1:... - 07:37 AM Bug #2914: Fix errors in window_sizing/test_runner.p
- Rebased task branch 2914a against trunk revision 10972. 2914a is now at revision 10974.
- 04:14 PM Bug #2997: Add support for pre-defined cursor types which do not have direct counterparts in AWT/JS
- Please find image captures of Progress pre-defined cursors which do not have AWT counterparts attached.
- 03:57 PM Bug #2997: Add support for pre-defined cursor types which do not have direct counterparts in AWT/JS
- Greg Shah wrote:
> http://www.trickyways.com/2014/03/capture-mouse-cursor-screenshot-windows/
> http://windows.micr... - 03:54 PM Bug #2997: Add support for pre-defined cursor types which do not have direct counterparts in AWT/JS
- http://www.trickyways.com/2014/03/capture-mouse-cursor-screenshot-windows/
http://windows.microsoft.com/en-us/window... - 03:48 PM Bug #2997: Add support for pre-defined cursor types which do not have direct counterparts in AWT/JS
- Greg Shah wrote:
> Please post image captures of the "no counterpart" cursors. These will be for reference purposes... - 07:51 AM Bug #2997: Add support for pre-defined cursor types which do not have direct counterparts in AWT/JS
- To be clear, when we create these images, we must do so "from scratch". We cannot just make a copy of the bits used ...
- 07:51 AM Bug #2997: Add support for pre-defined cursor types which do not have direct counterparts in AWT/JS
- Please post image captures of the "no counterpart" cursors. These will be for reference purposes only, we will not c...
- 03:54 AM Bug #2997: Add support for pre-defined cursor types which do not have direct counterparts in AWT/JS
- At this moment there are a few mouse cursors which are standard for Progress but do not have direct counterparts in A...
- 03:51 AM Bug #2997 (New): Add support for pre-defined cursor types which do not have direct counterparts i...
- 03:29 PM Bug #2849: implement and/or fix the default popup menus for all widgets
- I'm trying to fix the following bug:
When I open popup menu in EDITOR in a standard WINDOW it is shown at the point ... - 05:08 AM Bug #2849: implement and/or fix the default popup menus for all widgets
- Vadim Gindin wrote:
> Hynek Cihlar wrote:
> > ..
> > Yes we attempt not to put driver-specific code into common code,... - 04:39 AM Bug #2849: implement and/or fix the default popup menus for all widgets
- Hynek Cihlar wrote:
> ..
> Yes we attempt not to put driver-specific code into common code, but there are exception... - 01:10 PM Support #2672: GUI web client performance improvements
- Constantin Asofiei wrote:
> 2. fixed AbstractWidget.clipRectangle (the bottom/right coordinates were computed incorr... - 01:09 PM Support #2672: GUI web client performance improvements
- 1811t rev 11026 fixes:
# the window icon - we must not cache image widgets, as they are not rectangular and can be t... - 10:55 AM Support #2672: GUI web client performance improvements
- Sergey Ivanovskiy wrote:
> Ok, we can create a task to fix artifacts that appear in the case of popup-menu with the ... - 10:54 AM Support #2672: GUI web client performance improvements
- Ok, we can create a task to fix artifacts that appear in the case of popup-menu with the most simple 4GL test case pr...
- 10:40 AM Support #2672: GUI web client performance improvements
- Sergey, I've seen this only in a scenario for test 454 and also when the window popup-menu is shown then cleared (any...
- 10:07 AM Support #2672: GUI web client performance improvements
- Another argument can be if we test our system against @hello.p@, then are these artifacts present?
- 09:57 AM Support #2672: GUI web client performance improvements
- In Chrome I found this issue if we get @var image = ctx.getImageData(0.5,0.5, 10, 1)@, then the returned image dimens...
- 09:51 AM Support #2672: GUI web client performance improvements
- If you removed the @translate(0.5, 0.5)@ call, then some artifacts disappeared, didn't they? Now I have no ideas beca...
- 09:43 AM Support #2672: GUI web client performance improvements
- I increased the sizes of regions to watch the picture and the second red squared rectangle is antialiased. It has smo...
- 09:29 AM Support #2672: GUI web client performance improvements
- Constantin, please could you explain it more thoroughly.
The first script should intersect this rectangle(0, 0, 8, 8... - 08:58 AM Support #2672: GUI web client performance improvements
- Constantin Asofiei wrote:
> 3. an existing issue in trunk: in Web client for test 454, after navigating through the ... - 08:13 AM Support #2672: GUI web client performance improvements
- About the editing and showing data on the editor/fill-in:
# for editor, let the driver parse the text and split it i... - 12:52 AM Support #2672: GUI web client performance improvements
- > Greg Shah wrote:
> > It got me thinking. When the user is editing text in a fill-in or editor (or a browse cell/s... - 12:54 PM Bug #2968: disconnect/reconnect and manual reload must re-establish the websocket connection, nee...
- > 1) Disconnect/reconnect usecase
> Greg, please could you explain disconnect/reconnect? Does it mean the main conne... - 12:37 PM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- @MouseEvent.MOUSE_MOVED@ is restored in @ScrollPaneGuiImpl.mouseActions@.
Committed to the task branch 2565a revno... - 11:12 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- Constantin Asofiei wrote:
> About 2565a rev 11035:
> # @ClientExports.setMousePointer@ - the javadoc is missing the... - 09:59 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- More fixes according to the code review part 2:
>20. Why did you make the EditorGuiImpl.setEnabled() and FillInGui... - 09:55 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- Eugenie Lyzenko wrote:
> I think adding the informative comments will significantly help to review such code, just t... - 09:51 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- >I'm sorry that you find the new version of the code less readable but you understand that this is mostly a matter of...
- 07:14 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- About 2565a rev 11035:
# @ClientExports.setMousePointer@ - the javadoc is missing the parameter name for @ptr@.
# @... - 06:47 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- More fixes according to the code review part 2:
>11. UiUtils.lookup4GLWidgetId() could have been done with less code.... - 06:08 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- Constantin Asofiei wrote:
> Igor, in rev 11035 ThinClient.trigger returns if wait-state is on. But this code in 4GL... - 05:55 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- Constantin Asofiei wrote:
> Igor, in rev 11035 ThinClient.trigger returns if wait-state is on. But this code in 4GL... - 05:50 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- Igor, in rev 11035 ThinClient.trigger returns if wait-state is on. But this code in 4GL proves that triggers are exe...
- 03:45 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- Eugenie Lyzenko wrote:
> >Eugenie: Please review the FileSytemDaemon changes in 2565a.
>
> Well, the code was sig... - 07:24 PM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- >Eugenie: Please review the FileSytemDaemon changes in 2565a.
Well, the code was significantly rewritten from the ... - 11:55 AM Feature #3000: implement the SLIDER widget in ChUI
- The GUI slider already is complete. This task is to add the proper ChUI support using as much common code as possible.
- 11:55 AM Feature #3000 (New): implement the SLIDER widget in ChUI
- 11:54 AM Bug #2787: implement mnemonics/accelerator key support for button
- > # How is the alert-box relates to mnemonics?
Did you read #2775-8 as mentioned above?
It has this comment:
... - 11:47 AM Feature #2967: web socket message sizes are limited to 32K, make sure that drawing ops and images...
- I'm OK with this proposed approach. Make sure you write your own from-scratch version of the faster timeouts approach.
02/18/2016
- 05:54 PM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- Greg Shah wrote:
> Code Review Task Branch 2565a Revision 11031
>
> This is part 2 of the code review.
> 42. You... - 05:09 PM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- Fixed the following issues from the code review part 2: 17-19, 47, 53.
Committed to the task branch 2565a revno 11... - 04:08 PM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- > Regarding 47: There is no 'implements' keyword in the MouseHoverAction.
I should have written @extends@. - 04:04 PM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- Greg Shah wrote:
> As I noted in items 17 and 18 of my code review, we are going to use @window.btoa()@ for our enco... - 04:04 PM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- Sergey Ivanovskiy wrote:
> I don't know, but the reason can be found if we answer this question what css engine can ... - 04:03 PM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- As I noted in items 17 and 18 of my code review, we are going to use @window.btoa()@ for our encoding. Please remove ...
- 04:01 PM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- I don't know, but the reason can be found if we answer this question what css engine can do with @this.canvas.style.c...
- 03:51 PM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- Sergey Ivanovskiy wrote:
> Igor, please could you consider the second method due to the optimization. I am worried a... - 03:46 PM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- Igor, please could you consider the second method due to the optimization. I am worried about the large string that w...
- 03:43 PM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- Fixed the following issues from the code review part 2: 1-7, 10, 12-16, 21-35, 37, 39-41, 45,46, 48-52, 54, 55.
Rega... - 03:40 PM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- Let us consider two methods to set a custom cursor:
1) The first we use now... - 03:13 PM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- It is okay, I only want to select the best, it should be your solution.
- 03:12 PM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- Sergey Ivanovskiy wrote:
> If we consider @p2j.socket.js@, then we can find two methods to transform to base64 encod... - 03:06 PM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- If we consider @p2j.socket.js@, then we can find two methods to transform to base64 encoding. The first method is imp...
- 02:51 PM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- Sergey Ivanovskiy wrote:
> Igor, there are lot of changes, do you know that in the current 2565a the following funct... - 02:43 PM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- Igor, there are lot of changes, do you know that in the current 2565a the following function @Window.prototype.isPare...
- 02:21 PM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- > But in fact @GenericWidget.loadLousePointer@ does exactly what you describe (and no more).
You are processing on... - 02:10 PM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- > I've added the block of triggers as @SET-WAIT-STATE@ causes deactivation of the active drop-down. I had a trigger o...
- 12:50 PM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- Sergey: Please review the web client changes in 2565a.
Constantin: Please review the mouse processing changes in 2... - 12:49 PM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- Code Review Task Branch 2565a Revision 11031
This is part 2 of the code review.
1. You have put GUI-specific co... - 11:49 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- Greg Shah wrote:
> Code Review Task Branch 2565a Revision 11026
> 8. I am still finding a significant number of cod... - 10:48 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- Greg Shah wrote:
> 1. The cursor loading and processing should be as hidden as is possible on the client side. Yet ... - 10:35 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- I've added the block of triggers as @SET-WAIT-STATE@ causes deactivation of the active drop-down. I had a trigger on ...
- 10:23 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- Greg Shah wrote:
> >> 4. Please explain the logic behind duplicating the mousePointer member in so many of the *Conf... - 10:13 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- >> 4. Please explain the logic behind duplicating the mousePointer member in so many of the *Config classes (and thus...
- 10:08 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- You're right that some changes have been made. But I am concerned about the core approach. There are comments that ...
- 10:03 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- Committed to the task branch 2565a revno 11031
- 10:00 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- Greg Shah wrote:
> Code Review Task Branch 2565a Revision 11026
> 4. Please explain the logic behind duplicating th... - 09:01 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- Greg Shah wrote:
> 1. Most issues in note 121 (a code review) above have not been resolved. Items 1, 2 and 5 all ... - 08:25 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- Thank you Greg,
I'm working on your comments right now. - 07:41 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- Code Review Task Branch 2565a Revision 11026
This is part 1 of my code review. I want you to fix these things ver... - 06:41 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- Re-tested after rebase. Added custom mouse pointer support for the @SLIDER@ widget.
Committed to the task branch 2... - 05:37 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- Rebased task branch 2565a from P2J trunk rev 10972. The latest revision is now 11028.
- 12:28 PM Bug #2849: implement and/or fix the default popup menus for all widgets
- Vadim Gindin wrote:
> Does anybody know why in common class @TopLevelWindow@ the following GUI-specific statement is... - 12:18 PM Bug #2849: implement and/or fix the default popup menus for all widgets
- Does anybody know why in common class @TopLevelWindow@ the following GUI-specific statement is used: @GuiDriver gd = ...
- 06:25 AM Support #2672: GUI web client performance improvements
- It should improve drawings of lines(horizontal and vertical) having 1 pixel width and lines having 2 or more pixels w...
- 11:56 PM Feature #2612: implement GUI conversion and runtime support for the SLIDER widget
- Branch @2612b@ was merged to trunk as revno @10972@ then it was archived.
- 11:46 PM Feature #2612: implement GUI conversion and runtime support for the SLIDER widget
- The results are in @2612b_10987_2791e7a_20160217_evl.zip@.
- 11:42 PM Feature #2612: implement GUI conversion and runtime support for the SLIDER widget
- Greg Shah wrote:
> If CTRL-C testing passes, please go ahead and merge 2612b to trunk.
OK. The testing completed,... - 10:36 PM Feature #2612: implement GUI conversion and runtime support for the SLIDER widget
- If CTRL-C testing passes, please go ahead and merge 2612b to trunk.
- 10:21 PM Feature #2612: implement GUI conversion and runtime support for the SLIDER widget
- The main part completed without regressions. Running @CTRL-C@ one.
02/17/2016
- 05:44 PM Support #2672: GUI web client performance improvements
- Very cool results! Great job!
I've taken a quick look. Please add the comments I requested in note 30. Then I w... - 04:43 PM Support #2672: GUI web client performance improvements
- Sergey Ivanovskiy wrote:
> Greg, let me try with the 11021 design taking into account the tests result about the pix... - 04:11 PM Support #2672: GUI web client performance improvements
- Greg, let me try with the 11021 design taking into account the tests result about the pixels operations.
- 04:03 PM Support #2672: GUI web client performance improvements
- Greg, I change some method and gives improvement
look at this instead of get we can use create in some cases for Wid... - 03:49 PM Support #2672: GUI web client performance improvements
- Committed revision 11023 removes 11020 and 11021 changes.
- 03:31 PM Support #2672: GUI web client performance improvements
- > Greg, Do you agree if I will roll back 11021 changes according to this test?
Yes, roll it back. Even for the @... - 02:51 PM Support #2672: GUI web client performance improvements
- Greg, Do you agree if I will roll back 11021 changes according to this test?
- 02:48 PM Support #2672: GUI web client performance improvements
- I did this simple test to draw 160 vertical lines of 400 pixel width
for @DefaultPathRenderer@ with the default st... - 01:34 PM Support #2672: GUI web client performance improvements
- >> I am planing to check it with script test and will provide the JS test and its result here. Depending on the resul...
- 11:50 AM Support #2672: GUI web client performance improvements
- Also it is my fault that I don't check the performance for these two cases:
1) draw vertical|horizontal line by pixe... - 11:43 AM Support #2672: GUI web client performance improvements
- Before 11021 changes these primitives: drawRect, drawRoundRect, draw3DRect draws the stroked lines only if the curren...
- 11:02 AM Support #2672: GUI web client performance improvements
- Constantin, I found the performance issue with @./demo/movie-ratings-dynamic.p@ (@com.goldencode.testcases.demo.Movie...
- 08:11 AM Support #2672: GUI web client performance improvements
- Constantin Asofiei wrote:
> Sergey Ivanovskiy wrote:
> > The image background issue is ...
> Thanks for pointing t... - 01:45 AM Support #2672: GUI web client performance improvements
- I would like to notice the main problem related to the Web client performance is synchronous requests from the Java s...
- 12:49 AM Support #2672: GUI web client performance improvements
- I think that @getImageData@ is also an expensive operation.
- 12:43 AM Support #2672: GUI web client performance improvements
- It looks that the new caching introduced by 11022 is more slower than the previous version 11021.
The reported times... - 05:18 PM Bug #2996: Cursor change at the window border
- Restore the mouse cursor change at the crossing of the window border for the Web GUI.
- 05:17 PM Bug #2996 (Closed): Cursor change at the window border
- 05:14 PM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- Cleanup finished.
Committed to the task branch 2565a revno 11026
Ready for the code review - 02:30 PM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- Custom mouse pointer support for the @COMBO-BOX@ (WebGUI) finished.
Committed to the task branch 2565a revno 11023... - 10:13 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- Greg Shah wrote:
> Please create a separate task for this. We may have someone else work it. Do not work on the ... - 10:08 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- > After that the only remaining issue will be cursor change on the window border. It should be difficult
Please crea... - 08:41 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- Greg Shah wrote:
> Igor: Please provide some details on the state of this task. I know you are working on some prob... - 08:06 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- Igor: Please provide some details on the state of this task. I know you are working on some problems with combo-box ...
- 02:34 PM Bug #2995: if the first mouse after app startup is on a combo-box, then an abend occurs
- Greg Shah wrote:
> Code Review Task Branch 2565a Revisions 11019/11020
> 1. Why are @WidgetRegistry.getComponents()... - 11:01 AM Bug #2995: if the first mouse after app startup is on a combo-box, then an abend occurs
- Code Review Task Branch 2565a Revisions 11019/11020
Overall, the approach seems good.
1. Why are @WidgetRegistr... - 02:06 PM Bug #2914: Fix errors in window_sizing/test_runner.p
- I've created task branch 2914a.
- 12:53 PM Bug #2849: implement and/or fix the default popup menus for all widgets
- Vadim Gindin wrote:
> I've tested DIALOG-BOX. System popups are really don't work for it. So I'm adding that support... - 12:28 PM Bug #2849: implement and/or fix the default popup menus for all widgets
- I've tested DIALOG-BOX. System popups are really don't work for it. So I'm adding that support to DialogBox in the sa...
- 10:36 AM Bug #2849: implement and/or fix the default popup menus for all widgets
- Vadim Gindin wrote:
> Hynek Cihlar wrote:
> > In @MenuGuiImpl@, why to use reflection instead of just calling the c... - 07:17 AM Bug #2849: implement and/or fix the default popup menus for all widgets
- Hynek Cihlar wrote:
> @EditorGuiImpl.mouseClicked()@
> The @wnd.initEditorPopup()@ call is fishy and I think may not ... - 11:00 AM Feature #2612: implement GUI conversion and runtime support for the SLIDER widget
- The conversion testing completed, generated codes are identical. Continue with runtime testing.
- 07:32 AM Feature #2612: implement GUI conversion and runtime support for the SLIDER widget
- Greg Shah wrote:
> Code Review Task Branch 2612b Revision 10987
>
> I'm fine with the changes. Please put them t... - 07:29 AM Feature #2612: implement GUI conversion and runtime support for the SLIDER widget
- Code Review Task Branch 2612b Revision 10987
I'm fine with the changes. Please put them through regression testing. - 07:47 PM Feature #2612: implement GUI conversion and runtime support for the SLIDER widget
- Task branch @2612b@ for review updated to revision @10987@.
Added support for @INT64@ internal slider variable. Sc...
02/16/2016
- 06:16 PM Feature #2612: implement GUI conversion and runtime support for the SLIDER widget
- Task branch @2612b@ for review updated to revision @10986@.
Notes resolution for point 1 and 3 from #60 note. The ... - 06:07 PM Feature #2612: implement GUI conversion and runtime support for the SLIDER widget
- > But the question: even if we can initially assign the big enough value the screen value can be from MIN to MAX - wh...
- 05:57 PM Feature #2612: implement GUI conversion and runtime support for the SLIDER widget
- >> The only data is possible to use with slider is INTEGER.
>Changing the Sl variable in slider_test01.p to int64... - 04:42 PM Feature #2612: implement GUI conversion and runtime support for the SLIDER widget
- >> 2. Can you use an int64 or decimal with a slider?
>
> The only data is possible to use with slider is INTEGER.
... - 04:39 PM Feature #2612: implement GUI conversion and runtime support for the SLIDER widget
- Guy: Eugenie's slider testcases exhibit a strange behavior in GUI. Consider this code:...
- 04:31 PM Feature #2612: implement GUI conversion and runtime support for the SLIDER widget
- >1. Please add comments to the javadoc for both versions of SliderWidget,setNoCurrentValue(). As you mention in note ...
- 04:03 PM Feature #2612: implement GUI conversion and runtime support for the SLIDER widget
- Code Review Task Branch 2612b Revision 10985
This is great work!
1. Please add comments to the javadoc for both... - 03:54 PM Feature #2612: implement GUI conversion and runtime support for the SLIDER widget
- Greg Shah wrote:
> What testcases shows this behavior?
Every test in @uast/slider/@ directory. In all of them the... - 03:31 PM Feature #2612: implement GUI conversion and runtime support for the SLIDER widget
- > Also I've made the change looking strange, so need your comments. I have found in 4GL when the slider value is chan...
- 06:00 PM Bug #2849: implement and/or fix the default popup menus for all widgets
- @EditorGuiImpl.mouseClicked()@
The @wnd.initEditorPopup()@ call is fishy and I think may not work in a @DIALOG-BOX@.... - 03:25 PM Bug #2849: implement and/or fix the default popup menus for all widgets
- Yes, you can start testing.
Hynek and Constantin: please review. - 12:58 PM Bug #2849: implement and/or fix the default popup menus for all widgets
- Fixed. Can I ran regression testing?
- 12:34 PM Bug #2849: implement and/or fix the default popup menus for all widgets
- Code Review Task Branch 2849a Revision 10995
1. In @EditorPopupGuiImpl@, this code:... - 05:11 AM Bug #2849: implement and/or fix the default popup menus for all widgets
- Greg Shah wrote:
> ..
> 3. It is not clear to me if the changes to how @invalidateSelection()@ is called in the @Ed... - 04:36 AM Bug #2849: implement and/or fix the default popup menus for all widgets
- I've rebased branch 2849a with the latest trunk revision. Current branch revision is 10992.
- 05:53 PM Support #2672: GUI web client performance improvements
- The difficult problems in ./browse/gui/browse-gui-stat1.p are
!browse_artifacts_in_title.png!
It happens after clicki... - 05:38 PM Support #2672: GUI web client performance improvements
- It looks the same for ./browse/gui/browse-gui-stat1.p, I am planning to check the dots drawing and to do it the same ...
- 05:05 PM Support #2672: GUI web client performance improvements
- Sergey Ivanovskiy wrote:
> If we draw the image exactly like it comes from the Java, the result should be like we se... - 05:00 PM Support #2672: GUI web client performance improvements
- Sergey Ivanovskiy wrote:
> It should be the same as the previous implementation it has been tested with demo_widgets... - 04:59 PM Support #2672: GUI web client performance improvements
- If we draw the image exactly like it comes from the Java, the result should be like we see, I have encountered it in ...
- 04:52 PM Support #2672: GUI web client performance improvements
- Sergey Ivanovskiy wrote:
> The image background issue is ...
Thanks for pointing this, I'll look into it. I think so... - 04:50 PM Support #2672: GUI web client performance improvements
- The image background issue is !icons_bg_issue.png!
- 04:42 PM Support #2672: GUI web client performance improvements
- Constantin Asofiei wrote:
> Sergey, about revision 11021; the changes look OK, but are you sure this gets us the sam... - 04:30 PM Support #2672: GUI web client performance improvements
- Sergey, about revision 11021; the changes look OK, but are you sure this gets us the same result as the previous impl...
- 03:54 PM Support #2672: GUI web client performance improvements
- 1811t rev 11022 enhances the drawing cache to include intermediate widget states; currently, caching is used only for...
- 12:02 PM Support #2672: GUI web client performance improvements
- Sergey Ivanovskiy wrote:
> Constantin, could you help? Does the Web Chui client support md5 hashing? It looks that p... - 11:48 AM Support #2672: GUI web client performance improvements
- Constantin, could you help? Does the Web Chui client support md5 hashing? It looks that p2j.socket.js is a common mod...
- 01:34 AM Support #2672: GUI web client performance improvements
- Greg Shah wrote:
> It got me thinking. When the user is editing text in a fill-in or editor (or a browse cell/simple... - 04:51 PM Bug #2911: Fix extra background shown for popup_ext.p
- Some more info for note 25; the main problem with menu and popup-menu is this: these widgets behave differently than ...
- 03:29 PM Feature #2967: web socket message sizes are limited to 32K, make sure that drawing ops and images...
- Agree, it doesn't require to use Web Workers API. There is an alternative to use Timers API or http://dbaron.org/log/...
- 12:04 PM Bug #2995: if the first mouse after app startup is on a combo-box, then an abend occurs
- Please find the diff file attached. The fix is committed to the task branch 2565a
- 11:07 AM Bug #2995: if the first mouse after app startup is on a combo-box, then an abend occurs
- I prefer not to add a 3rd party code dependency for this. The 3rd party code also seems more designed for caching. T...
- 11:04 AM Bug #2995: if the first mouse after app startup is on a combo-box, then an abend occurs
- From Igor:
After added synchronization for access to the WidgetRegistry.widgetList the problem seem to disappear. ... - 11:03 AM Bug #2995: if the first mouse after app startup is on a combo-box, then an abend occurs
- This was reported by Igor:
-------- Forwarded Message --------
Subject: Issue with COMBO-BOX
Date: Thu, 11 Feb... - 11:01 AM Bug #2995 (Closed): if the first mouse after app startup is on a combo-box, then an abend occurs
- 11:19 AM Bug #2914: Fix errors in window_sizing/test_runner.p
- Greg Shah wrote:
> Please create a 2914a task branch for the changes. I'd also like to see some details posted here... - 09:59 AM Bug #2914: Fix errors in window_sizing/test_runner.p
- Please create a 2914a task branch for the changes. I'd also like to see some details posted here about the problems ...
- 10:46 AM Bug #2784 (Rejected): ./menu/simple_sm.p displays parts of menus inside window content frame for ...
- I closing this, since all known issues are already resolved.
- 10:39 AM Bug #1830: implement SYSTEM-DIALOG-GET-FILE support
- > Implement everything from scratch keeping look and feel to match the Windows style. In this model all elements are...
- 10:35 AM Bug #1830: implement SYSTEM-DIALOG-GET-FILE support
- The customer has confirmed that these statements will soon be disabled in their code. We do not have to work this ta...
- 08:44 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- -------- Forwarded Message --------
Subject: Re: Mouse cursor
Date: Wed, 10 Feb 2016 13:55:42 -0500
From: Igor .... - 08:43 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- -------- Forwarded Message --------
Subject: Re: Mouse cursor
Date: Wed, 10 Feb 2016 13:38:27 -0500
From: Igor .... - 08:42 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- -------- Forwarded Message --------
Subject: Re: Mouse cursor
Date: Wed, 10 Feb 2016 13:26:26 -0500
From: Igor ...
02/15/2016
- 06:07 PM Support #2672: GUI web client performance improvements
- Code Review Task Branch 1811t Revisions 11020/11021
The changes in @p2j.canvas_renderer.js@ are pretty straightfor... - 05:29 PM Support #2672: GUI web client performance improvements
- This text was written by Sergey in #2967 (note 21):
> In the case of the text editor we have numerous synchronous ... - 04:40 PM Support #2672: GUI web client performance improvements
- Greg, please review the committed revision 11021. It reduced @putImageData@ invocations for horizontal and vertical l...
- 02:29 AM Support #2672: GUI web client performance improvements
- For vertical and horizontal lines the stroke that widens a line can be optimized to reduce @putImageData@, because th...
- 05:37 PM Feature #2967: web socket message sizes are limited to 32K, make sure that drawing ops and images...
- > The note 18 states that if we send a large message from JS to Java using JS WebSocket API, then the Jetty server ca...
- 12:36 PM Feature #2967: web socket message sizes are limited to 32K, make sure that drawing ops and images...
- > 4. I don't understand all your findings so far. In particular, you state in notes 12 and 14 above, that our curren...
- 11:51 AM Feature #2967: web socket message sizes are limited to 32K, make sure that drawing ops and images...
- Some thoughts:
1. The current RFC implements a per "frame" payload size specified in the frame header with a maxim... - 01:25 PM Bug #2982: in Web client, overlay window must not be "resizeable"
- @processWindowBorder@ is noop when overlay window is active.
Committed to the task branch 2565a revno 11022. - 11:24 AM Bug #2787: implement mnemonics/accelerator key support for button
- # How is the alert-box relates to mnemonics?
# Does button grouping mechanism supported not or it doesn't supported ... - 08:23 AM Bug #2787: implement mnemonics/accelerator key support for button
- Created task branch 2787a from P2J trunk revision 10971.
- 10:52 AM Bug #2857: font differences for toggle box and menu
- Vadim, are the metrics of the toggle-box correct? I mean, the widget height/width (and its inner highlight rectangle)...
- 10:18 AM Bug #2849: implement and/or fix the default popup menus for all widgets
- Code Review Task Branch 2849a Revision 10991
1. Please rebase this to the latest trunk revision 10971.
2. The u... - 08:02 AM Bug #2784: ./menu/simple_sm.p displays parts of menus inside window content frame for the web client
- I've checked it just now. It is not reproduced in the current trunk revision (10971).
- 07:15 AM Feature #2612: implement GUI conversion and runtime support for the SLIDER widget
- Rebased task branch @2612b@ from P2J trunk revision @10971@, new revision is @10985@.
- 06:47 AM Bug #2911: Fix extra background shown for popup_ext.p
- Vadim Gindin wrote:
> So I thought so and I'd tried to fix this changing the point used to call the body from @bodyL... - 05:57 AM Feature #1801: add some frame options
- Task branch 2038b was merged to trunk as revision 10971.
It resolves the runtime support for FRAME/WINDOW attribut... - 05:36 AM Feature #1801: add some frame options
- Hynek Cihlar wrote:
> Are you ok with merging 2038b revision 11000 to trunk?
Yes, go ahead and merge to trunk. - 05:23 AM Feature #1801: add some frame options
- Constantin Asofiei wrote:
> Hynek, about 2038b revision 10999:
> # @Frame.calculateWidth@ - line 1619 has some comm... - 04:54 AM Feature #1801: add some frame options
- Hynek, about 2038b revision 10999:
# @Frame.calculateWidth@ - line 1619 has some commented code, remove it if is no ...
02/14/2016
- 04:42 PM Bug #1830: implement SYSTEM-DIALOG-GET-FILE support
- Greg Shah wrote:
> Actually, I'm trying to avoid doing this task for the current project. I am waiting to hear back... - 04:41 PM Bug #1830: implement SYSTEM-DIALOG-GET-FILE support
- Actually, I'm trying to avoid doing this task for the current project. I am waiting to hear back from the customer. ...
- 01:23 PM Bug #2911: Fix extra background shown for popup_ext.p
- Sub-menu body background looks drawn in a correct point, but it is also cut (clipped), so it is hardly depends on ite...
- 06:00 AM Bug #2911: Fix extra background shown for popup_ext.p
- So I thought so and I'd tried to fix this changing the point used to call the body from @bodyLoc@ to @this.physicalLo...
- 05:50 AM Bug #2911: Fix extra background shown for popup_ext.p
- Could you help me to deal with that. Here is the sub-menus hierarchy: Menu->SubMenu["John"]->SubMenu["sm00"].
Here...
02/13/2016
- 05:05 PM Support #2672: GUI web client performance improvements
- Greg, Constantin, the committed revision 11020 reduces @putImageData@ invocations for horizontal and vertical lines. ...
- 03:54 PM Feature #1801: add some frame options
- 2038b revision 10999 passes ChUI regression tests, GUI regression tests and the supported customer GUI demo screens. ...
- 07:07 PM Bug #1830: implement SYSTEM-DIALOG-GET-FILE support
- Is this the next task in queue, correct?
- 07:03 PM Bug #1830: implement SYSTEM-DIALOG-GET-FILE support
- This is the simple demo for @SYSTEM-DIALOG GET-FILE@ statement. As you can see it is the native OS dialog. So we have...
02/12/2016
- 03:39 PM Bug #2968: disconnect/reconnect and manual reload must re-establish the websocket connection, nee...
- 1) Disconnect/reconnect usecase
Greg, please could you explain disconnect/reconnect? Does it mean the main connectio... - 11:27 AM Feature #2612: implement GUI conversion and runtime support for the SLIDER widget
- Task branch @2612b@ for review updated to revision @10983, 10984@.
Added missed @ASSIGN@ statement support. Now th... - 07:21 PM Feature #2612: implement GUI conversion and runtime support for the SLIDER widget
- Some mote testing for GUI slider:
1. The web client works fine, see the attached file for sample.
2. There is one... - 05:43 AM Support #2672: GUI web client performance improvements
- Constantin, please look at this diff with the current 1811t. It works but the performance hasn't been increased yet. ...
- 12:41 AM Feature #2967: web socket message sizes are limited to 32K, make sure that drawing ops and images...
- Found that on the current branch the draw buffer size (0x81 message) is large enough if we scroll down the editor con...
02/11/2016
- 02:05 PM Feature #2967: web socket message sizes are limited to 32K, make sure that drawing ops and images...
- According to my test if we send the file with its size exceeding the maximum binary message size excepted by Jetty (g...
- 01:22 PM Feature #2612: implement GUI conversion and runtime support for the SLIDER widget
- Task branch @2612b@ for review updated to revision @10982@.
The screenshot for dynamic widget in @P2J@ is attached... - 08:27 PM Feature #2612: implement GUI conversion and runtime support for the SLIDER widget
- Task branch @2612b@ for review updated to revision @10981@.
The update has changes that fixes the current value co... - 01:14 PM Bug #2911: Fix extra background shown for popup_ext.p
- > It means that @Origin@ of sm00 is @219:104@. What does @AbstractGuiDriver.translatedOrigin@ contain? Is it a locati...
- 12:33 PM Bug #2911: Fix extra background shown for popup_ext.p
- John drawing bitmap at: 25:104 with clip: NativeRectangle[top=0, left=0, bottom=23, right=100]
John drawing body bit... - 08:31 AM Bug #2911: Fix extra background shown for popup_ext.p
- Vadim Gindin wrote:
> I've fixed bodyLoc translation in SubMenuGuiImpl.draw(). It was translated twice, that was wro... - 05:38 AM Bug #2911: Fix extra background shown for popup_ext.p
- I've fixed bodyLoc translation in SubMenuGuiImpl.draw(). It was translated twice, that was wrong and coordinates look...
- 11:28 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- 1. The discussion become too deep inside the code logic to be private. Please move it to the Redmine, appropriate tas...
- 11:28 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- Well. it seem that the problem is in the AbstractContainer. findMouseSource method. Its implementation seems a little...
- 11:26 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- I will take a look. Please note however that for all widgets except drop-down part of the COMBO-BOX mouse hover event...
- 11:26 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- Hi Igor,
The mouse events for drop-down's ScrollableSelectionListGuiImpl component is routed from ScrollPaneGuiImp... - 11:25 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- Hi Eugenie,
I'm working now on the runtime support for the custom mouse cursor (LOAD-MOUSE-POINTER method). At this ... - 09:34 AM Feature #1801: add some frame options
- Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > All work OK.
> Great!
>
> Have you checked the standalone G... - 09:17 AM Feature #1801: add some frame options
- Hynek Cihlar wrote:
> All work OK.
Great!
Have you checked the standalone GUI tests? - 09:12 AM Feature #1801: add some frame options
- Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > Yes, I didn't find any regressions there. What is the official ... - 07:03 AM Feature #1801: add some frame options
- Hynek Cihlar wrote:
> Yes, I didn't find any regressions there. What is the official test scenario that should work?... - 06:38 AM Feature #1801: add some frame options
- Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > Constantin, please review.
> I'm OK with the changes. I assum... - 06:02 AM Feature #1801: add some frame options
- Hynek Cihlar wrote:
> Constantin, please review.
I'm OK with the changes. I assume some cleanup is still needed, a... - 04:18 AM Feature #1801: add some frame options
- The ChUI regression test run ended with a regression, an NPE in FillIn.draw(). This was fixed in 2038b revision 10995...
02/10/2016
- 05:54 PM Feature #2612: implement GUI conversion and runtime support for the SLIDER widget
- Interesting finding about usage of the @NO-CURRENT-VALUE@ attribute option. According to the Progress documentation t...
- 08:36 PM Feature #2612: implement GUI conversion and runtime support for the SLIDER widget
- Task branch @2612b@ for review updated to revision @10980@.
The update implements the tic marks calculation compatib... - 02:36 PM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- Rebased task branch 2565a from P2J trunk rev 10970. The latest revision is now 11015.
- 02:28 PM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- Fixed @LOAD-MOUSE-POINTER@ support for the @COMBO-BOX@ (Swing GUI).
Committed to the task branch 2565a revno 11012. - 01:18 PM Feature #2967: web socket message sizes are limited to 32K, make sure that drawing ops and images...
- Sergey Ivanovskiy wrote:
> Greg, should I commit my changes without @remote.sendPartialBytes(data,isLast)@?
The pro... - 12:59 PM Feature #2967: web socket message sizes are limited to 32K, make sure that drawing ops and images...
- My Firefox websocket configuration parameters are in this picture. @network.websocket.max-message-size@ is related to...
- 12:40 PM Feature #2967: web socket message sizes are limited to 32K, make sure that drawing ops and images...
- Since the Web Socket Jetty API and web socket browser's client don't work as it is expected. This article http://www....
- 03:10 AM Feature #1801: add some frame options
- Hynek Cihlar wrote:
> Hynek Cihlar wrote:
> > Please review 2038b revision 10994. This resolves all known issues pl...
02/09/2016
- 05:44 PM Feature #1801: add some frame options
- Hynek Cihlar wrote:
> Please review 2038b revision 10994. This resolves all known issues plus some minor improvement... - 05:44 PM Feature #1801: add some frame options
- Constantin Asofiei wrote:
> If you are not aware yet, see test @popup_ext.p@ - with your changes, borders are being ... - 05:42 PM Feature #1801: add some frame options
- Please review 2038b revision 10994. This resolves all known issues plus some minor improvements to Widget Browser.
- 07:42 AM Feature #1801: add some frame options
- Constantin Asofiei wrote:
> Hynek, about the question in @Frame.setOuterSize()@: the @updateContentWidth@ call is no... - 07:31 AM Feature #1801: add some frame options
- > If you are not aware yet, see test @popup_ext.p@ - with your changes, borders are being drawn. Is this related to ...
- 07:22 AM Feature #1801: add some frame options
- Hynek, about the question in @Frame.setOuterSize()@: the @updateContentWidth@ call is no longer needed, as you've cha...
- 08:47 PM Feature #1801: add some frame options
- Code Review Task branch 2038b Revision 10990
I'm fine with the changes.
I will review again when the last fix i... - 07:47 PM Feature #1801: add some frame options
- 2038b revision 10990 contains regression fixes with one yet unresolved issue, the unexpected verticalStep from note 3...
- 02:34 PM Feature #2967: web socket message sizes are limited to 32K, make sure that drawing ops and images...
- For an example, ./demo/sample2.bmp has 43.9 kB (43,854 bytes) that exceeds the limit returned by @session.getPolicy()...
- 02:17 PM Feature #2967: web socket message sizes are limited to 32K, make sure that drawing ops and images...
- Greg, should I commit my changes without @remote.sendPartialBytes(data,isLast)@?
- 02:12 PM Feature #2967: web socket message sizes are limited to 32K, make sure that drawing ops and images...
- I encountered troubles if we use the Jetty partial message API @remote.sendPartialBytes(data,isLast)@, then the JS we...
- 09:13 AM Feature #2967: web socket message sizes are limited to 32K, make sure that drawing ops and images...
- The code changes are ready. The test with Firefox is passed. Planning to add comments and to commit within two or mor...
- 10:21 AM Bug #2849: implement and/or fix the default popup menus for all widgets
- I've committed the following changes: isRMBEntrySupported method(), added corresponding check to ThinClient.processPr...
- 05:36 AM Bug #2849: implement and/or fix the default popup menus for all widgets
- Scroll bars are also ignore RMB click and in this case scrollbar owner will get ENTRY event after scroll popup will b...
- 12:42 AM Bug #2988: The web click events on the caption buttons can invoke the resize action.
- Clicking on the minimized caption button can invoke the resize action for the window under the caption button if the ...
- 12:38 AM Bug #2988 (Closed): The web click events on the caption buttons can invoke the resize action.
- 12:31 AM Bug #2987: the combo-box's resources aren't disposed if its dropdown is collapsed
- Updated by Eugenie Lyzenko 5 days ago:
Sergey Ivanovskiy wrote:
> Eugenie, please look at this diff, it clea... - 12:29 AM Bug #2987: the combo-box's resources aren't disposed if its dropdown is collapsed
- Eugenie, please look at this diff, it cleans resources for web and gui. Planning to postpone this fix because the roo...
- 12:28 AM Bug #2987: the combo-box's resources aren't disposed if its dropdown is collapsed
- Updated by Eugenie Lyzenko 5 days ago:
I think the best place is @ComboBoxGuiImpl.postprocessDropDown()@. Here we ... - 12:26 AM Bug #2987: the combo-box's resources aren't disposed if its dropdown is collapsed
- Found two methods that are supposed to clean up resources, but actually they don't clean up....
- 12:22 AM Bug #2987 (New): the combo-box's resources aren't disposed if its dropdown is collapsed
- 12:19 AM Bug #2986 (Closed): ./demo/simple_windows.p opens the frame titled "second frame" with unset init...
- 08:49 PM Feature #2612: implement GUI conversion and runtime support for the SLIDER widget
- This is good headway! It looks like you are very close.
- 07:38 PM Feature #2612: implement GUI conversion and runtime support for the SLIDER widget
- Task branch @2612b@ for review updated to revision @10979@.
The update has fixes to draw slider for every mode. Th...
02/08/2016
- 04:45 PM Bug #2911: Fix extra background shown for popup_ext.p
- Vadim, the problem is with the fact that the items in the sub-menu's body are drawn with incorrect coordinates (they ...
- 02:03 PM Feature #2967: web socket message sizes are limited to 32K, make sure that drawing ops and images...
- The plan sounds reasonable.
- 12:45 PM Feature #2967: web socket message sizes are limited to 32K, make sure that drawing ops and images...
- >I would also like to see message types as a symbolic names like we do with p2j.screen.ops for the drawing ops. This ...
- 12:41 PM Feature #2967: web socket message sizes are limited to 32K, make sure that drawing ops and images...
- >Use transferable objects in order to increase the round trip time between JS UI thread and the web worker thread.
S... - 12:14 PM Feature #2967: web socket message sizes are limited to 32K, make sure that drawing ops and images...
- > Use transferable objects in order to increase the round trip time between JS UI thread and the web worker thread.
... - 02:02 PM Bug #2849: implement and/or fix the default popup menus for all widgets
- Greg Shah wrote:
> ..
> If you click on some other widget in the same window (for example, a button), then the butt... - 11:47 AM Bug #2849: implement and/or fix the default popup menus for all widgets
- > May be it is needed to implement menus in a separate window first to go further in the proposed way. What do you th...
- 12:46 AM Bug #2849: implement and/or fix the default popup menus for all widgets
- I suppose it would be better to commit system menus and finish ENTRY event in some other task?
- 01:53 PM Support #2672: GUI web client performance improvements
- Sergey Ivanovskiy wrote:
> I thought about the JS optimization to reduce numerous calls of puImageData and came to th... - 09:25 AM Bug #2857: font differences for toggle box and menu
- Could you recall me, when I got actual text and font metrics will be the fonts equal? In my case they are similar but...
02/07/2016
- 12:33 PM Feature #2967: web socket message sizes are limited to 32K, make sure that drawing ops and images...
- Following this plan:
1) Create the common module for the input and output operations - @p2j.io.js@
2) Reuse @p2j.io.j... - 09:31 AM Bug #2849: implement and/or fix the default popup menus for all widgets
- So, can I start to implement menus in a separate window?
- 09:07 AM Bug #2911: Fix extra background shown for popup_ext.p
- I've fixed PaintEvent's, but SubMenu's body still doesn't drawn. Constantin, could you have a look? Current branch re...
02/06/2016
- 04:01 PM Feature #2612: implement GUI conversion and runtime support for the SLIDER widget
- Greg Shah wrote:
> This is all coming along nicely. My only comment is that the colors/shading of the edges of the ... - 05:01 AM Feature #2612: implement GUI conversion and runtime support for the SLIDER widget
- This is all coming along nicely. My only comment is that the colors/shading of the edges of the SVG thumbs does not ...
- 09:48 PM Feature #2612: implement GUI conversion and runtime support for the SLIDER widget
- The work for slider elements adjustment to completely fit the @4gl@ is in progress. Some intermediate results can be ...
- 03:20 PM Feature #2967: web socket message sizes are limited to 32K, make sure that drawing ops and images...
- In any case if the websocket on the java side doesn't support messages that exceed the 32K limit, then we need to spl...
02/05/2016
- 06:54 PM Feature #1801: add some frame options
- After the last ChUI regression test run 2038b has three unresolved issues:
* wrong report page size, this is a con... - 03:13 AM Feature #1801: add some frame options
- Ctrl-C part passed, Main part has failed. Overall a great improvement from the previous ChUI regression test run. The...
- 05:55 PM Feature #2612: implement GUI conversion and runtime support for the SLIDER widget
- Rebased task branch @2612b@ from P2J trunk revision @10970@, new revision is @10978@.
- 08:39 PM Feature #2612: implement GUI conversion and runtime support for the SLIDER widget
- Slider testcases updated in bzr to revision @1465@.
- 08:29 PM Feature #2612: implement GUI conversion and runtime support for the SLIDER widget
- Task branch @2612b@ for review updated to revision @10977@.
This is rework for all thumb images to exactly match t... - 05:28 PM Feature #1811: implement the AJAX client driver
- Rebased 1811t from trunk revision 10970. The latest revision is now 11018.
- 01:13 PM Feature #2967: web socket message sizes are limited to 32K, make sure that drawing ops and images...
- If my understanding is correct, then Firefox Web Socket API doesn't require splitting data, if it sends/reads data ob...
- 10:33 AM Feature #2967: web socket message sizes are limited to 32K, make sure that drawing ops and images...
- We should not have a message limit. If it goes above 32K (the inherent limit in websockets), we should send multiple...
- 10:07 AM Feature #2967: web socket message sizes are limited to 32K, make sure that drawing ops and images...
- Greg, please could you write the requirements for this task? Should the maximum message size be configured via the di...
- 11:05 AM Bug #2982: in Web client, overlay window must not be "resizeable"
- Constantin Asofiei wrote:
> Just use a test like this:
> [...]
> open the combo's drop-down and move the mouse aro... - 11:04 AM Bug #2982: in Web client, overlay window must not be "resizeable"
- Just use a test like this:...
- 08:54 AM Bug #2956: When switching windows with Web GUI task bar the source window is not deactivated
- Committed revision 11015 resolves the @TypeAHead@ lock between the main and web worker threads.
- 08:34 AM Bug #2956: When switching windows with Web GUI task bar the source window is not deactivated
- Sergey Ivanovskiy wrote:
> Constantin Asofiei wrote:
> > I think the lock in @TypeAhead.getKeystroke@ should be mov... - 08:12 AM Bug #2956: When switching windows with Web GUI task bar the source window is not deactivated
- Constantin Asofiei wrote:
> I think the lock in @TypeAhead.getKeystroke@ should be moved from the method into its bo... - 04:52 AM Bug #2956: When switching windows with Web GUI task bar the source window is not deactivated
- I think the lock in @TypeAhead.getKeystroke@ should be moved from the method into its body, i.e.:...
- 04:23 AM Bug #2956: When switching windows with Web GUI task bar the source window is not deactivated
- I would like to notify here even this task is unrelated about the blocking state between main thread...
- 04:04 AM Bug #2956: When switching windows with Web GUI task bar the source window is not deactivated
- Ok, understand. Good news are these lines of the code can be successfully eliminated committed rev. 11012. Now the re...
- 04:02 AM Bug #2956: When switching windows with Web GUI task bar the source window is not deactivated
- Sergey Ivanovskiy wrote:
> Sergey Ivanovskiy wrote:
> > I think it is a new requirement to forbid the usage of @Win... - 01:43 AM Bug #2956: When switching windows with Web GUI task bar the source window is not deactivated
- Sergey Ivanovskiy wrote:
> I think it is a new requirement to forbid the usage of @WindowManager.getActiveWindow()@ ... - 12:31 AM Bug #2956: When switching windows with Web GUI task bar the source window is not deactivated
- Hynek Cihlar wrote:
> Sergey can you please explain in what situations is the parameter @focusOut@ needed?... - 12:24 AM Bug #2956: When switching windows with Web GUI task bar the source window is not deactivated
- Hynek Cihlar wrote:
> Sergey Ivanovskiy wrote:
> > Hynek, please look at the committed revision 11010, the diff is at... - 05:52 AM Bug #2928: non-localhost testing and fixes
- Constantin Asofiei wrote:
> Sergey, an issue about using @XMLHTTPRequest@ - if the web client startup fails, then th... - 05:35 AM Bug #2928: non-localhost testing and fixes
- Committed revision 11013 should fix the incorrect processing error's page.
- 04:54 AM Bug #2928: non-localhost testing and fixes
- Constantin Asofiei wrote:
> Sergey, an issue about using @XMLHTTPRequest@ - if the web client startup fails, then th... - 04:40 AM Bug #2928: non-localhost testing and fixes
- Sergey, an issue about using @XMLHTTPRequest@ - if the web client startup fails, then the message is not displayed as...
- 05:21 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
- Section 27 has been updated.
- 01:56 AM Bug #2849: implement and/or fix the default popup menus for all widgets
- I recall that at this step menus are implemented in the same window. In other words opened popup window is still in t...
02/04/2016
- 05:52 PM Bug #2982: in Web client, overlay window must not be "resizeable"
- Constantin Asofiei wrote:
> Currently, when hovering the mouse on the edge of a i.e. drop-down combobox, the mouse p... - 05:43 PM Bug #2982: in Web client, overlay window must not be "resizeable"
- Greg Shah wrote:
> Igor: are you already planning to handle this issue as part of #2565?
If I understand this issue... - 05:41 PM Bug #2982: in Web client, overlay window must not be "resizeable"
- Igor: are you already planning to handle this issue as part of #2565?
- 05:38 PM Bug #2982: in Web client, overlay window must not be "resizeable"
- Currently, when hovering the mouse on the edge of a i.e. drop-down combobox, the mouse pointer is switched to a "wind...
- 05:37 PM Bug #2982 (Closed): in Web client, overlay window must not be "resizeable"
- 02:06 PM Feature #1801: add some frame options
- ChUI regression tests for 2038b restarted.
- 12:55 PM Feature #1801: add some frame options
- Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > Constantin, is it expected for the @Frame.verticalStep@ to be e... - 10:12 AM Feature #1801: add some frame options
- Hynek Cihlar wrote:
> Constantin, is it expected for the @Frame.verticalStep@ to be equal to the size of base unit w... - 07:56 AM Feature #1801: add some frame options
- Greg Shah wrote:
> Code Review Task branch 2038b Revision 10983
>
> I'm fine with the changes.
>
> How bad are... - 07:45 AM Feature #1801: add some frame options
- Code Review Task branch 2038b Revision 10983
I'm fine with the changes.
How bad are the regressions? - 07:23 AM Feature #1801: add some frame options
- Hynek Cihlar wrote:
> ChUI regression testing is in progress.
The test run finished with regressions. - 10:29 AM Bug #2978: The Swing GUI window cannot be dragged between two monitors
- Moreover: even when the window is moved to another monitor via Alt-F7 is sometimes moves back to the initial one "by ...
- 08:18 AM Bug #2978: The Swing GUI window cannot be dragged between two monitors
- The Swing GUI window cannot be dragged between two monitors. It is possible to do it via Alt-F7.
- 08:17 AM Bug #2978 (New): The Swing GUI window cannot be dragged between two monitors
- 08:19 AM Bug #2979: The drop-down selection list for the combo-box is not properly aligned in the WebGUI
- The drop-down selection list for the combo-box is not properly aligned (shifted to the left) in the WebGUI
- 08:19 AM Bug #2979 (New): The drop-down selection list for the combo-box is not properly aligned in the We...
- 07:56 AM Bug #2849: implement and/or fix the default popup menus for all widgets
- > I think this is the same case as with combo drop-down. We do not handle mouse-click there but rather rely on Window...
- 05:56 AM Bug #2956: When switching windows with Web GUI task bar the source window is not deactivated
- Sergey Ivanovskiy wrote:
> Hynek, please look at the committed revision 11010, the diff is attached, taking into acc... - 05:33 AM Bug #2956: When switching windows with Web GUI task bar the source window is not deactivated
- Sergey Ivanovskiy wrote:
> If we use TAB/SHIFT+TAB keys, then at the beginning these keys help to move between widge...
Also available in: Atom