Activity

From 04/20/2016 to 05/19/2016

05/19/2016

06:18 PM Bug #2970 (WIP): rework menus to use OverlayWindow: Hynek Cihlar
06:16 PM Bug #3071 (Closed): A NPE is thrown when Alt-Tab while COMBO-BOX drop down active: Greg Shah
06:14 PM Bug #3071: A NPE is thrown when Alt-Tab while COMBO-BOX drop down active: Cannot reproduce anymore, resolved by #3062. Hynek Cihlar
03:02 PM Bug #2931: test Safari browser support: Committed revision 11045 fixed drawings of images. It seems that Chrome and Safari browsers have the same drawing iss... Sergey Ivanovskiy
02:59 PM Bug #2931: test Safari browser support: The P2J standard server certificate must be set as a trusted one at the first access to the login page. If it isn't d... Sergey Ivanovskiy
10:04 AM Bug #2931: test Safari browser support: Committed revision 11044(3084a) substitutes "const" statements to "var"s. Encountered new issue that self-signed cert... Sergey Ivanovskiy

05/18/2016

09:36 AM Bug #2857: font differences for toggle box and menu: Vadim, please use this patch for @AbstractGuiDriver.draw()@:... Constantin Asofiei

05/17/2016

03:19 PM Bug #2923: ./combo_box/combo_box9_1.p web combobox width is not enough to display its content wit...: Committed revision 11043 fixes this issue. The screen looks suitable. Sergey Ivanovskiy
02:44 PM Bug #2923: ./combo_box/combo_box9_1.p web combobox width is not enough to display its content wit...: The proposed solution doesn't work because it applies the stretch to the content uniformly to all combo boxes. There ... Sergey Ivanovskiy
02:53 PM Bug #2857: font differences for toggle box and menu: Here is the test to recreate the error:... Vadim Gindin
02:47 PM Bug #3113 (Closed): web client failure when trying to connect two web clients to the same P2J server: Greg Shah
02:29 PM Bug #3113: web client failure when trying to connect two web clients to the same P2J server: Sergey Ivanovskiy wrote:
> Have checked that if @webClient/port@ is 0, then we can use two clients simultaneously. I... Constantin Asofiei
02:28 PM Bug #3113: web client failure when trying to connect two web clients to the same P2J server: Have checked that if @webClient/port@ is 0, then we can use two clients simultaneously. I think the debug port is als... Sergey Ivanovskiy
02:01 PM Bug #3113: web client failure when trying to connect two web clients to the same P2J server: Sergey, I think you might be right, at that time I forgot that the web port (on which the redirection is done) is har... Constantin Asofiei
01:44 PM Bug #3113: web client failure when trying to connect two web clients to the same P2J server: Greg Shah wrote:
> Constantin reports:
>
> > have you tried connecting two web clients, to the same server (on th... Sergey Ivanovskiy
01:26 PM Bug #3113: web client failure when trying to connect two web clients to the same P2J server: Constantin reports:
> have you tried connecting two web clients, to the same server (on the same machine)? I get ... Greg Shah
01:25 PM Bug #3113 (Closed): web client failure when trying to connect two web clients to the same P2J server: Greg Shah

05/16/2016

09:45 AM Bug #3062 (Closed): COMBO-BOX steals focus when its drop-down active: Greg Shah
09:43 AM Bug #3062: COMBO-BOX steals focus when its drop-down active: 3062a merged to trunk as revision 11030 and archived. Hynek Cihlar
09:15 AM Bug #3062: COMBO-BOX steals focus when its drop-down active: Please go ahead and merge to trunk. Greg Shah

05/15/2016

12:48 PM Bug #3062: COMBO-BOX steals focus when its drop-down active: 3062a rebased against trunk rev 11029 and now at rev 11041. Greg, please let me know when it can be merged to trunk. Hynek Cihlar

05/13/2016

06:24 PM Bug #3062: COMBO-BOX steals focus when its drop-down active: Hynek Cihlar wrote:
>
> Yes, this works as expected.
OK. I have no other concerns for now. Eugenie Lyzenko
06:10 PM Bug #3062: COMBO-BOX steals focus when its drop-down active: Eugenie Lyzenko wrote:
> Imagine you have opened drop-down and press other button. The reaction for this single clic... Hynek Cihlar
06:04 PM Bug #3062: COMBO-BOX steals focus when its drop-down active: Hynek Cihlar wrote:
> Eugenie Lyzenko wrote:
> > My only concern is related to removed logic for @leave-and-repost@... Eugenie Lyzenko
05:20 PM Bug #3062: COMBO-BOX steals focus when its drop-down active: Eugenie Lyzenko wrote:
> My only concern is related to removed logic for @leave-and-repost@ mouse clicks approach. Y... Hynek Cihlar
04:06 PM Bug #3062: COMBO-BOX steals focus when its drop-down active: My only concern is related to removed logic for @leave-and-repost@ mouse clicks approach. You need to be sure the upd... Eugenie Lyzenko
03:27 PM Bug #3062: COMBO-BOX steals focus when its drop-down active: Greg Shah wrote:
>
> Eugenie and Constantin: do either of you have any concerns? I plan for Hynek to merge this t... Eugenie Lyzenko
03:13 PM Bug #3062: COMBO-BOX steals focus when its drop-down active: Greg Shah wrote:
> Eugenie and Constantin: do either of you have any concerns?
The changes are OK for me.
Constantin Asofiei
02:57 PM Bug #3062: COMBO-BOX steals focus when its drop-down active: Code Review Task Branch 3062a Revision 11038
The changes look good. I did commit some minor comment cleanup, but ... Greg Shah
02:10 PM Bug #3062: COMBO-BOX steals focus when its drop-down active: 3062a revision 11038 passed ChUI and GUI regression tests and was rebased against trunk revision 11028. Please review. Hynek Cihlar
08:16 AM Bug #2857: font differences for toggle box and menu: It seems this bug is not caused by menu classes.. Not sure, I've changed bgColor of them but the target rectangle did... Vadim Gindin
06:19 AM Bug #2857: font differences for toggle box and menu: I've committed current changes (sub-menus refactoring) and rebased the branch. Now current revision is 11037 (trunk r... Vadim Gindin
05:19 AM Bug #2857: font differences for toggle box and menu: I've faced with some problem after my refactoring:
!overritten_mi.png!
The second item in menubar is overwritten so... Vadim Gindin
07:37 AM Bug #3075: The window icon popup menu isn't displayed if a user clicks on the window icon by the ...: @./simple_alert_box.p com.goldencode.testcases.SimpleAlertBox.execute@ The web client issue is if we select "Close" ... Sergey Ivanovskiy
07:29 AM Bug #3075: The window icon popup menu isn't displayed if a user clicks on the window icon by the ...: Committed revision 11032 fixes the creation of window popup for a modal window. I have checked SELECTION-LIST widget,... Sergey Ivanovskiy
05:45 AM Bug #3075: The window icon popup menu isn't displayed if a user clicks on the window icon by the ...: Constantin Asofiei wrote:
> Sergey, about 3084a rev 11029:
> # for the title-bar popup: for embedded mode, no decor... Sergey Ivanovskiy
06:41 AM Bug #3106: Various GUI COMBO-BOX issues: Another issue. Combo-box drop-down won't close on ESC key.
EDIT: In ChUI.
Hynek Cihlar
05:57 AM Bug #3106: Various GUI COMBO-BOX issues: Another issue. When VALUE-CHANGED event handler disables the combo's parent frame, the combo's active drop-down must ... Hynek Cihlar
09:54 PM Bug #2923: ./combo_box/combo_box9_1.p web combobox width is not enough to display its content wit...: Greg Shah wrote:
> Code Review Task Branch 3084a Revision 11025 (was 11019)
>
> One thing that seems wrong is the... Sergey Ivanovskiy

05/12/2016

01:29 PM Bug #3107: GUI FRAME height may be calculated wrong due to rounding: ... Hynek Cihlar
01:26 PM Bug #3107 (New): GUI FRAME height may be calculated wrong due to rounding: Hynek Cihlar
12:28 PM Bug #2923: ./combo_box/combo_box9_1.p web combobox width is not enough to display its content wit...: Sergey Ivanovskiy wrote:
> I have checked that scaling text items doesn't help. It produces artifacts of double lette... Sergey Ivanovskiy
11:51 AM Bug #2923: ./combo_box/combo_box9_1.p web combobox width is not enough to display its content wit...: I have checked that scaling text items doesn't help. It produces artifacts of double letters and looks bad. But this ... Sergey Ivanovskiy
08:27 AM Bug #2923: ./combo_box/combo_box9_1.p web combobox width is not enough to display its content wit...: Planning to roll back combo box changes and to postpone this task. It is due to the font's antialiased effect. Greg, ... Sergey Ivanovskiy
08:21 AM Bug #2923: ./combo_box/combo_box9_1.p web combobox width is not enough to display its content wit...: Eugenie Lyzenko wrote:
> Constantin Asofiei wrote:
> > Sergey Ivanovskiy wrote:
> > > It seems that the web item text... Sergey Ivanovskiy
07:41 AM Bug #2923: ./combo_box/combo_box9_1.p web combobox width is not enough to display its content wit...: Constantin Asofiei wrote:
> Sergey Ivanovskiy wrote:
> > It seems that the web item text occupies the larger space ... Eugenie Lyzenko
06:30 AM Bug #2923: ./combo_box/combo_box9_1.p web combobox width is not enough to display its content wit...: Constantin Asofiei wrote:
> Sergey Ivanovskiy wrote:
> > It seems that the web item text occupies the larger space ... Sergey Ivanovskiy
06:11 AM Bug #2923: ./combo_box/combo_box9_1.p web combobox width is not enough to display its content wit...: Sergey Ivanovskiy wrote:
> It seems that the web item text occupies the larger space than the same text in 4GL winde... Constantin Asofiei
06:10 AM Bug #2923: ./combo_box/combo_box9_1.p web combobox width is not enough to display its content wit...: Constantin Asofiei wrote:
> Sergey Ivanovskiy wrote:
> > I have 3 pictures for @./combo_box/combo_box9_1.p@ : 4GL f... Sergey Ivanovskiy
06:01 AM Bug #2923: ./combo_box/combo_box9_1.p web combobox width is not enough to display its content wit...: Sergey Ivanovskiy wrote:
> I have 3 pictures for @./combo_box/combo_box9_1.p@ : 4GL from windev01, P2J swing and web... Constantin Asofiei
05:56 AM Bug #2923: ./combo_box/combo_box9_1.p web combobox width is not enough to display its content wit...: I have 3 pictures for @./combo_box/combo_box9_1.p@ : 4GL from windev01, P2J swing and web clients. Eugenie, could you... Sergey Ivanovskiy
01:32 AM Bug #2923: ./combo_box/combo_box9_1.p web combobox width is not enough to display its content wit...: Removed note 29. The test ./combo_box/combo_box9_1.p is correct. Sergey Ivanovskiy
01:15 AM Bug #2923: ./combo_box/combo_box9_1.p web combobox width is not enough to display its content wit...: Sergey Ivanovskiy wrote:
> Have found that the current solution isn't acceptable because different items are placed ... Sergey Ivanovskiy
01:06 AM Bug #2923: ./combo_box/combo_box9_1.p web combobox width is not enough to display its content wit...: Have found that the current solution isn't acceptable because different items are placed with different offsets. Thus... Sergey Ivanovskiy
12:47 AM Bug #2923: ./combo_box/combo_box9_1.p web combobox width is not enough to display its content wit...: Eugenie Lyzenko wrote:
> Sergey Ivanovskiy wrote:
> >
> > No, it adds additional parameters to the gui client, I ... Sergey Ivanovskiy
05:31 AM Bug #3075: The window icon popup menu isn't displayed if a user clicks on the window icon by the ...: Sergey, about 3084a rev 11029:
# for the title-bar popup: for embedded mode, no decorations are shown, so there will... Constantin Asofiei

05/11/2016

06:13 PM Bug #2923: ./combo_box/combo_box9_1.p web combobox width is not enough to display its content wit...: Sergey Ivanovskiy wrote:
>
> No, it adds additional parameters to the gui client, I need to deliver additional par... Eugenie Lyzenko
05:34 PM Bug #2923: ./combo_box/combo_box9_1.p web combobox width is not enough to display its content wit...: Eugenie Lyzenko wrote:
> Greg Shah wrote:
> >
> > I can't properly evaluate the Combo-Box changes. Eugenie: please ... Sergey Ivanovskiy
05:23 PM Bug #2923: ./combo_box/combo_box9_1.p web combobox width is not enough to display its content wit...: Greg Shah wrote:
>
> I can't properly evaluate the Combo-Box changes. Eugenie: please review 11025 in 3084a.
N... Eugenie Lyzenko
04:23 PM Bug #2923: ./combo_box/combo_box9_1.p web combobox width is not enough to display its content wit...: Code Review Task Branch 3084a Revision 11025 (was 11019)
One thing that seems wrong is the direct reference to @Co... Greg Shah
04:42 PM Bug #3075: The window icon popup menu isn't displayed if a user clicks on the window icon by the ...: The changes are fine with me.
Constantin: any concerns? Greg Shah
08:56 AM Bug #3062: COMBO-BOX steals focus when its drop-down active: 3062a revision 11032 resolves all the issues. The branch has passed GUI regression testing, ChUI regression testing i... Hynek Cihlar
08:10 AM Bug #3106: Various GUI COMBO-BOX issues: Another issue, in @combo_box/combo_box11.p@ the combo drop-down won't activate on Alt+Down. Hynek Cihlar

05/10/2016

06:22 PM Bug #3106: Various GUI COMBO-BOX issues: All the issues above can be reproduced in current trunk, in GUI mode. Hynek Cihlar
06:21 PM Bug #3106: Various GUI COMBO-BOX issues: combo_box/combo_box10_1.p shows blank rectangle instead of the SIMPLE list.
Clicking on an item in the combo simpl... Hynek Cihlar
06:18 PM Bug #3106 (New): Various GUI COMBO-BOX issues: Hynek Cihlar

05/09/2016

05:27 PM Bug #2857: font differences for toggle box and menu: > Should I create a separate task for this or work here?
These all seem easy to fix, right? Some of these seem li... Greg Shah

05/07/2016

04:12 AM Bug #3062: COMBO-BOX steals focus when its drop-down active: Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > I see three solutions: (1) make sure the driver sends the event... Hynek Cihlar
03:22 AM Bug #3062: COMBO-BOX steals focus when its drop-down active: Hynek Cihlar wrote:
> I see three solutions: (1) make sure the driver sends the events in correct and guaranteed ord... Constantin Asofiei

05/06/2016

05:52 PM Bug #3062: COMBO-BOX steals focus when its drop-down active: 3062a revision 11028 resolves all the issues of this issue plus #3071 except one:
Combo drop-down would not open ... Hynek Cihlar
11:46 AM Bug #3101: minimizing a web window results that the java web client process throws exceptions: Greg, please review these changes against P2j that fixes the issue. Sergey Ivanovskiy
10:52 AM Bug #3101: minimizing a web window results that the java web client process throws exceptions: The java web client's process throws these exceptions if we minimize a target web window:... Sergey Ivanovskiy
10:48 AM Bug #3101 (Closed): minimizing a web window results that the java web client process throws excep...: Sergey Ivanovskiy
01:14 AM Bug #3075: The window icon popup menu isn't displayed if a user clicks on the window icon by the ...: The issue is fixed in #3080 (task branch 3084a). Sergey Ivanovskiy
09:15 PM Bug #2857: font differences for toggle box and menu: I've found not implemented menu behavior related to empty labels for CHUI.
# If label for menu-item or sub-menu is... Vadim Gindin

05/05/2016

12:35 PM Bug #2857: font differences for toggle box and menu: The branch is rebased to current trunk revision. Current branch revision is 11029. Vadim Gindin
12:14 PM Bug #2923: ./combo_box/combo_box9_1.p web combobox width is not enough to display its content wit...: Greg, Constantin please review the proposed fix (rev 11028 ) branch 3084a Sergey Ivanovskiy
12:08 PM Bug #3062: COMBO-BOX steals focus when its drop-down active: 3062a rebased against trunk 11023, now at 11025. Hynek Cihlar
11:51 AM Bug #2787 (Closed): implement mnemonics/accelerator key support for button: Greg Shah
11:47 AM Bug #2787: implement mnemonics/accelerator key support for button: I've created the stask #3099 for the bug from the note 70. Vadim Gindin
11:38 AM Bug #2787: implement mnemonics/accelerator key support for button: The branch 2787a is rebased and merged to trunk as revision 11023. Vadim Gindin
07:44 AM Bug #2787: implement mnemonics/accelerator key support for button: Eugenie is going to merge 2738a into the trunk next. As soon as you see his notification, please rebase and then mer... Greg Shah
07:43 AM Bug #2787: implement mnemonics/accelerator key support for button: OK, please create a new task for ChUI frame issue. Make me a watcher. The task should NOT be a sub-task of #2677. Greg Shah
01:20 AM Bug #2787: implement mnemonics/accelerator key support for button: Greg Shah wrote:
> > Is it a known bug, should I create a task for it?
>
> Does this same bug happen in the P2J t... Vadim Gindin
11:45 AM Bug #3099: Frame layout error in ChUI: The failure test is @button-highlight.p@. Frames look differently.
PROGRESS (lindev01):... Vadim Gindin
11:44 AM Bug #3099 (New): Frame layout error in ChUI: Vadim Gindin
08:32 AM Bug #3093: widget-pool resources need to be pre-ordered when deleted (to enforce parent/child rel...: I've created branch 3093a from trunk rev 11022. Rev 11023 fixes the close button issue in task #2898, but the fix is... Constantin Asofiei

05/04/2016

03:44 PM Bug #2787: implement mnemonics/accelerator key support for button: Code Review Task Branch 2787a Revision 11033
I'm fine with the changes. Please answer the question in note 71 bef... Greg Shah
03:39 PM Bug #2787: implement mnemonics/accelerator key support for button: > Is it a known bug, should I create a task for it?
Does this same bug happen in the P2J trunk revision 11021? Greg Shah
03:03 PM Bug #2787: implement mnemonics/accelerator key support for button: Frames look differently (button-highlight.p):
PROGRESS (lindev01):... Vadim Gindin
02:57 PM Bug #2787: implement mnemonics/accelerator key support for button: I've ran these tests. Buttons are drawn correctly in both of them. Vadim Gindin
12:50 PM Bug #2787: implement mnemonics/accelerator key support for button: Vadim: please run the tests listed in note 67 and report the results here. Greg Shah
12:48 PM Bug #2787: implement mnemonics/accelerator key support for button: Greg Shah wrote:
> Eugenie: please post a list of tests that should be checked.
The one test can be @button-highl... Eugenie Lyzenko
12:10 PM Bug #2787: implement mnemonics/accelerator key support for button: Eugenie: please post a list of tests that should be checked. Greg Shah
11:44 AM Bug #2787: implement mnemonics/accelerator key support for button: I'm OK with changes.
However I would like to note the regression testing will NOT detect button underscore missing... Eugenie Lyzenko
06:05 AM Bug #2787: implement mnemonics/accelerator key support for button: Thanks, Hynek! It means that this bug is fixed there.
So I've tested standalone GUI tests. All is OK. Vadim Gindin
04:09 AM Bug #2787: implement mnemonics/accelerator key support for button: Vadim Gindin wrote:
> Greg Shah wrote:
> > Code Review Task Branch 2787a Revision 11025
> >
> > 1. The branch ne... Hynek Cihlar
02:55 AM Bug #2787: implement mnemonics/accelerator key support for button: Greg Shah wrote:
> Code Review Task Branch 2787a Revision 11025
>
> 1. The branch needs to be rebased.
>
> 2. ... Vadim Gindin
11:26 AM Bug #3096: Mnemonics highlighting for buttons in GUI: More: if I have 2 dynamic windows created at start time, i.e. one of them is active and one of them is inactive, beha... Vadim Gindin
11:20 AM Bug #3096: Mnemonics highlighting for buttons in GUI: Greg Shah wrote:
> Did you test this using the "procedure editor"? That would explain your results, since state can... Vadim Gindin
11:17 AM Bug #3096: Mnemonics highlighting for buttons in GUI: Did you test this using the "procedure editor"? That would explain your results, since state can be left around.
... Greg Shah
11:14 AM Bug #3096: Mnemonics highlighting for buttons in GUI: This task is about implementation of logic that shows/hides mnemonics for buttons in GUI.
_Proposal_. Behaviour is... Vadim Gindin
10:56 AM Bug #3096 (New): Mnemonics highlighting for buttons in GUI: Vadim Gindin

05/03/2016

12:25 PM Bug #3062: COMBO-BOX steals focus when its drop-down active: Hynek Cihlar wrote:
> Constantin Asofiei wrote:
> > Hynek Cihlar wrote:
> > Also, I'm wondering if this is not rel... Hynek Cihlar
11:10 AM Bug #3062: COMBO-BOX steals focus when its drop-down active: Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > > Who transfers the focus back to the combo-box? The combo's o... Hynek Cihlar
10:59 AM Bug #3062: COMBO-BOX steals focus when its drop-down active: Hynek Cihlar wrote:
> > Who transfers the focus back to the combo-box? The combo's own 'synthetic' wait-for loop or... Constantin Asofiei
10:40 AM Bug #3062: COMBO-BOX steals focus when its drop-down active: Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > Here's the workflow that does not produce expected result:
> >... Hynek Cihlar
10:30 AM Bug #3062: COMBO-BOX steals focus when its drop-down active: Hynek Cihlar wrote:
> Here's the workflow that does not produce expected result:
> * User clicks in the COMBO-BOX.
... Constantin Asofiei
08:47 AM Bug #3062: COMBO-BOX steals focus when its drop-down active: One of the causes of this issue is the way combo drop-down @waitForWorker()@ loop is interrupted and subsequently foc... Hynek Cihlar
05:34 AM Bug #3062 (WIP): COMBO-BOX steals focus when its drop-down active: Hynek Cihlar
10:12 AM Bug #2809: implement missing behaviour related to HIDDEN attribute: Another issue of interest, to check: how setting the HIDDEN/VISIBLE attribute for a WINDOW affects the containing fra... Constantin Asofiei
10:06 AM Bug #3093: widget-pool resources need to be pre-ordered when deleted (to enforce parent/child rel...: In the end, the issue is not related to widget-pools. Is related to how dynamic windows or frames get deleted:
# if... Constantin Asofiei

05/02/2016

04:29 PM Bug #2770: alert-box visual differences: 2770b merged to trunk as revision 11020. The branch was archived. Hynek Cihlar
04:02 PM Bug #2770: alert-box visual differences: Code Review Task Branch 2770b Revision 11025
I'm fine with the changes.
Please merge to trunk. Greg Shah
10:29 AM Bug #2770: alert-box visual differences: 2770b revision 11025 resolves regressions introduced by 2770a, fixes selection of next active window when modal windo... Hynek Cihlar
06:57 AM Bug #2770: alert-box visual differences: 2770a rebased against trunk 11019, the branch is now at rev 11022. Hynek Cihlar
03:42 PM Bug #2787: implement mnemonics/accelerator key support for button: Eugenie: please do a code review. Greg Shah
03:42 PM Bug #2787: implement mnemonics/accelerator key support for button: > The only question left is the question about "Key mode" for buttons in Windows. In most cases mnemonics are shown r... Greg Shah
03:41 PM Bug #2787: implement mnemonics/accelerator key support for button: Did you test all the standalone GUI cases? Greg Shah
03:40 PM Bug #2787: implement mnemonics/accelerator key support for button: Code Review Task Branch 2787a Revision 11025
1. The branch needs to be rebased.
2. The @MenuItemGuiImpl.createD... Greg Shah
09:40 AM Bug #2923: ./combo_box/combo_box9_1.p web combobox width is not enough to display its content wit...: Please review the committed revision 11019. It fixed @drawTextBoxAlligned@. Sergey Ivanovskiy
09:16 AM Bug #2923: ./combo_box/combo_box9_1.p web combobox width is not enough to display its content wit...: Constantin Asofiei wrote:
> Sergey Ivanovskiy wrote:
> > Thanks, is it an automate process to collect all strings use... Sergey Ivanovskiy

05/01/2016

03:46 PM Bug #2787: implement mnemonics/accelerator key support for button: I'm ready to commit.
The only question left is the question about "Key mode" for buttons in Windows. In most cases... Vadim Gindin
03:35 PM Bug #2787: implement mnemonics/accelerator key support for button: The changes passed regression testing. Vadim Gindin

04/30/2016

06:11 AM Bug #2770: alert-box visual differences: Code Review Task Branch 2770b Revision 11019
The changes are fine. Greg Shah

04/29/2016

04:09 PM Bug #2770: alert-box visual differences: 2770b revision 11019 fixes main window border being drawn even when the driver doesn't support window decorations. Pl... Hynek Cihlar
03:09 PM Bug #2770: alert-box visual differences: Code Review Task Branch 2770b Revision 11018
The changes are fine.
Please add the embedded mode fix to this bra... Greg Shah
02:59 PM Bug #2770: alert-box visual differences: Please review task branch 2770b revision 11018, it fixes GUI regressions caused by assigning widget IDs to all @Borde... Hynek Cihlar
01:25 PM Bug #2770 (Closed): alert-box visual differences: Greg Shah
01:21 PM Bug #2770 (WIP): alert-box visual differences: Hynek Cihlar
01:20 PM Bug #2770: alert-box visual differences: 2770a merged to trunk as revision 11017. The branch has been archived. Hynek Cihlar
09:53 AM Bug #2770: alert-box visual differences: Please merge 2770a to trunk. Greg Shah
02:11 AM Bug #2770: alert-box visual differences: Eugenie Lyzenko wrote:
> >Eugenie, please review 2770a revision 11025. It contains changes related to the subject ab... Hynek Cihlar
02:06 AM Bug #2770: alert-box visual differences: Greg Shah wrote:
> Code Review Task Branch 2770a Revision 11025
>
> I'm generally fine with the changes.
>
> 1... Hynek Cihlar
01:42 PM Bug #3093 (WIP): widget-pool resources need to be pre-ordered when deleted (to enforce parent/chi...: I think a similar issue exists if the @hw@ and @hf@ handles are deleted before the @delete widget-pool@ statement - @... Constantin Asofiei
01:40 PM Bug #3093: widget-pool resources need to be pre-ordered when deleted (to enforce parent/child rel...: In case of widgets added to widget-pools, the order needs to be deterministic: if the entire UI tree is added in a wi... Constantin Asofiei
01:35 PM Bug #3093 (WIP): widget-pool resources need to be pre-ordered when deleted (to enforce parent/chi...: Constantin Asofiei
01:25 PM Bug #3067 (Closed): Swing GUI window resize cursor fuzzy: Greg Shah
01:22 PM Bug #3067: Swing GUI window resize cursor fuzzy: This issue has been fixed by #2770. Hynek Cihlar
12:04 PM Bug #2923: ./combo_box/combo_box9_1.p web combobox width is not enough to display its content wit...: Sergey Ivanovskiy wrote:
> Thanks, is it an automate process to collect all strings used by application in @lines-li... Constantin Asofiei
11:55 AM Bug #2923: ./combo_box/combo_box9_1.p web combobox width is not enough to display its content wit...: Thanks, is it an automate process to collect all strings used by application in @lines-list.txt@ and then to run @./f... Sergey Ivanovskiy
11:35 AM Bug #2923: ./combo_box/combo_box9_1.p web combobox width is not enough to display its content wit...: Sergey Ivanovskiy wrote:
> Is font legacy width required for the compatibility with native 4GL application?
Yes
>... Constantin Asofiei
11:22 AM Bug #2923: ./combo_box/combo_box9_1.p web combobox width is not enough to display its content wit...: Constantin Asofiei wrote:
> Sergey, questions for @the legacy font width ... is less than the font width we can get ... Sergey Ivanovskiy
07:32 AM Bug #2923: ./combo_box/combo_box9_1.p web combobox width is not enough to display its content wit...: Hynek Cihlar wrote:
> Hynek Cihlar wrote:
> > Sergey Ivanovskiy wrote:
> > > I am planning to fix it like it is im... Sergey Ivanovskiy
06:01 AM Bug #2923: ./combo_box/combo_box9_1.p web combobox width is not enough to display its content wit...: Hynek Cihlar wrote:
> Sergey Ivanovskiy wrote:
> > I am planning to fix it like it is implemented for @ScrollPaneGuiI... Hynek Cihlar
05:55 AM Bug #2923: ./combo_box/combo_box9_1.p web combobox width is not enough to display its content wit...: Sergey Ivanovskiy wrote:
> I am planning to fix it like it is implemented for @ScrollPaneGuiImpl@.
Sounds good.
Hynek Cihlar
05:55 AM Bug #2923: ./combo_box/combo_box9_1.p web combobox width is not enough to display its content wit...: Sergey Ivanovskiy wrote:
> Hynek Cihlar wrote:
> > Sergey Ivanovskiy wrote:
> > > Found that the legacy font width... Hynek Cihlar
05:40 AM Bug #2923: ./combo_box/combo_box9_1.p web combobox width is not enough to display its content wit...: I am planning to fix it like it is implemented for @ScrollPaneGuiImpl@. The below code is from @DropDown@... Sergey Ivanovskiy
05:15 AM Bug #2923: ./combo_box/combo_box9_1.p web combobox width is not enough to display its content wit...: Hynek Cihlar wrote:
> Sergey Ivanovskiy wrote:
> > Found that the legacy font width used to draw the combobox's ent... Sergey Ivanovskiy
04:02 AM Bug #2923: ./combo_box/combo_box9_1.p web combobox width is not enough to display its content wit...: Sergey Ivanovskiy wrote:
> Found that the legacy font width used to draw the combobox's entry field and its drop dow... Hynek Cihlar
03:12 AM Bug #2923: ./combo_box/combo_box9_1.p web combobox width is not enough to display its content wit...: Constantin Asofiei wrote:
> Sergey Ivanovskiy wrote:
> > It makes impossible to use their @GuiFontResolver@ if we a... Sergey Ivanovskiy
02:53 AM Bug #2923: ./combo_box/combo_box9_1.p web combobox width is not enough to display its content wit...: Sergey Ivanovskiy wrote:
> It makes impossible to use their @GuiFontResolver@ if we are in the batch drawing of the ... Constantin Asofiei
02:50 AM Bug #2923: ./combo_box/combo_box9_1.p web combobox width is not enough to display its content wit...: Constantin Asofiei wrote:
> Sergey, questions for @the legacy font width ... is less than the font width we can get ... Sergey Ivanovskiy
02:29 AM Bug #2923: ./combo_box/combo_box9_1.p web combobox width is not enough to display its content wit...: Sergey, questions for @the legacy font width ... is less than the font width we can get from the web driver.@:
# do ... Constantin Asofiei
01:29 AM Bug #2923: ./combo_box/combo_box9_1.p web combobox width is not enough to display its content wit...: Don't know to whom address this question, who can help to answer it? Sergey Ivanovskiy
01:26 AM Bug #2923: ./combo_box/combo_box9_1.p web combobox width is not enough to display its content wit...: Found that the legacy font width used to draw the combobox's entry field and its drop down list by @ComboBoxGuiImpl@ ... Sergey Ivanovskiy
09:51 AM Bug #3073: Combo-box bug: widget is not in the container: Vadim: can you recreate this on the current trunk? Greg Shah
04:33 AM Bug #3073: Combo-box bug: widget is not in the container: Could not reproduce the issue. I have tried several tests with combo boxes, including the above mentioned @demo/demo_... Hynek Cihlar
04:08 AM Bug #3073 (WIP): Combo-box bug: widget is not in the container: Hynek Cihlar
01:28 AM Bug #2787: implement mnemonics/accelerator key support for button: In most cases mnemonics are shown right after start (GUI), but I met some time that mnemonics are not shown by defaul... Vadim Gindin

04/28/2016

05:15 PM Bug #2770: alert-box visual differences: >Eugenie, please review 2770a revision 11025. It contains changes related to the subject above.
Three considerations... Eugenie Lyzenko
04:32 PM Bug #2770: alert-box visual differences: Code Review Task Branch 2770a Revision 11025
I'm generally fine with the changes.
1. In @WindowBorder@, please ... Greg Shah
03:46 PM Bug #2770: alert-box visual differences: 2770a 11025 also resolves #3067. Hynek Cihlar
03:44 PM Bug #2770: alert-box visual differences: Eugenie Lyzenko wrote:
> The better way if the image size is constant I guess is to use simple bitmap. And no @BATIK... Hynek Cihlar
03:43 PM Bug #2770: alert-box visual differences: Greg Shah wrote:
> Is this ready for code review?
Revision 11025 is. Hynek Cihlar
03:43 PM Bug #2770: alert-box visual differences: Please review 2770a revision 11025.
The revision resolves the ALERT-BOX layout issues mentioned in the above note... Hynek Cihlar
03:34 PM Bug #2770: alert-box visual differences: Is this ready for code review? Greg Shah
03:33 PM Bug #2770: alert-box visual differences: 2770a rebased against trunk 11016, the branch is now at rev 11024. Hynek Cihlar

04/24/2016

05:11 PM Bug #2770: alert-box visual differences: Hynek Cihlar wrote:
> Eugenie, when I rasterize alert-box icon using @SharpPNGTranscoder@ I get a very distorted out... Eugenie Lyzenko
03:29 PM Bug #2770: alert-box visual differences: Eugenie, when I rasterize alert-box icon using @SharpPNGTranscoder@ I get a very distorted output. But if I use the u... Hynek Cihlar
05:28 AM Bug #2918: frame title active state difference for frames without focusable widgets: 2918a rebased against trunk rev 11008. Also I fixed two regressions in the branch - an NPE in GUI alert-box and wrong... Hynek Cihlar

04/23/2016

01:20 AM Bug #2918: frame title active state difference for frames without focusable widgets: This time 2918a ChUI testing hang in Ctrl-C part. Testing restarted. Hynek Cihlar

04/22/2016

04:18 PM Bug #3021: MESSAGE with SET clause works incorrectly: 3021a archived as dead. Hynek Cihlar
04:08 PM Bug #3021 (Closed): MESSAGE with SET clause works incorrectly: Greg Shah
03:58 PM Bug #3021: MESSAGE with SET clause works incorrectly: 3021a merged to 1811u revision 11027. Hynek Cihlar
09:53 AM Bug #3021: MESSAGE with SET clause works incorrectly: Please merge 3021a into 1811u. Greg Shah
04:03 PM Bug #2918: frame title active state difference for frames without focusable widgets: ChUI regression testing finished again with many false negatives, restarted. Hynek Cihlar
10:06 AM Bug #2918: frame title active state difference for frames without focusable widgets: Greg Shah wrote:
> How is testing coming along?
>
> I expect to be ready for 1811u to go into testing soon, but w... Hynek Cihlar
09:52 AM Bug #2918: frame title active state difference for frames without focusable widgets: How is testing coming along?
I expect to be ready for 1811u to go into testing soon, but we are waiting on 2918a. Greg Shah
03:54 PM Bug #3069: The maximize/restore action for the web client doesn't work properly: Committed rev 11026. Added the summary diff of the effective changes from 11024 to 11026. Sergey Ivanovskiy
03:39 PM Bug #3069: The maximize/restore action for the web client doesn't work properly: I would like to cleanup this fix, because found that the @magic@ byte array can be @static@ and resizeOps can have ty... Sergey Ivanovskiy
03:32 PM Bug #3069: The maximize/restore action for the web client doesn't work properly: Greg, Constantin please review the committed revision 11025. This fix is improved. Now the batch of drawing operation... Sergey Ivanovskiy
03:11 PM Bug #3069: The maximize/restore action for the web client doesn't work properly: Sergey Ivanovskiy wrote:
> Do you mean if the resize operation is inside the batch message, then don't cache it. I t... Constantin Asofiei
03:00 PM Bug #3069: The maximize/restore action for the web client doesn't work properly: Constantin Asofiei wrote:
> Sergey Ivanovskiy wrote:
> > Constantin, I don't try it, because the resize operations ... Sergey Ivanovskiy
02:55 PM Bug #3069: The maximize/restore action for the web client doesn't work properly: Sergey Ivanovskiy wrote:
> Constantin, I don't try it, because the resize operations are performed on canvas object,... Constantin Asofiei
02:51 PM Bug #3069: The maximize/restore action for the web client doesn't work properly: Constantin, I don't try it, because the resize operations are performed on canvas object, but all cached drawings are... Sergey Ivanovskiy
02:47 PM Bug #3069: The maximize/restore action for the web client doesn't work properly: Constantin Asofiei wrote:
> Why wouldn't including into the md5 hash the window's size (as reported, in pixels, by i... Constantin Asofiei
02:47 PM Bug #3069: The maximize/restore action for the web client doesn't work properly: What about my idea in note 9? Why wouldn't including into the md5 hash the window's size (as reported, in pixels, by... Constantin Asofiei
02:35 PM Bug #3069: The maximize/restore action for the web client doesn't work properly: Constantin Asofiei wrote:
> Sergey Ivanovskiy wrote:
> > Please review the committed revision 11024. Utilizes the r... Sergey Ivanovskiy
02:00 PM Bug #3069: The maximize/restore action for the web client doesn't work properly: Sergey Ivanovskiy wrote:
> Please review the committed revision 11024. Utilizes the root cause that we mustn't cache... Constantin Asofiei
01:28 PM Bug #3069: The maximize/restore action for the web client doesn't work properly: Code Review Task Branch 1811u Revision 11024
I'm fine with the changes.
Constantin: do you have any concerns? Greg Shah
01:06 PM Bug #3069: The maximize/restore action for the web client doesn't work properly: Please review the committed revision 11024. Utilizes the root cause that we mustn't cache the resize operations. Sergey Ivanovskiy
09:05 AM Bug #2787: implement mnemonics/accelerator key support for button: Vadim Gindin wrote:
> Here is the test:
> [...]
Your test doesn't match how serv21.p works: the overlay frame is s... Constantin Asofiei
08:29 AM Bug #2770: alert-box visual differences: Greg Shah wrote:
> Sorry, my mistake too, I also meant windev01. :)
>
> I did not intentionally scale the resolut... Hynek Cihlar
08:01 AM Bug #2770: alert-box visual differences: Sorry, my mistake too, I also meant windev01. :)
I did not intentionally scale the resolution, but it may have hap... Greg Shah
07:46 AM Bug #2770: alert-box visual differences: Hynek Cihlar wrote:
> Greg Shah wrote:
> > When you say devsrv01, did you mean winsrv01?
>
> Yes :-).
Actuall... Hynek Cihlar
07:40 AM Bug #2770: alert-box visual differences: Greg Shah wrote:
> When you say devsrv01, did you mean winsrv01?
Yes :-). Hynek Cihlar
07:37 AM Bug #2770: alert-box visual differences: When you say devsrv01, did you mean winsrv01? Greg Shah
03:56 AM Bug #2770: alert-box visual differences: Greg Shah wrote:
> 3. The icon is too big in P2J.
Greg, I just realized the icon sizes are equal. Your screenshot... Hynek Cihlar

04/21/2016

06:07 PM Bug #3069: The maximize/restore action for the web client doesn't work properly: Checked that if we send the batch of resize drawing operations in case of there is a resize drawing operation, then t... Sergey Ivanovskiy
10:31 AM Bug #3069: The maximize/restore action for the web client doesn't work properly: Sergey Ivanovskiy wrote:
> The problem with cache system is that resize messages are reached @GuiWebDriver@ correctl... Constantin Asofiei
10:24 AM Bug #3069: The maximize/restore action for the web client doesn't work properly: The problem with the drawing cache system is that resize messages are reached @GuiWebDriver@ correctly, but due to th... Sergey Ivanovskiy
04:34 AM Bug #3069: The maximize/restore action for the web client doesn't work properly: The sequence to reproduce:
1) First turn of the p2j.screen module cache to draw without caching, only the p2j.canvas_... Sergey Ivanovskiy
05:08 PM Bug #2787: implement mnemonics/accelerator key support for button: Here is the test:... Vadim Gindin
01:36 PM Bug #2918: frame title active state difference for frames without focusable widgets: Code Review Task Branch 2918a Revision 11012
I'm good with the changes. Greg Shah
01:13 PM Bug #2918: frame title active state difference for frames without focusable widgets: Greg Shah wrote:
> Code Review Task Branch 2918a Revision 11011
>
> Please update the javadoc for @UiUtils.getPar... Hynek Cihlar
12:11 PM Bug #2918: frame title active state difference for frames without focusable widgets: Code Review Task Branch 2918a Revision 11011
Please update the javadoc for @UiUtils.getParentFrames()@ to explain ... Greg Shah
11:52 AM Bug #2918: frame title active state difference for frames without focusable widgets: 2918a revision 11008 resolves the issues from review. It passed GUI regression tests and ChUI regression testing in p... Hynek Cihlar
11:40 AM Bug #2918: frame title active state difference for frames without focusable widgets: 2918a rebased against trunk revision 11007, the branch is now at revision 11010. Hynek Cihlar
08:51 AM Feature #3038: implement browse attrs COLUMN-MOVABLE, COLUMN-RESIZABLE, CREATE-ON-ADD, MIN-HEIGHT...: I've found few more issues related to resizing columns in a browse which has total columns width smaller that the vie... Stanislav Lomany
08:30 AM Feature #3038: implement browse attrs COLUMN-MOVABLE, COLUMN-RESIZABLE, CREATE-ON-ADD, MIN-HEIGHT...: I'd like 3038a to be next to merge to trunk. It should be rebased to trunk 11007 as well. When do you expect that t... Greg Shah
02:30 AM Bug #2988: The web click events on the caption buttons can invoke the resize action.: Now 1811u is from 11006 rev of trunc and is pushed up to revision 11021. Sergey Ivanovskiy
01:52 AM Bug #2988: The web click events on the caption buttons can invoke the resize action.: Planning to rebase to the current P2j trunc. Sergey Ivanovskiy
12:26 AM Bug #2988: The web click events on the caption buttons can invoke the resize action.: Committed revision 11015 has small fixes for misspelled listen event of @MousePopupable@ and incorrectly built event'... Sergey Ivanovskiy
01:50 AM Bug #3075: The window icon popup menu isn't displayed if a user clicks on the window icon by the ...: It is probably not a bug, but why the previous version implements a left mouse popup. The implementation is changed i... Sergey Ivanovskiy
01:43 AM Bug #3075 (Closed): The window icon popup menu isn't displayed if a user clicks on the window ico...: Sergey Ivanovskiy
01:27 AM Bug #3056: Mouse pointer issues for menus: I think it needs to check z-order of the popup menu. The popup menu must be on the top of the widgets in its containe... Sergey Ivanovskiy

04/20/2016

05:49 PM Bug #2988: The web click events on the caption buttons can invoke the resize action.: The current P2j trunc Swing client doesn't open a window icon popup menu that should be opened on the left mouse clic... Sergey Ivanovskiy
05:20 PM Bug #2988: The web click events on the caption buttons can invoke the resize action.: Committed revision 11014 fixed an infinite process to connect to the down java web client. Sergey Ivanovskiy
03:21 PM Bug #2988: The web click events on the caption buttons can invoke the resize action.: Committed revision 11013 rolled back my changes to 11011. It needs to find another solution. The previous commit to u... Sergey Ivanovskiy
11:39 AM Bug #2988: The web click events on the caption buttons can invoke the resize action.: We can use a map of custom html element's ids to their application window's ids in order to fix the usage of @"pwindo... Sergey Ivanovskiy
10:00 AM Bug #2988: The web click events on the caption buttons can invoke the resize action.: Constantin Asofiei wrote:
> Sergey, the changes in 1811u rev 11012 make sense. The only question is this: you are as... Sergey Ivanovskiy
09:47 AM Bug #2988: The web click events on the caption buttons can invoke the resize action.: Sergey, the changes in 1811u rev 11012 make sense. The only question is this: you are assuming the Window's name (i.e... Constantin Asofiei
05:11 AM Bug #2988: The web click events on the caption buttons can invoke the resize action.: Nevermind, I found @MousePopupable@ and the other related classes. Sergey Ivanovskiy
04:23 AM Bug #2988: The web click events on the caption buttons can invoke the resize action.: Vadim, could you help what mouse events are listen by popups? I am doing changes for the web client to dispatch the t... Sergey Ivanovskiy
04:33 PM Bug #3021: MESSAGE with SET clause works incorrectly: Code Review Task Branch 3021a Revision 11006
I'm fine with the changes. Greg Shah
04:24 PM Bug #3021: MESSAGE with SET clause works incorrectly: 3021a revision 11006 contains fix of the fix based on the review. I have tested SET and UPDATE with all data types an... Hynek Cihlar
12:59 PM Bug #3021 (WIP): MESSAGE with SET clause works incorrectly: Greg Shah
03:01 PM Feature #3038: implement browse attrs COLUMN-MOVABLE, COLUMN-RESIZABLE, CREATE-ON-ADD, MIN-HEIGHT...: Browse testcases are ok, and I didn't find any scrolling issues with other testcases.
I found one thing that is miss... Stanislav Lomany
12:20 PM Feature #3038: implement browse attrs COLUMN-MOVABLE, COLUMN-RESIZABLE, CREATE-ON-ADD, MIN-HEIGHT...: For the GUI testing, only test code with browse and some common widgets that are affected by the scroll changes. Greg Shah
12:18 PM Feature #3038: implement browse attrs COLUMN-MOVABLE, COLUMN-RESIZABLE, CREATE-ON-ADD, MIN-HEIGHT...: Code Review Task Branch 3038a Revision 110011
This is really good. I see that @ClientBrowseModel@ needs a copyrig... Greg Shah
01:06 PM Bug #2918: frame title active state difference for frames without focusable widgets: Code Review Task Branch 2918a Revision 11005
I'm fine with the changes. Some minor comments:
1. In @UiUtils@, ... Greg Shah
12:55 PM Bug #2918: frame title active state difference for frames without focusable widgets: The issue is fixed in task branch 2918a revision 11005. The changes depend on 2823a, rebase is pending. Hynek Cihlar
11:51 AM Bug #3073: Combo-box bug: widget is not in the container: Here is the stack of this error met in trunk:... Vadim Gindin
11:43 AM Bug #3073 (Closed): Combo-box bug: widget is not in the container: Vadim Gindin
10:16 AM Bug #2915: A modal window in Swing GUI client should not be on top of all other OS windows: Greg Shah wrote:
> Yes, please do.
Done. 2915a was archived to dead. Hynek Cihlar
10:14 AM Bug #2915: A modal window in Swing GUI client should not be on top of all other OS windows: Yes, please do. Greg Shah
10:13 AM Bug #2915: A modal window in Swing GUI client should not be on top of all other OS windows: Greg Shah wrote:
> Archive it to "dead" instead of the default. The default archive is for things that have already... Hynek Cihlar
09:27 AM Bug #2915: A modal window in Swing GUI client should not be on top of all other OS windows: Archive it to "dead" instead of the default. The default archive is for things that have already been merged. Greg Shah
08:56 AM Bug #2915: A modal window in Swing GUI client should not be on top of all other OS windows: Hynek Cihlar wrote:
> I have archived task branch 2915a.
Actually I am not sure archiving the branch is the corre... Hynek Cihlar
08:54 AM Bug #2915: A modal window in Swing GUI client should not be on top of all other OS windows: I have archived task branch 2915a. Hynek Cihlar
08:53 AM Bug #2915: A modal window in Swing GUI client should not be on top of all other OS windows: Steps to reproduce the issue.
# In Swing GUI client, run a test 4GL program that opens an @ALERT-BOX@.
# Drag a n... Hynek Cihlar
08:23 AM Bug #2915: A modal window in Swing GUI client should not be on top of all other OS windows: I think we need to pause work on this. Since it only affects the swing client, it is lower priority for the current ... Greg Shah

« Previous

Also available in: Atom

Project

General

Profile

FWD » Core Development » User Interface

Activity

Activity

05/19/2016

05/18/2016

05/17/2016

05/16/2016

05/15/2016

05/13/2016

05/12/2016

05/11/2016

05/10/2016

05/09/2016

05/07/2016

05/06/2016

05/05/2016

05/04/2016

05/03/2016

05/02/2016

05/01/2016

04/30/2016

04/29/2016

04/28/2016

04/27/2016

04/26/2016

04/25/2016

04/24/2016

04/23/2016

04/22/2016

04/21/2016

04/20/2016