Project

General

Profile

Activity

From 11/02/2016 to 12/01/2016

11/28/2016

03:22 PM Bug #2165: Handling "color skip" phrase produces incorrect color attribute selection
Consider the following code:... Greg Shah

11/18/2016

08:37 AM Bug #3212: OS inconsistency related to SET ... VALIDATE construct
OK, just make that clear. Greg Shah
07:37 AM Bug #3212: OS inconsistency related to SET ... VALIDATE construct
Greg Shah wrote:
> I'm OK with this. Since it works in most places and _only fails at compile time_ on 9.x in Linux...
Constantin Asofiei
07:33 AM Bug #3212: OS inconsistency related to SET ... VALIDATE construct
I'm OK with this. Since it works in most places and _only fails at compile time_ on 9.x in Linux, I think your appro... Greg Shah
06:02 AM Bug #3212: OS inconsistency related to SET ... VALIDATE construct
At the moment when the @validate@ was implemented/fixed, the only test machine for P4GL was a 9.X on Linux. Later on,... Ovidiu Maxiniuc
04:21 AM Bug #3212 (Closed): OS inconsistency related to SET ... VALIDATE construct
Ovidiu Maxiniuc

11/16/2016

02:37 PM Bug #2557: Fix MENUBAR layouting in a window
The problem is when we throw @StopConditionException@ - the program is restarted and throw it again and so on infinit... Vadim Gindin
09:49 AM Bug #2557: Fix MENUBAR layouting in a window
Hynek Cihlar wrote:
> Greg Shah wrote:
> > > The frame's hide/show is a consequence of the program restart.
> >
...
Vadim Gindin
07:59 AM Bug #2557: Fix MENUBAR layouting in a window
Greg Shah wrote:
> > The frame's hide/show is a consequence of the program restart.
>
> If the frame is missing a...
Hynek Cihlar
07:50 AM Bug #2557: Fix MENUBAR layouting in a window
To determine the condition that is raised, you can wrap the WAIT-FOR like this:... Greg Shah
05:19 AM Bug #2557: Fix MENUBAR layouting in a window
Vadim Gindin wrote:
> Hynek Cihlar wrote:
> > Vadim Gindin wrote:
> > > What conclusion do you think it means?
> ...
Hynek Cihlar
05:14 AM Bug #2557: Fix MENUBAR layouting in a window
Hynek Cihlar wrote:
> Vadim Gindin wrote:
> > What conclusion do you think it means?
>
> It shows that the @WAIT...
Vadim Gindin
05:11 AM Bug #2557: Fix MENUBAR layouting in a window
Vadim Gindin wrote:
> What conclusion do you think it means?
It shows that the @WAIT-FOR@ abort behavior may depe...
Hynek Cihlar
05:04 AM Bug #2557: Fix MENUBAR layouting in a window
What conclusion do you think it means? Vadim Gindin
04:07 AM Bug #2557: Fix MENUBAR layouting in a window
Vadim Gindin wrote:
> Yes, the frame appears and when I press some key it disappears and the WARNING is shown.. When...
Hynek Cihlar
10:51 PM Bug #2557: Fix MENUBAR layouting in a window
Greg Shah wrote:
> > Did you comment the line: ASSIGN current-window:menubar?
>
> I haven't had time to try this ...
Vadim Gindin

11/15/2016

03:39 PM Bug #2557: Fix MENUBAR layouting in a window
> Did you comment the line: ASSIGN current-window:menubar?
I haven't had time to try this myself, I am busy with o...
Greg Shah
02:30 PM Bug #2557: Fix MENUBAR layouting in a window
Greg Shah wrote:
> > At this moment when we process VIEW frame f or ENABLE frame f we show the window if it hidden (...
Vadim Gindin
02:01 PM Bug #2557: Fix MENUBAR layouting in a window
> At this moment when we process VIEW frame f or ENABLE frame f we show the window if it hidden (if I'm right). But n... Greg Shah
01:05 PM Bug #2557: Fix MENUBAR layouting in a window
I forgot to add.. I should start with that: when I'm running the test from the note 69 (ASSIGN is commented) in P2J: ... Vadim Gindin
12:59 PM Bug #2557: Fix MENUBAR layouting in a window
Greg Shah wrote:
> > There is one problem: frame is already displayed at the moment of wait-for processing, but if w...
Vadim Gindin
11:44 AM Bug #2557: Fix MENUBAR layouting in a window
> There is one problem: frame is already displayed at the moment of wait-for processing, but if we're going to show t... Greg Shah
05:10 AM Bug #2557: Fix MENUBAR layouting in a window
Vadim Gindin wrote:
> # There is one problem: frame is already displayed at the moment of wait-for processing, but i...
Vadim Gindin

11/14/2016

06:41 AM Bug #2557: Fix MENUBAR layouting in a window
# There is one problem: frame is already displayed at the moment of wait-for processing, but if we're going to show t... Vadim Gindin

11/10/2016

09:42 AM Bug #2557: Fix MENUBAR layouting in a window
Greg, Hynek.
I agree with that.
I've checked noted points superficially:
> Wnhat if MENU is attached to som...
Vadim Gindin
09:26 AM Bug #2557: Fix MENUBAR layouting in a window
Vadim Gindin wrote:
>
> In other words, window (got by wait-for widget) must be realized at the moment of wait-for...
Hynek Cihlar
09:24 AM Bug #2557: Fix MENUBAR layouting in a window
Vadim Gindin wrote:
> Hynek Cihlar wrote:
> > Greg Shah wrote:
> > > Vadim Gindin wrote:
> > > > Hynek Cihlar wro...
Vadim Gindin
09:17 AM Bug #2557: Fix MENUBAR layouting in a window
Hynek Cihlar wrote:
> Greg Shah wrote:
> > Vadim Gindin wrote:
> > > Hynek Cihlar wrote:
> > >
> > > > When yo...
Vadim Gindin
09:14 AM Bug #2557: Fix MENUBAR layouting in a window
Greg Shah wrote:
> Vadim Gindin wrote:
> > Hynek Cihlar wrote:
> >
> > > When you comment out the MESSAGE state...
Hynek Cihlar
09:05 AM Bug #2557: Fix MENUBAR layouting in a window
Vadim Gindin wrote:
> Hynek Cihlar wrote:
>
> > When you comment out the MESSAGE statement the window will not g...
Greg Shah
09:04 AM Bug #2557: Fix MENUBAR layouting in a window
Vadim Gindin wrote:
> Hynek Cihlar wrote:
>
> > When you comment out the MESSAGE statement the window will not g...
Hynek Cihlar
09:02 AM Bug #2557: Fix MENUBAR layouting in a window
> And If we comment line @assign current-window:menubar = menu mbar:handle@ PROGRESS will show the WARNING.
This r...
Greg Shah
08:57 AM Bug #2557: Fix MENUBAR layouting in a window
Hynek Cihlar wrote:

> When you comment out the MESSAGE statement the window will not get displayed, this will mak...
Vadim Gindin
08:53 AM Bug #2557: Fix MENUBAR layouting in a window
Vadim Gindin wrote:
> Greg Shah wrote:
> > > Menus are "enabled" by default.
> >
> > I'm asking so I understand ...
Hynek Cihlar
08:47 AM Bug #2557: Fix MENUBAR layouting in a window
Greg Shah wrote:
> Hynek: Does the example in note 69 generate the warning?
For the example in note 69 no warning...
Hynek Cihlar
08:46 AM Bug #2557: Fix MENUBAR layouting in a window
Greg Shah wrote:
> > Yes, we can have a window with menus and without any frames. But see the test from the note 43....
Vadim Gindin
08:35 AM Bug #2557: Fix MENUBAR layouting in a window
> Yes, we can have a window with menus and without any frames. But see the test from the note 43. Comment string MESS... Greg Shah
08:21 AM Bug #2557: Fix MENUBAR layouting in a window
Greg Shah wrote:
> > Menus are "enabled" by default.
>
> I'm asking so I understand the testcases posted here. S...
Vadim Gindin
08:10 AM Bug #2557: Fix MENUBAR layouting in a window
> Menus are "enabled" by default.
I'm asking so I understand the testcases posted here. Since menus are enabled b...
Greg Shah
07:55 AM Bug #2557: Fix MENUBAR layouting in a window
Greg Shah wrote:
> Hynek: Does the example in note 69 generate the warning?
>
> Vadim: Is it true that menus in t...
Vadim Gindin
07:45 AM Bug #2557: Fix MENUBAR layouting in a window
Hynek: Does the example in note 69 generate the warning?
Vadim: Is it true that menus in the 4GL don't need to be ...
Greg Shah
03:54 AM Bug #2557: Fix MENUBAR layouting in a window
Vadim Gindin wrote:
> The implemented case is the following. For CHUI WARNING is not shown. For GUI the WARNING is s...
Hynek Cihlar
12:58 AM Bug #2557: Fix MENUBAR layouting in a window
I've committed missed history entries. Vadim Gindin
12:50 AM Bug #2557: Fix MENUBAR layouting in a window
The implemented case is the following. For CHUI WARNING is not shown. For GUI the WARNING is shown if "waited" menu-i... Vadim Gindin

11/09/2016

04:50 PM Bug #2557: Fix MENUBAR layouting in a window
Greg Shah wrote:
> Can someone please summarize the case that causes the warning?
One case where the warning is...
Hynek Cihlar
04:34 PM Bug #2557: Fix MENUBAR layouting in a window
Can someone please summarize the case that causes the warning? Does it only happen from the procedure editor? Greg Shah
04:00 PM Bug #2557: Fix MENUBAR layouting in a window
Vadim Gindin wrote:
> I've committed the MENU reinitialization fix and rebased the branch. Please review.
Code re...
Hynek Cihlar
02:17 PM Bug #2557: Fix MENUBAR layouting in a window
I've committed the MENU reinitialization fix and rebased the branch. Please review. Vadim Gindin
12:51 PM Bug #2557: Fix MENUBAR layouting in a window
Hynek Cihlar wrote:
> Hynek Cihlar wrote:
> > Vadim Gindin wrote:
> > > P.P.S. Do you insist that we should not re...
Vadim Gindin
09:12 AM Bug #2557: Fix MENUBAR layouting in a window
Hynek Cihlar wrote:
> Vadim Gindin wrote:
> > P.P.S. Do you insist that we should not remove @Menu.destroy()@ metho...
Hynek Cihlar
09:12 AM Bug #2557: Fix MENUBAR layouting in a window
Vadim Gindin wrote:
> P.P.S. Do you insist that we should not remove @Menu.destroy()@ method?
IMHO the @destroy()...
Hynek Cihlar
09:10 AM Bug #2557: Fix MENUBAR layouting in a window
Vadim Gindin wrote:
> Hynek Cihlar wrote:
> > Hynek Cihlar wrote:
> > > Vadim Gindin wrote:
> > > > Hynek, the lo...
Hynek Cihlar
09:03 AM Bug #2557: Fix MENUBAR layouting in a window
> > According to my short testing on windev01, the warning message (1) should be displayed as an error (see attachmen... Vadim Gindin
08:51 AM Bug #2557: Fix MENUBAR layouting in a window
Hynek Cihlar wrote:
> Hynek Cihlar wrote:
> > Vadim Gindin wrote:
> > > Hynek, the logic is approximately the foll...
Vadim Gindin
08:36 AM Bug #2557: Fix MENUBAR layouting in a window
Hynek Cihlar wrote:
> Vadim Gindin wrote:
> > Hynek, the logic is approximately the following.
> >
> > # MENUBA...
Hynek Cihlar
05:39 AM Bug #2557: Fix MENUBAR layouting in a window
Vadim Gindin wrote:
> Hynek, about the bug you found. I've debugged it and found that it is caused by the following....
Hynek Cihlar
05:36 AM Bug #2557: Fix MENUBAR layouting in a window
Vadim Gindin wrote:
> Hynek, the logic is approximately the following.
>
> # MENUBAR is hidden by default becaus...
Hynek Cihlar
02:36 AM Bug #2557: Fix MENUBAR layouting in a window
Hynek, about the bug you found. I've debugged it and found that it is caused by the following.
When the MENUBAR i...
Vadim Gindin
01:21 AM Bug #2557: Fix MENUBAR layouting in a window
Hynek, the logic is approximately the following.
# MENUBAR is hidden by default because of necessity to show WARN...
Vadim Gindin
12:47 AM Bug #2557: Fix MENUBAR layouting in a window
Hynek Cihlar wrote:
> Vadim Gindin wrote:
> > @/menu/gui/mbar_warn.p@
> >
> > [...]
>
> Btw., the test case a...
Vadim Gindin
06:46 AM Feature #2959: Implement search by key in browse
Rebased task branch 2959a from P2J trunk revision 11128. Stanislav Lomany

11/08/2016

04:21 PM Bug #2557: Fix MENUBAR layouting in a window
Vadim Gindin wrote:
> @/menu/gui/mbar_warn.p@
>
> [...]
Btw., the test case abends when a sub-menu is selected...
Hynek Cihlar
04:11 PM Bug #2557: Fix MENUBAR layouting in a window
Vadim Gindin wrote:
> Hynek Cihlar wrote:
> > Hynek Cihlar wrote:
> > > How does this relate to the new method @Th...
Hynek Cihlar
02:43 PM Bug #2557: Fix MENUBAR layouting in a window
Hynek Cihlar wrote:
> Hynek Cihlar wrote:
> > How does this relate to the new method @ThinClient.isMenubarShowNeede...
Vadim Gindin
07:48 AM Bug #2557: Fix MENUBAR layouting in a window
Hynek Cihlar wrote:
> How does this relate to the new method @ThinClient.isMenubarShowNeeded()@? What would be the t...
Hynek Cihlar
07:00 AM Bug #2557: Fix MENUBAR layouting in a window
Vadim Gindin wrote:
> Hynek Cihlar wrote:
> > Vadim Gindin wrote:
> > > @/menu/gui/mbar_warn.p@
> > >
> > > [.....
Hynek Cihlar
11:51 PM Bug #2557: Fix MENUBAR layouting in a window
Hynek Cihlar wrote:
> Vadim Gindin wrote:
> > @/menu/gui/mbar_warn.p@
> >
> > [...]
>
> Vadim, send please al...
Vadim Gindin
07:40 AM Bug #2966 (Closed): NullPointerException is raised when RMB is clicked to show popup menu
Greg Shah
07:13 AM Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
Greg Shah wrote:
> Yes, please merge 2966a to trunk.
>
> There is nothing more to do in this task?
There is no...
Vadim Gindin
06:26 AM Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
Yes, please merge 2966a to trunk.
There is nothing more to do in this task?
Greg Shah
11:56 PM Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
Greg Shah wrote:
> It is difficult to tell, because the state of the database has been edited by the testing.
>
>...
Vadim Gindin

11/07/2016

03:34 PM Bug #2557: Fix MENUBAR layouting in a window
Vadim Gindin wrote:
> @/menu/gui/mbar_warn.p@
>
> [...]
Vadim, send please also the steps to reproduce the issue.
Hynek Cihlar
10:45 AM Bug #2557: Fix MENUBAR layouting in a window
@/menu/gui/mbar_warn.p@... Vadim Gindin
09:50 AM Bug #2557: Fix MENUBAR layouting in a window
Code review 2557a.
MessageAreaGuiImpl.java is missing a history entry.
@Window.afterConfigUpdate()@
I think th...
Hynek Cihlar
09:01 AM Bug #2557: Fix MENUBAR layouting in a window
Please summarize the purpose of the changes in 2557a.
Hynek: please do a code review.
Greg Shah
04:32 AM Bug #2557: Fix MENUBAR layouting in a window
Vadim Gindin wrote:
> Greg Shah wrote:
> > > May be I should add these bugs to that task?
> >
> > No. Please cr...
Vadim Gindin
08:59 AM Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
It is difficult to tell, because the state of the database has been edited by the testing.
Please just run main-re...
Greg Shah
08:57 AM Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
I've ran 238 and 364 in a single mode. 238 has PASSED and 364 has FAILED.... Vadim Gindin
08:39 AM Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
Here are the failed tests: gso_238, gso_364, gso178_session1, gso178_session2. All of them are met first time in this... Vadim Gindin
05:02 AM Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
Vadim Gindin wrote:
> Hynek, I've fixed remarks and reverted WindowManager/AbstractWidget changes. Please review aga...
Hynek Cihlar

11/05/2016

10:19 AM Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
Hynek, I've fixed remarks and reverted WindowManager/AbstractWidget changes. Please review again. I need permission t... Vadim Gindin
09:52 AM Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
Hynek Cihlar wrote:
> Vadim Gindin wrote:
> > After I reverted @WindowManager@ and @AbstractWidget@ I got 4 failed ...
Vadim Gindin

11/04/2016

12:19 PM Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
Greg Shah wrote:
> > Can I make all this changes: create 2966b with WindowManager change and revert it in 2966a?
> ...
Hynek Cihlar
12:16 PM Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
Greg Shah wrote:
> Hynek: how much of that original @WindowManager@ change is still relevant?
All the changes are...
Hynek Cihlar
11:49 AM Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
> Can I make all this changes: create 2966b with WindowManager change and revert it in 2966a?
Actually, I would pr...
Greg Shah
11:48 AM Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
Hynek: how much of that original @WindowManager@ change is still relevant? Greg Shah
07:29 AM Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
Vadim Gindin wrote:
> After I reverted @WindowManager@ and @AbstractWidget@ I got 4 failed test. Have a look at atta...
Hynek Cihlar
07:27 AM Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
Hynek Cihlar wrote:
> Code review 2966a.
>
Also the methods @enableOSEvents()@ and @disableOSEvents()@ in @Wind...
Hynek Cihlar
07:22 AM Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
Code review 2966a.
ThinClient.java
Duplicate file history entry.
Menu.java
* Wrong id in file history entry.
...
Hynek Cihlar
06:39 AM Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
Actually I would run another cycle of runtime regression testing, because the first run was only for main-part. Vadim Gindin
06:11 AM Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
Greg Shah wrote:
> There are no other tests that failed in both runs?
Yes, there are no other tests, that failed ...
Vadim Gindin
05:59 AM Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
Vadim: is the branch prepared for review or are you still using an update zip to remove the @WindowManager@ change? Greg Shah
05:57 AM Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
Hynek: please do a code review of this branch. Greg Shah
05:57 AM Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
The GSO 156 test is one that commonly fails. If you ran it manually and it was OK, then it is fine.
There are no ...
Greg Shah
03:54 AM Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
Anyway in the second test (gso156_session2) there is wrong output:... Vadim Gindin
03:16 AM Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
... Vadim Gindin
01:23 AM Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
Sure, only these tests are failed in both runs. Vadim Gindin

11/03/2016

01:17 PM Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
Did these same tests fail in the previous run? Greg Shah
01:14 PM Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
Here is how the error looks:... Vadim Gindin
01:11 PM Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
Regression testing finished. 2 tests are failed: gso156_session2 and gso156_session1 Vadim Gindin
01:52 AM Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
Hynek Cihlar wrote:
> Greg Shah wrote:
> > > After I reverted @WindowManager@ and @AbstractWidget@ I got 4 failed t...
Vadim Gindin
01:50 AM Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
Greg Shah wrote:
> > After I reverted @WindowManager@ and @AbstractWidget@ I got 4 failed test. Have a look at attac...
Vadim Gindin

11/02/2016

03:48 PM Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
Greg Shah wrote:
> > After I reverted @WindowManager@ and @AbstractWidget@ I got 4 failed test. Have a look at attac...
Hynek Cihlar
02:52 PM Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
> After I reverted @WindowManager@ and @AbstractWidget@ I got 4 failed test. Have a look at attached reverted diff
...
Greg Shah
01:21 PM Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
Greg Shah wrote:
> Use an update zip file like we did before using branches. That zip will be applied over the upda...
Vadim Gindin
06:23 AM Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
Use an update zip file like we did before using branches. That zip will be applied over the updated branch. Greg Shah
06:06 AM Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
I'd tried to some moment add changes to p2j in testcases folder (in testing environment), but during regression-testi... Vadim Gindin
05:53 AM Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
Greg Shah wrote:
> > The errors are the same: "eating" characters during authorization.
>
> I have duplicated thi...
Vadim Gindin
05:18 AM Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
> The errors are the same: "eating" characters during authorization.
I have duplicated this same result. There is...
Greg Shah
01:05 AM Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu
Greg Shah wrote:
> I'm running regression testing in my home dir on devsrv01. This way we can remove your testing e...
Vadim Gindin
 

Also available in: Atom