Project

General

Profile

Activity

From 02/01/2017 to 03/02/2017

03/02/2017

01:56 PM Feature #2683: reverse proxy implementation
Obviously, we can see the current approach to set web socket path is not good.... Sergey Ivanovskiy
01:39 PM Feature #2683: reverse proxy implementation
It doesnt work without this patch rewrite_uri_diff.txt from the note 34 (explanations note 29) and it requires to fix... Sergey Ivanovskiy
01:32 PM Feature #2683: reverse proxy implementation
Ok, planning to investigate a better approach. I used some Google help how to apply html_module that rewrites html li... Sergey Ivanovskiy
11:11 AM Feature #2683: reverse proxy implementation
> Should I continue to get this configuration working properly?
Do you have work to do for #3222? If so, it has t...
Greg Shah
10:41 AM Feature #2683: reverse proxy implementation
Yes, you are correct, I meant explicit mappings. At that moment we consider this schema
1) https://proxy/gui <-> htt...
Sergey Ivanovskiy
10:13 AM Feature #2683: reverse proxy implementation
> does it make sense to support a range of free IP addresses in directory.xml
Yes. That is the idea in #3236.
...
Greg Shah
09:58 AM Feature #2683: reverse proxy implementation
Greg, does it make sense to support a range of free IP addresses in directory.xml. For an example, the web client get... Sergey Ivanovskiy
09:36 AM Feature #2683: reverse proxy implementation
In summary: "It is not yet supported in jetty.". Greg Shah
09:07 AM Feature #2683: reverse proxy implementation
This is an interesting thread about "Support proxies with WebSocketClient" https://github.com/eclipse/jetty.project/i... Sergey Ivanovskiy
07:43 AM Feature #2683: reverse proxy implementation
The problem is that this rule @ProxyPassMatch ^/([0-9]+)/(index\.html.*)$ https://localhost:$1/$2@ can't be validate... Sergey Ivanovskiy
07:11 AM Feature #2683: reverse proxy implementation
Sergey Ivanovskiy wrote:
> Now, I am not sure that it is a good practice to open a forward from @https://127.0.0.1/...
Greg Shah
07:05 AM Feature #2683: reverse proxy implementation
Some thoughts:
1. We don't want to assume that reverse proxy is always being used. We need to support both direct...
Greg Shah
07:01 AM Feature #2683: reverse proxy implementation
Now, I am not sure that it is a good practice to open a forward from @https://127.0.0.1/7449/index.html?token=7f0e9f... Sergey Ivanovskiy
06:57 AM Feature #2683: reverse proxy implementation
Please review the current diff that builds @https://${X-Forwarded-Server}/freeport/index.html?token=...@ uri if X-For... Sergey Ivanovskiy
06:46 AM Feature #2683: reverse proxy implementation
Sergey Ivanovskiy wrote:
> I decided to use X-Forwarded-Server and X-Forwarded-Proto to rewrite web client uri if a...
Greg Shah
06:41 AM Feature #2683: reverse proxy implementation
Another trouble is that it seems that Apache has a bug (https://bz.apache.org/bugzilla/show_bug.cgi?id=46665) that pr... Sergey Ivanovskiy
05:21 AM Feature #2683: reverse proxy implementation
I decided to use X-Forwarded-Server and X-Forwarded-Proto to rewrite web client uri if a reverse proxy is present. Sergey Ivanovskiy
04:10 AM Feature #2683: reverse proxy implementation
Also we can change redirect url to something like https://${X-Forwarded-Server}/freeport/index.html?token=... if @X-F... Sergey Ivanovskiy
03:13 AM Feature #2683: reverse proxy implementation
The web client login page was changed to use ajax in order to fix the embedded client to work with IE. I didn't find ... Sergey Ivanovskiy
11:25 AM Bug #3252: incorrect cursor position in password fill-ins
I have fixed this while working on #2676 (the password character is different from theme to theme). Ovidiu Maxiniuc

03/01/2017

03:47 PM Feature #2683: reverse proxy implementation
Resolved this issue by providing these options... Sergey Ivanovskiy
02:23 PM Feature #2683: reverse proxy implementation
I couldn't redirect https://localhost/gui to https://localhost:7443/gui... Sergey Ivanovskiy
08:27 AM Feature #2683: reverse proxy implementation
FYI, we will continue to configure the FWD servers/clients using either the self-signed certificates OR real public c... Greg Shah
08:18 AM Feature #2683: reverse proxy implementation
A reverse proxy should add these headers to requests:... Sergey Ivanovskiy
06:28 AM Feature #2683: reverse proxy implementation
Sergey Ivanovskiy wrote:
> The question is simply what is the base entry url for this reverse proxy? Is it @https://...
Greg Shah
06:23 AM Feature #2683: reverse proxy implementation
1. I assume when a reverse proxy is being used, we will not be using localhost. The idea here is that localhost does... Greg Shah
06:17 AM Feature #2683: reverse proxy implementation
The question is simply what is the base entry url for this reverse proxy? Is it @https://localhost/gui@? Sergey Ivanovskiy
04:50 AM Feature #2683: reverse proxy implementation
Greg, please correct me. What would be reverse proxy settings and functionality for outside usages if we supposed tha... Sergey Ivanovskiy

02/28/2017

04:29 PM Feature #2683: reverse proxy implementation
From my reading of the above links, it seems that the web socket client will potentially be able to work without chan... Greg Shah

02/27/2017

02:01 PM Bug #3221 (Closed): Implement multi-rectangle clipping
Greg Shah
12:49 PM Bug #3221: Implement multi-rectangle clipping
This was implemented in 3209e, see #3209 note 771. Hynek Cihlar
08:20 AM Feature #2676: implement the equivalent to configurable support for a windows theme
> Will it be possible to swap the current theme at runtime? I will not do anything in this direction for the moment, ... Greg Shah
08:06 AM Feature #2676: implement the equivalent to configurable support for a windows theme
Greg Shah wrote:
> > I am thinking to provide these themes as separately packaged: class with additional code and it...
Ovidiu Maxiniuc
05:29 AM Feature #2676: implement the equivalent to configurable support for a windows theme
> I intend to create a manager/factory that will handle the theme initialization and rendering. It will be configured... Greg Shah
05:23 AM Bug #3250 (Closed): win_spawn failure cannot create process
Code Review Task Branch 3209e Revision 11216
The changes are good.
I'm closing this task. Nice work!
Greg Shah
05:20 AM Bug #3250: win_spawn failure cannot create process
> Do we need to change the spawn_nologon() to replace original CreateProcessW() with approach discussed in note #7 ab... Greg Shah
05:16 AM Bug #3250: win_spawn failure cannot create process
Greg Shah wrote:
> > I have made only one change to winspan.c for adding DestroyEnvironmentBlock call to cleanup env...
Eugenie Lyzenko
04:41 AM Bug #3250: win_spawn failure cannot create process
> I have made only one change to winspan.c for adding DestroyEnvironmentBlock call to cleanup environment block on ex... Greg Shah
04:13 AM Bug #3250: win_spawn failure cannot create process
Constantin Asofiei wrote:
> The repos for the Hotel ChUI and Hotel GUI are in @~/secure/code/p2j_repo/samples/hotel@...
Eugenie Lyzenko
03:51 AM Bug #3250: win_spawn failure cannot create process
Eugenie Lyzenko wrote:
> Can you tell me where can I find the repo to commit @Hotel ChUI@ version of the script?
Th...
Constantin Asofiei
03:49 AM Bug #3250: win_spawn failure cannot create process
Constantin Asofiei wrote:
>
> The modified @server.cmd@ in note 25 looks OK. Please fix the @server.cmd@ for Hote...
Eugenie Lyzenko
03:23 AM Bug #3250: win_spawn failure cannot create process
Eugenie Lyzenko wrote:
> Guys, have a good news.
>
> Finally I have got the web client running for server started...
Constantin Asofiei

02/26/2017

05:24 PM Bug #3250: win_spawn failure cannot create process
This is the modified @deploy/server/server.cmd@ file that works and keeps all functionality of the old one.... Eugenie Lyzenko

02/25/2017

06:56 PM Bug #3250: win_spawn failure cannot create process
Guys, have a good news.
Finally I have got the web client running for server started via @CMD@. You do not beleive...
Eugenie Lyzenko
12:10 PM Bug #3250: win_spawn failure cannot create process
Eugenie Lyzenko wrote:
> Constantin, do you use direct java classes loading to start the server within Eclipse.
No,...
Constantin Asofiei
08:22 AM Bug #3250: win_spawn failure cannot create process
Greg Shah wrote:
> Marius initially wrote the @winspawn.c@ on Windows 7 64-bit in March 2014. It was working at tha...
Eugenie Lyzenko
08:06 AM Bug #3250: win_spawn failure cannot create process
Marius initially wrote the @winspawn.c@ on Windows 7 64-bit in March 2014. It was working at that time.
I agree t...
Greg Shah
07:47 PM Bug #3250: win_spawn failure cannot create process
Constantin Asofiei wrote:
>
> > If this is the Windows update interference - I think we need to implement the appr...
Eugenie Lyzenko

02/24/2017

03:00 PM Feature #2676: implement the equivalent to configurable support for a windows theme
Greg Shah wrote:
> Please design the plugin approach so that we can sub-class a theme plugin and override just those...
Ovidiu Maxiniuc
02:52 PM Feature #2676: implement the equivalent to configurable support for a windows theme
From Greg:
> how much of the color side of the theming is configurable today via the directory vs. being hard-coded?...
Constantin Asofiei
02:45 PM Bug #3250: win_spawn failure cannot create process
Eugenie Lyzenko wrote:
> The question is: Do you have now the server/web client working on current Windows(with Ecli...
Constantin Asofiei
02:33 PM Bug #3250: win_spawn failure cannot create process
One more point.
If this is the Windows update interference - I think we need to implement the approach that is not...
Eugenie Lyzenko
02:24 PM Bug #3250: win_spawn failure cannot create process
Constantin Asofiei wrote:
> Greg Shah wrote:
> > Constantin: please review this task and comment with any ideas.
>...
Eugenie Lyzenko
02:19 PM Bug #3250: win_spawn failure cannot create process
Greg Shah wrote:
> Eugenie: Have you read "Spawner Setup and Configuration":/projects/p2j/wiki/Spawner_Setup_and_Con...
Eugenie Lyzenko
01:59 PM Bug #3250: win_spawn failure cannot create process
Greg Shah wrote:
> Constantin: please review this task and comment with any ideas.
What bugs me is when the server ...
Constantin Asofiei
01:50 PM Bug #3250: win_spawn failure cannot create process
Eugenie: Have you read "Spawner Setup and Configuration":/projects/p2j/wiki/Spawner_Setup_and_Configuration? Perhaps... Greg Shah
08:23 AM Bug #3250: win_spawn failure cannot create process
One small issue with @spawn_logon()@ is that when using @CreateEnvironmentBlock@, we are supposed to call @DeleteEnvi... Greg Shah
08:21 AM Bug #3250: win_spawn failure cannot create process
Constantin: please review this task and comment with any ideas. Greg Shah
08:20 AM Bug #3250: win_spawn failure cannot create process
To be clear, please note this text from Marius in #1811-497:
> I'm afraid that in Windows OS it's not possible to ...
Greg Shah
08:07 AM Bug #3250: win_spawn failure cannot create process
It is likely that the code in @winspawn.c@ is OK, since it did work in past testing. I think the most likely case is... Greg Shah
04:00 AM Bug #3250: win_spawn failure cannot create process
Greg Shah wrote:
> I think I was unclear.
>
> The documentation for @CreateProcessW@ states this:
>
> > Create...
Eugenie Lyzenko
08:48 AM Bug #3252: incorrect cursor position in password fill-ins
When typing in a password fill-in widget, the cursor moves incorrectly instead of staying at the position the last ke... Ovidiu Maxiniuc
08:43 AM Bug #3252 (New): incorrect cursor position in password fill-ins
Ovidiu Maxiniuc

02/23/2017

05:15 PM Feature #2676: implement the equivalent to configurable support for a windows theme
Please design the plugin approach so that we can sub-class a theme plugin and override just those parts that we need ... Greg Shah
05:12 PM Feature #2676: implement the equivalent to configurable support for a windows theme
The immediate objective is to implement the plugin abstraction layer (separating out the current classic theme) while... Greg Shah

02/22/2017

01:07 PM Bug #3250: win_spawn failure cannot create process
I think I was unclear.
The documentation for @CreateProcessW@ states this:
> Creates a new process and its prim...
Greg Shah
12:30 PM Bug #3250: win_spawn failure cannot create process
Greg Shah wrote:
> 2. Trusted
>
> This mode is used for the embedded web client AND also for appserver and batch ...
Eugenie Lyzenko
06:09 AM Bug #3250: win_spawn failure cannot create process
We spawn programs in 2 modes:
1. End-User Authenticated
In this mode, there is a real user that either does or ...
Greg Shah
09:24 PM Bug #3250: win_spawn failure cannot create process
Some investigation result:
1. The first thing that is wrong is the environment passing to @CreateProcessWithLogonW@ ...
Eugenie Lyzenko

02/21/2017

09:17 PM Bug #3250: win_spawn failure cannot create process
The options the @CreateProcessWithLogonW@ is trying to execute:... Eugenie Lyzenko

02/20/2017

04:56 PM Bug #3250: win_spawn failure cannot create process
Some initial background:
>Eugenie,
>
>I've stumbled upon this error, too... I didn't find why this was happening...
Eugenie Lyzenko
04:48 PM Bug #3250 (Closed): win_spawn failure cannot create process
Eugenie Lyzenko

02/18/2017

02:36 AM Bug #3249: APPLY statement to send characters to an unfocused Fill-In
The issue with reverted sequence of characters appeared in this task https://proj.goldencode.com/issues/3209#note-699... Sergey Ivanovskiy
02:15 AM Bug #3249 (New): APPLY statement to send characters to an unfocused Fill-In
Sergey Ivanovskiy

02/09/2017

02:08 PM Feature #3246: reduce the amount of data being sent to the client-side when an UI attribute is be...
Whenever a widget attribute setter is being called on server-side, FWD relies on the @pushScreenDefinition()@ to noti... Constantin Asofiei
01:55 PM Feature #3246 (Closed): reduce the amount of data being sent to the client-side when an UI attrib...
Constantin Asofiei

02/07/2017

03:15 PM Bug #3245: move-before-tab-item and move-after-tab-item must not affect the z-order
Something else to check: in nested event loops, is the adjusted z-order preserved (from outer to inner and viceversa)? Constantin Asofiei
03:04 PM Bug #3245: move-before-tab-item and move-after-tab-item must not affect the z-order
These two 4GL functions are implemented in @ThinClient.moveAfterTabItem@ and @ThinClient.moveBeforeTabItem@. When us... Constantin Asofiei
02:51 PM Bug #3245 (New): move-before-tab-item and move-after-tab-item must not affect the z-order
Constantin Asofiei
02:51 PM Feature #3244: implement search-by-key in SELECTION-LIST
Currently, SELECTION-LIST does not allow switching elements when a key matching the first char in the element is pres... Constantin Asofiei
02:49 PM Feature #3244 (New): implement search-by-key in SELECTION-LIST
Constantin Asofiei

02/02/2017

04:27 PM Bug #3238: GUI BROWSE gives an error when its parent top-level window maximized
No exact steps are known to reproduce this. The error has been spotted in a customer application. When the main windo... Hynek Cihlar
04:23 PM Bug #3238 (New): GUI BROWSE gives an error when its parent top-level window maximized
Hynek Cihlar
03:48 PM Feature #3232: implement WINDOW-STATE attribute support
Runtime support for @WINDOW-STATE@ has been committed to 3209e. Please note that the implementation is yet missing su... Hynek Cihlar

02/01/2017

03:27 PM Feature #3236: implement port range support for the web client's embedded web server
On further thought, we cannot implement the server-side termination hooks as the only solution for managing the avail... Greg Shah
03:24 PM Feature #3236: implement port range support for the web client's embedded web server
> Do you agree?
I think we do need to consider it, but I seem to recall that we deliberately don't use the watchdo...
Greg Shah
03:20 PM Feature #3236: implement port range support for the web client's embedded web server
Sergey wrote:
> Another thought is that we don't start watch dog timer here.
>
> // notify the remote client ...
Greg Shah
03:19 PM Feature #3236: implement port range support for the web client's embedded web server
It is a good point. I had forgotten we did that. For now I'm going to stop working on this idea. Greg Shah
03:18 PM Feature #3236: implement port range support for the web client's embedded web server
Sergey wrote:
> I didn't want to confuse this shutdown use case. I meant that getting MSG_QUIT from the websocket ...
Greg Shah
03:16 PM Feature #3236: implement port range support for the web client's embedded web server
> where websock.quit() invokes System.exit(0) on receiving MSG_QUIT
I don't see that WebClientProtocol.quit() cal...
Greg Shah
03:15 PM Feature #3236: implement port range support for the web client's embedded web server
Sergey wrote:
> I think these logs show the correct sequence of shutdown() method invocation:
>
> @Override
>...
Greg Shah
03:14 PM Feature #3236: implement port range support for the web client's embedded web server
Constantin wrote:
> Ah, OK, then it makes sense.
Greg Shah
03:13 PM Feature #3236: implement port range support for the web client's embedded web server
> From Constantin:
>
> > What if the client dies unexpectedly and the server is never notified the port is free? ...
Greg Shah
03:13 PM Feature #3236: implement port range support for the web client's embedded web server
From Constantin:
> What if the client dies unexpectedly and the server is never notified the port is free? This c...
Greg Shah
03:12 PM Feature #3236: implement port range support for the web client's embedded web server
I am looking into enabling the "port range" idea for launching web clients. Today we support a hard coded client web... Greg Shah
03:10 PM Feature #3236 (Closed): implement port range support for the web client's embedded web server
Greg Shah
07:59 AM Feature #3235: Proper handling of the image loading from file containing several images
The objective is to add ability to select image version to load from the file that has several versions of the same i... Eugenie Lyzenko
07:30 AM Feature #3235 (New): Proper handling of the image loading from file containing several images
Eugenie Lyzenko
 

Also available in: Atom