FWD » Core Development » User Interface

03/19/2020

06:16 PM Feature #4164: implement misc UI features (frame options, misc attributes)

Updated per suggestions. Thanks!... Roger Borrello

05:27 PM Feature #4164: implement misc UI features (frame options, misc attributes)

I don't see any value in @BrowseWidget.getBrowseCacheSize()@ when @getNumEntries()@ can call @LogicalTerminal.getBrow... Greg Shah

05:22 PM Feature #4164: implement misc UI features (frame options, misc attributes)

> * @ClientExports: public int getBrowseCacheSize(int browseId);@
> * @BrowseWidget: private int getBrowseCacheSize(... Stanislav Lomany

05:04 PM Feature #4164: implement misc UI features (frame options, misc attributes)

Stanislav Lomany wrote:
> Consider you have a browse:
>
> [...]
>
> DOWN is 5, cache size is 2.
Thanks.
... Roger Borrello

03:32 PM Feature #4164: implement misc UI features (frame options, misc attributes)

Consider you have a browse:... Stanislav Lomany

03:28 PM Feature #4164: implement misc UI features (frame options, misc attributes)

Greg Shah wrote:
> Yes, except you will only have the @browseId@ parameter and you must return an @int@.
What's t... Roger Borrello

02:33 PM Feature #4164: implement misc UI features (frame options, misc attributes)

Yes, except you will only have the @browseId@ parameter and you must return an @int@. Greg Shah

02:24 PM Feature #4164: implement misc UI features (frame options, misc attributes)

Stanislav Lomany wrote:
> > Do we already have an API for this? If not, do we store this value on the client?
>
... Roger Borrello

09:33 AM Feature #4164: implement misc UI features (frame options, misc attributes)

As Stanislav noted above, FWD returning 11 is a BUG. So you don't need to analyze how 11 relates to anything.
> 4... Greg Shah

09:16 AM Feature #4164: implement misc UI features (frame options, misc attributes)

FWD returning 11 leads me to believe there are still 11 rows in the view. Evidence is the slider on the scrollbar has... Roger Borrello

08:39 AM Feature #4164: implement misc UI features (frame options, misc attributes)

Read the comments in @browse_num_entries.p@ and look carefully at the current FWD implementation/comments. Make sure... Greg Shah

05:38 PM Bug #4589: menu case sensitivity and conversion

Sergey Ivanovskiy wrote:
> It is interesting what tests from @testcases/uast/menu/@ should be passed with the trunc... Roger Borrello

04:03 PM Bug #4589: menu case sensitivity and conversion

It is interesting what tests from @testcases/uast/menu/@ should be passed with the trunc version now. I found that m... Sergey Ivanovskiy

09:22 AM Bug #4589: menu case sensitivity and conversion

* 4GL names are always case-insensitive. Java names are always case-sensitive. So we must handle this at conver... Greg Shah

09:02 AM Bug #4589: menu case sensitivity and conversion

Yes, I have similar questions.
I have only this way to collect all @"javaname"@ annotations created for menus, sub... Sergey Ivanovskiy

08:54 AM Bug #4589: menu case sensitivity and conversion

Sergey Ivanovskiy wrote:
> I am investigating logs from my changes in @rules/annotations/menu_scoping.rules@ because... Roger Borrello

05:25 AM Bug #4589: menu case sensitivity and conversion

I am investigating logs from my changes in @rules/annotations/menu_scoping.rules@ because the rules are not clear for... Sergey Ivanovskiy

03:04 AM Bug #4589: menu case sensitivity and conversion

It seems that the sub menu name from its definition should be here, but the converted name can use lower and upper ca... Sergey Ivanovskiy

03/18/2020

07:01 PM Feature #4164: implement misc UI features (frame options, misc attributes)

> What is @NUM-ENTRIES@ attribute hold? Is it the number of entries left?
It is the number of data rows in the vie... Stanislav Lomany

06:51 PM Feature #4164: implement misc UI features (frame options, misc attributes)

Greg Shah wrote:
> Stanislav Lomany wrote:
> > > Stanislav: Please review.
> >
> > The approach in @getNumEntrie... Roger Borrello

05:12 PM Bug #4589: menu case sensitivity and conversion

I updated the testcase to get the new failure:... Roger Borrello

04:46 PM Bug #4589: menu case sensitivity and conversion

I don't think it fixes the issue. The Javaname is now lowercase, but not found. Shouldn't it be a converted name?
... Roger Borrello

04:06 PM Bug #4589: menu case sensitivity and conversion

Is this a complete fix for all known issues seen in this task? Greg Shah

03:58 PM Bug #4589: menu case sensitivity and conversion

Sergey Ivanovskiy wrote:
> Thank you. Please use this patch. It seems that it fixed @menu-item@ according to my test... Roger Borrello

03:41 PM Bug #4589: menu case sensitivity and conversion

Thank you. Please use this patch. It seems that it fixed @menu-item@ according to my test. Sergey Ivanovskiy

03:39 PM Bug #4589: menu case sensitivity and conversion

Sergey Ivanovskiy wrote:
> Roger, I tested this diff with 4231b patched. It couldn't convert @menu-item quititem:SEN... Roger Borrello

03:21 PM Bug #4589: menu case sensitivity and conversion

Roger, I tested this diff with 4231b patched. It couldn't convert @menu-item quititem:SENSITIVE = false.@ properly bu... Sergey Ivanovskiy

11:49 AM Bug #4589: menu case sensitivity and conversion

Sergey Ivanovskiy wrote:
> I think that frame scoping is not connected with this issue because this example 4GL GUI ... Roger Borrello

11:41 AM Bug #4589: menu case sensitivity and conversion

I cannot think of ANY names in the 4GL that are case-sensitive. Our conversion needs to treat all menu, sub-menu and... Greg Shah

11:31 AM Bug #4589: menu case sensitivity and conversion

I think that frame scoping is not connected with this issue because this example 4GL GUI works similarly on the nativ... Sergey Ivanovskiy

11:27 AM Bug #4589: menu case sensitivity and conversion

There isn't a @frame@ scoping the menu in the new case. That is what the customer's code is doing, so we need to unde... Roger Borrello

11:23 AM Bug #4589: menu case sensitivity and conversion

According to this 4GL UI test:... Sergey Ivanovskiy

10:39 AM Bug #4589: menu case sensitivity and conversion

Thank you, I see it now. Sergey Ivanovskiy

10:16 AM Bug #4589: menu case sensitivity and conversion

If you change @thissubmenu:SENSITIVE@ to @ThisSUBMENU:SENSITIVE@ it will generate the correct results. Roger Borrello

10:13 AM Bug #4589: menu case sensitivity and conversion

Compiling of @testcases/uast/submenu_case-sensitive.p@ with 4231b (rev 11376) failed... Sergey Ivanovskiy

10:07 AM Bug #4589 (Closed): menu case sensitivity and conversion

Sergey Ivanovskiy

04:30 PM Feature #3880: enhanced browse 3rd phase of improvements

> Help me understand what you see as the advantage of separating things.
I think you're right that it is a single ... Stanislav Lomany

09:24 PM Feature #3880: enhanced browse 3rd phase of improvements

I assume that the layout parameters for use in both the screen/display and the reports.
Why do we want to keep thi... Greg Shah

03/17/2020

05:42 PM Feature #3880: enhanced browse 3rd phase of improvements

All kinds of colors and fonts, column width, order and visibility, row height. Stanislav Lomany

05:39 PM Feature #3880: enhanced browse 3rd phase of improvements

What are examples of "layout parameters"? Greg Shah

05:29 PM Feature #3880: enhanced browse 3rd phase of improvements

Greg, I have some conceptual questions about report-related enhanced parameters. Enhanced parameters can be divided i... Stanislav Lomany

03:44 PM Feature #2683: reverse proxy implementation

> > It is used only to generate mapping on the fly for new connected broker client.
>
> Is it used for anything ex... Sergey Ivanovskiy

03:31 PM Feature #2683: reverse proxy implementation

> It is used only to generate mapping on the fly for new connected broker client.
Is it used for anything external... Greg Shah

03:22 PM Feature #2683: reverse proxy implementation

I rechecked if Jetty implements the reverse proxy support for wss connections and found that https://webtide.com/http... Sergey Ivanovskiy

02:29 PM Feature #2683: reverse proxy implementation

This hosts file is related only to the network configuration. It is used only to generate mapping on the fly for new ... Sergey Ivanovskiy

01:45 PM Feature #2683: reverse proxy implementation

> Should I change it to use the directory?
Is there any advantage to leaving it as a separate file? Greg Shah

01:02 PM Feature #2683: reverse proxy implementation

Committed revision 11374 (4231b) fixed 1), 2), 4) and 5). The hosts file is used for mapping unique pairs of host and... Sergey Ivanovskiy

08:37 AM Feature #2683: reverse proxy implementation

Code Review Task Branch 4231b Revision 11372
Overall, it is a nicer implementation to have the @HostsManager@.
... Greg Shah

07:51 AM Feature #2683: reverse proxy implementation

Constantin Asofiei wrote:
> Sergey Ivanovskiy wrote:
> > Yes, it looks like the old issue documented in @WebClientP... Sergey Ivanovskiy

11:43 AM Bug #3690: BUTTON widget reaction on SPACEBAR and ENTER keys

It seems the changes in 4231b Revision 11372 are good. Sergey Ivanovskiy

11:11 AM Bug #3690: BUTTON widget reaction on SPACEBAR and ENTER keys

Code Review Task Branch 4231b Revision 11372
The changes seem good to me.
Sergey: Any objections? Greg Shah

10:54 AM Bug #3690: BUTTON widget reaction on SPACEBAR and ENTER keys

Committed fix in 4231b/rev. 11373. The changes were minimal - only the space-bar generates additional released events. Adrian Lungu

06:11 AM Bug #3690: BUTTON widget reaction on SPACEBAR and ENTER keys

After checking the @GUIKeyboardReader@, I see there is the following code which triggers that additional @keyups@:
<... Adrian Lungu

05:16 AM Bug #3690: BUTTON widget reaction on SPACEBAR and ENTER keys

Now I see that this behavior can't be reproduced on Chrome. Maybe it is a bug in Firefox regarding long key presses? Adrian Lungu

05:10 AM Bug #3690: BUTTON widget reaction on SPACEBAR and ENTER keys

Greg Shah wrote:
> I don't want to send a large number of additional events up to Java if we only need a very small ... Adrian Lungu

11:39 AM Feature #4174: implement calendar control/dtpicker OCX replacement

The custom format is implemented exactly according to this documentations https://docs.oracle.com/javase/tutorial/i18... Sergey Ivanovskiy

11:16 AM Feature #4174: implement calendar control/dtpicker OCX replacement

I think the @VALUE-CHANGED@ event and the custom beginning day of week will be needed.
> but the custom format the... Greg Shah

10:46 AM Feature #4174: implement calendar control/dtpicker OCX replacement

Working to improve the documentation of calendar. The current version of @Calendar@ can convert @DateTimeValue@ value... Sergey Ivanovskiy

09:29 AM Feature #4174: implement calendar control/dtpicker OCX replacement

I see that there is a good start on the documentation. Thank you!
I sent the link to some customers for review. ... Greg Shah

03/16/2020

01:15 PM Bug #3690: BUTTON widget reaction on SPACEBAR and ENTER keys

>> Even though the KEY_RELEASED event is not a progress event, it should be generated in order to properly reproduce ... Greg Shah

12:29 PM Bug #3690: BUTTON widget reaction on SPACEBAR and ENTER keys

Adrian Lungu wrote:
> Yet, I am not sure how the key events are handled in the web driver. But from this slim invest... Sergey Ivanovskiy

12:12 PM Bug #3690: BUTTON widget reaction on SPACEBAR and ENTER keys

It seems that @keyup@ browser's event means that a key is released. Is it correct to change this part of the js web c... Sergey Ivanovskiy

10:39 AM Bug #3690: BUTTON widget reaction on SPACEBAR and ENTER keys

Adrian Lungu wrote:
> I recently found a bug related to the issue here - regarding the web interface. The web driver... Sergey Ivanovskiy

10:32 AM Bug #3690: BUTTON widget reaction on SPACEBAR and ENTER keys

Whatever solution is created, please minimize the number of events forwarded to the FWD client (Java side). Optimall... Greg Shah

10:21 AM Bug #3690: BUTTON widget reaction on SPACEBAR and ENTER keys

I recently found a bug related to the issue here - regarding the web interface. The web driver doesn't emit release e... Adrian Lungu

03/13/2020

03:45 PM Feature #4164: implement misc UI features (frame options, misc attributes)

Task branch 4335a was merged to trunk as revision 11345. Greg Shah

03:43 PM Feature #4199: implement a data visualization widget which can be used for a wide range of data-b...

Task branch 4335a was merged to trunk as revision 11345. Greg Shah

03:42 PM Feature #4472 (Closed): Allow pause for a fraction of a second

Task branch 4335a was merged to trunk as revision 11345. Greg Shah

03:41 PM Feature #4170: add drag and drop support to treeview widget

Task branch 4335a was merged to trunk as revision 11345.
See #4170-21 for the remaining work. Greg Shah

03/11/2020

04:05 PM Feature #4174: implement calendar control/dtpicker OCX replacement

Sergey: Please write up the documentation for this widget in "CALENDAR Widget and OCX Replacement":/projects/p2j/wiki... Greg Shah

02:54 PM Feature #2683: reverse proxy implementation

We don't have documentation yet. External widget support is only needed in special cases where the code cannot be pl... Greg Shah

02:25 PM Feature #2683: reverse proxy implementation

Greg, please could you provide me with information about external widget support? Are there ready examples? Sergey Ivanovskiy

02:18 PM Feature #2683: reverse proxy implementation

Although it should be safe, I prefer to avoid changes in 4335a. Please put your changes into 4231b after it is rebas... Greg Shah

03/10/2020

09:10 AM Feature #2683: reverse proxy implementation

Sergey Ivanovskiy wrote:
> I can't use 4231b for #2683-73 changes because these code exist only in 4335a. These chan... Sergey Ivanovskiy

08:42 AM Feature #2683: reverse proxy implementation

I can't use 4231b for #2683-73 changes because these code exist only in 4335a. These changes are only to remove logs ... Sergey Ivanovskiy

04:34 AM Feature #4182: KERNEL32:SLEEP() emulation

Roger Borrello wrote:
> Constantin Asofiei wrote:
> > Roger, I was missing the .ext-hints. After this, your sleep t... Hynek Cihlar

03:56 AM Feature #4170: add drag and drop support to treeview widget

Roger Borrello wrote:
> I see many new keywords added related to @node@ and @nodes@. Were they a result of this issu... Hynek Cihlar

03/09/2020

06:24 PM Feature #2683: reverse proxy implementation

Sergey Ivanovskiy wrote:
> Yes, it looks like the old issue documented in @WebClientProtocol@
OK, please add javado... Constantin Asofiei

06:23 PM Feature #2683: reverse proxy implementation

Greg Shah wrote:
> I don't have a problem with the patch, but Constantin should review.
I'm OK with the patch.
>... Constantin Asofiei

05:38 PM Feature #2683: reverse proxy implementation

Yes, it looks like the old issue documented in @WebClientProtocol@... Sergey Ivanovskiy

04:59 PM Feature #2683: reverse proxy implementation

It is interesting if we should remove logs here in @ThinClient.initializePost@ because it would block the web client?... Sergey Ivanovskiy

04:31 PM Feature #2683: reverse proxy implementation

It seems that this hanging issue is reproduced only when I tried to connect @https://localhost/gui@ and the Apache pr... Sergey Ivanovskiy

04:04 PM Feature #2683: reverse proxy implementation

The hanging issue has this thread context:
1) @KeyReader@ thread is in this state... Sergey Ivanovskiy

03:41 PM Feature #2683: reverse proxy implementation

No, the broker manager patch is related to the case when the broker manager is not used but clients to ports map is r... Sergey Ivanovskiy

03:28 PM Feature #2683: reverse proxy implementation

I don't have a problem with the patch, but Constantin should review.
> It requires to set up a broker configuratio... Greg Shah

03:14 PM Feature #2683: reverse proxy implementation

I tested this Apache Reverse proxy configuration with this branch 4335a using Hotel Gui application. The current code... Sergey Ivanovskiy

05:15 PM Feature #4170: add drag and drop support to treeview widget

I see many new keywords added related to @node@ and @nodes@. Were they a result of this issue? I noticed that @node-e... Roger Borrello

03:49 PM Feature #4182: KERNEL32:SLEEP() emulation

Constantin Asofiei wrote:
> Roger, I was missing the .ext-hints. After this, your sleep testcase in #4182-6 works fi... Roger Borrello

03:41 PM Feature #4182: KERNEL32:SLEEP() emulation

Roger, I was missing the .ext-hints. After this, your sleep testcase in #4182-6 works fine.
Please check your clas... Constantin Asofiei

03:27 PM Feature #4182: KERNEL32:SLEEP() emulation

Roger, sorry, I can't make anything to work (@gethostbyname@, @GetComputerNameA@). I don't recall how this was suppo... Constantin Asofiei

02:52 PM Feature #4182: KERNEL32:SLEEP() emulation

Eric Faulhaber wrote:
> Sorry, no. If this test case is one of mine, I don't remember it.
>
> Are you getting a p... Roger Borrello

02:48 PM Feature #4182: KERNEL32:SLEEP() emulation

Sorry, no. If this test case is one of mine, I don't remember it.
Are you getting a particular error, or just no r... Eric Faulhaber

02:39 PM Feature #4182: KERNEL32:SLEEP() emulation

Eric, did you ever test the @myconn1.p@ testcase under FWD and Windows? I'm trying to get my @Kernel32:Sleep@ functio... Roger Borrello

02:35 PM Feature #4182: KERNEL32:SLEEP() emulation

I made a simplified version of @uast/myconn1.p@:... Roger Borrello

02:12 PM Feature #4182: KERNEL32:SLEEP() emulation

I made sure my pathing was correct by validating that @directory.xml@ contains:... Roger Borrello

01:26 PM Feature #4182: KERNEL32:SLEEP() emulation

@./src/com/goldencode/testcases/name_map.xml@ looks good... although perhaps the pathing is misconfigured?... Roger Borrello

01:21 PM Feature #4182: KERNEL32:SLEEP() emulation

Roger Borrello wrote:
> When @getAbsoluteName(Object referent)@ is called, @jname="com.goldencode.testcases.windows_... Constantin Asofiei

01:16 PM Feature #4182: KERNEL32:SLEEP() emulation

When @getAbsoluteName(Object referent)@ is called, @jname="com.goldencode.testcases.windows_emulation.Kernel32Sleep"@... Roger Borrello

12:50 PM Feature #4182: KERNEL32:SLEEP() emulation

Constantin Asofiei wrote:
> Roger Borrello wrote:
> > I hit a breakpoint in @Kernel32Sleep.lambda$execute$1@ so I'l... Roger Borrello

12:27 PM Feature #4182: KERNEL32:SLEEP() emulation

Roger Borrello wrote:
> I hit a breakpoint in @Kernel32Sleep.lambda$execute$1@ so I'll try to find my way from here.... Constantin Asofiei

12:25 PM Feature #4182: KERNEL32:SLEEP() emulation

Constantin Asofiei wrote:
> Roger Borrello wrote:
> > I was expecting to hit my breakpoint, but I must be missing s... Roger Borrello

12:19 PM Feature #4182: KERNEL32:SLEEP() emulation

Roger Borrello wrote:
> I was expecting to hit my breakpoint, but I must be missing something.
You need to attach t... Constantin Asofiei

12:17 PM Feature #4182: KERNEL32:SLEEP() emulation

I've been trying to catch this in the debugger, but since this is my first rodeo debugging client or server runtime, ... Roger Borrello

03/06/2020

05:43 PM Feature #4182: KERNEL32:SLEEP() emulation

Greg Shah wrote:
> Did the conversion occur successfully?
Yes...... Roger Borrello

05:39 PM Feature #4182: KERNEL32:SLEEP() emulation

Did the conversion occur successfully? Greg Shah

05:32 PM Feature #4182: KERNEL32:SLEEP() emulation

List of testcases:... Roger Borrello

03/05/2020

09:40 PM Feature #3880: enhanced browse 3rd phase of improvements

Rebased task branch 3880a from P2J trunk revision 11344. Stanislav Lomany

03/04/2020

02:30 PM Feature #4199: implement a data visualization widget which can be used for a wide range of data-b...

The chart-related classes are in 4335a rev 11452 Constantin Asofiei

06:53 AM Feature #4199: implement a data visualization widget which can be used for a wide range of data-b...

The list of files I've added for charting are:... Constantin Asofiei

05:58 AM Feature #4199: implement a data visualization widget which can be used for a wide range of data-b...

Greg Shah wrote:
> OK. I'm fine with using Java getters/setters.
I haven't fixed this yet. The solution should wo... Constantin Asofiei

10:32 AM Bug #4498 (Closed): Embedded assignment of extent in shared frame fails

Greg Shah

10:31 AM Bug #4488 (Closed): Wrong frame used after display includes widgets from other frame

Greg Shah

03/03/2020

06:28 PM Feature #4393: add TITLE-DCOLOR attribute support

h2. Attributes
This documents the @TITLE-BGCOLOR@, @TITLE-DCOLOR@, @TITLE-FGCOLOR@ and @TITLE-FONT@ attributes for... Greg Shah

02:56 PM Bug #4498: Embedded assignment of extent in shared frame fails

Task branch 4207a was merged to trunk as revision 11344. Roger Borrello

02:56 PM Bug #4488: Wrong frame used after display includes widgets from other frame

Task branch 4207a was merged to trunk as revision 11344. Roger Borrello

01:08 PM Feature #4174 (Closed): implement calendar control/dtpicker OCX replacement

Branch 4207a was merged to trunk as revision 11344.
The items in #4174-152 are deferred to a future task (when a c... Greg Shah

07:55 AM Feature #4174 (Test): implement calendar control/dtpicker OCX replacement

Greg Shah

03/02/2020

06:43 PM Feature #4393: add TITLE-DCOLOR attribute support

h2. Title Phrase
Summary:
* the syntax processing of options for the frame phrase and the browse options phrase... Greg Shah

05:30 PM Feature #4393: add TITLE-DCOLOR attribute support

The following testcases were created:... Greg Shah

05:20 PM Feature #4199: implement a data visualization widget which can be used for a wide range of data-b...

Constantin Asofiei wrote:
> Greg Shah wrote:
> > This is probably OK for now, but we are really trying to achieve a... Greg Shah

10:41 AM Feature #4199: implement a data visualization widget which can be used for a wide range of data-b...

Greg Shah wrote:
> This is probably OK for now, but we are really trying to achieve a generic data visualization wid... Constantin Asofiei

09:59 AM Feature #4199: implement a data visualization widget which can be used for a wide range of data-b...

> I'm placing everything related to chart in com.goldencode.p2j.ui.chart, except main widget class (ui.ChartWidget).
... Greg Shah

08:08 AM Feature #4199: implement a data visualization widget which can be used for a wide range of data-b...

Hynek Cihlar wrote:
> Constantin Asofiei wrote:
> > The chaining (for chart setup) is pretty deep and is easier to ... Constantin Asofiei

07:58 AM Feature #4199: implement a data visualization widget which can be used for a wide range of data-b...

Constantin Asofiei wrote:
> The chaining (for chart setup) is pretty deep and is easier to allow this instead of exp... Hynek Cihlar

07:57 AM Feature #4199: implement a data visualization widget which can be used for a wide range of data-b...

I'm placing everything related to chart in @com.goldencode.p2j.ui.chart@, except main widget class (@ui.ChartWidget@)... Constantin Asofiei

07:54 AM Feature #4199: implement a data visualization widget which can be used for a wide range of data-b...

For chart, in the end I'm working on adding support for calls like:... Constantin Asofiei

12:55 PM Feature #4174: implement calendar control/dtpicker OCX replacement

Committed revision 11420 (4207a) fixed the custom format and color setters, removed extra elements from Calendar widg... Sergey Ivanovskiy

10:00 AM Feature #4174: implement calendar control/dtpicker OCX replacement

These MS Date/Time Picker features are not implemented yet:
1) to support MS @CustomFormat@ https://docs.microsoft... Sergey Ivanovskiy

02/29/2020

02:24 PM Feature #4174: implement calendar control/dtpicker OCX replacement

This task branch 4174a has been merged into the trunc as rev 11343 and archived. Sergey Ivanovskiy

02:02 PM Feature #4174: implement calendar control/dtpicker OCX replacement

Hynek Cihlar wrote:
> Code review 4174a revisions 11373..11379.
>
> @<action>map6.put("UpDown" , "UpDow... Sergey Ivanovskiy

01:46 PM Feature #4174: implement calendar control/dtpicker OCX replacement

Code review 4174a revisions 11373..11379.
@<action>map6.put("UpDown" , "UpDown")</action>@ is redundant ... Hynek Cihlar

12:33 PM Feature #4174: implement calendar control/dtpicker OCX replacement

Committed rev 11379 (4174a) fixed @DateTimeValue@ widget value to accept ISO date and time string value. Planning to ... Sergey Ivanovskiy

11:36 AM Feature #4174: implement calendar control/dtpicker OCX replacement

Committed revision 11378 (4174a) fixed @SCREEN-VALUE@ for new calendar widget. Sergey Ivanovskiy

02/28/2020

05:26 PM Feature #4174: implement calendar control/dtpicker OCX replacement

No objections. Greg Shah

05:19 PM Feature #4174: implement calendar control/dtpicker OCX replacement

Committed revision 11377 (4174a) fixed the conversion for new calendar widget when common methods of @OcxMouse@ and @... Sergey Ivanovskiy

10:12 AM Bug #4558: The semitransparent picture of the web client page is displayed when dragging the mouse

With Firefox we can observe the default action when dragging the mouse (the left mouse button is pressed and the mous... Sergey Ivanovskiy

10:09 AM Bug #4558 (New): The semitransparent picture of the web client page is displayed when dragging th...

Sergey Ivanovskiy

02/27/2020

08:41 AM Bug #4557: radio-set deviations from the 4GL GUI

Eugenie found this list of bugs (testing with branch 4335a) while running the radio-set testcases (in @testcases/uast... Greg Shah

08:36 AM Bug #4557 (New): radio-set deviations from the 4GL GUI

Greg Shah

02/26/2020

02:13 PM Feature #4174: implement calendar control/dtpicker OCX replacement

During the @test_bar_test2.p@ I found the conversion issues and fixed them so the @ProgressBar@ can be wrapped into @... Sergey Ivanovskiy

10:04 AM Feature #4174: implement calendar control/dtpicker OCX replacement

Yes, I missed this option in the hint file @progress_bar_test.p.ext-hints@... Sergey Ivanovskiy

09:59 AM Feature #4174: implement calendar control/dtpicker OCX replacement

But this test @uast/progressbar/progress_bar_test6.p@ doesn't have @control_load@ procedure and hence it can be used ... Sergey Ivanovskiy

09:36 AM Feature #4174: implement calendar control/dtpicker OCX replacement

I don't understand why the @.wrx@ file is needed. If you configure the @.ext-hints@ file, the @LoadControls@ will be... Greg Shah

09:30 AM Feature #4174: implement calendar control/dtpicker OCX replacement

The committed revision 11374 (4174a) fixed @progressbar@ widget issues and this test from @testcases@ must be fixed d... Sergey Ivanovskiy

01:43 AM Feature #4174: implement calendar control/dtpicker OCX replacement

Greg Shah wrote:
> What testing (conversion and runtime) is needed before this can be merged to trunk?
The customer... Sergey Ivanovskiy

11:30 AM Feature #3880: enhanced browse 3rd phase of improvements

For enhanced browse changes created task branch 3880a from FWD trunk revision 11342. Stanislav Lomany

02/25/2020

02:02 PM Feature #4174: implement calendar control/dtpicker OCX replacement

What testing (conversion and runtime) is needed before this can be merged to trunk? Greg Shah

01:43 PM Feature #4174: implement calendar control/dtpicker OCX replacement

Sergey Ivanovskiy wrote:
> Please review the fixed code the committed revision 11373 (4174a).
The changes are goo... Hynek Cihlar

01:39 PM Feature #4174: implement calendar control/dtpicker OCX replacement

Please review the fixed code the committed revision 11373 (4174a). Sergey Ivanovskiy

01:09 PM Feature #4174: implement calendar control/dtpicker OCX replacement

Sergey Ivanovskiy wrote:
> OK. The previous notes confuse me.
Some OCX/COM references are desired, like those in... Hynek Cihlar

12:30 PM Feature #4174: implement calendar control/dtpicker OCX replacement

This is the summary patch for this task. Sergey Ivanovskiy

12:28 PM Feature #4174 (Review): implement calendar control/dtpicker OCX replacement

OK. The previous notes confuse me. Please review these changes, the committed revision 11372 (4174a) that added histo... Sergey Ivanovskiy

11:26 AM Feature #4174: implement calendar control/dtpicker OCX replacement

Sergey Ivanovskiy wrote:
> Also there is a package @com.goldencode.p2j.ui.ocx@. Please explain the purpose of these ... Hynek Cihlar

11:13 AM Feature #4174: implement calendar control/dtpicker OCX replacement

Also there is a package @com.goldencode.p2j.ui.ocx@. Please explain the purpose of these changes/renamings in this task? Sergey Ivanovskiy

11:01 AM Feature #4174: implement calendar control/dtpicker OCX replacement

Were these files reviewed before they were committed in the trunc? Sergey Ivanovskiy

11:00 AM Feature #4174: implement calendar control/dtpicker OCX replacement

and these files
src/com/goldencode/p2j/ui/OcxDragDrop.java
src/com/goldencode/p2j/ui/OcxDragDropConfig.java
... Sergey Ivanovskiy

10:59 AM Feature #4174: implement calendar control/dtpicker OCX replacement

4174a
rules
convert
methods_attributes.rules (6 matches)
1,054: <rule>list.put(prog.kw_ole_drmd, execLib("cr_desc... Sergey Ivanovskiy

10:57 AM Feature #4174: implement calendar control/dtpicker OCX replacement

Sergey Ivanovskiy wrote:
> Hynek Cihlar wrote:
> > Sergey Ivanovskiy wrote:
> > > Does it make sense to postpone t... Hynek Cihlar

10:55 AM Feature #4174: implement calendar control/dtpicker OCX replacement

Another question is how these files are related to this particular task that implements the calendar widget? Sergey Ivanovskiy

10:52 AM Feature #4174: implement calendar control/dtpicker OCX replacement

Hynek Cihlar wrote:
> Sergey Ivanovskiy wrote:
> > Does it make sense to postpone these huge changes?
>
> By hug... Sergey Ivanovskiy

10:29 AM Feature #4174: implement calendar control/dtpicker OCX replacement

Sergey Ivanovskiy wrote:
> Does it make sense to postpone these huge changes?
By huge you mean the five files? Or... Hynek Cihlar

10:20 AM Feature #4174: implement calendar control/dtpicker OCX replacement

Does it make sense to postpone these huge changes? Sergey Ivanovskiy

10:16 AM Feature #4174: implement calendar control/dtpicker OCX replacement

I would like to notify that the huge number of files should be changed in order to remove OLE and OCX prefixes.
re... Sergey Ivanovskiy

04:15 AM Feature #4174: implement calendar control/dtpicker OCX replacement

Sergey Ivanovskiy wrote:
> Hynek, Greg, should I change this name @OcxDragDrop@ to @DragDropExt@? Should this @Widge... Hynek Cihlar

04:09 AM Feature #4174: implement calendar control/dtpicker OCX replacement

Sergey Ivanovskiy wrote:
> Hynek Cihlar wrote:
> > The changes look good. Just please rename DTPicker (and any othe... Hynek Cihlar

02:40 AM Feature #4174: implement calendar control/dtpicker OCX replacement

Hynek, Greg, should I change this name @OcxDragDrop@ to @DragDropExt@? Should this @WidgetExtension@ interface extend... Sergey Ivanovskiy

02:26 AM Feature #4174: implement calendar control/dtpicker OCX replacement

Greg Shah wrote:
> Other than changing some comments, is there any remaining work in this task?
I need to add his... Sergey Ivanovskiy

02:22 AM Feature #4174: implement calendar control/dtpicker OCX replacement

Hynek Cihlar wrote:
> Sergey Ivanovskiy wrote:
> > Please explain this idea more clearly. I removed them
> > [...... Sergey Ivanovskiy

02/24/2020

06:23 PM Feature #4174: implement calendar control/dtpicker OCX replacement

Other than changing some comments, is there any remaining work in this task? Greg Shah

04:45 PM Feature #4174: implement calendar control/dtpicker OCX replacement

Sergey Ivanovskiy wrote:
> Please explain this idea more clearly. I removed them
> [...]
> because they were rena... Hynek Cihlar

04:21 PM Feature #4174: implement calendar control/dtpicker OCX replacement

Greg Shah wrote:
> Please change "DateTimePicker" to "Calendar" everywhere (e.g. @DateTimePickerWidget@ to @Calendar... Sergey Ivanovskiy

03:30 PM Feature #4174: implement calendar control/dtpicker OCX replacement

Hynek Cihlar wrote:
> Greg Shah wrote:
> > I'll let Hynek provide his feedback on the naming changes in rev 11367.
... Sergey Ivanovskiy

01:15 PM Feature #4174: implement calendar control/dtpicker OCX replacement

Greg Shah wrote:
> I'll let Hynek provide his feedback on the naming changes in rev 11367.
Please change @REFRESH... Hynek Cihlar

12:41 PM Feature #4174: implement calendar control/dtpicker OCX replacement

Similar changes would be made in @progress.g@. There should be no references to @KW_DTPICKER@ or to @DATETIME-PICKER... Greg Shah

12:38 PM Feature #4174: implement calendar control/dtpicker OCX replacement

Please change "DateTimePicker" to "Calendar" everywhere (e.g. @DateTimePickerWidget@ to @CalendarWidget@, @DateTimePi... Greg Shah

12:14 PM Feature #4174: implement calendar control/dtpicker OCX replacement

Greg Shah wrote:
> I will ask for this change: Please change DatePicker/DTPicker to Calendar. This is a better desc... Sergey Ivanovskiy

12:04 PM Feature #4174: implement calendar control/dtpicker OCX replacement

I'll let Hynek provide his feedback on the naming changes in rev 11367.
I will ask for this change: Please change ... Greg Shah

01:46 AM Feature #4174: implement calendar control/dtpicker OCX replacement

Please look at the committed revision 11367 (4174a) if the naming will be accepted, then I will proceed with another ... Sergey Ivanovskiy

02/22/2020

12:17 PM Feature #4174: implement calendar control/dtpicker OCX replacement

Sergey Ivanovskiy wrote:
> https://proj.goldencode.com/projects/p2j/wiki/Progress_Indicator_Widget_and_OCX_Replaceme... Hynek Cihlar

12:13 PM Feature #4174: implement calendar control/dtpicker OCX replacement

https://proj.goldencode.com/projects/p2j/wiki/Progress_Indicator_Widget_and_OCX_Replacement control has OCX and OLE i... Sergey Ivanovskiy

11:57 AM Feature #4174: implement calendar control/dtpicker OCX replacement

Greg Shah wrote:
> > because we shouldn't copy and paste the common code for these methods. I proposed to use IActiv... Hynek Cihlar

11:52 AM Feature #4174: implement calendar control/dtpicker OCX replacement

> because we shouldn't copy and paste the common code for these methods. I proposed to use IActiveXUIComponent and th... Greg Shah

07:49 AM Feature #4174: implement calendar control/dtpicker OCX replacement

I need to use the common methods from @ProggressBarWidget@... Sergey Ivanovskiy

02/21/2020

04:49 PM Bug #4498 (Test): Embedded assignment of extent in shared frame fails

Greg Shah

04:25 PM Bug #4498: Embedded assignment of extent in shared frame fails

Should this be moved to Status= *Test* Roger Borrello

04:28 PM Bug #4244: Bad format of displays with AT

I'd like to see this moved along when *4207a* gets into trunk. Roger Borrello

01:13 PM Feature #4174: implement calendar control/dtpicker OCX replacement

Committed revision 11366 (4174a) prepared code for the review. The rest task is to add several new key words so that ... Sergey Ivanovskiy

07:34 AM Feature #4164: implement misc UI features (frame options, misc attributes)

Greg Shah wrote:
> Is this just a conversion issue? The methods are implemented in @CommonFrame@ and @FrameWidget@.... Constantin Asofiei

07:20 AM Feature #4164: implement misc UI features (frame options, misc attributes)

Is this just a conversion issue? The methods are implemented in @CommonFrame@ and @FrameWidget@. Greg Shah

07:07 AM Feature #4164: implement misc UI features (frame options, misc attributes)

Greg Shah wrote:
> Can someone please provide more detail on the parts that are missing in regard to @NEXT-TAB-ITEM@... Constantin Asofiei

02/20/2020

03:18 PM Feature #4164: implement misc UI features (frame options, misc attributes)

> Do we already have an API for this? If not, do we store this value on the client?
There's no server API for it,... Stanislav Lomany

03:15 PM Feature #4164: implement misc UI features (frame options, misc attributes)

There is no further conversion work in this task. Everything is just runtime at this point. Greg Shah

03:08 PM Feature #4164: implement misc UI features (frame options, misc attributes)

We have usage of both @NEXT-TAB-ITEM@ and @PREV-TAB-ITEM@ in a customer application. Frames are used as well as widg... Greg Shah

02:50 PM Feature #4164: implement misc UI features (frame options, misc attributes)

4335a revision 11428 adds conversion and server-side support for @EDITOR:AUTO-INDENT@. The client-side runtime still... Greg Shah

12:15 PM Feature #4164: implement misc UI features (frame options, misc attributes)

Stanislav Lomany wrote:
> > Stanislav: Please review.
>
> The approach in @getNumEntries@ doesn't work if a brows... Greg Shah

07:11 AM Feature #4174: implement calendar control/dtpicker OCX replacement

Greg Shah wrote:
> What is the status of this task? When are all items expected to be complete?
I am testing it no... Sergey Ivanovskiy

02/19/2020

06:00 PM Feature #4174: implement calendar control/dtpicker OCX replacement

What is the status of this task? When are all items expected to be complete? Greg Shah

05:40 PM Feature #4181 (Test): GetComputerNameA emulation

Greg Shah

05:29 PM Feature #4181 (WIP): GetComputerNameA emulation

Implemented with a TODO based upon future customer specifications. Ultimately to be implemented in the client drivers... Roger Borrello

05:10 PM Feature #4181: GetComputerNameA emulation

True. It does NOT make sense to do a reverse lookup. Just return the IP address as returned by @LogicalTerminal.get... Greg Shah

04:57 PM Feature #4181: GetComputerNameA emulation

In addition to the problem with NAT/proxy mentioned in the initial task description please consider the case of mult... Igor Skornyakov

04:36 PM Feature #4181: GetComputerNameA emulation

Roger Borrello wrote:
> Is it valid to simply return what returned by LogicalTerminal.getHostName()?
Only as a la... Greg Shah

03:12 PM Feature #4181: GetComputerNameA emulation

Is it valid to simply return what returned by LogicalTerminal.getHostName()? Roger Borrello

02:40 PM Feature #4181: GetComputerNameA emulation

Not really. I don't think we care about the netbios names of client or server. We are just trying to provide a name... Greg Shah

02:25 PM Feature #4181: GetComputerNameA emulation

@GetComputerNameA@ is defined as returning the NetBIOS name established at system startup. Further: "If the caller is... Roger Borrello