FWD » Core Development » User Interface

04/17/2020

06:39 PM Feature #4394 (WIP): add some frame options and attributes

Roger Borrello

06:38 PM Bug #4611: Implement a font enumeration Java API directly callable from legacy code

For Swing GUI, the fonts can be enumerated with:... Hynek Cihlar

06:36 PM Feature #4393: add TITLE-DCOLOR attribute support

Just _temporarily_ I updated to utilize the same method as @toMillis@.
By updating @directory.xml@:... Roger Borrello

02:03 PM Feature #4393: add TITLE-DCOLOR attribute support

With my proposed change, the code could be implemented with a simple check @EnvironmentOps.versionNumber() >= 11.3@. ... Greg Shah

01:38 PM Feature #4393: add TITLE-DCOLOR attribute support

Greg Shah wrote:
> Constantin: What was the code that you added recently which had to check the version numbers at r... Constantin Asofiei

12:43 PM Feature #4393: add TITLE-DCOLOR attribute support

We have @EnvironmentOps.versionWorker(long lvl)@ which can determine a version string for the 4GL version to which we... Greg Shah

11:56 AM Feature #4393 (WIP): add TITLE-DCOLOR attribute support

Roger Borrello

11:55 AM Feature #4393: add TITLE-DCOLOR attribute support

Greg Shah wrote:
> Yes, it could be a version difference. Run the testcases on both 10.x and 11.x and record the di... Roger Borrello

09:33 AM Feature #4393: add TITLE-DCOLOR attribute support

> Should these be pursued?
No. Create new tasks. Greg Shah

09:13 AM Feature #4393: add TITLE-DCOLOR attribute support

The @frame_title_color_default_values.p@ tests pass, however, there are a couple of differences.
# There is space in... Roger Borrello

08:48 AM Feature #4393: add TITLE-DCOLOR attribute support

Code Review Task Branch 4231b Revision 11463
The changes are good.
A minor code standards issue: split the foll... Greg Shah

07:07 AM Feature #4393: add TITLE-DCOLOR attribute support

> while in 4GL, it activates the button and an NPE exception is thrown:
This implies there is an NPE in the 4GL wh... Greg Shah

06:32 PM Feature #3876: add support for "direct font control" at the widget level

Hynek Cihlar wrote:
> but there were errors converting the method call returning String array. I tried to fix this a... Hynek Cihlar

04:56 PM Feature #3876: add support for "direct font control" at the widget level

Sergey Ivanovskiy wrote:
> It seems that these changes
> [...]
>
> are not consistent with @isFontInstalled@ us... Hynek Cihlar

03:44 PM Feature #3876: add support for "direct font control" at the widget level

It seems that these changes ... Sergey Ivanovskiy

11:28 AM Feature #3876: add support for "direct font control" at the widget level

Greg Shah wrote:
> Yes. When you designed the default freely licensed fonts for FWD, this included replacing the co... Eugenie Lyzenko

09:10 AM Feature #3876: add support for "direct font control" at the widget level

Yes. When you designed the default freely licensed fonts for FWD, this included replacing the common/standard bitmap... Greg Shah

09:00 AM Feature #3876: add support for "direct font control" at the widget level

Greg Shah wrote:
> The changes are good. I've made some additional tweaks.
>
> Eugenie: I'd like to include a li... Eugenie Lyzenko

07:39 AM Feature #3876: add support for "direct font control" at the widget level

The changes are good. I've made some additional tweaks.
Eugenie: I'd like to include a list of the commonly used ... Greg Shah

11:55 AM Bug #4619: GUI fill-in widgets show in FWD, when 4GL shows nothing

> In 4GL, this is not a fill-in and
I think you mean that it is an editable fill-in in FWD and not in the 4GL?
... Greg Shah

11:20 AM Bug #4619: GUI fill-in widgets show in FWD, when 4GL shows nothing

A simple integer on a frame becomes a fill-in widget with the default value showing. In 4GL, this is not a fill-in an... Roger Borrello

11:18 AM Bug #4619 (New): GUI fill-in widgets show in FWD, when 4GL shows nothing

Roger Borrello

11:11 AM Bug #4618: Default location of dialog box title is left justified instead of centered

The @uast/frame_title_color_default_values.p@ testcase shows that the dialog box has the title text left justified in... Roger Borrello

11:08 AM Bug #4618 (New): Default location of dialog box title is left justified instead of centered

Roger Borrello

10:32 AM Bug #4617: Number of GUI frames in default window differs from 4GL

Testcase related to #4393 reveals that FWD allows 5 frames on the default window, when 4GL only shows 4.
!GUI_fram... Roger Borrello

10:29 AM Bug #4617 (New): Number of GUI frames in default window differs from 4GL

Roger Borrello

04/16/2020

06:36 PM Feature #4394: add some frame options and attributes

Roger Borrello wrote:
> By updating @getFrameRow@ and @getFrameCol@ in @ThinClient.java@ to return a 0, if the frame... Hynek Cihlar

06:19 PM Feature #3876: add support for "direct font control" at the widget level

I added the required information in [[p2j:Font_Control_in_4GL_Widgets]] together with an example. I found a couple of... Hynek Cihlar

06:03 PM Feature #4393: add TITLE-DCOLOR attribute support

Regarding the menu tests, both GUI and ChUI result in the same attribute output.
However, there are different beha... Roger Borrello

04:40 PM Feature #4393: add TITLE-DCOLOR attribute support

These changes should complete the browse attributes and options.... Roger Borrello

02:34 PM Feature #4393: add TITLE-DCOLOR attribute support

Issue of the title bar missing was related to @annotations/sorting.rules@ where @DCOLOR@ was not included as criteria... Roger Borrello

01:49 PM Feature #4393: add TITLE-DCOLOR attribute support

It is not obviously on the client or server, we can't really know. But since it is drawing something and just missin... Greg Shah

11:37 AM Feature #4393: add TITLE-DCOLOR attribute support

Roger Borrello wrote:
> Another issue I am looking at. The browse title is missing, if @DCOLOR@ is part of the optio... Roger Borrello

10:59 AM Feature #4393: add TITLE-DCOLOR attribute support

Yes, I think so. Greg Shah

10:27 AM Feature #4393: add TITLE-DCOLOR attribute support

Greg Shah wrote:
> > I did not have good results with that flag, or I was using it incorrectly. However, the config.... Roger Borrello

11:20 AM Feature #4170: add drag and drop support to treeview widget

Investigating what issues need to be done for #4170-20 in item 2. Sergey Ivanovskiy

04/15/2020

02:21 PM Feature #4394: add some frame options and attributes

By updating @getFrameRow@ and @getFrameCol@ in @ThinClient.java@ to return a 0, if the frame is not visible, I get ma... Roger Borrello

12:11 PM Feature #4394: add some frame options and attributes

Roger Borrello wrote:
> Initial attribute values being returned for @frame-col@ and @frame-row@ are incorrect. They ... Roger Borrello

11:38 AM Feature #4394: add some frame options and attributes

Initial attribute values being returned for @frame-col@ and @frame-row@ are incorrect. They are coming from the clien... Roger Borrello

10:38 AM Feature #4394: add some frame options and attributes

We always must return BDT values from attribute getters. We never return @String@ instances. Greg Shah

10:22 AM Feature #4394: add some frame options and attributes

Greg Shah wrote:
> Right. So your existing code is not correct. I suspect that this is not the string @"?"@ but it... Roger Borrello

09:53 AM Feature #4394: add some frame options and attributes

Right. So your existing code is not correct. I suspect that this is not the string @"?"@ but it is just how the lan... Greg Shah

09:46 AM Feature #4394: add some frame options and attributes

Greg Shah wrote:
> Code Review Task Branch 4231b Revision 11446
>
> The only issue is the use of @new String()@ i... Roger Borrello

04/14/2020

02:38 PM Feature #4394: add some frame options and attributes

As someone wise once said: "The problem was a loose nut behind the wheel.". :)
Our current implementation assumes ... Greg Shah

02:35 PM Feature #4394: add some frame options and attributes

Roger Borrello wrote:
> Greg Shah wrote:
> > The @b4Frname.assign()@ is missing the @f0Frame.widgeti().getFrameName... Roger Borrello

02:07 PM Feature #4394: add some frame options and attributes

Greg Shah wrote:
> The @b4Frname.assign()@ is missing the @f0Frame.widgeti().getFrameName()@ argument.
>
> You'll... Roger Borrello

02:06 PM Feature #4394: add some frame options and attributes

We can't go on an 2 week effort to dig into this. It would be good to fix these as well. The issue is probably diffe... Greg Shah

12:53 PM Feature #4394: add some frame options and attributes

Roger Borrello wrote:
> Looking at more code emitted... would this be similar to why this code:
> [...]
> converts... Roger Borrello

12:26 PM Feature #4394: add some frame options and attributes

Greg Shah wrote:
> The @b4Frname.assign()@ is missing the @f0Frame.widgeti().getFrameName()@ argument.
>
> You'll... Roger Borrello

10:37 AM Feature #4394: add some frame options and attributes

Code Review Task Branch 4231b Revision 11446
The only issue is the use of @new String()@ in @GenericWidget.getFram... Greg Shah

10:30 AM Feature #4394: add some frame options and attributes

The @b4Frname.assign()@ is missing the @f0Frame.widgeti().getFrameName()@ argument.
You'll have to fix it. Most l... Greg Shah

10:21 AM Feature #4394: add some frame options and attributes

Current testcase has 2 of the same use of the @:frame-name@ attribute, with very different conversions:
# @assign b4... Roger Borrello

04/13/2020

05:28 PM Feature #4394: add some frame options and attributes

Code ready for review. Additional testcases being developed. Tested via @ON MOUSE-SELECT-CLICK@ of various widgets on... Roger Borrello

04:19 PM Feature #4394: add some frame options and attributes

> My assumptions is that there will need to be getter/setter support added in FrameInterface.java and FrameWidget.jav... Greg Shah

04:07 PM Feature #4394: add some frame options and attributes

Greg Shah wrote:
> Add support for:
>
> * @FRAME-NAME@ attribute (this is actually a generic widget attribute but... Roger Borrello

04/10/2020

06:23 PM Bug #4612: Fix ChUI browse drawing when the current row is out of the view

In a ChUI browse the current row can be out of the view. It is a rare case and I'm aware only of one case when this h... Stanislav Lomany

05:54 PM Bug #4612 (New): Fix ChUI browse drawing when the current row is out of the view

Stanislav Lomany

09:23 AM Feature #3876: add support for "direct font control" at the widget level

Greg Shah wrote:
> Please create a new task for that. We will defer work on it for now.
Done. Hynek Cihlar

09:13 AM Feature #3876: add support for "direct font control" at the widget level

Please create a new task for that. We will defer work on it for now. In the wiki page, explain the idea and link to... Greg Shah

09:12 AM Feature #3876: add support for "direct font control" at the widget level

Greg Shah wrote:
> > He could do this using the standard system tools. Or do you want to add other 4GL extensions th... Hynek Cihlar

09:07 AM Feature #3876: add support for "direct font control" at the widget level

> He could do this using the standard system tools. Or do you want to add other 4GL extensions that would allow this?... Greg Shah

09:00 AM Feature #3876: add support for "direct font control" at the widget level

Greg Shah wrote:
> I've just edited the "Font Control in 4GL Widgets":/projects/p2j/wiki/Font_Control_in_4GL_Widgets... Hynek Cihlar

08:16 AM Feature #3876: add support for "direct font control" at the widget level

I've just edited the "Font Control in 4GL Widgets":/projects/p2j/wiki/Font_Control_in_4GL_Widgets. Please review and... Greg Shah

09:21 AM Bug #4611: Implement a font enumeration Java API directly callable from legacy code

The motivation here is to provide a way to allow to enumerate available font faces in legacy code. That is FWD/4GL co... Hynek Cihlar

09:16 AM Bug #4611 (New): Implement a font enumeration Java API directly callable from legacy code

Hynek Cihlar

04/09/2020

02:24 PM Feature #4164: implement misc UI features (frame options, misc attributes)

As Constantin notes, you are telling the code to only have the frame positioned in @col 1 row 1@ because only the FIR... Greg Shah

01:05 PM Feature #4164: implement misc UI features (frame options, misc attributes)

Roger, the @AT COL ROW@ in the frame phrase (for DISPLAY) sets the frame's definition location, not at runtime.
To... Constantin Asofiei

01:01 PM Feature #4164: implement misc UI features (frame options, misc attributes)

New testcase has expanded my ability to validate values, but I'm not sure it's on the mark yet. I was expecting the f... Roger Borrello

04/08/2020

11:29 AM Feature #4394: add some frame options and attributes

The @frame-name@ is just a string, right? So you can do anything with it to see the value (e.g. @message widget:fram... Greg Shah

11:03 AM Feature #4394: add some frame options and attributes

I cannot find any useful documentation related to how @FRAME-NAME@ would be used in a testcase. Searching through our... Roger Borrello

09:05 AM Feature #4609: rework scrolling approach to use an cleaner, MVC design

For a customer-specific grid widget, Vladimir wrote an alternative MVC scrolling implementation. The details are doc... Greg Shah

09:02 AM Feature #4609 (New): rework scrolling approach to use an cleaner, MVC design

Greg Shah

04/06/2020

04:33 PM Feature #4164: implement misc UI features (frame options, misc attributes)

Greg Shah wrote:
> Make a list of the problems here and fix them.
>1. What do these return before the frame is real... Roger Borrello

04/03/2020

01:00 PM Feature #4164: implement misc UI features (frame options, misc attributes)

Make a list of the problems here and fix them. Greg Shah

12:33 PM Feature #4164: implement misc UI features (frame options, misc attributes)

I'll update, now that I (finally) understand. I do have some initial items, some not related to this testcase, but be... Roger Borrello

11:19 AM Feature #4164: implement misc UI features (frame options, misc attributes)

I think you should check the @FRAME-ROW(frame)@ builtin for all of the same case.
Make sure to test:
* What do ... Greg Shah

10:38 AM Feature #4164: implement misc UI features (frame options, misc attributes)

Greg Shah wrote:
> > That is not really correct, because the attribute is off the widget, in this case i.
>
> Pl... Roger Borrello

10:16 AM Feature #4164: implement misc UI features (frame options, misc attributes)

> That is not really correct, because the attribute is off the widget, in this case i.
Please read #4164-1 more c... Greg Shah

09:54 AM Feature #4164: implement misc UI features (frame options, misc attributes)

Greg Shah wrote:
> All you care about is positioning the frame in different locations.
That is not really corre... Roger Borrello

09:34 AM Feature #4164: implement misc UI features (frame options, misc attributes)

I had a testcase:... Roger Borrello

08:53 AM Feature #4164: implement misc UI features (frame options, misc attributes)

All you care about is positioning the frame in different locations. This is trivial to do in the AT phrase of the fr... Greg Shah

04/02/2020

05:40 PM Bug #4604: DCOLOR on FRAME or BROWSE TITLE phrase results in title not being displayed

Using @4231b-11418@:
Testcase @./uast/frame_title_color_default_values.p@ shows that @define frame@ with a title p... Roger Borrello

09:04 AM Bug #4604: DCOLOR on FRAME or BROWSE TITLE phrase results in title not being displayed

Please document the testcase and the trunk revision in which this can be recreated. Greg Shah

04/01/2020

06:54 PM Bug #4604 (New): DCOLOR on FRAME or BROWSE TITLE phrase results in title not being displayed

Roger Borrello

01:58 PM Feature #4393: add TITLE-DCOLOR attribute support

Yes, it could be a version difference. Run the testcases on both 10.x and 11.x and record the differences only. The... Greg Shah

12:22 PM Feature #4393: add TITLE-DCOLOR attribute support

I was re-running @frame_title_color_attributes.p@ to try to close this task down, and I was running on OE release 10.... Roger Borrello

10:53 AM Feature #4393: add TITLE-DCOLOR attribute support

h2. Browse TITLE Attribute Defaults (before/after realization)
|_. |_. ChUI (bef) |_. ChUI (aft) |_. GUI (... Roger Borrello

08:09 PM Feature #4393: add TITLE-DCOLOR attribute support

> Should I remove the comment: "For the browse options phrase, only the TITLE DCOLOR <num> "title" form can be used..... Greg Shah

03/31/2020

07:00 PM Feature #4393: add TITLE-DCOLOR attribute support

Made updates in Rev11413. I was attempting to get the title to appear when @DCOLOR@ was part of the title phrase. Thi... Roger Borrello

05:05 PM Feature #4393: add TITLE-DCOLOR attribute support

Greg Shah wrote:
> No, looking back on things they are all possible. I didn't update the comment in @frame_generato... Roger Borrello

04:02 PM Feature #4393: add TITLE-DCOLOR attribute support

No, looking back on things they are all possible. I didn't update the comment in @frame_generator.xml@ but the notes... Greg Shah

03:45 PM Feature #4393: add TITLE-DCOLOR attribute support

Greg Shah wrote:
> See the @gen_color@ in @frame_generator.xml@. It should only be generating code for @TITLE DCOLO... Roger Borrello

03:18 PM Feature #4393: add TITLE-DCOLOR attribute support

Not sure the @realized@ flag is correct.
See the @gen_color@ in @frame_generator.xml@. It should only be generati... Greg Shah

03:13 PM Feature #4393: add TITLE-DCOLOR attribute support

Greg Shah wrote:
> I guess you are referencing @testcases/uast/browse_title_color_options.p@. Options are not attri... Roger Borrello

03:12 PM Feature #4393: add TITLE-DCOLOR attribute support

Greg Shah wrote:
> What testcase are you using? The code in @testcases/uast/browse_title_color_attributes.p@ doesn'... Roger Borrello

03:11 PM Feature #4393: add TITLE-DCOLOR attribute support

I guess you are referencing @testcases/uast/browse_title_color_options.p@. Options are not attributes. The text abo... Greg Shah

02:46 PM Feature #4393: add TITLE-DCOLOR attribute support

What testcase are you using? The code in @testcases/uast/browse_title_color_attributes.p@ doesn't look anything like... Greg Shah

02:16 PM Feature #4393: add TITLE-DCOLOR attribute support

Another issue I am looking at. The browse title is missing, if @DCOLOR@ is part of the options:
!GUI_browse_title_... Roger Borrello

01:45 PM Feature #4393: add TITLE-DCOLOR attribute support

Greg Shah wrote:
> Be more specific. In which testscase and for which lines of code is this happening? GUI, ChUI? ... Roger Borrello

01:11 PM Feature #4393: add TITLE-DCOLOR attribute support

> I see the testcase in FWD displays 4052 in a popup for every browse widget.
Be more specific. In which testsca... Greg Shah

12:42 PM Feature #4393: add TITLE-DCOLOR attribute support

Done, but in my testing, I see the testcase in FWD displays 4052 in a popup for every browse widget. Either I need to... Roger Borrello

12:22 PM Feature #4393: add TITLE-DCOLOR attribute support

So @setTitleColor(ColorSpec)@ was just missing. My changes fixed the conversion, but you will need to add the runtim... Greg Shah

12:14 PM Feature #4393: add TITLE-DCOLOR attribute support

Greg Shah wrote:
> What happens in trunk?... Roger Borrello

12:07 PM Feature #4393: add TITLE-DCOLOR attribute support

> It looks like setTitleColor needs to be implemented. I have added it to BrowseWidget and I believe the interface is... Greg Shah

11:55 AM Feature #4393: add TITLE-DCOLOR attribute support

Compilation of the testcase:... Roger Borrello

11:52 AM Feature #4393: add TITLE-DCOLOR attribute support

Roger Borrello wrote:
> Converting the @browse_title_color_options.p@ testcase, @setTitleColor@ is unresolved. Did t... Greg Shah

11:43 AM Feature #4393: add TITLE-DCOLOR attribute support

Converting the @browse_title_color_options.p@ testcase, @setTitleColor@ is unresolved. Did that method ne get overloo... Roger Borrello

11:31 AM Feature #4393: add TITLE-DCOLOR attribute support

Code Review updates made:... Roger Borrello

10:55 AM Feature #4393: add TITLE-DCOLOR attribute support

Greg Shah wrote:
> For now, I'm just suggesting that you create a helper for @BrowseWidget@, so make common code ins... Roger Borrello

10:14 AM Feature #4393: add TITLE-DCOLOR attribute support

For now, I'm just suggesting that you create a helper for @BrowseWidget@, so make common code instead of the duplicat... Greg Shah

10:12 AM Feature #4393: add TITLE-DCOLOR attribute support

Greg Shah wrote:
> Anytime you are writing the same code over and over, you can make a helper. It is ALWAYS better ... Roger Borrello

09:52 AM Feature #4393: add TITLE-DCOLOR attribute support

Anytime you are writing the same code over and over, you can make a helper. It is ALWAYS better than copying the cod... Greg Shah

09:45 AM Feature #4393: add TITLE-DCOLOR attribute support

Greg Shah wrote:
> Code Review Task Branch 4231b Revision 11407
> 4. In @BrowseWidget@, you would have much less co... Roger Borrello

09:06 AM Feature #4393: add TITLE-DCOLOR attribute support

> Just to be sure... you want comments removed?
Yes.
> Isn't there any usefulness to tieing the keyword to the... Greg Shah

09:03 AM Feature #4393: add TITLE-DCOLOR attribute support

Greg Shah wrote:
> Code Review Task Branch 4231b Revision 11407
>
> 1. In @gaps/expressions.rules@, the @kw_tit*@... Roger Borrello

08:39 AM Feature #4393: add TITLE-DCOLOR attribute support

Code Review Task Branch 4231b Revision 11407
1. In @gaps/expressions.rules@, the @kw_tit*@ comments should be remo... Greg Shah

11:00 AM Feature #4394: add some frame options and attributes

@SCROLL@ and @NO-ATTR-SPACE@ will be finished in #4164. The only thing needed for this task is @FRAME-NAME@. Greg Shah

03/30/2020

04:14 PM Feature #4393: add TITLE-DCOLOR attribute support

Committed updates:... Roger Borrello

03:59 PM Feature #4393: add TITLE-DCOLOR attribute support

Roger Borrello wrote:
> Currently looking at why the @./uast/menu/menu_title_color_attributes.p@ testcase fails in *... Roger Borrello

03:21 PM Feature #4393: add TITLE-DCOLOR attribute support

Currently looking at why the @./uast/menu/menu_title_color_attributes.p@ testcase fails in *Core Code Conversion*:
<... Roger Borrello

02:17 PM Feature #4393: add TITLE-DCOLOR attribute support

Same issues occur with @trunk@. I'll focus on implementation, but these will prevent validation of the implementation... Roger Borrello

02:10 PM Feature #4393: add TITLE-DCOLOR attribute support

Greg Shah wrote:
> What do you mean by "build"? It parsed fine.
When I tried to convert the @./uast/browse_title... Roger Borrello

02:04 PM Feature #4393: add TITLE-DCOLOR attribute support

What do you mean by "build"? It parsed fine. Greg Shah

02:03 PM Feature #4393: add TITLE-DCOLOR attribute support

Suddenly that implementation seems secondary to an issue that came up when I tried to build @./uast/browse_title_colo... Roger Borrello

02:00 PM Feature #4393: add TITLE-DCOLOR attribute support

The frame definitions will use @setTitle*(long)@. It is possible for the attribute usage to convert this way too, un... Greg Shah

01:51 PM Feature #4393: add TITLE-DCOLOR attribute support

Doesn't the @int64@ interface to the converted 4GL? Perhaps that's what is confusing me. Is there a @long@ interface ... Roger Borrello

12:52 PM Feature #4393: add TITLE-DCOLOR attribute support

No.
> Just reverse the logic. The long version calls the wrapper version.
This means that @setTitleFgColor(... Greg Shah

12:25 PM Feature #4393: add TITLE-DCOLOR attribute support

I see the missing "new" in there. Roger Borrello

12:20 PM Feature #4393: add TITLE-DCOLOR attribute support

Greg Shah wrote:
> You did not reverse the logic.
Like this?... Roger Borrello

11:37 AM Feature #4393: add TITLE-DCOLOR attribute support

You did not reverse the logic. Greg Shah

11:23 AM Feature #4393: add TITLE-DCOLOR attribute support

Greg Shah wrote:
> Just reverse the logic. The @long@ version calls the wrapper version.
Can you review this imp... Roger Borrello

11:19 AM Feature #4393: add TITLE-DCOLOR attribute support

Just reverse the logic. The @long@ version calls the wrapper version. Greg Shah

10:49 AM Feature #4393: add TITLE-DCOLOR attribute support

The previous convention for the setters had the @int64@ versions calling the @long@ versions:... Roger Borrello

10:24 AM Feature #4393: add TITLE-DCOLOR attribute support

> For the cases where menu TITLE- attributes are actually handled (TITLE-BGCOLOR, TITLE-FGCOLOR and TITLE-FONT), but ... Greg Shah

10:07 AM Feature #4393: add TITLE-DCOLOR attribute support

For the cases where @menu TITLE-@ attributes are actually handled (TITLE-BGCOLOR, TITLE-FGCOLOR and TITLE-FONT), but ... Roger Borrello

09:20 AM Feature #4393: add TITLE-DCOLOR attribute support

Yes. Greg Shah

09:20 AM Feature #4393: add TITLE-DCOLOR attribute support

In @MenuWidget@, is it adequate to utilize @config.popupOnly@ to determine between popup and non-popup menus for the ... Roger Borrello

03/27/2020

06:53 PM Feature #4393: add TITLE-DCOLOR attribute support

Cleaned up and checked in:... Roger Borrello

05:48 PM Feature #4393: add TITLE-DCOLOR attribute support

> All the ChUI tests passed side-by-side, except for the fact that the color schemes seemed different. There were oft... Greg Shah

05:44 PM Feature #4393: add TITLE-DCOLOR attribute support

Remove all getters. Remove the @int64@ setters. Only the @long@ setters should be in either @CommonFrame@ or @Gener... Greg Shah

05:43 PM Feature #4393: add TITLE-DCOLOR attribute support

Roger Borrello wrote:
> Greg Shah wrote:
>
> > We need the @setTitle*(long)@ methods in @CommonFrame@. That is i... Greg Shah

05:42 PM Feature #4393: add TITLE-DCOLOR attribute support

Greg Shah wrote:
> We need the @setTitle*(long)@ methods in @CommonFrame@. That is it. Don't add the full @Title... Roger Borrello

05:22 PM Feature #4393: add TITLE-DCOLOR attribute support

I will go back and update per your last note. I was writing the below while you made your update:
All the ChUI tes... Roger Borrello

05:19 PM Feature #4393: add TITLE-DCOLOR attribute support

> Menus and Browse don't have the same complexity of the class structure, do they?
No, they don't.
> All the fr... Greg Shah

04:39 PM Feature #4393: add TITLE-DCOLOR attribute support

Roger Borrello wrote:
> The frames are CommonFrame, and trying to access the methods which aren't in that interface.... Roger Borrello

03:57 PM Feature #4393: add TITLE-DCOLOR attribute support

The frames are CommonFrame, and trying to access the methods which aren't in that interface.... Roger Borrello

03:45 PM Feature #4393: add TITLE-DCOLOR attribute support

Roger Borrello wrote:
> Updates for frames in *4231b-11400*.
Hold on... a couple more frame testcases to validate... Roger Borrello

03:41 PM Feature #4393: add TITLE-DCOLOR attribute support

Updates for frames in *4231b-11400*. Roger Borrello

03:26 PM Feature #4393: add TITLE-DCOLOR attribute support

Greg Shah wrote:
> Try @frame df:title-dcolor = 1@ instead of @3@ on line 208 of @testcases/uast/frame_title_color_a... Roger Borrello

03:22 PM Feature #4393: add TITLE-DCOLOR attribute support

Try @frame df:title-dcolor = 1@ instead of @3@ on line 208 of @testcases/uast/frame_title_color_attributes.p@. You s... Greg Shah

03:11 PM Feature #4393: add TITLE-DCOLOR attribute support

My previous note was stating the "current" state, so thank you for clarifying.
With respect to the ChUI testing, I... Roger Borrello

02:17 PM Feature #4393: add TITLE-DCOLOR attribute support

> TitiledElement - leave alone
Yes
> CommonFrame - currently an inteface that extends TitledElement. No getters... Greg Shah

01:51 PM Feature #4393: add TITLE-DCOLOR attribute support

Greg Shah wrote:
> Yes, I'm thinking that we leave the frame options in @CommonFrame@/@GenericFrame@. These are jus... Roger Borrello

09:56 AM Feature #4393: add TITLE-DCOLOR attribute support

Yes, I'm thinking that we leave the frame options in @CommonFrame@/@GenericFrame@. These are just the setters (@setT... Greg Shah

09:52 AM Feature #4393: add TITLE-DCOLOR attribute support

Greg Shah wrote:
> > Or, do you mean to convert frame f1:<widget/method> differently, and access the asWidget() meth... Constantin Asofiei

09:48 AM Feature #4393: add TITLE-DCOLOR attribute support

> Or, do you mean to convert frame f1:<widget/method> differently, and access the asWidget() method directly?
Yes,... Greg Shah

09:46 AM Feature #4393: add TITLE-DCOLOR attribute support

Greg Shah wrote:
> I was thinking about the dual nature, but I guess I got part of it backwards. If not present in ... Constantin Asofiei

09:39 AM Feature #4393: add TITLE-DCOLOR attribute support

I was thinking about the dual nature, but I guess I got part of it backwards. If not present in @widget_references.r... Greg Shah

09:25 AM Feature #4393: add TITLE-DCOLOR attribute support

Greg Shah wrote:
> Roger: If I'm right, then you would remove all the changes from @FrameWidget@ and just put them i... Constantin Asofiei

09:12 AM Feature #4393: add TITLE-DCOLOR attribute support

Roger: If I'm right, then you would remove all the changes from @FrameWidget@ and just put them in @GenericFrame@. Greg Shah

09:12 AM Feature #4393: add TITLE-DCOLOR attribute support

Code Review Task Branch 4231b Revision 11399
OK, you are close here.
Looking deeper at the changes in @widget_r... Greg Shah

03/26/2020

07:34 PM Feature #4393: add TITLE-DCOLOR attribute support

Roger Borrello wrote:
> Right now, the error message is being displayed, but the client is cycling in a loop, and no... Roger Borrello

07:06 PM Feature #4393: add TITLE-DCOLOR attribute support

Look at the Hotel ChUI @p2j.cfg.xml@ for clues. You can also add things to that project to test, though the regular ... Greg Shah

06:43 PM Feature #4393: add TITLE-DCOLOR attribute support

For the ChUI, what is the key to building it as-if using ChUI development, so that @&quot;{&amp;window-system}&quot; ... Roger Borrello

05:08 PM Feature #4393: add TITLE-DCOLOR attribute support

I have the @frame_title_color_attributes.p@ testcase working on GUI. There are some differences, between FWD and 4GL,... Roger Borrello

04:48 PM Feature #4393: add TITLE-DCOLOR attribute support

Correct. Greg Shah

04:34 PM Feature #4393: add TITLE-DCOLOR attribute support

In @common-progress.rules:read_only_attribute@ is included @prog.kw_titl_bgc@. I am going to remove this, since we ca... Roger Borrello

03:52 PM Feature #4393: add TITLE-DCOLOR attribute support

Nevermind. Found the sources to our @readOnlyError@. Roger Borrello

03:43 PM Feature #4393: add TITLE-DCOLOR attribute support

Greg Shah wrote:
> Figure out why the @getTitleFont()@ is converting differently than @getTitleBgColor()@. The font... Roger Borrello

02:59 PM Feature #4393: add TITLE-DCOLOR attribute support

Figure out why the @getTitleFont()@ is converting differently than @getTitleBgColor()@. The font is not converting t... Greg Shah

02:57 PM Feature #4393: add TITLE-DCOLOR attribute support

No, I don't think so. Greg Shah

02:56 PM Feature #4393: add TITLE-DCOLOR attribute support

Greg Shah wrote:
> Why would we want it to be @extends@?
I don't want to do that. I believe I need to add our get... Roger Borrello

02:38 PM Feature #4393: add TITLE-DCOLOR attribute support

Why would we want it to be @extends@? Greg Shah

02:23 PM Feature #4393: add TITLE-DCOLOR attribute support

Greg Shah wrote:
> Did you add it to @FrameWidget@?
ahh... @TitledElement@ is in there as @implements@, but not @... Roger Borrello

02:21 PM Feature #4393: add TITLE-DCOLOR attribute support

Did you add it to @FrameWidget@? Greg Shah

02:16 PM Feature #4393: add TITLE-DCOLOR attribute support

Greg Shah wrote:
> Remove it from @CommonFrame@.
When @extends TitledElement@ is removed from @CommonFrame@, the ... Roger Borrello

01:47 PM Feature #4393: add TITLE-DCOLOR attribute support

Greg Shah wrote:
> Feel free to fix your bugs.
LOL... nowhere did I add a 4052 warning... I'll find and fix, whoeve... Roger Borrello

01:06 PM Feature #4393: add TITLE-DCOLOR attribute support

Remove it from @CommonFrame@.
> Proceeding with the testcase, with all getters/setters in both GenericFrame and Fr... Greg Shah

12:46 PM Feature #4393: add TITLE-DCOLOR attribute support

Greg Shah wrote:
> @GenericFrame@ should not implement @TitledElement@, only implement in @FrameWidget@. You can st... Roger Borrello

12:04 PM Feature #4393: add TITLE-DCOLOR attribute support

@GenericFrame@ should not implement @TitledElement@, only implement in @FrameWidget@. You can still leave the setter... Greg Shah

11:23 AM Feature #4393: add TITLE-DCOLOR attribute support

Greg Shah wrote:
> > Where are the frame-options methods?
>
> That is the @setTitleColor(ColorSpec)@ (which you k... Roger Borrello

11:11 AM Feature #4393: add TITLE-DCOLOR attribute support

> Where are the frame-options methods?
That is the @setTitleColor(ColorSpec)@ (which you keep complaining about) w... Greg Shah

11:01 AM Feature #4393: add TITLE-DCOLOR attribute support

Greg Shah wrote:
> I forgot that we emit attributes using the @FrameWidget@ instead of direct access to the @Generic... Roger Borrello

10:48 AM Feature #4393: add TITLE-DCOLOR attribute support

I forgot that we emit attributes using the @FrameWidget@ instead of direct access to the @GenericFrame@ instance. Th... Greg Shah

10:38 AM Feature #4393: add TITLE-DCOLOR attribute support

Using this to ef with @titleDColor@:... Roger Borrello

09:05 AM Feature #4393: add TITLE-DCOLOR attribute support

> In setTitleColor(ColorSpec titleColor) on line 6860? That wasn't me... I mentioned how odd that method looked. Did ... Greg Shah

08:55 AM Feature #4393: add TITLE-DCOLOR attribute support

Greg Shah wrote:
> Code Review Task Branch 4231b Revision 11395
>
> The changes are moving the right direction.
... Roger Borrello

07:29 AM Feature #4393: add TITLE-DCOLOR attribute support

Code Review Task Branch 4231b Revision 11395
The changes are moving the right direction.
1. You've messed with ... Greg Shah

06:53 AM Feature #4393: add TITLE-DCOLOR attribute support

> Does this mean titleDColor is stored outside GenericFrame?
Yes.
As I said in #4393-20:
> Thus, only @conf... Greg Shah

09:45 PM Feature #4393: add TITLE-DCOLOR attribute support

Updates are buildable in revision 11395. Right now @GenericFrame@ is the only update without stubs. Please review... ... Roger Borrello

09:34 PM Feature #4393: add TITLE-DCOLOR attribute support

The documentation for Attributes:Frames for writing/assignment says...
_in ChUI:_
_before realization, all ... Roger Borrello

10:17 AM Feature #4164: implement misc UI features (frame options, misc attributes)

Branch 4231b revision 11395 includes @GenericFrame@ changes that complete @next-tab-item@ and @prev-tab-item@ per #41... Greg Shah

03/25/2020

03:42 PM Bug #4589: menu case sensitivity and conversion

> The current changes were checked with testcases/uast/menu tests that passed except 4 known cases:
Roger is worki... Greg Shah

03:33 PM Bug #4589: menu case sensitivity and conversion

The current changes were checked with @testcases/uast/menu@ tests that passed except 4 known cases:... Sergey Ivanovskiy

03:21 PM Bug #4589: menu case sensitivity and conversion

If everything is working so far and there are no regressions, then I am OK with it. Greg Shah

02:32 PM Bug #4589: menu case sensitivity and conversion

Greg, I compared the previous version and the current changes and found that this map used @submenu = names.convert(... Sergey Ivanovskiy

10:36 AM Bug #4589: menu case sensitivity and conversion

Code Review Task Branch 4231b Revision 11387
It seems wrong to use the javaname (even a lowercased one) as a key t... Greg Shah

08:13 AM Bug #4589: menu case sensitivity and conversion

Greg Shah wrote:
> This is not a problem with menu conversion. The skeletons should never be converted. They are s... Hynek Cihlar

08:13 AM Bug #4589: menu case sensitivity and conversion

Hynek Cihlar wrote:
> Sergey, I think I stepped on another error during <large_app> conversion caused by the menu ch... Hynek Cihlar

08:04 AM Bug #4589: menu case sensitivity and conversion

This is not a problem with menu conversion. The skeletons should never be converted. They are supposed to be exclud... Greg Shah

07:53 AM Bug #4589: menu case sensitivity and conversion

Sergey, I think I stepped on another error during <large_app> conversion caused by the menu changes.... Hynek Cihlar

03:20 PM Feature #4393: add TITLE-DCOLOR attribute support

Consider the following facts:
* The reason we store state in a separate config class (e.g. @BaseConfig@) is to hav... Greg Shah

02:41 PM Feature #4393: add TITLE-DCOLOR attribute support

Are @titleBGgColor@ and @titleFgColor@ attributes to be kept with @titleDColor@ and @titleFont@ in @BaseConfig@? Roger Borrello

01:45 PM Feature #4393: add TITLE-DCOLOR attribute support

> Yes I did, but in that method, it is setting frame.config.titleDColor instead of frame.config.titleColor.
There ... Greg Shah

01:34 PM Feature #4393: add TITLE-DCOLOR attribute support

Greg Shah wrote:
> Did you see this part in #4393-6:
>
> > @GenericFrame@: Add @getTitleDColor()@, @setTitleDColo... Roger Borrello

12:59 PM Feature #4393: add TITLE-DCOLOR attribute support

Did you see this part in #4393-6:
> @GenericFrame@: Add @getTitleDColor()@, @setTitleDColor(int64 dcolor)@, @setTi... Greg Shah

12:52 PM Feature #4393: add TITLE-DCOLOR attribute support

@GenericFrame@ had a method that looks a little broken:... Roger Borrello

11:45 AM Feature #4393: add TITLE-DCOLOR attribute support

Just implement what is in @TitledElement@. The @ColorSpec@ stuff is not related. Greg Shah

11:44 AM Feature #4393: add TITLE-DCOLOR attribute support

Should there be setters for *FG*, *BG*, and *D* which receive @(ColorSpec color)@? Or just @int64@ and @long@? Roger Borrello

11:21 AM Feature #4393: add TITLE-DCOLOR attribute support

Greg Shah wrote:
> It is recommended anytime you are:
>
> * implementing a method from an interface (which you ar... Roger Borrello

11:17 AM Feature #4393: add TITLE-DCOLOR attribute support

It is recommended anytime you are:
* implementing a method from an interface (which you are doing, right?) OR
* o... Greg Shah

10:58 AM Feature #4393: add TITLE-DCOLOR attribute support

I'm in @BrowseWidget@ and I see some methods with @&#64;Override@ annotation, and some without. What determines wheth... Roger Borrello

09:49 PM Feature #4393: add TITLE-DCOLOR attribute support

Just re-enable the warnings suppression. Greg Shah

03/24/2020

05:48 PM Feature #4393: add TITLE-DCOLOR attribute support

Is the below caused by commented out @options { generateAmbigWarnings = false; }@ ? Was that just for debug?... Roger Borrello

05:06 PM Feature #4393: add TITLE-DCOLOR attribute support

Attached are my incomplete changes for this task. The intention is to *finish the implementation of all the options ... Greg Shah

07:18 AM Bug #4589: menu case sensitivity and conversion

Sergey Ivanovskiy wrote:
> The AST of menu item in the assignment expression #4589-41 missed @<annotation datatype="... Sergey Ivanovskiy

06:07 AM Bug #4589: menu case sensitivity and conversion

The AST of menu item in the assignment expression #4589-41 missed @<annotation datatype="java.lang.String" key="in_wi... Sergey Ivanovskiy

05:37 AM Bug #4589: menu case sensitivity and conversion

This code... Sergey Ivanovskiy

05:12 AM Bug #4589: menu case sensitivity and conversion

The code is still needed to fix ACCELERATOR assignments for menu. I added new test case @test-accelerator-1.p@ into @... Sergey Ivanovskiy

03/23/2020

10:06 AM Bug #4598: define shared menu statement is converted using new name to reference the shared menu

This issue can be reproduced with @./menu/shared_new.p@ and @./menu/shared_use.p@ from the old @testcases/uast@ proje... Sergey Ivanovskiy

09:54 AM Bug #4598 (New): define shared menu statement is converted using new name to reference the shared...

Sergey Ivanovskiy

09:03 AM Bug #4589: menu case sensitivity and conversion

As long as the regression in the other customer's application is also fixed, then any remaining issues can be moved i... Greg Shah

08:53 AM Bug #4589: menu case sensitivity and conversion

I saw the Redmine entries about the regression, and I am grateful you found a better solution. The customer code stil... Roger Borrello

07:51 AM Bug #4589: menu case sensitivity and conversion

Roger Borrello wrote:
> I converted/compiled the customer code with your @4589_6.patch@ updates. Excellent! Did you ... Sergey Ivanovskiy

05:19 AM Bug #4589: menu case sensitivity and conversion

Hynek Cihlar wrote:
> Sergey Ivanovskiy wrote:
> > where @SharedUseMmMenu.class@ should be @SharedNewMmMenu.class@.... Sergey Ivanovskiy

03:55 AM Bug #4589: menu case sensitivity and conversion

Sergey Ivanovskiy wrote:
> where @SharedUseMmMenu.class@ should be @SharedNewMmMenu.class@. @SharedUseMmMenu.java@ i... Hynek Cihlar

03/20/2020

05:17 PM Feature #4164: implement misc UI features (frame options, misc attributes)

Please read the 4GL docs to see what the @FRAME-COL@ function is meant to do. It is the counterpart of @FRAME-ROW@ a... Greg Shah

11:10 AM Feature #4164: implement misc UI features (frame options, misc attributes)

This test is promising:
!frame_loc_attributes_get.png!
Code below. What else can I do to validate?... Roger Borrello

09:01 AM Feature #4164: implement misc UI features (frame options, misc attributes)

Stanislav Lomany wrote:
> Review rev 11377: Roger, you forgot to remove the array need for @eventDrawingBracket@. Yo... Roger Borrello

04:32 AM Feature #4164: implement misc UI features (frame options, misc attributes)

Review rev 11377: Roger, you forgot to remove the array need for @eventDrawingBracket@. You can just write @return br... Stanislav Lomany

03:50 PM Bug #4589: menu case sensitivity and conversion

I converted/compiled the customer code with your @4589_6.patch@ updates. Excellent! Did you remove all your debug @pr... Roger Borrello

03:30 PM Bug #4589: menu case sensitivity and conversion

Roger Borrello wrote:
> Are you getting a conversion error or runtime?
This is the menu generation issue for shared... Sergey Ivanovskiy

03:21 PM Bug #4589: menu case sensitivity and conversion

Committed revision 11381 (4231b) fixed case-insensitive issue for menu identifiers but the shared menu and labels iss... Sergey Ivanovskiy

03:01 PM Bug #4589: menu case sensitivity and conversion

Are you getting a conversion error or runtime?
I've made a change to the @shared_new.p@ to make is easier to run o... Roger Borrello

02:09 PM Bug #4589: menu case sensitivity and conversion

This diff @4589_6.patch@ fixed these tests (see #4589-28)... Sergey Ivanovskiy

01:44 PM Bug #4589: menu case sensitivity and conversion

I encountered a strange annotation generated for menu item... Sergey Ivanovskiy

11:10 AM Bug #4589: menu case sensitivity and conversion

These files... Sergey Ivanovskiy

09:20 AM Bug #4589: menu case sensitivity and conversion

It seems like you are getting close. Keep up the good work. If you need a hand on anything, please post. Roger Borrello

07:01 AM Bug #4589: menu case sensitivity and conversion

The following 3 types of exceptions were encountered with the last attached diff.
These tests... Sergey Ivanovskiy

01:57 AM Bug #4589: menu case sensitivity and conversion

Roger, the last changes fixed your test case but these changes to use low case identifier are not correct. There is a... Sergey Ivanovskiy