FWD » Core Development » User Interface

04/25/2020

10:41 AM Feature #4394: add some frame options and attributes

Code Review Task Branch 4231b Revisions 11483, 11486, 11487
The changes are good.
1. Please modify the @Generic... Greg Shah

04/24/2020

03:46 PM Bug #4627: CAN-QUERY incorrectly determines SCREEN-VALUE on a FRAME widget is queryable

Testcases:... Roger Borrello

03:42 PM Bug #4627 (New): CAN-QUERY incorrectly determines SCREEN-VALUE on a FRAME widget is queryable

Roger Borrello

03:40 PM Feature #4394: add some frame options and attributes

I have updated and my testcase passes. ... Roger Borrello

01:51 PM Feature #4394: add some frame options and attributes

Greg Shah wrote:
> > I suppose I could keep the 2nd parameter as the original name, and in the GenericFrame.coreInit... Constantin Asofiei

01:35 PM Feature #4394: add some frame options and attributes

> I suppose I could keep the 2nd parameter as the original name, and in the GenericFrame.coreInitialize method, perfo... Greg Shah

01:16 PM Feature #4394: add some frame options and attributes

Greg Shah wrote:
> Today, what is that 2nd parameter used for other than as the legacy name?
Two main things...
... Roger Borrello

12:48 PM Feature #4394: add some frame options and attributes

Today, what is that 2nd parameter used for other than as the legacy name? Greg Shah

12:47 PM Feature #4394: add some frame options and attributes

Greg Shah wrote:
> Is @FRAME-NAME()@ ready for review?
No... Is one of these a better choice than the other?
# A... Roger Borrello

11:48 AM Feature #4394: add some frame options and attributes

Is @FRAME-NAME()@ ready for review? Greg Shah

10:58 AM Feature #4394: add some frame options and attributes

Greg Shah wrote:
> Hint: I wonder if the 4GL returns (from @FRAME-NAME()@) the first frame name that is defined, the... Roger Borrello

10:08 AM Feature #4394: add some frame options and attributes

Hint: I wonder if the 4GL returns (from @FRAME-NAME()@) the first frame name that is defined, the last one that is de... Greg Shah

10:05 AM Feature #4394: add some frame options and attributes

I doubt that is a good idea. The original 4GL code allows specifying the name in any case when you refer to the fram... Greg Shah

09:57 AM Feature #4394: add some frame options and attributes

I was thinking of the ramifications of using the actual frame name as specified in the 4GL, instead of the lowercase ... Roger Borrello

06:12 AM Feature #4170: add drag and drop support to treeview widget

Thank you, it is clear now. It seems that this tree implementation from Microsoft TreeView Control 6.0 (SP6) from @ms... Sergey Ivanovskiy

04/23/2020

06:54 PM Feature #4394: add some frame options and attributes

Made changes in @frame_scoping.rules@ to create a "parallel" legacy name that is handled in the same manner as the fr... Roger Borrello

11:24 AM Feature #4394: add some frame options and attributes

Greg Shah wrote:
> Why mess around? Just store it before frame scoping occurs.
From what I know, it's pay-me-now... Roger Borrello

11:19 AM Feature #4394: add some frame options and attributes

Why mess around? Just store it before frame scoping occurs. Greg Shah

11:14 AM Feature #4394: add some frame options and attributes

About a year ago, Constantin made a specific update to @annotations/frame_scoping.rules@:... Roger Borrello

06:51 AM Feature #4170: add drag and drop support to treeview widget

Sergey Ivanovskiy wrote:
> Can I use these changes to add @COUNT@
> [...]
If the new alias works, it is only a h... Hynek Cihlar

04/22/2020

06:18 PM Feature #4394: add some frame options and attributes

Greg Shah wrote:
> OK, perhaps I need to clarify.
>
> @javaname@ is a converted Java name and will have been tran... Roger Borrello

06:09 PM Feature #4394: add some frame options and attributes

OK, perhaps I need to clarify.
@javaname@ is a converted Java name and will have been transformed to remove all th... Greg Shah

06:08 PM Feature #4394: add some frame options and attributes

Greg Shah wrote:
> No. Nein. Nyet. Non. Nee.
Tried updating that, and it looks like it should be using @name@. Ho... Roger Borrello

06:07 PM Feature #4394: add some frame options and attributes

No. Nein. Nyet. Non. Nee. Greg Shah

06:00 PM Feature #4394: add some frame options and attributes

Getting back to @FRAME-NAME@, it looks like @convert/frame_construction.rules@ retrieves the critical data using:
<p... Roger Borrello

04:50 PM Feature #4170: add drag and drop support to treeview widget

Can I use these changes to add @COUNT@... Sergey Ivanovskiy

02:51 PM Feature #4170: add drag and drop support to treeview widget

Sergey Ivanovskiy wrote:
> What 4GL create node methods are supported by TreeView FWD widget? I tried this code that... Hynek Cihlar

01:30 PM Feature #4170: add drag and drop support to treeview widget

Also I found that Progress 4GL COM Object Viewer returns incorrect signature for @Expand@ event of @ITreeViewEvents@ ... Sergey Ivanovskiy

12:21 PM Feature #4170: add drag and drop support to treeview widget

What 4GL create node methods are supported by TreeView FWD widget? I tried this code that works with 4GL... Sergey Ivanovskiy

03:45 PM Feature #4164: implement misc UI features (frame options, misc attributes)

When not using redirection, the testcase passes.... Roger Borrello

03:39 PM Feature #4164: implement misc UI features (frame options, misc attributes)

I also notice on the last frame (a dialog box) the @F2@ never is recognized in the @wait-for go of frame df0.@ I have... Roger Borrello

03:01 PM Feature #4164: implement misc UI features (frame options, misc attributes)

Constantin Asofiei wrote:
> Roger Borrello wrote:
> > I am using "output to..." to collect the output. I can try wi... Roger Borrello

02:42 PM Feature #4164: implement misc UI features (frame options, misc attributes)

Roger Borrello wrote:
> I am using "output to..." to collect the output. I can try without. However, I would think t... Constantin Asofiei

02:39 PM Feature #4164: implement misc UI features (frame options, misc attributes)

Constantin Asofiei wrote:
> Area you using streams in your tests, or the redirected terminal ( unnamed stream)? I... Roger Borrello

02:22 PM Feature #4164: implement misc UI features (frame options, misc attributes)

Roger Borrello wrote:
> During debug, I found that when the @visible@ flag is set prior to the frame being displayed... Constantin Asofiei

01:41 PM Feature #4164: implement misc UI features (frame options, misc attributes)

During debug, I found that when the @visible@ flag is set prior to the frame being displayed, the @getFrame(frameId)@... Roger Borrello

11:44 AM Feature #4164: implement misc UI features (frame options, misc attributes)

With respect to @FRAME-COL@ (and @FRAME-ROW@), I am debugging why these are incorrect when checked using this code:
... Roger Borrello

03:10 PM Bug #4625: Frame configuration not shared or synched back to the GUI frame on redirection

During debug, I found that when the @visible@ flag is set prior to the frame being displayed, the @getFrame(frameId)@... Roger Borrello

03:03 PM Bug #4625 (New): Frame configuration not shared or synched back to the GUI frame on redirection

Roger Borrello

02:46 PM Bug #4624: Fill-in: StringIndexOutOfBoundsException and other bugs

h1. Problem 1. Wrong END key action result
The code:... Vladimir Tsichevski

02:19 PM Bug #4624 (Closed): Fill-in: StringIndexOutOfBoundsException and other bugs

Vladimir Tsichevski

04/21/2020

06:34 PM Feature #4164: implement misc UI features (frame options, misc attributes)

Greg Shah wrote:
> 4335a revision 11428 adds conversion and server-side support for @EDITOR:AUTO-INDENT@. The clien... Roger Borrello

09:57 AM Feature #4164: implement misc UI features (frame options, misc attributes)

Roger Borrello wrote:
> Please confirm @editor:auto-indent@ already converts and just needs runtime support only (so... Greg Shah

09:26 AM Feature #4164: implement misc UI features (frame options, misc attributes)

Please confirm @editor:auto-indent@ already converts and just needs runtime support only (so I can bypass)? Roger Borrello

01:40 PM Feature #4170: add drag and drop support to treeview widget

I assume v6 is the correct one, but I do not know for sure. Greg Shah

01:06 PM Feature #4170: add drag and drop support to treeview widget

On my windows image I have two versions of a tree view control: Microsoft TreeView Control 6.0 (SP6) from @mscomctl.... Sergey Ivanovskiy

04/20/2020

02:49 PM Bug #4619: GUI fill-in widgets show in FWD, when 4GL shows nothing

The @message set@ case may not be related to this at all. Greg Shah

02:31 PM Bug #4619: GUI fill-in widgets show in FWD, when 4GL shows nothing

Would this be related to the variable factory itself, or the widgets? I had another testcase @uast/io/basic_redirecte... Roger Borrello

04:06 AM Feature #3876: add support for "direct font control" at the widget level

Sergey Ivanovskiy wrote:
> We have some functions that can return the metric size of a string from the driver, the S... Hynek Cihlar

02:32 AM Feature #3876: add support for "direct font control" at the widget level

Hynek Cihlar wrote:
> Sergey Ivanovskiy wrote:
> > It seems that these changes
> > [...]
> >
> > are not consi... Sergey Ivanovskiy

04/17/2020

06:39 PM Feature #4394 (WIP): add some frame options and attributes

Roger Borrello

06:38 PM Bug #4611: Implement a font enumeration Java API directly callable from legacy code

For Swing GUI, the fonts can be enumerated with:... Hynek Cihlar

06:36 PM Feature #4393: add TITLE-DCOLOR attribute support

Just _temporarily_ I updated to utilize the same method as @toMillis@.
By updating @directory.xml@:... Roger Borrello

02:03 PM Feature #4393: add TITLE-DCOLOR attribute support

With my proposed change, the code could be implemented with a simple check @EnvironmentOps.versionNumber() >= 11.3@. ... Greg Shah

01:38 PM Feature #4393: add TITLE-DCOLOR attribute support

Greg Shah wrote:
> Constantin: What was the code that you added recently which had to check the version numbers at r... Constantin Asofiei

12:43 PM Feature #4393: add TITLE-DCOLOR attribute support

We have @EnvironmentOps.versionWorker(long lvl)@ which can determine a version string for the 4GL version to which we... Greg Shah

11:56 AM Feature #4393 (WIP): add TITLE-DCOLOR attribute support

Roger Borrello

11:55 AM Feature #4393: add TITLE-DCOLOR attribute support

Greg Shah wrote:
> Yes, it could be a version difference. Run the testcases on both 10.x and 11.x and record the di... Roger Borrello

09:33 AM Feature #4393: add TITLE-DCOLOR attribute support

> Should these be pursued?
No. Create new tasks. Greg Shah

09:13 AM Feature #4393: add TITLE-DCOLOR attribute support

The @frame_title_color_default_values.p@ tests pass, however, there are a couple of differences.
# There is space in... Roger Borrello

08:48 AM Feature #4393: add TITLE-DCOLOR attribute support

Code Review Task Branch 4231b Revision 11463
The changes are good.
A minor code standards issue: split the foll... Greg Shah

07:07 AM Feature #4393: add TITLE-DCOLOR attribute support

> while in 4GL, it activates the button and an NPE exception is thrown:
This implies there is an NPE in the 4GL wh... Greg Shah

06:32 PM Feature #3876: add support for "direct font control" at the widget level

Hynek Cihlar wrote:
> but there were errors converting the method call returning String array. I tried to fix this a... Hynek Cihlar

04:56 PM Feature #3876: add support for "direct font control" at the widget level

Sergey Ivanovskiy wrote:
> It seems that these changes
> [...]
>
> are not consistent with @isFontInstalled@ us... Hynek Cihlar

03:44 PM Feature #3876: add support for "direct font control" at the widget level

It seems that these changes ... Sergey Ivanovskiy

11:28 AM Feature #3876: add support for "direct font control" at the widget level

Greg Shah wrote:
> Yes. When you designed the default freely licensed fonts for FWD, this included replacing the co... Eugenie Lyzenko

09:10 AM Feature #3876: add support for "direct font control" at the widget level

Yes. When you designed the default freely licensed fonts for FWD, this included replacing the common/standard bitmap... Greg Shah

09:00 AM Feature #3876: add support for "direct font control" at the widget level

Greg Shah wrote:
> The changes are good. I've made some additional tweaks.
>
> Eugenie: I'd like to include a li... Eugenie Lyzenko

07:39 AM Feature #3876: add support for "direct font control" at the widget level

The changes are good. I've made some additional tweaks.
Eugenie: I'd like to include a list of the commonly used ... Greg Shah

11:55 AM Bug #4619: GUI fill-in widgets show in FWD, when 4GL shows nothing

> In 4GL, this is not a fill-in and
I think you mean that it is an editable fill-in in FWD and not in the 4GL?
... Greg Shah

11:20 AM Bug #4619: GUI fill-in widgets show in FWD, when 4GL shows nothing

A simple integer on a frame becomes a fill-in widget with the default value showing. In 4GL, this is not a fill-in an... Roger Borrello

11:18 AM Bug #4619 (New): GUI fill-in widgets show in FWD, when 4GL shows nothing

Roger Borrello

11:11 AM Bug #4618: Default location of dialog box title is left justified instead of centered

The @uast/frame_title_color_default_values.p@ testcase shows that the dialog box has the title text left justified in... Roger Borrello

11:08 AM Bug #4618 (New): Default location of dialog box title is left justified instead of centered

Roger Borrello

10:32 AM Bug #4617: Number of GUI frames in default window differs from 4GL

Testcase related to #4393 reveals that FWD allows 5 frames on the default window, when 4GL only shows 4.
!GUI_fram... Roger Borrello

10:29 AM Bug #4617 (New): Number of GUI frames in default window differs from 4GL

Roger Borrello

04/16/2020

06:36 PM Feature #4394: add some frame options and attributes

Roger Borrello wrote:
> By updating @getFrameRow@ and @getFrameCol@ in @ThinClient.java@ to return a 0, if the frame... Hynek Cihlar

06:19 PM Feature #3876: add support for "direct font control" at the widget level

I added the required information in [[p2j:Font_Control_in_4GL_Widgets]] together with an example. I found a couple of... Hynek Cihlar

06:03 PM Feature #4393: add TITLE-DCOLOR attribute support

Regarding the menu tests, both GUI and ChUI result in the same attribute output.
However, there are different beha... Roger Borrello

04:40 PM Feature #4393: add TITLE-DCOLOR attribute support

These changes should complete the browse attributes and options.... Roger Borrello

02:34 PM Feature #4393: add TITLE-DCOLOR attribute support

Issue of the title bar missing was related to @annotations/sorting.rules@ where @DCOLOR@ was not included as criteria... Roger Borrello

01:49 PM Feature #4393: add TITLE-DCOLOR attribute support

It is not obviously on the client or server, we can't really know. But since it is drawing something and just missin... Greg Shah

11:37 AM Feature #4393: add TITLE-DCOLOR attribute support

Roger Borrello wrote:
> Another issue I am looking at. The browse title is missing, if @DCOLOR@ is part of the optio... Roger Borrello

10:59 AM Feature #4393: add TITLE-DCOLOR attribute support

Yes, I think so. Greg Shah

10:27 AM Feature #4393: add TITLE-DCOLOR attribute support

Greg Shah wrote:
> > I did not have good results with that flag, or I was using it incorrectly. However, the config.... Roger Borrello

11:20 AM Feature #4170: add drag and drop support to treeview widget

Investigating what issues need to be done for #4170-20 in item 2. Sergey Ivanovskiy

04/15/2020

02:21 PM Feature #4394: add some frame options and attributes

By updating @getFrameRow@ and @getFrameCol@ in @ThinClient.java@ to return a 0, if the frame is not visible, I get ma... Roger Borrello

12:11 PM Feature #4394: add some frame options and attributes

Roger Borrello wrote:
> Initial attribute values being returned for @frame-col@ and @frame-row@ are incorrect. They ... Roger Borrello

11:38 AM Feature #4394: add some frame options and attributes

Initial attribute values being returned for @frame-col@ and @frame-row@ are incorrect. They are coming from the clien... Roger Borrello

10:38 AM Feature #4394: add some frame options and attributes

We always must return BDT values from attribute getters. We never return @String@ instances. Greg Shah

10:22 AM Feature #4394: add some frame options and attributes

Greg Shah wrote:
> Right. So your existing code is not correct. I suspect that this is not the string @"?"@ but it... Roger Borrello

09:53 AM Feature #4394: add some frame options and attributes

Right. So your existing code is not correct. I suspect that this is not the string @"?"@ but it is just how the lan... Greg Shah

09:46 AM Feature #4394: add some frame options and attributes

Greg Shah wrote:
> Code Review Task Branch 4231b Revision 11446
>
> The only issue is the use of @new String()@ i... Roger Borrello

04/14/2020

02:38 PM Feature #4394: add some frame options and attributes

As someone wise once said: "The problem was a loose nut behind the wheel.". :)
Our current implementation assumes ... Greg Shah

02:35 PM Feature #4394: add some frame options and attributes

Roger Borrello wrote:
> Greg Shah wrote:
> > The @b4Frname.assign()@ is missing the @f0Frame.widgeti().getFrameName... Roger Borrello

02:07 PM Feature #4394: add some frame options and attributes

Greg Shah wrote:
> The @b4Frname.assign()@ is missing the @f0Frame.widgeti().getFrameName()@ argument.
>
> You'll... Roger Borrello

02:06 PM Feature #4394: add some frame options and attributes

We can't go on an 2 week effort to dig into this. It would be good to fix these as well. The issue is probably diffe... Greg Shah

12:53 PM Feature #4394: add some frame options and attributes

Roger Borrello wrote:
> Looking at more code emitted... would this be similar to why this code:
> [...]
> converts... Roger Borrello

12:26 PM Feature #4394: add some frame options and attributes

Greg Shah wrote:
> The @b4Frname.assign()@ is missing the @f0Frame.widgeti().getFrameName()@ argument.
>
> You'll... Roger Borrello

10:37 AM Feature #4394: add some frame options and attributes

Code Review Task Branch 4231b Revision 11446
The only issue is the use of @new String()@ in @GenericWidget.getFram... Greg Shah

10:30 AM Feature #4394: add some frame options and attributes

The @b4Frname.assign()@ is missing the @f0Frame.widgeti().getFrameName()@ argument.
You'll have to fix it. Most l... Greg Shah

10:21 AM Feature #4394: add some frame options and attributes

Current testcase has 2 of the same use of the @:frame-name@ attribute, with very different conversions:
# @assign b4... Roger Borrello

04/13/2020

05:28 PM Feature #4394: add some frame options and attributes

Code ready for review. Additional testcases being developed. Tested via @ON MOUSE-SELECT-CLICK@ of various widgets on... Roger Borrello

04:19 PM Feature #4394: add some frame options and attributes

> My assumptions is that there will need to be getter/setter support added in FrameInterface.java and FrameWidget.jav... Greg Shah

04:07 PM Feature #4394: add some frame options and attributes

Greg Shah wrote:
> Add support for:
>
> * @FRAME-NAME@ attribute (this is actually a generic widget attribute but... Roger Borrello

04/10/2020

06:23 PM Bug #4612: Fix ChUI browse drawing when the current row is out of the view

In a ChUI browse the current row can be out of the view. It is a rare case and I'm aware only of one case when this h... Stanislav Lomany

05:54 PM Bug #4612 (New): Fix ChUI browse drawing when the current row is out of the view

Stanislav Lomany

09:23 AM Feature #3876: add support for "direct font control" at the widget level

Greg Shah wrote:
> Please create a new task for that. We will defer work on it for now.
Done. Hynek Cihlar

09:13 AM Feature #3876: add support for "direct font control" at the widget level

Please create a new task for that. We will defer work on it for now. In the wiki page, explain the idea and link to... Greg Shah

09:12 AM Feature #3876: add support for "direct font control" at the widget level

Greg Shah wrote:
> > He could do this using the standard system tools. Or do you want to add other 4GL extensions th... Hynek Cihlar

09:07 AM Feature #3876: add support for "direct font control" at the widget level

> He could do this using the standard system tools. Or do you want to add other 4GL extensions that would allow this?... Greg Shah

09:00 AM Feature #3876: add support for "direct font control" at the widget level

Greg Shah wrote:
> I've just edited the "Font Control in 4GL Widgets":/projects/p2j/wiki/Font_Control_in_4GL_Widgets... Hynek Cihlar

08:16 AM Feature #3876: add support for "direct font control" at the widget level

I've just edited the "Font Control in 4GL Widgets":/projects/p2j/wiki/Font_Control_in_4GL_Widgets. Please review and... Greg Shah

09:21 AM Bug #4611: Implement a font enumeration Java API directly callable from legacy code

The motivation here is to provide a way to allow to enumerate available font faces in legacy code. That is FWD/4GL co... Hynek Cihlar

09:16 AM Bug #4611 (New): Implement a font enumeration Java API directly callable from legacy code

Hynek Cihlar

04/09/2020

02:24 PM Feature #4164: implement misc UI features (frame options, misc attributes)

As Constantin notes, you are telling the code to only have the frame positioned in @col 1 row 1@ because only the FIR... Greg Shah

01:05 PM Feature #4164: implement misc UI features (frame options, misc attributes)

Roger, the @AT COL ROW@ in the frame phrase (for DISPLAY) sets the frame's definition location, not at runtime.
To... Constantin Asofiei

01:01 PM Feature #4164: implement misc UI features (frame options, misc attributes)

New testcase has expanded my ability to validate values, but I'm not sure it's on the mark yet. I was expecting the f... Roger Borrello

04/08/2020

11:29 AM Feature #4394: add some frame options and attributes

The @frame-name@ is just a string, right? So you can do anything with it to see the value (e.g. @message widget:fram... Greg Shah

11:03 AM Feature #4394: add some frame options and attributes

I cannot find any useful documentation related to how @FRAME-NAME@ would be used in a testcase. Searching through our... Roger Borrello

09:05 AM Feature #4609: rework scrolling approach to use an cleaner, MVC design

For a customer-specific grid widget, Vladimir wrote an alternative MVC scrolling implementation. The details are doc... Greg Shah

09:02 AM Feature #4609 (New): rework scrolling approach to use an cleaner, MVC design

Greg Shah

04/06/2020

04:33 PM Feature #4164: implement misc UI features (frame options, misc attributes)

Greg Shah wrote:
> Make a list of the problems here and fix them.
>1. What do these return before the frame is real... Roger Borrello

04/03/2020

01:00 PM Feature #4164: implement misc UI features (frame options, misc attributes)

Make a list of the problems here and fix them. Greg Shah

12:33 PM Feature #4164: implement misc UI features (frame options, misc attributes)

I'll update, now that I (finally) understand. I do have some initial items, some not related to this testcase, but be... Roger Borrello

11:19 AM Feature #4164: implement misc UI features (frame options, misc attributes)

I think you should check the @FRAME-ROW(frame)@ builtin for all of the same case.
Make sure to test:
* What do ... Greg Shah

10:38 AM Feature #4164: implement misc UI features (frame options, misc attributes)

Greg Shah wrote:
> > That is not really correct, because the attribute is off the widget, in this case i.
>
> Pl... Roger Borrello

10:16 AM Feature #4164: implement misc UI features (frame options, misc attributes)

> That is not really correct, because the attribute is off the widget, in this case i.
Please read #4164-1 more c... Greg Shah

09:54 AM Feature #4164: implement misc UI features (frame options, misc attributes)

Greg Shah wrote:
> All you care about is positioning the frame in different locations.
That is not really corre... Roger Borrello

09:34 AM Feature #4164: implement misc UI features (frame options, misc attributes)

I had a testcase:... Roger Borrello

08:53 AM Feature #4164: implement misc UI features (frame options, misc attributes)

All you care about is positioning the frame in different locations. This is trivial to do in the AT phrase of the fr... Greg Shah

04/02/2020

05:40 PM Bug #4604: DCOLOR on FRAME or BROWSE TITLE phrase results in title not being displayed

Using @4231b-11418@:
Testcase @./uast/frame_title_color_default_values.p@ shows that @define frame@ with a title p... Roger Borrello

09:04 AM Bug #4604: DCOLOR on FRAME or BROWSE TITLE phrase results in title not being displayed

Please document the testcase and the trunk revision in which this can be recreated. Greg Shah

04/01/2020

06:54 PM Bug #4604 (New): DCOLOR on FRAME or BROWSE TITLE phrase results in title not being displayed

Roger Borrello

01:58 PM Feature #4393: add TITLE-DCOLOR attribute support

Yes, it could be a version difference. Run the testcases on both 10.x and 11.x and record the differences only. The... Greg Shah

12:22 PM Feature #4393: add TITLE-DCOLOR attribute support

I was re-running @frame_title_color_attributes.p@ to try to close this task down, and I was running on OE release 10.... Roger Borrello

10:53 AM Feature #4393: add TITLE-DCOLOR attribute support

h2. Browse TITLE Attribute Defaults (before/after realization)
|_. |_. ChUI (bef) |_. ChUI (aft) |_. GUI (... Roger Borrello

08:09 PM Feature #4393: add TITLE-DCOLOR attribute support

> Should I remove the comment: "For the browse options phrase, only the TITLE DCOLOR <num> "title" form can be used..... Greg Shah

03/31/2020

07:00 PM Feature #4393: add TITLE-DCOLOR attribute support

Made updates in Rev11413. I was attempting to get the title to appear when @DCOLOR@ was part of the title phrase. Thi... Roger Borrello

05:05 PM Feature #4393: add TITLE-DCOLOR attribute support

Greg Shah wrote:
> No, looking back on things they are all possible. I didn't update the comment in @frame_generato... Roger Borrello

04:02 PM Feature #4393: add TITLE-DCOLOR attribute support

No, looking back on things they are all possible. I didn't update the comment in @frame_generator.xml@ but the notes... Greg Shah

03:45 PM Feature #4393: add TITLE-DCOLOR attribute support

Greg Shah wrote:
> See the @gen_color@ in @frame_generator.xml@. It should only be generating code for @TITLE DCOLO... Roger Borrello

03:18 PM Feature #4393: add TITLE-DCOLOR attribute support

Not sure the @realized@ flag is correct.
See the @gen_color@ in @frame_generator.xml@. It should only be generati... Greg Shah

03:13 PM Feature #4393: add TITLE-DCOLOR attribute support

Greg Shah wrote:
> I guess you are referencing @testcases/uast/browse_title_color_options.p@. Options are not attri... Roger Borrello

03:12 PM Feature #4393: add TITLE-DCOLOR attribute support

Greg Shah wrote:
> What testcase are you using? The code in @testcases/uast/browse_title_color_attributes.p@ doesn'... Roger Borrello

03:11 PM Feature #4393: add TITLE-DCOLOR attribute support

I guess you are referencing @testcases/uast/browse_title_color_options.p@. Options are not attributes. The text abo... Greg Shah

02:46 PM Feature #4393: add TITLE-DCOLOR attribute support

What testcase are you using? The code in @testcases/uast/browse_title_color_attributes.p@ doesn't look anything like... Greg Shah

02:16 PM Feature #4393: add TITLE-DCOLOR attribute support

Another issue I am looking at. The browse title is missing, if @DCOLOR@ is part of the options:
!GUI_browse_title_... Roger Borrello

01:45 PM Feature #4393: add TITLE-DCOLOR attribute support

Greg Shah wrote:
> Be more specific. In which testscase and for which lines of code is this happening? GUI, ChUI? ... Roger Borrello

01:11 PM Feature #4393: add TITLE-DCOLOR attribute support

> I see the testcase in FWD displays 4052 in a popup for every browse widget.
Be more specific. In which testsca... Greg Shah

12:42 PM Feature #4393: add TITLE-DCOLOR attribute support

Done, but in my testing, I see the testcase in FWD displays 4052 in a popup for every browse widget. Either I need to... Roger Borrello

12:22 PM Feature #4393: add TITLE-DCOLOR attribute support

So @setTitleColor(ColorSpec)@ was just missing. My changes fixed the conversion, but you will need to add the runtim... Greg Shah

12:14 PM Feature #4393: add TITLE-DCOLOR attribute support

Greg Shah wrote:
> What happens in trunk?... Roger Borrello

12:07 PM Feature #4393: add TITLE-DCOLOR attribute support

> It looks like setTitleColor needs to be implemented. I have added it to BrowseWidget and I believe the interface is... Greg Shah

11:55 AM Feature #4393: add TITLE-DCOLOR attribute support

Compilation of the testcase:... Roger Borrello

11:52 AM Feature #4393: add TITLE-DCOLOR attribute support

Roger Borrello wrote:
> Converting the @browse_title_color_options.p@ testcase, @setTitleColor@ is unresolved. Did t... Greg Shah

11:43 AM Feature #4393: add TITLE-DCOLOR attribute support

Converting the @browse_title_color_options.p@ testcase, @setTitleColor@ is unresolved. Did that method ne get overloo... Roger Borrello

11:31 AM Feature #4393: add TITLE-DCOLOR attribute support

Code Review updates made:... Roger Borrello

10:55 AM Feature #4393: add TITLE-DCOLOR attribute support

Greg Shah wrote:
> For now, I'm just suggesting that you create a helper for @BrowseWidget@, so make common code ins... Roger Borrello

10:14 AM Feature #4393: add TITLE-DCOLOR attribute support

For now, I'm just suggesting that you create a helper for @BrowseWidget@, so make common code instead of the duplicat... Greg Shah

10:12 AM Feature #4393: add TITLE-DCOLOR attribute support

Greg Shah wrote:
> Anytime you are writing the same code over and over, you can make a helper. It is ALWAYS better ... Roger Borrello

09:52 AM Feature #4393: add TITLE-DCOLOR attribute support

Anytime you are writing the same code over and over, you can make a helper. It is ALWAYS better than copying the cod... Greg Shah

09:45 AM Feature #4393: add TITLE-DCOLOR attribute support

Greg Shah wrote:
> Code Review Task Branch 4231b Revision 11407
> 4. In @BrowseWidget@, you would have much less co... Roger Borrello

09:06 AM Feature #4393: add TITLE-DCOLOR attribute support

> Just to be sure... you want comments removed?
Yes.
> Isn't there any usefulness to tieing the keyword to the... Greg Shah

09:03 AM Feature #4393: add TITLE-DCOLOR attribute support

Greg Shah wrote:
> Code Review Task Branch 4231b Revision 11407
>
> 1. In @gaps/expressions.rules@, the @kw_tit*@... Roger Borrello

08:39 AM Feature #4393: add TITLE-DCOLOR attribute support

Code Review Task Branch 4231b Revision 11407
1. In @gaps/expressions.rules@, the @kw_tit*@ comments should be remo... Greg Shah

11:00 AM Feature #4394: add some frame options and attributes

@SCROLL@ and @NO-ATTR-SPACE@ will be finished in #4164. The only thing needed for this task is @FRAME-NAME@. Greg Shah

03/30/2020

04:14 PM Feature #4393: add TITLE-DCOLOR attribute support

Committed updates:... Roger Borrello

03:59 PM Feature #4393: add TITLE-DCOLOR attribute support

Roger Borrello wrote:
> Currently looking at why the @./uast/menu/menu_title_color_attributes.p@ testcase fails in *... Roger Borrello

03:21 PM Feature #4393: add TITLE-DCOLOR attribute support

Currently looking at why the @./uast/menu/menu_title_color_attributes.p@ testcase fails in *Core Code Conversion*:
<... Roger Borrello

02:17 PM Feature #4393: add TITLE-DCOLOR attribute support

Same issues occur with @trunk@. I'll focus on implementation, but these will prevent validation of the implementation... Roger Borrello

02:10 PM Feature #4393: add TITLE-DCOLOR attribute support

Greg Shah wrote:
> What do you mean by "build"? It parsed fine.
When I tried to convert the @./uast/browse_title... Roger Borrello

02:04 PM Feature #4393: add TITLE-DCOLOR attribute support

What do you mean by "build"? It parsed fine. Greg Shah

02:03 PM Feature #4393: add TITLE-DCOLOR attribute support

Suddenly that implementation seems secondary to an issue that came up when I tried to build @./uast/browse_title_colo... Roger Borrello

02:00 PM Feature #4393: add TITLE-DCOLOR attribute support

The frame definitions will use @setTitle*(long)@. It is possible for the attribute usage to convert this way too, un... Greg Shah

01:51 PM Feature #4393: add TITLE-DCOLOR attribute support

Doesn't the @int64@ interface to the converted 4GL? Perhaps that's what is confusing me. Is there a @long@ interface ... Roger Borrello

12:52 PM Feature #4393: add TITLE-DCOLOR attribute support

No.
> Just reverse the logic. The long version calls the wrapper version.
This means that @setTitleFgColor(... Greg Shah

12:25 PM Feature #4393: add TITLE-DCOLOR attribute support

I see the missing "new" in there. Roger Borrello

12:20 PM Feature #4393: add TITLE-DCOLOR attribute support

Greg Shah wrote:
> You did not reverse the logic.
Like this?... Roger Borrello

11:37 AM Feature #4393: add TITLE-DCOLOR attribute support

You did not reverse the logic. Greg Shah

11:23 AM Feature #4393: add TITLE-DCOLOR attribute support

Greg Shah wrote:
> Just reverse the logic. The @long@ version calls the wrapper version.
Can you review this imp... Roger Borrello

11:19 AM Feature #4393: add TITLE-DCOLOR attribute support

Just reverse the logic. The @long@ version calls the wrapper version. Greg Shah

10:49 AM Feature #4393: add TITLE-DCOLOR attribute support

The previous convention for the setters had the @int64@ versions calling the @long@ versions:... Roger Borrello

10:24 AM Feature #4393: add TITLE-DCOLOR attribute support

> For the cases where menu TITLE- attributes are actually handled (TITLE-BGCOLOR, TITLE-FGCOLOR and TITLE-FONT), but ... Greg Shah

10:07 AM Feature #4393: add TITLE-DCOLOR attribute support

For the cases where @menu TITLE-@ attributes are actually handled (TITLE-BGCOLOR, TITLE-FGCOLOR and TITLE-FONT), but ... Roger Borrello

09:20 AM Feature #4393: add TITLE-DCOLOR attribute support

Yes. Greg Shah

09:20 AM Feature #4393: add TITLE-DCOLOR attribute support

In @MenuWidget@, is it adequate to utilize @config.popupOnly@ to determine between popup and non-popup menus for the ... Roger Borrello

03/27/2020

06:53 PM Feature #4393: add TITLE-DCOLOR attribute support

Cleaned up and checked in:... Roger Borrello

05:48 PM Feature #4393: add TITLE-DCOLOR attribute support

> All the ChUI tests passed side-by-side, except for the fact that the color schemes seemed different. There were oft... Greg Shah

05:44 PM Feature #4393: add TITLE-DCOLOR attribute support

Remove all getters. Remove the @int64@ setters. Only the @long@ setters should be in either @CommonFrame@ or @Gener... Greg Shah

05:43 PM Feature #4393: add TITLE-DCOLOR attribute support

Roger Borrello wrote:
> Greg Shah wrote:
>
> > We need the @setTitle*(long)@ methods in @CommonFrame@. That is i... Greg Shah

05:42 PM Feature #4393: add TITLE-DCOLOR attribute support

Greg Shah wrote:
> We need the @setTitle*(long)@ methods in @CommonFrame@. That is it. Don't add the full @Title... Roger Borrello

05:22 PM Feature #4393: add TITLE-DCOLOR attribute support

I will go back and update per your last note. I was writing the below while you made your update:
All the ChUI tes... Roger Borrello

05:19 PM Feature #4393: add TITLE-DCOLOR attribute support

> Menus and Browse don't have the same complexity of the class structure, do they?
No, they don't.
> All the fr... Greg Shah

04:39 PM Feature #4393: add TITLE-DCOLOR attribute support

Roger Borrello wrote:
> The frames are CommonFrame, and trying to access the methods which aren't in that interface.... Roger Borrello

03:57 PM Feature #4393: add TITLE-DCOLOR attribute support

The frames are CommonFrame, and trying to access the methods which aren't in that interface.... Roger Borrello

03:45 PM Feature #4393: add TITLE-DCOLOR attribute support

Roger Borrello wrote:
> Updates for frames in *4231b-11400*.
Hold on... a couple more frame testcases to validate... Roger Borrello

03:41 PM Feature #4393: add TITLE-DCOLOR attribute support

Updates for frames in *4231b-11400*. Roger Borrello

03:26 PM Feature #4393: add TITLE-DCOLOR attribute support

Greg Shah wrote:
> Try @frame df:title-dcolor = 1@ instead of @3@ on line 208 of @testcases/uast/frame_title_color_a... Roger Borrello

03:22 PM Feature #4393: add TITLE-DCOLOR attribute support

Try @frame df:title-dcolor = 1@ instead of @3@ on line 208 of @testcases/uast/frame_title_color_attributes.p@. You s... Greg Shah

03:11 PM Feature #4393: add TITLE-DCOLOR attribute support

My previous note was stating the "current" state, so thank you for clarifying.
With respect to the ChUI testing, I... Roger Borrello

02:17 PM Feature #4393: add TITLE-DCOLOR attribute support

> TitiledElement - leave alone
Yes
> CommonFrame - currently an inteface that extends TitledElement. No getters... Greg Shah

01:51 PM Feature #4393: add TITLE-DCOLOR attribute support

Greg Shah wrote:
> Yes, I'm thinking that we leave the frame options in @CommonFrame@/@GenericFrame@. These are jus... Roger Borrello

09:56 AM Feature #4393: add TITLE-DCOLOR attribute support

Yes, I'm thinking that we leave the frame options in @CommonFrame@/@GenericFrame@. These are just the setters (@setT... Greg Shah

09:52 AM Feature #4393: add TITLE-DCOLOR attribute support

Greg Shah wrote:
> > Or, do you mean to convert frame f1:<widget/method> differently, and access the asWidget() meth... Constantin Asofiei

09:48 AM Feature #4393: add TITLE-DCOLOR attribute support

> Or, do you mean to convert frame f1:<widget/method> differently, and access the asWidget() method directly?
Yes,... Greg Shah

09:46 AM Feature #4393: add TITLE-DCOLOR attribute support

Greg Shah wrote:
> I was thinking about the dual nature, but I guess I got part of it backwards. If not present in ... Constantin Asofiei

09:39 AM Feature #4393: add TITLE-DCOLOR attribute support

I was thinking about the dual nature, but I guess I got part of it backwards. If not present in @widget_references.r... Greg Shah

09:25 AM Feature #4393: add TITLE-DCOLOR attribute support

Greg Shah wrote:
> Roger: If I'm right, then you would remove all the changes from @FrameWidget@ and just put them i... Constantin Asofiei

09:12 AM Feature #4393: add TITLE-DCOLOR attribute support

Roger: If I'm right, then you would remove all the changes from @FrameWidget@ and just put them in @GenericFrame@. Greg Shah

09:12 AM Feature #4393: add TITLE-DCOLOR attribute support

Code Review Task Branch 4231b Revision 11399
OK, you are close here.
Looking deeper at the changes in @widget_r... Greg Shah