FWD » Core Development » User Interface

05/07/2020

05:02 PM Feature #3880: enhanced browse 3rd phase of improvements

> *** This should support values of @LEFT@, @RIGHT@ and @CENTER@.
For CENTER-align columns in editing mode, I thin... Stanislav Lomany

02:50 PM Feature #4170: add drag and drop support to treeview widget

The committed rev 11534(4231b) extracted the control frame name from the ActiveX event procedure name and then used i... Sergey Ivanovskiy

02:19 PM Bug #4636: Make the Theme API independent on concrete implementation classes

Sergey Ivanovskiy wrote:
> As this part starts its changes, does it make sense to use container classes to gather co... Vladimir Tsichevski

02:09 PM Bug #4636: Make the Theme API independent on concrete implementation classes

As this part starts its changes, does it make sense to use container classes to gather common parameters for these me... Sergey Ivanovskiy

10:00 AM Bug #4636: Make the Theme API independent on concrete implementation classes

The @drawButton()@ method signature has been changed: a ButtonGuiImpl instance is not required anymore for this metho... Vladimir Tsichevski

05/06/2020

02:51 PM Bug #4636: Make the Theme API independent on concrete implementation classes

Below is the first draft of the list of candidates for API change. Note: some of these calls, like Browser-related, a... Vladimir Tsichevski

09:12 AM Bug #4636 (WIP): Make the Theme API independent on concrete implementation classes

Vladimir Tsichevski

09:09 AM Bug #4636: Make the Theme API independent on concrete implementation classes

h1. The problem
By its nature and goal, the FWD GUI Themes shall be an independent drawing primitives library. All... Vladimir Tsichevski

08:24 AM Bug #4636 (WIP): Make the Theme API independent on concrete implementation classes

Vladimir Tsichevski

12:46 PM Feature #4170: add drag and drop support to treeview widget

Hynek Cihlar wrote:
> Sergey Ivanovskiy wrote:
> > Are there another ways to get target widget type when annotation... Sergey Ivanovskiy

09:51 AM Feature #4170: add drag and drop support to treeview widget

Sergey Ivanovskiy wrote:
> Are there another ways to get target widget type when annotation rules are processed?
... Hynek Cihlar

08:05 AM Feature #4170: add drag and drop support to treeview widget

Please review the committed revision 11526 (4231b) that added COM-SELF conversion with this hint file... Sergey Ivanovskiy

09:29 AM Feature #3880: enhanced browse 3rd phase of improvements

Stanislav Lomany wrote:
> > Provide a 4GL syntax option to disable user-controlled sorting for that specific browse ... Greg Shah

05/05/2020

01:17 PM Feature #3880: enhanced browse 3rd phase of improvements

> Provide a 4GL syntax option to disable user-controlled sorting for that specific browse instance.
Turns out we a... Stanislav Lomany

11:39 AM Feature #4170: add drag and drop support to treeview widget

I used these changes now with this hint... Sergey Ivanovskiy

11:27 AM Feature #4170: add drag and drop support to treeview widget

Hynek Cihlar wrote:
> Sergey Ivanovskiy wrote:
> > will be converted into this java expression @self().unwrapTreeFa... Sergey Ivanovskiy

06:23 AM Feature #4170: add drag and drop support to treeview widget

Sergey Ivanovskiy wrote:
> will be converted into this java expression @self().unwrapTreeFace().getNodes().getCount(... Hynek Cihlar

04:49 AM Feature #4170: add drag and drop support to treeview widget

Planning to convert @COM-SELF@ into @self()@ and unwrap the target type using provided @java-class-name@ annotation s... Sergey Ivanovskiy

05/04/2020

06:12 PM Feature #4170: add drag and drop support to treeview widget

Sergey Ivanovskiy wrote:
> Thanks, changing all these methods in @ProgressBar@ to accept @NumericType@ in rev 11454 ... Hynek Cihlar

05:54 PM Bug #4631: Widget scoped to wrong frame on hide

Task ready for test. Roger Borrello

05:39 PM Feature #3880: enhanced browse 3rd phase of improvements

Stanislav Lomany wrote:
> > Provide a 4GL syntax option to disable user-controlled sorting for that specific browse ... Greg Shah

05:28 PM Feature #3880: enhanced browse 3rd phase of improvements

> Provide a 4GL syntax option to disable user-controlled sorting for that specific browse instance.
Are we talking... Stanislav Lomany

05/02/2020

03:06 PM Feature #4170: add drag and drop support to treeview widget

I tested @hitTest@ method on 4GL using this committed test case @uast/treeview/test-treeview-sp6-1.w@. @chCtrlFrame:T... Sergey Ivanovskiy

11:18 AM Feature #4170: add drag and drop support to treeview widget

Although the conversion of this code ... Sergey Ivanovskiy

11:07 AM Feature #4170: add drag and drop support to treeview widget

Thanks, changing all these methods in @ProgressBar@ to accept @NumericType@ in rev 11454 solves this compilation issu... Sergey Ivanovskiy

10:21 AM Feature #4170: add drag and drop support to treeview widget

Sergey Ivanovskiy wrote:
> I rechecked these test cases:
>
> there are compilation errors now
This is after my ... Hynek Cihlar

06:59 AM Feature #4170: add drag and drop support to treeview widget

I rechecked these test cases:... Sergey Ivanovskiy

05/01/2020

02:40 PM Feature #4170: add drag and drop support to treeview widget

Sergey Ivanovskiy wrote:
> Please correct if the following requirements are incorrect. It needs to implement @GET-NO... Hynek Cihlar

02:37 PM Feature #4170: add drag and drop support to treeview widget

Please correct if the following requirements are incorrect. It needs to implement @GET-NODE-AT(X, Y)@ for the tree wi... Sergey Ivanovskiy

02:02 PM Feature #4170: add drag and drop support to treeview widget

Sergey Ivanovskiy wrote:
> Eugenie Lyzenko wrote:
> > Sergey Ivanovskiy wrote:
> > > Committed rev 11507 (4231b) s... Eugenie Lyzenko

01:55 PM Feature #4170: add drag and drop support to treeview widget

Eugenie Lyzenko wrote:
> Sergey Ivanovskiy wrote:
> > Committed rev 11507 (4231b) should fix issues found in the re... Sergey Ivanovskiy

10:21 AM Feature #4170: add drag and drop support to treeview widget

Eugenie Lyzenko wrote:
> Sergey Ivanovskiy wrote:
> > Eugenie, I am not aware of this method. Could you help to fin... Hynek Cihlar

01:51 PM Feature #4394 (WIP): add some frame options and attributes

The other 2 tasks are TBD, so backing up this task to 30%.
* @SCROLL@ frame option
* @NO-ATTR-SPACE@ frame option Roger Borrello

01:05 PM Feature #4164: implement misc UI features (frame options, misc attributes)

Testcase passes in ChUI, as well. Roger Borrello

11:19 AM Bug #4631: Widget scoped to wrong frame on hide

Committed revision 4231b-11509. Roger Borrello

11:18 AM Bug #4631 (WIP): Widget scoped to wrong frame on hide

Roger Borrello

11:01 AM Bug #4631: Widget scoped to wrong frame on hide

I was able to find a few critical places where @frameLName@ was not being stored off, resulting in the downstream bre... Roger Borrello

09:04 AM Bug #4631: Widget scoped to wrong frame on hide

> Everywhere the frame name was being stored/retrieved from the frameName map in lowercase, I was doing the same with... Greg Shah

12:48 AM Bug #4631: Widget scoped to wrong frame on hide

There was a missing @def frame x@ I added, after taking a closer look at the code that broke.... Roger Borrello

09:20 AM Feature #3880: enhanced browse 3rd phase of improvements

Stanislav Lomany wrote:
> > Considering the latest changes in reports, keys used for report caching are not accurate... Greg Shah

06:57 AM Feature #3880: enhanced browse 3rd phase of improvements

> Considering the latest changes in reports, keys used for report caching are not accurate any more. Use the same key... Stanislav Lomany

04/30/2020

07:27 PM Feature #4170: add drag and drop support to treeview widget

Sergey Ivanovskiy wrote:
> Committed rev 11507 (4231b) should fix issues found in the review. getItem and add() meth... Eugenie Lyzenko

06:36 PM Feature #4170: add drag and drop support to treeview widget

Sergey Ivanovskiy wrote:
> Eugenie, I am not aware of this method. Could you help to find 4GL examples of @GET-NODE-... Eugenie Lyzenko

06:03 PM Feature #4170: add drag and drop support to treeview widget

Committed rev 11507 (4231b) should fix issues found in the review. getItem and add() methods were rewritten.
It ... Sergey Ivanovskiy

05:15 PM Feature #4170: add drag and drop support to treeview widget

Eugenie, I am not aware of this method. Could you help to find 4GL examples of @GET-NODE-AT(X, Y)@? I didn't find thi... Sergey Ivanovskiy

02:08 PM Feature #4170: add drag and drop support to treeview widget

Sergey,
What is your plans for implementing @GET-NODE-AT(X,Y)@ tree view widget method? Eugenie Lyzenko

05:59 PM Bug #4631: Widget scoped to wrong frame on hide

> please confirm that mymess should be scoped to frame x. If so, this is more of a case of mymess not being added as ... Greg Shah

05:12 PM Bug #4631: Widget scoped to wrong frame on hide

Still working on this, as that fix caused breakage elsewhere.
Greg, in this testcase:... Roger Borrello

12:32 PM Bug #4631: Widget scoped to wrong frame on hide

The change to restrict using the resolved frame when there isn't an explicit frame specified was too strict. It exclu... Roger Borrello

10:51 AM Bug #4631: Widget scoped to wrong frame on hide

This is related revision 11497 of @rules/annotations/frame_scoping.rules@. Researching. Roger Borrello

08:33 AM Bug #4631: Widget scoped to wrong frame on hide

Testcase: @./uast/frames/nested_scoping_frame.p@... Roger Borrello

08:31 AM Bug #4631 (Closed): Widget scoped to wrong frame on hide

Roger Borrello

02:29 PM Feature #4164: implement misc UI features (frame options, misc attributes)

Code review 4231b revision 11504. The code changes seem OK. I think you should also test the changes in ChUI if you h... Hynek Cihlar

04/29/2020

05:30 PM Feature #4164: implement misc UI features (frame options, misc attributes)

Roger Borrello wrote:
> From Hynek:
>
> Both getAssigned and getEffective return 0-based values. These must be in... Roger Borrello

05:28 PM Feature #4164: implement misc UI features (frame options, misc attributes)

From Hynek:
Both getAssigned and getEffective return 0-based values. These must be incremented by one (and perhaps... Roger Borrello

04:37 PM Feature #4164: implement misc UI features (frame options, misc attributes)

Updated @src/com/goldencode/p2j/ui/chui/ThinClient.java@ in 4231b-11504. Please review. Roger Borrello

03:00 PM Feature #4164: implement misc UI features (frame options, misc attributes)

@getEffectivexxx@ methods are returning @0.0@ for @clientColumn@ and @clientRow@ when reading the attributes. The @ge... Roger Borrello

01:27 PM Feature #4164: implement misc UI features (frame options, misc attributes)

Roger Borrello wrote:
> One other significant difference between the two is that @getFrameCol@ includes a check for ... Hynek Cihlar

01:14 PM Feature #4164: implement misc UI features (frame options, misc attributes)

One other significant difference between the two is that @getFrameCol@ includes a check for @!frame.isRedirected()@ w... Roger Borrello

12:36 PM Feature #4164: implement misc UI features (frame options, misc attributes)

Hynek Cihlar wrote:
> Both of these methods were at some point changed by myself and by Constantin as part of bigger... Roger Borrello

12:12 PM Feature #4164: implement misc UI features (frame options, misc attributes)

Roger Borrello wrote:
> Hynek: I am trying to understand why the implementations for @FRAME-COL@ and @FRAME-ROW@ are... Hynek Cihlar

11:48 AM Feature #4164: implement misc UI features (frame options, misc attributes)

Hynek: I am trying to understand why the implementations for @FRAME-COL@ and @FRAME-ROW@ are so different, and Greg s... Roger Borrello

03:57 PM Feature #4170: add drag and drop support to treeview widget

After removing the node all indices of tree nodes are rebuilt. So the @INDEX@ is not @NODE-ID@. Sergey Ivanovskiy

03:47 PM Feature #4170: add drag and drop support to treeview widget

Sergey Ivanovskiy wrote:
> I convinced myself that @KEY@ property is not unique but it was incorrect. Actually the k... Sergey Ivanovskiy

02:47 PM Feature #4170: add drag and drop support to treeview widget

I convinced myself that @KEY@ property is not unique but it was incorrect. Actually the keys are unique but can be se... Sergey Ivanovskiy

02:34 PM Feature #4170: add drag and drop support to treeview widget

Hynek Cihlar wrote:
> Sergey Ivanovskiy wrote:
> > Hynek Cihlar wrote:
> > > Code review 4231b revision 11491.
> ... Sergey Ivanovskiy

01:47 PM Feature #4170: add drag and drop support to treeview widget

Sergey Ivanovskiy wrote:
> These events: ONEXPANDING, ONEXPANDED, ... are not documented and 4GL COM object viewer f... Hynek Cihlar

01:35 PM Feature #4170: add drag and drop support to treeview widget

Yes, if we use @add(...)@ (@chCtrlFrame:TreeView:NODES:ADD(1, 4, "Key2", "Label2")@) with incorrect parameters, then... Sergey Ivanovskiy

01:30 PM Feature #4170: add drag and drop support to treeview widget

Sergey Ivanovskiy wrote:
> Hynek Cihlar wrote:
> > Code review 4231b revision 11491.
> >
> > @TreeNodeCollection... Hynek Cihlar

01:29 PM Feature #4170: add drag and drop support to treeview widget

Hynek Cihlar wrote:
> Code review 4231b revision 11491.
>
> @TreeNodeCollectionResource.add()@:
> Before the cha... Sergey Ivanovskiy

10:22 AM Feature #4170: add drag and drop support to treeview widget

Code review 4231b revision 11491.
@TreeNodeCollectionResource.add()@:
Before the change the method raises out of ... Hynek Cihlar

09:01 AM Feature #4170: add drag and drop support to treeview widget

Hynek, please review the committed rev 11500 (4231b) that removed already defined by @TreeFaceNode@ methods and added... Sergey Ivanovskiy

03:15 AM Feature #4170: add drag and drop support to treeview widget

Sorry, I missed this issue due to incremental builds. Please update to rev 11499 (4231b). Sergey Ivanovskiy

08:19 PM Feature #4170: add drag and drop support to treeview widget

Sergey,
The regression starting in @11495@ does not allow the @4231b@ branch to be compiled.
Please fix this on... Eugenie Lyzenko

04/28/2020

11:25 AM Feature #4393 (Test): add TITLE-DCOLOR attribute support

Greg Shah

11:24 AM Feature #4393: add TITLE-DCOLOR attribute support

Code Review Task Branch 4231b Revision 11494
The changes are good. Greg Shah

10:52 AM Feature #4393: add TITLE-DCOLOR attribute support

Code revised:... Roger Borrello

09:58 AM Feature #4393: add TITLE-DCOLOR attribute support

Code Review Task Branch 4231b Revision 11492
In Java, instances of @String@ are immutable. Please never use @new ... Greg Shah

09:49 AM Feature #4394 (Test): add some frame options and attributes

With the change in 4231b rev 11492, this is now complete. Greg Shah

04/27/2020

06:29 PM Feature #4393: add TITLE-DCOLOR attribute support

Thanks. Enhancements have been added to @4231b-11492@ and tested. I added @./uast/pause_millis.p@ for helping to that... Roger Borrello

05:13 PM Feature #4393: add TITLE-DCOLOR attribute support

Roger Borrello wrote:
> Constantin, do you already have a testcase that exercises @toMilliseconds@ so I can verify m... Constantin Asofiei

04:01 PM Feature #4393: add TITLE-DCOLOR attribute support

Testcase @./uast/proversion_builtin.p@ was used to verify the caching in @WorkArea@. Now verifying utilization in @./... Roger Borrello

03:43 PM Feature #4393: add TITLE-DCOLOR attribute support

Constantin Asofiei wrote:
> Greg Shah wrote:
> > Constantin: What was the code that you added recently which had to... Roger Borrello

02:19 PM Feature #4393: add TITLE-DCOLOR attribute support

Yes, float. Greg Shah

01:20 PM Feature #4393: add TITLE-DCOLOR attribute support

Greg Shah wrote:
> Of course the "simple" version number would need to be in the form @major.minor@ and the other pa... Roger Borrello

01:04 PM Feature #4393: add TITLE-DCOLOR attribute support

Greg Shah wrote:
> We have @EnvironmentOps.versionWorker(long lvl)@ which can determine a version string for the 4GL... Roger Borrello

04:05 PM Feature #4394: add some frame options and attributes

Code Review Task Branch 4231b Revision 11488
The only issue is a cut/paste problem in @frame_construction.rules@ w... Greg Shah

12:25 PM Feature #4394: add some frame options and attributes

Ready for test.... Roger Borrello

10:38 AM Feature #4394: add some frame options and attributes

> Should I just document GenericFrame or go beyond?
Just @GenericFrame@ is fine. Greg Shah

10:22 AM Feature #4394: add some frame options and attributes

Greg Shah wrote:
> 2. In @java_templates.tpl@ there is the @construct_frame@ template. The @javaname@ target is a m... Roger Borrello

10:13 AM Feature #4394: add some frame options and attributes

Greg Shah wrote:
> Code Review Task Branch 4231b Revisions 11483, 11486, 11487
>
> The changes are good.
>
> 1... Roger Borrello

04:04 PM Feature #4170: add drag and drop support to treeview widget

Hynek Cihlar wrote:
> Sergey Ivanovskiy wrote:
> > Please review the committed revision 11489 (4231b). It still doe... Sergey Ivanovskiy

01:59 PM Feature #4170: add drag and drop support to treeview widget

Sergey Ivanovskiy wrote:
> Please review the committed revision 11489 (4231b). It still doesn't work according to t... Hynek Cihlar

01:27 PM Feature #4170: add drag and drop support to treeview widget

Sergey Ivanovskiy wrote:
> Nodes of the Microsoft TreeView Control 6.0 (SP6) from mscomctl.ocx has @Index@ property ... Hynek Cihlar

12:16 PM Feature #4170: add drag and drop support to treeview widget

Please review the committed revision 11489 (4231b). It still doesn't work according to the Microsoft TreeView Contro... Sergey Ivanovskiy

11:13 AM Feature #4170: add drag and drop support to treeview widget

!mscomctl-tree.png! Sergey Ivanovskiy

11:07 AM Feature #4170: add drag and drop support to treeview widget

Hynek Cihlar wrote:
> How does @Add@ behave when you call it multiple times without any parameters? What the key v... Sergey Ivanovskiy

10:45 AM Feature #4170: add drag and drop support to treeview widget

Nodes of the Microsoft TreeView Control 6.0 (SP6) from mscomctl.ocx has @Index@ property that is used as a node key, ... Sergey Ivanovskiy

07:06 AM Feature #4170: add drag and drop support to treeview widget

Sergey Ivanovskiy wrote:
> Hynek Cihlar wrote:
> > Sergey Ivanovskiy wrote:
> > > Hynek Cihlar wrote:
> > > > If ... Hynek Cihlar

06:24 AM Feature #4170: add drag and drop support to treeview widget

Hynek Cihlar wrote:
> Sergey Ivanovskiy wrote:
> > Hynek Cihlar wrote:
> > > If the current implementation doesn't... Sergey Ivanovskiy

06:05 AM Feature #4170: add drag and drop support to treeview widget

Sergey Ivanovskiy wrote:
> Hynek Cihlar wrote:
> > If the current implementation doesn't behave as the original con... Hynek Cihlar

05:52 AM Feature #4170: add drag and drop support to treeview widget

Hynek Cihlar wrote:
> Hynek Cihlar wrote:
> > Sergey Ivanovskiy wrote:
> > > Thank you, it resolves the issue. Eac... Sergey Ivanovskiy

05:46 AM Feature #4170: add drag and drop support to treeview widget

Hynek Cihlar wrote:
> Sergey Ivanovskiy wrote:
> > Thank you, it resolves the issue. Each node has KEY property and... Hynek Cihlar

05:43 AM Feature #4170: add drag and drop support to treeview widget

Sergey Ivanovskiy wrote:
> Thank you, it resolves the issue. Each node has KEY property and this property doesn't id... Hynek Cihlar

04:36 AM Feature #4170: add drag and drop support to treeview widget

Thank you, it resolves the issue. Each node has KEY property and this property doesn't identify the tree node. Should... Sergey Ivanovskiy

04:15 AM Feature #4170: add drag and drop support to treeview widget

Sergey Ivanovskiy wrote:
> There are unresolved issues:
>
> * The code that assigns the result of applying chaine... Hynek Cihlar

02:02 AM Feature #4170: add drag and drop support to treeview widget

Is there a conceptual way to solve the issue in #4170-40? How these indirect COM objects should be supported? Should ... Sergey Ivanovskiy

01:21 AM Feature #4170: add drag and drop support to treeview widget

There are unresolved issues:
* The code that assigns the result of applying chained methods to the control frame o... Sergey Ivanovskiy

03:56 PM Feature #3880: enhanced browse 3rd phase of improvements

OK Greg Shah

03:07 PM Feature #3880: enhanced browse 3rd phase of improvements

Guys, I wanted to add a field where I could input a report title. I used existing file/font/color selection frames as... Stanislav Lomany

04/25/2020

10:41 AM Feature #4394: add some frame options and attributes

Code Review Task Branch 4231b Revisions 11483, 11486, 11487
The changes are good.
1. Please modify the @Generic... Greg Shah

04/24/2020

03:46 PM Bug #4627: CAN-QUERY incorrectly determines SCREEN-VALUE on a FRAME widget is queryable

Testcases:... Roger Borrello

03:42 PM Bug #4627 (New): CAN-QUERY incorrectly determines SCREEN-VALUE on a FRAME widget is queryable

Roger Borrello

03:40 PM Feature #4394: add some frame options and attributes

I have updated and my testcase passes. ... Roger Borrello

01:51 PM Feature #4394: add some frame options and attributes

Greg Shah wrote:
> > I suppose I could keep the 2nd parameter as the original name, and in the GenericFrame.coreInit... Constantin Asofiei

01:35 PM Feature #4394: add some frame options and attributes

> I suppose I could keep the 2nd parameter as the original name, and in the GenericFrame.coreInitialize method, perfo... Greg Shah

01:16 PM Feature #4394: add some frame options and attributes

Greg Shah wrote:
> Today, what is that 2nd parameter used for other than as the legacy name?
Two main things...
... Roger Borrello

12:48 PM Feature #4394: add some frame options and attributes

Today, what is that 2nd parameter used for other than as the legacy name? Greg Shah

12:47 PM Feature #4394: add some frame options and attributes

Greg Shah wrote:
> Is @FRAME-NAME()@ ready for review?
No... Is one of these a better choice than the other?
# A... Roger Borrello

11:48 AM Feature #4394: add some frame options and attributes

Is @FRAME-NAME()@ ready for review? Greg Shah

10:58 AM Feature #4394: add some frame options and attributes

Greg Shah wrote:
> Hint: I wonder if the 4GL returns (from @FRAME-NAME()@) the first frame name that is defined, the... Roger Borrello

10:08 AM Feature #4394: add some frame options and attributes

Hint: I wonder if the 4GL returns (from @FRAME-NAME()@) the first frame name that is defined, the last one that is de... Greg Shah

10:05 AM Feature #4394: add some frame options and attributes

I doubt that is a good idea. The original 4GL code allows specifying the name in any case when you refer to the fram... Greg Shah

09:57 AM Feature #4394: add some frame options and attributes

I was thinking of the ramifications of using the actual frame name as specified in the 4GL, instead of the lowercase ... Roger Borrello

06:12 AM Feature #4170: add drag and drop support to treeview widget

Thank you, it is clear now. It seems that this tree implementation from Microsoft TreeView Control 6.0 (SP6) from @ms... Sergey Ivanovskiy

04/23/2020

06:54 PM Feature #4394: add some frame options and attributes

Made changes in @frame_scoping.rules@ to create a "parallel" legacy name that is handled in the same manner as the fr... Roger Borrello

11:24 AM Feature #4394: add some frame options and attributes

Greg Shah wrote:
> Why mess around? Just store it before frame scoping occurs.
From what I know, it's pay-me-now... Roger Borrello

11:19 AM Feature #4394: add some frame options and attributes

Why mess around? Just store it before frame scoping occurs. Greg Shah

11:14 AM Feature #4394: add some frame options and attributes

About a year ago, Constantin made a specific update to @annotations/frame_scoping.rules@:... Roger Borrello

06:51 AM Feature #4170: add drag and drop support to treeview widget

Sergey Ivanovskiy wrote:
> Can I use these changes to add @COUNT@
> [...]
If the new alias works, it is only a h... Hynek Cihlar

04/22/2020

06:18 PM Feature #4394: add some frame options and attributes

Greg Shah wrote:
> OK, perhaps I need to clarify.
>
> @javaname@ is a converted Java name and will have been tran... Roger Borrello

06:09 PM Feature #4394: add some frame options and attributes

OK, perhaps I need to clarify.
@javaname@ is a converted Java name and will have been transformed to remove all th... Greg Shah

06:08 PM Feature #4394: add some frame options and attributes

Greg Shah wrote:
> No. Nein. Nyet. Non. Nee.
Tried updating that, and it looks like it should be using @name@. Ho... Roger Borrello

06:07 PM Feature #4394: add some frame options and attributes

No. Nein. Nyet. Non. Nee. Greg Shah

06:00 PM Feature #4394: add some frame options and attributes

Getting back to @FRAME-NAME@, it looks like @convert/frame_construction.rules@ retrieves the critical data using:
<p... Roger Borrello

04:50 PM Feature #4170: add drag and drop support to treeview widget

Can I use these changes to add @COUNT@... Sergey Ivanovskiy

02:51 PM Feature #4170: add drag and drop support to treeview widget

Sergey Ivanovskiy wrote:
> What 4GL create node methods are supported by TreeView FWD widget? I tried this code that... Hynek Cihlar

01:30 PM Feature #4170: add drag and drop support to treeview widget

Also I found that Progress 4GL COM Object Viewer returns incorrect signature for @Expand@ event of @ITreeViewEvents@ ... Sergey Ivanovskiy

12:21 PM Feature #4170: add drag and drop support to treeview widget

What 4GL create node methods are supported by TreeView FWD widget? I tried this code that works with 4GL... Sergey Ivanovskiy

03:45 PM Feature #4164: implement misc UI features (frame options, misc attributes)

When not using redirection, the testcase passes.... Roger Borrello

03:39 PM Feature #4164: implement misc UI features (frame options, misc attributes)

I also notice on the last frame (a dialog box) the @F2@ never is recognized in the @wait-for go of frame df0.@ I have... Roger Borrello

03:01 PM Feature #4164: implement misc UI features (frame options, misc attributes)

Constantin Asofiei wrote:
> Roger Borrello wrote:
> > I am using "output to..." to collect the output. I can try wi... Roger Borrello

02:42 PM Feature #4164: implement misc UI features (frame options, misc attributes)

Roger Borrello wrote:
> I am using "output to..." to collect the output. I can try without. However, I would think t... Constantin Asofiei

02:39 PM Feature #4164: implement misc UI features (frame options, misc attributes)

Constantin Asofiei wrote:
> Area you using streams in your tests, or the redirected terminal ( unnamed stream)? I... Roger Borrello

02:22 PM Feature #4164: implement misc UI features (frame options, misc attributes)

Roger Borrello wrote:
> During debug, I found that when the @visible@ flag is set prior to the frame being displayed... Constantin Asofiei

01:41 PM Feature #4164: implement misc UI features (frame options, misc attributes)

During debug, I found that when the @visible@ flag is set prior to the frame being displayed, the @getFrame(frameId)@... Roger Borrello

11:44 AM Feature #4164: implement misc UI features (frame options, misc attributes)

With respect to @FRAME-COL@ (and @FRAME-ROW@), I am debugging why these are incorrect when checked using this code:
... Roger Borrello

03:10 PM Bug #4625: Frame configuration not shared or synched back to the GUI frame on redirection

During debug, I found that when the @visible@ flag is set prior to the frame being displayed, the @getFrame(frameId)@... Roger Borrello

03:03 PM Bug #4625 (New): Frame configuration not shared or synched back to the GUI frame on redirection

Roger Borrello

02:46 PM Bug #4624: Fill-in: StringIndexOutOfBoundsException and other bugs

h1. Problem 1. Wrong END key action result
The code:... Vladimir Tsichevski

02:19 PM Bug #4624 (Closed): Fill-in: StringIndexOutOfBoundsException and other bugs

Vladimir Tsichevski

04/21/2020

06:34 PM Feature #4164: implement misc UI features (frame options, misc attributes)

Greg Shah wrote:
> 4335a revision 11428 adds conversion and server-side support for @EDITOR:AUTO-INDENT@. The clien... Roger Borrello

09:57 AM Feature #4164: implement misc UI features (frame options, misc attributes)

Roger Borrello wrote:
> Please confirm @editor:auto-indent@ already converts and just needs runtime support only (so... Greg Shah

09:26 AM Feature #4164: implement misc UI features (frame options, misc attributes)

Please confirm @editor:auto-indent@ already converts and just needs runtime support only (so I can bypass)? Roger Borrello

01:40 PM Feature #4170: add drag and drop support to treeview widget

I assume v6 is the correct one, but I do not know for sure. Greg Shah

01:06 PM Feature #4170: add drag and drop support to treeview widget

On my windows image I have two versions of a tree view control: Microsoft TreeView Control 6.0 (SP6) from @mscomctl.... Sergey Ivanovskiy

04/20/2020

02:49 PM Bug #4619: GUI fill-in widgets show in FWD, when 4GL shows nothing

The @message set@ case may not be related to this at all. Greg Shah

02:31 PM Bug #4619: GUI fill-in widgets show in FWD, when 4GL shows nothing

Would this be related to the variable factory itself, or the widgets? I had another testcase @uast/io/basic_redirecte... Roger Borrello

04:06 AM Feature #3876: add support for "direct font control" at the widget level

Sergey Ivanovskiy wrote:
> We have some functions that can return the metric size of a string from the driver, the S... Hynek Cihlar

02:32 AM Feature #3876: add support for "direct font control" at the widget level

Hynek Cihlar wrote:
> Sergey Ivanovskiy wrote:
> > It seems that these changes
> > [...]
> >
> > are not consi... Sergey Ivanovskiy

04/17/2020

06:39 PM Feature #4394 (WIP): add some frame options and attributes

Roger Borrello

06:38 PM Bug #4611: Implement a font enumeration Java API directly callable from legacy code

For Swing GUI, the fonts can be enumerated with:... Hynek Cihlar

06:36 PM Feature #4393: add TITLE-DCOLOR attribute support

Just _temporarily_ I updated to utilize the same method as @toMillis@.
By updating @directory.xml@:... Roger Borrello

02:03 PM Feature #4393: add TITLE-DCOLOR attribute support

With my proposed change, the code could be implemented with a simple check @EnvironmentOps.versionNumber() >= 11.3@. ... Greg Shah

01:38 PM Feature #4393: add TITLE-DCOLOR attribute support

Greg Shah wrote:
> Constantin: What was the code that you added recently which had to check the version numbers at r... Constantin Asofiei

12:43 PM Feature #4393: add TITLE-DCOLOR attribute support

We have @EnvironmentOps.versionWorker(long lvl)@ which can determine a version string for the 4GL version to which we... Greg Shah

11:56 AM Feature #4393 (WIP): add TITLE-DCOLOR attribute support

Roger Borrello

11:55 AM Feature #4393: add TITLE-DCOLOR attribute support

Greg Shah wrote:
> Yes, it could be a version difference. Run the testcases on both 10.x and 11.x and record the di... Roger Borrello

09:33 AM Feature #4393: add TITLE-DCOLOR attribute support

> Should these be pursued?
No. Create new tasks. Greg Shah

09:13 AM Feature #4393: add TITLE-DCOLOR attribute support

The @frame_title_color_default_values.p@ tests pass, however, there are a couple of differences.
# There is space in... Roger Borrello

08:48 AM Feature #4393: add TITLE-DCOLOR attribute support

Code Review Task Branch 4231b Revision 11463
The changes are good.
A minor code standards issue: split the foll... Greg Shah

07:07 AM Feature #4393: add TITLE-DCOLOR attribute support

> while in 4GL, it activates the button and an NPE exception is thrown:
This implies there is an NPE in the 4GL wh... Greg Shah

06:32 PM Feature #3876: add support for "direct font control" at the widget level

Hynek Cihlar wrote:
> but there were errors converting the method call returning String array. I tried to fix this a... Hynek Cihlar

04:56 PM Feature #3876: add support for "direct font control" at the widget level

Sergey Ivanovskiy wrote:
> It seems that these changes
> [...]
>
> are not consistent with @isFontInstalled@ us... Hynek Cihlar

03:44 PM Feature #3876: add support for "direct font control" at the widget level

It seems that these changes ... Sergey Ivanovskiy

11:28 AM Feature #3876: add support for "direct font control" at the widget level

Greg Shah wrote:
> Yes. When you designed the default freely licensed fonts for FWD, this included replacing the co... Eugenie Lyzenko

09:10 AM Feature #3876: add support for "direct font control" at the widget level

Yes. When you designed the default freely licensed fonts for FWD, this included replacing the common/standard bitmap... Greg Shah

09:00 AM Feature #3876: add support for "direct font control" at the widget level

Greg Shah wrote:
> The changes are good. I've made some additional tweaks.
>
> Eugenie: I'd like to include a li... Eugenie Lyzenko

07:39 AM Feature #3876: add support for "direct font control" at the widget level

The changes are good. I've made some additional tweaks.
Eugenie: I'd like to include a list of the commonly used ... Greg Shah

11:55 AM Bug #4619: GUI fill-in widgets show in FWD, when 4GL shows nothing

> In 4GL, this is not a fill-in and
I think you mean that it is an editable fill-in in FWD and not in the 4GL?
... Greg Shah

11:20 AM Bug #4619: GUI fill-in widgets show in FWD, when 4GL shows nothing

A simple integer on a frame becomes a fill-in widget with the default value showing. In 4GL, this is not a fill-in an... Roger Borrello

11:18 AM Bug #4619 (New): GUI fill-in widgets show in FWD, when 4GL shows nothing

Roger Borrello

11:11 AM Bug #4618: Default location of dialog box title is left justified instead of centered

The @uast/frame_title_color_default_values.p@ testcase shows that the dialog box has the title text left justified in... Roger Borrello

11:08 AM Bug #4618 (New): Default location of dialog box title is left justified instead of centered

Roger Borrello

10:32 AM Bug #4617: Number of GUI frames in default window differs from 4GL

Testcase related to #4393 reveals that FWD allows 5 frames on the default window, when 4GL only shows 4.
!GUI_fram... Roger Borrello

10:29 AM Bug #4617 (New): Number of GUI frames in default window differs from 4GL

Roger Borrello

04/16/2020

06:36 PM Feature #4394: add some frame options and attributes

Roger Borrello wrote:
> By updating @getFrameRow@ and @getFrameCol@ in @ThinClient.java@ to return a 0, if the frame... Hynek Cihlar

06:19 PM Feature #3876: add support for "direct font control" at the widget level

I added the required information in [[p2j:Font_Control_in_4GL_Widgets]] together with an example. I found a couple of... Hynek Cihlar

06:03 PM Feature #4393: add TITLE-DCOLOR attribute support

Regarding the menu tests, both GUI and ChUI result in the same attribute output.
However, there are different beha... Roger Borrello

04:40 PM Feature #4393: add TITLE-DCOLOR attribute support

These changes should complete the browse attributes and options.... Roger Borrello

02:34 PM Feature #4393: add TITLE-DCOLOR attribute support

Issue of the title bar missing was related to @annotations/sorting.rules@ where @DCOLOR@ was not included as criteria... Roger Borrello

01:49 PM Feature #4393: add TITLE-DCOLOR attribute support

It is not obviously on the client or server, we can't really know. But since it is drawing something and just missin... Greg Shah

11:37 AM Feature #4393: add TITLE-DCOLOR attribute support

Roger Borrello wrote:
> Another issue I am looking at. The browse title is missing, if @DCOLOR@ is part of the optio... Roger Borrello

10:59 AM Feature #4393: add TITLE-DCOLOR attribute support

Yes, I think so. Greg Shah

10:27 AM Feature #4393: add TITLE-DCOLOR attribute support

Greg Shah wrote:
> > I did not have good results with that flag, or I was using it incorrectly. However, the config.... Roger Borrello

11:20 AM Feature #4170: add drag and drop support to treeview widget

Investigating what issues need to be done for #4170-20 in item 2. Sergey Ivanovskiy

04/15/2020

02:21 PM Feature #4394: add some frame options and attributes

By updating @getFrameRow@ and @getFrameCol@ in @ThinClient.java@ to return a 0, if the frame is not visible, I get ma... Roger Borrello

12:11 PM Feature #4394: add some frame options and attributes

Roger Borrello wrote:
> Initial attribute values being returned for @frame-col@ and @frame-row@ are incorrect. They ... Roger Borrello

11:38 AM Feature #4394: add some frame options and attributes

Initial attribute values being returned for @frame-col@ and @frame-row@ are incorrect. They are coming from the clien... Roger Borrello

10:38 AM Feature #4394: add some frame options and attributes

We always must return BDT values from attribute getters. We never return @String@ instances. Greg Shah

10:22 AM Feature #4394: add some frame options and attributes

Greg Shah wrote:
> Right. So your existing code is not correct. I suspect that this is not the string @"?"@ but it... Roger Borrello

09:53 AM Feature #4394: add some frame options and attributes

Right. So your existing code is not correct. I suspect that this is not the string @"?"@ but it is just how the lan... Greg Shah

09:46 AM Feature #4394: add some frame options and attributes

Greg Shah wrote:
> Code Review Task Branch 4231b Revision 11446
>
> The only issue is the use of @new String()@ i... Roger Borrello

04/14/2020

02:38 PM Feature #4394: add some frame options and attributes

As someone wise once said: "The problem was a loose nut behind the wheel.". :)
Our current implementation assumes ... Greg Shah

02:35 PM Feature #4394: add some frame options and attributes

Roger Borrello wrote:
> Greg Shah wrote:
> > The @b4Frname.assign()@ is missing the @f0Frame.widgeti().getFrameName... Roger Borrello

02:07 PM Feature #4394: add some frame options and attributes

Greg Shah wrote:
> The @b4Frname.assign()@ is missing the @f0Frame.widgeti().getFrameName()@ argument.
>
> You'll... Roger Borrello

02:06 PM Feature #4394: add some frame options and attributes

We can't go on an 2 week effort to dig into this. It would be good to fix these as well. The issue is probably diffe... Greg Shah

12:53 PM Feature #4394: add some frame options and attributes

Roger Borrello wrote:
> Looking at more code emitted... would this be similar to why this code:
> [...]
> converts... Roger Borrello

12:26 PM Feature #4394: add some frame options and attributes

Greg Shah wrote:
> The @b4Frname.assign()@ is missing the @f0Frame.widgeti().getFrameName()@ argument.
>
> You'll... Roger Borrello

10:37 AM Feature #4394: add some frame options and attributes

Code Review Task Branch 4231b Revision 11446
The only issue is the use of @new String()@ in @GenericWidget.getFram... Greg Shah

10:30 AM Feature #4394: add some frame options and attributes

The @b4Frname.assign()@ is missing the @f0Frame.widgeti().getFrameName()@ argument.
You'll have to fix it. Most l... Greg Shah

10:21 AM Feature #4394: add some frame options and attributes

Current testcase has 2 of the same use of the @:frame-name@ attribute, with very different conversions:
# @assign b4... Roger Borrello

04/13/2020

05:28 PM Feature #4394: add some frame options and attributes

Code ready for review. Additional testcases being developed. Tested via @ON MOUSE-SELECT-CLICK@ of various widgets on... Roger Borrello

04:19 PM Feature #4394: add some frame options and attributes

> My assumptions is that there will need to be getter/setter support added in FrameInterface.java and FrameWidget.jav... Greg Shah

04:07 PM Feature #4394: add some frame options and attributes

Greg Shah wrote:
> Add support for:
>
> * @FRAME-NAME@ attribute (this is actually a generic widget attribute but... Roger Borrello

04/10/2020

06:23 PM Bug #4612: Fix ChUI browse drawing when the current row is out of the view

In a ChUI browse the current row can be out of the view. It is a rare case and I'm aware only of one case when this h... Stanislav Lomany

05:54 PM Bug #4612 (New): Fix ChUI browse drawing when the current row is out of the view

Stanislav Lomany

09:23 AM Feature #3876: add support for "direct font control" at the widget level

Greg Shah wrote:
> Please create a new task for that. We will defer work on it for now.
Done. Hynek Cihlar

09:13 AM Feature #3876: add support for "direct font control" at the widget level

Please create a new task for that. We will defer work on it for now. In the wiki page, explain the idea and link to... Greg Shah

09:12 AM Feature #3876: add support for "direct font control" at the widget level

Greg Shah wrote:
> > He could do this using the standard system tools. Or do you want to add other 4GL extensions th... Hynek Cihlar

09:07 AM Feature #3876: add support for "direct font control" at the widget level

> He could do this using the standard system tools. Or do you want to add other 4GL extensions that would allow this?... Greg Shah

09:00 AM Feature #3876: add support for "direct font control" at the widget level

Greg Shah wrote:
> I've just edited the "Font Control in 4GL Widgets":/projects/p2j/wiki/Font_Control_in_4GL_Widgets... Hynek Cihlar

08:16 AM Feature #3876: add support for "direct font control" at the widget level

I've just edited the "Font Control in 4GL Widgets":/projects/p2j/wiki/Font_Control_in_4GL_Widgets. Please review and... Greg Shah

09:21 AM Bug #4611: Implement a font enumeration Java API directly callable from legacy code

The motivation here is to provide a way to allow to enumerate available font faces in legacy code. That is FWD/4GL co... Hynek Cihlar

09:16 AM Bug #4611 (New): Implement a font enumeration Java API directly callable from legacy code

Hynek Cihlar

04/09/2020

02:24 PM Feature #4164: implement misc UI features (frame options, misc attributes)

As Constantin notes, you are telling the code to only have the frame positioned in @col 1 row 1@ because only the FIR... Greg Shah

01:05 PM Feature #4164: implement misc UI features (frame options, misc attributes)

Roger, the @AT COL ROW@ in the frame phrase (for DISPLAY) sets the frame's definition location, not at runtime.
To... Constantin Asofiei

01:01 PM Feature #4164: implement misc UI features (frame options, misc attributes)

New testcase has expanded my ability to validate values, but I'm not sure it's on the mark yet. I was expecting the f... Roger Borrello

04/08/2020

11:29 AM Feature #4394: add some frame options and attributes

The @frame-name@ is just a string, right? So you can do anything with it to see the value (e.g. @message widget:fram... Greg Shah

11:03 AM Feature #4394: add some frame options and attributes

I cannot find any useful documentation related to how @FRAME-NAME@ would be used in a testcase. Searching through our... Roger Borrello

09:05 AM Feature #4609: rework scrolling approach to use an cleaner, MVC design

For a customer-specific grid widget, Vladimir wrote an alternative MVC scrolling implementation. The details are doc... Greg Shah

09:02 AM Feature #4609 (New): rework scrolling approach to use an cleaner, MVC design

Greg Shah