Project

General

Profile

Activity

From 05/01/2020 to 05/30/2020

05/29/2020

03:10 PM Feature #3880: enhanced browse 3rd phase of improvements
> In Chrome, first drag works, after that it no longer works.
I can confirm the issue. After the dragging fix, it ... Stanislav Lomany
02:35 PM Feature #3880: enhanced browse 3rd phase of improvements
Guys, what FWD feature supports dragging files from OS so I can check that it works? Stanislav Lomany
01:27 PM Feature #3880: enhanced browse 3rd phase of improvements
Eugenie Lyzenko wrote:
> Constantin Asofiei wrote:
> > This looks like is Eugenie's, from trunk rev 11770:
> >
>... Hynek Cihlar
12:33 PM Feature #3880: enhanced browse 3rd phase of improvements
Greg Shah wrote:
> What about drag and drop between windows (across canvas instances)?
I'm not aware of any use c... Hynek Cihlar
10:31 AM Feature #3880: enhanced browse 3rd phase of improvements
Constantin Asofiei wrote:
> This looks like is Eugenie's, from trunk rev 11770:
> [...]
>
> Eugenie: do you reca... Eugenie Lyzenko
09:01 AM Feature #3880: enhanced browse 3rd phase of improvements
I think the problem is global; I'm having issues with dragging a button in FWD, on both Chrome and Firefox. See this... Constantin Asofiei
08:09 AM Feature #3880: enhanced browse 3rd phase of improvements
What about drag and drop between windows (across canvas instances)? Greg Shah
08:03 AM Feature #3880: enhanced browse 3rd phase of improvements
Hynek Cihlar wrote:
> Constantin Asofiei wrote:
> > Hynek: can the body draggable setting affect the other cases of... Hynek Cihlar
08:01 AM Feature #3880: enhanced browse 3rd phase of improvements
Constantin Asofiei wrote:
> Hynek: can the body draggable setting affect the other cases of movable/resizeable widge... Hynek Cihlar
07:35 AM Feature #3880: enhanced browse 3rd phase of improvements
This looks like is Eugenie's, from trunk rev 11770:... Constantin Asofiei
06:08 AM Feature #3880: enhanced browse 3rd phase of improvements
Stanislav Lomany wrote:
> OK, HTML @body@ was explicitly defined draggable for some reason. So, on every drag in fir... Hynek Cihlar
05:58 AM Feature #3880: enhanced browse 3rd phase of improvements
Sergey/Hynek/Constantin: Please review.
Sergey: the important parts are from #3880-44 to #3880-63. Greg Shah
05:17 AM Feature #3880: enhanced browse 3rd phase of improvements
OK, HTML @body@ was explicitly defined draggable for some reason. So, on every drag in firefox we were dragging @body... Stanislav Lomany
02:53 PM Feature #4170: add drag and drop support to treeview widget
Committed revision 11575 and 11574 (4231b) fixed the found issues.
 Sergey Ivanovskiy
09:41 AM Feature #4170: add drag and drop support to treeview widget
Hynek Cihlar wrote:
> Sergey Ivanovskiy wrote:
> > The issue from #4170-167 was due to @comhandle.resourceId@ usage... Sergey Ivanovskiy
04:56 AM Feature #4170: add drag and drop support to treeview widget
Sergey Ivanovskiy wrote:
> The issue from #4170-167 was due to @comhandle.resourceId@ usages in @comhandle.compareTo... Hynek Cihlar
04:47 AM Feature #4170: add drag and drop support to treeview widget
Sergey Ivanovskiy wrote:
> Thank you for this review. Could you advise the proper place for @ErrorManager.ErrorReaso... Hynek Cihlar
04:47 AM Feature #4170: add drag and drop support to treeview widget
Working on the review fixes and javadocs, planning to commit ASAP. Sergey Ivanovskiy
04:43 AM Feature #4170: add drag and drop support to treeview widget
The issue from #4170-167 was due to @comhandle.resourceId@ usages in @comhandle.compareTo@ that is used from object @... Sergey Ivanovskiy
03:48 AM Feature #4170: add drag and drop support to treeview widget
Hynek Cihlar wrote:
> Sergey Ivanovskiy wrote:
> > These changes with @treeview/test-image-list-1.w@ reproduced #41... Sergey Ivanovskiy
03:15 AM Feature #4170: add drag and drop support to treeview widget
Sergey Ivanovskiy wrote:
> These changes with @treeview/test-image-list-1.w@ reproduced #4170-147.
Code review 41... Hynek Cihlar

05/28/2020

06:14 PM Feature #4170: add drag and drop support to treeview widget
Today I found this helpful article about MS Tree but some information was already discovered manually using 4GL code ... Sergey Ivanovskiy
05:59 PM Feature #4170: add drag and drop support to treeview widget
These changes with @treeview/test-image-list-1.w@ reproduced #4170-147. Sergey Ivanovskiy
05:49 PM Feature #4170: add drag and drop support to treeview widget
I delayed to commit my changes until the following issue was resolved. The same code ... Sergey Ivanovskiy

05/27/2020

02:00 PM Feature #3880: enhanced browse 3rd phase of improvements
Stanislav Lomany wrote:
> > Also, you should use 4231b because there were many improvements in the drag/drop code in... Hynek Cihlar
11:48 AM Feature #3880: enhanced browse 3rd phase of improvements
To make sure we're on the same page. That's how drag works for me in the latest firefox: https://youtu.be/4XY0TKhKFRY... Stanislav Lomany
10:38 AM Feature #3880: enhanced browse 3rd phase of improvements
> Also, you should use 4231b because there were many improvements in the drag/drop code in that branch.
Yes, in ch... Stanislav Lomany
09:02 AM Feature #3880: enhanced browse 3rd phase of improvements
I think we will be trying to clean it up and get it into trunk over the next two weeks. We have known issues for thi... Greg Shah
08:58 AM Feature #3880: enhanced browse 3rd phase of improvements
> If it is safe to do so, put 3880a into 4231b. You've tested your changes in both enhanced and non-enhanced modes?
... Stanislav Lomany
08:02 AM Feature #3880: enhanced browse 3rd phase of improvements
If it is safe to do so, put 3880a into 4231b. You've tested your changes in both enhanced and non-enhanced modes? Greg Shah
06:59 AM Feature #3880: enhanced browse 3rd phase of improvements
> Also, you should use 4231b because there were many improvements in the drag/drop code in that branch.
Maybe it i... Stanislav Lomany
05:55 AM Feature #3880: enhanced browse 3rd phase of improvements
Stanislav Lomany wrote:
> Right. I start dragging, then dragging on canvas stops, HTML dragging starts and we have p... Constantin Asofiei
05:53 AM Feature #3880: enhanced browse 3rd phase of improvements
Right. I start dragging, then dragging on canvas stops, HTML dragging starts and we have picture like in #3880-44. Stanislav Lomany
05:48 AM Feature #3880: enhanced browse 3rd phase of improvements
Stanislav Lomany wrote:
> > This resize must happen on the canvas, and driven by the FWD JS driver...
>
> Right,... Constantin Asofiei
05:45 AM Feature #3880: enhanced browse 3rd phase of improvements
> This resize must happen on the canvas, and driven by the FWD JS driver...
Right, it should, but it happens in H... Stanislav Lomany

05/26/2020

06:41 PM Feature #3880: enhanced browse 3rd phase of improvements
Also, you should use 4231b because there were many improvements in the drag/drop code in that branch. Greg Shah
06:08 PM Feature #3880: enhanced browse 3rd phase of improvements
Stanislav, you can see how @TREELIST@ column move and resize is implemented in @TreeListCaptionItem@. Hynek Cihlar
05:55 PM Feature #3880: enhanced browse 3rd phase of improvements
Stanislav, if I'm not mistaken Hynek implemented in FWD the resize for legacy 4GL widgets (part of the 'direct manipu... Constantin Asofiei
05:38 PM Feature #3880: enhanced browse 3rd phase of improvements
> # In firefox, when I press mouse within a window, HTML drag start if I do a vertical mouse move.
It is not verti... Stanislav Lomany
01:50 PM Feature #3880: enhanced browse 3rd phase of improvements
> If you have any remaining questions, please post the list ASAP.
Guys, please consider mouse dragging:
# In chro... Stanislav Lomany
06:44 AM Bug #3690 (Test): BUTTON widget reaction on SPACEBAR and ENTER keys
Greg Shah
05:35 AM Bug #3690 (Review): BUTTON widget reaction on SPACEBAR and ENTER keys
Adrian Lungu

05/25/2020

03:33 PM Feature #4170: add drag and drop support to treeview widget
The following code doesn't warn about the same index and the list images count becomes 3.... Sergey Ivanovskiy
09:47 AM Feature #4170: add drag and drop support to treeview widget
In this example the same @OlePictureObject@ is added to image list widget with different keys and the result images h... Sergey Ivanovskiy
10:24 AM Bug #4624: Fill-in: StringIndexOutOfBoundsException and other bugs
Added missing history entry in 4231b/rev.11559. Adrian Lungu
09:30 AM Bug #4624 (Test): Fill-in: StringIndexOutOfBoundsException and other bugs
Greg Shah
08:23 AM Bug #4624: Fill-in: StringIndexOutOfBoundsException and other bugs
Greg Shah wrote:
> Did you review rev 11556 as well?
Yes. Constantin Asofiei
08:23 AM Bug #4624: Fill-in: StringIndexOutOfBoundsException and other bugs
Did you review rev 11556 as well? Greg Shah
08:17 AM Bug #4624: Fill-in: StringIndexOutOfBoundsException and other bugs
The changes make sense. Only issue is @WinKeyboardReader.java@ which is missing history entry. Constantin Asofiei
08:05 AM Bug #4624: Fill-in: StringIndexOutOfBoundsException and other bugs
Constantin: Please review. Greg Shah
07:44 AM Bug #4624 (Review): Fill-in: StringIndexOutOfBoundsException and other bugs
Problem 3 was solved in 4231b/rev. 11558. The bug was triggered by incorrect resizing of the text when explicit forma... Adrian Lungu

05/24/2020

05:31 PM Feature #3880: enhanced browse 3rd phase of improvements
You've been looking into this for a week. At this point, I'm guessing you have enough understanding about how the mo... Greg Shah

05/22/2020

12:42 PM Feature #4170: add drag and drop support to treeview widget
Hynek Cihlar wrote:
> Sergey Ivanovskiy wrote:
> > Hynek, I didn't understand what you meant by "If image removal i... Sergey Ivanovskiy
12:05 PM Feature #4170: add drag and drop support to treeview widget
Sergey Ivanovskiy wrote:
> Hynek, I didn't understand what you meant by "If image removal is not implemented yet, th... Hynek Cihlar
11:37 AM Feature #4170: add drag and drop support to treeview widget
Hynek, I didn't understand what you meant by "If image removal is not implemented yet, then the index caching is OK."... Sergey Ivanovskiy
11:28 AM Feature #4170: add drag and drop support to treeview widget
Sergey Ivanovskiy wrote:
> > When one of the images (@ListImage@) is destroyed or removed the image index will have ... Hynek Cihlar
08:18 AM Feature #4170: add drag and drop support to treeview widget
Hynek Cihlar wrote:
> Sergey Ivanovskiy wrote:
> > Please review rev 11550 (4231b) that implemented @LOAD-PICTURE@ ... Sergey Ivanovskiy
06:30 AM Feature #4170: add drag and drop support to treeview widget
Sergey Ivanovskiy wrote:
> Please review rev 11550 (4231b) that implemented @LOAD-PICTURE@ and @ADD@ with complete s... Hynek Cihlar
12:21 PM Bug #4624 (WIP): Fill-in: StringIndexOutOfBoundsException and other bugs
Solved the following issues:
# Prevented text sliding when deleting while the cursor is at the end
# Fixed bad care... Adrian Lungu

05/21/2020

06:28 PM Feature #4174: implement calendar control/dtpicker OCX replacement
Also all panels in @CalendarPopup@ except the @daysInMonthPanel@ should not be widget fields, since they are referenc... Vladimir Tsichevski
05:33 PM Feature #4174: implement calendar control/dtpicker OCX replacement
I suppose declarations like the following should read _leading_ instead of _trailing_ since we mean something _before... Vladimir Tsichevski
01:35 PM Feature #4174: implement calendar control/dtpicker OCX replacement
Fixed in rev 11555 (4231b). Sergey Ivanovskiy
12:32 PM Feature #4174: implement calendar control/dtpicker OCX replacement
Vladimir Tsichevski wrote:
> Sergey Ivanovskiy wrote:
> > Committed revision 11553 (4231b) Fixed #4174-191, extract... Sergey Ivanovskiy
12:07 PM Feature #4174: implement calendar control/dtpicker OCX replacement
Sergey Ivanovskiy wrote:
> Committed revision 11553 (4231b) Fixed #4174-191, extracted @CalendarPopup@, @CalendarMon... Vladimir Tsichevski
10:53 AM Feature #4174: implement calendar control/dtpicker OCX replacement
Committed revision 11553 (4231b) Fixed #4174-191, extracted @CalendarPopup@, @CalendarMonthModel@, added @ButtonFacto... Sergey Ivanovskiy
06:20 AM Feature #4174: implement calendar control/dtpicker OCX replacement
Planning to refactor CalendarGuiImpl in order that CalendarPopup can be used independently and to commit today. Sergey Ivanovskiy
03:39 AM Feature #4170: add drag and drop support to treeview widget
It seems that @OlePictureObject@ is exported by @olepro32.dll@ or @oleaut32.dll@, @https://www.nirsoft.net/utils/dll_... Sergey Ivanovskiy
03:02 AM Feature #4170: add drag and drop support to treeview widget
@LOAD-PICTURE@ should return @OlePictureObject@ according to Progress Docs. It needs to add this new com object to FW... Sergey Ivanovskiy

05/20/2020

06:32 PM Feature #4170: add drag and drop support to treeview widget
Working on the issue from #4170-135.
 Sergey Ivanovskiy
06:29 PM Feature #4170: add drag and drop support to treeview widget
Please review rev 11550 (4231b) that implemented @LOAD-PICTURE@ and @ADD@ with complete set of parameters. I tested w... Sergey Ivanovskiy
04:26 AM Feature #4170: add drag and drop support to treeview widget
Planning to test and to commit this diff that should implement LOAD-PICTURE, ADD with icons according to #4170-115. Sergey Ivanovskiy
05:55 PM Feature #4174: implement calendar control/dtpicker OCX replacement
Vladimir Tsichevski wrote:
> The following code looks suspicious (line 1168):
>
> [...]
>
> If the new value i... Sergey Ivanovskiy
05:45 PM Feature #4174: implement calendar control/dtpicker OCX replacement
The following code looks suspicious (line 1168):... Vladimir Tsichevski
05:31 PM Feature #4174: implement calendar control/dtpicker OCX replacement
Vladimir Tsichevski wrote:
> The argument of the following constructor is not used:
> [...]
>
> Meanwhile, there... Vladimir Tsichevski
05:21 PM Feature #4174: implement calendar control/dtpicker OCX replacement
The argument of the following constructor is not used:... Vladimir Tsichevski
11:15 AM Feature #4174: implement calendar control/dtpicker OCX replacement
Constantin Asofiei wrote:
> Vladimir Tsichevski wrote:
> > Constantin Asofiei wrote:
> > > Vladimir, please try to... Vladimir Tsichevski
11:11 AM Feature #4174: implement calendar control/dtpicker OCX replacement
Vladimir Tsichevski wrote:
> Constantin Asofiei wrote:
> > Vladimir, please try to set the calendar's parent via @c... Sergey Ivanovskiy
11:03 AM Feature #4174: implement calendar control/dtpicker OCX replacement
Vladimir Tsichevski wrote:
> Constantin Asofiei wrote:
> > Vladimir, please try to set the calendar's parent via @c... Constantin Asofiei
09:16 AM Feature #4174: implement calendar control/dtpicker OCX replacement
Constantin Asofiei wrote:
> Vladimir, please try to set the calendar's parent via @calendarWidget.setParent(this)@, ... Vladimir Tsichevski
09:37 AM Bug #4631: Widget scoped to wrong frame on hide
Added @uast/frames/frame_broken_hide.p@ testcase, which also exhibits runtime issues with a widget being passed in wh... Roger Borrello

05/19/2020

04:40 AM Feature #4174: implement calendar control/dtpicker OCX replacement
Vladimir, please try to set the calendar's parent via @calendarWidget.setParent(this)@, in @TestCalendarWidget@. Constantin Asofiei
03:33 AM Feature #4174: implement calendar control/dtpicker OCX replacement
Vladimir, extracting @CalendarPopup@ can be done if we take into account its parent and its @CalendarMonthModel@, fon... Sergey Ivanovskiy
01:57 AM Feature #4174: implement calendar control/dtpicker OCX replacement
Vladimir Tsichevski wrote:
> Sergey Ivanovskiy wrote:
>
> > It seems that @CalendarGuiImpl@ should be refactored ... Sergey Ivanovskiy

05/18/2020

04:57 PM Feature #4174: implement calendar control/dtpicker OCX replacement
Vladimir, where can I see the source code for the @AbstractDialog@ and @TestCalendarWidget@ files?... Constantin Asofiei
04:56 PM Feature #4174: implement calendar control/dtpicker OCX replacement
Do you have the default window shown? Do a @message "start."@ to display the default window, at the beginning of the ... Constantin Asofiei
04:51 PM Feature #4174: implement calendar control/dtpicker OCX replacement
Constantin Asofiei wrote:
> Vladimir, from @CalendarGuiImpl.updateSize()@:
> [...]
> Are you trying to test the ... Vladimir Tsichevski
04:46 PM Feature #4174: implement calendar control/dtpicker OCX replacement
Vladimir Tsichevski wrote:
> Sergey Ivanovskiy wrote:
> > The committed rev 11547 fixed unset background and foregr... Sergey Ivanovskiy
04:42 PM Feature #4174: implement calendar control/dtpicker OCX replacement
Vladimir, from @CalendarGuiImpl.updateSize()@:... Constantin Asofiei
04:36 PM Feature #4174: implement calendar control/dtpicker OCX replacement
Sergey Ivanovskiy wrote:
> It seems that @CalendarGuiImpl@ should be refactored in order to be run as a client.
... Vladimir Tsichevski
04:29 PM Feature #4174: implement calendar control/dtpicker OCX replacement
Sergey Ivanovskiy wrote:
> The committed rev 11547 fixed unset background and foreground colors used for selected te... Vladimir Tsichevski
04:26 PM Feature #4174: implement calendar control/dtpicker OCX replacement
Sergey Ivanovskiy wrote:
> Exception in thread "main" java.lang.NullPointerException
> [...]
>
I have not mana... Vladimir Tsichevski
04:23 PM Feature #4174: implement calendar control/dtpicker OCX replacement
Sergey Ivanovskiy wrote:
> Vladimir, what is the purpose of such tests? You used @org.eclipse.jdt.annotation.Nullabl... Vladimir Tsichevski
04:11 PM Feature #4174: implement calendar control/dtpicker OCX replacement
Sergey Ivanovskiy wrote:
> It looks like this code can be tried
> [...]
I changed the code, now I get... Vladimir Tsichevski
03:53 PM Feature #4174: implement calendar control/dtpicker OCX replacement
Sergey Ivanovskiy wrote:
> I found the code for AbstractDialog.java, but couldn't find TestCalendarWidget.
I fo... Vladimir Tsichevski
12:57 PM Feature #4174: implement calendar control/dtpicker OCX replacement
The committed rev 11547 fixed unset background and foreground colors used for selected text.This issue was found when... Sergey Ivanovskiy
11:29 AM Feature #4174: implement calendar control/dtpicker OCX replacement
Vladimir, what is the purpose of such tests? You used @org.eclipse.jdt.annotation.Nullable@ annotation. Are these tes... Sergey Ivanovskiy
01:59 PM Feature #3880: enhanced browse 3rd phase of improvements
We don't have anyone else available. Hynek and Eugenie have experience in the drag and drop support for web client. ... Greg Shah
01:51 PM Feature #3880: enhanced browse 3rd phase of improvements
> Web column/row resize issues.
Here is the list of issues:
# Column resize:
## Chrome: works, however the area w... Stanislav Lomany

05/17/2020

04:49 PM Feature #4174: implement calendar control/dtpicker OCX replacement
I didn't note that the widget value should be set via @cfg.dateTimeValue@ because @calendarWidget.setValue@ was not i... Sergey Ivanovskiy
04:42 PM Feature #4174: implement calendar control/dtpicker OCX replacement
It looks like this code can be tried... Sergey Ivanovskiy
04:35 PM Feature #4174: implement calendar control/dtpicker OCX replacement
I guessed that visibility of buttons (popup, up and down buttons) are set by @afterConfigUpdate()@ thus the popup but... Sergey Ivanovskiy
03:50 PM Feature #4174: implement calendar control/dtpicker OCX replacement
Vladimir Tsichevski wrote:
> Sergey Ivanovskiy wrote:
> > Vladimir, it can be that you should invoke @CalendarGuiIm... Sergey Ivanovskiy

05/16/2020

05:35 PM Feature #4174: implement calendar control/dtpicker OCX replacement
Sergey Ivanovskiy wrote:
> Vladimir, it can be that you should invoke @CalendarGuiImpl.this.initialize(WidgetId id, ... Vladimir Tsichevski
04:35 PM Feature #4174: implement calendar control/dtpicker OCX replacement
Vladimir, it can be that you should invoke @CalendarGuiImpl.this.initialize(WidgetId id, CalendarConfig cfg)@ artific... Sergey Ivanovskiy
04:28 PM Feature #4174: implement calendar control/dtpicker OCX replacement
Vladimir Tsichevski wrote:
> Is it possible to run this the calendar or its parts as a pure-client widget?
>
> I ... Sergey Ivanovskiy

05/15/2020

05:35 PM Feature #3880: enhanced browse 3rd phase of improvements
Yes, if you can do it quickly. Greg Shah
05:11 PM Feature #3880: enhanced browse 3rd phase of improvements
> add support for scroll-notify
Do I need to add support for @scroll-horizontal@ and @scroll-vertical@ as well? Stanislav Lomany
05:32 PM Feature #4174: implement calendar control/dtpicker OCX replacement
Is it possible to run this the calendar or its parts as a pure-client widget?
I used the @uast/calendar/test-calen... Vladimir Tsichevski
12:09 PM Feature #4170: add drag and drop support to treeview widget
Sergey Ivanovskiy wrote:
> OK. I have a test case and planning to add more. Some open source 4GL code uses @LOAD-PIC... Hynek Cihlar
10:39 AM Feature #4170: add drag and drop support to treeview widget
OK. I have a test case and planning to add more. Some open source 4GL code uses @LOAD-PICTURE@... Sergey Ivanovskiy
10:27 AM Feature #4170: add drag and drop support to treeview widget
Sergey Ivanovskiy wrote:
> I found some usages:
> [...]
> and there are many actual usages of @hImage:ImageList:Li... Hynek Cihlar
10:21 AM Feature #4170: add drag and drop support to treeview widget
I found some usages:... Sergey Ivanovskiy
09:33 AM Feature #4170: add drag and drop support to treeview widget
Sergey Ivanovskiy wrote:
> Can these changes break the customer's code? I didn't know all usages of @ImageList@.
... Hynek Cihlar
09:25 AM Feature #4170: add drag and drop support to treeview widget
> Hynek Cihlar wrote:
> > Sergey Ivanovskiy wrote:
> > Now the conversion of
> > [...]
> > is failed with NPE
> ... Sergey Ivanovskiy
07:32 AM Feature #4394 (Test): add some frame options and attributes
Greg Shah

05/14/2020

06:33 PM Feature #4394: add some frame options and attributes
According to #4394-4 this task should only cover @FRAME-NAME@, so it can be moved to Test. Roger Borrello
06:23 PM Feature #4164: implement misc UI features (frame options, misc attributes)
h2. USE-TEXT
This looks like it's working properly. However, there are 2 UI issues, one might be related, the othe... Roger Borrello
04:33 PM Feature #4164: implement misc UI features (frame options, misc attributes)
Even though documentation for @IS-ATTR-SPACE@ function indicates it is also supported only for backward compatibility... Roger Borrello
02:42 PM Feature #4164: implement misc UI features (frame options, misc attributes)
One issue is there isn't any documentation indicating the proper usage, or even what @ATTR-SPACE@ and @NO-ATTR-SPACE@... Roger Borrello
01:58 PM Feature #4164: implement misc UI features (frame options, misc attributes)
Prove it (with testcases). You can only do this with frame that have many widgets. Make sure you test:
* more th... Greg Shah
01:19 PM Feature #4164: implement misc UI features (frame options, misc attributes)
h2. NO-ATTR-SPACE
All the documentation indicates @ATTR-SPACE@ and @NO-ATTR-SPACE@ have no effect. That they are s... Roger Borrello
03:14 PM Bug #4643: Wrong text width calculation in Swing driver
Vladimir Tsichevski wrote:
> Does the JS version wrong results as the @SwingGuiDriver@ does? If not, then we can jus... Constantin Asofiei
02:55 PM Bug #4643: Wrong text width calculation in Swing driver
Constantin Asofiei wrote:
> The @getStringBounds@ approach is different than the @awt.FontMetrics@ used by @SwingFon... Vladimir Tsichevski
10:28 AM Bug #4643: Wrong text width calculation in Swing driver
The @getStringBounds@ approach is different than the @awt.FontMetrics@ used by @SwingFontMetrics@. The @Native@ suff... Constantin Asofiei
10:26 AM Bug #4643: Wrong text width calculation in Swing driver
> > I'd prefer to just use a new name for the new APIs since it will be used much less than the current APIs.
> Ok. ... Greg Shah
10:24 AM Bug #4643: Wrong text width calculation in Swing driver
Greg Shah wrote:
> I'd prefer to just use a new name for the new APIs since it will be used much less than the cur... Vladimir Tsichevski
10:21 AM Bug #4643: Wrong text width calculation in Swing driver
> If I get it right, in SwingGuiDriver first AWT internals are used to calculate individual character glyph sizes, bu... Greg Shah
09:37 AM Bug #4643: Wrong text width calculation in Swing driver
Comments from GregShah:
> Vladimir,
>
> I suspect that the reason is due to the idea that we are trying to size t... Vladimir Tsichevski
09:34 AM Bug #4643: Wrong text width calculation in Swing driver
To calculate widget optimal sizes, editor cursor position etc., we need to know the text width for a given string on ... Vladimir Tsichevski
09:24 AM Bug #4643 (New): Wrong text width calculation in Swing driver
Vladimir Tsichevski
02:48 PM Feature #4170: add drag and drop support to treeview widget
Hynek Cihlar wrote:
> Sergey Ivanovskiy wrote:
> > I found an issue with ThinClient.getMousePosition(widgetId) for ... Sergey Ivanovskiy
02:26 PM Feature #4170: add drag and drop support to treeview widget
Sergey Ivanovskiy wrote:
> Hynek, could you help to explain why @ThinClient.hitTest@ was in these @setInvalidate@-br... Hynek Cihlar
02:25 PM Feature #4170: add drag and drop support to treeview widget
Sergey Ivanovskiy wrote:
> I found an issue with ThinClient.getMousePosition(widgetId) for the Swing client related ... Hynek Cihlar
12:05 PM Feature #4170: add drag and drop support to treeview widget
Hynek, could you help to explain why @ThinClient.hitTest@ was in these @setInvalidate@-braces?... Sergey Ivanovskiy
08:24 AM Feature #4170: add drag and drop support to treeview widget
I found an issue with ThinClient.getMousePosition(widgetId) for the Swing client related to @AbstractWidget.displayPh... Sergey Ivanovskiy

05/13/2020

02:01 PM Feature #4170: add drag and drop support to treeview widget
Sergey Ivanovskiy wrote:
> Hynek, could you clarify why @TreeFace.getNodeAt@ has @GET-NODE-AT@ legacy method annotat... Hynek Cihlar
01:08 PM Feature #4170: add drag and drop support to treeview widget
Hynek, could you clarify why @TreeFace.getNodeAt@ has @GET-NODE-AT@ legacy method annotation?... Sergey Ivanovskiy
11:17 AM Feature #4170: add drag and drop support to treeview widget
Hynek Cihlar wrote:
> Sergey Ivanovskiy wrote:
> > Hynek, could you add new testcases for @TREELIST@ widget usages?... Sergey Ivanovskiy
11:05 AM Feature #4170: add drag and drop support to treeview widget
Sergey Ivanovskiy wrote:
> Hynek, could you add new testcases for @TREELIST@ widget usages? I didn't find @TREELIST@... Hynek Cihlar
10:54 AM Feature #4170: add drag and drop support to treeview widget
Hynek, could you add new testcases for @TREELIST@ widget usages? I didn't find @TREELIST@ examples in the @testcases@... Sergey Ivanovskiy
06:13 AM Feature #4170: add drag and drop support to treeview widget
Hynek Cihlar wrote:
> Sergey Ivanovskiy wrote:
> > Now the conversion of
> > [...]
> > is failed with NPE
> > [.... Sergey Ivanovskiy
05:50 AM Feature #4170: add drag and drop support to treeview widget
Sergey Ivanovskiy wrote:
> Hynek Cihlar wrote:
> > Sergey Ivanovskiy wrote:
> > > Another argument for not using o... Hynek Cihlar
05:44 AM Feature #4170: add drag and drop support to treeview widget
Sergey Ivanovskiy wrote:
> Now the conversion of
> [...]
> is failed with NPE
> [...]
> I prepared ext-hints for... Hynek Cihlar
05:36 AM Feature #4170: add drag and drop support to treeview widget
Hynek Cihlar wrote:
> Sergey Ivanovskiy wrote:
> > Another argument for not using of @hitTest@ directly on the serv... Sergey Ivanovskiy
05:14 AM Feature #4170: add drag and drop support to treeview widget
Sergey Ivanovskiy wrote:
> Another argument for not using of @hitTest@ directly on the server side is that on the se... Hynek Cihlar
05:11 AM Feature #4170: add drag and drop support to treeview widget
Sergey Ivanovskiy wrote:
> Hynek Cihlar wrote:
> > Code review 4231b revision 11541.
> >
> > @ocx_conversion.rul... Hynek Cihlar
04:54 AM Feature #4170: add drag and drop support to treeview widget
Now the conversion of... Sergey Ivanovskiy

05/12/2020

04:35 PM Bug #4636: Make the Theme API independent on concrete implementation classes
Ovidiu Maxiniuc wrote:

> The button background is transparent and the parent frame (part of the combo widget) is ... Vladimir Tsichevski
04:08 PM Bug #4636: Make the Theme API independent on concrete implementation classes
Actually, I took two screen-shots of the combobox implementation from the first page of the hotel-gui test applicatio... Ovidiu Maxiniuc
01:43 PM Bug #4636: Make the Theme API independent on concrete implementation classes
Ovidiu Maxiniuc wrote:
> Not sure I understand the issue. An screen-shot or two (on with current capture and one alt... Vladimir Tsichevski
01:03 PM Bug #4636: Make the Theme API independent on concrete implementation classes
Not sure I understand the issue. An screen-shot or two (on with current capture and one altered to reflect with how i... Ovidiu Maxiniuc
08:20 AM Bug #4636: Make the Theme API independent on concrete implementation classes
Greg Shah wrote:
> > > Just noticed that unless the mouse is hovering over the button or the button is pressed, the ... Eugenie Lyzenko
08:09 AM Bug #4636: Make the Theme API independent on concrete implementation classes
> > Just noticed that unless the mouse is hovering over the button or the button is pressed, the @drawComboBoxButton(... Greg Shah
04:04 PM Feature #4170: add drag and drop support to treeview widget
Another argument for not using of @hitTest@ directly on the server side is that on the server side we need to know th... Sergey Ivanovskiy
03:36 PM Feature #4170: add drag and drop support to treeview widget
Rev 11542 (4231b) fixed @getNodeAt@ to return unknown. But the following change leads to
the conversion becomes inco... Sergey Ivanovskiy
03:02 PM Feature #4170: add drag and drop support to treeview widget
Hynek Cihlar wrote:
> Code review 4231b revision 11541.
>
> @ocx_conversion.rules@, please revert the change. The... Sergey Ivanovskiy
02:30 PM Feature #4170: add drag and drop support to treeview widget
Code review 4231b revision 11541.
@ocx_conversion.rules@, please revert the change. The addition of @get-node-at@ ... Hynek Cihlar
01:20 PM Feature #4170: add drag and drop support to treeview widget
Added @uast/treeview/test-image-list-1.w@ to testcases project. In this 4GL example the @ImageList@ is filled with he... Sergey Ivanovskiy
09:16 AM Feature #4170: add drag and drop support to treeview widget
None of the existing tests from @testcases/uast/image-list@ can be run on 4GL.
 Sergey Ivanovskiy
08:00 AM Feature #4170: add drag and drop support to treeview widget
Sergey Ivanovskiy wrote:
> I found that @ImageListWidget@ should implement these required features
Also look at @... Hynek Cihlar
03:28 AM Feature #4170: add drag and drop support to treeview widget
I found that @ImageListWidget@ should implement these required features Sergey Ivanovskiy
03:08 AM Feature #4170: add drag and drop support to treeview widget
It seems that MS tree view has inside a reference to another COM object via @chCtrlFrame:TreeView:ImageList@ that hol... Sergey Ivanovskiy
02:39 PM Feature #3880: enhanced browse 3rd phase of improvements
> The need for these changes comes from #3765-100 (and #3765-116 through 119). I think the customer code should be mo... Stanislav Lomany

05/11/2020

07:02 PM Bug #4636: Make the Theme API independent on concrete implementation classes
Vladimir Tsichevski wrote:
> Vladimir Tsichevski wrote:
> > The @drawComboBoxButton()@ method signature has been ch... Vladimir Tsichevski
06:57 PM Bug #4636: Make the Theme API independent on concrete implementation classes
Vladimir Tsichevski wrote:
> The @drawComboBoxButton()@ method signature has been changed: a ComboBoxGuiImpl instanc... Vladimir Tsichevski
03:48 PM Feature #4170: add drag and drop support to treeview widget
Hynek, please review the committed revision 11541(4231b) that implemented @GET-NODE-AT@. I used the following program... Sergey Ivanovskiy
01:16 PM Feature #4170: add drag and drop support to treeview widget
If the input is relative to the window origin, then @pnt = C-Win:GET-MOUSE-POSITION().@ gets the mouse position for @... Sergey Ivanovskiy
12:03 PM Feature #4170: add drag and drop support to treeview widget
The following 4GL code ... Sergey Ivanovskiy
11:19 AM Feature #3880: enhanced browse 3rd phase of improvements
I assume this is a quick fix, right? If so, yes. Greg Shah
10:55 AM Feature #3880: enhanced browse 3rd phase of improvements
I've found that for browse editing fields, at least for character type, a field doesn't switch to _insert_ mode when ... Stanislav Lomany

05/10/2020

04:22 AM Feature #3880: enhanced browse 3rd phase of improvements
Rebased task branch 3880a from P2J trunk revision 11346. Stanislav Lomany

05/08/2020

05:56 PM Bug #4636: Make the Theme API independent on concrete implementation classes
The @drawComboBoxButton()@ method signature has been changed: a ComboBoxGuiImpl instance is not required anymore for ... Vladimir Tsichevski
02:17 PM Feature #4170: add drag and drop support to treeview widget
Sergey Ivanovskiy wrote:
> Hynek Cihlar wrote:
> > Hynek Cihlar wrote:
> > > Sergey Ivanovskiy wrote:
> > > > The... Hynek Cihlar
01:34 PM Feature #4170: add drag and drop support to treeview widget
Hynek Cihlar wrote:
> Hynek Cihlar wrote:
> > Sergey Ivanovskiy wrote:
> > > The @hitTest@ becomes working properl... Sergey Ivanovskiy
01:16 PM Feature #4170: add drag and drop support to treeview widget
Hynek Cihlar wrote:
> Sergey Ivanovskiy wrote:
> > The @hitTest@ becomes working properly with @hitTestFwd@ extensi... Hynek Cihlar
01:10 PM Feature #4170: add drag and drop support to treeview widget
Sergey Ivanovskiy wrote:
> The @hitTest@ becomes working properly with @hitTestFwd@ extension if these changes are a... Hynek Cihlar
01:05 PM Feature #4170: add drag and drop support to treeview widget
The @hitTest@ becomes working properly with @hitTestFwd@ extension if these changes are applied... Sergey Ivanovskiy
03:43 AM Feature #4170: add drag and drop support to treeview widget
Sergey Ivanovskiy wrote:
> Hynek Cihlar wrote:
> > Sergey Ivanovskiy wrote:
> > > Are there another ways to get ta... Hynek Cihlar
08:19 AM Feature #3880: enhanced browse 3rd phase of improvements
> For CENTER-align columns in editing mode, I think we can leave the fill-in left-aligned.
Agreed. The CENTER ali... Greg Shah

05/07/2020

05:02 PM Feature #3880: enhanced browse 3rd phase of improvements
> *** This should support values of @LEFT@, @RIGHT@ and @CENTER@.
For CENTER-align columns in editing mode, I thin... Stanislav Lomany
02:50 PM Feature #4170: add drag and drop support to treeview widget
The committed rev 11534(4231b) extracted the control frame name from the ActiveX event procedure name and then used i... Sergey Ivanovskiy
02:19 PM Bug #4636: Make the Theme API independent on concrete implementation classes
Sergey Ivanovskiy wrote:
> As this part starts its changes, does it make sense to use container classes to gather co... Vladimir Tsichevski
02:09 PM Bug #4636: Make the Theme API independent on concrete implementation classes
As this part starts its changes, does it make sense to use container classes to gather common parameters for these me... Sergey Ivanovskiy
10:00 AM Bug #4636: Make the Theme API independent on concrete implementation classes
The @drawButton()@ method signature has been changed: a ButtonGuiImpl instance is not required anymore for this metho... Vladimir Tsichevski

05/06/2020

02:51 PM Bug #4636: Make the Theme API independent on concrete implementation classes
Below is the first draft of the list of candidates for API change. Note: some of these calls, like Browser-related, a... Vladimir Tsichevski
09:12 AM Bug #4636 (WIP): Make the Theme API independent on concrete implementation classes
Vladimir Tsichevski
09:09 AM Bug #4636: Make the Theme API independent on concrete implementation classes
h1. The problem
By its nature and goal, the FWD GUI Themes shall be an independent drawing primitives library. All... Vladimir Tsichevski
08:24 AM Bug #4636 (WIP): Make the Theme API independent on concrete implementation classes
Vladimir Tsichevski
12:46 PM Feature #4170: add drag and drop support to treeview widget
Hynek Cihlar wrote:
> Sergey Ivanovskiy wrote:
> > Are there another ways to get target widget type when annotation... Sergey Ivanovskiy
09:51 AM Feature #4170: add drag and drop support to treeview widget
Sergey Ivanovskiy wrote:
> Are there another ways to get target widget type when annotation rules are processed?
... Hynek Cihlar
08:05 AM Feature #4170: add drag and drop support to treeview widget
Please review the committed revision 11526 (4231b) that added COM-SELF conversion with this hint file... Sergey Ivanovskiy
09:29 AM Feature #3880: enhanced browse 3rd phase of improvements
Stanislav Lomany wrote:
> > Provide a 4GL syntax option to disable user-controlled sorting for that specific browse ... Greg Shah

05/05/2020

01:17 PM Feature #3880: enhanced browse 3rd phase of improvements
> Provide a 4GL syntax option to disable user-controlled sorting for that specific browse instance.
Turns out we a... Stanislav Lomany
11:39 AM Feature #4170: add drag and drop support to treeview widget
I used these changes now with this hint... Sergey Ivanovskiy
11:27 AM Feature #4170: add drag and drop support to treeview widget
Hynek Cihlar wrote:
> Sergey Ivanovskiy wrote:
> > will be converted into this java expression @self().unwrapTreeFa... Sergey Ivanovskiy
06:23 AM Feature #4170: add drag and drop support to treeview widget
Sergey Ivanovskiy wrote:
> will be converted into this java expression @self().unwrapTreeFace().getNodes().getCount(... Hynek Cihlar
04:49 AM Feature #4170: add drag and drop support to treeview widget
Planning to convert @COM-SELF@ into @self()@ and unwrap the target type using provided @java-class-name@ annotation s... Sergey Ivanovskiy

05/04/2020

06:12 PM Feature #4170: add drag and drop support to treeview widget
Sergey Ivanovskiy wrote:
> Thanks, changing all these methods in @ProgressBar@ to accept @NumericType@ in rev 11454 ... Hynek Cihlar
05:54 PM Bug #4631: Widget scoped to wrong frame on hide
Task ready for test. Roger Borrello
05:39 PM Feature #3880: enhanced browse 3rd phase of improvements
Stanislav Lomany wrote:
> > Provide a 4GL syntax option to disable user-controlled sorting for that specific browse ... Greg Shah
05:28 PM Feature #3880: enhanced browse 3rd phase of improvements
> Provide a 4GL syntax option to disable user-controlled sorting for that specific browse instance.
Are we talking... Stanislav Lomany

05/02/2020

03:06 PM Feature #4170: add drag and drop support to treeview widget
I tested @hitTest@ method on 4GL using this committed test case @uast/treeview/test-treeview-sp6-1.w@. @chCtrlFrame:T... Sergey Ivanovskiy
11:18 AM Feature #4170: add drag and drop support to treeview widget
Although the conversion of this code ... Sergey Ivanovskiy
11:07 AM Feature #4170: add drag and drop support to treeview widget
Thanks, changing all these methods in @ProgressBar@ to accept @NumericType@ in rev 11454 solves this compilation issu... Sergey Ivanovskiy
10:21 AM Feature #4170: add drag and drop support to treeview widget
Sergey Ivanovskiy wrote:
> I rechecked these test cases:
>
> there are compilation errors now
This is after my ... Hynek Cihlar
06:59 AM Feature #4170: add drag and drop support to treeview widget
I rechecked these test cases:... Sergey Ivanovskiy

05/01/2020

02:40 PM Feature #4170: add drag and drop support to treeview widget
Sergey Ivanovskiy wrote:
> Please correct if the following requirements are incorrect. It needs to implement @GET-NO... Hynek Cihlar
02:37 PM Feature #4170: add drag and drop support to treeview widget
Please correct if the following requirements are incorrect. It needs to implement @GET-NODE-AT(X, Y)@ for the tree wi... Sergey Ivanovskiy
02:02 PM Feature #4170: add drag and drop support to treeview widget
Sergey Ivanovskiy wrote:
> Eugenie Lyzenko wrote:
> > Sergey Ivanovskiy wrote:
> > > Committed rev 11507 (4231b) s... Eugenie Lyzenko
01:55 PM Feature #4170: add drag and drop support to treeview widget
Eugenie Lyzenko wrote:
> Sergey Ivanovskiy wrote:
> > Committed rev 11507 (4231b) should fix issues found in the re... Sergey Ivanovskiy
10:21 AM Feature #4170: add drag and drop support to treeview widget
Eugenie Lyzenko wrote:
> Sergey Ivanovskiy wrote:
> > Eugenie, I am not aware of this method. Could you help to fin... Hynek Cihlar
01:51 PM Feature #4394 (WIP): add some frame options and attributes
The other 2 tasks are TBD, so backing up this task to 30%.
* @SCROLL@ frame option
* @NO-ATTR-SPACE@ frame option Roger Borrello
01:05 PM Feature #4164: implement misc UI features (frame options, misc attributes)
Testcase passes in ChUI, as well. Roger Borrello
11:19 AM Bug #4631: Widget scoped to wrong frame on hide
Committed revision 4231b-11509. Roger Borrello
11:18 AM Bug #4631 (WIP): Widget scoped to wrong frame on hide
Roger Borrello
11:01 AM Bug #4631: Widget scoped to wrong frame on hide
I was able to find a few critical places where @frameLName@ was not being stored off, resulting in the downstream bre... Roger Borrello
09:04 AM Bug #4631: Widget scoped to wrong frame on hide
> Everywhere the frame name was being stored/retrieved from the frameName map in lowercase, I was doing the same with... Greg Shah
12:48 AM Bug #4631: Widget scoped to wrong frame on hide
There was a missing @def frame x@ I added, after taking a closer look at the code that broke.... Roger Borrello
09:20 AM Feature #3880: enhanced browse 3rd phase of improvements
Stanislav Lomany wrote:
> > Considering the latest changes in reports, keys used for report caching are not accurate... Greg Shah
06:57 AM Feature #3880: enhanced browse 3rd phase of improvements
> Considering the latest changes in reports, keys used for report caching are not accurate any more. Use the same key... Stanislav Lomany
 

Also available in: Atom