Project

General

Profile

Activity

From 03/29/2022 to 04/27/2022

04/27/2022

07:24 PM Bug #5622: TREEVIEW widget issues
Vladimir Tsichevski wrote:
> Tijs Wickardt wrote:
> > On Wed 2022-04-20 we parked some @treeview@ issues. See @xfer...
Tijs Wickardt
06:51 PM Bug #5622: TREEVIEW widget issues
Hynek Cihlar wrote:
> I assume you mean the following statement: @hNode = chCfTreeView:TreeView:Nodes:Add(,,cParen...
Vladimir Tsichevski
06:17 PM Bug #5622: TREEVIEW widget issues
Another difference: in OCX the first argument to the @add@ procedure is a 1-based node index, and cannot be zero.
In...
Vladimir Tsichevski
01:16 PM Bug #5622: TREEVIEW widget issues
Tijs Wickardt wrote:
> On Wed 2022-04-20 we parked some @treeview@ issues. See @xfer testcases@ , @ocx_to_fwd/mscomc...
Vladimir Tsichevski
05:32 AM Bug #5622: TREEVIEW widget issues
Tijs Wickardt wrote:
> On Wed 2022-04-20 we parked some @treeview@ issues. See @xfer testcases@ , @ocx_to_fwd/mscomc...
Hynek Cihlar
02:33 AM Bug #5622: TREEVIEW widget issues
On Wed 2022-04-20 we parked some @treeview@ issues. See @xfer testcases@ , @ocx_to_fwd/mscomctl-treeview-ocx.readme.t... Tijs Wickardt
07:16 AM Bug #6038: ComboBox setScreenValue improvements
Greg Shah wrote:
> ** if multiple different format strings are defined (e.g. explicit @FORMAT ""@ definitions or imp...
Marian Edu
05:57 AM Bug #6267: StackOverflowError in BROWSE widget
I tested FWD with WINDOWS-1252 and the changes discussed in this thread and found many new issues for Swing and Web c... Sergey Ivanovskiy

04/26/2022

03:56 PM Bug #6267: StackOverflowError in BROWSE widget
It is okey. I cannot find how to setup of @i18n@ node in the directory. Is @i18n@ a node of @container@ class?
<pre...
Sergey Ivanovskiy
02:47 PM Bug #6267: StackOverflowError in BROWSE widget
Sergey Ivanovskiy wrote:
> Sergey Ivanovskiy wrote:
> > It seems that the @Keyboard@ can use unicode codepoints whe...
Hynek Cihlar
02:32 PM Bug #6267: StackOverflowError in BROWSE widget
Sergey Ivanovskiy wrote:
> It seems that the @Keyboard@ can use unicode codepoints when it initializes basic keys
>...
Sergey Ivanovskiy
06:41 AM Bug #6267: StackOverflowError in BROWSE widget
It seems that the @Keyboard@ can use unicode codepoints when it initializes basic keys... Sergey Ivanovskiy
06:36 AM Bug #6267: StackOverflowError in BROWSE widget
If integer value is within [0, 255], then it can be decoded using the current internal codepage given by @cpinternal@... Sergey Ivanovskiy
10:57 AM Bug #6298: Display using format
> Question - do we need to handle the case when the @value@ passed to @setScreenValue@ might be @FormatedValue@ (by l... Greg Shah
06:44 AM Bug #6298: Display using format
Looking at some issues with screen-value when the widget is using a custom format and the @display@ statement is used... Marian Edu
06:25 AM Bug #6298 (New): Display using format
Marian Edu
10:56 AM Bug #6038: ComboBox setScreenValue improvements
Our current approach can be described like this:
* static widgets (both client-side and server-side) are aware of ...
Greg Shah

04/25/2022

02:09 PM Bug #6267: StackOverflowError in BROWSE widget
OK, fix it. Greg Shah
01:59 PM Bug #6267: StackOverflowError in BROWSE widget
I checked that Apply statement interprets integer expression according to @cpinternal@ code page so @APPLY 225 TO EDI... Sergey Ivanovskiy
11:58 AM Bug #6267: StackOverflowError in BROWSE widget
Our approach is to use Unicode throughout all internal Java/Javascript code and we only convert to/from the @CPINTERN... Greg Shah
11:00 AM Bug #6267: StackOverflowError in BROWSE widget
I cannot answer these two questions. In this code... Sergey Ivanovskiy

04/22/2022

03:22 PM Bug #6267: StackOverflowError in BROWSE widget
It looks like the code from @I18nOps@ isn't used by @Keyboard@ but @String cset = Utils.getCharsetOverride();@ is use... Sergey Ivanovskiy
01:51 PM Bug #6267: StackOverflowError in BROWSE widget
Thank you. I have found this code @I18nOps@ too. Sergey Ivanovskiy
01:39 PM Bug #6267: StackOverflowError in BROWSE widget
Sergey Ivanovskiy wrote:
> Could you point me what is code that is responsible for providing @cpinternal@ and @cpstr...
Greg Shah
01:36 PM Bug #6267: StackOverflowError in BROWSE widget
Could you point me what is code that is responsible for providing @cpinternal@ and @cpstream@ codepage settings? I wo... Sergey Ivanovskiy

04/21/2022

05:51 PM Bug #6267: StackOverflowError in BROWSE widget
> I'll commit the fix for double @super.processKeyEvent(ke)@
Committed as 3821c rev 13808.
Stanislav Lomany
05:15 PM Bug #6267: StackOverflowError in BROWSE widget
> Theoretically, no, @return isPrintable(keyLabel(key));@ should be enough, as those places have already the proper @... Stanislav Lomany
10:53 AM Bug #6267: StackOverflowError in BROWSE widget
Stanislav Lomany wrote:
> What about the cases when @isReal@ flag is @true@, but it's not called from @EventManager....
Constantin Asofiei
10:44 AM Bug #6267: StackOverflowError in BROWSE widget
What about the cases when @isReal@ flag is @true@, but it's not called from @EventManager.getKeyEvent@? Do we preserv... Stanislav Lomany
05:47 AM Bug #6267: StackOverflowError in BROWSE widget
Stanislav Lomany wrote:
> > I agree, a replacement to be called by @EventManager.getKeyEvent@, when @isReal@ flag is...
Constantin Asofiei
04:02 AM Bug #6267: StackOverflowError in BROWSE widget
Stanislav, I would propose to discuss the following topics:
# To add a special keyboard layout to handle Cyrillic ch...
Sergey Ivanovskiy
08:14 PM Bug #6267: StackOverflowError in BROWSE widget
> I agree, a replacement to be called by @EventManager.getKeyEvent@, when @isReal@ flag is true.
Constantin, do ...
Stanislav Lomany
07:44 AM Bug #6053 (WIP): Widget realisation
Marian Edu

04/20/2022

07:46 PM Bug #6267: StackOverflowError in BROWSE widget
> * DELETE - considered as printable. It has code 127 and I have to say that it was considered as printable before th... Stanislav Lomany
07:40 PM Bug #6267: StackOverflowError in BROWSE widget
> It is worth checking the obvious cases that can be generated by Firefox/Chrome with your keyboard. Perhaps there a... Stanislav Lomany
07:44 AM Bug #6267: StackOverflowError in BROWSE widget
> Greg, should I check all the other keys?
It is worth checking the obvious cases that can be generated by Firefox...
Greg Shah
03:58 AM Bug #6267: StackOverflowError in BROWSE widget
Stanislav Lomany wrote:
> > I agree, a replacement to be called by @EventManager.getKeyEvent@, when @isReal@ flag is...
Constantin Asofiei
03:45 AM Bug #6267: StackOverflowError in BROWSE widget
> I agree, a replacement to be called by @EventManager.getKeyEvent@, when @isReal@ flag is true.
Constantin, are y...
Stanislav Lomany

04/19/2022

10:43 AM Bug #6267: StackOverflowError in BROWSE widget
Greg Shah wrote:
> Getting rid of the regression is important.
The fix from 3821c/13785 solves the regression.
>...
Constantin Asofiei
09:30 AM Bug #6267: StackOverflowError in BROWSE widget
What I mean by separate, is create a replacement for @isPrintableKey()@ for the user-typed key. It should be named d... Greg Shah
09:28 AM Bug #6267: StackOverflowError in BROWSE widget
Why not separate these cases and do the safe thing at this point? Getting rid of the regression is important. Greg Shah

04/18/2022

08:52 AM Bug #6282: Combo-box VALUE-CHANGED
For drop-down/drop-down-list combo-box when the drop down list is made visible and a value is selected before closing... Marian Edu
08:51 AM Bug #6282 (New): Combo-box VALUE-CHANGED
Marian Edu
05:44 AM Bug #6267: StackOverflowError in BROWSE widget
> If you see other places where @isPrintableKey@ receives the code generated by a generated key press, please specify... Stanislav Lomany
05:42 AM Bug #6267: StackOverflowError in BROWSE widget
Constantin Asofiei wrote:
> About the euro sign: you are right, pressing CTRL-ALT-5 generates the euro sign in OE (w...
Sergey Ivanovskiy
05:04 AM Bug #6267: StackOverflowError in BROWSE widget
Not exactly. The only place in FWD where @isPrintableKey@ receives the key code generated as it was typed by the use... Constantin Asofiei
04:49 AM Bug #6267: StackOverflowError in BROWSE widget
Constantin, so we have
* a "key code" which is a number that can be supplied to @APPLY@ or generated by a key press...
Stanislav Lomany
02:57 AM Bug #6267: StackOverflowError in BROWSE widget
It can be more clear if someone run this java program... Sergey Ivanovskiy

04/17/2022

03:52 PM Bug #6267: StackOverflowError in BROWSE widget
So if you would apply @APPLY 128 TO ch.@ using codepage @Windows-1252@, then you got the euro sign in the target field. Sergey Ivanovskiy
03:45 PM Bug #6267: StackOverflowError in BROWSE widget
Constantin, the decimal code @8364@ for the euro sign is just a representation of the euro sign but its key code can ... Sergey Ivanovskiy

04/16/2022

09:06 AM Bug #6267: StackOverflowError in BROWSE widget
A problem with @Keyboard.isPrintable@ originates from having to distinguish between characters being pressed by the u... Constantin Asofiei

04/15/2022

04:57 PM Bug #6267: StackOverflowError in BROWSE widget
Greg Shah wrote:
> Vladimir: Please use @bzr blame@ and report who wrote the code in question....
Vladimir Tsichevski
02:46 PM Bug #6267: StackOverflowError in BROWSE widget
Unfortunately, Nick Saxon is the original author of the majority of the @Keyboard@ class, including the key action/fu... Greg Shah
02:37 PM Bug #6267 (WIP): StackOverflowError in BROWSE widget
OK, now we're on the same page.
Greg, I checked usages of @isPrintableKey(int key)@ and half of them pass @KeyInpu...
Stanislav Lomany
01:49 PM Bug #6267: StackOverflowError in BROWSE widget
It seems that this function should be implemented using @evt.keyCode()@... Sergey Ivanovskiy
01:36 PM Bug #6267: StackOverflowError in BROWSE widget
Stanislav Lomany wrote:
> Consider we have a @KeyInput@ with @KeyInput.key = 501@ and @KeyInput.actionCode = -119@. ...
Sergey Ivanovskiy
01:17 PM Bug #6267: StackOverflowError in BROWSE widget
Consider we have a @KeyInput@ with @KeyInput.key = 501@ and @KeyInput.actionCode = -119@. I'm telling that it looks l... Stanislav Lomany
11:05 AM Bug #6267: StackOverflowError in BROWSE widget
In our system the key codes from 501 to 509 belong the the navigation key set and if @KeyCode@ belongs this range, th... Sergey Ivanovskiy
09:57 AM Bug #6267: StackOverflowError in BROWSE widget
> Stanislav, it seems that @KeyInput@ is created from @TypeAHead@ with help of @EventManager.eventFromKey@. So @Keybo... Stanislav Lomany
09:18 AM Bug #6267: StackOverflowError in BROWSE widget
Stanislav Lomany wrote:
> So it looks like you excluded @ǵ@ and some other chars from the printable range.
Yes.
Sergey Ivanovskiy
09:17 AM Bug #6267: StackOverflowError in BROWSE widget
Stanislav, it seems that @KeyInput@ is created from @TypeAHead@ with help of @EventManager.eventFromKey@. So @Keyboar... Sergey Ivanovskiy
08:53 AM Bug #6267: StackOverflowError in BROWSE widget
So it looks like you excluded @ǵ@ and some other chars from the printable range. Stanislav Lomany
08:51 AM Bug #6267: StackOverflowError in BROWSE widget
> I found that this unicode symbol ǵ has decimal code 501. It seems that my changes are correct.
Right, but we don...
Stanislav Lomany
08:09 AM Bug #6267: StackOverflowError in BROWSE widget
Stanislav Lomany wrote:
>
> An arrow doesn't seem to fall into any of these categories. So it should return @true@ ...
Sergey Ivanovskiy
06:34 AM Bug #6267: StackOverflowError in BROWSE widget
Igor, please take a look at the code which Vladimir posted in #6267-1. We have double @super.processKeyEvent(ke)@ cal... Stanislav Lomany
06:30 AM Bug #6267: StackOverflowError in BROWSE widget
> And, in any case, the program should be guarded against unlimited recursion.
I would say the keys in the browse ...
Stanislav Lomany
06:19 AM Bug #6267: StackOverflowError in BROWSE widget
> Committed revision 13785 (3821c) please review.
Sergey, @Character.isAlphabetic@ states that the following keys ...
Stanislav Lomany
05:40 AM Bug #6267: StackOverflowError in BROWSE widget
Committed revision 13785 (3821c) please review. Sergey Ivanovskiy

04/14/2022

07:00 PM Bug #6267: StackOverflowError in BROWSE widget
Sergey Ivanovskiy wrote:
> I would propose to fix @Keyboard.isPrintableKey(key, isReal)@ to limit this condition
> ...
Vladimir Tsichevski
06:32 PM Bug #6267: StackOverflowError in BROWSE widget
I would propose to fix @Keyboard.isPrintableKey(key, isReal)@ to limit this condition
@Character.isAlphabetic(key) &...
Sergey Ivanovskiy
05:37 PM Bug #6267: StackOverflowError in BROWSE widget
Vladimir Tsichevski wrote:
> Stanislav Lomany wrote:
> > Vladimir, I cannot help saying that the issue you was anal...
Vladimir Tsichevski
05:35 PM Bug #6267: StackOverflowError in BROWSE widget
Stanislav Lomany wrote:
> Vladimir, I cannot help saying that the issue you was analyzing is caused by your change 1...
Vladimir Tsichevski
05:34 PM Bug #6267: StackOverflowError in BROWSE widget
Stanislav Lomany wrote:
> Vladimir, I cannot help saying that the issue you was analyzing is caused by your change 1...
Greg Shah
04:34 PM Bug #6267: StackOverflowError in BROWSE widget
Vladimir, I cannot help saying that the issue you was analyzing is caused by your change 13716 (3821c). The change is... Stanislav Lomany

04/11/2022

06:04 AM Bug #6038 (Feedback): ComboBox setScreenValue improvements
Guys, I'm trying to close this somehow but although I've tried to keep the current implementation where the @screen-v... Marian Edu

04/08/2022

05:38 PM Bug #6267: StackOverflowError in BROWSE widget
Vladimir: Please use @bzr blame@ and report who wrote the code in question. Greg Shah
02:28 PM Bug #6267: StackOverflowError in BROWSE widget
This issue was first published as #5034-1982. Vladimir Tsichevski
02:27 PM Bug #6267: StackOverflowError in BROWSE widget
Stack overflow situation in @Browse@ widget:
# create an application with an editable @BROWSE@ widget (example @br...
Vladimir Tsichevski
02:24 PM Bug #6267 (Review): StackOverflowError in BROWSE widget
Vladimir Tsichevski

04/07/2022

06:07 AM Bug #6258: SELECTION-LIST: Swing ChUI: SPACE and arrow buttons processing
When space is pressed in Swing ChUI mode, the current row is selected.
Issues:
# After the SPACE was pressed, t...
Vladimir Tsichevski
06:05 AM Bug #6258 (Closed): SELECTION-LIST: Swing ChUI: SPACE and arrow buttons processing
Vladimir Tsichevski

04/06/2022

06:19 PM Bug #6254: SELECTION-LIST: horizontal scrollbar is always inactive
Horizontal scrolling is not working in @SELECTION-LIST@. The scrollbar is visible, but inactive even if long lines ex... Vladimir Tsichevski
06:18 PM Bug #6254 (New): SELECTION-LIST: horizontal scrollbar is always inactive
Vladimir Tsichevski
05:49 PM Bug #6251: Swing ChUI: BACK-TAB does not work
Test example @5937.p@.
The @TAB@ key works properly, but the @BACK-TAB@ does not do anything for any widget in the...
Vladimir Tsichevski
05:48 PM Bug #6251 (Rejected): Swing ChUI: BACK-TAB does not work
Vladimir Tsichevski
05:34 PM Bug #6250: SELECTION-LIST: declaring event trigger does not suppress normal event processing
# In OE, if I define an event trigger, the default event processing is suppressed. For example, if I define event tri... Vladimir Tsichevski
05:32 PM Bug #6250 (New): SELECTION-LIST: declaring event trigger does not suppress normal event processing
Vladimir Tsichevski
04:25 PM Bug #6249: SELECTION-LIST: lookup items beginning with SPACE issue
@SELECTION-LIST@ lookup feature: go to first or next item beginning with the character pressed.
When the user pres...
Vladimir Tsichevski
04:15 PM Bug #6249 (New): SELECTION-LIST: lookup items beginning with SPACE issue
Vladimir Tsichevski
03:34 PM Bug #6248: SELECTION-LIST: No mouse double-click actions
This issue was initially referenced in #5937. Vladimir Tsichevski
03:33 PM Bug #6248: SELECTION-LIST: No mouse double-click actions
In OE, when the user double-click an item in @SELECTION-LIST@:
# In *single selection mode*: @DEFAULT-ACTION@ is t...
Vladimir Tsichevski
03:32 PM Bug #6248 (New): SELECTION-LIST: No mouse double-click actions
Vladimir Tsichevski
01:10 PM Bug #6247: SELECTION-LIST drawing issues in GUI mode
These issues were previously registered as #5937-9 and #5937-10. Vladimir Tsichevski
01:08 PM Bug #6247: SELECTION-LIST drawing issues in GUI mode
The selection list in OE:
!5937-OE.png!
the same list in FWD:
!5937-FWD.png!
The differences:
1. in FWD th...
Vladimir Tsichevski
01:04 PM Bug #6247 (New): SELECTION-LIST drawing issues in GUI mode
Vladimir Tsichevski
11:11 AM Bug #6245: SELECTION-LIST: the first item is not initially highlighted in Swing ChUI
The test example @5937-simple.p@. Vladimir Tsichevski
11:05 AM Bug #6245: SELECTION-LIST: the first item is not initially highlighted in Swing ChUI
In OE ChUI, when the ``SELECTION-LIST`` is first shown, the first item is highlighted:
!6245-OE.png!
In FWD Swi...
Vladimir Tsichevski
11:03 AM Bug #6245 (New): SELECTION-LIST: the first item is not initially highlighted in Swing ChUI
Vladimir Tsichevski
09:51 AM Bug #6241: NPE in LinuxKeyboardReader when Escape is pressed
# Open any application with a window in ChUI Swing.
# Press @Escape@. Client crashes with NPE.
The stack trace:
...
Vladimir Tsichevski
09:38 AM Bug #6241 (New): NPE in LinuxKeyboardReader when Escape is pressed
Vladimir Tsichevski
06:48 AM Bug #6240: Context menu should open on mouse down and not mouse click
The attached diff simply moves the code responsible for showing context menus from @mouseClicked@ to @mousePressed@. ... Hynek Cihlar
06:45 AM Bug #6240 (New): Context menu should open on mouse down and not mouse click
Hynek Cihlar

04/05/2022

05:57 PM Bug #6239: SELECTION-LIST dragging with mouse does not scroll
In OE if the user drags an item in a @SELECTION-LIST@ with vertical scrolling enabled, the list is scrolled when the ... Vladimir Tsichevski
05:52 PM Bug #6239 (New): SELECTION-LIST dragging with mouse does not scroll
Vladimir Tsichevski
03:20 PM Bug #6238: Incorrect focus after frame hidden
The following test case shows the issue. In GUI focus must be set in @t2@ after the button is chosen, but it is set i... Hynek Cihlar
03:18 PM Bug #6238 (New): Incorrect focus after frame hidden
Hynek Cihlar

04/04/2022

12:21 PM Bug #6234: Frame does not receive focus
Example program @frame-focus.p@. In OE, when the user presses a key, the @ANY-KEY@ trigger is fired, and a message is... Vladimir Tsichevski
12:18 PM Bug #6234 (New): Frame does not receive focus
Vladimir Tsichevski
07:19 AM Support #6212 (Closed): View frame display default value for fill-in for some data types
Greg Shah
02:54 AM Support #6212: View frame display default value for fill-in for some data types
6212.patch checked in 3821c revision 13734. Hynek Cihlar

04/03/2022

07:34 PM Support #6212: View frame display default value for fill-in for some data types
Yes, go ahead. Greg Shah
03:00 PM Support #6212: View frame display default value for fill-in for some data types
Hynek Cihlar wrote:
> Greg Shah wrote:
> > Hynek: Please review and merge to 3821c if it is OK.
>
> Marian, the ...
Hynek Cihlar

04/02/2022

02:31 PM Support #6212: View frame display default value for fill-in for some data types
Greg Shah wrote:
> > Normally this should not be called when data type or format is being set
>
> The @DISPLAY <e...
Marian Edu
09:40 AM Support #6212: View frame display default value for fill-in for some data types
> Normally this should not be called when data type or format is being set
The @DISPLAY <expr> format "<fmt>" &#64...
Greg Shah
08:35 AM Support #6212: View frame display default value for fill-in for some data types
Hynek Cihlar wrote:
> Marian, the change also affects other use cases than only @VIEW@ or visibility change. For exa...
Marian Edu

04/01/2022

12:08 PM Support #6212: View frame display default value for fill-in for some data types
Greg Shah wrote:
> Hynek: Please review and merge to 3821c if it is OK.
Marian, the change also affects other use...
Hynek Cihlar
08:26 AM Support #6212: View frame display default value for fill-in for some data types
Hynek: Please review and merge to 3821c if it is OK. Greg Shah
06:41 AM Support #6212 (Review): View frame display default value for fill-in for some data types
Marian Edu
06:41 AM Support #6212 (WIP): View frame display default value for fill-in for some data types
Attached a quick patch to fix this and for whatever reason the screen width for datetime format only considered the d... Marian Edu
 

Also available in: Atom