Project

General

Profile

Activity

From 05/26/2022 to 06/24/2022

06/20/2022

08:45 AM Feature #5742: improve web client startup time
Greg Shah wrote:
> At least the @TailScopedDictionary@ is not from Tomasz.
I'm sorry.. I combined them incorrectly.
Roger Borrello
08:36 AM Feature #5742: improve web client startup time
At least the @TailScopedDictionary@ is not from Tomasz. Greg Shah
08:35 AM Feature #5742: improve web client startup time
Tomasz, there is a minor javadoc issues to correct:... Roger Borrello
04:53 AM Bug #6513: Invalid key sequence response in FILL-IN widget inside Web client
I don't understand now why this condition is not enough. It should return true only if a pressed key is SHIFT, ALT, C... Sergey Ivanovskiy

06/17/2022

04:35 PM Bug #6513: Invalid key sequence response in FILL-IN widget inside Web client
Sergey Ivanovskiy wrote:
> Eugenie Lyzenko wrote:
> > Sergey Ivanovskiy wrote:
> > > Eugenie Lyzenko wrote:
> > >...
Eugenie Lyzenko
04:19 PM Bug #6513: Invalid key sequence response in FILL-IN widget inside Web client
Eugenie Lyzenko wrote:
> Sergey Ivanovskiy wrote:
> > Eugenie Lyzenko wrote:
> > > The @3821c@ updated for review ...
Sergey Ivanovskiy
04:14 PM Bug #6513: Invalid key sequence response in FILL-IN widget inside Web client
Yes, I think you should not this new fix because last event was allocated if there is no such event in the events queue. Sergey Ivanovskiy
03:54 PM Bug #6513: Invalid key sequence response in FILL-IN widget inside Web client
The other possible fix version for @p2j.keyboard.js@ is:... Eugenie Lyzenko
11:04 AM Bug #6513: Invalid key sequence response in FILL-IN widget inside Web client
I have observed the possible alternatives for the fix and found we can not avoid the logic currently used in fix.
...
Eugenie Lyzenko

06/15/2022

06:46 PM Bug #6513: Invalid key sequence response in FILL-IN widget inside Web client
Sergey Ivanovskiy wrote:
> Eugenie Lyzenko wrote:
> > The @3821c@ updated for review to revision @13975@.
> >
> ...
Eugenie Lyzenko
09:03 AM Bug #6513: Invalid key sequence response in FILL-IN widget inside Web client
Eugenie Lyzenko wrote:
> The @3821c@ updated for review to revision @13975@.
>
> This is the fix for original iss...
Sergey Ivanovskiy
08:57 AM Bug #6513: Invalid key sequence response in FILL-IN widget inside Web client
Sergey: Have you reviewed Eugenie's change? Greg Shah
08:49 AM Bug #6513: Invalid key sequence response in FILL-IN widget inside Web client
Eugenie Lyzenko wrote:
> Sergey Ivanovskiy wrote:
> > All these keys were pressed rapidly with SHIFT was hold on.
...
Sergey Ivanovskiy

06/14/2022

03:31 PM Bug #6513: Invalid key sequence response in FILL-IN widget inside Web client
Sergey: Please review. Greg Shah
02:50 PM Bug #6513 (Review): Invalid key sequence response in FILL-IN widget inside Web client
Eugenie Lyzenko
02:50 PM Bug #6513 (WIP): Invalid key sequence response in FILL-IN widget inside Web client
The @3821c@ updated for review to revision @13975@.
This is the fix for original issue. The idea is to restore the...
Eugenie Lyzenko
08:07 AM Bug #6513: Invalid key sequence response in FILL-IN widget inside Web client
Sergey Ivanovskiy wrote:
> All these keys were pressed rapidly with SHIFT was hold on.
You need to press @SHIFT+f...
Eugenie Lyzenko
08:04 AM Bug #6513: Invalid key sequence response in FILL-IN widget inside Web client
Sergey Ivanovskiy wrote:
> I was trying to reproduce this sequence of key events independently and failed to reprodu...
Hynek Cihlar
05:56 AM Bug #6513: Invalid key sequence response in FILL-IN widget inside Web client
Eugenie Lyzenko wrote:
> Any suggestions why we do not emit the keys on @keydown@?
We emit keys on @keypress@ if ...
Sergey Ivanovskiy
05:47 AM Bug #6513: Invalid key sequence response in FILL-IN widget inside Web client
All these keys were pressed rapidly with SHIFT was hold on. Sergey Ivanovskiy
05:44 AM Bug #6513: Invalid key sequence response in FILL-IN widget inside Web client
I was trying to reproduce this sequence of key events independently and failed to reproduce it. In Firefox if the @SH... Sergey Ivanovskiy
04:58 AM Bug #6053: Widget realisation
Marian Edu wrote:
> Hynek Cihlar wrote:
> > Code review @6053.patch@.
> >
> > There are two references to @wasRe...
Hynek Cihlar

06/13/2022

06:17 PM Bug #6513: Invalid key sequence response in FILL-IN widget inside Web client
The bug can be reproduced in any standalone testcase containing @FILL-IN@ widget. But only within Web client.
To r...
Eugenie Lyzenko
06:05 PM Bug #6513 (Closed): Invalid key sequence response in FILL-IN widget inside Web client
Eugenie Lyzenko
05:26 PM Bug #6512: An opened menu item of a sub menu remains highlighted if the mouse pointer is moved ou...
If the full menu item chain is displayed and the mouse pointer is moved out of that menu item, then it should not be ... Sergey Ivanovskiy
05:24 PM Bug #6512 (New): An opened menu item of a sub menu remains highlighted if the mouse pointer is mo...
Sergey Ivanovskiy
05:17 PM Bug #6511: An empty submenu displays a small box if the mouse pointer is over it
!win_menu_bar_submenu_same.png!
An empty submenu @Subbar2@ displays a small box if the mouse pointer is over it.
Sergey Ivanovskiy
05:05 PM Bug #6511 (New): An empty submenu displays a small box if the mouse pointer is over it
Sergey Ivanovskiy
07:14 AM Bug #6053: Widget realisation
Hynek Cihlar wrote:
> Marian Edu wrote:
> > The revision I've pulled now from it is #13968, is that ok to recreate ...
Marian Edu
04:36 AM Bug #6053: Widget realisation
Marian Edu wrote:
> The revision I've pulled now from it is #13968, is that ok to recreate the patch?
Yes, that i...
Hynek Cihlar
04:15 AM Bug #6053: Widget realisation
Hynek Cihlar wrote:
> Marian Edu wrote:
> > If you can push the latest revision to xfer I can recreate the patch to...
Marian Edu
04:10 AM Bug #6053: Widget realisation
Marian Edu wrote:
> If you can push the latest revision to xfer I can recreate the patch today.
Will do, what's t...
Hynek Cihlar
03:09 AM Bug #6053: Widget realisation
Hynek Cihlar wrote:
> Code review @6053.patch@.
>
> There are two references to @wasRealized@ causing compilation...
Marian Edu

06/10/2022

03:03 PM Bug #6053: Widget realisation
Code review @6053.patch@.
There are two references to @wasRealized@ causing compilation errors. I ran several test...
Hynek Cihlar
10:46 AM Bug #6053: Widget realisation
I think last time when we’ve tried to remove @wasRealized@ Roger reported some regression on @<customer_app_2>@. We’v... Marian Edu
09:51 AM Bug #6053: Widget realisation
Hynek: Please review and merge if OK. Greg Shah
08:05 AM Bug #6053 (Review): Widget realisation
Attached the patch to remove the temporary solution with @wasRealized@, we've made tests for widget properties that r... Marian Edu

06/09/2022

12:59 PM Bug #6509: Update to Keikai 5.10.0
Note that 5.10.0 is not yet available in the private Keikai repositories, but should be soon. Hynek Cihlar
12:57 PM Bug #6509: Update to Keikai 5.10.0
Keikai 5.10.0 is an anticipated version. It fixes a potential security vulnerability https://tracker.zkoss.org/browse... Hynek Cihlar
12:51 PM Bug #6509 (Closed): Update to Keikai 5.10.0
Hynek Cihlar

06/06/2022

12:24 PM Feature #6495: add equivalent support for the undocumented -sbhelp command line option
It was seen on a command line as @-sbhelp something.p@.
We don't know what this does, though the name suggests tha...
Greg Shah
12:20 PM Feature #6495 (New): add equivalent support for the undocumented -sbhelp command line option
Greg Shah
07:51 AM Bug #6491: ClassCastException seen in stream processing related to GuiDriver
#5034-2102 - seen by VVT, a @ClassCastException@ seen in stream processing related to GuiDriver (this is not a recent... Greg Shah
07:50 AM Bug #6491 (New): ClassCastException seen in stream processing related to GuiDriver
Greg Shah

06/02/2022

03:14 PM Bug #6483 (Closed): SYSTEM-DIALOG GET-FILE AT-WEB-BROWSER UPLOAD doesn't open file selection dial...
Greg Shah
01:47 PM Bug #6483 (Review): SYSTEM-DIALOG GET-FILE AT-WEB-BROWSER UPLOAD doesn't open file selection dial...
This is not FWD issue, something is broken in my environment. Even a simple DOM-only HTML sample with file input does... Hynek Cihlar
01:46 PM Bug #6483 (WIP): SYSTEM-DIALOG GET-FILE AT-WEB-BROWSER UPLOAD doesn't open file selection dialog ...
Hynek Cihlar
09:24 AM Bug #6483: SYSTEM-DIALOG GET-FILE AT-WEB-BROWSER UPLOAD doesn't open file selection dialog in Chrome
It seems that we can close this issue. Hynek, could you recheck your program with this new version Version 102.0.5005... Sergey Ivanovskiy
09:23 AM Bug #6483: SYSTEM-DIALOG GET-FILE AT-WEB-BROWSER UPLOAD doesn't open file selection dialog in Chrome
I have installed Version 102.0.5005.61 (Official Build) (64-bit) of Google Chrome and checked that this test program ... Sergey Ivanovskiy
09:11 AM Bug #6483: SYSTEM-DIALOG GET-FILE AT-WEB-BROWSER UPLOAD doesn't open file selection dialog in Chrome
But the older version 84.0.4147.105 (Official Build) (64-bit) on my 16.04 Ubuntu works properly with your program too. Sergey Ivanovskiy
08:47 AM Bug #6483: SYSTEM-DIALOG GET-FILE AT-WEB-BROWSER UPLOAD doesn't open file selection dialog in Chrome
The last my test was done with this program ... Sergey Ivanovskiy
08:37 AM Bug #6483: SYSTEM-DIALOG GET-FILE AT-WEB-BROWSER UPLOAD doesn't open file selection dialog in Chrome
Should I work on this issue? Sergey Ivanovskiy
05:22 AM Bug #6483: SYSTEM-DIALOG GET-FILE AT-WEB-BROWSER UPLOAD doesn't open file selection dialog in Chrome
The following test case shows this issue. Clicking on the Upload button and OK in the security dialog doesn't do anyt... Hynek Cihlar
05:21 AM Bug #6483 (Closed): SYSTEM-DIALOG GET-FILE AT-WEB-BROWSER UPLOAD doesn't open file selection dial...
Hynek Cihlar

06/01/2022

07:46 AM Bug #6480: Frame size validation (height/width)
Validation for frame @HEIGHT@/@WIDTH@ and their virtual correspondents needs to be implemented. The behaviour is diff... Marian Edu
07:39 AM Bug #6480 (New): Frame size validation (height/width)
Marian Edu

05/30/2022

12:32 PM Feature #5742 (Test): improve web client startup time
Greg Shah
12:04 PM Feature #5742: improve web client startup time
Greg Shah wrote:
> Can you detect any performance difference in large applications (especially in open complex scree...
Tomasz Domin
10:43 AM Feature #5742: improve web client startup time
Can you detect any performance difference in large applications (especially in open complex screens)? Greg Shah
10:42 AM Feature #5742: improve web client startup time
You can merge 5742c.diff into 3821c. Greg Shah
10:35 AM Feature #5742: improve web client startup time
In meantime I've found an issue with the feature implementation.
There would be two types of setups of the feature...
Tomasz Domin
08:59 AM Bug #6474: finish CAN-SET, CAN-QUERY, LIST-QUERY-ATTRS, LIST-SET-ATTRS
Ensure all widget and other handle-based resources are reporting properly CAN-SET, CAN-QUERY, LIST-QUERY-ATTRS and LI... Greg Shah
08:58 AM Bug #6474 (New): finish CAN-SET, CAN-QUERY, LIST-QUERY-ATTRS, LIST-SET-ATTRS
Greg Shah
07:48 AM Feature #6473: better approach for default event behavior
As Marian notes in #6394-10, we often see some problems in handling default behavior for an event:
* Sometimes the...
Greg Shah
07:43 AM Feature #6473 (New): better approach for default event behavior
Greg Shah

05/29/2022

11:14 AM Feature #6464: cleanup of some messy parts of the UI implementation
We need to cleanup many parts of the UI implementation:
* The naming of these classes. Often we had early approac...
Greg Shah
11:14 AM Feature #6464 (New): cleanup of some messy parts of the UI implementation
Greg Shah

05/27/2022

02:56 PM Feature #5742: improve web client startup time
Code Review 5742b.diff
I think this is a really good update. I'm excited to see it in use in real applications. ...
Greg Shah
10:29 AM Feature #5742 (Review): improve web client startup time
Implemented as planned
To activate following section needs to be added to directory.xml "server/default" section:
<...
Tomasz Domin
02:40 PM Bug #6460: AsyncContext completed and/or Request lifecycle recycled
Please see #5976-57. Sergey Ivanovskiy
02:39 PM Bug #6460 (New): AsyncContext completed and/or Request lifecycle recycled
Sergey Ivanovskiy
01:51 AM Bug #6443 (Review): Widget ROW/COLUMN validation
Ready for review... Marian Edu
01:50 AM Bug #6443 (WIP): Widget ROW/COLUMN validation
Just in case this gets overlooked, after changes in #5897 there was a regression reported for screens in #6314. Rever... Marian Edu
01:38 AM Bug #6443 (Review): Widget ROW/COLUMN validation
Marian Edu
09:14 PM Feature #6440: ATTR-SPACE in FILL-IN
@ATTR-SPACE@ (although we don't support, 4GL documentation claims it has no effect and is for backward compatibility ... Greg Shah
09:13 PM Feature #6440 (New): ATTR-SPACE in FILL-IN
Greg Shah
09:12 PM Feature #6439: improve event support
* @PROCESS_EVENTS@ is lightly used; some events may not be supported, but it's not obvious which are in use
* @LIST-...
Greg Shah
09:11 PM Feature #6439 (New): improve event support
Greg Shah
09:11 PM Feature #6438: frame attributes, methods and options
* @LINE@ attribute
* @CURRENT-ITERATION@ attribute
* @GET-ITERATION()@ method
* @STREAM-IO@ option
* @SCROLL@ opt...
Greg Shah
09:10 PM Feature #6438 (Closed): frame attributes, methods and options
Greg Shah
09:09 PM Feature #6437 (New): FIELD-GROUP:FOREGROUND
Greg Shah
09:08 PM Feature #6436 (New): CLIPBOARD:NUM-FORMATS
Greg Shah

05/26/2022

11:05 AM Feature #5742: improve web client startup time
I like the plan. Greg Shah
10:52 AM Feature #5742: improve web client startup time
Let me explain the approach.
My goal is to balance between minimum client cache size and optimum performance not de...
Tomasz Domin
07:48 AM Feature #5742: improve web client startup time
> >To "one time" push some state from the client to the server at startup, we have void MainEntry.setClientParams(Cli... Greg Shah
07:17 AM Feature #5742 (WIP): improve web client startup time
Tomasz Domin
07:17 AM Feature #5742: improve web client startup time
Greg Shah wrote:
>To "one time" push some state from the client to the server at startup, we have void MainEntry.set...
Tomasz Domin
 

Also available in: Atom