FWD » Core Development » Conversion Tools

05/24/2017

12:30 PM Feature #3277: implement call-graph v3

The following is a really great resource for understanding zooming/panning and transforms in d3:
https://stackover... Greg Shah

10:47 AM Feature #3277: implement call-graph v3

Greg, I think everything is there for the OO call-sites (except events/triggers at class-level, which I haven't check... Constantin Asofiei

07:14 AM Feature #3277: implement call-graph v3

Greg Shah wrote:
> > create an edge to CLASS_DEF
>
> This one.
OK
> > the s:ToString() will point to the Sta... Constantin Asofiei

07:05 AM Feature #3277: implement call-graph v3

> create an edge to CLASS_DEF
This one.
> the s:ToString() will point to the Stateful implementation, and not A... Greg Shah

03:35 AM Feature #3277: implement call-graph v3

Greg Shah wrote:
> > At least the implicit c'tor should be referenced by the call-site. Or I can just link to CLASS... Constantin Asofiei

05/23/2017

06:14 PM Feature #3277: implement call-graph v3

> At least the implicit c'tor should be referenced by the call-site. Or I can just link to CLASS_DEF vertex?
I th... Greg Shah

02:11 PM Feature #3277: implement call-graph v3

Greg, some questions about OO:
* when an implicit constructor or destructor is called (as there is no actual impleme... Constantin Asofiei

07:40 AM Feature #3277: implement call-graph v3

Greg Shah wrote:
> In @SymbolResolver@, you can set breakpoints on access to @ROOT_OBJ_NAME@ to see how the @Progres... Constantin Asofiei

05/22/2017

07:15 PM Feature #3277: implement call-graph v3

Something is definitely wrong there. All of these parsed the last time I tried it. The implicit parent class was wo... Greg Shah

05:27 PM Feature #3277: implement call-graph v3

Greg Shah wrote:
> Check out the latest @cfg/class_map.xml@. See if that makes a difference.
No, it doesn't work. ... Constantin Asofiei

05:20 PM Feature #3277: implement call-graph v3

Check out the latest @cfg/class_map.xml@. See if that makes a difference. Greg Shah

05:11 PM Feature #3277: implement call-graph v3

Greg Shah wrote:
> From the project root, you should have a @p2j/skeleton/@ directory.
Tried your idea, also I've s... Constantin Asofiei

04:02 PM Feature #3277: implement call-graph v3

From the project root, you should have a @p2j/skeleton/@ directory. Greg Shah

03:12 PM Feature #3277: implement call-graph v3

Greg Shah wrote:
> > But aren't these supposed to be loaded into SymbolResolver$WorkArea.classDict
>
> The actual... Constantin Asofiei

03:06 PM Feature #3277: implement call-graph v3

> But aren't these supposed to be loaded into SymbolResolver$WorkArea.classDict
The actual skeleton classes need t... Greg Shah

03:00 PM Feature #3277: implement call-graph v3

Greg Shah wrote:
> See "OO Skeleton Classes":https://proj.goldencode.com/projects/p2j/wiki/Downloads#Object-Oriented... Constantin Asofiei

02:11 PM Feature #3277: implement call-graph v3

> Why there are two RAISES edges? One is from the subscriber (which expects an EVENT to be published by that external... Greg Shah

02:02 PM Feature #3277: implement call-graph v3

See "OO Skeleton Classes":https://proj.goldencode.com/projects/p2j/wiki/Downloads#Object-Oriented-Skeleton-Classes Greg Shah

01:10 PM Feature #3277: implement call-graph v3

Greg, any idea if the @testcases/uast/oo@ tests will parse in FWD? Because I'm getting some weird parsing errors... Constantin Asofiei

12:48 PM Feature #3277: implement call-graph v3

Greg, about PUBLISH/SUBSCRIBE. The events are raised by the "external procedure", and not by internal procedure or f... Constantin Asofiei

10:13 AM Feature #3277: implement call-graph v3

This is a summary/grouping of #2251-7
What is marked with an @X@ means is implemented in current 1514a branch.
h2... Constantin Asofiei

08:17 AM Feature #3277: implement call-graph v3

As of branch 1514a rev 11188, there is a good starting point for the call graph visualization. I have implemented th... Greg Shah

05/17/2017

11:07 AM Feature #3277: implement call-graph v3

> I assume we don't want to add to the graph the entire schema, correct?
Yes.
> Also, should I fix the existing... Greg Shah

09:42 AM Feature #3277: implement call-graph v3

Greg, a quick status:
# func/proc calls, super and dynamic calls are added (including 'references' via hints for 'vi... Constantin Asofiei

05/16/2017

02:31 PM Feature #3277: implement call-graph v3

> There is some redundant information in create_edge:
> ...
> which is used by current reports, but we can derive t... Greg Shah

02:14 PM Feature #3277: implement call-graph v3

Greg Shah wrote:
> > If there is no local definition, the target will be either a super definition or an external pr... Constantin Asofiei

02:04 PM Feature #3277: implement call-graph v3

> A secondary issue: for defined procedures or functions, which are 'not local' (i.e. IN SUPER, IN handle or EXTERNAL... Greg Shah

05/15/2017

04:55 PM Feature #3277: implement call-graph v3

Greg Shah wrote:
> Constantin, please rework and extend the run_statements.rules, for each call-site:
> * establis... Constantin Asofiei

11:09 AM Feature #3277: implement call-graph v3

Constantin Asofiei wrote:
> - create @calls@ links to all internal procs/funcs with the same name
This is @referenc... Constantin Asofiei

11:08 AM Feature #3277: implement call-graph v3

Eric Faulhaber wrote:
> Constantin Asofiei wrote:
> > Greg, a quick question: the callgraph needs to be built on th... Constantin Asofiei

10:47 AM Feature #3277: implement call-graph v3

Constantin Asofiei wrote:
> Greg, a quick question: the callgraph needs to be built on the F2's ASTs, correct? And n... Eric Faulhaber

08:37 AM Feature #3277: implement call-graph v3

Greg, a quick question: the callgraph needs to be built on the F2's ASTs, correct? And not the full conversion's modi... Constantin Asofiei

05/12/2017

05:45 PM Feature #3277: implement call-graph v3

Just a heads up: the @Element.property(String)@ getter has changed, it returns a @Property@ instance - I'll add a @cg... Constantin Asofiei

05/11/2017

07:34 AM Feature #3277: implement call-graph v3

> Do we really need in Janus to map the key as String? Because if instead of bld.addKey(prop, Mapping.STRING.asParame... Greg Shah

06:33 AM Feature #3277: implement call-graph v3

Greg Shah wrote:
> > About the index issues: this code in JanusGraphDB.createIndexImpl needs to be changed, as compo... Constantin Asofiei

06:16 AM Feature #3277: implement call-graph v3

> About the index issues: this code in JanusGraphDB.createIndexImpl needs to be changed, as composite indexes don't a... Greg Shah

06:15 AM Feature #3277: implement call-graph v3

Constantin, please rework and extend the run_statements.rules, for each call-site:
* establish a "contains" edge f... Greg Shah

06:07 AM Feature #3277: implement call-graph v3

About the index issues: this code in @JanusGraphDB.createIndexImpl@ needs to be changed, as composite indexes don't a... Constantin Asofiei

05/09/2017

05:56 PM Feature #3277: implement call-graph v3

I've just checked in branch 1514a revision 11161 which is a shift to JanusGraph 0.2.0 and Tinkerpop 3.2.2 plus all th... Greg Shah

04:46 PM Feature #3277: implement call-graph v3

>> add all entry points as full vertices in the database, with enough information to associate them back to the origi... Greg Shah

04:22 PM Feature #3277: implement call-graph v3

From Greg:
> I need help with the expansion and rework of the core graph itself. The biggest areas are:
>
> ad... Constantin Asofiei

01:20 PM Feature #3277: implement call-graph v3

Attached is the JanusGraph 0.2.0 javadoc which is not available on the Internet (at least as known by Google and by t... Greg Shah

05/05/2017

12:55 PM Feature #3277: implement call-graph v3

Greg Shah wrote:
> As far as I can tell, the javadoc parameter is probably just a bit misleading. Am I missing some... Constantin Asofiei

10:38 AM Feature #3277: implement call-graph v3

In @JanusGraphDB.createIndex*Impl()@, the @text@ parameter is described as this:... Greg Shah

05/02/2017

05:17 PM Feature #3277: implement call-graph v3

Greg Shah wrote:
> In @link_to_include@ or @print_call_site@ we see this code: @cgw.edgeIterator(out, "include-locat... Constantin Asofiei

04:21 PM Feature #3277: implement call-graph v3

In @link_to_include@ or @print_call_site@ we see this code: @cgw.edgeIterator(out, "include-location", "call-site-id"... Greg Shah

04:22 PM Feature #3225: windows vs linux in p2j.cfg.xml

> use progress-style separators, this way being OS neutral
This seems to make good sense. Greg Shah

05/01/2017

11:01 AM Feature #1514: implement fully dynamic reports (backed by the database)

Branch 1514a has been rebased from trunk 11150. The latest revision is 11155. Greg Shah

04/27/2017

12:40 PM Bug #2356 (New): pphints bug - nested includes are missing from the.pphints file

OK, that makes sense. Greg Shah

12:19 PM Bug #2356: pphints bug - nested includes are missing from the.pphints file

Greg Shah wrote:
> I've looked deeper at this. Expansions that are inside of preprocessor directives are deliberate... Constantin Asofiei

10:59 AM Bug #2356 (Rejected): pphints bug - nested includes are missing from the.pphints file

I've looked deeper at this. Expansions that are inside of preprocessor directives are deliberately excluded from the... Greg Shah

04/26/2017

02:18 PM Feature #3277: implement call-graph v3

Greg Shah wrote:
> 1. The @CGW.CallGraph.addTarget()@ does not add to the @traversed@ list. Is that expected?
I th... Constantin Asofiei

02:05 PM Feature #3277: implement call-graph v3

1. The @CGW.CallGraph.addTarget()@ does not add to the @traversed@ list. Is that expected?
2. I don't understand ... Greg Shah