Activity
From 05/04/2017 to 06/02/2017
06/03/2017
- 09:30 PM Feature #3277: implement call-graph v3
- > I've moved the reports in a separate section, but the menubar needs more work - currently looks the same as the mai...
- 09:06 PM Feature #3277: implement call-graph v3
- Greg Shah wrote:
> Constantin: I'm pretty dependent on you for items 1 and 2. Do you think you are close enough to ... - 09:03 PM Feature #3277: implement call-graph v3
- I see some improvements in the graph, though it is still pretty badly broken when all 3 root nodes are loaded. When ...
- 08:42 PM Feature #1514: implement fully dynamic reports (backed by the database)
- Sergey: When you get in tomorrow, can you look at my Dojo ComboBox code in @callgraph.js@, see @createComboBox()@? I ...
06/02/2017
- 07:25 PM Feature #1514: implement fully dynamic reports (backed by the database)
- Eric Faulhaber wrote:
> Sergey Ivanovskiy wrote:
> > Yes, I tried to change highlighted style, but without success ... - 06:26 PM Feature #1514: implement fully dynamic reports (backed by the database)
- Sergey Ivanovskiy wrote:
> Yes, I tried to change highlighted style, but without success and more JQuery ui should p... - 06:23 PM Feature #1514: implement fully dynamic reports (backed by the database)
- Committed revision 11250 added my css tries.
- 06:22 PM Feature #1514: implement fully dynamic reports (backed by the database)
- Yes, I tried to change highlighted style, but without success and more JQuery ui should provide with $("#profileSelec...
- 05:10 PM Feature #1514: implement fully dynamic reports (backed by the database)
- Sergey Ivanovskiy wrote:
> Added Selected Profile label and selection control 11248. The styles for label and select... - 04:51 PM Feature #1514: implement fully dynamic reports (backed by the database)
- Added Selected Profile label and selection control 11248. The styles for label and selector are not set accordingly t...
- 04:44 PM Feature #1514: implement fully dynamic reports (backed by the database)
- FYI, the more I look at JQuery UI, the more I dislike it. The problems (in my opinion):
* It is very heavy in dec... - 04:06 PM Feature #1514: implement fully dynamic reports (backed by the database)
- Sergey Ivanovskiy wrote:
> Thanks, I get this list with one element followed by the active profile id at the end of ... - 03:50 PM Feature #1514: implement fully dynamic reports (backed by the database)
- Thanks, I get this list with one element followed by the active profile id at the end of this list. JQuery UI is very...
- 01:36 PM Feature #1514: implement fully dynamic reports (backed by the database)
- Sergey Ivanovskiy wrote:
> Ok, I will use JQuery UI. It seems that you forgot to commit new class FilterProfile. Is ... - 01:33 PM Feature #1514: implement fully dynamic reports (backed by the database)
- Ok, I will use JQuery UI. It seems that you forgot to commit new class FilterProfile. Is it a pure bean?
- 12:56 PM Feature #1514: implement fully dynamic reports (backed by the database)
- Sergey Ivanovskiy wrote:
> Thank you, it is clear now. will you provide stubs to get all profiles and to select one ... - 12:42 PM Feature #1514: implement fully dynamic reports (backed by the database)
- Thank you, it is clear now. will you provide stubs to get all profiles and to select one of the profiles? What are AP...
- 12:22 PM Feature #1514: implement fully dynamic reports (backed by the database)
- Sergey Ivanovskiy wrote:
> Eric, is it correct that now you would like to get only read only filter_profiles list an... - 12:02 PM Feature #1514: implement fully dynamic reports (backed by the database)
- Eric, is it correct that now you would like to get only read only filter_profiles list and to permit a user to select...
- 11:41 AM Feature #1514: implement fully dynamic reports (backed by the database)
- There are three tables involved in the file filtering:
* @file_map@ - maps file and AST IDs to file names and type (... - 09:13 AM Feature #1514: implement fully dynamic reports (backed by the database)
- The thing that is most urgent is item 1 in #1514-22. That is a much simpler UI.
- 09:13 AM Feature #1514: implement fully dynamic reports (backed by the database)
- Yes, the FancyTree looks pretty good. If it works well and is simple to use then it is OK. It has MIT license so it...
- 09:09 AM Feature #1514: implement fully dynamic reports (backed by the database)
- It seems that the tree component that can be used as a file set creator is not implemented by JQuery UI framework. Bu...
- 08:32 AM Feature #1514: implement fully dynamic reports (backed by the database)
- Sergey: here are some details on the File Set functionality.
The idea is that we are creating arbitrary lists of f... - 03:55 PM Feature #3277: implement call-graph v3
- Constantin Asofiei wrote:
> Yes, I'm using Eric's code and it works for some call-sites, but not for others. There'... - 03:40 PM Feature #3277: implement call-graph v3
- > Even if report is in its own menu, after the AST view we need to allow back to the report. Eric's reports have the ...
- 03:09 PM Feature #3277: implement call-graph v3
- Greg Shah wrote:
> I like the reports approach. I will provide a different way to select them. I'm adding some oth... - 11:36 AM Feature #3277: implement call-graph v3
- Actually, upon thinking about this, I think we should have a separate menu item. Instead of "Call Graph" we should h...
- 11:25 AM Feature #3277: implement call-graph v3
- I like the reports approach. I will provide a different way to select them. I'm adding some other UI controls to th...
- 09:33 AM Feature #3277: implement call-graph v3
- Constantin Asofiei wrote:
> Greg, what was the reason for the @Configuration.forceHome(@ changes in @RootNodeList.ja... - 09:30 AM Feature #3277: implement call-graph v3
- > About the trigger blocks and UI statements raising events: in a previous note you mentioned that the UI statement s...
- 09:17 AM Feature #3277: implement call-graph v3
- Greg, what was the reason for the @Configuration.forceHome(@ changes in @RootNodeList.java@ rev 11225? With these cha...
- 07:43 AM Feature #3277: implement call-graph v3
- About the trigger blocks and UI statements raising events: in a previous note you mentioned that the UI statement sho...
- 07:17 AM Feature #3277: implement call-graph v3
- For the @RUN initializeObject IN hSmartWindow.@ case, I think I have a better way than just link to all definitions o...
- 07:07 AM Feature #3277: implement call-graph v3
- > for the other MORE cases, we need to determine what "stop" vertex mean: for example, a call-site targeting an exter...
- 09:01 PM Feature #3277: implement call-graph v3
- Greg Shah wrote:
> Constantin: your approach sounds pretty good. Can you check it in so I can review it?
Is commit... - 08:51 PM Feature #3277: implement call-graph v3
- !call_graph_on_hotel_gui_branch_1514a_rev_11239_20170601.png!
- 08:49 PM Feature #3277: implement call-graph v3
- Constantin: your approach sounds pretty good. Can you check it in so I can review it?
I've checked in fixes for m... - 08:25 PM Feature #3277: implement call-graph v3
- Greg, OK, I'm looking at the issues now.
I've managed to get into a good step with the client-side infrastructure ...
06/01/2017
- 07:53 PM Feature #3277: implement call-graph v3
- Strangely, the nodes that I am failing on are these:...
- 07:48 PM Feature #3277: implement call-graph v3
- One more fix is in, but it still isn't correct.
The sizes of the containers are calculated properly, but we never ... - 07:29 PM Feature #3277: implement call-graph v3
- I think most of the CONTAINS links are missing from the graph snippet. This is the full list for my Hotel GUI setup ...
- 06:58 PM Feature #3277: implement call-graph v3
- I have my changes for the n-level contains, but it is not working properly. I'm debugging it now, on top of your cha...
- 06:17 PM Feature #3277: implement call-graph v3
- Greg, see revision 11235 for the @readGraph@ changes, an attempt to improve KW_ON and other misc fixes.
Note that ... - 06:08 PM Feature #3277: implement call-graph v3
- Nevermind. I see them.
- 06:06 PM Feature #3277: implement call-graph v3
- In what revision were the edits?
- 05:50 PM Feature #3277: implement call-graph v3
- Greg, you've rolled back some edits I made to @swapPointsWorker@ in @callgraph.js@ - without those edits, there are J...
- 05:42 PM Feature #3277: implement call-graph v3
- That makes sense.
- 05:30 PM Feature #3277: implement call-graph v3
- Greg Shah wrote:
> Constantin Asofiei wrote:
> > Greg Shah wrote:
> > > > The start parameter must always include ... - 05:27 PM Feature #3277: implement call-graph v3
- Constantin Asofiei wrote:
> Greg Shah wrote:
> > > The start parameter must always include vertices for the procedu... - 05:21 PM Feature #3277: implement call-graph v3
- I don't think the KW_ON should be linked to a TRIGGER as calls. The ON statement doesn't call the trigger. The trig...
- 05:13 PM Feature #3277: implement call-graph v3
- Greg Shah wrote:
> > The start parameter must always include vertices for the procedure files, correct?
>
> I had... - 04:55 PM Feature #3277: implement call-graph v3
- Greg Shah wrote:
> Do you have a list of all possible graph vertex @node-type@ values?
Vertex @node-type@ possibl... - 03:48 PM Feature #3277: implement call-graph v3
- Do you have a list of all possible graph vertex @node-type@ values?
Do you have a list of all possible edge labels? - 03:43 PM Feature #3277: implement call-graph v3
- > The start parameter must always include vertices for the procedure files, correct?
I had written the code so tha... - 03:19 PM Feature #3277: implement call-graph v3
- Greg Shah wrote:
> > If we want to properly manage the parent-child relation when triggers are involved, then yes.
... - 03:18 PM Feature #3277: implement call-graph v3
- > If we want to properly manage the parent-child relation when triggers are involved, then yes.
Let's fix this. I... - 03:11 PM Feature #3277: implement call-graph v3
- Greg Shah wrote:
> > There was something bugging me about this 2-level approach and it just clicked: triggers can be... - 03:08 PM Feature #3277: implement call-graph v3
- Also, the KW_ON is a registration of the trigger, but it is not really the trigger itself. Perhaps the distinction d...
- 03:07 PM Feature #3277: implement call-graph v3
- > There was something bugging me about this 2-level approach and it just clicked: triggers can be nested and/or defin...
- 02:56 PM Feature #3277: implement call-graph v3
- Constantin Asofiei wrote:
> > Any scenario that adds contains edges to the snippet will need to have code changes on... - 02:52 PM Feature #3277: implement call-graph v3
- Greg Shah wrote:
> In regard to your upstream question, the idea of upstream or downstream is in regard to other pro... - 02:43 PM Feature #3277: implement call-graph v3
- I just checked in some improvements to text and tooltips.
> There are three entry points: start.p, emain.p and eho... - 02:13 PM Feature #3277: implement call-graph v3
- Greg Shah wrote:
> > I would expect the top-level FILE_RESOURCE blocks to not intersect...
>
> My code that calls... - 01:36 PM Feature #3277: implement call-graph v3
- > Can you point me how D3 computes the z-order?
D3 does nothing with z-order. The SVG's natural z-order will be ... - 11:04 AM Feature #3277: implement call-graph v3
- Greg Shah wrote:
> > (and what is the meaning of the graph) in the web UI.
>
> I'm not sure what you question is ... - 07:34 AM Feature #3277: implement call-graph v3
- > But what is the idea to get these "non-contains" edges?
The top part of the method (above the non-contains part)... - 05:08 AM Feature #3277: implement call-graph v3
- Greg Shah wrote:
> > still have some KW_DYN_FUNC cases (Which I'm not really sure how to resolve automatically)
> ... - 05:04 AM Feature #3277: implement call-graph v3
- > still have some KW_DYN_FUNC cases (Which I'm not really sure how to resolve automatically)
What about the techn...
05/31/2017
- 07:50 PM Feature #3277: implement call-graph v3
- Greg, see revision 11228 - there was another problem, between first 2 contains levels no edges were being added.
B... - 06:58 PM Feature #3277: implement call-graph v3
- Greg Shah wrote:
> These should not be using the "contains" edges. We have already traversed the "contains" up on l... - 06:44 PM Feature #3277: implement call-graph v3
- The changes in 11227 are not quite correct....
- 06:32 PM Feature #3277: implement call-graph v3
- Greg Shah wrote:
> One other thing I need help with: I need a simple and generic way to get a descriptive text strin... - 06:30 PM Feature #3277: implement call-graph v3
- One other thing I need help with: I need a simple and generic way to get a descriptive text string for each node. If...
- 06:29 PM Feature #3277: implement call-graph v3
- Greg, please see revision 11227 - this shows data into the D3 web graph, but it doesn't look OK; not sure what is wro...
- 06:26 PM Feature #3277: implement call-graph v3
- > you are assuming that node-id is unique for the entire callgraph? This is true only in the same resource-domain: i....
- 05:58 PM Feature #3277: implement call-graph v3
- Greg, beside some other JS errors, I can get data into the web graph. But, I don't understand something: what kind o...
- 05:39 PM Feature #3277: implement call-graph v3
- And something else; in this code:...
- 05:24 PM Feature #3277: implement call-graph v3
- Greg, and the root cause why the graph isn't loading: in @createSnippet@, you are using @node-id@. Instead, you can ...
- 05:18 PM Feature #3277: implement call-graph v3
- Greg, I see two issues:
# when processing BOTH directions, you need to make sure a vertex is processed only once - o... - 04:57 PM Feature #3277: implement call-graph v3
- Greg Shah wrote:
> The problem is that the @CGH.loadFileNodes()@ seems to return the @EXTERNAL_PROCEDURE@ node, not ... - 04:31 PM Feature #3277: implement call-graph v3
- I'm testing a first pass at the @CallGraphApi.readGraph(String[] files, int direction, int levels)@ API call. It suc...
- 04:24 PM Feature #3277: implement call-graph v3
- The approach makes sense.
- 04:03 PM Feature #3277: implement call-graph v3
- For any kind of callgraph report, I'm planning to send these details about it, to the function which will build it:
... - 07:04 AM Feature #3277: implement call-graph v3
- When you have the reports fixed and available in the API, you can work on the client side up call and display of the ...
- 06:56 AM Feature #3277: implement call-graph v3
- 1514a rev 11220 has support for these items:
* address the initial layout, positioning bias and collision avoidanc... - 06:52 AM Feature #3277: implement call-graph v3
- >>> Constantin wrote:
>>>
>>> Currently I'm almost finished optimizing the ambiguous sites for Hotel GUI, so that A... - 06:50 AM Feature #3277: implement call-graph v3
- >> Greg wrote:
>> I was thinking that your next step would be to implement an API call for each of the reports and w...
05/30/2017
- 12:31 PM Feature #3277: implement call-graph v3
- Greg Shah wrote:
> It does and we will be using it. Anything that would be moving off the displayed graph will be p... - 11:56 AM Feature #3277: implement call-graph v3
- > Can't we make this configurable in the UI?
Yes, that is the idea.
> Doesn't D3 allow a way to 'insert' dynami... - 11:43 AM Feature #3277: implement call-graph v3
- Greg Shah wrote:
> * see relationships, patterns and connections of the application that would be much harder to und...
05/29/2017
- 01:13 PM Feature #3277: implement call-graph v3
- I guess we need a way to get the list of the file set names.
Then for a given file set name (or ID of the file set... - 12:26 PM Feature #3277: implement call-graph v3
- Greg Shah wrote:
> the user should be able to select a different file set to load (Eric has an implementation of thi... - 11:31 AM Feature #3277: implement call-graph v3
- >> rework the current reports, but as dynamically calculated results that we will send down to the browser for displa...
- 12:58 PM Feature #1514: implement fully dynamic reports (backed by the database)
- Greg Shah wrote:
> The following is a description of the transport and API approach that we are using. Eric, please... - 11:13 AM Feature #1514: implement fully dynamic reports (backed by the database)
- The following is a description of the transport and API approach that we are using. Eric, please correct or add to t...
05/28/2017
- 02:07 PM Feature #3277: implement call-graph v3
- Greg Shah wrote:
> > if @ON ... PERSISTENT RUN@ is a call-site (as in #3277-41), then why is not a @SUBSCRIBE@ a cal...
05/26/2017
- 07:10 PM Feature #3277: implement call-graph v3
- > if @ON ... PERSISTENT RUN@ is a call-site (as in #3277-41), then why is not a @SUBSCRIBE@ a call-site, too? Because...
- 06:41 PM Feature #3277: implement call-graph v3
- Current status (rev 11204):
!call_graph_visualization_branch_1514a_rev_11204_20170526.png!
* link z-order is hi... - 06:00 PM Feature #3277: implement call-graph v3
- Greg, regarding events/triggers, can you help me with something: if @ON ... PERSISTENT RUN@ is a call-site (as in #32...
05/24/2017
- 12:30 PM Feature #3277: implement call-graph v3
- The following is a really great resource for understanding zooming/panning and transforms in d3:
https://stackover... - 10:47 AM Feature #3277: implement call-graph v3
- Greg, I think everything is there for the OO call-sites (except events/triggers at class-level, which I haven't check...
- 07:14 AM Feature #3277: implement call-graph v3
- Greg Shah wrote:
> > create an edge to CLASS_DEF
>
> This one.
OK
> > the s:ToString() will point to the Sta... - 07:05 AM Feature #3277: implement call-graph v3
- > create an edge to CLASS_DEF
This one.
> the s:ToString() will point to the Stateful implementation, and not A... - 03:35 AM Feature #3277: implement call-graph v3
- Greg Shah wrote:
> > At least the implicit c'tor should be referenced by the call-site. Or I can just link to CLASS...
05/23/2017
- 06:14 PM Feature #3277: implement call-graph v3
- > At least the implicit c'tor should be referenced by the call-site. Or I can just link to CLASS_DEF vertex?
I th... - 02:11 PM Feature #3277: implement call-graph v3
- Greg, some questions about OO:
* when an implicit constructor or destructor is called (as there is no actual impleme... - 07:40 AM Feature #3277: implement call-graph v3
- Greg Shah wrote:
> In @SymbolResolver@, you can set breakpoints on access to @ROOT_OBJ_NAME@ to see how the @Progres...
05/22/2017
- 07:15 PM Feature #3277: implement call-graph v3
- Something is definitely wrong there. All of these parsed the last time I tried it. The implicit parent class was wo...
- 05:27 PM Feature #3277: implement call-graph v3
- Greg Shah wrote:
> Check out the latest @cfg/class_map.xml@. See if that makes a difference.
No, it doesn't work. ... - 05:20 PM Feature #3277: implement call-graph v3
- Check out the latest @cfg/class_map.xml@. See if that makes a difference.
- 05:11 PM Feature #3277: implement call-graph v3
- Greg Shah wrote:
> From the project root, you should have a @p2j/skeleton/@ directory.
Tried your idea, also I've s... - 04:02 PM Feature #3277: implement call-graph v3
- From the project root, you should have a @p2j/skeleton/@ directory.
- 03:12 PM Feature #3277: implement call-graph v3
- Greg Shah wrote:
> > But aren't these supposed to be loaded into SymbolResolver$WorkArea.classDict
>
> The actual... - 03:06 PM Feature #3277: implement call-graph v3
- > But aren't these supposed to be loaded into SymbolResolver$WorkArea.classDict
The actual skeleton classes need t... - 03:00 PM Feature #3277: implement call-graph v3
- Greg Shah wrote:
> See "OO Skeleton Classes":https://proj.goldencode.com/projects/p2j/wiki/Downloads#Object-Oriented... - 02:11 PM Feature #3277: implement call-graph v3
- > Why there are two RAISES edges? One is from the subscriber (which expects an EVENT to be published by that external...
- 02:02 PM Feature #3277: implement call-graph v3
- See "OO Skeleton Classes":https://proj.goldencode.com/projects/p2j/wiki/Downloads#Object-Oriented-Skeleton-Classes
- 01:10 PM Feature #3277: implement call-graph v3
- Greg, any idea if the @testcases/uast/oo@ tests will parse in FWD? Because I'm getting some weird parsing errors...
- 12:48 PM Feature #3277: implement call-graph v3
- Greg, about PUBLISH/SUBSCRIBE. The events are raised by the "external procedure", and not by internal procedure or f...
- 10:13 AM Feature #3277: implement call-graph v3
- This is a summary/grouping of #2251-7
What is marked with an @X@ means is implemented in current 1514a branch.
h2... - 08:17 AM Feature #3277: implement call-graph v3
- As of branch 1514a rev 11188, there is a good starting point for the call graph visualization. I have implemented th...
05/17/2017
- 11:07 AM Feature #3277: implement call-graph v3
- > I assume we don't want to add to the graph the entire schema, correct?
Yes.
> Also, should I fix the existing... - 09:42 AM Feature #3277: implement call-graph v3
- Greg, a quick status:
# func/proc calls, super and dynamic calls are added (including 'references' via hints for 'vi...
05/16/2017
- 02:31 PM Feature #3277: implement call-graph v3
- > There is some redundant information in create_edge:
> ...
> which is used by current reports, but we can derive t... - 02:14 PM Feature #3277: implement call-graph v3
- Greg Shah wrote:
> > If there is no local definition, the target will be either a super definition or an external pr... - 02:04 PM Feature #3277: implement call-graph v3
- > A secondary issue: for defined procedures or functions, which are 'not local' (i.e. IN SUPER, IN handle or EXTERNAL...
05/15/2017
- 04:55 PM Feature #3277: implement call-graph v3
- Greg Shah wrote:
> Constantin, please rework and extend the run_statements.rules, for each call-site:
> * establis... - 11:09 AM Feature #3277: implement call-graph v3
- Constantin Asofiei wrote:
> - create @calls@ links to all internal procs/funcs with the same name
This is @referenc... - 11:08 AM Feature #3277: implement call-graph v3
- Eric Faulhaber wrote:
> Constantin Asofiei wrote:
> > Greg, a quick question: the callgraph needs to be built on th... - 10:47 AM Feature #3277: implement call-graph v3
- Constantin Asofiei wrote:
> Greg, a quick question: the callgraph needs to be built on the F2's ASTs, correct? And n... - 08:37 AM Feature #3277: implement call-graph v3
- Greg, a quick question: the callgraph needs to be built on the F2's ASTs, correct? And not the full conversion's modi...
05/12/2017
- 05:45 PM Feature #3277: implement call-graph v3
- Just a heads up: the @Element.property(String)@ getter has changed, it returns a @Property@ instance - I'll add a @cg...
05/11/2017
- 07:34 AM Feature #3277: implement call-graph v3
- > Do we really need in Janus to map the key as String? Because if instead of bld.addKey(prop, Mapping.STRING.asParame...
- 06:33 AM Feature #3277: implement call-graph v3
- Greg Shah wrote:
> > About the index issues: this code in JanusGraphDB.createIndexImpl needs to be changed, as compo... - 06:16 AM Feature #3277: implement call-graph v3
- > About the index issues: this code in JanusGraphDB.createIndexImpl needs to be changed, as composite indexes don't a...
- 06:15 AM Feature #3277: implement call-graph v3
- Constantin, please rework and extend the run_statements.rules, for each call-site:
* establish a "contains" edge f... - 06:07 AM Feature #3277: implement call-graph v3
- About the index issues: this code in @JanusGraphDB.createIndexImpl@ needs to be changed, as composite indexes don't a...
05/09/2017
- 05:56 PM Feature #3277: implement call-graph v3
- I've just checked in branch 1514a revision 11161 which is a shift to JanusGraph 0.2.0 and Tinkerpop 3.2.2 plus all th...
- 04:46 PM Feature #3277: implement call-graph v3
- >> add all entry points as full vertices in the database, with enough information to associate them back to the origi...
- 04:22 PM Feature #3277: implement call-graph v3
- From Greg:
> I need help with the expansion and rework of the core graph itself. The biggest areas are:
>
> ad... - 01:20 PM Feature #3277: implement call-graph v3
- Attached is the JanusGraph 0.2.0 javadoc which is not available on the Internet (at least as known by Google and by t...
05/05/2017
- 12:55 PM Feature #3277: implement call-graph v3
- Greg Shah wrote:
> As far as I can tell, the javadoc parameter is probably just a bit misleading. Am I missing some... - 10:38 AM Feature #3277: implement call-graph v3
- In @JanusGraphDB.createIndex*Impl()@, the @text@ parameter is described as this:...
Also available in: Atom