Project

General

Profile

Activity

From 05/10/2017 to 06/08/2017

06/08/2017

05:09 PM Feature #1514: implement fully dynamic reports (backed by the database)
Please review these small changes on the server side, revision 11289. It is required to get files specifications from... Sergey Ivanovskiy
03:20 PM Feature #3277: implement call-graph v3
I've been thinking about the "hidden more" problem:
* I know that you have greatly reduced the number of links fro... Greg Shah

06/07/2017

08:51 AM Feature #3277: implement call-graph v3
Greg, in the end the problem was something stupid, I was computing wrong index of the matrix element, in the snapPoin... Constantin Asofiei
05:15 AM Feature #3277: implement call-graph v3
Greg Shah wrote:
> Overall, the changes seem to make things better. Any further improvements will be appreciated. ... Constantin Asofiei
12:39 AM Feature #3277: implement call-graph v3
Overall, the changes seem to make things better. Any further improvements will be appreciated. The start.p external... Greg Shah
11:14 PM Feature #3277: implement call-graph v3
Greg, in revision 11284 is the current approach, with start.p looking OK. My idea was to have a static grid (determi... Constantin Asofiei
11:08 PM Feature #3277: implement call-graph v3
> how is the matrix computed for the d.contained nodes, via the snapIndex? Because an element with snapIndex 10 shoul... Greg Shah
10:59 PM Feature #3277: implement call-graph v3
Greg Shah wrote:
> > For the container size: it mostly works, but there are cases where the jails are outside of the... Constantin Asofiei
10:55 PM Feature #3277: implement call-graph v3
> For the container size: it mostly works, but there are cases where the jails are outside of the prison, the contain... Greg Shah

06/06/2017

07:57 PM Feature #3277: implement call-graph v3
Greg Shah wrote:
> Can MESSAGE and PAUSE really generate the full set of possible user-generated events?
Hmm... act... Constantin Asofiei
04:56 PM Feature #3277: implement call-graph v3
Can MESSAGE and PAUSE really generate the full set of possible user-generated events? Greg Shah
03:08 PM Feature #3277: implement call-graph v3
Greg, just a quick status: my approach is to 'compact' the rows/columns on the minimum element height/width, from eac... Constantin Asofiei
10:28 AM Feature #3277: implement call-graph v3
> Do you have a hint where this is computed?
This is calculated in @calcElementJail()@ and enforced by the code in... Greg Shah
10:15 AM Feature #3277: implement call-graph v3
Revision 11281 adds a calculation of the actual minimum width and height of each container. This is the basis for rew... Greg Shah
12:37 PM Feature #1514: implement fully dynamic reports (backed by the database)
Eric Faulhaber wrote:
> If you have no objection, I will add an "err" parameter as the first of each JS callback fun... Constantin Asofiei
12:35 PM Feature #1514: implement fully dynamic reports (backed by the database)
Constantin, I've found a flaw in our JS<-->Java API, in that exceptions on the server side are never reported to the ... Eric Faulhaber

06/05/2017

04:22 PM Feature #3277: implement call-graph v3
Greg, 1514a rev 11279 adds SHIFT/CTRL-click on a MORE node which will either load the graph with the program as root ... Constantin Asofiei
03:34 PM Feature #3277: implement call-graph v3
Greg, 1514a rev 11277 has the custom graph loading from note #3277-173 . I'm moving to MORE node expansion next. Constantin Asofiei
02:11 PM Feature #3277: implement call-graph v3
Greg Shah wrote:
> Code Review Task Branch 1514a Revision 11276
> This is the reason that the links to and from rec... Constantin Asofiei
02:01 PM Feature #3277: implement call-graph v3
Code Review Task Branch 1514a Revision 11276
Everything is good except for the changes on line 2117 and 2132. In ... Greg Shah
11:26 AM Feature #3277: implement call-graph v3
Greg, I think I found the cause of the NaN's:
# in @rectIntersection@, if @outside.x == inside.x@, then the slope is... Constantin Asofiei
06:16 AM Feature #3277: implement call-graph v3
> I mean, even if both programs are expanded in the current snippet, then we don't create a link for each call betwee... Greg Shah
06:13 AM Feature #3277: implement call-graph v3
Another thing to consider is that instead of loading entire root list, a user might want to load just a single progra... Greg Shah
06:05 AM Feature #3277: implement call-graph v3
Greg Shah wrote:
> > for dependencies between external-program, by default use a dependency link between them
>
>... Constantin Asofiei
05:54 AM Feature #3277: implement call-graph v3
> for dependencies between external-program, by default use a dependency link between them
What do you mean by "de... Greg Shah
05:48 AM Feature #3277: implement call-graph v3
> I'm including the names of all targets for a call site, for function, procedure or event calls, so you can see them... Greg Shah
05:48 AM Feature #3277: implement call-graph v3
Greg Shah wrote:
> How many procedure_file nodes are there in the level == 1 case? Is it correct that there 4000 no... Constantin Asofiei
05:19 AM Feature #3277: implement call-graph v3
> About the MORE nodes: I'm not sure how to solve this; maybe I can enable it only for level > 0?
I'm not sure. I... Greg Shah
09:23 PM Feature #3277: implement call-graph v3
Greg, see 1514a revision 11273 for improvements related to the description/tooltip of the call sites - I'm including ... Constantin Asofiei
04:00 PM Feature #1514: implement fully dynamic reports (backed by the database)
Eric Faulhaber wrote:
> Eric Faulhaber wrote:
> > Sergey, could you please help me debug a radio button issue?
> >... Constantin Asofiei
03:58 PM Feature #1514: implement fully dynamic reports (backed by the database)
Eric Faulhaber wrote:
> Sergey, could you please help me debug a radio button issue?
>
> I just checked in rev. 1... Eric Faulhaber
03:54 PM Feature #1514: implement fully dynamic reports (backed by the database)
Sergey, could you please help me debug a radio button issue?
I just checked in rev. 11278. On the "Customize" page... Eric Faulhaber
03:28 PM Feature #1514: implement fully dynamic reports (backed by the database)
Sergey Ivanovskiy wrote:
> May be this code can help
> [...]
Yes, it helped, thanks! Constantin Asofiei
03:28 PM Feature #1514: implement fully dynamic reports (backed by the database)
May be this code can help... Sergey Ivanovskiy
03:08 PM Feature #1514: implement fully dynamic reports (backed by the database)
I used this code for destroy combobox... Sergey Ivanovskiy
02:45 PM Feature #1514: implement fully dynamic reports (backed by the database)
Greg Shah wrote:
> Constantin Asofiei wrote:
> > Sergey, the combobox code for note 43 is not working in chrome.
>... Constantin Asofiei

06/04/2017

05:32 PM Feature #3277: implement call-graph v3
Greg Shah wrote:
See 1514a revision 11271 for event improvements.
> After the event improvements are in, please l... Constantin Asofiei
04:23 PM Feature #3277: implement call-graph v3
Revision 11270 makes improvements in node text and some tweaks for reducing the space allocated for containers.
Af... Greg Shah
03:59 PM Feature #3277: implement call-graph v3
Greg Shah wrote:
> > can you make them contained?
> I can look at it. It has other ramifications but I should be c... Constantin Asofiei
03:58 PM Feature #3277: implement call-graph v3
> can you make them contained?
I can look at it. It has other ramifications but I should be close.
> Note that... Greg Shah
03:32 PM Feature #3277: implement call-graph v3
Greg, the approach with the events is this:
# EVENT nodes are created in each context (internal proc, function, exte... Constantin Asofiei
03:10 PM Feature #3277: implement call-graph v3
11269 has improved displayProps. Greg Shah
01:33 PM Feature #3277: implement call-graph v3
Revision 11268 has text labels added to the middle of every link. This should make it much easier to understand the ... Greg Shah
12:46 PM Feature #3277: implement call-graph v3
> The links reported by createNodeMap are calls links, not contains... so I'm not sure where the problem is.
You'r... Greg Shah
12:42 PM Feature #3277: implement call-graph v3
Greg Shah wrote:
> > MORE nodes should never be contained or containers. How do you determine that they should be co... Constantin Asofiei
12:40 PM Feature #3277: implement call-graph v3
The first one matched in the current scope is used. So it seems like we could walk up the call graph and look for sc... Greg Shah
12:35 PM Feature #3277: implement call-graph v3
Greg Shah wrote:
> I think EVENT nodes should be contained in the scope (4GL code block) that registers them. Event... Constantin Asofiei
10:29 AM Feature #3277: implement call-graph v3
I think EVENT nodes should be contained in the scope (4GL code block) that registers them. Events are not really glo... Greg Shah
10:20 AM Feature #3277: implement call-graph v3
> MORE nodes: the traverseLevel must create MORE nodes only if level 0 is reached and only to PROCEDURE_FILE or SCHEM... Greg Shah
09:40 AM Feature #3277: implement call-graph v3
> MORE nodes should never be contained or containers. How do you determine that they should be contained or container... Greg Shah
08:25 AM Feature #3277: implement call-graph v3
Greg Shah wrote:
> Some other questions:
>
> 1. I don't see any "calls" link from an event to a trigger. This is... Constantin Asofiei
08:11 AM Feature #3277: implement call-graph v3
Greg Shah wrote:
> With rev 11265, I add the circle back in as a shape (for More and Event nodes) and there is some ... Constantin Asofiei
07:46 AM Feature #3277: implement call-graph v3
Some other questions:
1. I don't see any "calls" link from an event to a trigger. This is a pretty crucial elemen... Greg Shah
07:43 AM Feature #3277: implement call-graph v3
Greg Shah wrote:
> Is the addition of the node-key enough for this or do we need to augment the data (both stored in... Constantin Asofiei
07:34 AM Feature #3277: implement call-graph v3
I'm working on improving the appearance of nodes and links. I'm adding colors and so forth for all types than can be... Greg Shah
12:26 AM Feature #3277: implement call-graph v3
Constantin: your changes in 11264 do make a huge improvement.
With rev 11265, I add the circle back in as a shape ... Greg Shah
08:32 PM Feature #3277: implement call-graph v3
Greg, I think I've managed to get the callgraph (a real call-graph, not code graph - if you want code, I assume are r... Constantin Asofiei
10:49 AM Feature #1514: implement fully dynamic reports (backed by the database)
Sergey: Please work on the file list editing next. It would be useful for us to be able to actually create some real... Greg Shah

06/03/2017

06:47 PM Feature #3277: implement call-graph v3
Greg, I've been trying to solve these issues:
# MORE nodes: the @traverseLevel@ must create MORE nodes only if level... Constantin Asofiei
03:28 PM Feature #3277: implement call-graph v3
Greg, I've done the dead code report. I'm looking into the callgraph visualisation improvements next. Constantin Asofiei
02:21 PM Feature #3277: implement call-graph v3
Revision 11260 adds the AST details info panel (no annotations right now) on hover over a node that is backed by an A... Greg Shah
08:50 AM Feature #3277: implement call-graph v3
I am working to replace global js module initialization with AMD initialization like it was done for the known demo p... Sergey Ivanovskiy
07:17 AM Feature #3277: implement call-graph v3
Found that these call graph reports are very heavy and loaded Firefox browser on my computer, I didn't investigated i... Sergey Ivanovskiy
07:04 AM Feature #3277: implement call-graph v3
I changed Call Graph Reports navigation menu to be a dropdown menu that is placed over reports views at the right top... Sergey Ivanovskiy
12:57 AM Feature #3277: implement call-graph v3
Greg Shah wrote:
> Actually, upon thinking about this, I think we should have a separate menu item. Instead of "Cal... Eric Faulhaber
09:30 PM Feature #3277: implement call-graph v3
> I've moved the reports in a separate section, but the menubar needs more work - currently looks the same as the mai... Greg Shah
09:06 PM Feature #3277: implement call-graph v3
Greg Shah wrote:
> Constantin: I'm pretty dependent on you for items 1 and 2. Do you think you are close enough to ... Constantin Asofiei
09:03 PM Feature #3277: implement call-graph v3
I see some improvements in the graph, though it is still pretty badly broken when all 3 root nodes are loaded. When ... Greg Shah
01:00 PM Feature #1514: implement fully dynamic reports (backed by the database)
Please update report.js, committed revision 11259 changed selected profile to use dijit.Select. Sergey Ivanovskiy
11:33 AM Feature #1514: implement fully dynamic reports (backed by the database)
Greg Shah wrote:
> Constantin Asofiei wrote:
> > Sergey, the combobox code for note 43 is not working in chrome.
>... Sergey Ivanovskiy
11:28 AM Feature #1514: implement fully dynamic reports (backed by the database)
Constantin Asofiei wrote:
> Sergey, the combobox code for note 43 is not working in chrome.
It is working for me ... Greg Shah
11:26 AM Feature #1514: implement fully dynamic reports (backed by the database)
> It seems they are required for offline usages.
If we have it local to the install (in build/lib/), why do we nee... Greg Shah
11:18 AM Feature #1514: implement fully dynamic reports (backed by the database)
Sergey, the combobox code for note 43 is not working in chrome. Constantin Asofiei
10:48 AM Feature #1514: implement fully dynamic reports (backed by the database)
Yes, it seems that dojo is loaded from this zip file by DojoToolkitHandler. If you need offline page, then you should... Sergey Ivanovskiy
10:22 AM Feature #1514: implement fully dynamic reports (backed by the database)
Really great! Thank you for fixing this. I didn't realize how badly broken the newer Dojo implementation is when yo... Greg Shah
09:56 AM Feature #1514: implement fully dynamic reports (backed by the database)
Greg, please review the changes, committed revision 11256 that fixed this combobox initialization.
!VirtCallGraphDoj... Sergey Ivanovskiy
08:42 PM Feature #1514: implement fully dynamic reports (backed by the database)
Sergey: When you get in tomorrow, can you look at my Dojo ComboBox code in @callgraph.js@, see @createComboBox()@? I ... Greg Shah

06/02/2017

07:25 PM Feature #1514: implement fully dynamic reports (backed by the database)
Eric Faulhaber wrote:
> Sergey Ivanovskiy wrote:
> > Yes, I tried to change highlighted style, but without success ... Sergey Ivanovskiy
06:26 PM Feature #1514: implement fully dynamic reports (backed by the database)
Sergey Ivanovskiy wrote:
> Yes, I tried to change highlighted style, but without success and more JQuery ui should p... Eric Faulhaber
06:23 PM Feature #1514: implement fully dynamic reports (backed by the database)
Committed revision 11250 added my css tries. Sergey Ivanovskiy
06:22 PM Feature #1514: implement fully dynamic reports (backed by the database)
Yes, I tried to change highlighted style, but without success and more JQuery ui should provide with $("#profileSelec... Sergey Ivanovskiy
05:10 PM Feature #1514: implement fully dynamic reports (backed by the database)
Sergey Ivanovskiy wrote:
> Added Selected Profile label and selection control 11248. The styles for label and select... Eric Faulhaber
04:51 PM Feature #1514: implement fully dynamic reports (backed by the database)
Added Selected Profile label and selection control 11248. The styles for label and selector are not set accordingly t... Sergey Ivanovskiy
04:44 PM Feature #1514: implement fully dynamic reports (backed by the database)
FYI, the more I look at JQuery UI, the more I dislike it. The problems (in my opinion):
* It is very heavy in dec... Greg Shah
04:06 PM Feature #1514: implement fully dynamic reports (backed by the database)
Sergey Ivanovskiy wrote:
> Thanks, I get this list with one element followed by the active profile id at the end of ... Eric Faulhaber
03:50 PM Feature #1514: implement fully dynamic reports (backed by the database)
Thanks, I get this list with one element followed by the active profile id at the end of this list. JQuery UI is very... Sergey Ivanovskiy
01:36 PM Feature #1514: implement fully dynamic reports (backed by the database)
Sergey Ivanovskiy wrote:
> Ok, I will use JQuery UI. It seems that you forgot to commit new class FilterProfile. Is ... Eric Faulhaber
01:33 PM Feature #1514: implement fully dynamic reports (backed by the database)
Ok, I will use JQuery UI. It seems that you forgot to commit new class FilterProfile. Is it a pure bean? Sergey Ivanovskiy
12:56 PM Feature #1514: implement fully dynamic reports (backed by the database)
Sergey Ivanovskiy wrote:
> Thank you, it is clear now. will you provide stubs to get all profiles and to select one ... Eric Faulhaber
12:42 PM Feature #1514: implement fully dynamic reports (backed by the database)
Thank you, it is clear now. will you provide stubs to get all profiles and to select one of the profiles? What are AP... Sergey Ivanovskiy
12:22 PM Feature #1514: implement fully dynamic reports (backed by the database)
Sergey Ivanovskiy wrote:
> Eric, is it correct that now you would like to get only read only filter_profiles list an... Eric Faulhaber
12:02 PM Feature #1514: implement fully dynamic reports (backed by the database)
Eric, is it correct that now you would like to get only read only filter_profiles list and to permit a user to select... Sergey Ivanovskiy
11:41 AM Feature #1514: implement fully dynamic reports (backed by the database)
There are three tables involved in the file filtering:
* @file_map@ - maps file and AST IDs to file names and type (... Eric Faulhaber
09:13 AM Feature #1514: implement fully dynamic reports (backed by the database)
The thing that is most urgent is item 1 in #1514-22. That is a much simpler UI. Greg Shah
09:13 AM Feature #1514: implement fully dynamic reports (backed by the database)
Yes, the FancyTree looks pretty good. If it works well and is simple to use then it is OK. It has MIT license so it... Greg Shah
09:09 AM Feature #1514: implement fully dynamic reports (backed by the database)
It seems that the tree component that can be used as a file set creator is not implemented by JQuery UI framework. Bu... Sergey Ivanovskiy
08:32 AM Feature #1514: implement fully dynamic reports (backed by the database)
Sergey: here are some details on the File Set functionality.
The idea is that we are creating arbitrary lists of f... Greg Shah
03:55 PM Feature #3277: implement call-graph v3
Constantin Asofiei wrote:
> Yes, I'm using Eric's code and it works for some call-sites, but not for others. There'... Eric Faulhaber
03:40 PM Feature #3277: implement call-graph v3
> Even if report is in its own menu, after the AST view we need to allow back to the report. Eric's reports have the ... Greg Shah
03:09 PM Feature #3277: implement call-graph v3
Greg Shah wrote:
> I like the reports approach. I will provide a different way to select them. I'm adding some oth... Constantin Asofiei
11:36 AM Feature #3277: implement call-graph v3
Actually, upon thinking about this, I think we should have a separate menu item. Instead of "Call Graph" we should h... Greg Shah
11:25 AM Feature #3277: implement call-graph v3
I like the reports approach. I will provide a different way to select them. I'm adding some other UI controls to th... Greg Shah
09:33 AM Feature #3277: implement call-graph v3
Constantin Asofiei wrote:
> Greg, what was the reason for the @Configuration.forceHome(@ changes in @RootNodeList.ja... Greg Shah
09:30 AM Feature #3277: implement call-graph v3
> About the trigger blocks and UI statements raising events: in a previous note you mentioned that the UI statement s... Greg Shah
09:17 AM Feature #3277: implement call-graph v3
Greg, what was the reason for the @Configuration.forceHome(@ changes in @RootNodeList.java@ rev 11225? With these cha... Constantin Asofiei
07:43 AM Feature #3277: implement call-graph v3
About the trigger blocks and UI statements raising events: in a previous note you mentioned that the UI statement sho... Constantin Asofiei
07:17 AM Feature #3277: implement call-graph v3
For the @RUN initializeObject IN hSmartWindow.@ case, I think I have a better way than just link to all definitions o... Constantin Asofiei
07:07 AM Feature #3277: implement call-graph v3
> for the other MORE cases, we need to determine what "stop" vertex mean: for example, a call-site targeting an exter... Greg Shah
09:01 PM Feature #3277: implement call-graph v3
Greg Shah wrote:
> Constantin: your approach sounds pretty good. Can you check it in so I can review it?
Is commit... Constantin Asofiei
08:51 PM Feature #3277: implement call-graph v3
!call_graph_on_hotel_gui_branch_1514a_rev_11239_20170601.png! Greg Shah
08:49 PM Feature #3277: implement call-graph v3
Constantin: your approach sounds pretty good. Can you check it in so I can review it?
I've checked in fixes for m... Greg Shah
08:25 PM Feature #3277: implement call-graph v3
Greg, OK, I'm looking at the issues now.
I've managed to get into a good step with the client-side infrastructure ... Constantin Asofiei

06/01/2017

07:53 PM Feature #3277: implement call-graph v3
Strangely, the nodes that I am failing on are these:... Greg Shah
07:48 PM Feature #3277: implement call-graph v3
One more fix is in, but it still isn't correct.
The sizes of the containers are calculated properly, but we never ... Greg Shah
07:29 PM Feature #3277: implement call-graph v3
I think most of the CONTAINS links are missing from the graph snippet. This is the full list for my Hotel GUI setup ... Greg Shah
06:58 PM Feature #3277: implement call-graph v3
I have my changes for the n-level contains, but it is not working properly. I'm debugging it now, on top of your cha... Greg Shah
06:17 PM Feature #3277: implement call-graph v3
Greg, see revision 11235 for the @readGraph@ changes, an attempt to improve KW_ON and other misc fixes.
Note that ... Constantin Asofiei
06:08 PM Feature #3277: implement call-graph v3
Nevermind. I see them. Greg Shah
06:06 PM Feature #3277: implement call-graph v3
In what revision were the edits? Greg Shah
05:50 PM Feature #3277: implement call-graph v3
Greg, you've rolled back some edits I made to @swapPointsWorker@ in @callgraph.js@ - without those edits, there are J... Constantin Asofiei
05:42 PM Feature #3277: implement call-graph v3
That makes sense. Greg Shah
05:30 PM Feature #3277: implement call-graph v3
Greg Shah wrote:
> Constantin Asofiei wrote:
> > Greg Shah wrote:
> > > > The start parameter must always include ... Constantin Asofiei
05:27 PM Feature #3277: implement call-graph v3
Constantin Asofiei wrote:
> Greg Shah wrote:
> > > The start parameter must always include vertices for the procedu... Greg Shah
05:21 PM Feature #3277: implement call-graph v3
I don't think the KW_ON should be linked to a TRIGGER as calls. The ON statement doesn't call the trigger. The trig... Greg Shah
05:13 PM Feature #3277: implement call-graph v3
Greg Shah wrote:
> > The start parameter must always include vertices for the procedure files, correct?
>
> I had... Constantin Asofiei
04:55 PM Feature #3277: implement call-graph v3
Greg Shah wrote:
> Do you have a list of all possible graph vertex @node-type@ values?
Vertex @node-type@ possibl... Constantin Asofiei
03:48 PM Feature #3277: implement call-graph v3
Do you have a list of all possible graph vertex @node-type@ values?
Do you have a list of all possible edge labels? Greg Shah
03:43 PM Feature #3277: implement call-graph v3
> The start parameter must always include vertices for the procedure files, correct?
I had written the code so tha... Greg Shah
03:19 PM Feature #3277: implement call-graph v3
Greg Shah wrote:
> > If we want to properly manage the parent-child relation when triggers are involved, then yes.
... Constantin Asofiei
03:18 PM Feature #3277: implement call-graph v3
> If we want to properly manage the parent-child relation when triggers are involved, then yes.
Let's fix this. I... Greg Shah
03:11 PM Feature #3277: implement call-graph v3
Greg Shah wrote:
> > There was something bugging me about this 2-level approach and it just clicked: triggers can be... Constantin Asofiei
03:08 PM Feature #3277: implement call-graph v3
Also, the KW_ON is a registration of the trigger, but it is not really the trigger itself. Perhaps the distinction d... Greg Shah
03:07 PM Feature #3277: implement call-graph v3
> There was something bugging me about this 2-level approach and it just clicked: triggers can be nested and/or defin... Greg Shah
02:56 PM Feature #3277: implement call-graph v3
Constantin Asofiei wrote:
> > Any scenario that adds contains edges to the snippet will need to have code changes on... Constantin Asofiei
02:52 PM Feature #3277: implement call-graph v3
Greg Shah wrote:
> In regard to your upstream question, the idea of upstream or downstream is in regard to other pro... Constantin Asofiei
02:43 PM Feature #3277: implement call-graph v3
I just checked in some improvements to text and tooltips.
> There are three entry points: start.p, emain.p and eho... Greg Shah
02:13 PM Feature #3277: implement call-graph v3
Greg Shah wrote:
> > I would expect the top-level FILE_RESOURCE blocks to not intersect...
>
> My code that calls... Constantin Asofiei
01:36 PM Feature #3277: implement call-graph v3
> Can you point me how D3 computes the z-order?
D3 does nothing with z-order. The SVG's natural z-order will be ... Greg Shah
11:04 AM Feature #3277: implement call-graph v3
Greg Shah wrote:
> > (and what is the meaning of the graph) in the web UI.
>
> I'm not sure what you question is ... Constantin Asofiei
07:34 AM Feature #3277: implement call-graph v3
> But what is the idea to get these "non-contains" edges?
The top part of the method (above the non-contains part)... Greg Shah
05:08 AM Feature #3277: implement call-graph v3
Greg Shah wrote:
> > still have some KW_DYN_FUNC cases (Which I'm not really sure how to resolve automatically)
> ... Constantin Asofiei
05:04 AM Feature #3277: implement call-graph v3
> still have some KW_DYN_FUNC cases (Which I'm not really sure how to resolve automatically)
What about the techn... Greg Shah

05/31/2017

07:50 PM Feature #3277: implement call-graph v3
Greg, see revision 11228 - there was another problem, between first 2 contains levels no edges were being added.
B... Constantin Asofiei
06:58 PM Feature #3277: implement call-graph v3
Greg Shah wrote:
> These should not be using the "contains" edges. We have already traversed the "contains" up on l... Constantin Asofiei
06:44 PM Feature #3277: implement call-graph v3
The changes in 11227 are not quite correct.... Greg Shah
06:32 PM Feature #3277: implement call-graph v3
Greg Shah wrote:
> One other thing I need help with: I need a simple and generic way to get a descriptive text strin... Constantin Asofiei
06:30 PM Feature #3277: implement call-graph v3
One other thing I need help with: I need a simple and generic way to get a descriptive text string for each node. If... Greg Shah
06:29 PM Feature #3277: implement call-graph v3
Greg, please see revision 11227 - this shows data into the D3 web graph, but it doesn't look OK; not sure what is wro... Constantin Asofiei
06:26 PM Feature #3277: implement call-graph v3
> you are assuming that node-id is unique for the entire callgraph? This is true only in the same resource-domain: i.... Greg Shah
05:58 PM Feature #3277: implement call-graph v3
Greg, beside some other JS errors, I can get data into the web graph. But, I don't understand something: what kind o... Constantin Asofiei
05:39 PM Feature #3277: implement call-graph v3
And something else; in this code:... Constantin Asofiei
05:24 PM Feature #3277: implement call-graph v3
Greg, and the root cause why the graph isn't loading: in @createSnippet@, you are using @node-id@. Instead, you can ... Constantin Asofiei
05:18 PM Feature #3277: implement call-graph v3
Greg, I see two issues:
# when processing BOTH directions, you need to make sure a vertex is processed only once - o... Constantin Asofiei
04:57 PM Feature #3277: implement call-graph v3
Greg Shah wrote:
> The problem is that the @CGH.loadFileNodes()@ seems to return the @EXTERNAL_PROCEDURE@ node, not ... Constantin Asofiei
04:31 PM Feature #3277: implement call-graph v3
I'm testing a first pass at the @CallGraphApi.readGraph(String[] files, int direction, int levels)@ API call. It suc... Greg Shah
04:24 PM Feature #3277: implement call-graph v3
The approach makes sense. Greg Shah
04:03 PM Feature #3277: implement call-graph v3
For any kind of callgraph report, I'm planning to send these details about it, to the function which will build it:
... Constantin Asofiei
07:04 AM Feature #3277: implement call-graph v3
When you have the reports fixed and available in the API, you can work on the client side up call and display of the ... Greg Shah
06:56 AM Feature #3277: implement call-graph v3
1514a rev 11220 has support for these items:
* address the initial layout, positioning bias and collision avoidanc... Greg Shah
06:52 AM Feature #3277: implement call-graph v3
>>> Constantin wrote:
>>>
>>> Currently I'm almost finished optimizing the ambiguous sites for Hotel GUI, so that A... Greg Shah
06:50 AM Feature #3277: implement call-graph v3
>> Greg wrote:
>> I was thinking that your next step would be to implement an API call for each of the reports and w... Greg Shah

05/30/2017

12:31 PM Feature #3277: implement call-graph v3
Greg Shah wrote:
> It does and we will be using it. Anything that would be moving off the displayed graph will be p... Constantin Asofiei
11:56 AM Feature #3277: implement call-graph v3
> Can't we make this configurable in the UI?
Yes, that is the idea.
> Doesn't D3 allow a way to 'insert' dynami... Greg Shah
11:43 AM Feature #3277: implement call-graph v3
Greg Shah wrote:
> * see relationships, patterns and connections of the application that would be much harder to und... Constantin Asofiei

05/29/2017

01:13 PM Feature #3277: implement call-graph v3
I guess we need a way to get the list of the file set names.
Then for a given file set name (or ID of the file set... Greg Shah
12:26 PM Feature #3277: implement call-graph v3
Greg Shah wrote:
> the user should be able to select a different file set to load (Eric has an implementation of thi... Eric Faulhaber
11:31 AM Feature #3277: implement call-graph v3
>> rework the current reports, but as dynamically calculated results that we will send down to the browser for displa... Greg Shah
12:58 PM Feature #1514: implement fully dynamic reports (backed by the database)
Greg Shah wrote:
> The following is a description of the transport and API approach that we are using. Eric, please... Eric Faulhaber
11:13 AM Feature #1514: implement fully dynamic reports (backed by the database)
The following is a description of the transport and API approach that we are using. Eric, please correct or add to t... Greg Shah

05/28/2017

02:07 PM Feature #3277: implement call-graph v3
Greg Shah wrote:
> > if @ON ... PERSISTENT RUN@ is a call-site (as in #3277-41), then why is not a @SUBSCRIBE@ a cal... Constantin Asofiei

05/26/2017

07:10 PM Feature #3277: implement call-graph v3
> if @ON ... PERSISTENT RUN@ is a call-site (as in #3277-41), then why is not a @SUBSCRIBE@ a call-site, too? Because... Greg Shah
06:41 PM Feature #3277: implement call-graph v3
Current status (rev 11204):
!call_graph_visualization_branch_1514a_rev_11204_20170526.png!
* link z-order is hi... Greg Shah
06:00 PM Feature #3277: implement call-graph v3
Greg, regarding events/triggers, can you help me with something: if @ON ... PERSISTENT RUN@ is a call-site (as in #32... Constantin Asofiei

05/24/2017

12:30 PM Feature #3277: implement call-graph v3
The following is a really great resource for understanding zooming/panning and transforms in d3:
https://stackover... Greg Shah
10:47 AM Feature #3277: implement call-graph v3
Greg, I think everything is there for the OO call-sites (except events/triggers at class-level, which I haven't check... Constantin Asofiei
07:14 AM Feature #3277: implement call-graph v3
Greg Shah wrote:
> > create an edge to CLASS_DEF
>
> This one.
OK
> > the s:ToString() will point to the Sta... Constantin Asofiei
07:05 AM Feature #3277: implement call-graph v3
> create an edge to CLASS_DEF
This one.
> the s:ToString() will point to the Stateful implementation, and not A... Greg Shah
03:35 AM Feature #3277: implement call-graph v3
Greg Shah wrote:
> > At least the implicit c'tor should be referenced by the call-site. Or I can just link to CLASS... Constantin Asofiei

05/23/2017

06:14 PM Feature #3277: implement call-graph v3
> At least the implicit c'tor should be referenced by the call-site. Or I can just link to CLASS_DEF vertex?
I th... Greg Shah
02:11 PM Feature #3277: implement call-graph v3
Greg, some questions about OO:
* when an implicit constructor or destructor is called (as there is no actual impleme... Constantin Asofiei
07:40 AM Feature #3277: implement call-graph v3
Greg Shah wrote:
> In @SymbolResolver@, you can set breakpoints on access to @ROOT_OBJ_NAME@ to see how the @Progres... Constantin Asofiei

05/22/2017

07:15 PM Feature #3277: implement call-graph v3
Something is definitely wrong there. All of these parsed the last time I tried it. The implicit parent class was wo... Greg Shah
05:27 PM Feature #3277: implement call-graph v3
Greg Shah wrote:
> Check out the latest @cfg/class_map.xml@. See if that makes a difference.
No, it doesn't work. ... Constantin Asofiei
05:20 PM Feature #3277: implement call-graph v3
Check out the latest @cfg/class_map.xml@. See if that makes a difference. Greg Shah
05:11 PM Feature #3277: implement call-graph v3
Greg Shah wrote:
> From the project root, you should have a @p2j/skeleton/@ directory.
Tried your idea, also I've s... Constantin Asofiei
04:02 PM Feature #3277: implement call-graph v3
From the project root, you should have a @p2j/skeleton/@ directory. Greg Shah
03:12 PM Feature #3277: implement call-graph v3
Greg Shah wrote:
> > But aren't these supposed to be loaded into SymbolResolver$WorkArea.classDict
>
> The actual... Constantin Asofiei
03:06 PM Feature #3277: implement call-graph v3
> But aren't these supposed to be loaded into SymbolResolver$WorkArea.classDict
The actual skeleton classes need t... Greg Shah
03:00 PM Feature #3277: implement call-graph v3
Greg Shah wrote:
> See "OO Skeleton Classes":https://proj.goldencode.com/projects/p2j/wiki/Downloads#Object-Oriented... Constantin Asofiei
02:11 PM Feature #3277: implement call-graph v3
> Why there are two RAISES edges? One is from the subscriber (which expects an EVENT to be published by that external... Greg Shah
02:02 PM Feature #3277: implement call-graph v3
See "OO Skeleton Classes":https://proj.goldencode.com/projects/p2j/wiki/Downloads#Object-Oriented-Skeleton-Classes Greg Shah
01:10 PM Feature #3277: implement call-graph v3
Greg, any idea if the @testcases/uast/oo@ tests will parse in FWD? Because I'm getting some weird parsing errors... Constantin Asofiei
12:48 PM Feature #3277: implement call-graph v3
Greg, about PUBLISH/SUBSCRIBE. The events are raised by the "external procedure", and not by internal procedure or f... Constantin Asofiei
10:13 AM Feature #3277: implement call-graph v3
This is a summary/grouping of #2251-7
What is marked with an @X@ means is implemented in current 1514a branch.
h2... Constantin Asofiei
08:17 AM Feature #3277: implement call-graph v3
As of branch 1514a rev 11188, there is a good starting point for the call graph visualization. I have implemented th... Greg Shah

05/17/2017

11:07 AM Feature #3277: implement call-graph v3
> I assume we don't want to add to the graph the entire schema, correct?
Yes.
> Also, should I fix the existing... Greg Shah
09:42 AM Feature #3277: implement call-graph v3
Greg, a quick status:
# func/proc calls, super and dynamic calls are added (including 'references' via hints for 'vi... Constantin Asofiei

05/16/2017

02:31 PM Feature #3277: implement call-graph v3
> There is some redundant information in create_edge:
> ...
> which is used by current reports, but we can derive t... Greg Shah
02:14 PM Feature #3277: implement call-graph v3
Greg Shah wrote:
> > If there is no local definition, the target will be either a super definition or an external pr... Constantin Asofiei
02:04 PM Feature #3277: implement call-graph v3
> A secondary issue: for defined procedures or functions, which are 'not local' (i.e. IN SUPER, IN handle or EXTERNAL... Greg Shah

05/15/2017

04:55 PM Feature #3277: implement call-graph v3
Greg Shah wrote:
> Constantin, please rework and extend the run_statements.rules, for each call-site:
> * establis... Constantin Asofiei
11:09 AM Feature #3277: implement call-graph v3
Constantin Asofiei wrote:
> - create @calls@ links to all internal procs/funcs with the same name
This is @referenc... Constantin Asofiei
11:08 AM Feature #3277: implement call-graph v3
Eric Faulhaber wrote:
> Constantin Asofiei wrote:
> > Greg, a quick question: the callgraph needs to be built on th... Constantin Asofiei
10:47 AM Feature #3277: implement call-graph v3
Constantin Asofiei wrote:
> Greg, a quick question: the callgraph needs to be built on the F2's ASTs, correct? And n... Eric Faulhaber
08:37 AM Feature #3277: implement call-graph v3
Greg, a quick question: the callgraph needs to be built on the F2's ASTs, correct? And not the full conversion's modi... Constantin Asofiei

05/12/2017

05:45 PM Feature #3277: implement call-graph v3
Just a heads up: the @Element.property(String)@ getter has changed, it returns a @Property@ instance - I'll add a @cg... Constantin Asofiei

05/11/2017

07:34 AM Feature #3277: implement call-graph v3
> Do we really need in Janus to map the key as String? Because if instead of bld.addKey(prop, Mapping.STRING.asParame... Greg Shah
06:33 AM Feature #3277: implement call-graph v3
Greg Shah wrote:
> > About the index issues: this code in JanusGraphDB.createIndexImpl needs to be changed, as compo... Constantin Asofiei
06:16 AM Feature #3277: implement call-graph v3
> About the index issues: this code in JanusGraphDB.createIndexImpl needs to be changed, as composite indexes don't a... Greg Shah
06:15 AM Feature #3277: implement call-graph v3
Constantin, please rework and extend the run_statements.rules, for each call-site:
* establish a "contains" edge f... Greg Shah
06:07 AM Feature #3277: implement call-graph v3
About the index issues: this code in @JanusGraphDB.createIndexImpl@ needs to be changed, as composite indexes don't a... Constantin Asofiei
 

Also available in: Atom