FWD » Core Development » Conversion Tools

07/03/2017

02:09 PM Feature #1514: implement fully dynamic reports (backed by the database)

Task branch 1514a has been rebased to trunk revision 11154. Current branch revision is 11310. Eric Faulhaber

12:43 PM Feature #1514: implement fully dynamic reports (backed by the database)

Eric Faulhaber wrote:
> I would like to rebase branch 1514a soon. Let me know if you have pending updates, or if thi... Constantin Asofiei

12:30 PM Feature #1514: implement fully dynamic reports (backed by the database)

I would like to rebase branch 1514a soon. Let me know if you have pending updates, or if this is a bad time for any r... Eric Faulhaber

06/29/2017

07:08 PM Feature #3277: implement call-graph v3

Constantin Asofiei wrote:
> Sergey, do you have other changes for the @File List@ section? Because currently is not ... Eric Faulhaber

06:56 PM Feature #3277: implement call-graph v3

Sergey, do you have other changes for the @File List@ section? Because currently is not functionally complete. Constantin Asofiei

06/20/2017

01:38 PM Feature #3277: implement call-graph v3

This is the list of features that were planned but are not yet implemented.
# -Ensure that the call graph processi... Greg Shah

06/19/2017

04:10 PM Feature #3277: implement call-graph v3

Greg Shah wrote:
> Does the following correctly explain the status of our call graph v3 report replacements?
>
> ... Constantin Asofiei

04:03 PM Feature #3277: implement call-graph v3

Does the following correctly explain the status of our call graph v3 report replacements?
View Program Dependencie... Greg Shah

06/16/2017

01:15 PM Feature #3277: implement call-graph v3

Constantin: Can you see if you can resolve the @.pphints@ issue recently seen in the customer application? We will b... Greg Shah

06/15/2017

02:24 PM Feature #1521: implement gap analysis rules or backing database/marker approach

On March 24, 2017 we merged branch 1521b into the trunk as revision 11144. Branch 1521b has been archived. Greg Shah

06/09/2017

07:27 PM Feature #3277: implement call-graph v3

Greg Shah wrote:
> I've been thinking about the "hidden more" problem:
>
> * I know that you have greatly reduced... Constantin Asofiei

12:05 PM Feature #1514: implement fully dynamic reports (backed by the database)

Sergey Ivanovskiy wrote:
> Please review these small changes on the server side, revision 11289. It is required to g... Eric Faulhaber

06/08/2017

05:09 PM Feature #1514: implement fully dynamic reports (backed by the database)

Please review these small changes on the server side, revision 11289. It is required to get files specifications from... Sergey Ivanovskiy

03:20 PM Feature #3277: implement call-graph v3

I've been thinking about the "hidden more" problem:
* I know that you have greatly reduced the number of links fro... Greg Shah

06/07/2017

08:51 AM Feature #3277: implement call-graph v3

Greg, in the end the problem was something stupid, I was computing wrong index of the matrix element, in the snapPoin... Constantin Asofiei

05:15 AM Feature #3277: implement call-graph v3

Greg Shah wrote:
> Overall, the changes seem to make things better. Any further improvements will be appreciated. ... Constantin Asofiei

12:39 AM Feature #3277: implement call-graph v3

Overall, the changes seem to make things better. Any further improvements will be appreciated. The start.p external... Greg Shah

11:14 PM Feature #3277: implement call-graph v3

Greg, in revision 11284 is the current approach, with start.p looking OK. My idea was to have a static grid (determi... Constantin Asofiei

11:08 PM Feature #3277: implement call-graph v3

> how is the matrix computed for the d.contained nodes, via the snapIndex? Because an element with snapIndex 10 shoul... Greg Shah

10:59 PM Feature #3277: implement call-graph v3

Greg Shah wrote:
> > For the container size: it mostly works, but there are cases where the jails are outside of the... Constantin Asofiei

10:55 PM Feature #3277: implement call-graph v3

> For the container size: it mostly works, but there are cases where the jails are outside of the prison, the contain... Greg Shah

06/06/2017

07:57 PM Feature #3277: implement call-graph v3

Greg Shah wrote:
> Can MESSAGE and PAUSE really generate the full set of possible user-generated events?
Hmm... act... Constantin Asofiei

04:56 PM Feature #3277: implement call-graph v3

Can MESSAGE and PAUSE really generate the full set of possible user-generated events? Greg Shah

03:08 PM Feature #3277: implement call-graph v3

Greg, just a quick status: my approach is to 'compact' the rows/columns on the minimum element height/width, from eac... Constantin Asofiei

10:28 AM Feature #3277: implement call-graph v3

> Do you have a hint where this is computed?
This is calculated in @calcElementJail()@ and enforced by the code in... Greg Shah

10:15 AM Feature #3277: implement call-graph v3

Revision 11281 adds a calculation of the actual minimum width and height of each container. This is the basis for rew... Greg Shah

12:37 PM Feature #1514: implement fully dynamic reports (backed by the database)

Eric Faulhaber wrote:
> If you have no objection, I will add an "err" parameter as the first of each JS callback fun... Constantin Asofiei

12:35 PM Feature #1514: implement fully dynamic reports (backed by the database)

Constantin, I've found a flaw in our JS<-->Java API, in that exceptions on the server side are never reported to the ... Eric Faulhaber

06/05/2017

04:22 PM Feature #3277: implement call-graph v3

Greg, 1514a rev 11279 adds SHIFT/CTRL-click on a MORE node which will either load the graph with the program as root ... Constantin Asofiei

03:34 PM Feature #3277: implement call-graph v3

Greg, 1514a rev 11277 has the custom graph loading from note #3277-173 . I'm moving to MORE node expansion next. Constantin Asofiei

02:11 PM Feature #3277: implement call-graph v3

Greg Shah wrote:
> Code Review Task Branch 1514a Revision 11276
> This is the reason that the links to and from rec... Constantin Asofiei

02:01 PM Feature #3277: implement call-graph v3

Code Review Task Branch 1514a Revision 11276
Everything is good except for the changes on line 2117 and 2132. In ... Greg Shah

11:26 AM Feature #3277: implement call-graph v3

Greg, I think I found the cause of the NaN's:
# in @rectIntersection@, if @outside.x == inside.x@, then the slope is... Constantin Asofiei

06:16 AM Feature #3277: implement call-graph v3

> I mean, even if both programs are expanded in the current snippet, then we don't create a link for each call betwee... Greg Shah

06:13 AM Feature #3277: implement call-graph v3

Another thing to consider is that instead of loading entire root list, a user might want to load just a single progra... Greg Shah

06:05 AM Feature #3277: implement call-graph v3

Greg Shah wrote:
> > for dependencies between external-program, by default use a dependency link between them
>
>... Constantin Asofiei

05:54 AM Feature #3277: implement call-graph v3

> for dependencies between external-program, by default use a dependency link between them
What do you mean by "de... Greg Shah

05:48 AM Feature #3277: implement call-graph v3

> I'm including the names of all targets for a call site, for function, procedure or event calls, so you can see them... Greg Shah

05:48 AM Feature #3277: implement call-graph v3

Greg Shah wrote:
> How many procedure_file nodes are there in the level == 1 case? Is it correct that there 4000 no... Constantin Asofiei

05:19 AM Feature #3277: implement call-graph v3

> About the MORE nodes: I'm not sure how to solve this; maybe I can enable it only for level > 0?
I'm not sure. I... Greg Shah

09:23 PM Feature #3277: implement call-graph v3

Greg, see 1514a revision 11273 for improvements related to the description/tooltip of the call sites - I'm including ... Constantin Asofiei

04:00 PM Feature #1514: implement fully dynamic reports (backed by the database)

Eric Faulhaber wrote:
> Eric Faulhaber wrote:
> > Sergey, could you please help me debug a radio button issue?
> >... Constantin Asofiei

03:58 PM Feature #1514: implement fully dynamic reports (backed by the database)

Eric Faulhaber wrote:
> Sergey, could you please help me debug a radio button issue?
>
> I just checked in rev. 1... Eric Faulhaber

03:54 PM Feature #1514: implement fully dynamic reports (backed by the database)

Sergey, could you please help me debug a radio button issue?
I just checked in rev. 11278. On the "Customize" page... Eric Faulhaber

03:28 PM Feature #1514: implement fully dynamic reports (backed by the database)

Sergey Ivanovskiy wrote:
> May be this code can help
> [...]
Yes, it helped, thanks! Constantin Asofiei

03:28 PM Feature #1514: implement fully dynamic reports (backed by the database)

May be this code can help... Sergey Ivanovskiy

03:08 PM Feature #1514: implement fully dynamic reports (backed by the database)

I used this code for destroy combobox... Sergey Ivanovskiy

02:45 PM Feature #1514: implement fully dynamic reports (backed by the database)

Greg Shah wrote:
> Constantin Asofiei wrote:
> > Sergey, the combobox code for note 43 is not working in chrome.
>... Constantin Asofiei

06/04/2017

05:32 PM Feature #3277: implement call-graph v3

Greg Shah wrote:
See 1514a revision 11271 for event improvements.
> After the event improvements are in, please l... Constantin Asofiei

04:23 PM Feature #3277: implement call-graph v3

Revision 11270 makes improvements in node text and some tweaks for reducing the space allocated for containers.
Af... Greg Shah

03:59 PM Feature #3277: implement call-graph v3

Greg Shah wrote:
> > can you make them contained?
> I can look at it. It has other ramifications but I should be c... Constantin Asofiei

03:58 PM Feature #3277: implement call-graph v3

> can you make them contained?
I can look at it. It has other ramifications but I should be close.
> Note that... Greg Shah

03:32 PM Feature #3277: implement call-graph v3

Greg, the approach with the events is this:
# EVENT nodes are created in each context (internal proc, function, exte... Constantin Asofiei

03:10 PM Feature #3277: implement call-graph v3

11269 has improved displayProps. Greg Shah

01:33 PM Feature #3277: implement call-graph v3

Revision 11268 has text labels added to the middle of every link. This should make it much easier to understand the ... Greg Shah

12:46 PM Feature #3277: implement call-graph v3

> The links reported by createNodeMap are calls links, not contains... so I'm not sure where the problem is.
You'r... Greg Shah

12:42 PM Feature #3277: implement call-graph v3

Greg Shah wrote:
> > MORE nodes should never be contained or containers. How do you determine that they should be co... Constantin Asofiei

12:40 PM Feature #3277: implement call-graph v3

The first one matched in the current scope is used. So it seems like we could walk up the call graph and look for sc... Greg Shah

12:35 PM Feature #3277: implement call-graph v3

Greg Shah wrote:
> I think EVENT nodes should be contained in the scope (4GL code block) that registers them. Event... Constantin Asofiei

10:29 AM Feature #3277: implement call-graph v3

I think EVENT nodes should be contained in the scope (4GL code block) that registers them. Events are not really glo... Greg Shah

10:20 AM Feature #3277: implement call-graph v3

> MORE nodes: the traverseLevel must create MORE nodes only if level 0 is reached and only to PROCEDURE_FILE or SCHEM... Greg Shah

09:40 AM Feature #3277: implement call-graph v3

> MORE nodes should never be contained or containers. How do you determine that they should be contained or container... Greg Shah

08:25 AM Feature #3277: implement call-graph v3

Greg Shah wrote:
> Some other questions:
>
> 1. I don't see any "calls" link from an event to a trigger. This is... Constantin Asofiei

08:11 AM Feature #3277: implement call-graph v3

Greg Shah wrote:
> With rev 11265, I add the circle back in as a shape (for More and Event nodes) and there is some ... Constantin Asofiei

07:46 AM Feature #3277: implement call-graph v3

Some other questions:
1. I don't see any "calls" link from an event to a trigger. This is a pretty crucial elemen... Greg Shah

07:43 AM Feature #3277: implement call-graph v3

Greg Shah wrote:
> Is the addition of the node-key enough for this or do we need to augment the data (both stored in... Constantin Asofiei

07:34 AM Feature #3277: implement call-graph v3

I'm working on improving the appearance of nodes and links. I'm adding colors and so forth for all types than can be... Greg Shah

12:26 AM Feature #3277: implement call-graph v3

Constantin: your changes in 11264 do make a huge improvement.
With rev 11265, I add the circle back in as a shape ... Greg Shah

10:49 AM Feature #1514: implement fully dynamic reports (backed by the database)

Sergey: Please work on the file list editing next. It would be useful for us to be able to actually create some real... Greg Shah