FWD » Core Development » Conversion Tools

07/25/2019

03:08 PM Bug #4151: make databaseMode usage safer in rpt_file_list

The task branch 4151a has been committed into the trunk as bzr revision 11327. Vladimir Tsichevski

02:03 PM Bug #4151: make databaseMode usage safer in rpt_file_list

Please merge 4151a to trunk.
You will need to make some edits to the documentation as well, but make sure that it ... Greg Shah

02:01 PM Bug #4151: make databaseMode usage safer in rpt_file_list

> AFAIR, with the introduction of the code analytics feature set, this rule set is no longer used.
This ruleset a... Greg Shah

01:59 PM Bug #4151: make databaseMode usage safer in rpt_file_list

Code Review Task Branch 4151a Revision 11327
I'm good with the changes. Greg Shah

05:24 AM Bug #4154 (Closed): NPE in ENABLE ALL

Vladimir Tsichevski

07/24/2019

03:20 PM Bug #4151: make databaseMode usage safer in rpt_file_list

Greg Shah wrote:
> Eric: You put in the @databaseMode@. What do you think?
I'm pretty sure I've never touched ... Eric Faulhaber

07/23/2019

04:23 PM Bug #4151 (Review): make databaseMode usage safer in rpt_file_list

Vladimir Tsichevski

04:21 PM Bug #4151: make databaseMode usage safer in rpt_file_list

The changes are as follows:
# only the root AST node is now tested for the condition;
# the databaseMode comamnd-... Vladimir Tsichevski

07/22/2019

04:54 PM Bug #4151: make databaseMode usage safer in rpt_file_list

> It also may make sense to check for srcfile on the root node. If it exists there, use it else use file.
Agreed. ... Vladimir Tsichevski

02:03 PM Bug #4151: make databaseMode usage safer in rpt_file_list

It also may make sense to check for @srcfile@ on the @root@ node. If it exists there, use it else use @file@. Greg Shah

02:02 PM Bug #4151: make databaseMode usage safer in rpt_file_list

That sounds reasonable.
Eric: You put in the @databaseMode@. What do you think? Greg Shah

01:39 PM Bug #4151: make databaseMode usage safer in rpt_file_list

The right thing will be to change the script logic as follows:
# if the "srcfile" annotation is defined for a node... Vladimir Tsichevski

11:26 AM Bug #4151 (WIP): make databaseMode usage safer in rpt_file_list

Vladimir Tsichevski

10:58 AM Bug #4151: make databaseMode usage safer in rpt_file_list

There are 2 sources of "database" ASTs:
* @.df@ files which are the schemata for databases
* static temp-table de... Greg Shah

10:41 AM Bug #4151: make databaseMode usage safer in rpt_file_list

If the @databaseMode="true"@ is used when running the @reports/rpt_file_list@ report, and not a @*.schema@ AST source... Vladimir Tsichevski

09:59 AM Bug #4151 (Closed): make databaseMode usage safer in rpt_file_list

Vladimir Tsichevski