FWD » Core Development » Conversion Tools

09/29/2021

12:49 PM Feature #4105: improve flexibility of schema loading

> It is documented as the default option. If -P is present or none of other file specification parameters the PLAIN m... Greg Shah

12:18 PM Feature #4105: improve flexibility of schema loading

Greg Shah wrote:
> Code Review Task Branch 3821c Revision 12996
> 1. As far as I know, there is no support for a @P... Ovidiu Maxiniuc

10:29 AM Feature #4105: improve flexibility of schema loading

If I understand correctly, only the 2nd bullet remains. Correct? Greg Shah

10:29 AM Feature #4105: improve flexibility of schema loading

Code Review Task Branch 3821c Revision 12996
This is very nice! Some minor feedback:
1. As far as I know, ther... Greg Shah

09/24/2021

06:23 PM Feature #4105: improve flexibility of schema loading

The support for database profiles in configuration file was committed to 12996 of 3821c.
The active profile can be s... Ovidiu Maxiniuc

09/21/2021

05:56 AM Feature #4105: improve flexibility of schema loading

Overall, I like the approach very much.
> I chosen System property solution because it can be queried directly in ... Greg Shah

09/20/2021

06:59 PM Feature #4105: improve flexibility of schema loading

Since we need to run the conversion multiple times but keep the same @p2j.cfg.xml@ it means the only way to inform th... Ovidiu Maxiniuc

09/18/2021

10:16 AM Feature #4105: improve flexibility of schema loading

We should not have to "swap out" the @p2j.cfg.xml@ for different conversion runs. Greg Shah

10:16 AM Feature #4105: improve flexibility of schema loading

To clarify item 3:
* We have a customer which has 2 builds/compiles of their application:
** A version that runs ... Greg Shah

09/17/2021

06:29 PM Feature #4105: improve flexibility of schema loading

The previous commit was pushing the metadata processing (@standard.dict@) to @ReportDriver@.
Starting with revision ... Ovidiu Maxiniuc

09/16/2021

10:33 AM Bug #5664 (Closed): treeview parent node conversion issue

Greg Shah

10:06 AM Bug #5664: treeview parent node conversion issue

Vladimir Tsichevski wrote:
> The result is committed as rev. 12932. Please review.
I'm OK with the change.
Constantin Asofiei

08:57 AM Bug #5664: treeview parent node conversion issue

Constantin Asofiei wrote:
> Review for 3821c/12930:
> * the test for function parameters needs to be like @upPath("... Vladimir Tsichevski

03:51 AM Bug #5664: treeview parent node conversion issue

Review for 3821c/12930:
* the test for function parameters needs to be like @upPath("KW_FUNCT/LPARENS/PARAMETER/SYMB... Constantin Asofiei

09/15/2021

03:19 PM Bug #5664 (Review): treeview parent node conversion issue

Vladimir Tsichevski

03:19 PM Bug #5664 (WIP): treeview parent node conversion issue

Constantin Asofiei wrote:
> Vladimir, see @annotations/ocx_conversions.rules@, line 536 I think. That part is missi... Vladimir Tsichevski

07:22 AM Bug #5664: treeview parent node conversion issue

Vladimir, see @annotations/ocx_conversions.rules@, line 536 I think. That part is missing function parameters.
<pre... Constantin Asofiei

07:15 AM Bug #5664: treeview parent node conversion issue

This issue probably needs to be renamed since it neither relates to @TREEVIEW@, nor to @PARENT@ call. Vladimir Tsichevski

09/14/2021

05:12 PM Feature #4105: improve flexibility of schema loading

Moved @FLAG_DICT@ declaration from @AstManager@ to @AstGenerator@. Augmented @flags@ to 64 bits (8 reserved).
Comm... Ovidiu Maxiniuc

10:29 AM Feature #4105: improve flexibility of schema loading

I think the correct location is in @AstGenerator@ (the same place we have the @DICT_POSTFIX@ constant. Greg Shah

10:28 AM Feature #4105: improve flexibility of schema loading

I think that is OK, because the flags only need to be consistent within a given project. In other words, as long as ... Greg Shah

10:06 AM Feature #4105: improve flexibility of schema loading

Greg Shah wrote:
> My only feedback is that the @FLAG_DICT@ should not be defined in @AstManager@. The @AstManager@... Ovidiu Maxiniuc

09:30 AM Feature #4105: improve flexibility of schema loading

Code Review Task Branch 3821c Revision 12923
The changes are very nice. I like the idea of being able to mark AST... Greg Shah

04:48 PM Bug #5664: treeview parent node conversion issue

Greg Shah wrote:
> The problem with the first function is that there is already a 4GL @PARENT@ attribute that can be... Vladimir Tsichevski

04:19 PM Bug #5664: treeview parent node conversion issue

The problem with the first function is that there is already a 4GL @PARENT@ attribute that can be accessed on a @HAND... Greg Shah

04:15 PM Bug #5664: treeview parent node conversion issue

Moved from #5034-1198 (by Vladimir):
Gentlemen,
I'm stuck converting code related to @TREEVIEW/TREELIST@.
Th... Greg Shah

04:15 PM Bug #5664 (Closed): treeview parent node conversion issue

Greg Shah