Project

General

Profile

Activity

From 07/27/2025 to 08/25/2025

08/25/2025

09:25 AM Feature #6083: schema (.df) changes in incremental conversion mode should only reconvert those pr...
Greg Shah wrote:
> We could calculate the checksum for the original input text for that table. That would be more c...
Dănuț Filimon
09:19 AM Feature #6083: schema (.df) changes in incremental conversion mode should only reconvert those pr...
We could calculate the checksum for the original input text for that table. That would be more consistent with our f... Greg Shah
05:13 AM Feature #6083: schema (.df) changes in incremental conversion mode should only reconvert those pr...
Committed *6083a/16125*. Keep track of modified tables in incremental conversion.
I've noticed that during convers...
Dănuț Filimon
06:56 AM Bug #10469: incremental conversion when basepath is more than one folder (aka abl/foo) with #5586
I already tried to add abl/hotel to the propath:... Dănuț Filimon
06:48 AM Bug #10469: incremental conversion when basepath is more than one folder (aka abl/foo) with #5586
You need to add @:${P2J_HOME}/abl/hotel/@ to @propath@ in @p2j.cfg.xml@. If we look in @Configuration.getPathToConve... Constantin Asofiei
06:27 AM Bug #10469: incremental conversion when basepath is more than one folder (aka abl/foo) with #5586
Constantin, is there any configuration missing? I get this error with the mentioned configuration:... Dănuț Filimon
06:06 AM Bug #10469 (WIP): incremental conversion when basepath is more than one folder (aka abl/foo) with...
I'll look into the issue right away. Dănuț Filimon
06:05 AM Bug #10469: incremental conversion when basepath is more than one folder (aka abl/foo) with #5586
There is a bug when @basepath="./abl/hotel/"@ and @cvtpath="./cvt"@. Incremental conversion will fail because @Confi... Constantin Asofiei
06:04 AM Bug #10469 (Test): incremental conversion when basepath is more than one folder (aka abl/foo) wit...
Constantin Asofiei
06:05 AM Feature #6256 (Test): improved profile support
OK, moved to 10469. Constantin Asofiei
06:00 AM Feature #6256: improved profile support
Constantin, this is related to 5586a changes. Can you create a separate task? Dănuț Filimon
05:57 AM Feature #6256 (WIP): improved profile support
There is a bug when @basepath="./abl/hotel/"@ and @cvtpath="./cvt"@. Incremental conversion will fail because @Confi... Constantin Asofiei

08/22/2025

10:32 AM Feature #6319: IntelliJ plugin
!ss3.png! Florin Eugen Rotaru
10:30 AM Feature #6319: IntelliJ plugin
The IntelliJ platform is Swing-based and we can think of the UI components as wrappers over Swing @JComponents@. For ... Florin Eugen Rotaru

08/21/2025

10:31 AM Feature #10459: migrate all project configuration into a single jSON configuration file
> The "new" hotel method generates a JSON based upon the responses to the prompts.
We will want to invert that. ...
Greg Shah
10:05 AM Feature #10459: migrate all project configuration into a single jSON configuration file
The "new" hotel method generates a JSON based upon the responses to the prompts. This JSON is also made available in ... Roger Borrello
09:14 AM Feature #10459: migrate all project configuration into a single jSON configuration file
There are also schema hint files.
We should also have a tool to gather all these input files and generate the .jso...
Constantin Asofiei
09:12 AM Feature #10459: migrate all project configuration into a single jSON configuration file
The current approach to conversion project configuration is a frankenstein monster which we have pieced together over... Greg Shah
08:46 AM Feature #10459 (New): migrate all project configuration into a single jSON configuration file
Greg Shah
09:22 AM Feature #6083: schema (.df) changes in incremental conversion mode should only reconvert those pr...
Rebased *6083a* to latest *trunk/16124*. Dănuț Filimon
09:08 AM Bug #10208 (Test): do not convert the schema in incremental mode if it hasn't changed
Branch 10208a was merged into trunk as rev. 16124 and archived. Dănuț Filimon
08:50 AM Bug #10208 (Merge Pending): do not convert the schema in incremental mode if it hasn't changed
You can merge to trunk now. Constantin Asofiei
07:22 AM Bug #10208: do not convert the schema in incremental mode if it hasn't changed
I'm OK with a merge but please coordinate with Constantin to ensure that we don't negatively affect customer deliveri... Greg Shah
05:37 AM Bug #10208: do not convert the schema in incremental mode if it hasn't changed
Testing went well, Radu also got the error from #10208-37 and it was related to trunk/16111 (since he converted with ... Dănuț Filimon
08:29 AM Feature #10458 (Rejected): stable and deterministic name generation during app-by-app conversion
This work is already represented in #9639. Greg Shah
08:23 AM Feature #10458: stable and deterministic name generation during app-by-app conversion
We need to ensure that the names we generate (classes, methods, data members...) are stable and deterministic. This ... Greg Shah
08:00 AM Feature #10458 (Rejected): stable and deterministic name generation during app-by-app conversion
Greg Shah
08:28 AM Feature #9639: centralized name management (and conversion) OR jar based resolution
We need to ensure that the names we generate (classes, methods, data members...) are stable and deterministic. This ... Greg Shah
07:57 AM Bug #8967 (Closed): Remove relationship annotation from full conversion
Greg Shah
03:32 AM Bug #9917 (Internal Test): Fileset not ignoring case
I retested conversion without revision 15971 for the problematic application and there were no issues.
Committed *...
Dănuț Filimon

08/19/2025

10:10 AM Feature #6319: IntelliJ plugin
I managed to implement the idea above and created a real-time side-by-side preview of the preporcessed 4GL code (usin... Florin Eugen Rotaru
07:08 AM Bug #10208: do not convert the schema in incremental mode if it hasn't changed
Committed *10208a/16118*. SchemaLoader should have schemasChanged passed in runSchemaLoader().
Mutable databases w...
Dănuț Filimon
05:43 AM Bug #10208: do not convert the schema in incremental mode if it hasn't changed
I tested incremental conversion for two customers and even if the schema was not changed, it was still running the Sc... Dănuț Filimon

08/18/2025

09:03 AM Feature #6083: schema (.df) changes in incremental conversion mode should only reconvert those pr...
Dănuț Filimon wrote:
> Issues:
> * I am calculating the table hash and overriding before I can compare it
I have...
Dănuț Filimon
07:15 AM Feature #6083: schema (.df) changes in incremental conversion mode should only reconvert those pr...
At the moment, I've managed to implement the following:
# When we have changed schemas, I iterate over the ones that...
Dănuț Filimon
08:18 AM Feature #6256 (Test): improved profile support
Branch 6256a was merged to trunk as rev. 16116 and archived. Dănuț Filimon
08:03 AM Feature #6256 (Merge Pending): improved profile support
6256a can be merged now. Constantin Asofiei

08/14/2025

10:24 AM Feature #6319: IntelliJ plugin
So far I have investigated the following areas of the IntelliJ Plugin Devkit.
1. @Extension Points@ - these can be...
Florin Eugen Rotaru
07:07 AM Bug #10208 (Internal Test): do not convert the schema in incremental mode if it hasn't changed
Code Review Task Branch 10208a Revision 16117
I like it.
Greg Shah
04:42 AM Bug #10208 (Review): do not convert the schema in incremental mode if it hasn't changed
Committed *10208a/16117*. Fixed full conversion problem where schemasChanged was null and the standard.df was skipped... Dănuț Filimon
04:09 AM Bug #10208 (WIP): do not convert the schema in incremental mode if it hasn't changed
Currently working on a fix. Dănuț Filimon
04:08 AM Bug #10208: do not convert the schema in incremental mode if it hasn't changed
There's a scenario in ETF where the schemasChanged is null, but also should contain all the schemas because we are no... Dănuț Filimon
06:57 AM Feature #7180 (Review): create a centralized manager for the conversion list and per-file/project...
Rebased *7180a* to latest *trunk/16115*, the branch is now at revision *16137*.
Committed revisions *16138* and *1...
Dănuț Filimon
06:34 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
Committed *7180a/16132*: Moved getPathToConversionFolder() and getPathToSourceFileFromConversionFolder() to ArtifactM... Dănuț Filimon

08/13/2025

12:09 PM Bug #10208: do not convert the schema in incremental mode if it hasn't changed
Found an issue with ETF conversion, I will be investigating. Dănuț Filimon
04:01 AM Bug #10208: do not convert the schema in incremental mode if it hasn't changed
Rebased *10208a* to latest *trunk/16110*, the branch is now at revision *16116*. Dănuț Filimon
04:46 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
Rebased *7180a* to latest *trunk/16110*, the branch is now at revision *16131*. Dănuț Filimon

08/12/2025

06:53 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
Looked at the ArtifaceManager and Configuration classes, the following are required by the ArtifactManager:
* @getPa...
Dănuț Filimon

08/11/2025

08:44 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
Committed *7180a/16111*. Compatibility changes after rebasing and picking up 5586a.
I will also look into #7180-1...
Dănuț Filimon

08/08/2025

11:00 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
Greg Shah wrote:
> Please consider if code like @Configuration.getPathToSourceFileFromConversionFolder()@ should be ...
Dănuț Filimon
10:55 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
Please consider if code like @Configuration.getPathToSourceFileFromConversionFolder()@ should be in the @AM@ instead ... Greg Shah
06:04 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
There are also cases where I create an artifact by doing @artifact.getRelativePATH() + the extension@, those should a... Dănuț Filimon
03:15 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
Most of the problems with 7180a after the trunk rebase is that transforming artifacts and retrieving the original art... Dănuț Filimon

08/07/2025

07:58 AM Bug #10208 (Internal Test): do not convert the schema in incremental mode if it hasn't changed
Code Review Task Branch 10208a Revision 16080
The change is good.
Greg Shah
07:51 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
Rebased *7180a* to latest *trunk/16090*, the branch is now at revision *7180a/16110*. I will follow up with another c... Dănuț Filimon

08/06/2025

09:21 AM Feature #5586 (Test): move all conversion artifacts/outputs into the cvtdb or into a dedicated di...
Branch 5586a was merged to trunk as rev. 16089 and archived. Dănuț Filimon
08:45 AM Feature #5586 (Merge Pending): move all conversion artifacts/outputs into the cvtdb or into a ded...
Please merge 5586a to trunk now. Alexandru Lungu
04:59 AM Feature #6083: schema (.df) changes in incremental conversion mode should only reconvert those pr...
*Note: Everything I mention will consider the implementation from 10208a to be part of this task.*
Even if there ...
Dănuț Filimon
03:00 AM Feature #6083 (WIP): schema (.df) changes in incremental conversion mode should only reconvert th...
Created *6083a* from latest *trunk/16087*. Dănuț Filimon
03:49 AM Bug #10208 (Review): do not convert the schema in incremental mode if it hasn't changed
The solution is simple, only save the file hash if we use a df file:... Dănuț Filimon
03:17 AM Bug #10208 (WIP): do not convert the schema in incremental mode if it hasn't changed
I started working on the regression test plan and found this issue while testing a customer application:... Dănuț Filimon

08/05/2025

08:17 AM Bug #10208: do not convert the schema in incremental mode if it hasn't changed
Committed *10208a/16079*, added a detailed javadoc to @schemasChanged@ set class members in @TransformDriver@ and @Sc... Dănuț Filimon
08:04 AM Bug #10208: do not convert the schema in incremental mode if it hasn't changed
OK, then add a comment to explain that in full conversion mode, all schemata will be detected as "changed" and will b... Greg Shah
07:45 AM Bug #10208 (Internal Test): do not convert the schema in incremental mode if it hasn't changed
Greg Shah wrote:
> Code Review Tk Branch 10208a Revision 16078
>
> Overall, I agree with the changes for when we ...
Dănuț Filimon
07:38 AM Bug #10208: do not convert the schema in incremental mode if it hasn't changed
Code Review Tk Branch 10208a Revision 16078
Overall, I agree with the changes for when we are running incremental ...
Greg Shah

08/04/2025

06:41 AM Bug #10208 (Review): do not convert the schema in incremental mode if it hasn't changed
Greg Shah wrote:
> Code Review Task Branch 10208a Revisons 16075 through 16077
>
> Overall the changes are a good...
Dănuț Filimon

07/31/2025

01:33 PM Bug #10208 (WIP): do not convert the schema in incremental mode if it hasn't changed
Code Review Task Branch 10208a Revisons 16075 through 16077
Overall the changes are a good first pass. In most ca...
Greg Shah

07/30/2025

07:01 AM Bug #10208 (Review): do not convert the schema in incremental mode if it hasn't changed
Committed *10208a/16077*. Removed IncrementalCvtRunMode, omitting the schema related phases can be achieved using the... Dănuț Filimon

07/29/2025

06:17 AM Bug #10208: do not convert the schema in incremental mode if it hasn't changed
Rebased *10208a* to latest *trunk/16074*, the branch is now at revision *16076*. Dănuț Filimon

07/28/2025

07:40 AM Bug #9863 (Test): Fileset eXclude broken on native Windows
Branch 9863a was merged to trunk revision 16071 and archived. Dănuț Filimon
07:10 AM Bug #9863 (Merge Pending): Fileset eXclude broken on native Windows
Alexandru Lungu
02:07 AM Bug #9863: Fileset eXclude broken on native Windows
Regression testing completed, no issues found.
*9863a* can be merged to trunk.
Dănuț Filimon
06:48 AM Bug #9917: Fileset not ignoring case
I will revert the Set changes and see if the problem persists. If this is the cause, I will create a separate issue t... Dănuț Filimon
06:46 AM Bug #9917: Fileset not ignoring case
I had to setup the customer application locally and run the conversion to check what files end up causing the problem... Dănuț Filimon
 

Also available in: Atom